Skip to content

[backport cloud/1.59] feat: check a local workflow against Comfy Cloud and offer to open it there - #23146

Merged
comfy-pr-bot merged 2 commits into
cloud/1.59from
backport-23071-to-cloud-1.59
Nov 9, 2026
Merged

comfy-pr-bot merged 2 commits into
cloud/1.59from
backport-23071-to-cloud-1.59

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #23071 to cloud/1.59

Automatically created by backport workflow.

… there (#23071)

<p align="center"><img
src="https://github.com/user-attachments/assets/5eaf9e78-12fd-4c3c-803e-18c18ea21972"
alt="J1 sequence" width="720"></p>

## Summary

**J1, Cloud-compatible workflow.** On a local origin with the flag on,
the Cloud button replaces Deploy in the top menu. Hovering or clicking
it checks the workflow against the Cloud compatibility API; for a
runnable workflow it opens a Comfy Cloud tab and offers the workflow by
`postMessage`. The Cloud-side receiver lands in #23074, so with the flag
on this PR alone, the Cloud tab opens but doesn't import yet. With the
flag off nothing renders and nothing is requested.

Also adds the live-Cloud fixture and network allowance the later live
specs reuse, which is about half of this diff.

Scope notes:
- Browser path only. Desktop hides the button until its relay arrives in
J5 (#23075).
- The dialog renders only the ready state. A workflow Cloud can't run
shows a toast until the missing-node and missing-model cards arrive in
J2 and J3 (#23072).
- `openCardDialog` is exported here because the J1 dialog needs it.
- The check reads node types and widget values straight from the graph,
so hovering never runs `serializeValue` hooks. A model on a loader the
asset picker doesn't map (such as `DualCLIPLoader`) gets its folder from
the local model library; if it can't be placed (not installed, in two
folders, or on a loader that isn't installed locally), the check returns
no verdict instead of claiming Cloud can run it.
- The gate spec drives the flag through the server feature-flag
handshake, because CI serves a production build where the `ff:`
localStorage override is tree-shaken.

## Verification

<details open><summary><b>J1 · Cloud-compatible workflow</b></summary>

**1.** Load model-free EmptyImage → SaveImage.<br>
<img
src="https://github.com/user-attachments/assets/ec66f384-a7c7-46e1-a4f1-01e29082504d"
alt="J1 · Cloud-compatible workflow, step 1" width="640">

**2.** Real HTTP 200: no missing nodes or models.<br>
<img
src="https://github.com/user-attachments/assets/b266e5bd-13ba-4736-b5a4-74bf7ab970b1"
alt="J1 · Cloud-compatible workflow, step 2" width="640">

**3.** Cloud action and sign-in guidance shown.<br>
<img
src="https://github.com/user-attachments/assets/bf7ad393-ac78-4d68-886b-2e862a9107a6"
alt="J1 · Cloud-compatible workflow, step 3" width="640">

</details>

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: huang47 <157390+huang47@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Nov 9, 2026
@comfy-pr-bot
comfy-pr-bot requested review from a team and dante01yoon as code owners November 9, 2026 09:03
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Nov 9, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) November 9, 2026 09:03
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle: ⏳ Size data collection in progress…

⚡ Performance: ⚠️ Performance tests failed — check the CI workflow logs

🔬 E2E Coverage: ⚠️ Coverage collection failed — check the CI workflow logs

🎭 Playwright: ✅ 3150 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2329 / ❌ 0 / ⚠️ 2 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 790 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • desktop: View Report (✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 11/09/2026, 09:58:08 AM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 9f8d7f2d3aff2f5da820da6e3d46d2cb467f8a92

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (307)

  • workspace path matches no source files: src/platform/workspace/fixtures/**. Remove or update it in docs/architecture/domains/records/workspace.domain.json.
  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/Popover.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupEnforcementBoundary.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/syncPromotedComboHostOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/legacyUI/attachLegacyUI.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/agentPanel.historyIdentity.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cloudBadges.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/dynamicPrompts.serializeValue.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/electronAdapter.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/index.cloud.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/index.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/findNumericWidget.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dLazy.retry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dSettings.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dWidgets.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dWidgets.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/slotDefaults.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchPointerGuards.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/ContextMenu.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/LGraphCanvas.startRendering.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 257 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

@datadog-official

This comment has been minimized.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Nov 9, 2026
cloud/1.59 predates the package extractions this PR's imports assume, so
point them at the in-tree modules that still exist on this branch:

- @comfyorg/telemetry/reportError -> @/platform/telemetry/reportError
- @comfyorg/graph-model/workflowSchema -> @/platform/workflow/validation/schemas/workflowSchema
- @comfyorg/design-system/{button/Button,dialog/DialogTitle} -> @/components/ui/...

Add the generated Cloud compatibility types (CompatibilityModel,
CloudCompatibility*, CheckCloudCompatibility*) and their Zod schemas to
ingest-types, copied verbatim from main's sync (#22718), and export
handsPopupsToSystemBrowser from billingTab as main did at the time of #23071.
@codecov

codecov Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.61756% with 19 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/platform/openOnCloud/openWorkflowOnCloud.ts 82.69% 9 Missing ⚠️
...platform/openOnCloud/components/RunOnCloudCard.vue 76.47% 4 Missing ⚠️
...rc/platform/openOnCloud/components/CloudButton.vue 95.83% 2 Missing ⚠️
src/platform/openOnCloud/openRunOnCloudDialog.ts 77.77% 2 Missing ⚠️
src/platform/openOnCloud/cloudCompatibilityApi.ts 99.22% 1 Missing ⚠️
...form/openOnCloud/stores/cloudWorkflowCheckStore.ts 95.23% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.59   #23146   +/-   ##
=============================================
  Coverage              ?   86.89%           
=============================================
  Files                 ?     2828           
  Lines                 ?   144265           
  Branches              ?    44414           
=============================================
  Hits                  ?   125357           
  Misses                ?    17924           
  Partials              ?      984           
Flag Coverage Δ
billing-web-unit 92.14% <ø> (?)
unit 86.76% <94.61%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/TopMenuSection.vue 91.41% <100.00%> (ø)
src/platform/billing/billingTab.ts 94.44% <100.00%> (ø)
src/platform/openOnCloud/cloudWorkflowCheck.ts 100.00% <100.00%> (ø)
...c/platform/openOnCloud/components/ProgressRing.vue 100.00% <100.00%> (ø)
...atform/openOnCloud/components/RunOnCloudDialog.vue 100.00% <100.00%> (ø)
src/platform/openOnCloud/localHandoffProtocol.ts 100.00% <100.00%> (ø)
src/platform/openOnCloud/runOnCloudModalState.ts 100.00% <100.00%> (ø)
src/platform/openOnCloud/serializeRootGraph.ts 100.00% <100.00%> (ø)
...c/platform/workspace/openCustomDeploymentDialog.ts 91.42% <100.00%> (ø)
src/platform/openOnCloud/cloudCompatibilityApi.ts 99.22% <99.22%> (ø)
... and 5 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added risk:xhigh PR risk grade (advisory shadow check; grader-owned) and removed risk:high PR risk grade (advisory shadow check; grader-owned) labels Nov 9, 2026

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved under the requested backport-only policy. No code-change findings; no tests were run.

@comfy-pr-bot
comfy-pr-bot merged commit b986a7e into cloud/1.59 Nov 9, 2026
110 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-23071-to-cloud-1.59 branch November 9, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants