Repository navigation
[backport cloud/1.59] feat: check a local workflow against Comfy Cloud and offer to open it there - #23146
Conversation
… there (#23071) <p align="center"><img src="https://github.com/user-attachments/assets/5eaf9e78-12fd-4c3c-803e-18c18ea21972" alt="J1 sequence" width="720"></p> ## Summary **J1, Cloud-compatible workflow.** On a local origin with the flag on, the Cloud button replaces Deploy in the top menu. Hovering or clicking it checks the workflow against the Cloud compatibility API; for a runnable workflow it opens a Comfy Cloud tab and offers the workflow by `postMessage`. The Cloud-side receiver lands in #23074, so with the flag on this PR alone, the Cloud tab opens but doesn't import yet. With the flag off nothing renders and nothing is requested. Also adds the live-Cloud fixture and network allowance the later live specs reuse, which is about half of this diff. Scope notes: - Browser path only. Desktop hides the button until its relay arrives in J5 (#23075). - The dialog renders only the ready state. A workflow Cloud can't run shows a toast until the missing-node and missing-model cards arrive in J2 and J3 (#23072). - `openCardDialog` is exported here because the J1 dialog needs it. - The check reads node types and widget values straight from the graph, so hovering never runs `serializeValue` hooks. A model on a loader the asset picker doesn't map (such as `DualCLIPLoader`) gets its folder from the local model library; if it can't be placed (not installed, in two folders, or on a loader that isn't installed locally), the check returns no verdict instead of claiming Cloud can run it. - The gate spec drives the flag through the server feature-flag handshake, because CI serves a production build where the `ff:` localStorage override is tree-shaken. ## Verification <details open><summary><b>J1 · Cloud-compatible workflow</b></summary> **1.** Load model-free EmptyImage → SaveImage.<br> <img src="https://github.com/user-attachments/assets/ec66f384-a7c7-46e1-a4f1-01e29082504d" alt="J1 · Cloud-compatible workflow, step 1" width="640"> **2.** Real HTTP 200: no missing nodes or models.<br> <img src="https://github.com/user-attachments/assets/b266e5bd-13ba-4736-b5a4-74bf7ab970b1" alt="J1 · Cloud-compatible workflow, step 2" width="640"> **3.** Cloud action and sign-in guidance shown.<br> <img src="https://github.com/user-attachments/assets/bf7ad393-ac78-4d68-886b-2e862a9107a6" alt="J1 · Cloud-compatible workflow, step 3" width="640"> </details> 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: huang47 <157390+huang47@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance:
|
This comment has been minimized.
This comment has been minimized.
cloud/1.59 predates the package extractions this PR's imports assume, so
point them at the in-tree modules that still exist on this branch:
- @comfyorg/telemetry/reportError -> @/platform/telemetry/reportError
- @comfyorg/graph-model/workflowSchema -> @/platform/workflow/validation/schemas/workflowSchema
- @comfyorg/design-system/{button/Button,dialog/DialogTitle} -> @/components/ui/...
Add the generated Cloud compatibility types (CompatibilityModel,
CloudCompatibility*, CheckCloudCompatibility*) and their Zod schemas to
ingest-types, copied verbatim from main's sync (#22718), and export
handsPopupsToSystemBrowser from billingTab as main did at the time of #23071.
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.59 #23146 +/- ##
=============================================
Coverage ? 86.89%
=============================================
Files ? 2828
Lines ? 144265
Branches ? 44414
=============================================
Hits ? 125357
Misses ? 17924
Partials ? 984
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Approved under the requested backport-only policy. No code-change findings; no tests were run.
Backport of #23071 to
cloud/1.59Automatically created by backport workflow.