Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/ingest-types/src/types.gen.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/ingest-types/src/zod.gen.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions src/composables/__mocks__/useFeatureFlags.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ const defaultFlags: FeatureFlags = {
userSecretsEnabled: false,
nodeReplacementsEnabled: false,
deployToCloud: false,
openOnCloudEnabled: false,
nodeLibraryEssentialsEnabled: false,
comfyHubUploadEnabled: false,
comfyHubProfileGateEnabled: false,
Expand Down
37 changes: 37 additions & 0 deletions src/composables/useFeatureFlags.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,43 @@ describe('useFeatureFlags', () => {
})
})

describe('openOnCloudEnabled', () => {
beforeEach(() => {
vi.mocked(api.getServerFeature).mockImplementation(
(_path, defaultValue) => defaultValue
)
})

afterEach(() => {
remoteConfig.value = {}
})

it('stays off in a production build that serves no value', () => {
vi.stubEnv('DEV', false)

expect(useFeatureFlags().flags.openOnCloudEnabled).toBe(false)
})

it('defaults on in a development build that serves no value', () => {
vi.stubEnv('DEV', true)

expect(useFeatureFlags().flags.openOnCloudEnabled).toBe(true)
})

it.for([
{ dev: false, served: true, expected: true },
{ dev: true, served: false, expected: false }
])(
'follows a remote config $served over the dev=$dev default',
({ dev, served, expected }) => {
vi.stubEnv('DEV', dev)
remoteConfig.value = { open_on_cloud_enabled: served }

expect(useFeatureFlags().flags.openOnCloudEnabled).toBe(expected)
}
)
})

describe('assetsEnabled', () => {
it.for([
['stable cohort without the flag', undefined, false],
Expand Down
8 changes: 8 additions & 0 deletions src/composables/useFeatureFlags.ts
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,13 @@ export function useFeatureFlags() {
get nodeReplacementsEnabled() {
return api.getServerFeature(ServerFeatureFlag.NODE_REPLACEMENTS, false)
},
get openOnCloudEnabled() {
return resolveFlag(
ServerFeatureFlag.OPEN_ON_CLOUD_ENABLED,
remoteConfig.value.open_on_cloud_enabled,
import.meta.env.DEV
)
},
get deployToCloud() {
return api.getServerFeature(ServerFeatureFlag.DEPLOY_TO_CLOUD, false)
},
Expand Down Expand Up @@ -425,6 +432,7 @@ export function startFeatureFlagTelemetry() {
flags.partnerNodeGovernanceEnabled,
[ServerFeatureFlag.USER_SECRETS_ENABLED]: flags.userSecretsEnabled,
[ServerFeatureFlag.NODE_REPLACEMENTS]: flags.nodeReplacementsEnabled,
[ServerFeatureFlag.OPEN_ON_CLOUD_ENABLED]: flags.openOnCloudEnabled,
[ServerFeatureFlag.NODE_LIBRARY_ESSENTIALS_ENABLED]:
flags.nodeLibraryEssentialsEnabled,
[ServerFeatureFlag.COMFYHUB_UPLOAD_ENABLED]: flags.comfyHubUploadEnabled,
Expand Down
1 change: 1 addition & 0 deletions src/platform/remoteConfig/serverFeatureFlag.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export enum ServerFeatureFlag {
DEPLOYMENT_START_ENABLED = 'deployment_start_enabled',
USER_SECRETS_ENABLED = 'user_secrets_enabled',
NODE_REPLACEMENTS = 'node_replacements',
OPEN_ON_CLOUD_ENABLED = 'open_on_cloud_enabled',
DEPLOY_TO_CLOUD = 'deploy_to_cloud',
NODE_LIBRARY_ESSENTIALS_ENABLED = 'node_library_essentials_enabled',
COMFYHUB_UPLOAD_ENABLED = 'comfyhub_upload_enabled',
Expand Down
Loading