Repository navigation
FRONT-3800 refactor(billing): render the Billing tab sections from account-ui (4/4 banners) - #23117
Conversation
BillingTab renders the paused, plan checkout, top-up checkout, parked, auto top-up and credit banners with BillingBanner from @comfyorg/account-ui/billing. The credit banner rules move into useCreditBanner and the banner strings into useBillingBannerCopy. account-ui's banner now uses the 12px radius and full border the shipped banners use, and its link action carries data-variant.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-07T22:53:19.010Z",
"gitSha": "d5f86777a7eee04b156e1d9e047afcefc067602e",
"branch": "1.61-billing-sdk/front-3800-billing-tab-banners",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2035.7369999999833,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.5159999999999996,
"layouts": 10,
"layoutDurationMs": 2.248,
"taskDurationMs": 460.33000000000004,
"heapDeltaBytes": 4035692,
"heapUsedBytes": 64018136,
"domNodes": -178,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 7.6930000000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.8649999999811,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.392,
"layouts": 9,
"layoutDurationMs": 2.15,
"taskDurationMs": 421.20900000000006,
"heapDeltaBytes": 12228896,
"heapUsedBytes": 81122256,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 7.096,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1725.69900000002,
"styleRecalcs": 72,
"styleRecalcDurationMs": 11.815,
"layouts": 9,
"layoutDurationMs": 1.9879999999999998,
"taskDurationMs": 758.208,
"heapDeltaBytes": -16991060,
"heapUsedBytes": 60804012,
"domNodes": -178,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 120.41099999999999,
"eventListeners": -91,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1677.7159999999753,
"styleRecalcs": 72,
"styleRecalcDurationMs": 11.483,
"layouts": 10,
"layoutDurationMs": 2.035,
"taskDurationMs": 691.2909999999999,
"heapDeltaBytes": 3416720,
"heapUsedBytes": 73180200,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 117.25399999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.8549999999714,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.074,
"layouts": 12,
"layoutDurationMs": 2.1919999999999997,
"taskDurationMs": 325.40000000000003,
"heapDeltaBytes": 5453372,
"heapUsedBytes": 75069480,
"domNodes": 57,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 9.343999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.1510000000158,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.6179999999999986,
"layouts": 14,
"layoutDurationMs": 2.785,
"taskDurationMs": 327.395,
"heapDeltaBytes": 5882476,
"heapUsedBytes": 75854664,
"domNodes": 57,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 9.559000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 550.9450000000129,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.739,
"layouts": 10,
"layoutDurationMs": 2.265,
"taskDurationMs": 401.471,
"heapDeltaBytes": 1775312,
"heapUsedBytes": 62960660,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 134.934,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 542.0619999999872,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.077,
"layouts": 10,
"layoutDurationMs": 2.362,
"taskDurationMs": 406.336,
"heapDeltaBytes": 7009748,
"heapUsedBytes": 82795908,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 136.45399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1021.0569999999848,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 686.2320000000001,
"heapDeltaBytes": -9862404,
"heapUsedBytes": 78104748,
"domNodes": -208,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 47.90899999999999,
"eventListeners": -107,
"totalBlockingTimeMs": 355,
"frameDurationMs": 28.24166666666666,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1036.707999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 698.3059999999999,
"heapDeltaBytes": -5155320,
"heapUsedBytes": 78085100,
"domNodes": -208,
"jsHeapTotalBytes": 17047552,
"scriptDurationMs": 49.61300000000001,
"eventListeners": -107,
"totalBlockingTimeMs": 372,
"frameDurationMs": 28.70277777777777,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 777.9460000000142,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.99300000000017,
"heapDeltaBytes": -6196836,
"heapUsedBytes": 83755508,
"domNodes": 0,
"jsHeapTotalBytes": 4198400,
"scriptDurationMs": 111.675,
"eventListeners": 0,
"totalBlockingTimeMs": 159,
"frameDurationMs": 23.038235294117626,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 811.493999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.42300000000006,
"heapDeltaBytes": -11397072,
"heapUsedBytes": 70501352,
"domNodes": -208,
"jsHeapTotalBytes": 4325376,
"scriptDurationMs": 139.921,
"eventListeners": -107,
"totalBlockingTimeMs": 167,
"frameDurationMs": 22.683333333333344,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7200.760000000002,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8200000000000004,
"layouts": 3,
"layoutDurationMs": 0.6689999999999999,
"taskDurationMs": 6410.357,
"heapDeltaBytes": 65987684,
"heapUsedBytes": 140161920,
"domNodes": -274,
"jsHeapTotalBytes": 50720768,
"scriptDurationMs": 4924.61,
"eventListeners": -69,
"totalBlockingTimeMs": 60,
"frameDurationMs": 24.297643097643096,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7179.374999999993,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9130000000000006,
"layouts": 3,
"layoutDurationMs": 0.8230000000000004,
"taskDurationMs": 6448.022,
"heapDeltaBytes": 64088692,
"heapUsedBytes": 139536788,
"domNodes": -274,
"jsHeapTotalBytes": 59371520,
"scriptDurationMs": 4990.481,
"eventListeners": -69,
"totalBlockingTimeMs": 57,
"frameDurationMs": 24.43197278911565,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6901.336999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6160.776,
"heapDeltaBytes": -5337228,
"heapUsedBytes": 86934284,
"domNodes": -274,
"jsHeapTotalBytes": 9826304,
"scriptDurationMs": 4771.782,
"eventListeners": -69,
"totalBlockingTimeMs": 37,
"frameDurationMs": 24.38056537102473,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6729.129999999997,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8319999999999994,
"layouts": 3,
"layoutDurationMs": 0.5830000000000002,
"taskDurationMs": 6119.927,
"heapDeltaBytes": 4531904,
"heapUsedBytes": 94147916,
"domNodes": -274,
"jsHeapTotalBytes": 10612736,
"scriptDurationMs": 4762.879,
"eventListeners": -69,
"totalBlockingTimeMs": 22,
"frameDurationMs": 24.572992700729923,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 182.34499999999798,
"styleRecalcs": 23,
"styleRecalcDurationMs": 12.160999999999998,
"layouts": 12,
"layoutDurationMs": 2.7549999999999994,
"taskDurationMs": 139.535,
"heapDeltaBytes": 14581996,
"heapUsedBytes": 74683244,
"domNodes": 699,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.951999999999999,
"eventListeners": 72,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.81428571428569,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 165.22400000002335,
"styleRecalcs": 22,
"styleRecalcDurationMs": 10.908000000000001,
"layouts": 10,
"layoutDurationMs": 2.295,
"taskDurationMs": 121.85600000000002,
"heapDeltaBytes": 14502068,
"heapUsedBytes": 74971312,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.079999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.82499999999999,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2024.6160000000089,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.2659999999999996,
"layouts": 9,
"layoutDurationMs": 1.818,
"taskDurationMs": 532.5300000000001,
"heapDeltaBytes": -29218992,
"heapUsedBytes": 63418052,
"domNodes": -274,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 28.47500000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2023.480999999947,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.1159999999999997,
"layouts": 9,
"layoutDurationMs": 1.8840000000000003,
"taskDurationMs": 520.5090000000001,
"heapDeltaBytes": -19686104,
"heapUsedBytes": 61431496,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 27.458000000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2219.274000000013,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.363,
"layouts": 8,
"layoutDurationMs": 1.7940000000000003,
"taskDurationMs": 1344.1159999999998,
"heapDeltaBytes": -23452584,
"heapUsedBytes": 70649944,
"domNodes": -274,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 639.5390000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666165413533836,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2318.1490000000053,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.224,
"layouts": 7,
"layoutDurationMs": 1.632,
"taskDurationMs": 1335.742,
"heapDeltaBytes": -15016780,
"heapUsedBytes": 78918664,
"domNodes": -274,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 642.544,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66690647482014,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3273.520000000019,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.041000000000002,
"layouts": 66,
"layoutDurationMs": 9.976,
"taskDurationMs": 1466.8860000000002,
"heapDeltaBytes": -8821804,
"heapUsedBytes": 73875784,
"domNodes": -250,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 632.8000000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666326530612242,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3282.2209999999927,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.488,
"layouts": 64,
"layoutDurationMs": 9.521,
"taskDurationMs": 1470.4969999999998,
"heapDeltaBytes": 5905840,
"heapUsedBytes": 77872504,
"domNodes": -250,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 636.719,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66598984771574,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2326.5539999999874,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.297000000000001,
"layouts": 7,
"layoutDurationMs": 1.647,
"taskDurationMs": 1542.977,
"heapDeltaBytes": -1738544,
"heapUsedBytes": 76691068,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 756.759,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.786956521739132,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2244.8780000000284,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.9239999999999995,
"layouts": 8,
"layoutDurationMs": 1.8569999999999998,
"taskDurationMs": 1547.1770000000001,
"heapDeltaBytes": -1812444,
"heapUsedBytes": 76749284,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 756.911,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.790298507462683,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2901.2560000000176,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.9130000000000007,
"layouts": 8,
"layoutDurationMs": 1.5,
"taskDurationMs": 627.516,
"heapDeltaBytes": -8894372,
"heapUsedBytes": 67833512,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 281.914,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66628571428571,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2967.1969999999988,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.83,
"layouts": 8,
"layoutDurationMs": 1.63,
"taskDurationMs": 653.4010000000001,
"heapDeltaBytes": -6381188,
"heapUsedBytes": 68383244,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 295.71,
"eventListeners": -91,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666292134831462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.518999999993,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.6849999999999998,
"layouts": 7,
"layoutDurationMs": 1.4390000000000003,
"taskDurationMs": 514.7420000000002,
"heapDeltaBytes": 3116340,
"heapUsedBytes": 79315120,
"domNodes": -274,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 27.400999999999996,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2033.3630000000085,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.6479999999999992,
"layouts": 7,
"layoutDurationMs": 1.469,
"taskDurationMs": 513.4259999999999,
"heapDeltaBytes": 12816804,
"heapUsedBytes": 87799320,
"domNodes": -274,
"jsHeapTotalBytes": -659456,
"scriptDurationMs": 28.125999999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2687.418000000008,
"styleRecalcs": 25,
"styleRecalcDurationMs": 11.616999999999999,
"layouts": 6,
"layoutDurationMs": 1.2789999999999997,
"taskDurationMs": 449.6199999999999,
"heapDeltaBytes": 6622056,
"heapUsedBytes": 80566420,
"domNodes": 19,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 157.38299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66645962732919,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2687.6120000000014,
"styleRecalcs": 27,
"styleRecalcDurationMs": 11.778,
"layouts": 8,
"layoutDurationMs": 1.624,
"taskDurationMs": 438.661,
"heapDeltaBytes": 5366724,
"heapUsedBytes": 76533708,
"domNodes": 19,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 145.18800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665838509316767,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3030.788999999999,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9770000000000005,
"layouts": 8,
"layoutDurationMs": 1.5330000000000001,
"taskDurationMs": 758.1089999999999,
"heapDeltaBytes": -20015336,
"heapUsedBytes": 62591136,
"domNodes": -274,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 291.5179999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666483516483517,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3027.313000000049,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.803,
"layouts": 8,
"layoutDurationMs": 1.507,
"taskDurationMs": 690.9119999999998,
"heapDeltaBytes": 8116976,
"heapUsedBytes": 79697452,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 277.754,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665934065934067,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 548.3940000000302,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.076,
"layouts": 10,
"layoutDurationMs": 2.36,
"taskDurationMs": 364.833,
"heapDeltaBytes": 23642672,
"heapUsedBytes": 85340344,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 122.18799999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636368,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 547.4679999999807,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.1930000000000005,
"layouts": 10,
"layoutDurationMs": 2.119,
"taskDurationMs": 351.271,
"heapDeltaBytes": 7027108,
"heapUsedBytes": 80870524,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 116.79500000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636368,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2007.191000000006,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.0949999999999998,
"layouts": 10,
"layoutDurationMs": 2.039,
"taskDurationMs": 410.63400000000007,
"heapDeltaBytes": 4628476,
"heapUsedBytes": 65965244,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 6.774000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.0959999999664,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.1340000000000003,
"layouts": 9,
"layoutDurationMs": 1.9210000000000003,
"taskDurationMs": 407.425,
"heapDeltaBytes": 4601932,
"heapUsedBytes": 66514004,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 6.608999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.3500000000095,
"styleRecalcs": 75,
"styleRecalcDurationMs": 11.903,
"layouts": 9,
"layoutDurationMs": 1.7779999999999998,
"taskDurationMs": 696.453,
"heapDeltaBytes": -4330692,
"heapUsedBytes": 58948328,
"domNodes": -200,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 82.465,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.5389999999734,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.999,
"layouts": 11,
"layoutDurationMs": 2.2649999999999997,
"taskDurationMs": 698.249,
"heapDeltaBytes": -8413824,
"heapUsedBytes": 54476728,
"domNodes": -200,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 84.51,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 1386.3999999999805,
"styleRecalcs": 20,
"styleRecalcDurationMs": 21.009,
"layouts": 5,
"layoutDurationMs": 12.495,
"taskDurationMs": 973.8220000000002,
"heapDeltaBytes": 15351884,
"heapUsedBytes": 96966984,
"domNodes": 19229,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 24.834999999999997,
"eventListeners": 3566,
"totalBlockingTimeMs": 135,
"frameDurationMs": 19.443055555555564,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8441.837000000021,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.415000000000003,
"layouts": 8,
"layoutDurationMs": 1.65,
"taskDurationMs": 4690.943,
"heapDeltaBytes": 2298348,
"heapUsedBytes": 76017968,
"domNodes": -274,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 2126.9939999999997,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666074950690337,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8358.387999999992,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.71,
"layouts": 9,
"layoutDurationMs": 2.038,
"taskDurationMs": 4702.623,
"heapDeltaBytes": -2470528,
"heapUsedBytes": 80491484,
"domNodes": -274,
"jsHeapTotalBytes": 3760128,
"scriptDurationMs": 2136.962,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66593625498008,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 20520.376999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19831.428000000004,
"heapDeltaBytes": -1586788,
"heapUsedBytes": 286486240,
"domNodes": -3512,
"jsHeapTotalBytes": 13357056,
"scriptDurationMs": 297.66900000000004,
"eventListeners": -677,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.57005347593583,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 20661.310000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19958.552,
"heapDeltaBytes": -5671072,
"heapUsedBytes": 278613832,
"domNodes": -3482,
"jsHeapTotalBytes": 13357056,
"scriptDurationMs": 256.42600000000004,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.192469352014015,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 24725.00200000002,
"styleRecalcs": 180,
"styleRecalcDurationMs": 19.955000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24435.378,
"heapDeltaBytes": -33108012,
"heapUsedBytes": 270953556,
"domNodes": -3482,
"jsHeapTotalBytes": 14139392,
"scriptDurationMs": 734.2539999999999,
"eventListeners": -659,
"totalBlockingTimeMs": 3,
"frameDurationMs": 46.42669172932331,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 25033.07899999993,
"styleRecalcs": 180,
"styleRecalcDurationMs": 19.632999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24648.166,
"heapDeltaBytes": -27335484,
"heapUsedBytes": 271194124,
"domNodes": -3482,
"jsHeapTotalBytes": 15716352,
"scriptDurationMs": 745.148,
"eventListeners": -659,
"totalBlockingTimeMs": 28,
"frameDurationMs": 46.528438661710034,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7426.212000000021,
"styleRecalcs": 20,
"styleRecalcDurationMs": 50.33199999999999,
"layouts": 20,
"layoutDurationMs": 20.56100000000001,
"taskDurationMs": 7289.463000000001,
"heapDeltaBytes": -23660052,
"heapUsedBytes": 274417636,
"domNodes": -3482,
"jsHeapTotalBytes": 20434944,
"scriptDurationMs": 112.55100000000002,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.0639751552795,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7288.1399999999985,
"styleRecalcs": 20,
"styleRecalcDurationMs": 49.66000000000001,
"layouts": 20,
"layoutDurationMs": 20.703,
"taskDurationMs": 7204.227000000001,
"heapDeltaBytes": -39803084,
"heapUsedBytes": 270939108,
"domNodes": -3482,
"jsHeapTotalBytes": 25415680,
"scriptDurationMs": 109.851,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.61077844311377,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10435.801999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10082.937999999998,
"heapDeltaBytes": 7920456,
"heapUsedBytes": 284068328,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 140.65499999999992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.01532846715329,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10108.184000000052,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9706.605,
"heapDeltaBytes": 5719908,
"heapUsedBytes": 284345912,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 125.004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.371328671328676,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 101.77400000003445,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.249,
"layouts": 7,
"layoutDurationMs": 2.8569999999999998,
"taskDurationMs": 87.78999999999999,
"heapDeltaBytes": -10915716,
"heapUsedBytes": 63863060,
"domNodes": 132,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 10.160999999999998,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 91.54599999999391,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.822,
"layouts": 7,
"layoutDurationMs": 2.556,
"taskDurationMs": 68.315,
"heapDeltaBytes": 4818536,
"heapUsedBytes": 66443540,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.8500000000000005,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.650000000000016,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 295.7529999999906,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.629,
"layouts": 76,
"layoutDurationMs": 11.136999999999999,
"taskDurationMs": 255.28700000000003,
"heapDeltaBytes": -5837420,
"heapUsedBytes": 37458852,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 117.48100000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670588235294122,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 296.7549999999619,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.653,
"layouts": 76,
"layoutDurationMs": 11.394,
"taskDurationMs": 262.941,
"heapDeltaBytes": -5739544,
"heapUsedBytes": 39066912,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 119.081,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66111111111114,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 338.9439999999695,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.462,
"layouts": 76,
"layoutDurationMs": 12.017,
"taskDurationMs": 311.832,
"heapDeltaBytes": -1738844,
"heapUsedBytes": 91226876,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 115.828,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661904761904744,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 339.3990000000713,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.5050000000000001,
"layouts": 76,
"layoutDurationMs": 11.512,
"taskDurationMs": 306.80600000000004,
"heapDeltaBytes": -1782708,
"heapUsedBytes": 91438460,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 113.111,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage: 🟡 59.1% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3273 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since ffc0697a64578170b9e692a5008bb9f3a5e13458
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (401)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## 1.61-billing-sdk/front-3800-billing-tab-auto-top-up #23117 +/- ##
======================================================================================
Coverage 87.63% 87.63%
======================================================================================
Files 3064 3061 -3
Lines 164241 164180 -61
Branches 43853 41801 -2052
======================================================================================
- Hits 143932 143879 -53
+ Misses 19417 19410 -7
+ Partials 892 891 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 14 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…to 1.61-billing-sdk/front-3800-billing-tab-banners
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit 3c02cad has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
0e7ae64
into
1.61-billing-sdk/front-3800-billing-tab-auto-top-up
Stack 4/4 for FRONT-3800: banners. Stacked on the auto top-up PR. After this,
src/platform/billing/components/billingTab/holds onlyBillingPlanLifecycle.vue(no account-ui counterpart) and its composables.Why
The Billing tab and Platform billing implement the same sections twice. This renders every Billing tab banner with
BillingBannerfrom@comfyorg/account-ui/billingand deletes the app copies.How
BillingBannerviewBillingPausedBanner.vuepaused, fromuseBillingBannerCopy().pausedView; Update payment ->usePaymentRecoveryDialogBillingPlanCheckoutBanner.vueplanCheckoutBannerView; Dismiss ->usePlanCheckoutBanner().dismissBillingTopupCheckoutBanner.vuetopupCheckoutBannerView; Dismiss / Add credits -> app handlersBillingParkedBanner.vueparked(Contact support link)BillingLocalCreditBanner.vue+BillingAutoTopUpBanner.vuecredit/autoTopUp, fromuseCreditBanner(the moved rules, dismiss state, Add credits / Update payment / handoff)BillingStatusBanner(plan status) is untouched. Server-fact conditions (canManageBilling,canTopUp, parked) stay in the BillingTab template as before.Gaps fixed in account-ui:
rounded-xl border-borderfor every kind (wasborder-border/60, androunded-2xlfor roomy kinds; fix(billing): Billing tab style pass against Figma #22392 moved all banners to 12px and full stroke).Deleted: the six banner
.vuefiles above,BillingBanner.parity.test.ts,BillingLocalCreditBanner.parity.test.ts,BillingAutoTopUpBanner.test.ts.Tests:
BillingLocalCreditBanner.test.ts/.capabilities.test.tsmoved touseCreditBanner.test.ts/.capabilities.test.ts, all assertions kept, rendered through__tests__/CreditBannerHarness.ts.BillingAutoTopUpBanner.test.tsassertions (copy per kind, 12px shell) moved intouseCreditBanner.test.ts.BillingPlanCheckoutBanner.test.tsmoved touseBillingBannerCopy.test.ts.BillingTab.test.ts: banner test ids follow account-ui (billing-banner-<kind>); the paused shell class is read from the banner'sstatuselement. Nobrowser_testsuse the old ids.AS IS / TO BE
Screenshots per state to follow (no visual change expected).
Verification
vitest runBillingTab.test.ts +src/platform/billing/composables/(1656) andsrc/platform/billing/components/settings; account-uisrc/billing(354). All pass.E2E: no
browser_testsspec covers the Billing tab; not run.Part of FRONT-3795
Fixes FRONT-3800