Repository navigation
FRONT-3800 refactor(billing): render the Billing tab sections from account-ui (3/4 auto top-up) - #23116
Conversation
… block from account-ui BillingTab renders BillingAutoTopUpCard and BillingAutoTopUpMemberBlock from @comfyorg/account-ui/billing. The card's served read, saved payment method read, viewed telemetry and Platform link move into useAutoTopUpCardSection, gated on the card being shown. account-ui's card gains an actionHref prop so the action is the same new-tab link the app rendered, and its status dots use the theme classes the app uses.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-08T15:28:23.521Z",
"gitSha": "6bac21feb3f8ca0f9119f0f1b7c3f4bb4e850c77",
"branch": "1.61-billing-sdk/front-3800-billing-tab-auto-top-up",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.8459999999966,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.7990000000000004,
"layouts": 10,
"layoutDurationMs": 2.9039999999999995,
"taskDurationMs": 586.8489999999999,
"heapDeltaBytes": -14227932,
"heapUsedBytes": 62916540,
"domNodes": -178,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 9.562000000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2039.9929999999813,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.5000000000000004,
"layouts": 9,
"layoutDurationMs": 3.2409999999999997,
"taskDurationMs": 692.08,
"heapDeltaBytes": -4691812,
"heapUsedBytes": 71311992,
"domNodes": -178,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 15.062000000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1775.447999999983,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.416,
"layouts": 10,
"layoutDurationMs": 2.688,
"taskDurationMs": 912.0490000000001,
"heapDeltaBytes": -3475736,
"heapUsedBytes": 58688300,
"domNodes": -178,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 157.116,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665094339622637,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1924.8230000000603,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.691999999999998,
"layouts": 9,
"layoutDurationMs": 2.8240000000000003,
"taskDurationMs": 1041.097,
"heapDeltaBytes": -3277816,
"heapUsedBytes": 72967856,
"domNodes": -178,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 174.324,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66608695652174,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.9920000000293,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.523,
"layouts": 13,
"layoutDurationMs": 3.364,
"taskDurationMs": 440.75199999999995,
"heapDeltaBytes": 5783944,
"heapUsedBytes": 75801428,
"domNodes": 57,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 12.438,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.7249999999822,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.454000000000001,
"layouts": 12,
"layoutDurationMs": 3.4010000000000002,
"taskDurationMs": 488.93699999999995,
"heapDeltaBytes": 374820,
"heapUsedBytes": 61592960,
"domNodes": 57,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 16.248999999999995,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 690.6999999999925,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.34,
"layouts": 8,
"layoutDurationMs": 1.9699999999999995,
"taskDurationMs": 477.357,
"heapDeltaBytes": 4003540,
"heapUsedBytes": 65233632,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 162.462,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66341463414635,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 778.0729999999494,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.914999999999999,
"layouts": 8,
"layoutDurationMs": 2.2560000000000002,
"taskDurationMs": 549.172,
"heapDeltaBytes": 1095320,
"heapUsedBytes": 61130344,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 173.565,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667391304347824,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1174.997999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 873.8979999999999,
"heapDeltaBytes": -11219544,
"heapUsedBytes": 78104876,
"domNodes": -208,
"jsHeapTotalBytes": 20193280,
"scriptDurationMs": 69.03799999999998,
"eventListeners": -107,
"totalBlockingTimeMs": 478,
"frameDurationMs": 31.53243243243244,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1222.7080000000115,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 964.0779999999999,
"heapDeltaBytes": -11747488,
"heapUsedBytes": 77583136,
"domNodes": -208,
"jsHeapTotalBytes": 18358272,
"scriptDurationMs": 69.11900000000001,
"eventListeners": -107,
"totalBlockingTimeMs": 522,
"frameDurationMs": 32.88378378378378,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 875.9689999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.6490000000002,
"heapDeltaBytes": -16776296,
"heapUsedBytes": 69720716,
"domNodes": -208,
"jsHeapTotalBytes": 2228224,
"scriptDurationMs": 161.846,
"eventListeners": -107,
"totalBlockingTimeMs": 214,
"frameDurationMs": 24.536111111111115,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 919.7460000000319,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 615.3870000000002,
"heapDeltaBytes": -18665744,
"heapUsedBytes": 66427084,
"domNodes": -208,
"jsHeapTotalBytes": 3801088,
"scriptDurationMs": 179.65100000000007,
"eventListeners": -107,
"totalBlockingTimeMs": 227,
"frameDurationMs": 24.77027027027027,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11042.007999999982,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.04399999999999977,
"layouts": 1,
"layoutDurationMs": 0.24900000000000008,
"taskDurationMs": 10193.095,
"heapDeltaBytes": 44608232,
"heapUsedBytes": 139080112,
"domNodes": -274,
"jsHeapTotalBytes": 64352256,
"scriptDurationMs": 8147.206000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 1055,
"frameDurationMs": 31.886994219653182,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11028.050000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10182.884,
"heapDeltaBytes": 73674264,
"heapUsedBytes": 150163204,
"domNodes": -274,
"jsHeapTotalBytes": 72478720,
"scriptDurationMs": 8076.941999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 1152,
"frameDurationMs": 31.74697406340057,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9089.767999999993,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.07399999999999941,
"layouts": 1,
"layoutDurationMs": 0.20499999999999988,
"taskDurationMs": 8276.961,
"heapDeltaBytes": 62909512,
"heapUsedBytes": 138519156,
"domNodes": -274,
"jsHeapTotalBytes": 58322944,
"scriptDurationMs": 6855.298000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 608,
"frameDurationMs": 32.55555555555556,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11993.137999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11212.688999999998,
"heapDeltaBytes": -14327572,
"heapUsedBytes": 80630608,
"domNodes": -274,
"jsHeapTotalBytes": 23719936,
"scriptDurationMs": 9065.465,
"eventListeners": -69,
"totalBlockingTimeMs": 1625,
"frameDurationMs": 32.2989218328841,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 218.61300000000483,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.215000000000002,
"layouts": 11,
"layoutDurationMs": 2.7459999999999996,
"taskDurationMs": 162.958,
"heapDeltaBytes": -12761428,
"heapUsedBytes": 68537808,
"domNodes": 936,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 8.1,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.066666666666656,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 227.79400000001715,
"styleRecalcs": 19,
"styleRecalcDurationMs": 13.713,
"layouts": 6,
"layoutDurationMs": 1.9469999999999998,
"taskDurationMs": 164.35299999999998,
"heapDeltaBytes": 14553848,
"heapUsedBytes": 74871884,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.014999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 7,
"frameDurationMs": 24.066666666666706,
"p95FrameDurationMs": 83.40000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2041.1300000000097,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5700000000000003,
"layouts": 8,
"layoutDurationMs": 2.267,
"taskDurationMs": 656.2509999999999,
"heapDeltaBytes": -10394876,
"heapUsedBytes": 62891952,
"domNodes": -274,
"jsHeapTotalBytes": -397312,
"scriptDurationMs": 31.309000000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2055.749999999989,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.431,
"layouts": 7,
"layoutDurationMs": 1.9689999999999999,
"taskDurationMs": 823.2779999999999,
"heapDeltaBytes": -8824848,
"heapUsedBytes": 64701868,
"domNodes": -274,
"jsHeapTotalBytes": 913408,
"scriptDurationMs": 41.37499999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2764.762000000019,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.871,
"layouts": 6,
"layoutDurationMs": 1.515,
"taskDurationMs": 1774.908,
"heapDeltaBytes": -11505376,
"heapUsedBytes": 63290688,
"domNodes": -274,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 842.68,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.766666666666662,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2873.7109999999575,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.587000000000002,
"layouts": 7,
"layoutDurationMs": 2.157,
"taskDurationMs": 1836.686,
"heapDeltaBytes": -17492616,
"heapUsedBytes": 63871792,
"domNodes": -274,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 867.27,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76315789473684,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3957.3760000000107,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.793,
"layouts": 64,
"layoutDurationMs": 10.226,
"taskDurationMs": 1827.1469999999997,
"heapDeltaBytes": 8146516,
"heapUsedBytes": 85056700,
"domNodes": -250,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 776.617,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66582278481013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4060.573999999974,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.893,
"layouts": 64,
"layoutDurationMs": 10.719,
"taskDurationMs": 1973.6560000000002,
"heapDeltaBytes": -13877340,
"heapUsedBytes": 62109800,
"domNodes": -250,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 823.602,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3036.535000000015,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.209,
"layouts": 4,
"layoutDurationMs": 0.905,
"taskDurationMs": 1967.816,
"heapDeltaBytes": 9391052,
"heapUsedBytes": 88237056,
"domNodes": 0,
"jsHeapTotalBytes": 6447104,
"scriptDurationMs": 966.3980000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75714285714286,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3232.8489999999874,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.002999999999999,
"layouts": 4,
"layoutDurationMs": 1.1650000000000003,
"taskDurationMs": 2103.41,
"heapDeltaBytes": 6322420,
"heapUsedBytes": 79332012,
"domNodes": 0,
"jsHeapTotalBytes": 6254592,
"scriptDurationMs": 1004.9630000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 2,
"frameDurationMs": 16.923195876288663,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3053.8650000000016,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.8729999999999989,
"layouts": 7,
"layoutDurationMs": 1.6569999999999998,
"taskDurationMs": 798.549,
"heapDeltaBytes": 10629188,
"heapUsedBytes": 85851296,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 354.757,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666120218579234,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3135.1570000000493,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.7350000000000003,
"layouts": 6,
"layoutDurationMs": 1.7339999999999995,
"taskDurationMs": 896.4469999999999,
"heapDeltaBytes": -13246456,
"heapUsedBytes": 60824644,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 395.469,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66595744680851,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2043.1730000000243,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.019,
"layouts": 7,
"layoutDurationMs": 2.3670000000000004,
"taskDurationMs": 734.4209999999999,
"heapDeltaBytes": 10467088,
"heapUsedBytes": 86574108,
"domNodes": -274,
"jsHeapTotalBytes": 389120,
"scriptDurationMs": 33.98099999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666664,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2044.6359999999686,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.32,
"layouts": 7,
"layoutDurationMs": 2.058,
"taskDurationMs": 767.908,
"heapDeltaBytes": -26594392,
"heapUsedBytes": 61636636,
"domNodes": -274,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 38.769999999999996,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2755.196000000012,
"styleRecalcs": 26,
"styleRecalcDurationMs": 13.237000000000002,
"layouts": 7,
"layoutDurationMs": 2.37,
"taskDurationMs": 558.92,
"heapDeltaBytes": 7235068,
"heapUsedBytes": 86614200,
"domNodes": 19,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 179.367,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2996.495999999979,
"styleRecalcs": 25,
"styleRecalcDurationMs": 13.447,
"layouts": 6,
"layoutDurationMs": 1.8760000000000006,
"taskDurationMs": 710.719,
"heapDeltaBytes": -6883988,
"heapUsedBytes": 74889780,
"domNodes": -270,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 214.262,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665363128491617,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3309.65599999999,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.608,
"layouts": 5,
"layoutDurationMs": 1.4829999999999999,
"taskDurationMs": 943.536,
"heapDeltaBytes": 4409252,
"heapUsedBytes": 89207640,
"domNodes": -274,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 370.77500000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.750761421319798,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3373.5659999999825,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.4940000000000004,
"layouts": 5,
"layoutDurationMs": 1.3250000000000002,
"taskDurationMs": 1009.0360000000001,
"heapDeltaBytes": -2328604,
"heapUsedBytes": 84556316,
"domNodes": -274,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 381.867,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66600985221675,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 629.1879999999992,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.403,
"layouts": 9,
"layoutDurationMs": 2.568,
"taskDurationMs": 450.21500000000003,
"heapDeltaBytes": 3215212,
"heapUsedBytes": 74495508,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 146.24599999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 713.7099999999919,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.3340000000000005,
"layouts": 8,
"layoutDurationMs": 2.086,
"taskDurationMs": 490.329,
"heapDeltaBytes": 4415292,
"heapUsedBytes": 78466516,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 148.99400000000003,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2039.231000000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.6669999999999994,
"layouts": 9,
"layoutDurationMs": 2.1660000000000004,
"taskDurationMs": 554.6999999999999,
"heapDeltaBytes": -4021424,
"heapUsedBytes": 58976796,
"domNodes": -200,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 7.183000000000002,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2025.841000000014,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8669999999999995,
"layouts": 8,
"layoutDurationMs": 2.3210000000000006,
"taskDurationMs": 641.2990000000001,
"heapDeltaBytes": 4970084,
"heapUsedBytes": 67977400,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 13.927999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1740.4260000000136,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.738000000000001,
"layouts": 9,
"layoutDurationMs": 2.5250000000000004,
"taskDurationMs": 886.228,
"heapDeltaBytes": -10774612,
"heapUsedBytes": 51985336,
"domNodes": -200,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 108.822,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1734.7200000000385,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.647999999999998,
"layouts": 8,
"layoutDurationMs": 2.4330000000000003,
"taskDurationMs": 977.954,
"heapDeltaBytes": 11053316,
"heapUsedBytes": 71565636,
"domNodes": -200,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 119.89599999999999,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6673076923077,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1625.436000000036,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.059,
"layouts": 5,
"layoutDurationMs": 18.894000000000005,
"taskDurationMs": 1443.6360000000002,
"heapDeltaBytes": 3005056,
"heapUsedBytes": 85821396,
"domNodes": -1320,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 33.424,
"eventListeners": -262,
"totalBlockingTimeMs": 207,
"frameDurationMs": 20.37037037037037,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10381.483000000004,
"styleRecalcs": 250,
"styleRecalcDurationMs": 28.79,
"layouts": 8,
"layoutDurationMs": 1.97,
"taskDurationMs": 6038.2119999999995,
"heapDeltaBytes": 4001108,
"heapUsedBytes": 77401540,
"domNodes": -274,
"jsHeapTotalBytes": 5300224,
"scriptDurationMs": 2699.1929999999998,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665916398713826,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 11275.105000000054,
"styleRecalcs": 249,
"styleRecalcDurationMs": 31.371000000000002,
"layouts": 6,
"layoutDurationMs": 1.7699999999999998,
"taskDurationMs": 6544.5689999999995,
"heapDeltaBytes": 3818068,
"heapUsedBytes": 77010152,
"domNodes": -274,
"jsHeapTotalBytes": 4251648,
"scriptDurationMs": 2873.8080000000004,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69066666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 24567.22400000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23848.388,
"heapDeltaBytes": -21712328,
"heapUsedBytes": 262909092,
"domNodes": -3482,
"jsHeapTotalBytes": 6537216,
"scriptDurationMs": 329.66900000000004,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.18952042628774,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 25132.243000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24380.214,
"heapDeltaBytes": -29971124,
"heapUsedBytes": 267507940,
"domNodes": -3482,
"jsHeapTotalBytes": -2109440,
"scriptDurationMs": 374.01300000000003,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.32522045855379,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 29841.119999999988,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.963999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 29527.762000000002,
"heapDeltaBytes": -29444104,
"heapUsedBytes": 253799680,
"domNodes": -3482,
"jsHeapTotalBytes": -4988928,
"scriptDurationMs": 894.215,
"eventListeners": -659,
"totalBlockingTimeMs": 16,
"frameDurationMs": 56.50037878787878,
"p95FrameDurationMs": 116.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 30188.255000000026,
"styleRecalcs": 181,
"styleRecalcDurationMs": 24.089,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 29941.034,
"heapDeltaBytes": -1773400,
"heapUsedBytes": 288224548,
"domNodes": -3482,
"jsHeapTotalBytes": 11452416,
"scriptDurationMs": 920.1980000000001,
"eventListeners": -659,
"totalBlockingTimeMs": 88,
"frameDurationMs": 57.05500945179584,
"p95FrameDurationMs": 116.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8768.58900000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 65.308,
"layouts": 20,
"layoutDurationMs": 23.830999999999992,
"taskDurationMs": 8604.367,
"heapDeltaBytes": 7867252,
"heapUsedBytes": 280392952,
"domNodes": -3482,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 132.003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 51.5664705882353,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8830.247999999983,
"styleRecalcs": 20,
"styleRecalcDurationMs": 65.824,
"layouts": 20,
"layoutDurationMs": 23.88,
"taskDurationMs": 8684.911999999998,
"heapDeltaBytes": 16714500,
"heapUsedBytes": 269762160,
"domNodes": -3482,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 127.92900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 50.18749999999999,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12757.032999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12442.041,
"heapDeltaBytes": -14793600,
"heapUsedBytes": 249982716,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 165.47200000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.37188612099644,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12920.593000000054,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12654.273999999998,
"heapDeltaBytes": -30263796,
"heapUsedBytes": 261045144,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 172.88899999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.42042253521127,
"p95FrameDurationMs": 100
},
{
"name": "workflow-execution",
"durationMs": 148.9090000000033,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.504,
"layouts": 9,
"layoutDurationMs": 4.377000000000001,
"taskDurationMs": 120.43700000000001,
"heapDeltaBytes": -10969872,
"heapUsedBytes": 61115848,
"domNodes": 128,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 9.057,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.677777777777766,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 145.06600000004255,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.3,
"layouts": 10,
"layoutDurationMs": 4.141000000000001,
"taskDurationMs": 99.82000000000001,
"heapDeltaBytes": 4779476,
"heapUsedBytes": 73152328,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.839000000000002,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.655555555555566,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 587.6779999999826,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.873,
"layouts": 76,
"layoutDurationMs": 16.837,
"taskDurationMs": 540.734,
"heapDeltaBytes": -3363580,
"heapUsedBytes": 43435480,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 250.01299999999998,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668571428571443,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 649.7269999999844,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.76,
"layouts": 76,
"layoutDurationMs": 19.337,
"taskDurationMs": 611.523,
"heapDeltaBytes": 151728,
"heapUsedBytes": 47803380,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 286.091,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102578,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 676.4089999999214,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.4290000000000003,
"layouts": 76,
"layoutDurationMs": 16.869,
"taskDurationMs": 640.662,
"heapDeltaBytes": 1161888,
"heapUsedBytes": 106824784,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 262.444,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.082500000000003,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 630.4440000000113,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.189,
"layouts": 76,
"layoutDurationMs": 15.606,
"taskDurationMs": 601.093,
"heapDeltaBytes": 329680,
"heapUsedBytes": 80430888,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 236.40800000000002,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage: 🟡 59.2% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3274 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 5c9d49268a55bef296d47823120cd90242f2fc2d
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (401)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## 1.61-billing-sdk/front-3800-billing-tab-credits-card #23116 +/- ##
========================================================================================
- Coverage 87.64% 87.62% -0.02%
========================================================================================
Files 3065 3061 -4
Lines 164306 164177 -129
Branches 43878 43820 -58
========================================================================================
- Hits 144003 143865 -138
- Misses 19411 19421 +10
+ Partials 892 891 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 16 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…nto 1.61-billing-sdk/front-3800-billing-tab-auto-top-up
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 97 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit ffc0697 has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
…count-ui (4/4 banners) (#23117) Stack 4/4 for FRONT-3800: banners. Stacked on the auto top-up PR. After this, `src/platform/billing/components/billingTab/` holds only `BillingPlanLifecycle.vue` (no account-ui counterpart) and its composables. ## Why The Billing tab and Platform billing implement the same sections twice. This renders every Billing tab banner with `BillingBanner` from `@comfyorg/account-ui/billing` and deletes the app copies. ## How | Local (deleted) | account-ui `BillingBanner` view | | -- | -- | | `BillingPausedBanner.vue` | `paused`, from `useBillingBannerCopy().pausedView`; Update payment -> `usePaymentRecoveryDialog` | | `BillingPlanCheckoutBanner.vue` | `planCheckoutBannerView`; Dismiss -> `usePlanCheckoutBanner().dismiss` | | `BillingTopupCheckoutBanner.vue` | `topupCheckoutBannerView`; Dismiss / Add credits -> app handlers | | `BillingParkedBanner.vue` | `parked` (Contact support link) | | `BillingLocalCreditBanner.vue` + `BillingAutoTopUpBanner.vue` | `credit` / `autoTopUp`, from `useCreditBanner` (the moved rules, dismiss state, Add credits / Update payment / handoff) | `BillingStatusBanner` (plan status) is untouched. Server-fact conditions (`canManageBilling`, `canTopUp`, parked) stay in the BillingTab template as before. Gaps fixed in account-ui: - Banner panel uses `rounded-xl border-border` for every kind (was `border-border/60`, and `rounded-2xl` for roomy kinds; #22392 moved all banners to 12px and full stroke). Deleted: the six banner `.vue` files above, `BillingBanner.parity.test.ts`, `BillingLocalCreditBanner.parity.test.ts`, `BillingAutoTopUpBanner.test.ts`. Tests: - `BillingLocalCreditBanner.test.ts` / `.capabilities.test.ts` moved to `useCreditBanner.test.ts` / `.capabilities.test.ts`, all assertions kept, rendered through `__tests__/CreditBannerHarness.ts`. - `BillingAutoTopUpBanner.test.ts` assertions (copy per kind, 12px shell) moved into `useCreditBanner.test.ts`. - `BillingPlanCheckoutBanner.test.ts` moved to `useBillingBannerCopy.test.ts`. - `BillingTab.test.ts`: banner test ids follow account-ui (`billing-banner-<kind>`); the paused shell class is read from the banner's `status` element. No `browser_tests` use the old ids. - Banner parity tests retired: the app banners they compared against are gone; BillingTab.test.ts covers paused, parked, top-up checkout and the stack order. ## AS IS / TO BE Screenshots per state to follow (no visual change expected). ## Verification - `vitest run` BillingTab.test.ts + `src/platform/billing/composables/` (1656) and `src/platform/billing/components/settings`; account-ui `src/billing` (354). All pass. - E2E: no `browser_tests` spec covers the Billing tab; not run. - Part of FRONT-3795 - Fixes FRONT-3800
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit 0e7ae64 has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
1d3ef36
into
1.61-billing-sdk/front-3800-billing-tab-credits-card
Stack 3/4 for FRONT-3800: auto top-up card and member block. Stacked on the Credits card PR.
Why
The Billing tab and Platform billing implement the same sections twice. This renders the auto top-up card and the member block from
@comfyorg/account-ui/billingand deletes the app copies.How
billingTab/BillingAutoTopUpCard.vueBillingAutoTopUpCard, fed byuseAutoTopUpCardSection(served read, saved payment methods read, viewed telemetry, Platform link) anduseAutoTopUpCardCopybillingTab/BillingAutoTopUpMemberCard.vueBillingAutoTopUpMemberBlockwithuseAutoTopUpMemberBlockCopyand the servedautoTopUpMemberViewbillingTab/BillingInfoTip.vueBillingInfoTip(already used inside the cards)useAutoTopUpCardSectiontakes the card's visibility, so the read, the payment-method read and theauto_top_up_card viewedevent still only happen while the card is shown (they used to be bound to the card's mount).Gaps fixed in account-ui:
BillingAutoTopUpCardgets anactionHrefprop: the action renders as the same new-tab link the app rendered (correlation-id href +platform_handofftelemetry via@action). Test added.bg-destructive,bg-warning,bg-success(were*-backgroundvariants, the ones fix(billing): Billing tab style pass against Figma #22392 found invisible).BillingBannerActionButtontakes a slot for the icon, any button variant, optionalloading, and putsdata-varianton its link, so the card reuses it for the action.Deleted:
BillingAutoTopUpCard.vue,BillingAutoTopUpMemberCard.vue,BillingInfoTip.vue,BillingAutoTopUpCard.parity.test.ts,BillingAutoTopUpMemberCard.parity.test.ts.Tests:
BillingAutoTopUpCard.test.tsmoved touseAutoTopUpCardSection.test.tswith every assertion kept (renders account-ui's card from the composable), plus one for the hidden-card gate.BillingInfoTip.test.tsmoved to account-ui. Member block parity is retired; BillingTab.test.ts covers the member statuses.AS IS / TO BE
Screenshots per state to follow (no visual change expected).
Verification
vitest runBillingTab.test.ts + useAutoTopUpCardSection.test.ts (158); account-uisrc/billing/tab(125). All pass.E2E: no
browser_testsspec covers the Billing tab; not run.Part of FRONT-3795
Part of FRONT-3800