Repository navigation
FRONT-3800 refactor(billing): render the Billing tab sections from account-ui (2/4 credits card) - #23115
Conversation
BillingTab renders BillingCreditsCard from @comfyorg/account-ui/billing with host-translated copy. The account-ui card now uses the border token the shipped ComfyUI card uses, and CheckoutButton carries data-variant like the design-system Button it stands in for.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-08T16:10:37.532Z",
"gitSha": "9bc255d07867ff2495df68263424796ecc71cab5",
"branch": "1.61-billing-sdk/front-3800-billing-tab-credits-card",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2026.1490000000038,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.6260000000000003,
"layouts": 10,
"layoutDurationMs": 2.404,
"taskDurationMs": 487.931,
"heapDeltaBytes": -26087528,
"heapUsedBytes": 51400184,
"domNodes": -178,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 8.568000000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2024.9569999999721,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4570000000000003,
"layouts": 9,
"layoutDurationMs": 2.065,
"taskDurationMs": 467.059,
"heapDeltaBytes": -14814996,
"heapUsedBytes": 63076680,
"domNodes": -178,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 7.564999999999999,
"eventListeners": -91,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1710.7139999999958,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.544,
"layouts": 10,
"layoutDurationMs": 2.3579999999999997,
"taskDurationMs": 766.203,
"heapDeltaBytes": 221888,
"heapUsedBytes": 77020912,
"domNodes": -178,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 123.66800000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1711.373999999978,
"styleRecalcs": 72,
"styleRecalcDurationMs": 11.32,
"layouts": 9,
"layoutDurationMs": 2.0820000000000003,
"taskDurationMs": 763.707,
"heapDeltaBytes": -17861640,
"heapUsedBytes": 59917372,
"domNodes": -178,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 121.47699999999999,
"eventListeners": -91,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1758.217000000002,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.936000000000001,
"layouts": 13,
"layoutDurationMs": 2.5820000000000003,
"taskDurationMs": 370.718,
"heapDeltaBytes": 4870712,
"heapUsedBytes": 73590476,
"domNodes": 57,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 11.055,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666981132075474,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.5100000000093,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.695,
"layouts": 12,
"layoutDurationMs": 2.2430000000000003,
"taskDurationMs": 326.325,
"heapDeltaBytes": 3479364,
"heapUsedBytes": 64965048,
"domNodes": 57,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 9.930000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 565.2280000000189,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.171,
"layouts": 11,
"layoutDurationMs": 2.675,
"taskDurationMs": 405.8160000000001,
"heapDeltaBytes": 7991460,
"heapUsedBytes": 77100560,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 135.853,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 567.6960000000122,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.9010000000000002,
"layouts": 10,
"layoutDurationMs": 2.396,
"taskDurationMs": 409.465,
"heapDeltaBytes": -15790264,
"heapUsedBytes": 61521788,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 135.93099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66176470588235,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 970.8970000000079,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 612.2209999999999,
"heapDeltaBytes": 28446056,
"heapUsedBytes": 98472164,
"domNodes": 0,
"jsHeapTotalBytes": 11698176,
"scriptDurationMs": 48.99100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 346,
"frameDurationMs": 29.29393939393939,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1036.4270000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 701.518,
"heapDeltaBytes": -10525108,
"heapUsedBytes": 77521444,
"domNodes": -208,
"jsHeapTotalBytes": 18096128,
"scriptDurationMs": 50.461999999999996,
"eventListeners": -107,
"totalBlockingTimeMs": 369,
"frameDurationMs": 28.702777777777783,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 797.7620000000059,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.1529999999998,
"heapDeltaBytes": -22352788,
"heapUsedBytes": 67536392,
"domNodes": -208,
"jsHeapTotalBytes": 4063232,
"scriptDurationMs": 111.99100000000001,
"eventListeners": -107,
"totalBlockingTimeMs": 159,
"frameDurationMs": 22.857142857142858,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 778.774999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.3199999999999,
"heapDeltaBytes": -5185408,
"heapUsedBytes": 85544280,
"domNodes": 0,
"jsHeapTotalBytes": 4984832,
"scriptDurationMs": 109.80899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 158,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7437.2500000000055,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.25100000000000033,
"layouts": 1,
"layoutDurationMs": 0.17599999999999993,
"taskDurationMs": 6541.697999999999,
"heapDeltaBytes": -4821916,
"heapUsedBytes": 86077816,
"domNodes": -270,
"jsHeapTotalBytes": 9302016,
"scriptDurationMs": 5043.894,
"eventListeners": -69,
"totalBlockingTimeMs": 73,
"frameDurationMs": 24.450986842105266,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7033.6770000000115,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.5549999999999999,
"layouts": 3,
"layoutDurationMs": 0.5890000000000001,
"taskDurationMs": 6268.388,
"heapDeltaBytes": 47182316,
"heapUsedBytes": 140633492,
"domNodes": -274,
"jsHeapTotalBytes": 65138688,
"scriptDurationMs": 4799.117000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 54,
"frameDurationMs": 24.42013888888889,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7410.074000000009,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7429999999999998,
"layouts": 3,
"layoutDurationMs": 0.846,
"taskDurationMs": 6569.3099999999995,
"heapDeltaBytes": 81742800,
"heapUsedBytes": 157985948,
"domNodes": -274,
"jsHeapTotalBytes": 65925120,
"scriptDurationMs": 5074.593,
"eventListeners": -69,
"totalBlockingTimeMs": 34,
"frameDurationMs": 24.18235294117647,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6965.728000000013,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.68,
"layouts": 2,
"layoutDurationMs": 0.48099999999999965,
"taskDurationMs": 6241.446,
"heapDeltaBytes": 41032008,
"heapUsedBytes": 134616296,
"domNodes": -270,
"jsHeapTotalBytes": 59109376,
"scriptDurationMs": 4794.844,
"eventListeners": -69,
"totalBlockingTimeMs": 68,
"frameDurationMs": 24.529577464788733,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 173.97600000001034,
"styleRecalcs": 20,
"styleRecalcDurationMs": 11.415000000000001,
"layouts": 10,
"layoutDurationMs": 2.3350000000000004,
"taskDurationMs": 122.43199999999999,
"heapDeltaBytes": 14455964,
"heapUsedBytes": 75415144,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.192999999999998,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.36666666666669,
"p95FrameDurationMs": 49.90000000000009
},
{
"name": "large-combo-open",
"durationMs": 183.86800000001813,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.536999999999999,
"layouts": 9,
"layoutDurationMs": 2.506,
"taskDurationMs": 140.904,
"heapDeltaBytes": 14472944,
"heapUsedBytes": 75323584,
"domNodes": 699,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.743999999999998,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.912499999999966,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2025.6430000000023,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.476,
"layouts": 9,
"layoutDurationMs": 2.14,
"taskDurationMs": 549.825,
"heapDeltaBytes": -13291436,
"heapUsedBytes": 61469340,
"domNodes": -274,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 29.613999999999994,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2026.3539999999693,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.7030000000000007,
"layouts": 9,
"layoutDurationMs": 2.1710000000000003,
"taskDurationMs": 538.502,
"heapDeltaBytes": -5575096,
"heapUsedBytes": 86463088,
"domNodes": -274,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 28.039999999999996,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2742.851999999999,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.369,
"layouts": 6,
"layoutDurationMs": 1.3579999999999999,
"taskDurationMs": 1457.693,
"heapDeltaBytes": -398620,
"heapUsedBytes": 71097260,
"domNodes": -274,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 683.5120000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666463414634144,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2209.730000000036,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.045000000000002,
"layouts": 9,
"layoutDurationMs": 2.016,
"taskDurationMs": 1349.8000000000002,
"heapDeltaBytes": -9026564,
"heapUsedBytes": 62519084,
"domNodes": -274,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 632.316,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3785.855999999995,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.343000000000002,
"layouts": 65,
"layoutDurationMs": 9.836,
"taskDurationMs": 1553.34,
"heapDeltaBytes": 2121404,
"heapUsedBytes": 79151080,
"domNodes": -250,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 668.203,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666519823788544,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3336.6740000000163,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.506,
"layouts": 64,
"layoutDurationMs": 9.630999999999998,
"taskDurationMs": 1467.492,
"heapDeltaBytes": 620296,
"heapUsedBytes": 78528492,
"domNodes": -250,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 627.337,
"eventListeners": -91,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2573.769999999996,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.072000000000001,
"layouts": 6,
"layoutDurationMs": 1.408,
"taskDurationMs": 1628.658,
"heapDeltaBytes": 1456904,
"heapUsedBytes": 73704440,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 778.9970000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.774509803921568,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2402.0170000000007,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.463000000000001,
"layouts": 6,
"layoutDurationMs": 1.15,
"taskDurationMs": 1583.1749999999997,
"heapDeltaBytes": 1484844,
"heapUsedBytes": 73210176,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 777.292,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665277777777774,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2921.447999999998,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.1409999999999996,
"layouts": 8,
"layoutDurationMs": 1.8739999999999999,
"taskDurationMs": 585.05,
"heapDeltaBytes": -3666660,
"heapUsedBytes": 72446044,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 275.534,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666285714285713,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2968.522000000007,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.446,
"layouts": 8,
"layoutDurationMs": 1.9340000000000002,
"taskDurationMs": 652.4749999999999,
"heapDeltaBytes": -20754916,
"heapUsedBytes": 64176868,
"domNodes": -274,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 286.80100000000004,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665730337078653,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2029.2929999999956,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9630000000000003,
"layouts": 8,
"layoutDurationMs": 1.7320000000000002,
"taskDurationMs": 527.7950000000001,
"heapDeltaBytes": -9055956,
"heapUsedBytes": 63566456,
"domNodes": -274,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 30.017000000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2034.7380000000044,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2780000000000005,
"layouts": 8,
"layoutDurationMs": 1.986,
"taskDurationMs": 562.3520000000001,
"heapDeltaBytes": -10865408,
"heapUsedBytes": 65702852,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 33.671,
"eventListeners": -91,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2705.303000000015,
"styleRecalcs": 28,
"styleRecalcDurationMs": 12.133,
"layouts": 8,
"layoutDurationMs": 1.6370000000000002,
"taskDurationMs": 449.14200000000005,
"heapDeltaBytes": 6748084,
"heapUsedBytes": 86834224,
"domNodes": 19,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 146.35,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666049382716047,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2673.7660000000005,
"styleRecalcs": 28,
"styleRecalcDurationMs": 12.154,
"layouts": 9,
"layoutDurationMs": 1.8430000000000002,
"taskDurationMs": 461.33099999999996,
"heapDeltaBytes": 6329228,
"heapUsedBytes": 79968328,
"domNodes": 19,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 158.282,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665838509316767,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3055.439999999976,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2639999999999993,
"layouts": 8,
"layoutDurationMs": 1.7460000000000002,
"taskDurationMs": 717.422,
"heapDeltaBytes": 8743720,
"heapUsedBytes": 81689804,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 284.557,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666120218579234,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-topology-cadence",
"durationMs": 3082.2729999999865,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.142,
"layouts": 8,
"layoutDurationMs": 1.6579999999999997,
"taskDurationMs": 749.0689999999998,
"heapDeltaBytes": -8144452,
"heapUsedBytes": 65219116,
"domNodes": -274,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 290.962,
"eventListeners": -91,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665760869565215,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 545.49099999997,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.56,
"layouts": 11,
"layoutDurationMs": 2.659,
"taskDurationMs": 365.04800000000006,
"heapDeltaBytes": 5014716,
"heapUsedBytes": 83143684,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 122.765,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636368,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 571.4260000000309,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.236,
"layouts": 9,
"layoutDurationMs": 2.1049999999999995,
"taskDurationMs": 372.454,
"heapDeltaBytes": 21883836,
"heapUsedBytes": 83314176,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 122.474,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2022.4660000000085,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.0879999999999996,
"layouts": 9,
"layoutDurationMs": 2.4960000000000004,
"taskDurationMs": 486.25399999999996,
"heapDeltaBytes": 5026976,
"heapUsedBytes": 66836064,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 10.023000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.1450000000132,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.6029999999999998,
"layouts": 10,
"layoutDurationMs": 2.258,
"taskDurationMs": 425.914,
"heapDeltaBytes": 12384924,
"heapUsedBytes": 84330916,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 7.098,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.7569999999855,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.572999999999999,
"layouts": 9,
"layoutDurationMs": 1.8960000000000001,
"taskDurationMs": 691.6669999999999,
"heapDeltaBytes": -110684,
"heapUsedBytes": 70843740,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 92.318,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1751.1539999999854,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.685000000000002,
"layouts": 9,
"layoutDurationMs": 1.9370000000000003,
"taskDurationMs": 722.058,
"heapDeltaBytes": -9779800,
"heapUsedBytes": 53026336,
"domNodes": -200,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 89.883,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664761904761907,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1437.8299999999626,
"styleRecalcs": 18,
"styleRecalcDurationMs": 21.8,
"layouts": 5,
"layoutDurationMs": 14.052000000000001,
"taskDurationMs": 1076.1070000000002,
"heapDeltaBytes": 9928568,
"heapUsedBytes": 86445088,
"domNodes": -1320,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 26.583999999999996,
"eventListeners": -262,
"totalBlockingTimeMs": 147,
"frameDurationMs": 19.59324324324324,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9159.15800000002,
"styleRecalcs": 250,
"styleRecalcDurationMs": 31.611,
"layouts": 8,
"layoutDurationMs": 1.7280000000000002,
"taskDurationMs": 4857.426,
"heapDeltaBytes": 1959160,
"heapUsedBytes": 75858176,
"domNodes": -274,
"jsHeapTotalBytes": 3760128,
"scriptDurationMs": 2165.5820000000003,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9246.443999999996,
"styleRecalcs": 249,
"styleRecalcDurationMs": 30.879,
"layouts": 7,
"layoutDurationMs": 1.657,
"taskDurationMs": 4887.575,
"heapDeltaBytes": 9356408,
"heapUsedBytes": 83487512,
"domNodes": -273,
"jsHeapTotalBytes": 3497984,
"scriptDurationMs": 2203.485,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 20510.31899999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19873.482,
"heapDeltaBytes": -22327656,
"heapUsedBytes": 265899380,
"domNodes": -3482,
"jsHeapTotalBytes": 8634368,
"scriptDurationMs": 315.13,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.96522522522522,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 20791.88099999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20177.094999999998,
"heapDeltaBytes": -11183648,
"heapUsedBytes": 272264016,
"domNodes": -3482,
"jsHeapTotalBytes": 15192064,
"scriptDurationMs": 275.62899999999996,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.71837455830389,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 24536.39099999998,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.709000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24256.861,
"heapDeltaBytes": 7043384,
"heapUsedBytes": 290857812,
"domNodes": -3482,
"jsHeapTotalBytes": 15126528,
"scriptDurationMs": 740.241,
"eventListeners": -659,
"totalBlockingTimeMs": 4,
"frameDurationMs": 46.58254269449716,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 24612.546000000068,
"styleRecalcs": 180,
"styleRecalcDurationMs": 19.467000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24298.234,
"heapDeltaBytes": -22942632,
"heapUsedBytes": 274918700,
"domNodes": -3482,
"jsHeapTotalBytes": 20434944,
"scriptDurationMs": 734.56,
"eventListeners": -659,
"totalBlockingTimeMs": 7,
"frameDurationMs": 46.94484732824427,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7209.779000000026,
"styleRecalcs": 20,
"styleRecalcDurationMs": 56.82200000000001,
"layouts": 20,
"layoutDurationMs": 25.915000000000006,
"taskDurationMs": 7127.062000000001,
"heapDeltaBytes": -19561428,
"heapUsedBytes": 278109188,
"domNodes": -3482,
"jsHeapTotalBytes": 18075648,
"scriptDurationMs": 102.14800000000001,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.21197604790419,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7401.599999999917,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.163,
"layouts": 20,
"layoutDurationMs": 27.316000000000006,
"taskDurationMs": 7310.248999999999,
"heapDeltaBytes": -25404964,
"heapUsedBytes": 278555116,
"domNodes": -3482,
"jsHeapTotalBytes": 18337792,
"scriptDurationMs": 127.525,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.02151162790697,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10497.947999999951,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10173.996000000001,
"heapDeltaBytes": 1148968,
"heapUsedBytes": 275739040,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 133.22300000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.653496503496505,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10353.37800000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10075.854,
"heapDeltaBytes": 7497816,
"heapUsedBytes": 274287852,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 142.40900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.98860294117646,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 448.2280000000287,
"styleRecalcs": 15,
"styleRecalcDurationMs": 10.181,
"layouts": 12,
"layoutDurationMs": 3.509,
"taskDurationMs": 104.03399999999999,
"heapDeltaBytes": 7371100,
"heapUsedBytes": 67393688,
"domNodes": 108,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.580999999999998,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 439.59399999994275,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.259999999999999,
"layouts": 12,
"layoutDurationMs": 2.9629999999999996,
"taskDurationMs": 94.55,
"heapDeltaBytes": 7080240,
"heapUsedBytes": 73955012,
"domNodes": 99,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.590000000000002,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 279.54299999998966,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.657,
"layouts": 76,
"layoutDurationMs": 11.117,
"taskDurationMs": 245.175,
"heapDeltaBytes": 10403736,
"heapUsedBytes": 53266696,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 109.763,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 395.326999999952,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.646,
"layouts": 76,
"layoutDurationMs": 12.829,
"taskDurationMs": 352.486,
"heapDeltaBytes": -4549992,
"heapUsedBytes": 39558140,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 162.67,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67083333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 352.62699999998404,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.51,
"layouts": 76,
"layoutDurationMs": 11.763,
"taskDurationMs": 313.21,
"heapDeltaBytes": -1787372,
"heapUsedBytes": 91098472,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 114.126,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.457142857142873,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 365.64499999997224,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.6980000000000002,
"layouts": 76,
"layoutDurationMs": 11.606,
"taskDurationMs": 335.0880000000001,
"heapDeltaBytes": -1288244,
"heapUsedBytes": 91439652,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 125.563,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669565217391327,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage: 🟡 59.1% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3272 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e47423521d0a64d6fce4c9f5b58383f8963b8f49
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (401)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## 1.61-billing-sdk/front-3800-billing-tab-account-ui #23115 +/- ##
======================================================================================
- Coverage 87.65% 87.63% -0.03%
======================================================================================
Files 3067 3061 -6
Lines 164374 164180 -194
Branches 41883 43820 +1937
======================================================================================
- Hits 144079 143873 -206
- Misses 19403 19416 +13
+ Partials 892 891 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 14 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…o 1.61-billing-sdk/front-3800-billing-tab-credits-card
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 97 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit 5c9d492 has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
…count-ui (3/4 auto top-up) (#23116) Stack 3/4 for FRONT-3800: auto top-up card and member block. Stacked on the Credits card PR. ## Why The Billing tab and Platform billing implement the same sections twice. This renders the auto top-up card and the member block from `@comfyorg/account-ui/billing` and deletes the app copies. ## How | Local (deleted) | account-ui | | -- | -- | | `billingTab/BillingAutoTopUpCard.vue` | `BillingAutoTopUpCard`, fed by `useAutoTopUpCardSection` (served read, saved payment methods read, viewed telemetry, Platform link) and `useAutoTopUpCardCopy` | | `billingTab/BillingAutoTopUpMemberCard.vue` | `BillingAutoTopUpMemberBlock` with `useAutoTopUpMemberBlockCopy` and the served `autoTopUpMemberView` | | `billingTab/BillingInfoTip.vue` | account-ui `BillingInfoTip` (already used inside the cards) | `useAutoTopUpCardSection` takes the card's visibility, so the read, the payment-method read and the `auto_top_up_card viewed` event still only happen while the card is shown (they used to be bound to the card's mount). Gaps fixed in account-ui: - `BillingAutoTopUpCard` gets an `actionHref` prop: the action renders as the same new-tab link the app rendered (correlation-id href + `platform_handoff` telemetry via `@action`). Test added. - Status dots use the theme classes the app uses: `bg-destructive`, `bg-warning`, `bg-success` (were `*-background` variants, the ones #22392 found invisible). - `BillingBannerActionButton` takes a slot for the icon, any button variant, optional `loading`, and puts `data-variant` on its link, so the card reuses it for the action. Deleted: `BillingAutoTopUpCard.vue`, `BillingAutoTopUpMemberCard.vue`, `BillingInfoTip.vue`, `BillingAutoTopUpCard.parity.test.ts`, `BillingAutoTopUpMemberCard.parity.test.ts`. Tests: `BillingAutoTopUpCard.test.ts` moved to `useAutoTopUpCardSection.test.ts` with every assertion kept (renders account-ui's card from the composable), plus one for the hidden-card gate. `BillingInfoTip.test.ts` moved to account-ui. Member block parity is retired; BillingTab.test.ts covers the member statuses. ## AS IS / TO BE Screenshots per state to follow (no visual change expected). ## Verification - `vitest run` BillingTab.test.ts + useAutoTopUpCardSection.test.ts (158); account-ui `src/billing/tab` (125). All pass. - E2E: no `browser_tests` spec covers the Billing tab; not run. - Part of FRONT-3795 - Part of FRONT-3800
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit 1d3ef36 has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
c7eecd2
into
1.61-billing-sdk/front-3800-billing-tab-account-ui
Stack 2/4 for FRONT-3800: Credits card. Stacked on the plan row PR.
Why
The Billing tab and Platform billing implement the same sections twice. This renders the Credits card from
@comfyorg/account-ui/billingand deletes the app copy.How
billingTab/BillingCreditsCard.vue+BillingCreditsPlanCell.vueBillingCreditsCardwithcopyfromuseCreditsCardCopycomponents/AddCreditsAction.vue(now unused)AddCreditsActioninside the cardThe app keeps its handlers:
@retryrefetches the balance,@add-creditsopens the Add credits dialog with telemetry.Gaps fixed in account-ui:
border-border(wereborder-card, drift from fix(billing): Billing tab style pass against Figma #22392).CheckoutButtonrendersdata-variantlike the design-systemButtonit stands in for (BillingTab tests read the Add credits emphasis from it).Deleted:
BillingCreditsCard.vue,BillingCreditsPlanCell.vue,BillingCreditsCard.parity.test.ts,components/AddCreditsAction.vue.Tests:
BillingCreditsCard.test.tsmoved touseCreditsCardCopy.test.tswith every assertion kept, rendering account-ui's card with the app copy; emitted events became handler spies. The parity test is retired: it compared the app card to account-ui's, and the app card no longer exists.AS IS / TO BE
Screenshots per state to follow (no visual change expected).
Verification
vitest runBillingTab.test.ts, useCreditsCardCopy.test.ts (151 total); account-uisrc/billing/tab+src/billing/checkout(233). All pass.E2E: no
browser_testsspec covers the Billing tab; not run.Part of FRONT-3795
Part of FRONT-3800