Repository navigation
FRONT-3800 refactor(billing): render the Billing tab sections from account-ui (1/4 plan row) - #23114
Conversation
BillingTab renders BillingPlanRow from @comfyorg/account-ui/billing with host-translated copy, the plan lifecycle actions in its leading slot and the Platform handoff links in its action slot. The account-ui plan row default now matches the shipped ComfyUI look: centered actions, the border token and the up-right arrow on Contact sales.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 8 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-08T16:40:31.577Z",
"gitSha": "0e14c585627f4529ac5d8c562afac7a77c74058a",
"branch": "1.61-billing-sdk/front-3800-billing-tab-account-ui",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2041.263999999984,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.593000000000001,
"layouts": 8,
"layoutDurationMs": 2.1160000000000005,
"taskDurationMs": 531.085,
"heapDeltaBytes": 4244324,
"heapUsedBytes": 66053264,
"domNodes": -178,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 11.528000000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406503,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2041.8200000000297,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.047,
"layouts": 9,
"layoutDurationMs": 2.436000000000001,
"taskDurationMs": 591.39,
"heapDeltaBytes": -20050696,
"heapUsedBytes": 52686992,
"domNodes": -178,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 12.219000000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1691.4110000000164,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.914000000000001,
"layouts": 9,
"layoutDurationMs": 2.2880000000000003,
"taskDurationMs": 744.1659999999999,
"heapDeltaBytes": 3124920,
"heapUsedBytes": 73115148,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 124.76299999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1710.9849999999938,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.776000000000002,
"layouts": 10,
"layoutDurationMs": 2.7489999999999997,
"taskDurationMs": 787.5889999999999,
"heapDeltaBytes": 3897436,
"heapUsedBytes": 74588872,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 128.523,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1716.4600000000405,
"styleRecalcs": 20,
"styleRecalcDurationMs": 4.841,
"layouts": 12,
"layoutDurationMs": 2.692,
"taskDurationMs": 361.76000000000005,
"heapDeltaBytes": 25279760,
"heapUsedBytes": 86497700,
"domNodes": 57,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 12.048,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1703.514000000041,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.717,
"layouts": 12,
"layoutDurationMs": 3.0309999999999997,
"taskDurationMs": 414.45699999999994,
"heapDeltaBytes": 25286492,
"heapUsedBytes": 84551280,
"domNodes": 57,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 14.189,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 576.3880000000086,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.8460000000000005,
"layouts": 9,
"layoutDurationMs": 2.275,
"taskDurationMs": 430.723,
"heapDeltaBytes": 5774188,
"heapUsedBytes": 67570948,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 143.718,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 625.6799999999885,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.9179999999999997,
"layouts": 9,
"layoutDurationMs": 2.358,
"taskDurationMs": 450.03099999999995,
"heapDeltaBytes": 9473368,
"heapUsedBytes": 86051036,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 142.64100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1011.5089999999896,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 716.2160000000001,
"heapDeltaBytes": -10947776,
"heapUsedBytes": 77992696,
"domNodes": -208,
"jsHeapTotalBytes": 18358272,
"scriptDurationMs": 45.803,
"eventListeners": -107,
"totalBlockingTimeMs": 347,
"frameDurationMs": 28.238888888888887,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1045.722000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 746.0889999999999,
"heapDeltaBytes": 624724,
"heapUsedBytes": 78101148,
"domNodes": -208,
"jsHeapTotalBytes": 15736832,
"scriptDurationMs": 53.077,
"eventListeners": -129,
"totalBlockingTimeMs": 366,
"frameDurationMs": 28.375675675675666,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 781.5920000000176,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.7330000000001,
"heapDeltaBytes": -6587808,
"heapUsedBytes": 85502364,
"domNodes": 0,
"jsHeapTotalBytes": 5771264,
"scriptDurationMs": 116.91200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 159,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 813.1529999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.08200000000033,
"heapDeltaBytes": -26627564,
"heapUsedBytes": 65457656,
"domNodes": -208,
"jsHeapTotalBytes": 5111808,
"scriptDurationMs": 122.90400000000001,
"eventListeners": -107,
"totalBlockingTimeMs": 165,
"frameDurationMs": 22.683333333333344,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8767.277000000007,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8679999999999999,
"layouts": 3,
"layoutDurationMs": 0.6639999999999997,
"taskDurationMs": 7590.965000000001,
"heapDeltaBytes": 70976372,
"heapUsedBytes": 166254424,
"domNodes": -274,
"jsHeapTotalBytes": 77197312,
"scriptDurationMs": 6273.816,
"eventListeners": -69,
"totalBlockingTimeMs": 202,
"frameDurationMs": 27.394687500000003,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8258.897999999988,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.4339999999999995,
"layouts": 1,
"layoutDurationMs": 0.31100000000000005,
"taskDurationMs": 7419.785000000001,
"heapDeltaBytes": 59252312,
"heapUsedBytes": 153766296,
"domNodes": -274,
"jsHeapTotalBytes": 70905856,
"scriptDurationMs": 5776.215,
"eventListeners": -69,
"totalBlockingTimeMs": 85,
"frameDurationMs": 24.43392330383481,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7421.43999999999,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6310000000000004,
"layouts": 2,
"layoutDurationMs": 0.415,
"taskDurationMs": 6586.181999999999,
"heapDeltaBytes": 58600952,
"heapUsedBytes": 151590988,
"domNodes": -274,
"jsHeapTotalBytes": 63303680,
"scriptDurationMs": 5011.026,
"eventListeners": -69,
"totalBlockingTimeMs": 33,
"frameDurationMs": 24.078896103896103,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7856.378000000006,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8939999999999998,
"layouts": 3,
"layoutDurationMs": 0.7759999999999998,
"taskDurationMs": 6993.592000000001,
"heapDeltaBytes": -14053064,
"heapUsedBytes": 78953712,
"domNodes": -274,
"jsHeapTotalBytes": 8515584,
"scriptDurationMs": 5387.296,
"eventListeners": -91,
"totalBlockingTimeMs": 69,
"frameDurationMs": 24.152923076923074,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 209.16299999998955,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.800999999999998,
"layouts": 12,
"layoutDurationMs": 3.39,
"taskDurationMs": 173.561,
"heapDeltaBytes": -439912,
"heapUsedBytes": 74542580,
"domNodes": 699,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 10.253,
"eventListeners": 72,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.22222222222222,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 186.6380000000163,
"styleRecalcs": 22,
"styleRecalcDurationMs": 13.119,
"layouts": 10,
"layoutDurationMs": 2.7470000000000003,
"taskDurationMs": 137.65299999999996,
"heapDeltaBytes": 14576972,
"heapUsedBytes": 75900412,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.217,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.22222222222222,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2042.2489999999982,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7389999999999994,
"layouts": 9,
"layoutDurationMs": 2.1609999999999996,
"taskDurationMs": 608.6709999999999,
"heapDeltaBytes": -20168072,
"heapUsedBytes": 61976488,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 37.17,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2025.492999999983,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.952999999999999,
"layouts": 9,
"layoutDurationMs": 2.319,
"taskDurationMs": 529.124,
"heapDeltaBytes": 13363800,
"heapUsedBytes": 86829788,
"domNodes": -274,
"jsHeapTotalBytes": -1445888,
"scriptDurationMs": 35.738,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 3051.782000000003,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.945,
"layouts": 8,
"layoutDurationMs": 1.8880000000000001,
"taskDurationMs": 1509.401,
"heapDeltaBytes": -29947496,
"heapUsedBytes": 62414824,
"domNodes": -274,
"jsHeapTotalBytes": 6193152,
"scriptDurationMs": 714.441,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2947.530000000029,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.059000000000001,
"layouts": 8,
"layoutDurationMs": 1.96,
"taskDurationMs": 1528.757,
"heapDeltaBytes": -32434708,
"heapUsedBytes": 62690480,
"domNodes": -274,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 701.156,
"eventListeners": -89,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.760795454545452,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3998.117000000036,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.538,
"layouts": 64,
"layoutDurationMs": 10.371,
"taskDurationMs": 1582.5529999999999,
"heapDeltaBytes": 1053224,
"heapUsedBytes": 87677668,
"domNodes": 24,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 702.912,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66625,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 4018.053000000009,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.644,
"layouts": 65,
"layoutDurationMs": 10.690000000000001,
"taskDurationMs": 1672.8580000000002,
"heapDeltaBytes": -12423996,
"heapUsedBytes": 65250464,
"domNodes": -250,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 699.59,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66597510373444,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2941.1269999999945,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.861,
"layouts": 7,
"layoutDurationMs": 1.5140000000000002,
"taskDurationMs": 1671.44,
"heapDeltaBytes": 9160364,
"heapUsedBytes": 89115548,
"domNodes": 0,
"jsHeapTotalBytes": 5136384,
"scriptDurationMs": 803.6829999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.761142857142858,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3157.626999999991,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.7860000000000005,
"layouts": 6,
"layoutDurationMs": 1.3419999999999999,
"taskDurationMs": 1820.3990000000001,
"heapDeltaBytes": -11831204,
"heapUsedBytes": 68315104,
"domNodes": 0,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 889.221,
"eventListeners": 182,
"totalBlockingTimeMs": 14,
"frameDurationMs": 16.9331550802139,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2968.9480000000117,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9049999999999996,
"layouts": 7,
"layoutDurationMs": 1.6019999999999999,
"taskDurationMs": 664.331,
"heapDeltaBytes": -2692400,
"heapUsedBytes": 74634896,
"domNodes": -274,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 292.38199999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666480446927373,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2989.868999999999,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2130000000000005,
"layouts": 7,
"layoutDurationMs": 1.647,
"taskDurationMs": 686.9249999999998,
"heapDeltaBytes": -3769164,
"heapUsedBytes": 73696252,
"domNodes": -274,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 299.61400000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611111111111,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2028.447999999969,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2659999999999996,
"layouts": 7,
"layoutDurationMs": 1.7770000000000001,
"taskDurationMs": 549.834,
"heapDeltaBytes": -855204,
"heapUsedBytes": 74625564,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 29.669,
"eventListeners": -91,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2041.4839999999685,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.0489999999999995,
"layouts": 7,
"layoutDurationMs": 1.6250000000000002,
"taskDurationMs": 673.648,
"heapDeltaBytes": 7329140,
"heapUsedBytes": 82114828,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 38.809999999999995,
"eventListeners": -91,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2691.194000000024,
"styleRecalcs": 27,
"styleRecalcDurationMs": 12.364,
"layouts": 7,
"layoutDurationMs": 1.568,
"taskDurationMs": 470.01800000000003,
"heapDeltaBytes": 6728300,
"heapUsedBytes": 83300764,
"domNodes": 19,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 155.918,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666049382716047,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2862.546000000009,
"styleRecalcs": 25,
"styleRecalcDurationMs": 11.713,
"layouts": 6,
"layoutDurationMs": 1.5140000000000002,
"taskDurationMs": 520.0519999999999,
"heapDeltaBytes": 6768392,
"heapUsedBytes": 79631012,
"domNodes": 19,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 163.83,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665697674418606,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3079.43800000001,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0930000000000004,
"layouts": 7,
"layoutDurationMs": 1.521,
"taskDurationMs": 781.9770000000001,
"heapDeltaBytes": -4620864,
"heapUsedBytes": 77815432,
"domNodes": -274,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 286.26399999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3129.4549999999504,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.3930000000000002,
"layouts": 9,
"layoutDurationMs": 2.02,
"taskDurationMs": 814.748,
"heapDeltaBytes": -7712596,
"heapUsedBytes": 75118552,
"domNodes": -274,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 313.99399999999997,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.754545454545454,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 563.9370000000099,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.3790000000000004,
"layouts": 9,
"layoutDurationMs": 2.214,
"taskDurationMs": 378.53700000000003,
"heapDeltaBytes": 1061688,
"heapUsedBytes": 63405416,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 120.439,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.5809999999665,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.547000000000001,
"layouts": 9,
"layoutDurationMs": 2.1969999999999996,
"taskDurationMs": 389.325,
"heapDeltaBytes": 22326364,
"heapUsedBytes": 82885864,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 122.64399999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2009.6089999999833,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.764,
"layouts": 9,
"layoutDurationMs": 2.406,
"taskDurationMs": 520.509,
"heapDeltaBytes": 11794880,
"heapUsedBytes": 83012860,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 10.025999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.9909999999709,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8729999999999998,
"layouts": 9,
"layoutDurationMs": 2.348,
"taskDurationMs": 549.062,
"heapDeltaBytes": 7703204,
"heapUsedBytes": 84714132,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 11.365000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.644000000002,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.57,
"layouts": 9,
"layoutDurationMs": 2.2649999999999997,
"taskDurationMs": 754.5310000000001,
"heapDeltaBytes": 6757652,
"heapUsedBytes": 68310432,
"domNodes": -200,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 95.078,
"eventListeners": -119,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1733.3090000000198,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.881000000000002,
"layouts": 9,
"layoutDurationMs": 2.242,
"taskDurationMs": 798.516,
"heapDeltaBytes": 13737520,
"heapUsedBytes": 75856532,
"domNodes": -200,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 98.121,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1470.7449999999653,
"styleRecalcs": 19,
"styleRecalcDurationMs": 22.837000000000003,
"layouts": 5,
"layoutDurationMs": 13.104000000000005,
"taskDurationMs": 1198.979,
"heapDeltaBytes": 17731956,
"heapUsedBytes": 113482568,
"domNodes": 19229,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 29.609999999999996,
"eventListeners": 3566,
"totalBlockingTimeMs": 137,
"frameDurationMs": 19.517105263157898,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "viewport-pan-sweep",
"durationMs": 10307.920000000024,
"styleRecalcs": 250,
"styleRecalcDurationMs": 31.544000000000004,
"layouts": 9,
"layoutDurationMs": 2.1729999999999996,
"taskDurationMs": 5059.794999999999,
"heapDeltaBytes": -13810136,
"heapUsedBytes": 80860772,
"domNodes": -274,
"jsHeapTotalBytes": 6123520,
"scriptDurationMs": 2211.588,
"eventListeners": -89,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.693042071197414,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 11962.72799999997,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.689,
"layouts": 8,
"layoutDurationMs": 1.783,
"taskDurationMs": 5330.375999999999,
"heapDeltaBytes": -3732308,
"heapUsedBytes": 71045688,
"domNodes": -274,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 2311.963,
"eventListeners": -89,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665877437325904,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 20802.520000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20235.034999999996,
"heapDeltaBytes": -39382912,
"heapUsedBytes": 264226360,
"domNodes": -3482,
"jsHeapTotalBytes": 15974400,
"scriptDurationMs": 275.41700000000003,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.233639705882354,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 21079.271000000062,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20633.142,
"heapDeltaBytes": -1476172,
"heapUsedBytes": 282134828,
"domNodes": -3482,
"jsHeapTotalBytes": 15974400,
"scriptDurationMs": 278.76099999999997,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.79319371727749,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 25014.935000000038,
"styleRecalcs": 179,
"styleRecalcDurationMs": 22.505999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24779.184,
"heapDeltaBytes": 8064384,
"heapUsedBytes": 291625796,
"domNodes": -3482,
"jsHeapTotalBytes": 15388672,
"scriptDurationMs": 808.401,
"eventListeners": -659,
"totalBlockingTimeMs": 7,
"frameDurationMs": 48.26061776061776,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 24857.644999999935,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.48599999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24584.627,
"heapDeltaBytes": -25284404,
"heapUsedBytes": 278309528,
"domNodes": -3482,
"jsHeapTotalBytes": 13877248,
"scriptDurationMs": 740.251,
"eventListeners": -659,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.6256862745098,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7502.043000000014,
"styleRecalcs": 20,
"styleRecalcDurationMs": 68.797,
"layouts": 20,
"layoutDurationMs": 27.320999999999998,
"taskDurationMs": 7410.737999999999,
"heapDeltaBytes": 1439920,
"heapUsedBytes": 284763208,
"domNodes": -3482,
"jsHeapTotalBytes": 20176896,
"scriptDurationMs": 114.38,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.47888198757764,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7484.098000000017,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.95100000000001,
"layouts": 20,
"layoutDurationMs": 21.854,
"taskDurationMs": 7420.287,
"heapDeltaBytes": -22398776,
"heapUsedBytes": 286870592,
"domNodes": -3482,
"jsHeapTotalBytes": 21221376,
"scriptDurationMs": 113.58299999999998,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.66315789473684,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10620.542000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10406.559000000001,
"heapDeltaBytes": -31042544,
"heapUsedBytes": 261936408,
"domNodes": 0,
"jsHeapTotalBytes": -2621440,
"scriptDurationMs": 142.81100000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.88754578754578,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10551.891999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10261.785,
"heapDeltaBytes": -27905456,
"heapUsedBytes": 261516044,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 140.52999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.94820143884892,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 480.05000000000564,
"styleRecalcs": 16,
"styleRecalcDurationMs": 10.419999999999998,
"layouts": 10,
"layoutDurationMs": 3.6629999999999994,
"taskDurationMs": 124.88,
"heapDeltaBytes": 7584516,
"heapUsedBytes": 74845488,
"domNodes": 134,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.308,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 443.23800000006486,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.748000000000001,
"layouts": 13,
"layoutDurationMs": 3.4729999999999994,
"taskDurationMs": 93.054,
"heapDeltaBytes": 6971368,
"heapUsedBytes": 74345284,
"domNodes": 103,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.982000000000001,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662962962962965,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 309.5020000000659,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6769999999999999,
"layouts": 76,
"layoutDurationMs": 11.487,
"taskDurationMs": 274.017,
"heapDeltaBytes": -5711652,
"heapUsedBytes": 38486080,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 125.65799999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736862,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 326.56599999995706,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.675,
"layouts": 76,
"layoutDurationMs": 12.391,
"taskDurationMs": 293.75399999999996,
"heapDeltaBytes": -5225452,
"heapUsedBytes": 38219620,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 134.192,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000027,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 377.05499999992753,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.835,
"layouts": 76,
"layoutDurationMs": 12.366999999999999,
"taskDurationMs": 341.73,
"heapDeltaBytes": -612160,
"heapUsedBytes": 99974628,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 126.32199999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304356,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 374.2500000000746,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.5260000000000002,
"layouts": 76,
"layoutDurationMs": 12.696000000000002,
"taskDurationMs": 350.626,
"heapDeltaBytes": -640372,
"heapUsedBytes": 99948988,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 126.856,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636382,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage: 🟡 59.1% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3275 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 6eb8832452386acbf233b8ef432b9f2d10cd23f1
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (401)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## 1.61-billing-sdk/front-3799-billing-tab-sdk-rules #23114 +/- ##
=====================================================================================
- Coverage 87.65% 87.62% -0.03%
=====================================================================================
Files 3067 3061 -6
Lines 164415 164181 -234
Branches 41914 41802 -112
=====================================================================================
- Hits 144110 143871 -239
- Misses 19413 19419 +6
+ Partials 892 891 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 15 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…ing-tab-sdk-rules' into 1.61-billing-sdk/front-3800-billing-tab-account-ui
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 97 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit e474235 has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
…count-ui (2/4 credits card) (#23115) Stack 2/4 for FRONT-3800: Credits card. Stacked on the plan row PR. ## Why The Billing tab and Platform billing implement the same sections twice. This renders the Credits card from `@comfyorg/account-ui/billing` and deletes the app copy. ## How | Local (deleted) | account-ui | | -- | -- | | `billingTab/BillingCreditsCard.vue` + `BillingCreditsPlanCell.vue` | `BillingCreditsCard` with `copy` from `useCreditsCardCopy` | | `components/AddCreditsAction.vue` (now unused) | account-ui `AddCreditsAction` inside the card | The app keeps its handlers: `@retry` refetches the balance, `@add-credits` opens the Add credits dialog with telemetry. Gaps fixed in account-ui: - Card surface, plan/top-up divider and plan cell use `border-border` (were `border-card`, drift from #22392). - `CheckoutButton` renders `data-variant` like the design-system `Button` it stands in for (BillingTab tests read the Add credits emphasis from it). Deleted: `BillingCreditsCard.vue`, `BillingCreditsPlanCell.vue`, `BillingCreditsCard.parity.test.ts`, `components/AddCreditsAction.vue`. Tests: `BillingCreditsCard.test.ts` moved to `useCreditsCardCopy.test.ts` with every assertion kept, rendering account-ui's card with the app copy; emitted events became handler spies. The parity test is retired: it compared the app card to account-ui's, and the app card no longer exists. ## AS IS / TO BE Screenshots per state to follow (no visual change expected). ## Verification - `vitest run` BillingTab.test.ts, useCreditsCardCopy.test.ts (151 total); account-ui `src/billing/tab` + `src/billing/checkout` (233). All pass. - E2E: no `browser_tests` spec covers the Billing tab; not run. - Part of FRONT-3795 - Part of FRONT-3800
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit c7eecd2 has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
f11c5bf
into
1.61-billing-sdk/front-3799-billing-tab-sdk-rules
Stack 1/4 for FRONT-3800: plan row. Next: credits card, auto top-up, banners (each a working state).
Why
The Billing tab and Platform billing implement the same sections twice. FRONT-3797 built them in
@comfyorg/account-ui/billingwith ComfyUI as the default look; this stack makes ComfyUI render them and deletes the app copies.How
billingTab/BillingPlanRow.vueBillingPlanRowwithcopyfromusePlanRowCopy,BillingPlanLifecyclein#leading, the Platform handoff / Contact sales links in#actionThe app keeps its handlers: plans handoff link +
platform_handofftelemetry, Contact sales link, Stay/Resume lifecycle commands (BillingPlanLifecycle.vuestays, account-ui has no lifecycle).Gaps fixed in account-ui (package default drifted from the #22392 style pass):
items-center border-border(wasitems-start border-card).arrow-up-right(wasexternal-link).Deleted:
BillingPlanRow.vue,BillingPlanRow.stories.ts(account-ui hasBillingPlanRow.stories.ts),BillingPlanRow.parity.test.ts.Tests: the parity matrix (13 states x owner/member + 5 actions) is now
usePlanRowCopy.test.ts, asserting the exact title/line/action text the deleted app row rendered, against account-ui with the app copy.AS IS / TO BE
Screenshots per state to follow (no visual change expected).
Verification
vitest runBillingTab.test.ts (112), usePlanRowCopy.test.ts (31); account-uiBillingPlanRow.test.ts(21). All pass.Tailwind: the app's Tailwind (
tailwindcss/utilitieswithoutsource(none)) auto-detects from the repo root, sopackages/account-ui/srcis already scanned; no@sourcechange.E2E: no
browser_testsspec covers the Billing tab (the billing specs drive Subscription / Plan & Credits panels); not run.Part of FRONT-3795
Part of FRONT-3800