Repository navigation
Conversation
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 282276cb0d8d5e11b73f0ab66fe4724776abab46
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (371)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #23088 +/- ##
==========================================
- Coverage 87.62% 87.52% -0.10%
==========================================
Files 3053 2946 -107
Lines 163915 160532 -3383
Branches 41768 42620 +852
==========================================
- Hits 143625 140507 -3118
+ Misses 19399 19293 -106
+ Partials 891 732 -159
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Summary
Fixes https://linear.app/comfyorg/issue/FRONT-3823
Use real workflow graph/canvas fixtures and the real subgraph guard. Give each test a fresh canvas so the missing-canvas case cannot leak into later tests.
Keep unsafe malformed-locator, null-canvas, and missing-subgraph-root inputs explicit, with their original assertions. Production signatures stay unchanged: callers pass branded locators, raw strings already have a parser, and optional canvas access already has its own API. The remaining
fromAnycalls exercise violations of those contracts and remain tracked by FRONT-3823.Verification