Repository navigation
[backport cloud/1.59] fix(agent): say Add credits does not start a Cloud plan on the agent paywall (#22979) - #22991
Conversation
…paywall (#22979) A Cloud owner without a plan can top up, so the agent's **Out of credits** card offered **Add credits** and said the workspace "has spent its monthly credits". Credits bought there fund the agent but not workflow runs, and nothing said so before the purchase. A user reported exactly this: the agent sent them to buy credits, they got a budget approval, then found they needed a subscription and had to ask again (PM-2273, report #2). When the Add credits plan line applies (Cloud, no plan or an ended plan, can top up), the card now: - uses the no-plan body ("Your account has no credits available for the agent. Add credits to use it.") instead of the monthly-credits sentence, and - adds the same plan-required line the Add credits dialog shows, for example "Buying credits doesn't start a Cloud plan. Subscribe to keep running workflows once your free runs are used.", and - offers **Subscribe** (secondary) next to **Add credits**, without **Upgrade plan**. The line applies only when the owner can subscribe self-serve. The no-funds pause card, which also offers Add credits, shows the same line. Subscribed owners, members, sales-managed workspaces and Local are unchanged. No new strings: the copy is the already-translated `credits.topUp.planRequired*` set. Refs PM-2273. - `agentPaywallPresentation`: the `subscribed` presentation carries an optional `planCreditLine`. - `AgentPanelRoot` reads it from the existing `usePlanCreditLine()` (now exported from `useTopUpPlanCreditCopy`). - `AgentPaywallPlanNote` renders the line (`data-testid="agent-paywall-plan-note"`); `AgentPaywallCard` and `AgentPausedCard` (no-funds pauses) use it. The paywall card switches the body and CTAs. - Story `NoPlan` added. - Red/green unit: `agentPaywallPresentation.test.ts`, `AgentPaywallCard.test.ts`, `AgentPausedCard.test.ts` (failed before the change, pass after). - Integration: `AgentPanelRoot.test.ts`, a free owner without a plan sees the note under the card; an owner with a plan does not. - Cloud e2e + screenshot: `agentPaywallPlanNote.spec.ts` drives a real no-funds turn for a never-subscribed account and snapshots the card (`agent-paywall-plan-note.png`). The baseline is the CI image (8ff93b4):  The body here is the server's no-funds message, which overrides the card's own body; the plan line and the Subscribe + Add credits actions sit below it. - Local: agent panel, paywall and billing suites pass (898 tests in the agent subset); typecheck and server-facts gate clean. Known limit, left as is: before billing finishes loading, the card can briefly show Add credits without the line. The paywall needs a refused turn first, by which point billing has loaded. (cherry picked from commit 126e215)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 8 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-05T10:22:31.651Z",
"gitSha": "a76c97727c20da1793b76cf919d58f3bfb756d25",
"branch": "backport-22979-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2025.2690000000086,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.1000000000000005,
"layouts": 10,
"layoutDurationMs": 2.67,
"taskDurationMs": 334.58700000000005,
"heapDeltaBytes": 24574352,
"heapUsedBytes": 85144220,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 8.267000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2008.1969999999956,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.977,
"layouts": 10,
"layoutDurationMs": 2.5300000000000002,
"taskDurationMs": 372.32200000000006,
"heapDeltaBytes": -25015900,
"heapUsedBytes": 52655468,
"domNodes": -161,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 8.476,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1677.7019999999823,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.355999999999998,
"layouts": 10,
"layoutDurationMs": 2.4079999999999995,
"taskDurationMs": 590.787,
"heapDeltaBytes": 22529900,
"heapUsedBytes": 84155232,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 109.089,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.158000000053,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.118,
"layouts": 10,
"layoutDurationMs": 2.524,
"taskDurationMs": 600.9949999999999,
"heapDeltaBytes": 21910060,
"heapUsedBytes": 82891972,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 111.773,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.641,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.805999999999999,
"layouts": 10,
"layoutDurationMs": 2.8930000000000007,
"taskDurationMs": 287.05099999999993,
"heapDeltaBytes": -166700,
"heapUsedBytes": 62990628,
"domNodes": 56,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 11.971999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.7569999999678,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.437,
"layouts": 12,
"layoutDurationMs": 3.2259999999999995,
"taskDurationMs": 262.15,
"heapDeltaBytes": 24532464,
"heapUsedBytes": 85625304,
"domNodes": 56,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 9.979999999999999,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 526.6280000000165,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.0300000000000002,
"layouts": 10,
"layoutDurationMs": 2.6020000000000003,
"taskDurationMs": 340.66799999999995,
"heapDeltaBytes": 5989636,
"heapUsedBytes": 78531496,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 115.29100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000003,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 543.6359999999922,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.93,
"layouts": 10,
"layoutDurationMs": 2.6229999999999993,
"taskDurationMs": 345.798,
"heapDeltaBytes": 3051504,
"heapUsedBytes": 83592968,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 116.57799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 875.3439999999841,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.26900000000006,
"heapDeltaBytes": 18694784,
"heapUsedBytes": 86394820,
"domNodes": 0,
"jsHeapTotalBytes": 8290304,
"scriptDurationMs": 37.650000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 268,
"frameDurationMs": 25.979411764705887,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 919.5269999999596,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.437,
"heapDeltaBytes": 1411612,
"heapUsedBytes": 76053496,
"domNodes": -191,
"jsHeapTotalBytes": 15212544,
"scriptDurationMs": 37.21099999999999,
"eventListeners": -107,
"totalBlockingTimeMs": 270,
"frameDurationMs": 25.46111111111111,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 719.2450000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 307.1299999999999,
"heapDeltaBytes": -4524228,
"heapUsedBytes": 70585720,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 96.84700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 101,
"frameDurationMs": 21.076470588235278,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 717.817000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 294.3130000000003,
"heapDeltaBytes": -4089468,
"heapUsedBytes": 70806920,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 99.73000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 91,
"frameDurationMs": 21.076470588235306,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6735.1120000000155,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8879999999999999,
"layouts": 3,
"layoutDurationMs": 0.9480000000000001,
"taskDurationMs": 5710.1939999999995,
"heapDeltaBytes": 63616332,
"heapUsedBytes": 138186972,
"domNodes": -257,
"jsHeapTotalBytes": 58847232,
"scriptDurationMs": 4287.812000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.465045592705167,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6671.537,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.1419999999999997,
"layouts": 4,
"layoutDurationMs": 1.0119999999999998,
"taskDurationMs": 5440.18,
"heapDeltaBytes": -10810548,
"heapUsedBytes": 80406264,
"domNodes": -257,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 4177.745,
"eventListeners": -69,
"totalBlockingTimeMs": 45,
"frameDurationMs": 20.079518072289154,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6421.752999999995,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8139999999999996,
"layouts": 3,
"layoutDurationMs": 0.735,
"taskDurationMs": 5572.763999999999,
"heapDeltaBytes": 57123032,
"heapUsedBytes": 134068184,
"domNodes": -257,
"jsHeapTotalBytes": 53604352,
"scriptDurationMs": 4222.839,
"eventListeners": -69,
"totalBlockingTimeMs": 45,
"frameDurationMs": 21.899317406143343,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6567.598000000033,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.17,
"layouts": 4,
"layoutDurationMs": 1.0739999999999998,
"taskDurationMs": 5410.898,
"heapDeltaBytes": 60734672,
"heapUsedBytes": 135871020,
"domNodes": -257,
"jsHeapTotalBytes": 57798656,
"scriptDurationMs": 4063.191,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.847575757575758,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 183.79500000000348,
"styleRecalcs": 23,
"styleRecalcDurationMs": 12.961,
"layouts": 13,
"layoutDurationMs": 3.5569999999999995,
"taskDurationMs": 139.06000000000003,
"heapDeltaBytes": -8343464,
"heapUsedBytes": 75361900,
"domNodes": 936,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 6.548,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.36666666666669,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 162.3700000000099,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.005999999999998,
"layouts": 13,
"layoutDurationMs": 3.226,
"taskDurationMs": 114.35700000000001,
"heapDeltaBytes": -8125352,
"heapUsedBytes": 75575228,
"domNodes": 936,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 6.213,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.428571428571427,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2030.2039999999977,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7820000000000007,
"layouts": 6,
"layoutDurationMs": 1.5019999999999998,
"taskDurationMs": 411.36400000000003,
"heapDeltaBytes": 8189924,
"heapUsedBytes": 82489600,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 28.224,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2025.2350000000092,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6629999999999994,
"layouts": 9,
"layoutDurationMs": 2.241,
"taskDurationMs": 427.16499999999996,
"heapDeltaBytes": -12594104,
"heapUsedBytes": 61310988,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 28.144999999999996,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2612.681000000009,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.984,
"layouts": 6,
"layoutDurationMs": 1.5510000000000004,
"taskDurationMs": 1196.3600000000001,
"heapDeltaBytes": 16588512,
"heapUsedBytes": 76268544,
"domNodes": -257,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 580.792,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666242038216563,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2734.9629999999934,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.037,
"layouts": 9,
"layoutDurationMs": 2.333,
"taskDurationMs": 1270.924,
"heapDeltaBytes": -21956304,
"heapUsedBytes": 61822328,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 611.889,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-zoom",
"durationMs": 3721.439000000004,
"styleRecalcs": 72,
"styleRecalcDurationMs": 11.454999999999998,
"layouts": 66,
"layoutDurationMs": 11.807,
"taskDurationMs": 1353.2379999999998,
"heapDeltaBytes": -2584412,
"heapUsedBytes": 75333420,
"domNodes": -233,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 578.6850000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66591928251121,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3539.0560000000164,
"styleRecalcs": 72,
"styleRecalcDurationMs": 11.341000000000001,
"layouts": 66,
"layoutDurationMs": 12.65,
"taskDurationMs": 1254.149,
"heapDeltaBytes": -12516788,
"heapUsedBytes": 64767756,
"domNodes": -233,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 525.301,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66619718309859,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2822.2579999999766,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.2540000000000004,
"layouts": 7,
"layoutDurationMs": 1.777,
"taskDurationMs": 1439.8270000000002,
"heapDeltaBytes": 15130144,
"heapUsedBytes": 93558708,
"domNodes": 0,
"jsHeapTotalBytes": 5660672,
"scriptDurationMs": 723.306,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665882352941175,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2901.001000000008,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.857,
"layouts": 7,
"layoutDurationMs": 1.7329999999999997,
"taskDurationMs": 1451.0339999999999,
"heapDeltaBytes": 20769476,
"heapUsedBytes": 94610716,
"domNodes": 0,
"jsHeapTotalBytes": 4612096,
"scriptDurationMs": 719.581,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2846.330999999992,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0999999999999996,
"layouts": 7,
"layoutDurationMs": 1.8149999999999997,
"taskDurationMs": 541.351,
"heapDeltaBytes": -644756,
"heapUsedBytes": 75709840,
"domNodes": -257,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 255.49999999999994,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66608187134503,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2842.0809999999506,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.183,
"layouts": 8,
"layoutDurationMs": 1.9269999999999998,
"taskDurationMs": 541.021,
"heapDeltaBytes": -28477136,
"heapUsedBytes": 65303152,
"domNodes": -257,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 246.844,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666470588235292,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2035.9040000000164,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.142,
"layouts": 7,
"layoutDurationMs": 1.806,
"taskDurationMs": 418.91100000000006,
"heapDeltaBytes": -12473680,
"heapUsedBytes": 64663588,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 26.437999999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.3749999999973,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9240000000000004,
"layouts": 10,
"layoutDurationMs": 2.469,
"taskDurationMs": 404.887,
"heapDeltaBytes": -17268544,
"heapUsedBytes": 77404780,
"domNodes": -257,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 26.562,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2678.615999999977,
"styleRecalcs": 28,
"styleRecalcDurationMs": 11.324999999999998,
"layouts": 8,
"layoutDurationMs": 2.252,
"taskDurationMs": 423.745,
"heapDeltaBytes": 492332,
"heapUsedBytes": 82627596,
"domNodes": -238,
"jsHeapTotalBytes": 389120,
"scriptDurationMs": 133.56900000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66583850931677,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2726.512000000014,
"styleRecalcs": 28,
"styleRecalcDurationMs": 10.973,
"layouts": 8,
"layoutDurationMs": 2.1140000000000003,
"taskDurationMs": 445.138,
"heapDeltaBytes": -4670120,
"heapUsedBytes": 83389724,
"domNodes": -238,
"jsHeapTotalBytes": 163840,
"scriptDurationMs": 143.745,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 2964.9980000000087,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.1130000000000004,
"layouts": 8,
"layoutDurationMs": 1.8899999999999997,
"taskDurationMs": 659.9549999999999,
"heapDeltaBytes": -6236296,
"heapUsedBytes": 68275108,
"domNodes": -257,
"jsHeapTotalBytes": 651264,
"scriptDurationMs": 255.216,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665730337078653,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 2954.341999999997,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0729999999999995,
"layouts": 8,
"layoutDurationMs": 1.914,
"taskDurationMs": 665.8060000000002,
"heapDeltaBytes": 7327540,
"heapUsedBytes": 82074416,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 263.33299999999997,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665730337078653,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 509.76700000001074,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.635000000000001,
"layouts": 9,
"layoutDurationMs": 2.3369999999999997,
"taskDurationMs": 313.689,
"heapDeltaBytes": 20700456,
"heapUsedBytes": 82054116,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 105.268,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664516129032254,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 464.02199999999993,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.5169999999999995,
"layouts": 10,
"layoutDurationMs": 2.4619999999999997,
"taskDurationMs": 297.508,
"heapDeltaBytes": 22037660,
"heapUsedBytes": 84411240,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 99.798,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2009.8059999999975,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.698,
"layouts": 9,
"layoutDurationMs": 2.4740000000000006,
"taskDurationMs": 382.469,
"heapDeltaBytes": -2810088,
"heapUsedBytes": 60567860,
"domNodes": -183,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 8.839,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2009.4490000000178,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.0410000000000004,
"layouts": 11,
"layoutDurationMs": 2.8910000000000005,
"taskDurationMs": 333.82199999999995,
"heapDeltaBytes": -2045712,
"heapUsedBytes": 59780612,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 7.915000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1679.2330000000106,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.055000000000001,
"layouts": 10,
"layoutDurationMs": 2.3480000000000003,
"taskDurationMs": 570.825,
"heapDeltaBytes": 17938704,
"heapUsedBytes": 79850440,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 85.282,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.1420000000035,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.208,
"layouts": 10,
"layoutDurationMs": 2.4699999999999998,
"taskDurationMs": 596.9060000000001,
"heapDeltaBytes": 18160548,
"heapUsedBytes": 80700508,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 88.42399999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 850.592000000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 15.823000000000004,
"layouts": 5,
"layoutDurationMs": 10.103,
"taskDurationMs": 668.655,
"heapDeltaBytes": 9540312,
"heapUsedBytes": 101141788,
"domNodes": 16030,
"jsHeapTotalBytes": 17965056,
"scriptDurationMs": 21.041999999999998,
"eventListeners": 3246,
"totalBlockingTimeMs": 85,
"frameDurationMs": 19.76511627906976,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9440.026999999987,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.577999999999996,
"layouts": 8,
"layoutDurationMs": 2.091,
"taskDurationMs": 4456.346999999999,
"heapDeltaBytes": 3857996,
"heapUsedBytes": 82988128,
"domNodes": -257,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 2083.9169999999995,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666137566137564,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8740.20200000001,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.789,
"layouts": 9,
"layoutDurationMs": 2.438,
"taskDurationMs": 4239.817999999999,
"heapDeltaBytes": 6262048,
"heapUsedBytes": 86730132,
"domNodes": -257,
"jsHeapTotalBytes": 2449408,
"scriptDurationMs": 1970.211,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666095238095238,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16804.295000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16092.220000000001,
"heapDeltaBytes": -8526324,
"heapUsedBytes": 284168544,
"domNodes": -3343,
"jsHeapTotalBytes": 14143488,
"scriptDurationMs": 220.567,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.794520547945204,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 16614.536999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15778.002999999999,
"heapDeltaBytes": -15652264,
"heapUsedBytes": 281493336,
"domNodes": -3343,
"jsHeapTotalBytes": 14929920,
"scriptDurationMs": 242.152,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.379469026548676,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 19339.68900000002,
"styleRecalcs": 155,
"styleRecalcDurationMs": 18.289,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18985.716,
"heapDeltaBytes": -9296824,
"heapUsedBytes": 274369320,
"domNodes": -3343,
"jsHeapTotalBytes": 14409728,
"scriptDurationMs": 678.494,
"eventListeners": -651,
"totalBlockingTimeMs": 14,
"frameDurationMs": 36.19775700934579,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 18269.928999999935,
"styleRecalcs": 153,
"styleRecalcDurationMs": 15.898000000000009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17867.193,
"heapDeltaBytes": -28748448,
"heapUsedBytes": 269639388,
"domNodes": -3343,
"jsHeapTotalBytes": 16764928,
"scriptDurationMs": 631.9549999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 6,
"frameDurationMs": 33.607536764705884,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6082.334000000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 42.763,
"layouts": 20,
"layoutDurationMs": 21.592,
"taskDurationMs": 5960.654999999999,
"heapDeltaBytes": -10402680,
"heapUsedBytes": 287278840,
"domNodes": -3343,
"jsHeapTotalBytes": 24367104,
"scriptDurationMs": 94.52400000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.78294117647059,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 5787.02300000009,
"styleRecalcs": 20,
"styleRecalcDurationMs": 42.16400000000001,
"layouts": 20,
"layoutDurationMs": 20.295999999999996,
"taskDurationMs": 5629.334999999999,
"heapDeltaBytes": -12094492,
"heapUsedBytes": 261886964,
"domNodes": -3343,
"jsHeapTotalBytes": 35381248,
"scriptDurationMs": 80.31700000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.72934131736527,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8491.860000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8119.006,
"heapDeltaBytes": 1632432,
"heapUsedBytes": 283469008,
"domNodes": 0,
"jsHeapTotalBytes": -26476544,
"scriptDurationMs": 104.14000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.95221843003413,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8325.846999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7839.937000000001,
"heapDeltaBytes": 28333940,
"heapUsedBytes": 287733212,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 127.797,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.53732876712329,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "workflow-execution",
"durationMs": 90.88099999996757,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.377999999999999,
"layouts": 7,
"layoutDurationMs": 2.298,
"taskDurationMs": 70.79700000000001,
"heapDeltaBytes": -13269632,
"heapUsedBytes": 61420508,
"domNodes": 101,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 6.038,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 88.8400000000047,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.547999999999999,
"layouts": 6,
"layoutDurationMs": 2.055,
"taskDurationMs": 54.144999999999996,
"heapDeltaBytes": 4672284,
"heapUsedBytes": 83632036,
"domNodes": 107,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.963,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 210.2189999999382,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.596,
"layouts": 76,
"layoutDurationMs": 9.976,
"taskDurationMs": 172.71499999999997,
"heapDeltaBytes": 9895984,
"heapUsedBytes": 49824176,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 69.53399999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230754,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 214.89499999995587,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.608,
"layouts": 76,
"layoutDurationMs": 10.76,
"taskDurationMs": 182.889,
"heapDeltaBytes": 9954380,
"heapUsedBytes": 49141132,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 74.76,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.676923076923092,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 244.71300000004703,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.199,
"layouts": 76,
"layoutDurationMs": 9.748,
"taskDurationMs": 217.12300000000002,
"heapDeltaBytes": -5807256,
"heapUsedBytes": 79966272,
"domNodes": 4,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 72.326,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.673333333333296,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 244.82400000010784,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.143,
"layouts": 76,
"layoutDurationMs": 9.422,
"taskDurationMs": 205.78199999999998,
"heapDeltaBytes": -1485968,
"heapUsedBytes": 88874752,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 66.258,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🎭 Playwright: ✅ 3144 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1fd9a2ade8658155cff7152c518f2cab1584d3c9
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (282)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
This comment has been minimized.
This comment has been minimized.
dante01yoon
left a comment
There was a problem hiding this comment.
Approved as a backport of #22979 to cloud/1.59, per the requested backport policy. No code-change review or local tests performed. CI currently reports a failure in unit / test-shards (2), with other checks still running; this approval does not verify that failure is resolved.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.59 #22991 +/- ##
=============================================
Coverage ? 87.23%
=============================================
Files ? 3072
Lines ? 161173
Branches ? 43043
=============================================
Hits ? 140592
Misses ? 19901
Partials ? 680
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…ected copy Release resolution for this backport. #22991 landed on cloud/1.59 after this branch was cut, and its new `says Add credits does not start a plan for an owner with no plan` case asserts the pre-#22694 body sentence, which the cherry-pick above replaces. Left as-is the two cases fail on the rebased tree. The expectation is updated to the exact string `main` already asserts in the same case, not loosened: it is still an exact-text `getByText` on the full sentence, and the falsifying control (reverting only the `main.json` line) turns three cases red. vitest AgentPaywallCard.test.ts: 10/10 pass (2 failed before this commit). Wider run over the agent message components, the paywall presentation service, AgentPanelRoot and platform/billing: 157 files, 4352 tests, all pass.
…he user spent credits they never had (#22694) (#22997) Backport of #22694 to `cloud/1.59`. Cherry-pick of `aa8c1610ac` plus one release resolution (see below). ## Why this train needs it `cloud/1.59` is what production serves right now — `cloud.comfy.org` returns `x-frontend-version: 072c3c1` (`cloud/v1.59.5~1`), which is an ancestor of `cloud/1.59` and of neither `cloud/1.60` nor `main`. #22694 landed on `main` on 2026-11-02 and reached `cloud/1.60` by branch timing, but it was never backported, so `cloud/1.59` still carries the old string: > "You've spent your credit balance. Add credits to keep the agent running." That sentence is false for an account that never had a balance, which is exactly why #22694 replaced it with "Your account has no credits available for the agent. Add credits to use it." ## What changed since #22694 merged, and why it now matters more here When #22694 landed, `agent.paywall.body.local` was only the Local distribution's body. #22979 — backported to this branch as #22991, merged `0d3fc943` — **reuses that same key for the Cloud no-plan card**: `bodyKey` resolves to `bodyKeys.local` whenever `presentation.kind === 'subscribed' && presentation.planCreditLine`. So on `cloud/1.59` as it stands today, the persistent credits-exhausted card in `AgentPanel.vue` (rendered without a server `message`, so the body comes from the locale) reads, for a Cloud user with no plan: > **Out of credits** > You've spent your credit balance. Add credits to keep the agent running. > Buying credits doesn't start a Cloud plan. Subscribe to keep running workflows once your free runs are used. The body claims adding credits keeps the agent running; the note directly below says credits don't run workflows. On `cloud/1.60` and `main` the same card is consistent, because #22694 is in those histories. This is the PM-2273 reporter population (free Cloud account, no plan, bought credits). Note this is the `AgentPanel.vue` render site only. The `AgentMessageGroup.vue` site passes a server `message`, which takes precedence over the locale body — which is also why #22991's e2e screenshot baseline is unaffected by this string either way. ## Contents Two commits: 1. `a326077` — the cherry-pick of `aa8c1610ac`, hunks byte-identical to upstream, no conflicts. 2. `75cf37d` — the release resolution. #22991 landed after this branch was cut, and the `says Add credits does not start a plan for an owner with no plan` case it added asserts the **pre-#22694** body sentence. Left alone, both of its parametrised cases fail once the cherry-pick is applied. The expectation is changed to the exact string `main` already asserts in the same case — still an exact-text `getByText` over the full sentence, not loosened. After both commits, `agent.paywall.body.local` on this branch is byte-identical to `main` and `cloud/1.60`, and no occurrence of the old sentence remains anywhere in the tree (`git grep "spent your credit balance"` → no hits). ## Verification Red, then green, then falsified: | | Result | | --- | --- | | `vitest AgentPaywallCard.test.ts` on the rebase **before** commit 2 | **2 failed**, 8 passed — the #22991 cases | | same, **after** commit 2 | **10/10 pass** | | falsifying control: revert only the `main.json` line, keep both expectations | **3 failed**, 7 passed; restored → 10/10 | | wider run: agent message components, `agentPaywallPresentation`, `AgentPanelRoot`, `platform/billing` | **157 files, 4352 tests, all pass** | Also checked: `git grep` over the whole tree, including the `browser_tests` fixture and spec tree, for both the full old sentence and the `keep the agent running` fragment — the only remaining uses of that fragment are the unrelated `subscribed` body, which this PR does not touch. Cherry-pick hunks diffed against `aa8c1610ac` — identical. Only `en` changes; other locales regenerate on the release version-bump PR, as upstream did. ## The merge-ordering hazard this PR was held as a draft for is resolved This branch was cut before #22991 merged, and the two were incompatible in either merge order because `Core release branches` sets `strict: false`, so a stale head can merge and redden the branch. #22991 merged first (`0d3fc943`, 10:31:41Z), this branch is now rebased on top of it, and commit 2 aligns the expectation it added. Nothing is left to sequence.
Manual backport of #22979 to
cloud/1.59, the build cloud.comfy.org serves. On 1.59 a Cloud account with no plan that can top up resolves to thesubscribedpaywall and sees only Add credits, which is how report #2 in PM-2273 happened.Conflict resolution:
useTopUpPlanCreditCopy.ts: same as the cloud/1.60 port. Adds exportedTOP_UP_PLAN_CREDIT_LINE_KEYSandusePlanCreditLine(); nouseAddCreditsPlanLine(not on 1.59).agentPaywallPresentation.ts: kept 1.59's@/platform/telemetry/typesimport; added theplanCreditLinepresentation field and resolver branch from fix(agent): say Add credits does not start a Cloud plan on the agent paywall #22979.AgentPaywallCard.vue: kept 1.59's localCard/Buttonimports and itsshowAddCreditsrule (1.59 has notoAgentPaywallRemediation).showSubscribeissubscriptionRequired || hasNoPlan, as on main.AgentPausedCard.vueand its test: dropped. The no-funds pause card does not exist on 1.59.Refs PM-2273.