Repository navigation
[backport cloud/1.60] fix(agent): say Add credits does not start a Cloud plan on the agent paywall (#22979) - #22990
Conversation
…paywall (#22979) A Cloud owner without a plan can top up, so the agent's **Out of credits** card offered **Add credits** and said the workspace "has spent its monthly credits". Credits bought there fund the agent but not workflow runs, and nothing said so before the purchase. A user reported exactly this: the agent sent them to buy credits, they got a budget approval, then found they needed a subscription and had to ask again (PM-2273, report #2). When the Add credits plan line applies (Cloud, no plan or an ended plan, can top up), the card now: - uses the no-plan body ("Your account has no credits available for the agent. Add credits to use it.") instead of the monthly-credits sentence, and - adds the same plan-required line the Add credits dialog shows, for example "Buying credits doesn't start a Cloud plan. Subscribe to keep running workflows once your free runs are used.", and - offers **Subscribe** (secondary) next to **Add credits**, without **Upgrade plan**. The line applies only when the owner can subscribe self-serve. The no-funds pause card, which also offers Add credits, shows the same line. Subscribed owners, members, sales-managed workspaces and Local are unchanged. No new strings: the copy is the already-translated `credits.topUp.planRequired*` set. Refs PM-2273. - `agentPaywallPresentation`: the `subscribed` presentation carries an optional `planCreditLine`. - `AgentPanelRoot` reads it from the existing `usePlanCreditLine()` (now exported from `useTopUpPlanCreditCopy`). - `AgentPaywallPlanNote` renders the line (`data-testid="agent-paywall-plan-note"`); `AgentPaywallCard` and `AgentPausedCard` (no-funds pauses) use it. The paywall card switches the body and CTAs. - Story `NoPlan` added. - Red/green unit: `agentPaywallPresentation.test.ts`, `AgentPaywallCard.test.ts`, `AgentPausedCard.test.ts` (failed before the change, pass after). - Integration: `AgentPanelRoot.test.ts`, a free owner without a plan sees the note under the card; an owner with a plan does not. - Cloud e2e + screenshot: `agentPaywallPlanNote.spec.ts` drives a real no-funds turn for a never-subscribed account and snapshots the card (`agent-paywall-plan-note.png`). The baseline is the CI image (8ff93b4):  The body here is the server's no-funds message, which overrides the card's own body; the plan line and the Subscribe + Add credits actions sit below it. - Local: agent panel, paywall and billing suites pass (898 tests in the agent subset); typecheck and server-facts gate clean. Known limit, left as is: before billing finishes loading, the card can briefly show Add credits without the line. The paywall needs a refused turn first, by which point billing has loaded. (cherry picked from commit 126e215)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-05T10:02:47.133Z",
"gitSha": "48ed09a48470cb7bdd260822345087a4b2919c39",
"branch": "backport-22979-to-cloud-1.60",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.265000000004,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.793,
"layouts": 10,
"layoutDurationMs": 2.356,
"taskDurationMs": 358.53200000000004,
"heapDeltaBytes": 8299108,
"heapUsedBytes": 69970072,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 9.37,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999955
},
{
"name": "canvas-idle",
"durationMs": 2024.772999999982,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.9090000000000003,
"layouts": 11,
"layoutDurationMs": 2.6560000000000006,
"taskDurationMs": 347.187,
"heapDeltaBytes": -23346504,
"heapUsedBytes": 54164540,
"domNodes": -178,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 6.715000000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.3320000000076,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.595999999999998,
"layouts": 9,
"layoutDurationMs": 2.3110000000000004,
"taskDurationMs": 659.4069999999999,
"heapDeltaBytes": -7037308,
"heapUsedBytes": 55566084,
"domNodes": -178,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 115.09,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666664,
"p95FrameDurationMs": 16.799999999999955
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1728.6900000000287,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.696,
"layouts": 10,
"layoutDurationMs": 2.169,
"taskDurationMs": 558.081,
"heapDeltaBytes": -15081512,
"heapUsedBytes": 62749080,
"domNodes": -178,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 95.182,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.2599999999957,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.968999999999999,
"layouts": 12,
"layoutDurationMs": 2.9190000000000005,
"taskDurationMs": 286.763,
"heapDeltaBytes": 1654016,
"heapUsedBytes": 63661088,
"domNodes": 57,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 11.774999999999999,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.047000000055,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.55,
"layouts": 13,
"layoutDurationMs": 2.8200000000000003,
"taskDurationMs": 250.52399999999997,
"heapDeltaBytes": -1647492,
"heapUsedBytes": 65863524,
"domNodes": 57,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 9.418000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 510.31299999999646,
"styleRecalcs": 16,
"styleRecalcDurationMs": 3.0820000000000003,
"layouts": 11,
"layoutDurationMs": 2.6870000000000003,
"taskDurationMs": 339.911,
"heapDeltaBytes": -15540552,
"heapUsedBytes": 61928724,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 112.159,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664516129032254,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 416.8160000000398,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.7410000000000005,
"layouts": 10,
"layoutDurationMs": 2.263,
"taskDurationMs": 303.82300000000004,
"heapDeltaBytes": 8006388,
"heapUsedBytes": 70854300,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 103.048,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668000000000003,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 890.4369999999631,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.072,
"heapDeltaBytes": -10908308,
"heapUsedBytes": 77393052,
"domNodes": -208,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 35.60200000000001,
"eventListeners": -107,
"totalBlockingTimeMs": 261,
"frameDurationMs": 25.711428571428574,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 965.8689999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 622.661,
"heapDeltaBytes": -11757308,
"heapUsedBytes": 77800376,
"domNodes": -208,
"jsHeapTotalBytes": 22552576,
"scriptDurationMs": 42.172000000000004,
"eventListeners": -107,
"totalBlockingTimeMs": 314,
"frameDurationMs": 27.617142857142866,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 718.2489999999575,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.71700000000016,
"heapDeltaBytes": -18683160,
"heapUsedBytes": 68404984,
"domNodes": -208,
"jsHeapTotalBytes": 2490368,
"scriptDurationMs": 98.79300000000002,
"eventListeners": -107,
"totalBlockingTimeMs": 87,
"frameDurationMs": 20.474285714285724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 702.7110000000221,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 285.29599999999976,
"heapDeltaBytes": 92384,
"heapUsedBytes": 82070508,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 95.574,
"eventListeners": 0,
"totalBlockingTimeMs": 86,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6256.799999999998,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.8850000000000003,
"layouts": 4,
"layoutDurationMs": 0.9889999999999999,
"taskDurationMs": 5129.264,
"heapDeltaBytes": 52992596,
"heapUsedBytes": 129476504,
"domNodes": -274,
"jsHeapTotalBytes": 46788608,
"scriptDurationMs": 3830.36,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.634375,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6307.114000000012,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.8780000000000003,
"layouts": 3,
"layoutDurationMs": 0.6859999999999999,
"taskDurationMs": 5139.71,
"heapDeltaBytes": 59113324,
"heapUsedBytes": 134999872,
"domNodes": -274,
"jsHeapTotalBytes": 55963648,
"scriptDurationMs": 3895.491,
"eventListeners": -69,
"totalBlockingTimeMs": 1,
"frameDurationMs": 19.435384615384613,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6570.290999999997,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8659999999999995,
"layouts": 3,
"layoutDurationMs": 0.673,
"taskDurationMs": 5472.629,
"heapDeltaBytes": 37909668,
"heapUsedBytes": 132876476,
"domNodes": -274,
"jsHeapTotalBytes": 66973696,
"scriptDurationMs": 4160.097000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 17,
"frameDurationMs": 19.838368580060422,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6486.114000000043,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.1090000000000007,
"layouts": 4,
"layoutDurationMs": 0.8930000000000001,
"taskDurationMs": 5495.5289999999995,
"heapDeltaBytes": 46690864,
"heapUsedBytes": 129020208,
"domNodes": -274,
"jsHeapTotalBytes": 60420096,
"scriptDurationMs": 4227.58,
"eventListeners": -69,
"totalBlockingTimeMs": 2,
"frameDurationMs": 21.049025974025973,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 154.11000000000286,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.059,
"layouts": 12,
"layoutDurationMs": 2.994,
"taskDurationMs": 108.686,
"heapDeltaBytes": 14826876,
"heapUsedBytes": 91030904,
"domNodes": 936,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.2459999999999996,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.41428571428573,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 156.45399999999654,
"styleRecalcs": 23,
"styleRecalcDurationMs": 11.094,
"layouts": 13,
"layoutDurationMs": 2.986,
"taskDurationMs": 111.78200000000001,
"heapDeltaBytes": 14808896,
"heapUsedBytes": 92261544,
"domNodes": 936,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.124999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.73750000000001,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2025.7680000000278,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.88,
"layouts": 9,
"layoutDurationMs": 2.4200000000000004,
"taskDurationMs": 496.095,
"heapDeltaBytes": -5084412,
"heapUsedBytes": 84130416,
"domNodes": -274,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 30.144,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2010.0029999999833,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.9069999999999998,
"layouts": 9,
"layoutDurationMs": 1.6490000000000002,
"taskDurationMs": 365.956,
"heapDeltaBytes": -30152244,
"heapUsedBytes": 60876612,
"domNodes": -274,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 20.451999999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2832.981000000018,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.879,
"layouts": 9,
"layoutDurationMs": 2.2640000000000002,
"taskDurationMs": 1257.726,
"heapDeltaBytes": -20572824,
"heapUsedBytes": 63321472,
"domNodes": -274,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 591.1610000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666470588235292,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2348.423999999909,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.479,
"layouts": 9,
"layoutDurationMs": 1.9680000000000002,
"taskDurationMs": 1149.714,
"heapDeltaBytes": -27794472,
"heapUsedBytes": 63094728,
"domNodes": -274,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 585.4110000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3705.039999999997,
"styleRecalcs": 74,
"styleRecalcDurationMs": 11.467999999999998,
"layouts": 67,
"layoutDurationMs": 11.298,
"taskDurationMs": 1312.9569999999999,
"heapDeltaBytes": -7033944,
"heapUsedBytes": 79106508,
"domNodes": -250,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 573.275,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666216216216217,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3389.2940000000635,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.453000000000001,
"layouts": 67,
"layoutDurationMs": 10.664,
"taskDurationMs": 1197.185,
"heapDeltaBytes": -20607144,
"heapUsedBytes": 61655244,
"domNodes": -250,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 513.112,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509802,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3028.2169999999837,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.472,
"layouts": 7,
"layoutDurationMs": 1.9400000000000004,
"taskDurationMs": 1478.2640000000001,
"heapDeltaBytes": -6065340,
"heapUsedBytes": 78180408,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 725.317,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665934065934064,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2270.8470000000034,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.746,
"layouts": 7,
"layoutDurationMs": 1.5079999999999998,
"taskDurationMs": 1186.0919999999999,
"heapDeltaBytes": -10711624,
"heapUsedBytes": 78380388,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 608.905,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66544117647059,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2795.611000000008,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4280000000000004,
"layouts": 8,
"layoutDurationMs": 1.92,
"taskDurationMs": 475.538,
"heapDeltaBytes": 1545360,
"heapUsedBytes": 93192268,
"domNodes": 0,
"jsHeapTotalBytes": 4755456,
"scriptDurationMs": 232.237,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66547619047619,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2839.328999999964,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9290000000000003,
"layouts": 8,
"layoutDurationMs": 1.632,
"taskDurationMs": 477.68600000000004,
"heapDeltaBytes": -20162864,
"heapUsedBytes": 72240072,
"domNodes": 0,
"jsHeapTotalBytes": 4493312,
"scriptDurationMs": 235.836,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665882352941175,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2022.1240000000194,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.719,
"layouts": 10,
"layoutDurationMs": 2.3930000000000002,
"taskDurationMs": 474.235,
"heapDeltaBytes": -10603480,
"heapUsedBytes": 74117476,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 29.616999999999997,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2021.3769999999158,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.3810000000000002,
"layouts": 10,
"layoutDurationMs": 2.115,
"taskDurationMs": 413.31200000000007,
"heapDeltaBytes": -30043008,
"heapUsedBytes": 62449896,
"domNodes": -274,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 25.337,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2677.489000000037,
"styleRecalcs": 28,
"styleRecalcDurationMs": 10.578,
"layouts": 8,
"layoutDurationMs": 1.814,
"taskDurationMs": 406.92100000000005,
"heapDeltaBytes": -4108320,
"heapUsedBytes": 80097724,
"domNodes": -263,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 127.37199999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66583850931677,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2706.467000000032,
"styleRecalcs": 28,
"styleRecalcDurationMs": 12.026000000000002,
"layouts": 8,
"layoutDurationMs": 1.6849999999999998,
"taskDurationMs": 426.582,
"heapDeltaBytes": -7033144,
"heapUsedBytes": 65668472,
"domNodes": -259,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 137.88,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666257668711655,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 2906.3620000000014,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2379999999999995,
"layouts": 9,
"layoutDurationMs": 2.0540000000000003,
"taskDurationMs": 587.1570000000002,
"heapDeltaBytes": -8165000,
"heapUsedBytes": 76426708,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 237.81199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 2956.3510000000406,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9469999999999998,
"layouts": 8,
"layoutDurationMs": 1.629,
"taskDurationMs": 649.7460000000001,
"heapDeltaBytes": -22098672,
"heapUsedBytes": 63205596,
"domNodes": -274,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 251.515,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915255,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 441.1319999999819,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.535000000000001,
"layouts": 10,
"layoutDurationMs": 2.418,
"taskDurationMs": 305.022,
"heapDeltaBytes": 24755588,
"heapUsedBytes": 88027544,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 102.41699999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661538461538456,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 443.6329999999771,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.3740000000000006,
"layouts": 10,
"layoutDurationMs": 2.386,
"taskDurationMs": 296.0930000000001,
"heapDeltaBytes": 23474168,
"heapUsedBytes": 85448828,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 95.917,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670370370370367,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2021.1139999999546,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.614,
"layouts": 9,
"layoutDurationMs": 2.215,
"taskDurationMs": 395.23699999999997,
"heapDeltaBytes": 4639236,
"heapUsedBytes": 65746680,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 10.790000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.8800000000665,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.2920000000000003,
"layouts": 11,
"layoutDurationMs": 2.1910000000000003,
"taskDurationMs": 320.40999999999997,
"heapDeltaBytes": -4627600,
"heapUsedBytes": 58396496,
"domNodes": -200,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 4.902,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.6390000000324,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.517000000000003,
"layouts": 9,
"layoutDurationMs": 2.12,
"taskDurationMs": 606.839,
"heapDeltaBytes": 23397488,
"heapUsedBytes": 85336360,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 92.087,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.3510000000779,
"styleRecalcs": 75,
"styleRecalcDurationMs": 11.544,
"layouts": 10,
"layoutDurationMs": 2.059,
"taskDurationMs": 512.8439999999999,
"heapDeltaBytes": -9964164,
"heapUsedBytes": 53346344,
"domNodes": -192,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 70.199,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509802,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1283.9529999999968,
"styleRecalcs": 21,
"styleRecalcDurationMs": 16.941000000000003,
"layouts": 5,
"layoutDurationMs": 10.527000000000001,
"taskDurationMs": 860.7389999999999,
"heapDeltaBytes": 18251992,
"heapUsedBytes": 100122024,
"domNodes": 19229,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 24.589,
"eventListeners": 3566,
"totalBlockingTimeMs": 117,
"frameDurationMs": 18.872058823529414,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10060.528999999973,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.172999999999995,
"layouts": 10,
"layoutDurationMs": 2.326,
"taskDurationMs": 4563.674,
"heapDeltaBytes": -4963752,
"heapUsedBytes": 84279616,
"domNodes": -274,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 2176.167,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665894039735097,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8423.199000000068,
"styleRecalcs": 250,
"styleRecalcDurationMs": 33.501000000000005,
"layouts": 10,
"layoutDurationMs": 2.275,
"taskDurationMs": 3956.115,
"heapDeltaBytes": -5736164,
"heapUsedBytes": 77814296,
"domNodes": -274,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 1890.444,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66600790513834,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16368.295999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15390.108,
"heapDeltaBytes": -21162504,
"heapUsedBytes": 268946612,
"domNodes": -3482,
"jsHeapTotalBytes": 18071552,
"scriptDurationMs": 216.95600000000002,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.26614853195164,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 15727.209000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14787.352,
"heapDeltaBytes": -22980968,
"heapUsedBytes": 286696236,
"domNodes": -3482,
"jsHeapTotalBytes": 47964160,
"scriptDurationMs": 188.942,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.801873935264055,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 18543.172999999966,
"styleRecalcs": 147,
"styleRecalcDurationMs": 17.928,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18132.272999999997,
"heapDeltaBytes": -24086820,
"heapUsedBytes": 273558752,
"domNodes": -3482,
"jsHeapTotalBytes": 17022976,
"scriptDurationMs": 639.656,
"eventListeners": -659,
"totalBlockingTimeMs": 9,
"frameDurationMs": 34.383302411873835,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 18488.26399999996,
"styleRecalcs": 153,
"styleRecalcDurationMs": 16.184000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18007.532000000003,
"heapDeltaBytes": -24734056,
"heapUsedBytes": 272868636,
"domNodes": -3482,
"jsHeapTotalBytes": 16506880,
"scriptDurationMs": 601.672,
"eventListeners": -659,
"totalBlockingTimeMs": 4,
"frameDurationMs": 33.75784671532847,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5910.437000000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 43.294,
"layouts": 20,
"layoutDurationMs": 21.76600000000001,
"taskDurationMs": 5791.392999999999,
"heapDeltaBytes": -17235444,
"heapUsedBytes": 270845088,
"domNodes": -3482,
"jsHeapTotalBytes": 37736448,
"scriptDurationMs": 86.44000000000001,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.39767441860465,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5520.757000000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 39.469,
"layouts": 20,
"layoutDurationMs": 19.072999999999993,
"taskDurationMs": 5415.909,
"heapDeltaBytes": -22583872,
"heapUsedBytes": 267755564,
"domNodes": -3482,
"jsHeapTotalBytes": 36425728,
"scriptDurationMs": 80.362,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.74082840236686,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8321.475999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7847.2649999999985,
"heapDeltaBytes": -24880428,
"heapUsedBytes": 264561568,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 106.47500000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.190847457627115,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8254.575999999928,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7730.188000000002,
"heapDeltaBytes": 5509152,
"heapUsedBytes": 281286300,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 105.44999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.021355932203388,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 85.46899999998914,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.501999999999999,
"layouts": 5,
"layoutDurationMs": 1.7810000000000001,
"taskDurationMs": 59.76999999999999,
"heapDeltaBytes": 5013048,
"heapUsedBytes": 66403344,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.252000000000001,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.659999999999947,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 90.4369999999517,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.261000000000001,
"layouts": 6,
"layoutDurationMs": 1.9489999999999998,
"taskDurationMs": 59.58400000000001,
"heapDeltaBytes": -11858016,
"heapUsedBytes": 64218872,
"domNodes": 125,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 5.013000000000001,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 206.16200000006302,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.732,
"layouts": 76,
"layoutDurationMs": 9.863,
"taskDurationMs": 175.757,
"heapDeltaBytes": 10377856,
"heapUsedBytes": 53037964,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 74.421,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230754,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 221.25500000004195,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.578,
"layouts": 76,
"layoutDurationMs": 10.51,
"taskDurationMs": 186.004,
"heapDeltaBytes": -5941976,
"heapUsedBytes": 37834964,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 76.226,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428578,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 361.19399999995494,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.309,
"layouts": 76,
"layoutDurationMs": 13.764,
"taskDurationMs": 336.12,
"heapDeltaBytes": -583476,
"heapUsedBytes": 95055640,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 120.821,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66818181818181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 227.59900000005473,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.2069999999999999,
"layouts": 76,
"layoutDurationMs": 9.431000000000001,
"taskDurationMs": 203.91799999999998,
"heapDeltaBytes": -1751632,
"heapUsedBytes": 90179460,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 66.536,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.699999999999818
}
]
}🎭 Playwright: ✅ 3225 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3b436b967da7fefc06af246435ed8b6a5f8866cc
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (356)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
This comment has been minimized.
This comment has been minimized.
dante01yoon
left a comment
There was a problem hiding this comment.
Approved as a backport of #22979 to cloud/1.60, per the requested backport policy. No code-change review or local tests performed. CI is still running.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.60 #22990 +/- ##
=============================================
Coverage ? 87.52%
=============================================
Files ? 2892
Lines ? 159689
Branches ? 42791
=============================================
Hits ? 139765
Misses ? 19161
Partials ? 763
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #22979 to
cloud/1.60.The auto-backport conflicted in one file,
useTopUpPlanCreditCopy.ts:cloud/1.60has nouseAddCreditsPlanLine/ADD_CREDITS_LINES(Add credits plan-line fact from main). Resolution keeps the release branch's surface and adds only what #22979 needs: exportedTOP_UP_PLAN_CREDIT_LINE_KEYSandusePlanCreditLine(), withuseTopUpPlanCreditCopy()built on it. Behavior of the Add credits line is unchanged. All other files applied cleanly.Refs PM-2273.