Repository navigation
[backport cloud/1.59] fix(billing): explain locked credits on Subscribe to Run for an inactive account with funds (#22976) - #22988
Conversation
…ive account with funds (#22976) An inactive Cloud account that holds credits (it never had a plan, or its plan ended, and it topped up) is blocked on the client before any server refusal, so it never saw the locked-credits line from #22514. The run block in `useCoreCommands` and the **Subscribe to Run** button now pass `creditsLocked` for such an account, so the subscribe dialog says why the credits did not unlock runs. Fixes FRONT-3758. Refs PM-2273, FRONT-3662. - `subscribeToRunDialogOptions({ subscriptionState, hasFunds })`: one helper for both paths. It sets `creditsLocked: true` only when `has_funds` is true and the server-owned `subscription_state` is `never_subscribed` or `ended`, the same states the Add credits plan line renders. Paused, past-due, activating, active and unknown states get the plain dialog. - The check is wrapped in `pendingServerFact('BE-24447', …)`: billing status does not serve `credits_locked` yet (the 402 refusal does). BE-24447 now also asks for it on `GET /api/billing/status`. - The notice itself is unchanged (`CreditsLockedNotice`, existing translated copy, resubscribe wording for `ended`). No new strings. - Red/green: the new cases in `useCoreCommands.test.ts`, `SubscribeToRun.test.ts` and `subscribeToRunDialogOptions.test.ts` failed before the fix and pass after it. - Cloud e2e (`cloudCreditsLockedRefusal.spec.ts`): an ended plan with funds clicks Subscribe to Run and sees the full resubscribe line; without funds it does not. - Local: billing, actionbar and linear-mode suites pass; typecheck and server-facts gate clean. Placement is unchanged (same notice slot as #22514), so there is no new screenshot baseline. Review notes: a fresh Claude adversarial reviewer and the PR reviewers flagged the client-side derivation (ADR-0042) and inactive-for-other-reasons states (paused, past due). Both are handled by the `subscription_state` gate and the `pendingServerFact` wrapper. Known limit: `has_funds` also counts granted credits, so a lapsed subscriber holding only granted credits reads "Buying credits doesn't restart your Cloud plan". That sentence is still true for them; the served `credits_locked` (BE-24447) will make it exact. --------- Co-authored-by: GitHub Action <action@github.com> (cherry picked from commit 92bb421)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 8 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-05T09:42:56.870Z",
"gitSha": "0515aa2a30a128b4a05ccd86d1abf515f9a1fcaa",
"branch": "backport-22976-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.791999999995,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.2909999999999995,
"layouts": 10,
"layoutDurationMs": 2.385,
"taskDurationMs": 452.253,
"heapDeltaBytes": 5220832,
"heapUsedBytes": 76011800,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 9.434,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2022.137999999984,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.033,
"layouts": 9,
"layoutDurationMs": 2.003,
"taskDurationMs": 446.20699999999994,
"heapDeltaBytes": 4039756,
"heapUsedBytes": 65356956,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 9.373999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.7549999999865,
"styleRecalcs": 72,
"styleRecalcDurationMs": 11.540000000000001,
"layouts": 10,
"layoutDurationMs": 2.313,
"taskDurationMs": 723.943,
"heapDeltaBytes": 17712404,
"heapUsedBytes": 79423884,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 124.017,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.5889999999745,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.283000000000001,
"layouts": 7,
"layoutDurationMs": 1.4590000000000003,
"taskDurationMs": 708.26,
"heapDeltaBytes": 21951744,
"heapUsedBytes": 83669992,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 118.03400000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.5999999999622,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.288,
"layouts": 11,
"layoutDurationMs": 2.702,
"taskDurationMs": 362.977,
"heapDeltaBytes": -183324,
"heapUsedBytes": 70094712,
"domNodes": 56,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 10.926000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.6870000000272,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.823999999999999,
"layouts": 11,
"layoutDurationMs": 2.6290000000000004,
"taskDurationMs": 363.877,
"heapDeltaBytes": 228168,
"heapUsedBytes": 77990612,
"domNodes": 56,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 11.378,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 615.6939999999906,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.313,
"layouts": 10,
"layoutDurationMs": 2.3469999999999995,
"taskDurationMs": 430.84000000000003,
"heapDeltaBytes": 5721320,
"heapUsedBytes": 68186416,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 145.97899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 569.4910000000277,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.737,
"layouts": 9,
"layoutDurationMs": 2.1879999999999997,
"taskDurationMs": 419.6240000000001,
"heapDeltaBytes": 2974604,
"heapUsedBytes": 65263616,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 142.769,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1065.384000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 723.3859999999999,
"heapDeltaBytes": 17570408,
"heapUsedBytes": 87748800,
"domNodes": 0,
"jsHeapTotalBytes": 13008896,
"scriptDurationMs": 48.484,
"eventListeners": 0,
"totalBlockingTimeMs": 442,
"frameDurationMs": 32.321212121212135,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1117.0999999999935,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 787.7180000000001,
"heapDeltaBytes": -12131184,
"heapUsedBytes": 76083960,
"domNodes": -191,
"jsHeapTotalBytes": 21766144,
"scriptDurationMs": 57.24399999999999,
"eventListeners": -107,
"totalBlockingTimeMs": 442,
"frameDurationMs": 31.016666666666666,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 762.8630000000101,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.15,
"heapDeltaBytes": -5649296,
"heapUsedBytes": 69610704,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 119.66399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 142,
"frameDurationMs": 22.547058823529397,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 763.7040000000184,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.539,
"heapDeltaBytes": 23142916,
"heapUsedBytes": 86124836,
"domNodes": -191,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 117.29099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 137,
"frameDurationMs": 22.549999999999994,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9293.835000000001,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.4349999999999996,
"layouts": 2,
"layoutDurationMs": 0.41399999999999987,
"taskDurationMs": 8297.774000000001,
"heapDeltaBytes": 61566376,
"heapUsedBytes": 144602436,
"domNodes": -257,
"jsHeapTotalBytes": 69070848,
"scriptDurationMs": 6339.883,
"eventListeners": -69,
"totalBlockingTimeMs": 182,
"frameDurationMs": 26.646704871060173,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8038.477999999997,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.2009999999999998,
"layouts": 1,
"layoutDurationMs": 0.2750000000000001,
"taskDurationMs": 7222.983,
"heapDeltaBytes": 67639156,
"heapUsedBytes": 141776024,
"domNodes": -257,
"jsHeapTotalBytes": 61730816,
"scriptDurationMs": 5478.916,
"eventListeners": -69,
"totalBlockingTimeMs": 62,
"frameDurationMs": 24.565749235474005,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8607.731999999998,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.26099999999999995,
"layouts": 1,
"layoutDurationMs": 0.20700000000000016,
"taskDurationMs": 7772.076999999999,
"heapDeltaBytes": 63819940,
"heapUsedBytes": 135834272,
"domNodes": -257,
"jsHeapTotalBytes": 63041536,
"scriptDurationMs": 5913.247,
"eventListeners": -69,
"totalBlockingTimeMs": 175,
"frameDurationMs": 25.416814159292038,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8106.885999999975,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.26200000000000007,
"layouts": 1,
"layoutDurationMs": 0.29999999999999993,
"taskDurationMs": 7296.296,
"heapDeltaBytes": 64440884,
"heapUsedBytes": 138421160,
"domNodes": -257,
"jsHeapTotalBytes": 66711552,
"scriptDurationMs": 5522.054,
"eventListeners": -69,
"totalBlockingTimeMs": 67,
"frameDurationMs": 24.39668674698795,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "large-combo-open",
"durationMs": 227.52700000000914,
"styleRecalcs": 24,
"styleRecalcDurationMs": 12.562,
"layouts": 11,
"layoutDurationMs": 2.8069999999999995,
"taskDurationMs": 182.66,
"heapDeltaBytes": 14492992,
"heapUsedBytes": 90441500,
"domNodes": 936,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 11.103,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.833333333333332,
"p95FrameDurationMs": 66.59999999999991
},
{
"name": "large-combo-open",
"durationMs": 207.22599999999147,
"styleRecalcs": 23,
"styleRecalcDurationMs": 12.063999999999998,
"layouts": 10,
"layoutDurationMs": 2.7239999999999998,
"taskDurationMs": 170.68499999999997,
"heapDeltaBytes": 14430928,
"heapUsedBytes": 90764808,
"domNodes": 936,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 7.432999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.22222222222222,
"p95FrameDurationMs": 66.70000000000027
},
{
"name": "large-graph-idle",
"durationMs": 2042.226999999997,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.0619999999999994,
"layouts": 7,
"layoutDurationMs": 1.8950000000000002,
"taskDurationMs": 549.2540000000001,
"heapDeltaBytes": -4951980,
"heapUsedBytes": 68101900,
"domNodes": -257,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 33.577,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2024.360999999999,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.6109999999999995,
"layouts": 8,
"layoutDurationMs": 1.5180000000000002,
"taskDurationMs": 542.485,
"heapDeltaBytes": -30433860,
"heapUsedBytes": 61176472,
"domNodes": -257,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 29.555,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2206.894000000034,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.587000000000002,
"layouts": 9,
"layoutDurationMs": 1.924,
"taskDurationMs": 1464.557,
"heapDeltaBytes": -28821220,
"heapUsedBytes": 62413000,
"domNodes": -257,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 686.0319999999999,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2203.989999999976,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.528,
"layouts": 7,
"layoutDurationMs": 1.517,
"taskDurationMs": 1437.0569999999998,
"heapDeltaBytes": -18746720,
"heapUsedBytes": 62419760,
"domNodes": -257,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 668.432,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909093,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3390.0600000000054,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.641000000000002,
"layouts": 65,
"layoutDurationMs": 11.487,
"taskDurationMs": 1604.8029999999999,
"heapDeltaBytes": -12840384,
"heapUsedBytes": 80166636,
"domNodes": -233,
"jsHeapTotalBytes": 6193152,
"scriptDurationMs": 676.9099999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666502463054186,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3424.607999999978,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.78,
"layouts": 64,
"layoutDurationMs": 11.497,
"taskDurationMs": 1632.0650000000003,
"heapDeltaBytes": 3108904,
"heapUsedBytes": 80665728,
"domNodes": -233,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 676.3939999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666341463414636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2573.162000000025,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.441,
"layouts": 7,
"layoutDurationMs": 1.3579999999999999,
"taskDurationMs": 1687.268,
"heapDeltaBytes": 15339836,
"heapUsedBytes": 94844480,
"domNodes": 0,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 805.278,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.885526315789473,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2405.407000000025,
"styleRecalcs": 41,
"styleRecalcDurationMs": 4.383,
"layouts": 2,
"layoutDurationMs": 0.3640000000000006,
"taskDurationMs": 1623.662,
"heapDeltaBytes": 5982532,
"heapUsedBytes": 68681812,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 790.134,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.901408450704224,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3038.521000000003,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.5970000000000004,
"layouts": 7,
"layoutDurationMs": 1.626,
"taskDurationMs": 729.8950000000001,
"heapDeltaBytes": -21207868,
"heapUsedBytes": 72839752,
"domNodes": -257,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 325.81000000000006,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665934065934067,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3047.1280000000434,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.2599999999999998,
"layouts": 7,
"layoutDurationMs": 1.356,
"taskDurationMs": 722.2379999999999,
"heapDeltaBytes": -1605468,
"heapUsedBytes": 75830524,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 335.38,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666120218579234,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2031.8979999999556,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.4659999999999995,
"layouts": 7,
"layoutDurationMs": 1.5779999999999998,
"taskDurationMs": 552.82,
"heapDeltaBytes": -16932892,
"heapUsedBytes": 62433184,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 29.895999999999994,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2032.1400000000267,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.5580000000000003,
"layouts": 7,
"layoutDurationMs": 1.5850000000000002,
"taskDurationMs": 559.329,
"heapDeltaBytes": -13762396,
"heapUsedBytes": 64120868,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 31.738000000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2724.694999999997,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.657,
"layouts": 7,
"layoutDurationMs": 1.395,
"taskDurationMs": 557.2370000000001,
"heapDeltaBytes": 3026720,
"heapUsedBytes": 79715704,
"domNodes": -238,
"jsHeapTotalBytes": 1437696,
"scriptDurationMs": 172.203,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7680981595092,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2708.8750000000346,
"styleRecalcs": 28,
"styleRecalcDurationMs": 11.56,
"layouts": 8,
"layoutDurationMs": 4.078,
"taskDurationMs": 559.8900000000001,
"heapDeltaBytes": 1498356,
"heapUsedBytes": 83199048,
"domNodes": -238,
"jsHeapTotalBytes": 913408,
"scriptDurationMs": 156.23299999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66564417177914,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3212.1640000000016,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.5520000000000005,
"layouts": 7,
"layoutDurationMs": 1.5469999999999997,
"taskDurationMs": 883.985,
"heapDeltaBytes": -11230108,
"heapUsedBytes": 66507096,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 332.93,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666321243523317,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3170.979999999986,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.6490000000000002,
"layouts": 7,
"layoutDurationMs": 1.595,
"taskDurationMs": 867.3409999999999,
"heapDeltaBytes": 7921992,
"heapUsedBytes": 79711084,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 321.43399999999997,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684207,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 544.8880000000145,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.257000000000001,
"layouts": 10,
"layoutDurationMs": 2.038,
"taskDurationMs": 364.89,
"heapDeltaBytes": 594024,
"heapUsedBytes": 62958724,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 118.80499999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 558.7080000000242,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.071000000000001,
"layouts": 10,
"layoutDurationMs": 2.132,
"taskDurationMs": 375.945,
"heapDeltaBytes": -1083536,
"heapUsedBytes": 71852560,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 118.398,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2007.3509999999999,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.309,
"layouts": 10,
"layoutDurationMs": 2.2950000000000004,
"taskDurationMs": 441.2999999999999,
"heapDeltaBytes": 4812864,
"heapUsedBytes": 77030188,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 8.140999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2026.267999999959,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.164,
"layouts": 10,
"layoutDurationMs": 2.143,
"taskDurationMs": 485.92999999999995,
"heapDeltaBytes": -12978764,
"heapUsedBytes": 56831228,
"domNodes": -183,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 8.601,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.426000000007,
"styleRecalcs": 77,
"styleRecalcDurationMs": 11.245999999999999,
"layouts": 9,
"layoutDurationMs": 1.735,
"taskDurationMs": 695.4549999999999,
"heapDeltaBytes": 19821728,
"heapUsedBytes": 81755888,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 86.467,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.5009999999497,
"styleRecalcs": 75,
"styleRecalcDurationMs": 11.072000000000003,
"layouts": 9,
"layoutDurationMs": 1.814,
"taskDurationMs": 700.7220000000001,
"heapDeltaBytes": 17676532,
"heapUsedBytes": 80139084,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 85.975,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.2290000000048,
"styleRecalcs": 19,
"styleRecalcDurationMs": 18.075,
"layouts": 5,
"layoutDurationMs": 10.386,
"taskDurationMs": 899.917,
"heapDeltaBytes": 9493316,
"heapUsedBytes": 98405508,
"domNodes": 16030,
"jsHeapTotalBytes": 7999488,
"scriptDurationMs": 27.94,
"eventListeners": 3246,
"totalBlockingTimeMs": 146,
"frameDurationMs": 19.444444444444443,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8227.596000000005,
"styleRecalcs": 250,
"styleRecalcDurationMs": 29.154,
"layouts": 8,
"layoutDurationMs": 1.7630000000000001,
"taskDurationMs": 5112.915,
"heapDeltaBytes": -13264400,
"heapUsedBytes": 62068324,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 2220.057,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66612576064909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8241.911999999957,
"styleRecalcs": 249,
"styleRecalcDurationMs": 30.650999999999996,
"layouts": 6,
"layoutDurationMs": 1.2349999999999999,
"taskDurationMs": 5169.096,
"heapDeltaBytes": 2750912,
"heapUsedBytes": 75904116,
"domNodes": -257,
"jsHeapTotalBytes": -434176,
"scriptDurationMs": 2301.208,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66599190283401,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 19098.457999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18548.390000000003,
"heapDeltaBytes": -17512032,
"heapUsedBytes": 279223176,
"domNodes": -3343,
"jsHeapTotalBytes": 9162752,
"scriptDurationMs": 270.1,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.53684210526316,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 13451.905999999894,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12819.455000000002,
"heapDeltaBytes": -25324636,
"heapUsedBytes": 258751432,
"domNodes": -3343,
"jsHeapTotalBytes": 15978496,
"scriptDurationMs": 205.017,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.94029363784665,
"p95FrameDurationMs": 33.5
},
{
"name": "vue-large-graph-pan",
"durationMs": 16543.024,
"styleRecalcs": 97,
"styleRecalcDurationMs": 13.111999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15988.617999999999,
"heapDeltaBytes": -17944668,
"heapUsedBytes": 283877344,
"domNodes": -3343,
"jsHeapTotalBytes": 11976704,
"scriptDurationMs": 804.329,
"eventListeners": -651,
"totalBlockingTimeMs": 82,
"frameDurationMs": 29.741472172351884,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 21793.730000000098,
"styleRecalcs": 173,
"styleRecalcDurationMs": 20.38899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21424.087,
"heapDeltaBytes": -37179372,
"heapUsedBytes": 264859672,
"domNodes": -3343,
"jsHeapTotalBytes": 10735616,
"scriptDurationMs": 866.023,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.638992537313435,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6759.926000000007,
"styleRecalcs": 20,
"styleRecalcDurationMs": 52.172,
"layouts": 20,
"layoutDurationMs": 23.112999999999996,
"taskDurationMs": 6637.943,
"heapDeltaBytes": -518272,
"heapUsedBytes": 275980200,
"domNodes": -3343,
"jsHeapTotalBytes": 16769024,
"scriptDurationMs": 108.77199999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.01348314606742,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6766.92700000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 51.884000000000015,
"layouts": 20,
"layoutDurationMs": 23.612999999999996,
"taskDurationMs": 6642.097,
"heapDeltaBytes": 7195216,
"heapUsedBytes": 285234728,
"domNodes": -307,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 117.34599999999999,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.228248587570626,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9283.318000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9034.975999999999,
"heapDeltaBytes": 14876544,
"heapUsedBytes": 277116084,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 131.26900000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.15357142857143,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9479.058000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9125.837,
"heapDeltaBytes": 7627780,
"heapUsedBytes": 272665296,
"domNodes": -1,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 156.713,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.27368421052632,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 142.69200000001092,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.534,
"layouts": 11,
"layoutDurationMs": 4.002999999999999,
"taskDurationMs": 97.463,
"heapDeltaBytes": 4955648,
"heapUsedBytes": 67122140,
"domNodes": 136,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.995999999999999,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 128.2610000000659,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.502,
"layouts": 9,
"layoutDurationMs": 2.931,
"taskDurationMs": 87.799,
"heapDeltaBytes": -13294872,
"heapUsedBytes": 60847712,
"domNodes": 125,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 5.5840000000000005,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142844,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 365.462999999977,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.718,
"layouts": 76,
"layoutDurationMs": 13.103,
"taskDurationMs": 328.156,
"heapDeltaBytes": -4658956,
"heapUsedBytes": 37912544,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 147.46200000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66818181818181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 344.5400000000518,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.7110000000000001,
"layouts": 76,
"layoutDurationMs": 13.327,
"taskDurationMs": 314.957,
"heapDeltaBytes": -4854656,
"heapUsedBytes": 37801840,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 139.34099999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 463.5569999999234,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.618,
"layouts": 76,
"layoutDurationMs": 13.713,
"taskDurationMs": 423.262,
"heapDeltaBytes": 1000204,
"heapUsedBytes": 99651556,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.526,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 477.895999999987,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.618,
"layouts": 76,
"layoutDurationMs": 13.414,
"taskDurationMs": 436.26400000000007,
"heapDeltaBytes": 1108848,
"heapUsedBytes": 99728156,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 167.08399999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.699999999999818
}
]
}🎭 Playwright: ✅ 2702 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 8da66e6cd0e7f635283f2a58b0cdd973f477e785
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (282)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
This comment has been minimized.
This comment has been minimized.
dante01yoon
left a comment
There was a problem hiding this comment.
Approved as a backport, as requested. No code-change review or tests were run.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.59 #22988 +/- ##
=============================================
Coverage ? 87.25%
=============================================
Files ? 3068
Lines ? 160354
Branches ? 43032
=============================================
Hits ? 139917
Misses ? 19756
Partials ? 681
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Manual backport of #22976 to
cloud/1.59(the build production serves). The auto-backport hit conflicts.Conflicts resolved:
useCoreCommands.ts: cloud/1.59 has the older synchronousblockRunWithoutSubscription; kept it and added onlysubscriptionStateplus thesubscribeToRunDialogOptions(...)call.SubscribeToRun.vue/SubscribeToRun.test.ts: cloud/1.59 reads permissions fromuseWorkspaceUIand telemetry from@/platform/telemetry; kept those and added the billing-context import.useCoreCommands.test.ts: kept the 1.59 mock shape and addedhasFundsandsubscriptionState.Behavior matches #22976: a funded account whose served
subscription_stateisnever_subscribedorendedsees the locked-credits line from the run block and the Subscribe to Run button.Refs FRONT-3758, PM-2273.