Repository navigation
[backport cloud/1.59] fix(workflow): load a tab before saving it instead of failing (#22971) - #22983
Conversation
Saving a tab whose content was not loaded failed with "Cannot save workflow '<path>' before it is loaded". That is the guard from #21326, which stops the save from writing `null` over the file. On cloud production (1.59.5) it fires from the close dialog's **Save** on a saved file that was unloaded but still marked modified (Sentry `CLOUD-FRONTEND-PROD-394`, 12 events / 11 users), and from saves of unsaved tabs a reload restored without opening (`CLOUD-FRONTEND-PROD-393`, 34 / 32; the agent-picker part of that is [FRONT-3837](https://linear.app/comfyorg/issue/FRONT-3837). Changes: - `saveWorkflow` / `saveWorkflowAs` load an unloaded tab in the background first (the serialized load queue, as #22648 does for the picker), which applies its draft. This covers every caller: close dialog, Ctrl+S, autosave, workspace switch, picker. The guard in `ComfyWorkflow.save` stays as the backstop. - If loading finds no usable draft for a saved file marked modified, its edits were already gone: nothing is written, the modified mark is cleared, the user gets a warning toast ("Unsaved changes were not saved"), and it is reported (`Modified saved workflow lost its edits before saving`, static message, no path) so any remaining source stays visible. Before, the save failed; a plain write would have reported Save as done. - An **active** tab with no loaded content still hits the guard: a background copy is not what is on the canvas. - Root cause fixed for one path: workflow sync no longer unloads (or re-stamps) a **modified background tab** whose file changed remotely. Unloading made its draft older than the file, so the next load dropped the edits and left the modified mark, which is the state the close-dialog Save then failed on. The tab is now treated like the active one: its in-memory edits win until the user saves or discards them. - The guard's error message no longer contains the workflow path (alerts showed user file names in their titles). Design notes: - Sync keeping local edits means a remote change to a modified background tab (another device, the agent writing the file) is not shown until the user saves or discards. Saving then overwrites it, as it already does for the active tab. Before, the remote copy silently replaced the edits. - `discardSupersededLoad` is unchanged: it restores the pre-open state, and saving that state now loads first. - Red first: on `main` the new service tests failed with the exact production message ("Cannot save workflow 'workflows/background.json' before it is loaded"), and the sync test failed with the tab unloaded. - `workflowService.test.ts` "saving a tab that is not loaded": close-dialog Save writes the draft; direct save writes the draft; no usable draft writes nothing, warns and reports; an active unloaded tab still refuses; a restored unsaved tab closes through Save As and is written. - `workflowStore.test.ts`: a modified background tab keeps its edits and metadata through a sync with a changed file; an unmodified one is still unloaded; guard message is static. - Local: all `src/platform/workflow` tests and `useAgentWorkflowSelection.test.ts` pass (2360), `typecheck:app`, `oxlint --type-aware`, `oxfmt`. - Adversarial review (fresh reviewer): its majors are fixed in the second commit (no write when edits are gone, active tab keeps the guard, kept tab's draft stays usable, Save As loads after the prompt). - After release: `CLOUD-FRONTEND-PROD-394` and `-393` should stop on the release carrying this; any `Modified saved workflow lost its edits before saving` events show what else still drops edits. --------- Co-authored-by: GitHub Action <action@github.com> (cherry picked from commit 03bbb78)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-05T08:11:26.650Z",
"gitSha": "52fe13314e8d466c8fae5600fcdd7fd8e531ae3a",
"branch": "backport-22971-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.364000000005,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.513,
"layouts": 9,
"layoutDurationMs": 2.0610000000000004,
"taskDurationMs": 282.80899999999997,
"heapDeltaBytes": 4402092,
"heapUsedBytes": 66865940,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 5.4,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2025.8330000000342,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.283,
"layouts": 10,
"layoutDurationMs": 2.1590000000000003,
"taskDurationMs": 331.36199999999997,
"heapDeltaBytes": -11950112,
"heapUsedBytes": 60277280,
"domNodes": -161,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 5.903000000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.3110000000079,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.786,
"layouts": 10,
"layoutDurationMs": 2.202,
"taskDurationMs": 516.846,
"heapDeltaBytes": 21804692,
"heapUsedBytes": 83039900,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 94.09500000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1677.3680000000013,
"styleRecalcs": 73,
"styleRecalcDurationMs": 11.475,
"layouts": 10,
"layoutDurationMs": 2.855,
"taskDurationMs": 530.165,
"heapDeltaBytes": 24042968,
"heapUsedBytes": 87189384,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 97.172,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.2130000000013,
"styleRecalcs": 19,
"styleRecalcDurationMs": 3.5480000000000005,
"layouts": 11,
"layoutDurationMs": 2.339,
"taskDurationMs": 219.222,
"heapDeltaBytes": 320492,
"heapUsedBytes": 73670260,
"domNodes": 56,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 5.964,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.352000000024,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.954999999999999,
"layouts": 11,
"layoutDurationMs": 2.985,
"taskDurationMs": 290.50100000000003,
"heapDeltaBytes": 1812472,
"heapUsedBytes": 79861172,
"domNodes": 56,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 11.633999999999999,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 465.9990000000107,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.572,
"layouts": 9,
"layoutDurationMs": 2.1229999999999998,
"taskDurationMs": 298.60200000000003,
"heapDeltaBytes": 7661612,
"heapUsedBytes": 85601044,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 101.674,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 526.5500000000429,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.1229999999999998,
"layouts": 10,
"layoutDurationMs": 2.593,
"taskDurationMs": 329.097,
"heapDeltaBytes": 4043816,
"heapUsedBytes": 64353796,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 112.98899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000003,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 894.771999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.147,
"heapDeltaBytes": -15297480,
"heapUsedBytes": 74821476,
"domNodes": -191,
"jsHeapTotalBytes": 20193280,
"scriptDurationMs": 35.161,
"eventListeners": -107,
"totalBlockingTimeMs": 270,
"frameDurationMs": 26.46764705882353,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 910.9970000000089,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 548.317,
"heapDeltaBytes": 282396,
"heapUsedBytes": 76026412,
"domNodes": -191,
"jsHeapTotalBytes": 15474688,
"scriptDurationMs": 35.994,
"eventListeners": -107,
"totalBlockingTimeMs": 267,
"frameDurationMs": 25.46111111111111,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 687.3829999999828,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 268.70400000000006,
"heapDeltaBytes": -4455728,
"heapUsedBytes": 70457944,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 85.31800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 83,
"frameDurationMs": 20.58529411764705,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 700.1080000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 283.8790000000002,
"heapDeltaBytes": -3618636,
"heapUsedBytes": 66744496,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 92.943,
"eventListeners": 0,
"totalBlockingTimeMs": 91,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6402.0370000000075,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.0559999999999996,
"layouts": 4,
"layoutDurationMs": 0.9309999999999999,
"taskDurationMs": 5257.512999999999,
"heapDeltaBytes": 80157748,
"heapUsedBytes": 153544772,
"domNodes": -257,
"jsHeapTotalBytes": 67235840,
"scriptDurationMs": 4002.9709999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.451975683890577,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6558.366000000035,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.7329999999999993,
"layouts": 3,
"layoutDurationMs": 0.6389999999999998,
"taskDurationMs": 5386.495,
"heapDeltaBytes": 58804448,
"heapUsedBytes": 143322384,
"domNodes": -257,
"jsHeapTotalBytes": 78245888,
"scriptDurationMs": 4157.434,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.728012048192774,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5467.626999999993,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.855000000000001,
"layouts": 3,
"layoutDurationMs": 0.7369999999999998,
"taskDurationMs": 4573.305,
"heapDeltaBytes": -27191936,
"heapUsedBytes": 67021964,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 3482.643,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.41150159744409,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6288.283999999976,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.0230000000000006,
"layouts": 4,
"layoutDurationMs": 0.9369999999999999,
"taskDurationMs": 5176.939,
"heapDeltaBytes": 60034480,
"heapUsedBytes": 135896628,
"domNodes": -257,
"jsHeapTotalBytes": 59633664,
"scriptDurationMs": 3964.315,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.883227848101264,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 135.66499999998882,
"styleRecalcs": 21,
"styleRecalcDurationMs": 9.695,
"layouts": 12,
"layoutDurationMs": 2.561,
"taskDurationMs": 96.467,
"heapDeltaBytes": 14435276,
"heapUsedBytes": 85208564,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.283,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.028571428571468,
"p95FrameDurationMs": 33.20000000000027
},
{
"name": "large-combo-open",
"durationMs": 141.92500000001473,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.416,
"layouts": 12,
"layoutDurationMs": 3.0089999999999995,
"taskDurationMs": 107.98400000000001,
"heapDeltaBytes": -5592520,
"heapUsedBytes": 73360196,
"domNodes": 936,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 5.608999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.44285714285713,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2010.0989999999967,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.809,
"layouts": 9,
"layoutDurationMs": 1.618,
"taskDurationMs": 344.50299999999993,
"heapDeltaBytes": 9144152,
"heapUsedBytes": 83055644,
"domNodes": -257,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 17.901,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2025.2509999999688,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.176,
"layouts": 9,
"layoutDurationMs": 1.955,
"taskDurationMs": 389.04600000000005,
"heapDeltaBytes": -12642976,
"heapUsedBytes": 61939516,
"domNodes": -257,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 23.32,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2084.0809999999974,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.020000000000001,
"layouts": 9,
"layoutDurationMs": 2.1149999999999998,
"taskDurationMs": 996.6239999999999,
"heapDeltaBytes": -19978068,
"heapUsedBytes": 61629392,
"domNodes": -242,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 503.19199999999995,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6664,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2166.124000000025,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.128000000000002,
"layouts": 9,
"layoutDurationMs": 1.9439999999999997,
"taskDurationMs": 1104.714,
"heapDeltaBytes": -18539504,
"heapUsedBytes": 73315576,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 546.0710000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3089.7470000000167,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.049,
"layouts": 67,
"layoutDurationMs": 10.415000000000001,
"taskDurationMs": 1052.8329999999999,
"heapDeltaBytes": 4911316,
"heapUsedBytes": 81648456,
"domNodes": 24,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 481.12200000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258063,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3434.663999999998,
"styleRecalcs": 74,
"styleRecalcDurationMs": 11.993,
"layouts": 67,
"layoutDurationMs": 12.355000000000002,
"taskDurationMs": 1298.026,
"heapDeltaBytes": 9383120,
"heapUsedBytes": 82662348,
"domNodes": -233,
"jsHeapTotalBytes": 2486272,
"scriptDurationMs": 547.3900000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665533980582524,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2189.355000000006,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.817,
"layouts": 7,
"layoutDurationMs": 1.585,
"taskDurationMs": 1211.9650000000001,
"heapDeltaBytes": 15806616,
"heapUsedBytes": 101520884,
"domNodes": 0,
"jsHeapTotalBytes": 7757824,
"scriptDurationMs": 635.084,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665648854961834,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2359.4039999999836,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.221,
"layouts": 8,
"layoutDurationMs": 1.7570000000000001,
"taskDurationMs": 1325.991,
"heapDeltaBytes": 12780764,
"heapUsedBytes": 92362688,
"domNodes": 0,
"jsHeapTotalBytes": 5398528,
"scriptDurationMs": 670.818,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666197183098593,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2733.6990000000014,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.7290000000000005,
"layouts": 9,
"layoutDurationMs": 1.6449999999999998,
"taskDurationMs": 466.619,
"heapDeltaBytes": -12127216,
"heapUsedBytes": 61294076,
"domNodes": -257,
"jsHeapTotalBytes": -1183744,
"scriptDurationMs": 210.82500000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2822.8960000000143,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8980000000000004,
"layouts": 8,
"layoutDurationMs": 1.809,
"taskDurationMs": 505.73,
"heapDeltaBytes": -27029328,
"heapUsedBytes": 66454916,
"domNodes": -257,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 234.204,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666272189349115,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2005.1810000000216,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.9569999999999996,
"layouts": 9,
"layoutDurationMs": 1.7389999999999999,
"taskDurationMs": 352.009,
"heapDeltaBytes": -29344120,
"heapUsedBytes": 63686060,
"domNodes": -257,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 16.682000000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-idle",
"durationMs": 2027.5439999999776,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.174,
"layouts": 8,
"layoutDurationMs": 1.8619999999999999,
"taskDurationMs": 421.317,
"heapDeltaBytes": 10931416,
"heapUsedBytes": 86130612,
"domNodes": -257,
"jsHeapTotalBytes": 389120,
"scriptDurationMs": 26.846,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2710.3670000000193,
"styleRecalcs": 24,
"styleRecalcDurationMs": 9.081,
"layouts": 5,
"layoutDurationMs": 0.8930000000000001,
"taskDurationMs": 322.81499999999994,
"heapDeltaBytes": -14245556,
"heapUsedBytes": 62024664,
"domNodes": -256,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 119.23100000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665644171779142,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2678.8270000000125,
"styleRecalcs": 26,
"styleRecalcDurationMs": 9.709999999999999,
"layouts": 7,
"layoutDurationMs": 1.5079999999999998,
"taskDurationMs": 387.059,
"heapDeltaBytes": 2179872,
"heapUsedBytes": 79274808,
"domNodes": -239,
"jsHeapTotalBytes": 651264,
"scriptDurationMs": 131.954,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66645962732919,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 2904.9950000000135,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.144999999999999,
"layouts": 8,
"layoutDurationMs": 1.7989999999999997,
"taskDurationMs": 575.286,
"heapDeltaBytes": -7936852,
"heapUsedBytes": 87358420,
"domNodes": -257,
"jsHeapTotalBytes": 6193152,
"scriptDurationMs": 225.041,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666091954022992,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 2907.947999999976,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8010000000000006,
"layouts": 7,
"layoutDurationMs": 1.5990000000000002,
"taskDurationMs": 623.6139999999999,
"heapDeltaBytes": 985184,
"heapUsedBytes": 77857432,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 235.274,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66609195402299,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 397.82900000000154,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.338,
"layouts": 10,
"layoutDurationMs": 2.2489999999999997,
"taskDurationMs": 262.35999999999996,
"heapDeltaBytes": 22137984,
"heapUsedBytes": 83534252,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 91.598,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 442.52800000003845,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.235,
"layouts": 10,
"layoutDurationMs": 2.5069999999999997,
"taskDurationMs": 298.36300000000006,
"heapDeltaBytes": -1049536,
"heapUsedBytes": 60838540,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 100.423,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662962962962965,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2009.742999999986,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.6549999999999994,
"layouts": 11,
"layoutDurationMs": 2.533,
"taskDurationMs": 287.043,
"heapDeltaBytes": 4792756,
"heapUsedBytes": 68821184,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 4.519,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2008.482000000015,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4419999999999997,
"layouts": 10,
"layoutDurationMs": 2.142,
"taskDurationMs": 352.665,
"heapDeltaBytes": -5692188,
"heapUsedBytes": 66406720,
"domNodes": -183,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 6.540000000000001,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.7500000000032,
"styleRecalcs": 75,
"styleRecalcDurationMs": 10.638,
"layouts": 9,
"layoutDurationMs": 1.8390000000000002,
"taskDurationMs": 464.514,
"heapDeltaBytes": 17878724,
"heapUsedBytes": 80110212,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 69.24,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667326732673267,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.3790000000067,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.181,
"layouts": 9,
"layoutDurationMs": 2.308,
"taskDurationMs": 569.1229999999999,
"heapDeltaBytes": 18047764,
"heapUsedBytes": 79673772,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 84.451,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 834.4539999999938,
"styleRecalcs": 20,
"styleRecalcDurationMs": 15.073,
"layouts": 5,
"layoutDurationMs": 8.893,
"taskDurationMs": 629.186,
"heapDeltaBytes": 38128656,
"heapUsedBytes": 114276792,
"domNodes": 16030,
"jsHeapTotalBytes": 14028800,
"scriptDurationMs": 19.102,
"eventListeners": 3246,
"totalBlockingTimeMs": 80,
"frameDurationMs": 19.379069767441866,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8256.935999999996,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.301,
"layouts": 9,
"layoutDurationMs": 1.93,
"taskDurationMs": 3848.02,
"heapDeltaBytes": -3126712,
"heapUsedBytes": 74103588,
"domNodes": -257,
"jsHeapTotalBytes": 9302016,
"scriptDurationMs": 2007.2330000000002,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66592741935484,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9339.370000000032,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.074000000000005,
"layouts": 8,
"layoutDurationMs": 2.036,
"taskDurationMs": 4475.058000000001,
"heapDeltaBytes": -12914292,
"heapUsedBytes": 62004656,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 2079.659,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571428,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15363.068000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14349.895,
"heapDeltaBytes": -4390340,
"heapUsedBytes": 282080724,
"domNodes": -3343,
"jsHeapTotalBytes": 16502784,
"scriptDurationMs": 188.595,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.95608108108108,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 16818.475000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16174.954,
"heapDeltaBytes": -28895340,
"heapUsedBytes": 263680964,
"domNodes": -3343,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 226.47299999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.274260869565218,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 18533.365000000005,
"styleRecalcs": 160,
"styleRecalcDurationMs": 15.270000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18087.003,
"heapDeltaBytes": -14055364,
"heapUsedBytes": 268586740,
"domNodes": -3343,
"jsHeapTotalBytes": 14667776,
"scriptDurationMs": 610.0289999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.0672794117647,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 18486.16999999996,
"styleRecalcs": 146,
"styleRecalcDurationMs": 16.721,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18125.098,
"heapDeltaBytes": 21095976,
"heapUsedBytes": 289533808,
"domNodes": -3343,
"jsHeapTotalBytes": -1118208,
"scriptDurationMs": 666.7080000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.61161048689139,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5607.505000000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 43.07900000000001,
"layouts": 20,
"layoutDurationMs": 19.157000000000007,
"taskDurationMs": 5501.22,
"heapDeltaBytes": -17748008,
"heapUsedBytes": 265790696,
"domNodes": -3343,
"jsHeapTotalBytes": 27516928,
"scriptDurationMs": 74.52499999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.13491124260354,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5824.21400000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 44.667000000000016,
"layouts": 20,
"layoutDurationMs": 20.803,
"taskDurationMs": 5706.316000000001,
"heapDeltaBytes": -19396936,
"heapUsedBytes": 262974276,
"domNodes": -3343,
"jsHeapTotalBytes": 25157632,
"scriptDurationMs": 83.064,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.92814371257485,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7610.093000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7300.352,
"heapDeltaBytes": 10985964,
"heapUsedBytes": 278452364,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 86.85000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.58821548821549,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8304.311999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7875.9529999999995,
"heapDeltaBytes": -14636476,
"heapUsedBytes": 259457572,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 106.47400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.32662116040955,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "workflow-execution",
"durationMs": 78.45399999996516,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.5920000000000005,
"layouts": 5,
"layoutDurationMs": 2.132,
"taskDurationMs": 55.461000000000006,
"heapDeltaBytes": 4786584,
"heapUsedBytes": 72647668,
"domNodes": 105,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.657000000000001,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.680000000000017,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 92.81100000009701,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.832999999999999,
"layouts": 8,
"layoutDurationMs": 2.6040000000000005,
"taskDurationMs": 59.05300000000001,
"heapDeltaBytes": 4657572,
"heapUsedBytes": 74638720,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.970000000000001,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 206.18200000001252,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.5680000000000001,
"layouts": 76,
"layoutDurationMs": 9.802,
"taskDurationMs": 167.00799999999998,
"heapDeltaBytes": 9711440,
"heapUsedBytes": 51170656,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 68.883,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 251.16000000002714,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.628,
"layouts": 76,
"layoutDurationMs": 12.576,
"taskDurationMs": 209.983,
"heapDeltaBytes": 10314252,
"heapUsedBytes": 51794364,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 88.79299999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 266.46999999991294,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.48,
"layouts": 76,
"layoutDurationMs": 11.323,
"taskDurationMs": 237.01999999999998,
"heapDeltaBytes": -1499752,
"heapUsedBytes": 92229040,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 76.18599999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352898,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 279.376999999954,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.443,
"layouts": 76,
"layoutDurationMs": 11.443999999999999,
"taskDurationMs": 249.838,
"heapDeltaBytes": -1264508,
"heapUsedBytes": 92209476,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 83.66,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.65882352941181,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage: 🟡 59.7% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3131 passed, 0 failed · 7 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 95af965c128d5d971e19440718d11dc5cf037648
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (282)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Approved as a backport of #22971, per the requested backport review policy. No tests or workflows were run.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.59 #22983 +/- ##
=============================================
Coverage ? 87.30%
=============================================
Files ? 3070
Lines ? 160934
Branches ? 40505
=============================================
Hits ? 140508
Misses ? 19746
Partials ? 680
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #22971 to
cloud/1.59. Fixes FRONT-3837: cloud prod alert "Cannot save workflow … before it is loaded" (Sentry CLOUD-FRONTEND-PROD-394 / PROD-393).Save and Save As load a tab that is not loaded first (with its draft), instead of hitting the fix: harden workflow load against null initial state and report occurrences #21326 guard. The guard stays for an active tab with no content.
Workflow sync no longer unloads or re-stamps a modified background tab, which used to lose its draft.
If the edits are already gone: nothing is written, a warning toast shows, and a static report is sent.
The guard message no longer contains the file path.
Conflict: only
src/locales/en/main.json. Kept this branch's keys and added the two newworkflowServicekeys; theunreadableWorkflow*keys from fix(workflow): tell the user when a saved workflow file cannot be opened #22946 are not added here.Auto-backport failed on merge conflicts; cherry-picked
03bbb78ba2with-x.