Repository navigation
[backport cloud/1.59] fix: prune unresolvable subgraph links on load and stop prompt build failing on them - #22960
Conversation
…failing on them (#19625) Saved subgraphs can carry inner links that never resolve: a target input the node no longer lays out, an endpoint node that does not exist, or a boundary slot index that does not exist. They make `unpackSubgraph` refuse (`error_unpacking_subgraph_link`) and, when the dangling link feeds a subgraph output, make queueing throw `No output node found for id [N] slot [S] <name>` (Sentry CLOUD-FRONTEND-PROD-38B), so the user cannot run that workflow at all. This PR repairs those links when a subgraph definition loads and stops prompt building from failing on any that remain. Fixes FRONT-3831 (QA tracking: CQA-765) - **Load-time prune** (`pruneDanglingSubgraphLinks`, run from `Subgraph.configure`): deletes inner links that `isUnresolvableSubgraphLink` (the predicate the unpack guard uses) already rejects and that are unambiguous: - `origin_node_missing` / `target_node_missing`: the endpoint node id is not in the subgraph. - `boundary_slot_out_of_range`: a subgraph input/output slot index that does not exist. - `dropped_input`: the link's target slot does not exist and the target node no longer has an input carrying the name the workflow saved for *this* link, either free or holding it. Matched per link (not per node), so a link whose named input is still live is never deleted, duplicate input names are handled, and reminted node ids cannot mismatch. - Boundary `linkIds` are reconciled against the link map; both surviving endpoints get `onConnectionsChange(…, false, …)`. - Output-slot drift on an existing node is still left alone (outputs are never realigned by name). - **Graceful degradation** in `ExecutableNodeDTO._resolveSubgraphOutput`: an inner output link with no origin node now warns and resolves to nothing (like the existing no-inner-link case), so the backend reports an ordinary missing input instead of the whole queue failing client-side. A pass-through link (subgraph input wired straight to a subgraph output) now resolves through the subgraph node's input instead of throwing; when that input has no outer link but holds a promoted widget value, the output resolves to that widget value, matching the existing boundary-input behaviour. - **Telemetry**: `error_pruning_subgraph_link` (warning, counts per kind as tags, no node ids, at most 5 per session) when a load prunes links; `error_resolving_subgraph_output_origin` (warning, once per subgraph per session) when prompt building skips such an output. Both reports use a fixed fingerprint so they group into one Sentry issue each, instead of one issue per node id. - A pruned link is deleted at load, permanently. Opening an affected workflow can mark it modified without a user edit (the repair is savable). - The prune runs before graph-level `onGraphConfigured`/`onAfterGraphConfigured`, so the dropped-input check skips any node that defines those hooks (it may lay out inputs there). The widget-inputs extension gives every registered node type an `onGraphConfigured`, so in the app the dropped-input check applies to nested subgraph nodes (the proven producer, `SubgraphNode._internalConfigureAfterSlots`); other nodes' out-of-range links stay for the unpack guard to refuse, as on `main`. The missing-node and boundary-slot kinds apply to every node. Documented in `docs/extensions/connection-callbacks-migration.md` ("Unresolvable subgraph links are pruned on load"). Summary: - Each pruned link fires `onConnectionsChange(type, slot, false, link, slot)` on every endpoint node that still exists. During load, a `false` notification can mean "pruned", not "user disconnected". - Timing: pruning runs when the subgraph definition is configured, after its nodes' `configure()`, and before any `onGraphConfigured` / `onAfterGraphConfigured` hook. - State inside the callback: every pruned link is already removed and stale boundary `linkIds` are already cleared before the first callback fires. - Failure isolation: each endpoint callback has its own `try`; a throw is reported as `error_notifying_pruned_subgraph_link` (warning, at most 5 per session) and does not skip the other endpoint, the other pruned links, or the rest of the load. - Handlers that treat a load-time disconnect as a user action should check `app.configuringGraph`. Tests pin each of these: callbacks see an empty link map and cleared boundary `linkIds`, and a throwing callback still lets the remaining notifications run. - `lostItsInput` rule: a link left out of range while a same-named input is free is a failed realignment, not a drop, so it is kept and the unpack guard still refuses it loudly. - Prune kept separate from `realignInputLinkSlots` on purpose: realign also runs for root graphs and mid-`node.configure` (via `realignGroupWidgetChildLinks`), so adding deletion there would widen this to root workflows. - `danglingInnerLink.test.ts` (17 tests: dropped input, shrink to zero, duplicate names, boundary slot cases as a table, origin/target node missing, out-of-range boundary origin, healthy links kept, uninstalled node with no saved inputs kept, node with graph hooks kept, input renamed in place kept, nested subgraph producer, unpack after load) plus 3 notification-contract tests, and five new `ExecutableNodeDTO` tests (dangling output resolves to nothing; pass-through forwards; pass-through to a missing input is skipped; unlinked pass-through returns the promoted widget value; unlinked pass-through with no widget resolves to nothing). The new behaviour tests failed on `main` first; the DTO test reproduced the exact production message. Each prune kind has its own falsifier: disabling the origin-missing, target-missing, boundary-slot or target-slot-exists branch fails exactly one test. - `vitest run src/lib/litegraph src/scripts src/platform/workflow`, oxlint type-aware, eslint, oxfmt on the changed files. - No browser test: no UI surface changes, and the unit tests drive the real `createSubgraph`/`createSubgraphs` → `Subgraph.configure` → `unpackSubgraph` path. - After release: Sentry CLOUD-FRONTEND-PROD-38B (and the `No output node found` family) should stop receiving events from builds carrying this; `error_pruning_subgraph_link` / `error_resolving_subgraph_output_origin` show how often old workflows hit it and which kind. Rebased onto current `main` and reworked to address the earlier review rounds (cursor panel E1–E10, mrseek review) and the Sentry RCA review above. (cherry picked from commit d8bfed6)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-05T04:03:16.655Z",
"gitSha": "b2672e348a72f3ab3002d7c1e432b90a6bca4b91",
"branch": "backport-19625-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.9749999999835,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.4799999999999995,
"layouts": 10,
"layoutDurationMs": 2.5669999999999997,
"taskDurationMs": 550.797,
"heapDeltaBytes": -10901112,
"heapUsedBytes": 65795484,
"domNodes": -161,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 7.872999999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2007.2410000000218,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.1710000000000003,
"layouts": 9,
"layoutDurationMs": 2.487,
"taskDurationMs": 508.02599999999995,
"heapDeltaBytes": 1913124,
"heapUsedBytes": 64186508,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 8.136999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1740.87099999997,
"styleRecalcs": 74,
"styleRecalcDurationMs": 11.692,
"layouts": 9,
"layoutDurationMs": 2.568,
"taskDurationMs": 841.0580000000001,
"heapDeltaBytes": 22220984,
"heapUsedBytes": 84522716,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 154.66000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1776.344999999992,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.968000000000002,
"layouts": 9,
"layoutDurationMs": 2.429,
"taskDurationMs": 861.7170000000001,
"heapDeltaBytes": 21955340,
"heapUsedBytes": 83709396,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 156.924,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66728971962617,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.1779999999949,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.443999999999999,
"layouts": 10,
"layoutDurationMs": 2.615999999999999,
"taskDurationMs": 392.93699999999995,
"heapDeltaBytes": 24500076,
"heapUsedBytes": 86231060,
"domNodes": 56,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 10.217,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.6550000000743,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.867,
"layouts": 11,
"layoutDurationMs": 2.8719999999999994,
"taskDurationMs": 390.73199999999997,
"heapDeltaBytes": 547020,
"heapUsedBytes": 70007936,
"domNodes": 56,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 9.817,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 708.6209999999937,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.4879999999999995,
"layouts": 8,
"layoutDurationMs": 2.074,
"taskDurationMs": 489.304,
"heapDeltaBytes": 3905848,
"heapUsedBytes": 64338484,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 167.989,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 707.198999999946,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.2560000000000002,
"layouts": 9,
"layoutDurationMs": 2.0480000000000005,
"taskDurationMs": 494.182,
"heapDeltaBytes": 3499864,
"heapUsedBytes": 65654064,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 171.859,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1196.7470000000162,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 901.2679999999999,
"heapDeltaBytes": -11857612,
"heapUsedBytes": 75587060,
"domNodes": -191,
"jsHeapTotalBytes": 21504000,
"scriptDurationMs": 66.463,
"eventListeners": -107,
"totalBlockingTimeMs": 530,
"frameDurationMs": 33.333333333333336,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1229.7230000000354,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 917.498,
"heapDeltaBytes": -2134152,
"heapUsedBytes": 75792220,
"domNodes": -191,
"jsHeapTotalBytes": 15998976,
"scriptDurationMs": 70.15800000000002,
"eventListeners": -107,
"totalBlockingTimeMs": 544,
"frameDurationMs": 33.329729729729735,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.6309999999926,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.7190000000001,
"heapDeltaBytes": -3602084,
"heapUsedBytes": 70210988,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 155.81300000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 217,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 925.122999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.5129999999996,
"heapDeltaBytes": -27728212,
"heapUsedBytes": 67495116,
"domNodes": -191,
"jsHeapTotalBytes": 3538944,
"scriptDurationMs": 169.172,
"eventListeners": -107,
"totalBlockingTimeMs": 262,
"frameDurationMs": 25.925000000000004,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10417.045000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9618.332,
"heapDeltaBytes": -11186348,
"heapUsedBytes": 67094224,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 7765.526000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 887,
"frameDurationMs": 32.14907407407408,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10648.375999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9895.810000000001,
"heapDeltaBytes": -3964528,
"heapUsedBytes": 68727668,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 8079.222,
"eventListeners": 0,
"totalBlockingTimeMs": 1085,
"frameDurationMs": 31.13888888888889,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10149.715000000015,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.034000000000000176,
"layouts": 1,
"layoutDurationMs": 0.183,
"taskDurationMs": 9421.497000000001,
"heapDeltaBytes": 63711728,
"heapUsedBytes": 138263628,
"domNodes": -257,
"jsHeapTotalBytes": 59109376,
"scriptDurationMs": 7586.522,
"eventListeners": -69,
"totalBlockingTimeMs": 837,
"frameDurationMs": 31.229538461538464,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10585.996000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9844.785,
"heapDeltaBytes": -11587540,
"heapUsedBytes": 78121060,
"domNodes": -257,
"jsHeapTotalBytes": 7729152,
"scriptDurationMs": 8041.276999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 1126,
"frameDurationMs": 31.496726190476195,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 231.27499999998236,
"styleRecalcs": 23,
"styleRecalcDurationMs": 12.824000000000002,
"layouts": 10,
"layoutDurationMs": 2.883,
"taskDurationMs": 170.302,
"heapDeltaBytes": 14652116,
"heapUsedBytes": 71016020,
"domNodes": -2315,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.810999999999998,
"eventListeners": -574,
"totalBlockingTimeMs": 2,
"frameDurationMs": 24.077777777777758,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 285.2139999999963,
"styleRecalcs": 25,
"styleRecalcDurationMs": 13.254000000000001,
"layouts": 11,
"layoutDurationMs": 3.078,
"taskDurationMs": 230.784,
"heapDeltaBytes": -18359576,
"heapUsedBytes": 57824768,
"domNodes": 936,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 8.424000000000001,
"eventListeners": -641,
"totalBlockingTimeMs": 1,
"frameDurationMs": 25.008333333333365,
"p95FrameDurationMs": 100
},
{
"name": "large-graph-idle",
"durationMs": 2056.3430000000267,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.9969999999999997,
"layouts": 8,
"layoutDurationMs": 2.038,
"taskDurationMs": 631.3739999999999,
"heapDeltaBytes": -14638620,
"heapUsedBytes": 60063264,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 32.031,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2041.029999999978,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.0439999999999996,
"layouts": 8,
"layoutDurationMs": 2.1989999999999994,
"taskDurationMs": 626.666,
"heapDeltaBytes": -1419512,
"heapUsedBytes": 75865576,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 31.174999999999994,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2681.6239999999993,
"styleRecalcs": 67,
"styleRecalcDurationMs": 7.8759999999999994,
"layouts": 6,
"layoutDurationMs": 1.477,
"taskDurationMs": 1765.879,
"heapDeltaBytes": -4545608,
"heapUsedBytes": 85468356,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 851.481,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2378.846000000067,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.967999999999999,
"layouts": 8,
"layoutDurationMs": 2.1020000000000003,
"taskDurationMs": 1679.236,
"heapDeltaBytes": 3927684,
"heapUsedBytes": 82332408,
"domNodes": -257,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 824.352,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666901408450705,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3750.959000000023,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.222000000000001,
"layouts": 64,
"layoutDurationMs": 10.104999999999999,
"taskDurationMs": 1816.806,
"heapDeltaBytes": -3679252,
"heapUsedBytes": 74825224,
"domNodes": -233,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 790.7850000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66622222222222,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3616.6099999999233,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.126,
"layouts": 66,
"layoutDurationMs": 10.374,
"taskDurationMs": 1764.8389999999997,
"heapDeltaBytes": -4828492,
"heapUsedBytes": 67037608,
"domNodes": -233,
"jsHeapTotalBytes": 1437696,
"scriptDurationMs": 775.261,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66589861751152,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3178.278999999975,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.773000000000001,
"layouts": 4,
"layoutDurationMs": 1.1810000000000003,
"taskDurationMs": 2037.1139999999998,
"heapDeltaBytes": -9582440,
"heapUsedBytes": 71384516,
"domNodes": 0,
"jsHeapTotalBytes": 6381568,
"scriptDurationMs": 1020.7610000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 31,
"frameDurationMs": 17.02021276595745,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3080.5159999999887,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.403,
"layouts": 3,
"layoutDurationMs": 0.876,
"taskDurationMs": 1992.4269999999997,
"heapDeltaBytes": -1261628,
"heapUsedBytes": 70881224,
"domNodes": -257,
"jsHeapTotalBytes": 2711552,
"scriptDurationMs": 985.909,
"eventListeners": 113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756830601092897,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3108.2020000000057,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.98,
"layouts": 7,
"layoutDurationMs": 1.7640000000000005,
"taskDurationMs": 785.2020000000001,
"heapDeltaBytes": -11840272,
"heapUsedBytes": 67539152,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 374.745,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66524064171123,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3068.722999999977,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8310000000000002,
"layouts": 8,
"layoutDurationMs": 2.038,
"taskDurationMs": 773.163,
"heapDeltaBytes": -26058340,
"heapUsedBytes": 67398872,
"domNodes": -257,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 368.545,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666304347826088,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2030.9500000000185,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.7819999999999998,
"layouts": 7,
"layoutDurationMs": 1.7069999999999999,
"taskDurationMs": 638.133,
"heapDeltaBytes": 5414872,
"heapUsedBytes": 83364476,
"domNodes": -281,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 31.707,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-idle",
"durationMs": 2030.424000000039,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.757,
"layouts": 6,
"layoutDurationMs": 1.8110000000000002,
"taskDurationMs": 678.371,
"heapDeltaBytes": 7737768,
"heapUsedBytes": 86510936,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 31.436,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2806.355999999994,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.533999999999999,
"layouts": 7,
"layoutDurationMs": 2.225,
"taskDurationMs": 619.4599999999999,
"heapDeltaBytes": -8589664,
"heapUsedBytes": 84551032,
"domNodes": -238,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 186.394,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665476190476188,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 3028.197999999975,
"styleRecalcs": 24,
"styleRecalcDurationMs": 9.780999999999999,
"layouts": 4,
"layoutDurationMs": 0.8210000000000001,
"taskDurationMs": 566.6499999999999,
"heapDeltaBytes": -12978508,
"heapUsedBytes": 61737392,
"domNodes": -238,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 178.79799999999997,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665555555555557,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3276.8590000000017,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.6629999999999996,
"layouts": 7,
"layoutDurationMs": 1.647,
"taskDurationMs": 938.739,
"heapDeltaBytes": -11722364,
"heapUsedBytes": 69436132,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 368.058,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665816326530614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3222.479000000021,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.7900000000000007,
"layouts": 7,
"layoutDurationMs": 1.5210000000000001,
"taskDurationMs": 933.0609999999999,
"heapDeltaBytes": -13123976,
"heapUsedBytes": 64111040,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 375.22099999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665803108808287,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.6269999999927,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.524,
"layouts": 9,
"layoutDurationMs": 2.2049999999999996,
"taskDurationMs": 422.108,
"heapDeltaBytes": -1299908,
"heapUsedBytes": 61080412,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 141.61499999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714277,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.7530000000634,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.571000000000001,
"layouts": 9,
"layoutDurationMs": 2.4090000000000007,
"taskDurationMs": 440.31,
"heapDeltaBytes": 262784,
"heapUsedBytes": 62882596,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 148.342,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2018.6100000000238,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2249999999999996,
"layouts": 8,
"layoutDurationMs": 2.3640000000000003,
"taskDurationMs": 511.849,
"heapDeltaBytes": 4403144,
"heapUsedBytes": 66477512,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 7.814,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2024.5159999999487,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.6310000000000007,
"layouts": 11,
"layoutDurationMs": 2.8600000000000003,
"taskDurationMs": 547.987,
"heapDeltaBytes": -5976520,
"heapUsedBytes": 68812388,
"domNodes": -183,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 7.302999999999999,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.054999999982,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.658,
"layouts": 9,
"layoutDurationMs": 2.284,
"taskDurationMs": 850.999,
"heapDeltaBytes": 20109992,
"heapUsedBytes": 81761400,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 111.561,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.7740000000113,
"styleRecalcs": 79,
"styleRecalcDurationMs": 13.273,
"layouts": 9,
"layoutDurationMs": 2.801,
"taskDurationMs": 886.247,
"heapDeltaBytes": 18849136,
"heapUsedBytes": 81124132,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 111.57400000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1435.1330000000075,
"styleRecalcs": 19,
"styleRecalcDurationMs": 22.175,
"layouts": 5,
"layoutDurationMs": 14.037,
"taskDurationMs": 1017.9119999999999,
"heapDeltaBytes": 13901916,
"heapUsedBytes": 116727400,
"domNodes": 16030,
"jsHeapTotalBytes": 9834496,
"scriptDurationMs": 31.966,
"eventListeners": 3246,
"totalBlockingTimeMs": 151,
"frameDurationMs": 19.594594594594593,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9607.738999999981,
"styleRecalcs": 250,
"styleRecalcDurationMs": 27.388,
"layouts": 8,
"layoutDurationMs": 1.854,
"taskDurationMs": 6105.595,
"heapDeltaBytes": 12792600,
"heapUsedBytes": 86885872,
"domNodes": -257,
"jsHeapTotalBytes": 4251648,
"scriptDurationMs": 2756.074,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665857885615253,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8740.85100000002,
"styleRecalcs": 250,
"styleRecalcDurationMs": 26.819000000000003,
"layouts": 8,
"layoutDurationMs": 1.8870000000000002,
"taskDurationMs": 5828.651,
"heapDeltaBytes": -5649928,
"heapUsedBytes": 85230120,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 2675.814,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665904761904763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 22967.097000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22057.313000000002,
"heapDeltaBytes": -25713060,
"heapUsedBytes": 275008800,
"domNodes": -3343,
"jsHeapTotalBytes": 17031168,
"scriptDurationMs": 308.68100000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.29640410958904,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 22945.63800000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22199.967,
"heapDeltaBytes": -28151520,
"heapUsedBytes": 254535696,
"domNodes": -3343,
"jsHeapTotalBytes": 13099008,
"scriptDurationMs": 312.908,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.1339590443686,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 27710.867000000006,
"styleRecalcs": 179,
"styleRecalcDurationMs": 17.597,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27320.939999999995,
"heapDeltaBytes": -7699668,
"heapUsedBytes": 269299820,
"domNodes": -3343,
"jsHeapTotalBytes": 13099008,
"scriptDurationMs": 892.415,
"eventListeners": -651,
"totalBlockingTimeMs": 10,
"frameDurationMs": 51.61191806331472,
"p95FrameDurationMs": 116.5
},
{
"name": "vue-large-graph-pan",
"durationMs": 27824.422000000028,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.69100000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27435.933,
"heapDeltaBytes": -24627596,
"heapUsedBytes": 252722536,
"domNodes": -3343,
"jsHeapTotalBytes": 13099008,
"scriptDurationMs": 884.625,
"eventListeners": -651,
"totalBlockingTimeMs": 23,
"frameDurationMs": 50.78868613138686,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8114.000000000033,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.20400000000001,
"layouts": 20,
"layoutDurationMs": 20.418999999999993,
"taskDurationMs": 7924.464,
"heapDeltaBytes": -32606128,
"heapUsedBytes": 259055312,
"domNodes": -3343,
"jsHeapTotalBytes": 19652608,
"scriptDurationMs": 117.265,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.64540229885057,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 8076.801000000046,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.891000000000005,
"layouts": 20,
"layoutDurationMs": 21.778999999999993,
"taskDurationMs": 7934.086,
"heapDeltaBytes": -39537884,
"heapUsedBytes": 257472360,
"domNodes": -3343,
"jsHeapTotalBytes": 18079744,
"scriptDurationMs": 115.166,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.5464705882353,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11262.963999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10711.73,
"heapDeltaBytes": 19078256,
"heapUsedBytes": 276354536,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 147.50499999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.98339100346021,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11666.608999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11204.925000000001,
"heapDeltaBytes": -10535356,
"heapUsedBytes": 248708924,
"domNodes": 0,
"jsHeapTotalBytes": -23330816,
"scriptDurationMs": 148.39400000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.95239726027397,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 501.5060000000062,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.843000000000004,
"layouts": 11,
"layoutDurationMs": 4.223,
"taskDurationMs": 144.318,
"heapDeltaBytes": 7325104,
"heapUsedBytes": 67732540,
"domNodes": 136,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 18.006999999999998,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 115.0639999999612,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.29,
"layouts": 8,
"layoutDurationMs": 3.7250000000000005,
"taskDurationMs": 79.125,
"heapDeltaBytes": 4649480,
"heapUsedBytes": 72738248,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.6129999999999995,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142844,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 556.5350000000535,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.634,
"layouts": 76,
"layoutDurationMs": 14.642000000000001,
"taskDurationMs": 498.46600000000007,
"heapDeltaBytes": -2793220,
"heapUsedBytes": 41880688,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 245.368,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 506.97299999990264,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.625,
"layouts": 76,
"layoutDurationMs": 14.613,
"taskDurationMs": 462.57,
"heapDeltaBytes": -3411804,
"heapUsedBytes": 40906396,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 221.994,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 518.318000000022,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.592,
"layouts": 76,
"layoutDurationMs": 13.950000000000001,
"taskDurationMs": 491.47,
"heapDeltaBytes": 434748,
"heapUsedBytes": 103614020,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 198.465,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 520.7530000000133,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.5859999999999999,
"layouts": 76,
"layoutDurationMs": 14.364999999999998,
"taskDurationMs": 490.1749999999999,
"heapDeltaBytes": 704124,
"heapUsedBytes": 104001840,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 192.692,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.699999999999818
}
]
}🎭 Playwright: ✅ 3143 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e5534fc4ea82ebf35689ca18020b15f78de8407d
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (282)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation failed to run ( Evaluation budget remaining for this pull request: 99 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
This comment has been minimized.
This comment has been minimized.
dante01yoon
left a comment
There was a problem hiding this comment.
Approved as a backport of #19625, per the requested backport review policy. No code-change findings added. Tests were not run.
|
Justification: dante01yoon approved 6e66b9a. The only later change, bc4ed48, is a one-line import of the |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.59 #22960 +/- ##
=============================================
Coverage ? 86.70%
=============================================
Files ? 2703
Lines ? 140124
Branches ? 43016
=============================================
Hits ? 121498
Misses ? 17805
Partials ? 821
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #19625 to the 1.59 train.
This is a manual backport because the automatic cherry-pick conflicted. 1.59 does not have the
@comfyorg/graph-modelor@comfyorg/telemetrypackages, so the imports now use the 1.59 paths:@/types/linkId,@/types/nodeId,@/types/widgetId,@/lib/litegraph/src/types/*and@/platform/telemetry/reportError. The logic is unchanged.ExecutableNodeDTO.test.tsanddanglingInnerLink.test.tspass on this branch (60 tests).