Repository navigation
[backport cloud/1.60] fix: prune unresolvable subgraph links on load and stop prompt build failing on them - #22957
Conversation
…failing on them (#19625) ## Summary Saved subgraphs can carry inner links that never resolve: a target input the node no longer lays out, an endpoint node that does not exist, or a boundary slot index that does not exist. They make `unpackSubgraph` refuse (`error_unpacking_subgraph_link`) and, when the dangling link feeds a subgraph output, make queueing throw `No output node found for id [N] slot [S] <name>` (Sentry CLOUD-FRONTEND-PROD-38B), so the user cannot run that workflow at all. This PR repairs those links when a subgraph definition loads and stops prompt building from failing on any that remain. Fixes FRONT-3831 (QA tracking: CQA-765) ## Changes - **Load-time prune** (`pruneDanglingSubgraphLinks`, run from `Subgraph.configure`): deletes inner links that `isUnresolvableSubgraphLink` (the predicate the unpack guard uses) already rejects and that are unambiguous: - `origin_node_missing` / `target_node_missing`: the endpoint node id is not in the subgraph. - `boundary_slot_out_of_range`: a subgraph input/output slot index that does not exist. - `dropped_input`: the link's target slot does not exist and the target node no longer has an input carrying the name the workflow saved for *this* link, either free or holding it. Matched per link (not per node), so a link whose named input is still live is never deleted, duplicate input names are handled, and reminted node ids cannot mismatch. - Boundary `linkIds` are reconciled against the link map; both surviving endpoints get `onConnectionsChange(…, false, …)`. - Output-slot drift on an existing node is still left alone (outputs are never realigned by name). - **Graceful degradation** in `ExecutableNodeDTO._resolveSubgraphOutput`: an inner output link with no origin node now warns and resolves to nothing (like the existing no-inner-link case), so the backend reports an ordinary missing input instead of the whole queue failing client-side. A pass-through link (subgraph input wired straight to a subgraph output) now resolves through the subgraph node's input instead of throwing; when that input has no outer link but holds a promoted widget value, the output resolves to that widget value, matching the existing boundary-input behaviour. - **Telemetry**: `error_pruning_subgraph_link` (warning, counts per kind as tags, no node ids, at most 5 per session) when a load prunes links; `error_resolving_subgraph_output_origin` (warning, once per subgraph per session) when prompt building skips such an output. Both reports use a fixed fingerprint so they group into one Sentry issue each, instead of one issue per node id. ## Behaviour changes worth knowing - A pruned link is deleted at load, permanently. Opening an affected workflow can mark it modified without a user edit (the repair is savable). - The prune runs before graph-level `onGraphConfigured`/`onAfterGraphConfigured`, so the dropped-input check skips any node that defines those hooks (it may lay out inputs there). The widget-inputs extension gives every registered node type an `onGraphConfigured`, so in the app the dropped-input check applies to nested subgraph nodes (the proven producer, `SubgraphNode._internalConfigureAfterSlots`); other nodes' out-of-range links stay for the unpack guard to refuse, as on `main`. The missing-node and boundary-slot kinds apply to every node. ## Extension authors: load-time `onConnectionsChange` notifications Documented in `docs/extensions/connection-callbacks-migration.md` ("Unresolvable subgraph links are pruned on load"). Summary: - Each pruned link fires `onConnectionsChange(type, slot, false, link, slot)` on every endpoint node that still exists. During load, a `false` notification can mean "pruned", not "user disconnected". - Timing: pruning runs when the subgraph definition is configured, after its nodes' `configure()`, and before any `onGraphConfigured` / `onAfterGraphConfigured` hook. - State inside the callback: every pruned link is already removed and stale boundary `linkIds` are already cleared before the first callback fires. - Failure isolation: each endpoint callback has its own `try`; a throw is reported as `error_notifying_pruned_subgraph_link` (warning, at most 5 per session) and does not skip the other endpoint, the other pruned links, or the rest of the load. - Handlers that treat a load-time disconnect as a user action should check `app.configuringGraph`. Tests pin each of these: callbacks see an empty link map and cleared boundary `linkIds`, and a throwing callback still lets the remaining notifications run. ## Review Focus - `lostItsInput` rule: a link left out of range while a same-named input is free is a failed realignment, not a drop, so it is kept and the unpack guard still refuses it loudly. - Prune kept separate from `realignInputLinkSlots` on purpose: realign also runs for root graphs and mid-`node.configure` (via `realignGroupWidgetChildLinks`), so adding deletion there would widen this to root workflows. ## Verification - `danglingInnerLink.test.ts` (17 tests: dropped input, shrink to zero, duplicate names, boundary slot cases as a table, origin/target node missing, out-of-range boundary origin, healthy links kept, uninstalled node with no saved inputs kept, node with graph hooks kept, input renamed in place kept, nested subgraph producer, unpack after load) plus 3 notification-contract tests, and five new `ExecutableNodeDTO` tests (dangling output resolves to nothing; pass-through forwards; pass-through to a missing input is skipped; unlinked pass-through returns the promoted widget value; unlinked pass-through with no widget resolves to nothing). The new behaviour tests failed on `main` first; the DTO test reproduced the exact production message. Each prune kind has its own falsifier: disabling the origin-missing, target-missing, boundary-slot or target-slot-exists branch fails exactly one test. - `vitest run src/lib/litegraph src/scripts src/platform/workflow`, oxlint type-aware, eslint, oxfmt on the changed files. - No browser test: no UI surface changes, and the unit tests drive the real `createSubgraph`/`createSubgraphs` → `Subgraph.configure` → `unpackSubgraph` path. - After release: Sentry CLOUD-FRONTEND-PROD-38B (and the `No output node found` family) should stop receiving events from builds carrying this; `error_pruning_subgraph_link` / `error_resolving_subgraph_output_origin` show how often old workflows hit it and which kind. Rebased onto current `main` and reworked to address the earlier review rounds (cursor panel E1–E10, mrseek review) and the Sentry RCA review above.
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 8 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-05T03:39:03.007Z",
"gitSha": "3751befa66303ea3aea75b5d64939dc9df7ba750",
"branch": "backport-19625-to-cloud-1.60",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.9659999999635,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.351999999999999,
"layouts": 9,
"layoutDurationMs": 2.9430000000000005,
"taskDurationMs": 742.5500000000001,
"heapDeltaBytes": -13840876,
"heapUsedBytes": 63782696,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 15.152000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2047.345000000064,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.7919999999999994,
"layouts": 8,
"layoutDurationMs": 2.53,
"taskDurationMs": 690.608,
"heapDeltaBytes": 6421076,
"heapUsedBytes": 66713512,
"domNodes": -178,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 13.815000000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1898.9740000000097,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.039,
"layouts": 8,
"layoutDurationMs": 2.5269999999999997,
"taskDurationMs": 1045.3929999999998,
"heapDeltaBytes": 5448432,
"heapUsedBytes": 66130736,
"domNodes": -178,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 177.921,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684207,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1825.505000000021,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.956000000000001,
"layouts": 9,
"layoutDurationMs": 2.5249999999999995,
"taskDurationMs": 910.9900000000001,
"heapDeltaBytes": 204088,
"heapUsedBytes": 61848200,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 167.485,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871556,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.8069999999989,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.4959999999999996,
"layouts": 11,
"layoutDurationMs": 3.3109999999999995,
"taskDurationMs": 513.6469999999999,
"heapDeltaBytes": 11576264,
"heapUsedBytes": 84540320,
"domNodes": 57,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 16.438000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1730.860000000007,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.9319999999999995,
"layouts": 12,
"layoutDurationMs": 3.7059999999999995,
"taskDurationMs": 468.45,
"heapDeltaBytes": 25389244,
"heapUsedBytes": 85641800,
"domNodes": 57,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 15.057999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 777.136999999982,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.169000000000001,
"layouts": 9,
"layoutDurationMs": 2.7020000000000004,
"taskDurationMs": 563.225,
"heapDeltaBytes": 12471228,
"heapUsedBytes": 85028704,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 180.682,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66304347826087,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 682.8440000000455,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.964,
"layouts": 9,
"layoutDurationMs": 2.6710000000000003,
"taskDurationMs": 507.8950000000001,
"heapDeltaBytes": 9980528,
"heapUsedBytes": 79581320,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 172.41299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667500000000008,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1361.077000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1110.8280000000002,
"heapDeltaBytes": 19390176,
"heapUsedBytes": 85348092,
"domNodes": 0,
"jsHeapTotalBytes": 14843904,
"scriptDurationMs": 78.821,
"eventListeners": 0,
"totalBlockingTimeMs": 720,
"frameDurationMs": 39.708823529411745,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1173.041000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 878.388,
"heapDeltaBytes": 23704612,
"heapUsedBytes": 86297212,
"domNodes": 0,
"jsHeapTotalBytes": 10911744,
"scriptDurationMs": 74.88099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 532,
"frameDurationMs": 34.31176470588234,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 882.3090000000207,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 564.0710000000003,
"heapDeltaBytes": -6183052,
"heapUsedBytes": 90189140,
"domNodes": 0,
"jsHeapTotalBytes": 4722688,
"scriptDurationMs": 177.36399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 241,
"frameDurationMs": 25.982352941176458,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.2049999999881,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.9429999999995,
"heapDeltaBytes": -2773876,
"heapUsedBytes": 73406804,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 156.88000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 215,
"frameDurationMs": 25.00000000000003,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 13231.659000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12313.587,
"heapDeltaBytes": 93602704,
"heapUsedBytes": 167254640,
"domNodes": -274,
"jsHeapTotalBytes": 86372352,
"scriptDurationMs": 10008.084,
"eventListeners": -69,
"totalBlockingTimeMs": 2283,
"frameDurationMs": 33.67055837563451,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11397.401999999944,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10579.056,
"heapDeltaBytes": 56581116,
"heapUsedBytes": 151478508,
"domNodes": -274,
"jsHeapTotalBytes": 75624448,
"scriptDurationMs": 8384.555,
"eventListeners": -69,
"totalBlockingTimeMs": 1393,
"frameDurationMs": 31.016076294277934,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11731.55699999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10909.815,
"heapDeltaBytes": 52129752,
"heapUsedBytes": 146424576,
"domNodes": -274,
"jsHeapTotalBytes": 82702336,
"scriptDurationMs": 8742.73,
"eventListeners": -69,
"totalBlockingTimeMs": 1526,
"frameDurationMs": 31.79620596205962,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 12094.48000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11259.314,
"heapDeltaBytes": 14544820,
"heapUsedBytes": 76095952,
"domNodes": -274,
"jsHeapTotalBytes": 20709376,
"scriptDurationMs": 9099.453000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 1608,
"frameDurationMs": 32.26533333333333,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 236.57099999996944,
"styleRecalcs": 20,
"styleRecalcDurationMs": 14.519,
"layouts": 6,
"layoutDurationMs": 2.1590000000000003,
"taskDurationMs": 184.28300000000004,
"heapDeltaBytes": 14926852,
"heapUsedBytes": 76134620,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.934999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 11,
"frameDurationMs": 25,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 247.8089999999611,
"styleRecalcs": 20,
"styleRecalcDurationMs": 13.569999999999999,
"layouts": 7,
"layoutDurationMs": 2.5779999999999994,
"taskDurationMs": 179.56,
"heapDeltaBytes": 14936252,
"heapUsedBytes": 76166744,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.112,
"eventListeners": 205,
"totalBlockingTimeMs": 8,
"frameDurationMs": 25.91111111111114,
"p95FrameDurationMs": 100
},
{
"name": "large-graph-idle",
"durationMs": 2056.4880000000016,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.636,
"layouts": 7,
"layoutDurationMs": 2.683,
"taskDurationMs": 816.1559999999998,
"heapDeltaBytes": -19645820,
"heapUsedBytes": 63267288,
"domNodes": -274,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 39.766000000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2058.2689999999957,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6920000000000006,
"layouts": 8,
"layoutDurationMs": 2.3680000000000003,
"taskDurationMs": 778.4000000000001,
"heapDeltaBytes": -19242444,
"heapUsedBytes": 63891692,
"domNodes": -278,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 40.932,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3043.5469999999896,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.617,
"layouts": 7,
"layoutDurationMs": 2.098,
"taskDurationMs": 1982.736,
"heapDeltaBytes": 10394808,
"heapUsedBytes": 93325880,
"domNodes": -274,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 934.9499999999999,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.758011049723756,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2888.103000000001,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.264000000000003,
"layouts": 8,
"layoutDurationMs": 2.523,
"taskDurationMs": 1937.658,
"heapDeltaBytes": 3971220,
"heapUsedBytes": 79266252,
"domNodes": -274,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 921.6569999999999,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665895953757225,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 4310.612999999989,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.265999999999998,
"layouts": 63,
"layoutDurationMs": 11.665999999999999,
"taskDurationMs": 2164.158,
"heapDeltaBytes": -7822488,
"heapUsedBytes": 76388436,
"domNodes": -250,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 940.713,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666023166023166,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3858.926999999994,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.796000000000001,
"layouts": 64,
"layoutDurationMs": 10.703000000000001,
"taskDurationMs": 1869.634,
"heapDeltaBytes": -7379916,
"heapUsedBytes": 85149240,
"domNodes": -250,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 809.372,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66637931034483,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3243.323999999973,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.0280000000000005,
"layouts": 5,
"layoutDurationMs": 1.5439999999999998,
"taskDurationMs": 2253.5510000000004,
"heapDeltaBytes": -7007744,
"heapUsedBytes": 79178100,
"domNodes": -274,
"jsHeapTotalBytes": 5525504,
"scriptDurationMs": 1078.132,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.8390625,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3193.2199999999966,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.877000000000001,
"layouts": 4,
"layoutDurationMs": 1.344,
"taskDurationMs": 2149.594,
"heapDeltaBytes": -15012028,
"heapUsedBytes": 71672832,
"domNodes": 0,
"jsHeapTotalBytes": 7168000,
"scriptDurationMs": 1041.569,
"eventListeners": 182,
"totalBlockingTimeMs": 22,
"frameDurationMs": 17.020744680851063,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3261.679000000015,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.194,
"layouts": 6,
"layoutDurationMs": 1.803,
"taskDurationMs": 933.216,
"heapDeltaBytes": 10172132,
"heapUsedBytes": 82472104,
"domNodes": -274,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 428.873,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666153846153843,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3105.2700000000186,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.817,
"layouts": 6,
"layoutDurationMs": 1.6609999999999998,
"taskDurationMs": 849.4959999999999,
"heapDeltaBytes": -8003284,
"heapUsedBytes": 68601164,
"domNodes": -274,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 387.672,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66631016042781,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2044.2030000000386,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.242,
"layouts": 7,
"layoutDurationMs": 2.218,
"taskDurationMs": 786.372,
"heapDeltaBytes": 6901836,
"heapUsedBytes": 82734852,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 37.99999999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2061.8769999999813,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.7159999999999997,
"layouts": 8,
"layoutDurationMs": 2.309,
"taskDurationMs": 722.187,
"heapDeltaBytes": -19898932,
"heapUsedBytes": 65172308,
"domNodes": -274,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 34.60900000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258063,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 3095.0940000000173,
"styleRecalcs": 26,
"styleRecalcDurationMs": 13.151,
"layouts": 7,
"layoutDurationMs": 2.1949999999999994,
"taskDurationMs": 757.1730000000001,
"heapDeltaBytes": -6515612,
"heapUsedBytes": 79067576,
"domNodes": -256,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 226.92800000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2863.0809999999656,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.357,
"layouts": 6,
"layoutDurationMs": 2.1189999999999998,
"taskDurationMs": 670.1989999999998,
"heapDeltaBytes": -5542904,
"heapUsedBytes": 78209584,
"domNodes": -256,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 205.589,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666279069767445,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3503.863000000024,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.0800000000000012,
"layouts": 3,
"layoutDurationMs": 0.9540000000000004,
"taskDurationMs": 1166.931,
"heapDeltaBytes": -9973848,
"heapUsedBytes": 63368920,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 463.667,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.745454545454546,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3349.962000000005,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.744,
"layouts": 5,
"layoutDurationMs": 1.429,
"taskDurationMs": 1000.5680000000001,
"heapDeltaBytes": -17089552,
"heapUsedBytes": 75596184,
"domNodes": 0,
"jsHeapTotalBytes": 6328320,
"scriptDurationMs": 409.324,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7495,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 739.7750000000087,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.483,
"layouts": 8,
"layoutDurationMs": 2.3089999999999997,
"taskDurationMs": 493.481,
"heapDeltaBytes": 23874212,
"heapUsedBytes": 86050236,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 154.95299999999997,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 689.7870000000239,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.1049999999999995,
"layouts": 9,
"layoutDurationMs": 2.637,
"taskDurationMs": 486.877,
"heapDeltaBytes": 4075680,
"heapUsedBytes": 74837896,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 152.719,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2055.3669999999897,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.2709999999999995,
"layouts": 9,
"layoutDurationMs": 3.117,
"taskDurationMs": 718.186,
"heapDeltaBytes": -19436236,
"heapUsedBytes": 54541296,
"domNodes": -200,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 13.982000000000001,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2015.1559999999336,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6900000000000004,
"layouts": 9,
"layoutDurationMs": 2.3859999999999997,
"taskDurationMs": 546.104,
"heapDeltaBytes": 4644112,
"heapUsedBytes": 66072616,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 8.925,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1822.7309999999761,
"styleRecalcs": 79,
"styleRecalcDurationMs": 16.151000000000003,
"layouts": 8,
"layoutDurationMs": 2.4450000000000003,
"taskDurationMs": 1036.532,
"heapDeltaBytes": -7912048,
"heapUsedBytes": 56526812,
"domNodes": -185,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 128.554,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666972477064224,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1744.128000000046,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.875,
"layouts": 8,
"layoutDurationMs": 2.3829999999999996,
"taskDurationMs": 940.607,
"heapDeltaBytes": 10332204,
"heapUsedBytes": 72681164,
"domNodes": -200,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 118.24399999999999,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1737.2720000000754,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.069000000000003,
"layouts": 5,
"layoutDurationMs": 18.775,
"taskDurationMs": 1458.3780000000002,
"heapDeltaBytes": 17798620,
"heapUsedBytes": 100549780,
"domNodes": 19229,
"jsHeapTotalBytes": 20447232,
"scriptDurationMs": 38.95399999999999,
"eventListeners": 3566,
"totalBlockingTimeMs": 229,
"frameDurationMs": 20.883132530120484,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 11571.775000000001,
"styleRecalcs": 249,
"styleRecalcDurationMs": 33.945,
"layouts": 7,
"layoutDurationMs": 2.272,
"taskDurationMs": 7242.742,
"heapDeltaBytes": -6599608,
"heapUsedBytes": 83476936,
"domNodes": -274,
"jsHeapTotalBytes": 5337088,
"scriptDurationMs": 3275.6929999999998,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66599423631124,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10808.058999999957,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.256,
"layouts": 8,
"layoutDurationMs": 2.13,
"taskDurationMs": 6590.489,
"heapDeltaBytes": -18935332,
"heapUsedBytes": 62848624,
"domNodes": -274,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 2945.42,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66604938271605,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 24925.22200000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24097.875,
"heapDeltaBytes": -13513532,
"heapUsedBytes": 287101404,
"domNodes": -3482,
"jsHeapTotalBytes": 10469376,
"scriptDurationMs": 345.654,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.81792618629175,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-idle",
"durationMs": 24925.601000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24125.011000000002,
"heapDeltaBytes": -9227272,
"heapUsedBytes": 288086096,
"domNodes": -3482,
"jsHeapTotalBytes": 9158656,
"scriptDurationMs": 381.48400000000004,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.74070175438596,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 29680.751999999986,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.69500000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 29350.100999999995,
"heapDeltaBytes": -27230348,
"heapUsedBytes": 256569172,
"domNodes": -3482,
"jsHeapTotalBytes": 11255808,
"scriptDurationMs": 927.4500000000002,
"eventListeners": -659,
"totalBlockingTimeMs": 33,
"frameDurationMs": 55.06920222634508,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 29217.205000000034,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.522000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28803.16,
"heapDeltaBytes": -6464024,
"heapUsedBytes": 278523220,
"domNodes": -3482,
"jsHeapTotalBytes": 13877248,
"scriptDurationMs": 891.922,
"eventListeners": -659,
"totalBlockingTimeMs": 28,
"frameDurationMs": 54.00277264325324,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8936.532,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.28599999999999,
"layouts": 20,
"layoutDurationMs": 24.08600000000001,
"taskDurationMs": 8804.964000000002,
"heapDeltaBytes": -12423592,
"heapUsedBytes": 284253768,
"domNodes": -3482,
"jsHeapTotalBytes": 17551360,
"scriptDurationMs": 140.19799999999998,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 50.18539325842696,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 8790.041999999972,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.00599999999999,
"layouts": 20,
"layoutDurationMs": 22.58199999999999,
"taskDurationMs": 8636.057,
"heapDeltaBytes": -27067148,
"heapUsedBytes": 269812400,
"domNodes": -3482,
"jsHeapTotalBytes": 7852032,
"scriptDurationMs": 155.81699999999998,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 50.284000000000006,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12605.541000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12293.174,
"heapDeltaBytes": 16023468,
"heapUsedBytes": 280268124,
"domNodes": 0,
"jsHeapTotalBytes": -2883584,
"scriptDurationMs": 169.52100000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.38931034482759,
"p95FrameDurationMs": 83.5
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12420.387000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11886.054999999998,
"heapDeltaBytes": -2710008,
"heapUsedBytes": 261743352,
"domNodes": 0,
"jsHeapTotalBytes": 20971520,
"scriptDurationMs": 163.21600000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.66735395189002,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 522.5259999999707,
"styleRecalcs": 21,
"styleRecalcDurationMs": 13.309000000000001,
"layouts": 11,
"layoutDurationMs": 4.952,
"taskDurationMs": 164.375,
"heapDeltaBytes": -8690664,
"heapUsedBytes": 62183716,
"domNodes": 136,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 19.702,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664516129032254,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 506.9740000000138,
"styleRecalcs": 21,
"styleRecalcDurationMs": 10.221,
"layouts": 13,
"layoutDurationMs": 4.359999999999999,
"taskDurationMs": 147.088,
"heapDeltaBytes": -8934284,
"heapUsedBytes": 64689440,
"domNodes": 133,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 12.937,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 610.1840000000038,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.65,
"layouts": 76,
"layoutDurationMs": 16.205000000000002,
"taskDurationMs": 566.9839999999999,
"heapDeltaBytes": 807404,
"heapUsedBytes": 49113584,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 274.11600000000004,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 664.7629999999936,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.695,
"layouts": 76,
"layoutDurationMs": 16.869,
"taskDurationMs": 628.163,
"heapDeltaBytes": 419924,
"heapUsedBytes": 36850048,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 305.761,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 683.2670000000007,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.263,
"layouts": 76,
"layoutDurationMs": 16.854,
"taskDurationMs": 651.824,
"heapDeltaBytes": -24731408,
"heapUsedBytes": 77765352,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 267.665,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536566,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 614.0470000000278,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.689,
"layouts": 76,
"layoutDurationMs": 15.945999999999998,
"taskDurationMs": 587.0790000000001,
"heapDeltaBytes": 1292852,
"heapUsedBytes": 104299308,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 237.66199999999998,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage: 🟡 59.3% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3221 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since ae9e1d821ba0b9b1216d9a0a0a29c3a2cc08afd6
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (356)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.60 #22957 +/- ##
=============================================
Coverage ? 87.51%
=============================================
Files ? 2890
Lines ? 159560
Branches ? 42738
=============================================
Hits ? 139633
Misses ? 19164
Partials ? 763
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #19625 to
cloud/1.60Automatically created by backport workflow.