Repository navigation
docs(adr): keep the unsent draft when switching between existing chats - #22948
Conversation
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 10 minutes for your next included review. View limit details
|
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since f492f7c591c75822419fb894dcf90956753ceac6
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (360)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed the ADR amendment at 9b62047 against trackDraftThread(), its AgentPanelRoot watcher and the existing persistence tests. Keeping typed input across existing-chat switches matches the implementation. One wording question remains about what survives a refresh; please clarify that scope before approval. This is documentation only, so no additional runtime test is requested. Reviewer-run checks: NOT_RUN.
| (amended 2026-11-01 for PM-2251). Leaving a failed history selection with Back keeps the unsent | ||
| text and follows the visible workflow. | ||
| text and follows the visible workflow. Switching to another existing chat through history keeps | ||
| the unsent draft; only New Chat clears it, and the draft also survives a page refresh (amended |
There was a problem hiding this comment.
question: Could the refresh sentence name the persisted parts explicitly? The preceding paragraph defines the unsent draft to include attachments and staged node references, but agentComposerStore persists only text and workflowReferences and restores with attachments: []; its existing test explicitly says 'restores text and workflow references, dropping node references and attachments'. As written, 'the draft also survives a page refresh' can promise preservation of those discarded items. If this amendment records current behavior, please scope that clause to text and workflow references; if broader restoration is intended, please distinguish that future decision from what main implements.
There was a problem hiding this comment.
Good catch, fixed in a256973: the sentence now says a refresh restores the draft's text and workflow references for the same chat, and that attachments and staged node references are not restored. That is what main does today.
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 97 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
dante01yoon
left a comment
There was a problem hiding this comment.
Re-reviewed a256973. The refresh clause now explicitly restores text and workflow references for the same chat and excludes attachments and staged node references, matching trackDraftThread() and the existing persistence test. The existing-chat versus New Chat decision is clear, and there are no remaining wording blockers.
This is documentation only; the exact-head checks are settled successfully with expected skips. No runtime behavior or release claim is implied. Reviewer-run tests, builds, type checks and runtime QA: NOT_RUN.
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit a256973 has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
Summary
Records a product decision in ADR-AGENT-TARGET-0037: switching to another existing chat through history keeps the unsent draft. Only New Chat clears it (#21588), and the draft also survives a page refresh (#22821).
Changes
docs/adr/AGENT-TARGET-0037-...md. Docs only, no behavior change.mainalready does. The old ticket for clearing it, PM-1517, stays canceled.Review Focus
Wording only. This matches the current behavior of
agentComposerStore.trackDraftThread, which keeps the draft on a thread switch.Refs PM-1517, PM-2251, PM-2002