Repository navigation
fix(agent): let the page own the agent transport, not the panel (FRONT-3582) - #22926
Conversation
## Summary Uses the websocket contract Comfy-Org/ComfyUI#16763 and #16809 shipped, which the frontend never adopted: `queuePrompt` sent no `workflow_metadata`, so the server had nothing to stamp beyond the id inside `extra_pnginfo`. This sends it, reads what comes back, and uses it to place a job that no per-tab mapping knows about. Replaces #20045. #21666 landed the instance-keyed gate for the Agent while that PR was in review, so the headline cross-tab fix is already on main. What was left is here, rebuilt on top of it. ## Changes - `queuePrompt` sends `workflow_metadata: { workflow_id }`, and the stamped id is forwarded to the gate from `execution_start`, `progress_state`, the `executed` listener, and the binary preview header, whose decoder was dropping it. - The ownership gate — now `rememberStampAndCheckActiveWorkflow`, named for the per-job stamp it records — gains two legs below `instanceId`: the session path, then the frame's own workflow id. The graph id is the weakest leg on purpose, because every copy of a workflow shares it, so copy-paste into a new tab gives two tabs one id and keying on it first makes each match the other's jobs. - The all-zero UUID is discarded rather than compared, on both sides. It is `LGraph._id`'s default and the codebase reads it as "no id yet", so comparing it as a real id matched nothing and rejected a fresh graph's own frames. - `forgetFinishedJobs` releases the tab's workflow status. Only a terminal frame cleared it, so a job that ended without one left the badge claiming the tab was running for the rest of the session. It releases an orphaned Running badge only: a workflow whose newer job already completed keeps its Completed or Failed badge when an older unreadable job is forgotten. - ADR-EXECUTION-ROUTING-0049 records the resolution order and that the unresolvable-frame fallback departs from ADR-GRAPH-DOCUMENT-0026 D2, with the condition for removing the exception. ## Review focus - **#21666's gate had no unit coverage**, and the existing `executionStore` fixtures carry no `instanceId`, so nothing exercised the instance leg. `executionStore.workflowOwnership.test.ts` covers it first, so the behaviour this builds on is pinned before anything is added to it. - **The unresolvable fallback is the weakest point.** It is narrower than permissive, since a foreign job's unresolvable frame is dropped while another job is active, but with two tabs open and a frame unresolvable it can still land on the wrong one. The ADR says so. - **`progress_text` is still unattributable on current core.** Core packs it as a binary frame `send_sync` cannot stamp, and the frontend decodes a job id out of it only under `supports_progress_text_metadata`, which no core version sets — so the gate is called with no job id and returns before any stamp lookup. Comfy-Org/ComfyUI#16887 is what unblocks the leg. ## Tests Every change is verified by mutation: the fix reverted and the test confirmed to fail. Each wire boundary falsifies on its own — dropping the `workflow_metadata` spread fails the request rows, dropping the `!== zeroUuid` guard fails the sentinel row, removing `workflowId` from the type-4 decoder fails the preview decode, and removing either app forwarding argument fails the unmapped-routing case. Removing the instance comparison fails the shared-graph case, the path leg two, the workflow-id leg one, and the status release one. Store, request and decoder coverage lives in `executionStore.workflowOwnership.test.ts`, `executionStore.terminalRecovery.test.ts`, `api.queuePrompt.test.ts`, `api.previewMetadata.test.ts` and `app.test.ts`. `typecheck:app`, `typecheck:browser` and the `fallow` audit gate are clean, with 0 introduced findings of any kind. Both store suites register tabs through `workflowStore.attachWorkflow` rather than assigning `openWorkflows`, because `applyWorkflowStatus` refuses to record a status for a workflow the real `isOpen` does not consider open. Assigning the computed made the premise silently false. `browser_tests/tests/wsReconnectStaleJob.spec.ts` carries the black-box regression for the status release. It strands one unreadable job on each of two workflows — one of them the workflow's only job, the other alongside a live sibling — and uses the orphaned workflow's badge disappearing as the cleanup barrier before asserting the sibling's badge survives, because the detail-request counters move before the responses are fulfilled and cannot establish completion. Verified three ways on `--project=chromium`: 6/6 green on the repair and 3/3 on `--repeat-each=3`; failing at the barrier when cleanup is prevented from running, so the barrier is not vacuous; and failing at the sibling assertion under the pre-#22013 clear ordering. #20700 still covers replacing the remaining scripted reconnect specs with real-backend tests. ## Sibling overlap Overlaps #20982 (draft) at `packages/api-client/src/ComfyApi.ts`, where both add a different member to the same `BackendApiCalls` interface: that PR an `agent_status` entry, this one `workflowId` on the existing `b_preview_with_metadata` entry. No shared behaviour or symbol. **#11951 conflicts on policy, not on text.** It proposes a `messageMatchesActiveWorkflow` resolver that consults the frame's workflow id ahead of session ownership — the inverse of the order decided here, and the order that makes two tabs sharing one copied graph id match each other's jobs. Its resolver is superseded; remaining work there should be carried onto this gate rather than restoring the id-first policy during integration. Recorded in ADR-EXECUTION-ROUTING-0049 under the rejected alternatives. Needs a human call rather than being settled by this PR. **#22186 landed first, and this branch carried the contracts across.** It merged 2026-10-30 (`d9290b0`), moving the API and execution contracts into `packages/api-client`. The merge of `main` at `24b64d62` relocated this PR's request field, preview decoding and stamped types into `packages/api-client/src/ComfyApi.ts` and `packages/api-client/src/executionTypes.ts`. The relocation is content-identical: comparing this PR's own diff before the merge (`9facf6c7`..`a8e25943`) against after it (`1bbea48f`..`24b64d62`), the entire changed-line delta is two lines out and six in, all in `api.previewMetadata.test.ts` — the `ComfyApi` import path and the constructor options the package now requires. No production line changed. **#22271 (open) overlaps on ownership policy.** It adds an unconditional `detail.workflow_id !== this.rootGraph.id` rejection after the output ownership check, which can reject a job this PR's stronger instance/path identity accepts, and treats the all-zero UUID as a real identity rather than the "no id yet" default this PR discards. Its remaining coverage should be carried onto this PR's single ownership decision rather than kept as an independent guard. Same class of conflict as #11951, and the same kind of human call. Proposed order is this PR first, since #20982 is a draft that has not moved since 2026-10-18, then a one-line rebase there. Reversed is equally cheap: this branch would merge main and re-add its line. ## Derivation, and the control that it is load-bearing `workflow_metadata` is no longer hand-declared. #22426 is on `main`, so both wire types now come from `@comfyorg/comfyui-api-types`, which generates core's `PromptRequest` from `openapi.yaml` pinned at `4281eb0a14`: ```ts // request — the spec's map narrowed to the one key this client sends workflow_metadata?: Pick<PromptWorkflowMetadata, 'workflow_id'> // frame — the map's VALUE type, not the map type StampedWorkflowId = { workflow_id?: PromptWorkflowMetadata[string] } ``` Core's spec defines no websocket frame schemas. It documents that `workflow_metadata` is echoed onto every JSON frame carrying a `prompt_id`, so the frame field is that request contract read back. The frame carries the map's contents merged into the frame object, which is why the value type is what transfers — a `Pick` or `Partial` of the map would describe the wrong shape here even though it would compile. The dependency is on `packages/api-client`, not the app, since `ComfyApi` builds the body. ### Verification Evidence **1. Delete the member from the pinned spec, regenerate — `pnpm typecheck` fails.** ``` packages/comfyui-api-types/src/index.ts(9,29): error TS2339: Property 'workflow_metadata' does not exist on type 'PromptRequest'. ``` Restored: spec hash back to `8f0da854…`, `check:generated` 0, `typecheck` 0. **2. That is not sufficient on its own.** The error above surfaces at the package's own alias — the first link in the chain — so it does not show that consumers are tied to the spec. Isolating them: retype the spec's value to `integer` *and* relax the package's `Record<string, string>` constraint, leaving consumers as the only thing that can fail. The retype reaches real call sites: ``` src/stores/executionStore.ts(592,38): error TS2345: Argument of type 'number | undefined' is not assignable to parameter of type 'string | undefined'. src/stores/executionStore.ts(593,55): error TS2345: … src/stores/executionStore.ts(752,64): error TS2345: … src/scripts/app.ts(782,11): error TS2345: … ``` Both controls reverted. Gates after restore: `typecheck` 0, `typecheck:browser` 0, `oxlint --type-aware` on both changed files 0 (verified scanning — an injected `no-explicit-any` is reported), 239 `packages/api-client` tests passing. `main` was merged rather than rebased, so existing review anchors are preserved.
…mber notice fact (#22914) ## Summary The Billing tab shows the member auto top-up block ("Contact a workspace owner to manage this.") only when the server serves `can_view_auto_top_up_member_notice: true`, so a member on a paused Team workspace no longer sees it. The owner card now renders the served `can_view_auto_top_up` instead of the BE-25243 interim combination. Stacked on #22913 (ingest-types sync). ## Why QA case E1 on 1.60: a Member on a paused Team workspace still sees the member block; the design hides it while paused. https://comfy-organization.slack.com/archives/C0932CGKT5K/p1793803745327049 ## Root cause `deriveAutoTopUpSection` showed the member block for any `denied_reasons.can_manage_auto_top_up === 'not_workspace_owner'`. That denial only says the actor is not an owner; it says nothing about the workspace being paused or past due, so a paused member qualified. The backend now serves that answer directly (cloud#18078). ## How - `useBillingCapabilities` exposes `canViewAutoTopUpMemberNotice` as `receiveServerFact('can_view_auto_top_up_member_notice', ...)`. - `canViewAutoTopUpCard` reads `receiveServerFact('can_view_auto_top_up', ...)` (cloud#17972). The `pendingServerFact('BE-25243', canManageAutoTopUp && canTopUp)` wrapper is deleted, as `pendingServerFact` requires once the field ships. - `deriveAutoTopUpSection` takes `canViewAutoTopUpMemberNotice` in place of `manageAutoTopUpDenial` and shows `memberBlock` when it is true, still inside `auto_top_up_enabled` and after the card check. - `manageAutoTopUpDenial` had no other reader and is removed from the composable and its mock. Commits: the test commit (`test(billing): ...`) goes red on the member block, the core table and the served card fact; it carries the type surface the tests compile against (the new fact on the composable, its mock, and `AutoTopUpSectionFacts`), because the pre-commit typecheck rejects a test against an API that does not exist yet. The fix commit changes no tests. ## Verification - `pnpm exec vitest run src/platform/billing src/platform/account`: 4061/4061. - account-core `src/core/billing/billingTab`: 137/137. - Red commit alone: BillingTab member block, the core "member on a healthy workspace" row and the three served `can_view_auto_top_up` composable cases fail; the fix commit turns them green. - `pnpm typecheck`, `typecheck:account-core`, knip: clean. | | AS IS | TO BE | | --- | --- | --- | | Member, paused Team workspace | <img alt="AS IS: Member, paused Team workspace" src="https://gist.githubusercontent.com/dante01yoon/c914fc8fd60fb6db3dc2a5b24ca0a441/raw/18f42041227d6bfaeb283d1746bb36dc23e0ed5a/pr22914-as-is-paused-member.png" width="480"> | <img alt="TO BE: Member, paused Team workspace" src="https://gist.githubusercontent.com/dante01yoon/c914fc8fd60fb6db3dc2a5b24ca0a441/raw/18f42041227d6bfaeb283d1746bb36dc23e0ed5a/pr22914-to-be-paused-member.png" width="480"> | | Member, healthy Team workspace | <img alt="AS IS: Member, healthy Team workspace" src="https://gist.githubusercontent.com/dante01yoon/c914fc8fd60fb6db3dc2a5b24ca0a441/raw/18f42041227d6bfaeb283d1746bb36dc23e0ed5a/pr22914-as-is-healthy-member.png" width="480"> | <img alt="TO BE: Member, healthy Team workspace" src="https://gist.githubusercontent.com/dante01yoon/c914fc8fd60fb6db3dc2a5b24ca0a441/raw/18f42041227d6bfaeb283d1746bb36dc23e0ed5a/pr22914-to-be-healthy-member.png" width="480"> | | Owner, healthy Team workspace | <img alt="AS IS: Owner, healthy Team workspace" src="https://gist.githubusercontent.com/dante01yoon/c914fc8fd60fb6db3dc2a5b24ca0a441/raw/18f42041227d6bfaeb283d1746bb36dc23e0ed5a/pr22914-as-is-healthy-owner.png" width="480"> | <img alt="TO BE: Owner, healthy Team workspace" src="https://gist.githubusercontent.com/dante01yoon/c914fc8fd60fb6db3dc2a5b24ca0a441/raw/18f42041227d6bfaeb283d1746bb36dc23e0ed5a/pr22914-to-be-healthy-owner.png" width="480"> | ## Risk Both capability booleans are required in the generated zod. Without them from prod ingest, the SDK capabilities read fails to decode; the legacy read falls back to `false` and hides the card and the member block. Ingest must ship cloud#17972 and cloud#18078 before this.
…T-3582) Stage 1a of CRDT-FOLLOWER-0052. Closing the Agent panel is an ordinary unmount — DockedAgentPanel renders the root under v-if — and the panel constructed the agent event source and the doc-frame transport in its own setup, destroying the transport in onBeforeUnmount. The event source reference-counts its socket by listener count and disconnects at zero, so that teardown dropped the doc-frame tap and the session stream together and closed the socket outright. Reopening the panel had to dial a fresh connection, re-read credentials, and pay reconnect backoff for a panel the user had only toggled. Both are now page-session resources in agentPageSession.ts, which the panel consumes. The socket needs no new lifetime machinery: a surviving tap keeps it open under the reference-counting rule the event source already has. This is the prerequisite half of Stage 1, not the whole stage. The replica is still panel-owned, so the deleted-while-closed divergence (the ADR's cost A) is NOT fixed here — that needs the document-keyed session registry (Stage 1b) and the cold-seed declaration (Stage 3). Landing the transport first because a registry that leaves the transport panel-owned produces a session that can neither receive an update nor resubscribe, which is worse than today's honest cold seed. Guards, because an ADR without one is a suggestion: - A page-session-owns-transport rule in check-follower-invariants.ts, scoped wider than the follower seam so it can see AgentPanelRoot.vue — the call site it exists to forbid. It parses .vue script blocks with offsets preserved, so it reports the real line in the component. Verified to flag the parent at :263 and :268. - An assert in the owner's create path naming the one-transport-per-page invariant and linking the ADR. - The guard had no CI enforcement at all: no workflow runs follower-invariants:check and every existing test used temp dirs, so a violation landed green. It is now also asserted against the real repository tree from the test suite, which is a required check. Tests: one black-box case in browser_tests, red on the parent (connection count 2) and green here (1), driving a real turn so the follower actually subscribes — without that the tap never exists and the spec would be red both sides. Plus unit cover for the owner. The two panel suites reset the page session per test, since each test is a fresh page load and the transport is no longer torn down with the component.
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 10 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-04T22:57:47.142Z",
"gitSha": "75e68668dbf3ae01ab66f9009ce26282ff0417c8",
"branch": "front-3582-stage1-document-owned-follower-session",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.2649999999808,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.521,
"layouts": 8,
"layoutDurationMs": 2.432,
"taskDurationMs": 550.963,
"heapDeltaBytes": 12163828,
"heapUsedBytes": 82065816,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 9.774999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2056.8960000000516,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.73,
"layouts": 8,
"layoutDurationMs": 2.534,
"taskDurationMs": 591.0060000000001,
"heapDeltaBytes": 3621988,
"heapUsedBytes": 65345552,
"domNodes": -178,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 9.485999999999997,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406503,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1893.9560000000029,
"styleRecalcs": 78,
"styleRecalcDurationMs": 13.533999999999999,
"layouts": 9,
"layoutDurationMs": 2.71,
"taskDurationMs": 948.5310000000001,
"heapDeltaBytes": 3204648,
"heapUsedBytes": 72808876,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 170.053,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66637168141593,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1991.1150000000362,
"styleRecalcs": 81,
"styleRecalcDurationMs": 13.509,
"layouts": 9,
"layoutDurationMs": 2.466,
"taskDurationMs": 995.322,
"heapDeltaBytes": -9620248,
"heapUsedBytes": 52551208,
"domNodes": -163,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 178.067,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.806779661016947,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.3199999999956,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.123999999999999,
"layouts": 11,
"layoutDurationMs": 2.8339999999999996,
"taskDurationMs": 435.60699999999997,
"heapDeltaBytes": 1972252,
"heapUsedBytes": 63886276,
"domNodes": 57,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 11.629000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.5560000000014,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.136,
"layouts": 10,
"layoutDurationMs": 2.6959999999999997,
"taskDurationMs": 440.85300000000007,
"heapDeltaBytes": 5103480,
"heapUsedBytes": 73781088,
"domNodes": 57,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 12.095999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 693.7880000000405,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.788,
"layouts": 9,
"layoutDurationMs": 2.544,
"taskDurationMs": 514.282,
"heapDeltaBytes": 8595160,
"heapUsedBytes": 77536124,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 168.603,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 677.6740000000245,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.6670000000000003,
"layouts": 9,
"layoutDurationMs": 2.5860000000000007,
"taskDurationMs": 509.68199999999996,
"heapDeltaBytes": 5749424,
"heapUsedBytes": 67754596,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 167.269,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1159.4719999999938,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 847.2610000000001,
"heapDeltaBytes": 28497100,
"heapUsedBytes": 98617640,
"domNodes": 0,
"jsHeapTotalBytes": 11436032,
"scriptDurationMs": 68.76599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 522,
"frameDurationMs": 34.84848484848485,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1144.0399999999045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 825.3660000000001,
"heapDeltaBytes": 28351244,
"heapUsedBytes": 98414872,
"domNodes": 0,
"jsHeapTotalBytes": 12222464,
"scriptDurationMs": 67.353,
"eventListeners": 0,
"totalBlockingTimeMs": 509,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 905.856999999969,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 570.2530000000002,
"heapDeltaBytes": 8290172,
"heapUsedBytes": 84726580,
"domNodes": -208,
"jsHeapTotalBytes": 655360,
"scriptDurationMs": 171.244,
"eventListeners": -107,
"totalBlockingTimeMs": 227,
"frameDurationMs": 24.997222222222213,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 891.138000000069,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.3080000000004,
"heapDeltaBytes": -29642132,
"heapUsedBytes": 63707852,
"domNodes": 0,
"jsHeapTotalBytes": 5373952,
"scriptDurationMs": 171.05900000000003,
"eventListeners": -107,
"totalBlockingTimeMs": 235,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11413.166999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10492.377,
"heapDeltaBytes": -22345536,
"heapUsedBytes": 69545780,
"domNodes": -274,
"jsHeapTotalBytes": 9302016,
"scriptDurationMs": 8422.901000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 1302,
"frameDurationMs": 32.15830985915493,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10361.499000000094,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9504.442,
"heapDeltaBytes": 85230884,
"heapUsedBytes": 161866156,
"domNodes": -274,
"jsHeapTotalBytes": 72740864,
"scriptDurationMs": 7574.754,
"eventListeners": -69,
"totalBlockingTimeMs": 820,
"frameDurationMs": 31.3178247734139,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11427.340000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10667.313,
"heapDeltaBytes": 93617040,
"heapUsedBytes": 170049476,
"domNodes": -274,
"jsHeapTotalBytes": 83226624,
"scriptDurationMs": 8645.615,
"eventListeners": -69,
"totalBlockingTimeMs": 1511,
"frameDurationMs": 31.582596685082876,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10135.09099999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9308.7,
"heapDeltaBytes": -23966284,
"heapUsedBytes": 68635404,
"domNodes": -274,
"jsHeapTotalBytes": 11399168,
"scriptDurationMs": 7414.798,
"eventListeners": -69,
"totalBlockingTimeMs": 675,
"frameDurationMs": 31.371207430340558,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "large-combo-open",
"durationMs": 229.05500000001666,
"styleRecalcs": 20,
"styleRecalcDurationMs": 12.411999999999999,
"layouts": 6,
"layoutDurationMs": 1.9989999999999999,
"taskDurationMs": 171.469,
"heapDeltaBytes": 14548408,
"heapUsedBytes": 73264976,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.476999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 6,
"frameDurationMs": 23.329999999999973,
"p95FrameDurationMs": 83.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 222.16699999989942,
"styleRecalcs": 21,
"styleRecalcDurationMs": 13.017,
"layouts": 8,
"layoutDurationMs": 2.3829999999999996,
"taskDurationMs": 160.045,
"heapDeltaBytes": 14535348,
"heapUsedBytes": 74103732,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.59,
"eventListeners": 205,
"totalBlockingTimeMs": 1,
"frameDurationMs": 24.066666666666656,
"p95FrameDurationMs": 83.19999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2057.0450000000164,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7389999999999994,
"layouts": 9,
"layoutDurationMs": 2.866,
"taskDurationMs": 688.2279999999998,
"heapDeltaBytes": 12515252,
"heapUsedBytes": 86266728,
"domNodes": -274,
"jsHeapTotalBytes": 126976,
"scriptDurationMs": 36.050999999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2055.9150000000272,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.287,
"layouts": 8,
"layoutDurationMs": 2.3549999999999995,
"taskDurationMs": 662.907,
"heapDeltaBytes": -8167212,
"heapUsedBytes": 64727860,
"domNodes": -274,
"jsHeapTotalBytes": 389120,
"scriptDurationMs": 30.401000000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2644.6370000000456,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.471,
"layouts": 7,
"layoutDurationMs": 1.5599999999999998,
"taskDurationMs": 1758.6989999999998,
"heapDeltaBytes": -15748092,
"heapUsedBytes": 60947900,
"domNodes": -274,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 817.525,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.771518987341775,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2609.9879999999303,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.293999999999999,
"layouts": 6,
"layoutDurationMs": 1.4329999999999998,
"taskDurationMs": 1749.5849999999998,
"heapDeltaBytes": -4302332,
"heapUsedBytes": 71292112,
"domNodes": -274,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 823.247,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.774193548387096,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3830.941999999993,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.635,
"layouts": 64,
"layoutDurationMs": 10.777999999999999,
"taskDurationMs": 1802.255,
"heapDeltaBytes": 529768,
"heapUsedBytes": 76809804,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 798.851,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666086956521738,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3943.3070000000043,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.981999999999998,
"layouts": 63,
"layoutDurationMs": 10.515,
"taskDurationMs": 1868.8719999999998,
"heapDeltaBytes": -14960420,
"heapUsedBytes": 61044912,
"domNodes": -250,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 786.377,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666244725738395,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3209.339,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.872999999999998,
"layouts": 3,
"layoutDurationMs": 0.7690000000000001,
"taskDurationMs": 2056.95,
"heapDeltaBytes": -8548728,
"heapUsedBytes": 69120644,
"domNodes": 0,
"jsHeapTotalBytes": 7991296,
"scriptDurationMs": 995.2330000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 16,
"frameDurationMs": 16.9282722513089,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3065.51300000001,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.1579999999999995,
"layouts": 5,
"layoutDurationMs": 1.3120000000000003,
"taskDurationMs": 2005.4050000000002,
"heapDeltaBytes": 4774688,
"heapUsedBytes": 77074628,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 958.7780000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756830601092897,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3078.7619999999833,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.672,
"layouts": 7,
"layoutDurationMs": 1.7029999999999996,
"taskDurationMs": 779.281,
"heapDeltaBytes": 24464780,
"heapUsedBytes": 98280448,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 369.159,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6654054054054,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3066.7359999999917,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.3519999999999999,
"layouts": 5,
"layoutDurationMs": 1.2500000000000002,
"taskDurationMs": 812.797,
"heapDeltaBytes": -15594124,
"heapUsedBytes": 60314276,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 362.666,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666304347826088,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2045.0049999999464,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.0759999999999996,
"layouts": 6,
"layoutDurationMs": 1.7460000000000002,
"taskDurationMs": 697.526,
"heapDeltaBytes": -10213672,
"heapUsedBytes": 63654500,
"domNodes": -274,
"jsHeapTotalBytes": -659456,
"scriptDurationMs": 34.65899999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2054.4380000000046,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9819999999999993,
"layouts": 6,
"layoutDurationMs": 1.6300000000000003,
"taskDurationMs": 680.076,
"heapDeltaBytes": -10098400,
"heapUsedBytes": 63216392,
"domNodes": -274,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 37.701,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2715.243999999984,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.177999999999999,
"layouts": 6,
"layoutDurationMs": 1.48,
"taskDurationMs": 618.7259999999999,
"heapDeltaBytes": -7319468,
"heapUsedBytes": 68968024,
"domNodes": -259,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 197.457,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665644171779142,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2778.9109999999937,
"styleRecalcs": 25,
"styleRecalcDurationMs": 11.429000000000002,
"layouts": 6,
"layoutDurationMs": 1.687,
"taskDurationMs": 565.9040000000001,
"heapDeltaBytes": 6787420,
"heapUsedBytes": 79740952,
"domNodes": 19,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 190.09599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66586826347305,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3340.8569999999713,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.864,
"layouts": 7,
"layoutDurationMs": 1.9690000000000003,
"taskDurationMs": 975.414,
"heapDeltaBytes": -6343752,
"heapUsedBytes": 69559508,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 383.673,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.749748743718595,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3319.4160000000466,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.47,
"layouts": 5,
"layoutDurationMs": 1.4529999999999998,
"taskDurationMs": 967.1509999999998,
"heapDeltaBytes": -8042004,
"heapUsedBytes": 67356752,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 390.69699999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666331658291455,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 658.5929999999962,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.170999999999999,
"layouts": 9,
"layoutDurationMs": 2.3680000000000003,
"taskDurationMs": 470.81300000000005,
"heapDeltaBytes": 4717700,
"heapUsedBytes": 76962156,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 148.143,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66923076923077,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 638.4480000000394,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.971,
"layouts": 9,
"layoutDurationMs": 2.1799999999999997,
"taskDurationMs": 461.0040000000001,
"heapDeltaBytes": 2316296,
"heapUsedBytes": 65414816,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 146.65800000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2057.1350000000166,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.9260000000000006,
"layouts": 8,
"layoutDurationMs": 2.318,
"taskDurationMs": 600.7399999999999,
"heapDeltaBytes": -10247172,
"heapUsedBytes": 64137472,
"domNodes": -200,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 8.919,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.6830000000527,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.7889999999999997,
"layouts": 9,
"layoutDurationMs": 2.652,
"taskDurationMs": 562.8120000000001,
"heapDeltaBytes": 11763424,
"heapUsedBytes": 82975752,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 9.198000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1730.3530000000364,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.542000000000002,
"layouts": 8,
"layoutDurationMs": 2.2510000000000003,
"taskDurationMs": 897.719,
"heapDeltaBytes": 12239464,
"heapUsedBytes": 72552152,
"domNodes": -200,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 109.64999999999999,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.2150000000856,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.492,
"layouts": 9,
"layoutDurationMs": 2.7799999999999994,
"taskDurationMs": 924.195,
"heapDeltaBytes": 7225132,
"heapUsedBytes": 69180072,
"domNodes": -200,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 114.612,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665048543689316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1558.712000000014,
"styleRecalcs": 18,
"styleRecalcDurationMs": 27.040999999999997,
"layouts": 5,
"layoutDurationMs": 19.773,
"taskDurationMs": 1298.2459999999999,
"heapDeltaBytes": 12936376,
"heapUsedBytes": 99164404,
"domNodes": 19229,
"jsHeapTotalBytes": 18747392,
"scriptDurationMs": 31.089,
"eventListeners": 3566,
"totalBlockingTimeMs": 200,
"frameDurationMs": 20.511538461538457,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "viewport-pan-sweep",
"durationMs": 10376.360999999975,
"styleRecalcs": 251,
"styleRecalcDurationMs": 30.617999999999995,
"layouts": 8,
"layoutDurationMs": 2.038,
"taskDurationMs": 6325.464999999999,
"heapDeltaBytes": 2480412,
"heapUsedBytes": 83819152,
"domNodes": -274,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 2788.342,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69291465378422,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10168.342000000051,
"styleRecalcs": 249,
"styleRecalcDurationMs": 29.586000000000002,
"layouts": 7,
"layoutDurationMs": 1.8920000000000001,
"taskDurationMs": 6230.868,
"heapDeltaBytes": -12579360,
"heapUsedBytes": 62300548,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 2726.7380000000003,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666065573770492,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 24429.663000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23567.824,
"heapDeltaBytes": -44094328,
"heapUsedBytes": 258898220,
"domNodes": -3482,
"jsHeapTotalBytes": 9420800,
"scriptDurationMs": 330.62,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.68479020979021,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 24633.97300000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23643.059,
"heapDeltaBytes": -20668848,
"heapUsedBytes": 277186664,
"domNodes": -3482,
"jsHeapTotalBytes": 10207232,
"scriptDurationMs": 360.916,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.543005181347155,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 29262.239000000023,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.980999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28906.779,
"heapDeltaBytes": 25558144,
"heapUsedBytes": 277779176,
"domNodes": -3482,
"jsHeapTotalBytes": 16252928,
"scriptDurationMs": 890.6419999999999,
"eventListeners": -659,
"totalBlockingTimeMs": 22,
"frameDurationMs": 53.66752293577982,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 29392.898999999943,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.680000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 29005.164,
"heapDeltaBytes": -11858072,
"heapUsedBytes": 271783132,
"domNodes": -3482,
"jsHeapTotalBytes": 8900608,
"scriptDurationMs": 914.95,
"eventListeners": -659,
"totalBlockingTimeMs": 37,
"frameDurationMs": 54.67565055762081,
"p95FrameDurationMs": 100.10000000000582
},
{
"name": "vue-node-resize-workload",
"durationMs": 8476.357000000007,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.998,
"layouts": 20,
"layoutDurationMs": 22.709000000000007,
"taskDurationMs": 8377.33,
"heapDeltaBytes": 18636116,
"heapUsedBytes": 272330604,
"domNodes": -3482,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 130.23,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.47428571428571,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8444.151999999918,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.79399999999999,
"layouts": 20,
"layoutDurationMs": 21.334000000000007,
"taskDurationMs": 8331.967999999999,
"heapDeltaBytes": 11511268,
"heapUsedBytes": 281812620,
"domNodes": -3486,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 119.55300000000001,
"eventListeners": -661,
"totalBlockingTimeMs": 19,
"frameDurationMs": 50.90180722891566,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12335.835999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11848.669000000002,
"heapDeltaBytes": 30697200,
"heapUsedBytes": 281145912,
"domNodes": 0,
"jsHeapTotalBytes": 19136512,
"scriptDurationMs": 171.30899999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.38041237113402,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12517.365000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12072.378999999997,
"heapDeltaBytes": -4690028,
"heapUsedBytes": 263217344,
"domNodes": 0,
"jsHeapTotalBytes": 19398656,
"scriptDurationMs": 166.115,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.916140350877185,
"p95FrameDurationMs": 100
},
{
"name": "workflow-execution",
"durationMs": 129.39300000005005,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.453999999999999,
"layouts": 8,
"layoutDurationMs": 3.7039999999999997,
"taskDurationMs": 92.31900000000002,
"heapDeltaBytes": 4891652,
"heapUsedBytes": 72358092,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.744000000000002,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999966,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 190.71999999994205,
"styleRecalcs": 12,
"styleRecalcDurationMs": 13.814,
"layouts": 10,
"layoutDurationMs": 4.507,
"taskDurationMs": 129.25400000000002,
"heapDeltaBytes": 4889700,
"heapUsedBytes": 72427044,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.671999999999999,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.366666666666635,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 446.00900000000365,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6449999999999999,
"layouts": 76,
"layoutDurationMs": 14.556,
"taskDurationMs": 410.379,
"heapDeltaBytes": -4619608,
"heapUsedBytes": 40617908,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 191.53199999999998,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 486.98799999999665,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.634,
"layouts": 76,
"layoutDurationMs": 15.045,
"taskDurationMs": 447.30199999999996,
"heapDeltaBytes": -4145300,
"heapUsedBytes": 42337000,
"domNodes": 4,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 207.083,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 683.9459999999917,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.811,
"layouts": 76,
"layoutDurationMs": 17.951,
"taskDurationMs": 649.8320000000001,
"heapDeltaBytes": 932752,
"heapUsedBytes": 106789340,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 261.48400000000004,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668292682926843,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 559.6729999999752,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.528,
"layouts": 76,
"layoutDurationMs": 15.668999999999999,
"taskDurationMs": 531.699,
"heapDeltaBytes": 375880,
"heapUsedBytes": 105652436,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 212.98,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.169696969696982,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage: 🟡 59.3% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3256 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since ca294aa3e6f50703aea5f77665365572f290346d
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (360)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Review finding on the stage 1a change, and a real one: a connection that outlives the panel outlives the panel's watchers too. AgentPanelRoot owned the watcher that reconnects the agent socket when the account or workspace changes. Once the socket became page-owned, closing the panel disposed that watcher while leaving the connection up — so signing into a different account, or switching workspace, with the panel closed left a live socket authenticated for the previous context, and the panel resolved that same socket on reopen. Before stage 1a this was unreachable, because panel teardown closed the socket outright. The watcher moves to agentPageSession.ts, beside the connection whose credentials it governs, in a detached effect scope so it is not adopted by whichever component resolves the session first. The reconnect rule itself is moved verbatim — including the clause that ignores a workspace reading as null for an unchanged account — so the rule did not change while its owner did. The panel keeps the genuinely panel-scoped half, re-resolving the agent identity it holds, via the new onIdentityChange subscription. The existing socket-identity table in AgentPanelRoot.test.ts covers the mounted cases and still passes unchanged, which is the evidence that behaviour was preserved rather than reimplemented. Added alongside it: the case that was previously unreachable and is the point of this commit — an account switch made while the panel is unmounted still reconnects.
dante01yoon
left a comment
There was a problem hiding this comment.
Read-only review of 2c10a0d. The happy-path close/reopen browser regression and reported parent-red/branch-green result cover the intended connection-count change. Two lifetime edges remain in the implementation: the authentication invalidation watcher still dies with the panel, and the reconnect timer still inherits the first panel's Vue scope. Both need author-owned regression coverage before approval; see the two inline findings.
Exact-head CI is also red: adr-links reports six dangling references to CRDT-FOLLOWER-0052, which is absent from this branch. Please include the ADR dependency or update the branch once it lands, then provide passing exact-head results. Other checks were still running when read; I have not treated them as passes.
Evidence gaps specific to this diff are closed-panel account/team/host-workspace changes and closing during reconnect backoff. Mobile/dark-theme screenshots do not prove these transport lifetime cases. Reviewer tests/builds/type checks/browser/backend validation: NOT_RUN.
|
Stacked on #22919, and why. This branch's code cites One review finding from #22919 applied to the code here, and it was a genuine defect in the first commit. CodeRabbit's "move the authentication lifecycle with the page-session transport" was correct. Once the socket is page-owned it outlives the panel's watchers too, and Fixed in Evidence that behaviour was preserved rather than reimplemented: the existing socket-identity table in Re-verified on this head: 197 unit files / 5057 passed, the |
Stacked on #22919. The code here cites the ADR by path, so adr-links needs the record present in the tree; merging rather than rebasing keeps the already-pushed commits intact.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## docs/front-3582-follower-session-ownership #22926 +/- ##
=============================================================================
Coverage ? 87.56%
=============================================================================
Files ? 3039
Lines ? 162846
Branches ? 43476
=============================================================================
Hits ? 142590
Misses ? 19366
Partials ? 890
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Review finding, and the quiet half of the ownership bug the previous commits fixed loudly. A module-level singleton does not change the active Vue scope. The first useAgentPageSession() runs synchronously inside AgentPanelRoot.setup(), so constructing the event source outside the page's own scope registered createAgentEventSource's useTimeoutFn reconnect timer against the panel -- @vueuse/shared 14.4.0 calls tryOnScopeDispose(stop) (dist/index.js:1760). Closing the panel during a pending backoff then cancelled the retry while the transport and its doc tap survived, leaving a connection that could never come back. That is worse than the cold seed this change set removes, and it was invisible to the earlier tests: they resolved the accessor without ever mounting or disposing a component scope, and the browser case exercises an already-open healthy socket. The event source and the doc-frame transport are now built inside the same detached scope that already held the identity watcher, so one scope owns every page-lifetime resource and only an explicit page teardown stops it. Pinned both ways: the new cases fail on the previous arrangement and pass here. They assert the construction scope is not the resolving component's, that it stays active after that component is stopped, and that it goes inactive only on destroyAgentPageSession().
dante01yoon
left a comment
There was a problem hiding this comment.
Re-reviewed 655188f. Both original runtime findings are addressed: credential invalidation survives panel closure, and transport construction now runs inside the detached page scope. The new real-Vue scope ownership/teardown pins, together with the existing identity table, closed-panel identity case and browser close/reopen regression, are sufficient for those fixes. Keeping the local identity resolver with the still-panel-owned follower is a reasonable staged boundary because page-owned credential invalidation is already in place.
Approval is now blocked by the new repository-wide invariant test failing in exact-head CI. Shard 7 times out at scripts/check-follower-invariants.test.ts:286 in the initial attempt and both retries; unit/test and test are downstream failures of that one test. Please fix the test's execution/budget while retaining the invariant and provide passing exact-head CI. See the inline comment for the job and failure. Other unfinished checks are not passes. The performance report has no baseline, so its below-target scenarios alone do not establish a regression from this change.
Reviewer tests/builds/type checks/browser/backend validation: NOT_RUN; this finding comes from the author's exact-head CI logs.
CI caught this and it was mine: unit shard 7 went red on AssetsSidebarListView, a suite that has nothing to do with the agent panel and does not even import it. Moving the identity watcher into agentPageSession.ts put the auth, API-key and workspace stores onto that module's import graph, and the page session is reached from AgentPanelRoot.vue. That was enough to hang the unrelated suite's app bootstrap at vitest.setup.ts's appBridge.loading. It is order-dependent, which is why it hid: the whole suite in one process passes, because something else initialises those stores first, and it only fails when that file runs alone -- i.e. in its own CI shard. The page session now takes a () => SocketIdentity getter and the panel supplies it from the stores it already imported before this change set. The import graph is therefore exactly what it was on main, while the watcher still lives, and still survives, in the page's detached scope -- which is the property that matters and is still covered by the panel test that switches accounts while unmounted. Verified: the previously red suite passes alone (3.6s, was a 10s hook timeout), as do the other three files that reach the panel; the page-session suite no longer needs its firebase/auth mock at all, which is the import graph getting lighter rather than a workaround. The five residual failures in a local whole-suite run are unrelated network flakes on this host (ENOTFOUND, ECONNREFUSED :3000) and all five pass in isolation.
CI shard 7 went red and it was my own test, not the product change: the repo-tree case "the agent surface holds the transport-ownership invariant" hit vitest's default 5s timeout, with the whole file taking 21.5s on the runner. It passed here every time, which is what made it a flake I had introduced rather than a failure I had seen. Root cause: the rule's scope is the whole agent surface, about 200 files, and it parsed every one with the TypeScript compiler to look for two identifiers. Now it text-gates first and only parses files that actually mention a factory name. That is sound rather than a heuristic -- a call expression cannot exist without the callee's text in the source -- and it speeds up `pnpm follower-invariants:check` for real use too, not just the test. The file now runs in about 0.7s. Detection re-proven after the change, since a pre-filter is exactly the kind of optimisation that can quietly disable a guard: the rule still flags the parent's AgentPanelRoot.vue at :263 and :268, and the whole-tree run still scans 57 seam and 202 agent-surface files. Both repo-tree cases also carry an explicit 60s timeout now. They read and scan real files, so they are bounded by IO and runner load; inheriting a default tuned for unit tests was the wrong contract for them.
The pre-push health gate flagged two high-CRAP functions and an oversized describe block. The breaching dimension on both was "0% tested" rather than raw branching, and the honest fix for that is coverage, not a threshold bump -- these two rules are the subtlest part of the change. `toSocketIdentity` now normalises the tuple: whichever of the Firebase account or the API key user is present identifies the caller, and every slot collapses undefined to null so "not loaded yet" is not read as a change. Extracting it also drops the panel's inline arrow to a plain call. `needsReauthentication` is exported and tested directly, including the one intentional exception a reviewer asked to have written down -- a workspace blanking for an unchanged signed-in account, which happens during an ordinary workspace refresh and must not bounce the socket. Three cases pin that the exception does not over-reach: a signed-out account, and a blanked workspace while Desktop pins one, both still reconnect. That exception is now proven rather than described, which is a better answer to the review comment than prose would have been.
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed 95f10870bdd7860683332841c77199a29e86ffd1. The page-owned identity watcher and detached transport scope address the earlier account-change and reconnect-backoff findings. The repository guard keeps its enforcement assertions with a scoped scan budget; exact-head CI now has 99 successful and 18 skipped checks, with no failures or pending checks.
The PR's red/green panel-close reproduction and its auth/lifetime regression tests cover the changed behavior. No remaining change-attributable code blockers found for this stage 1a transport scope.
Reviewer execution: NOT_RUN. Validation above is author-provided evidence and GitHub CI; I did not run tests, builds, type checks, or browser QA.
9332c18
into
docs/front-3582-follower-session-ownership
Summary
Closing the Agent panel used to close the agent websocket.
DockedAgentPanelrenders the panel root underv-if, so closing it is an ordinary unmount — and the panel constructed both the agent event source and the doc-frame transport in its ownsetup, destroying the transport inonBeforeUnmount. The event source reference-counts its socket by listener count and disconnects at zero, so that one teardown dropped the doc-frame tap and the session stream together and took the connection down with them. Reopening the panel had to dial a fresh socket, re-read credentials, and pay reconnect backoff — for a panel the user had only toggled.Both are now page-session resources in
agentPageSession.ts, which the panel consumes rather than constructs. The socket needed no new lifetime machinery: a surviving tap keeps it open under the reference-counting rule the event source already had.This is stage 1a of ADR-CRDT-FOLLOWER-0052 (
docs/adr/CRDT-FOLLOWER-0052-the-workflow-document-owns-the-follower-session.md), which moves follower-session ownership from the Agent panel to the workflow document.It is deliberately the prerequisite half, not the whole stage. The replica is still panel-owned, so the deleted-while-closed divergence the ADR records as cost A is not fixed here — that needs the document-keyed session registry (stage 1b) and the cold-seed declaration (stage 3). The transport goes first because a registry that leaves the transport panel-owned yields a surviving session that can neither receive an update nor resubscribe, which is worse than today's honest cold seed.
Guards
page-session-owns-transportrule inscripts/check-follower-invariants.ts, scoped wider than the follower seam so it can seeAgentPanelRoot.vue— the call site it exists to forbid. It parses.vuescript blocks with offsets preserved, so it reports the real line in the component.assertin the owner's create path naming the one-transport-per-page invariant and linking the ADR.follower-invariants:check, and every existing test ran against temp directories, so a violation would have landed green. It is now also asserted against the real repository tree from the test suite, which is a required check.Verification
Black-box (
browser_tests), red on the parent and green here.agentPanelCloseKeepsConnection.spec.tsbinds a workflow, runs a turn so the follower genuinely subscribes, closes the panel, reopens it, and asserts the connection was never dropped and redialled.hostSocket.connectionCount()AgentPanelRoot.vuefrommain)Driving a real turn is load-bearing rather than ceremony: binding alone does not start the follower, and without the doc-frame tap the spec would be red on both sides for the wrong reason. It fails on the parent at the final assertion only, so every step before it behaves identically — the spec isolates the defect rather than the setup.
Narrow by design: it asserts the surviving connection and that the panel is usable on reopen. Asserting the deleted-while-closed case would be asserting something this stage does not do.
Unit.
agentPageSession.test.tscovers one transport per page, survival across a remount with no second event source minted, one tap for the page rather than one per consumer, and a fresh mint after an explicit page teardown.check-follower-invariants.test.tsadds the new rule's cases, including.vueline fidelity, the owner exemption, factory definitions versus calls, and comment/string false positives.Suites run locally (node 26.10.0 via nvm,
NODE_OPTIONS=--no-experimental-webstorage):vitest run src/workbench/extensions/agent scripts/check-follower-invariants.test.ts— 197 files, 5056 passed, 2 expected-failtypecheck:app,typecheck:browser,typecheck:scripts— cleandepcruise src— no dependency violations (2895 modules), confirming the new module introduces no cycle betweencrdt/andservices/agent/follower-invariants:check— passes (57 seam files, 202 agent surface files)The two panel suites now reset the page session per test: each test is a fresh page load, and the transport is no longer torn down with the component, so without the reset the first test's socket would outlive it.
Behaviour change worth calling out in review
The agent socket now stays open while the panel is closed. That is the intended effect, and the ADR records it as a negative consequence: a subscription the user cannot see, so "the agent is syncing" state should become discoverable from outside the panel. Closing the panel previously hid that question.