Repository navigation
[backport cloud/1.60] M4 fix(billing): drop "or message support" from the paused top-up line on the Credits card (#22888) - #22895
Conversation
…e on the Credits card (#22888) When staff pause top-up purchases, the Cloud Billing tab's Credits card shows the refusal line under Top-up as "Buying credits isn't available right now. Try again later, or message support." The Cloud footer already links Message support (DES-1306), so the line now ends at "Try again later." (QA plan case C5). The 1.60 QA plan expects the C5 line without "or message support", and the 1.60 build still showed it. message support" at the end. The Cloud footer already has a Message support link, so the Credits card said the same thing twice. Copy only: `topupPurchasesPaused` in `src/locales/en/main.json` and the matching `account-ui` fixture. The out-of-credits banners (`pausedBodyNoDate`, `pausedPersonalBodyNoDate`) keep "or message support" from #22846 (DES-1307, QA case D7). Platform billing has its own copy and is unaffected. - Tests: updated the assertions that read the real locale (`BillingCreditsCard`, `BillingTab`, `CurrentUserPopoverWorkspace`) and the mock locales. With only the locale change reverted, 3 tests fail; with it, all 676 tests in the touched suites pass. | AS IS | TO BE | | --- | --- | | <img alt="AS IS" src="https://gist.githubusercontent.com/dante01yoon/12dbdd8d81114fb01acad573a5cc6330/raw/9cd8b37516a04857bdc08ff539bea986b44c71c5/pr22888-asis.png" width="480"> | <img alt="TO BE" src="https://gist.githubusercontent.com/dante01yoon/12dbdd8d81114fb01acad573a5cc6330/raw/9cd8b37516a04857bdc08ff539bea986b44c71c5/pr22888-tobe.png" width="480"> | (cherry picked from commit 5c9677e)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-04T06:02:36.188Z",
"gitSha": "c9559a49ab3c983e968811f5238545063a8ec242",
"branch": "backport-22888-to-cloud-1.60",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.4180000000108,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.0689999999999995,
"layouts": 11,
"layoutDurationMs": 2.6590000000000003,
"taskDurationMs": 383.027,
"heapDeltaBytes": -19963664,
"heapUsedBytes": 57879524,
"domNodes": -178,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 7.791999999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2008.7049999999635,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9430000000000005,
"layouts": 9,
"layoutDurationMs": 2.3669999999999995,
"taskDurationMs": 386.653,
"heapDeltaBytes": 8410732,
"heapUsedBytes": 70427492,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 10.312999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1722.4119999999914,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.792,
"layouts": 10,
"layoutDurationMs": 2.421,
"taskDurationMs": 685.3520000000001,
"heapDeltaBytes": 5025312,
"heapUsedBytes": 66153392,
"domNodes": -178,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 117.959,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1710.8230000000049,
"styleRecalcs": 71,
"styleRecalcDurationMs": 16.114,
"layouts": 9,
"layoutDurationMs": 2.283,
"taskDurationMs": 654.704,
"heapDeltaBytes": 1107052,
"heapUsedBytes": 62493176,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 127.18800000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.4769999999885,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.352,
"layouts": 12,
"layoutDurationMs": 3.0460000000000003,
"taskDurationMs": 283.97799999999995,
"heapDeltaBytes": 5892004,
"heapUsedBytes": 82077628,
"domNodes": 57,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 10.414,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1690.1050000000168,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.707,
"layouts": 10,
"layoutDurationMs": 2.451,
"taskDurationMs": 265.50600000000003,
"heapDeltaBytes": 8606500,
"heapUsedBytes": 86222476,
"domNodes": 57,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 8.942,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 500.89099999999576,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.1639999999999997,
"layouts": 10,
"layoutDurationMs": 2.6700000000000004,
"taskDurationMs": 351.16400000000004,
"heapDeltaBytes": -15391852,
"heapUsedBytes": 61962020,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 114.161,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 527.5320000000079,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.1080000000000005,
"layouts": 10,
"layoutDurationMs": 2.541,
"taskDurationMs": 336.156,
"heapDeltaBytes": -15237736,
"heapUsedBytes": 60972824,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 111.654,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000003,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 909.2400000000112,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 549.959,
"heapDeltaBytes": -6144228,
"heapUsedBytes": 77709288,
"domNodes": -208,
"jsHeapTotalBytes": 14163968,
"scriptDurationMs": 36.707,
"eventListeners": -107,
"totalBlockingTimeMs": 273,
"frameDurationMs": 26.188571428571425,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 906.2720000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.8839999999999,
"heapDeltaBytes": -13972532,
"heapUsedBytes": 68820492,
"domNodes": -208,
"jsHeapTotalBytes": 17571840,
"scriptDurationMs": 33.755,
"eventListeners": -107,
"totalBlockingTimeMs": 263,
"frameDurationMs": 25.463888888888885,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 730.1459999999906,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.2199999999999,
"heapDeltaBytes": -19625568,
"heapUsedBytes": 68973588,
"domNodes": -208,
"jsHeapTotalBytes": 2228224,
"scriptDurationMs": 97.57600000000002,
"eventListeners": -107,
"totalBlockingTimeMs": 92,
"frameDurationMs": 20.369444444444426,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 730.4110000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.9100000000002,
"heapDeltaBytes": -24964732,
"heapUsedBytes": 65983540,
"domNodes": -208,
"jsHeapTotalBytes": 4325376,
"scriptDurationMs": 103.992,
"eventListeners": -107,
"totalBlockingTimeMs": 100,
"frameDurationMs": 20.951428571428576,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6909.232000000003,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7069999999999993,
"layouts": 2,
"layoutDurationMs": 0.5630000000000002,
"taskDurationMs": 5998.437,
"heapDeltaBytes": 69279728,
"heapUsedBytes": 144134016,
"domNodes": -274,
"jsHeapTotalBytes": 56750080,
"scriptDurationMs": 4463.999,
"eventListeners": -69,
"totalBlockingTimeMs": 48,
"frameDurationMs": 22.026751592356685,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6339.389000000039,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.1129999999999993,
"layouts": 4,
"layoutDurationMs": 1.0009999999999997,
"taskDurationMs": 5190.2119999999995,
"heapDeltaBytes": 47610376,
"heapUsedBytes": 141928504,
"domNodes": -274,
"jsHeapTotalBytes": 54915072,
"scriptDurationMs": 3855.791,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.28658146964856,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6420.327000000015,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.2259999999999998,
"layouts": 4,
"layoutDurationMs": 1.0339999999999998,
"taskDurationMs": 5377.553,
"heapDeltaBytes": 37005928,
"heapUsedBytes": 113723324,
"domNodes": -274,
"jsHeapTotalBytes": 45215744,
"scriptDurationMs": 3974.948,
"eventListeners": -69,
"totalBlockingTimeMs": 1,
"frameDurationMs": 19.44363636363636,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6420.766000000014,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.112,
"layouts": 4,
"layoutDurationMs": 1.015,
"taskDurationMs": 5478.384,
"heapDeltaBytes": 37993096,
"heapUsedBytes": 121159140,
"domNodes": -280,
"jsHeapTotalBytes": 53342208,
"scriptDurationMs": 4139.197999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 12,
"frameDurationMs": 20.90032573289902,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 223.4510000000114,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.363,
"layouts": 13,
"layoutDurationMs": 3.8400000000000003,
"taskDurationMs": 157.848,
"heapDeltaBytes": 14881844,
"heapUsedBytes": 91391520,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.943,
"eventListeners": 205,
"totalBlockingTimeMs": 2,
"frameDurationMs": 21.218181818181826,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 159.76399999999558,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.440999999999997,
"layouts": 12,
"layoutDurationMs": 3.19,
"taskDurationMs": 113.771,
"heapDeltaBytes": 14695968,
"heapUsedBytes": 92159428,
"domNodes": 936,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 7.356,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.442857142857196,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2026.6970000000128,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.633,
"layouts": 9,
"layoutDurationMs": 2.076,
"taskDurationMs": 452.421,
"heapDeltaBytes": -4628896,
"heapUsedBytes": 77332492,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 29.072,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2022.0770000000243,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.746,
"layouts": 9,
"layoutDurationMs": 2.842,
"taskDurationMs": 494.63500000000005,
"heapDeltaBytes": -30679520,
"heapUsedBytes": 63398592,
"domNodes": -274,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 32.249,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2782.364999999999,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.796,
"layouts": 7,
"layoutDurationMs": 1.787,
"taskDurationMs": 1250.5890000000002,
"heapDeltaBytes": -2829864,
"heapUsedBytes": 73031620,
"domNodes": -274,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 578.084,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665868263473055,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2376.9360000000006,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.639,
"layouts": 9,
"layoutDurationMs": 2.313,
"taskDurationMs": 1229.4959999999999,
"heapDeltaBytes": 10326212,
"heapUsedBytes": 82905588,
"domNodes": -274,
"jsHeapTotalBytes": 3497984,
"scriptDurationMs": 605.711,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665734265734265,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3851.8980000000056,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.546,
"layouts": 67,
"layoutDurationMs": 12.458,
"taskDurationMs": 1410.587,
"heapDeltaBytes": -7368172,
"heapUsedBytes": 84497652,
"domNodes": -250,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 589.2,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666233766233766,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3455.699999999979,
"styleRecalcs": 73,
"styleRecalcDurationMs": 11.594999999999997,
"layouts": 67,
"layoutDurationMs": 11.962,
"taskDurationMs": 1342.178,
"heapDeltaBytes": -24624264,
"heapUsedBytes": 61593728,
"domNodes": -250,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 571.6,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665700483091786,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3074.6010000000015,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.654999999999999,
"layouts": 6,
"layoutDurationMs": 1.6190000000000002,
"taskDurationMs": 1504.729,
"heapDeltaBytes": -9899216,
"heapUsedBytes": 76509644,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 727.967,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666486486486484,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2512.045999999998,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.329,
"layouts": 7,
"layoutDurationMs": 1.663,
"taskDurationMs": 1358.1180000000002,
"heapDeltaBytes": -10376392,
"heapUsedBytes": 77404936,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 669.7040000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666225165562913,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2863.4570000000112,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.102,
"layouts": 9,
"layoutDurationMs": 1.8960000000000001,
"taskDurationMs": 519.8480000000001,
"heapDeltaBytes": 1059024,
"heapUsedBytes": 92483216,
"domNodes": 0,
"jsHeapTotalBytes": 4493312,
"scriptDurationMs": 256.452,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66686046511628,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2869.9009999999703,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.286,
"layouts": 8,
"layoutDurationMs": 2.0239999999999996,
"taskDurationMs": 544.913,
"heapDeltaBytes": -14803468,
"heapUsedBytes": 69233708,
"domNodes": -274,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 253.22899999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665697674418606,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2022.0589999999845,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9640000000000004,
"layouts": 9,
"layoutDurationMs": 2.2990000000000004,
"taskDurationMs": 496.092,
"heapDeltaBytes": -5305040,
"heapUsedBytes": 86855644,
"domNodes": -274,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 28.978,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-idle",
"durationMs": 2036.2670000000094,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.405,
"layouts": 8,
"layoutDurationMs": 1.9369999999999998,
"taskDurationMs": 398.52599999999995,
"heapDeltaBytes": 5979948,
"heapUsedBytes": 82237184,
"domNodes": -274,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 26.084000000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2725.9009999999935,
"styleRecalcs": 28,
"styleRecalcDurationMs": 11.235999999999999,
"layouts": 8,
"layoutDurationMs": 1.786,
"taskDurationMs": 436.983,
"heapDeltaBytes": -25402692,
"heapUsedBytes": 60099732,
"domNodes": -267,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 133.18799999999996,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2675.8859999999913,
"styleRecalcs": 27,
"styleRecalcDurationMs": 10.850999999999999,
"layouts": 8,
"layoutDurationMs": 1.8159999999999998,
"taskDurationMs": 390.41200000000003,
"heapDeltaBytes": 7927976,
"heapUsedBytes": 92916520,
"domNodes": 19,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 141.604,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665838509316767,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 2914.1039999999803,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.849,
"layouts": 7,
"layoutDurationMs": 1.5190000000000001,
"taskDurationMs": 625.4789999999999,
"heapDeltaBytes": -6721120,
"heapUsedBytes": 77739024,
"domNodes": -274,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 240.883,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666285714285717,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-topology-cadence",
"durationMs": 2980.1759999999717,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.1839999999999993,
"layouts": 8,
"layoutDurationMs": 1.8599999999999999,
"taskDurationMs": 609.9859999999999,
"heapDeltaBytes": -14906308,
"heapUsedBytes": 76875708,
"domNodes": 0,
"jsHeapTotalBytes": 6328320,
"scriptDurationMs": 243.862,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665921787709497,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 526.1239999999816,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.174999999999999,
"layouts": 10,
"layoutDurationMs": 2.5469999999999997,
"taskDurationMs": 334.671,
"heapDeltaBytes": 24885440,
"heapUsedBytes": 86990516,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 105.76,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 466.9810000000325,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.42,
"layouts": 10,
"layoutDurationMs": 2.449,
"taskDurationMs": 306.49199999999996,
"heapDeltaBytes": 23812700,
"heapUsedBytes": 87643728,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 101.43900000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2006.3339999999812,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.7940000000000005,
"layouts": 11,
"layoutDurationMs": 2.6940000000000004,
"taskDurationMs": 369.512,
"heapDeltaBytes": -4407300,
"heapUsedBytes": 59756168,
"domNodes": -200,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 6.98,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.9769999999921,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9110000000000005,
"layouts": 9,
"layoutDurationMs": 2.421,
"taskDurationMs": 368.211,
"heapDeltaBytes": 7630216,
"heapUsedBytes": 69764836,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 8.741000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.521000000013,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.739,
"layouts": 9,
"layoutDurationMs": 2.2189999999999994,
"taskDurationMs": 620.563,
"heapDeltaBytes": 23251384,
"heapUsedBytes": 85198356,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 90.14999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.0859999999702,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.753,
"layouts": 9,
"layoutDurationMs": 1.8999999999999997,
"taskDurationMs": 606.563,
"heapDeltaBytes": 2085296,
"heapUsedBytes": 65912908,
"domNodes": -192,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 85.285,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1044.326999999953,
"styleRecalcs": 19,
"styleRecalcDurationMs": 16.867000000000004,
"layouts": 5,
"layoutDurationMs": 11.566,
"taskDurationMs": 841.6650000000001,
"heapDeltaBytes": -9289728,
"heapUsedBytes": 81077976,
"domNodes": 9218,
"jsHeapTotalBytes": 18087936,
"scriptDurationMs": 22.543,
"eventListeners": 3566,
"totalBlockingTimeMs": 96,
"frameDurationMs": 19.442592592592593,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9555.946000000005,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.669,
"layouts": 9,
"layoutDurationMs": 2.341,
"taskDurationMs": 4434.1720000000005,
"heapDeltaBytes": -11487452,
"heapUsedBytes": 78315136,
"domNodes": -274,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 2007.8620000000003,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666027874564463,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8655.749000000014,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.059,
"layouts": 9,
"layoutDurationMs": 2.0949999999999998,
"taskDurationMs": 4210.03,
"heapDeltaBytes": -18208344,
"heapUsedBytes": 64014632,
"domNodes": -274,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 1958.798,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665961538461538,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17496.230000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17059.173000000003,
"heapDeltaBytes": -397300,
"heapUsedBytes": 281155572,
"domNodes": -3482,
"jsHeapTotalBytes": 17027072,
"scriptDurationMs": 243.957,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.98730703259005,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-large-graph-idle",
"durationMs": 16987.438,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16279.786999999998,
"heapDeltaBytes": -2285608,
"heapUsedBytes": 287977156,
"domNodes": -3482,
"jsHeapTotalBytes": 16498688,
"scriptDurationMs": 230.93800000000002,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.812372881355937,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 19933.304000000022,
"styleRecalcs": 151,
"styleRecalcDurationMs": 21.563999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19498.212000000003,
"heapDeltaBytes": -39341324,
"heapUsedBytes": 258309316,
"domNodes": -3482,
"jsHeapTotalBytes": 16244736,
"scriptDurationMs": 697.826,
"eventListeners": -659,
"totalBlockingTimeMs": 24,
"frameDurationMs": 36.50659340659341,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 19641.121,
"styleRecalcs": 161,
"styleRecalcDurationMs": 19.448000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19290.480000000003,
"heapDeltaBytes": -44242672,
"heapUsedBytes": 258994304,
"domNodes": -3482,
"jsHeapTotalBytes": 15196160,
"scriptDurationMs": 714.7600000000001,
"eventListeners": -659,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.856021897810216,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6619.064000000037,
"styleRecalcs": 20,
"styleRecalcDurationMs": 44.27700000000001,
"layouts": 20,
"layoutDurationMs": 24.409,
"taskDurationMs": 6470.668,
"heapDeltaBytes": -36308420,
"heapUsedBytes": 261414524,
"domNodes": -3482,
"jsHeapTotalBytes": 25411584,
"scriptDurationMs": 100.85400000000001,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.692982456140356,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 5921.8009999999595,
"styleRecalcs": 20,
"styleRecalcDurationMs": 39.635000000000005,
"layouts": 20,
"layoutDurationMs": 19.785999999999998,
"taskDurationMs": 5816.215,
"heapDeltaBytes": -28253284,
"heapUsedBytes": 282187724,
"domNodes": -3482,
"jsHeapTotalBytes": 29605888,
"scriptDurationMs": 80.572,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.599415204678365,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8439.209000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8222.340999999999,
"heapDeltaBytes": 5750960,
"heapUsedBytes": 295564344,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 129.86399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.674410774410777,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7607.703000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7249.276999999999,
"heapDeltaBytes": -24775984,
"heapUsedBytes": 265929368,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 85.38600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.588552188552185,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 86.66099999999233,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.002,
"layouts": 5,
"layoutDurationMs": 1.44,
"taskDurationMs": 63.419000000000004,
"heapDeltaBytes": -13609736,
"heapUsedBytes": 62149636,
"domNodes": 101,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 5.856,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 90.5680000000757,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.863000000000001,
"layouts": 6,
"layoutDurationMs": 1.5379999999999998,
"taskDurationMs": 64.13400000000001,
"heapDeltaBytes": -12771256,
"heapUsedBytes": 62502808,
"domNodes": 98,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 4.591,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 215.44700000004013,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.61,
"layouts": 76,
"layoutDurationMs": 10.461,
"taskDurationMs": 170.831,
"heapDeltaBytes": 9800924,
"heapUsedBytes": 50223056,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 71.642,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66923076923079,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 219.71699999994598,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.598,
"layouts": 76,
"layoutDurationMs": 10.323,
"taskDurationMs": 177.344,
"heapDeltaBytes": 9873084,
"heapUsedBytes": 49646100,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 78.789,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230754,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 239.13400000003548,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.209,
"layouts": 76,
"layoutDurationMs": 9.779,
"taskDurationMs": 198.86900000000003,
"heapDeltaBytes": -2348596,
"heapUsedBytes": 89862456,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 64.05799999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 236.97199999992336,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.183,
"layouts": 76,
"layoutDurationMs": 9.683,
"taskDurationMs": 198.06799999999998,
"heapDeltaBytes": -1834048,
"heapUsedBytes": 96428396,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 64.139,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage: 🟡 59.3% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3219 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e9e3ee1c6c00a9135c99dcdfbc130ba17a1ab276
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (356)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.60 #22895 +/- ##
=============================================
Coverage ? 87.50%
=============================================
Files ? 2889
Lines ? 159385
Branches ? 40671
=============================================
Hits ? 139469
Misses ? 19152
Partials ? 764
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Exact-fidelity backport of merged #22888 onto cloud/1.60, same change as #22894 for the sibling branch. Drops the same clause from the locale string and every matching test fixture; the missing packages/account-ui fixture hunk is forced by the older base lacking that package, same as #22894. All 109 checks settled (87 success / 22 skipped), no review threads.
Approved. Reassigning to the author.
Manual backport of #22888 to
cloud/1.60; the auto-backport hit a conflict.The only conflict:
packages/account-ui/src/billing/tab/__fixtures__/creditsCardCopy.tsdoesn't exist oncloud/1.60, so it is dropped. The locale change and test updates apply unchanged. The out-of-credits banners keep "or message support" (QA case D7).Verification: the touched suites pass on this branch (16 files, 557 tests).
QA: case C5 in the 1.60 M4 plan. With top-up purchases paused, the line under Top-up on the Credits card reads "Buying credits isn't available right now. Try again later."