Repository navigation
[backport cloud/1.60] M4 feat(workspace): explain a refused workspace creation with the served reason and limit - #22840
Conversation
…ved reason and limit (#22436) ## Why The disabled "Create a team workspace" row (workspace switcher) and the create notice in the team workspaces dialog explained a refusal from client guesses: the owned-workspace limit was `MAX_OWNED_WORKSPACES = 10` counted on the frontend, and "managed by your organization" was inferred from `default_workspace_id`. Cloud v0.521.1 now serves both facts on `GET /api/workspaces` (BE-24095, cloud#17159): `max_owned_workspaces` and `denied_reasons.can_create_workspace` (`organization_managed` | `owned_workspace_limit`). ## How - `teamWorkspaceStore` reads `denied_reasons.can_create_workspace` and `max_owned_workspaces` from every list load. `canCreateWorkspace` is `can_create_workspace` alone; the client count and the constant are gone. - For `organization_managed` (an SSO organization manages the account), the switcher keeps today's disabled Create row with the existing line "Your organization manages your workspaces, so you can't create one.", and the team workspaces dialog hides its create form. - The other refusal notices are chosen by the served reason. Per the spec, an absent reason is no explanation, so it keeps the neutral "You can't create a workspace on this account right now." - The limit copy renders the served number: "You can only own {max} workspaces. Delete one to create a new one." - A denial reason beside `can_create_workspace: true` grants nothing and shows nothing. - `POST /api/workspaces` refused with `OWNED_WORKSPACE_LIMIT` already shows the server's `message` as the toast description (`handleAxiosError` -> `WorkspaceApiError.message` -> `getErrorMessage`), so that path needs no change. - `plan_summary` (BE-24094) is not wired here; per Alex it ships with the FRONT-3644 redesign. ## Design reference [Alex on #proj-billing](https://comfy-organization.slack.com/archives/C0BNGQG2LCW/p1793313374311129): - Keep today's layout and copy until FRONT-3644; the neutral fallback "You can't create a workspace on this account right now." stays. - The per-workspace plan line waits for FRONT-3644. - SSO-managed accounts (`organization_managed`), corrected: "skip my new line and keep the existing 'Your organization manages your workspaces, so you can't create one.' that #22436 already uses. Hiding the create form in the workspaces dialog still stands." So the switcher keeps the disabled Create row with that line, and the dialog keeps replacing its form with it. The redesign itself is [Workspace switcher - states](https://www.figma.com/design/C1fxz3akrW7Pl22zM2b301/Unified-Settings---Billing?node-id=2292-3034). ## AS IS / TO BE Taken in the running app with the real testcloud session in Ego Lite; listed API responses stubbed. AS IS = base `dante/m4-ingest-types-sync` (a6f4c3d), TO BE = this branch: the two limit states at 501e44e (their code is unchanged at the current head bf3ddaf), the organization_managed state at bf3ddaf. Team workspace (test-1, owner), dark theme. `GET /api/workspaces` (list) is the real body merged with the fields below. **Switcher: `can_create_workspace: false`, `denied_reasons.can_create_workspace: owned_workspace_limit`, `max_owned_workspaces: 3`** | AS IS | TO BE | |---|---| | <img src="https://gist.githubusercontent.com/dante01yoon/1ac7e437012e4ada57fe5e06ecfa5cdf/raw/090ef9ad598b41cc20842877c31790a2d0725306/22436-asis-switcher-limit.png" alt="AS IS Switcher at the owned workspace limit" width="420"> | <img src="https://gist.githubusercontent.com/dante01yoon/1ac7e437012e4ada57fe5e06ecfa5cdf/raw/090ef9ad598b41cc20842877c31790a2d0725306/22436-tobe-switcher-limit.png" alt="TO BE Switcher at the owned workspace limit" width="420"> | **Team workspaces dialog: same `owned_workspace_limit` stub** | AS IS | TO BE | |---|---| | <img src="https://gist.githubusercontent.com/dante01yoon/1ac7e437012e4ada57fe5e06ecfa5cdf/raw/090ef9ad598b41cc20842877c31790a2d0725306/22436-asis-dialog-limit.png" alt="AS IS Team workspaces dialog at the owned workspace limit" width="420"> | <img src="https://gist.githubusercontent.com/dante01yoon/1ac7e437012e4ada57fe5e06ecfa5cdf/raw/090ef9ad598b41cc20842877c31790a2d0725306/22436-tobe-dialog-limit.png" alt="TO BE Team workspaces dialog at the owned workspace limit" width="420"> | **Switcher: `can_create_workspace: false`, `denied_reasons.can_create_workspace: organization_managed`** | AS IS | TO BE | |---|---| | <img src="https://gist.githubusercontent.com/dante01yoon/1ac7e437012e4ada57fe5e06ecfa5cdf/raw/090ef9ad598b41cc20842877c31790a2d0725306/22436-asis-switcher-org-managed.png" alt="AS IS Switcher, organization managed" width="420"> | <img src="https://gist.githubusercontent.com/dante01yoon/1ac7e437012e4ada57fe5e06ecfa5cdf/raw/7e61f81b1117699aea2449421152e3c0335fb3b8/22436-tobe-bf3dda-switcher-org-managed.png" alt="TO BE Switcher, organization managed" width="420"> | ## Tests - `teamWorkspaceStore.test.ts`: each served reason (`organization_managed`, `owned_workspace_limit`, absent) names the refusal; creation stays offered when the server allows it despite a stray reason or an owned count past the limit. - `WorkspaceSwitcherPopover.test.ts`: each served reason renders its notice, with the served limit (25) in the copy; `organization_managed` shows the disabled Create row with the existing line, like the others; no click emits `create`. - `TeamWorkspacesDialogContent.test.ts`: each served reason replaces the form with its notice; 10 owned workspaces with no refusal keep the form. - `pnpm exec vitest run` on the three files plus `webSessionFlagOn` and `useCreateWorkspaceUrlLoader`: 421 pass. oxlint, oxfmt, eslint, `lint:server-facts --staged`, `typecheck:app` clean. ## Plan position | Item | Ticket | PR | Status | |---|---|---|---| | Ingest types sync from cloud v0.521.1 | BE-24094 / BE-24095 / BE-24096 / BE-24449 / BE-24556 | #22434 | Open | | Served top-up minimum in Add credits | BE-24096 | #22435 | Open | | **Served workspace creation refusal and limit** | **BE-24095** | **this PR** | **Open** | | Per-workspace plan line in the switcher | BE-24094 / FRONT-3644 | - | With the FRONT-3644 redesign | | Credits card refill line | BE-24556 | - | Not started | | Display balance | BE-24449 | - | Not started | ```mermaid graph TD sync["PR 22434 types sync"] --> topup["PR 22435 top-up minimum"] sync --> ws["This PR: creation refusal and limit"] sync --> plan["Switcher plan line (FRONT-3644)"] sync --> refill["Refill line"] sync --> balance["Display balance"] style ws fill:#f9d71c,stroke:#333,stroke-width:3px ``` Base is `dante/m4-ingest-types-sync`; retarget to `main` after #22434 merges.
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 8 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-03T19:07:46.340Z",
"gitSha": "ff4b7a9748d8ea0b06d7bbd71c3afb7c7453a0ff",
"branch": "backport-22436-to-cloud-1.60",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2032.0770000000152,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.8469999999999995,
"layouts": 8,
"layoutDurationMs": 2.7230000000000003,
"taskDurationMs": 587.5500000000001,
"heapDeltaBytes": 6399308,
"heapUsedBytes": 66640340,
"domNodes": -178,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 9.682,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2036.9359999999688,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.6970000000000005,
"layouts": 10,
"layoutDurationMs": 3.149,
"taskDurationMs": 680.552,
"heapDeltaBytes": -6690036,
"heapUsedBytes": 66850888,
"domNodes": -178,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 13.865000000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1780.3030000000035,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.579999999999998,
"layouts": 8,
"layoutDurationMs": 2.395,
"taskDurationMs": 932.045,
"heapDeltaBytes": 6865352,
"heapUsedBytes": 66975704,
"domNodes": -178,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 164.133,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1898.2630000000427,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.269,
"layouts": 8,
"layoutDurationMs": 2.897,
"taskDurationMs": 1012.146,
"heapDeltaBytes": 8087820,
"heapUsedBytes": 68126812,
"domNodes": -178,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 178.123,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684207,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1730.4090000000087,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.969000000000001,
"layouts": 11,
"layoutDurationMs": 3.023,
"taskDurationMs": 445.102,
"heapDeltaBytes": 25377668,
"heapUsedBytes": 85369812,
"domNodes": 57,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 11.824000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.6570000000029,
"styleRecalcs": 20,
"styleRecalcDurationMs": 5.280000000000001,
"layouts": 11,
"layoutDurationMs": 2.99,
"taskDurationMs": 430.85200000000003,
"heapDeltaBytes": 9267624,
"heapUsedBytes": 82288780,
"domNodes": 57,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 10.983,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665048543689316,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 700.4100000000335,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.267,
"layouts": 11,
"layoutDurationMs": 3.223,
"taskDurationMs": 506.25699999999995,
"heapDeltaBytes": -16172012,
"heapUsedBytes": 60762696,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 172.06300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 792.1469999999999,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.974999999999999,
"layouts": 8,
"layoutDurationMs": 2.661,
"taskDurationMs": 567.2410000000001,
"heapDeltaBytes": 9255208,
"heapUsedBytes": 77939432,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 186.845,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668085106382982,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1229.3580000000475,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 932.0990000000002,
"heapDeltaBytes": -10970384,
"heapUsedBytes": 77869864,
"domNodes": -208,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 75.756,
"eventListeners": -107,
"totalBlockingTimeMs": 542,
"frameDurationMs": 33.33243243243243,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1143.9209999999775,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 831.27,
"heapDeltaBytes": 19425680,
"heapUsedBytes": 82934784,
"domNodes": 0,
"jsHeapTotalBytes": 17465344,
"scriptDurationMs": 72.31899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 513,
"frameDurationMs": 33.82058823529412,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 877.4520000000052,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.73999999999984,
"heapDeltaBytes": -1534976,
"heapUsedBytes": 85182896,
"domNodes": 0,
"jsHeapTotalBytes": 3411968,
"scriptDurationMs": 167.223,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 25.237142857142864,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 859.7839999999906,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.421,
"heapDeltaBytes": -4883364,
"heapUsedBytes": 86955992,
"domNodes": 0,
"jsHeapTotalBytes": 3411968,
"scriptDurationMs": 167.704,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 25.49117647058823,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11025.115,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10063.277,
"heapDeltaBytes": 49178812,
"heapUsedBytes": 132409692,
"domNodes": -274,
"jsHeapTotalBytes": 67235840,
"scriptDurationMs": 7966.849,
"eventListeners": -69,
"totalBlockingTimeMs": 970,
"frameDurationMs": 31.56532951289398,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10828.111000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9968.664999999999,
"heapDeltaBytes": 71062344,
"heapUsedBytes": 145114660,
"domNodes": -274,
"jsHeapTotalBytes": 76410880,
"scriptDurationMs": 7901.2699999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 899,
"frameDurationMs": 31.129022988505746,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10296.440000000019,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.05099999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9564.771999999999,
"heapDeltaBytes": 46487440,
"heapUsedBytes": 140348252,
"domNodes": -274,
"jsHeapTotalBytes": 74051584,
"scriptDurationMs": 7590.827,
"eventListeners": -69,
"totalBlockingTimeMs": 801,
"frameDurationMs": 31.64,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11838.915000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11119.845,
"heapDeltaBytes": 8407948,
"heapUsedBytes": 83413352,
"domNodes": -274,
"jsHeapTotalBytes": 18739200,
"scriptDurationMs": 9058.475999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 1612,
"frameDurationMs": 32.33032786885246,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 212.9380000000083,
"styleRecalcs": 20,
"styleRecalcDurationMs": 12.248,
"layouts": 7,
"layoutDurationMs": 2.2050000000000005,
"taskDurationMs": 160.76199999999997,
"heapDeltaBytes": 14911160,
"heapUsedBytes": 74869772,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.767000000000001,
"eventListeners": 205,
"totalBlockingTimeMs": 4,
"frameDurationMs": 24.077777777777758,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 221.492000000012,
"styleRecalcs": 21,
"styleRecalcDurationMs": 12.197,
"layouts": 8,
"layoutDurationMs": 2.339,
"taskDurationMs": 170.647,
"heapDeltaBytes": 14947420,
"heapUsedBytes": 76472984,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.200999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 6,
"frameDurationMs": 23.34000000000001,
"p95FrameDurationMs": 83.40000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2054.9310000000105,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4929999999999994,
"layouts": 8,
"layoutDurationMs": 2.448,
"taskDurationMs": 685.1719999999999,
"heapDeltaBytes": -18833188,
"heapUsedBytes": 63181396,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 34.27,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2055.6040000000166,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9899999999999995,
"layouts": 8,
"layoutDurationMs": 1.9529999999999998,
"taskDurationMs": 672.085,
"heapDeltaBytes": 6636296,
"heapUsedBytes": 80500992,
"domNodes": -274,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 38.126999999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2740.8189999999877,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.243,
"layouts": 7,
"layoutDurationMs": 1.951,
"taskDurationMs": 1773.895,
"heapDeltaBytes": -6817756,
"heapUsedBytes": 72905768,
"domNodes": -274,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 847.1719999999999,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2552.7799999999843,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.674000000000001,
"layouts": 8,
"layoutDurationMs": 2.1999999999999997,
"taskDurationMs": 1716.772,
"heapDeltaBytes": -9471720,
"heapUsedBytes": 73480560,
"domNodes": -274,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 827.508,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666233766233766,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3887.108000000012,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.366,
"layouts": 64,
"layoutDurationMs": 10.341,
"taskDurationMs": 1855.6440000000002,
"heapDeltaBytes": 1185420,
"heapUsedBytes": 85464652,
"domNodes": -250,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 791.6769999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666094420600857,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3954.150000000027,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.583,
"layouts": 64,
"layoutDurationMs": 10.56,
"taskDurationMs": 1894.248,
"heapDeltaBytes": 744188,
"heapUsedBytes": 86087932,
"domNodes": -250,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 815.1709999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665400843881855,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3175.555000000031,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.289000000000001,
"layouts": 6,
"layoutDurationMs": 1.5830000000000002,
"taskDurationMs": 2035.266,
"heapDeltaBytes": -15126580,
"heapUsedBytes": 71442208,
"domNodes": 0,
"jsHeapTotalBytes": 6905856,
"scriptDurationMs": 997.885,
"eventListeners": 182,
"totalBlockingTimeMs": 21,
"frameDurationMs": 16.930687830687834,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3123.629000000051,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.084,
"layouts": 5,
"layoutDurationMs": 1.3550000000000002,
"taskDurationMs": 2046.0640000000003,
"heapDeltaBytes": 22860816,
"heapUsedBytes": 101632876,
"domNodes": 0,
"jsHeapTotalBytes": 6971392,
"scriptDurationMs": 1012.3899999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 10,
"frameDurationMs": 17.026486486486483,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3106.27199999999,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7950000000000006,
"layouts": 7,
"layoutDurationMs": 1.631,
"taskDurationMs": 822.3710000000001,
"heapDeltaBytes": -11185444,
"heapUsedBytes": 61270196,
"domNodes": -274,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 368.977,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258063,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3095.256999999947,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.7109999999999999,
"layouts": 6,
"layoutDurationMs": 1.6720000000000004,
"taskDurationMs": 814.5290000000001,
"heapDeltaBytes": -14437148,
"heapUsedBytes": 62112744,
"domNodes": -274,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 364.734,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66540540540541,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2063.530999999955,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.2830000000000004,
"layouts": 7,
"layoutDurationMs": 4.549,
"taskDurationMs": 673.7480000000002,
"heapDeltaBytes": -2283968,
"heapUsedBytes": 73349020,
"domNodes": -274,
"jsHeapTotalBytes": 651264,
"scriptDurationMs": 33.145,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2064.700000000016,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0460000000000003,
"layouts": 7,
"layoutDurationMs": 2.1719999999999993,
"taskDurationMs": 750.4949999999999,
"heapDeltaBytes": -18492168,
"heapUsedBytes": 66355376,
"domNodes": -274,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 37.916999999999994,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66612903225806,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2716.413999999986,
"styleRecalcs": 25,
"styleRecalcDurationMs": 11.683,
"layouts": 6,
"layoutDurationMs": 1.7419999999999995,
"taskDurationMs": 570.2570000000002,
"heapDeltaBytes": 8140148,
"heapUsedBytes": 92395648,
"domNodes": 19,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 194.913,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665644171779142,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2908.1279999999197,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.727999999999998,
"layouts": 7,
"layoutDurationMs": 2.0580000000000003,
"taskDurationMs": 633.8840000000001,
"heapDeltaBytes": -7924776,
"heapUsedBytes": 65388400,
"domNodes": -260,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 199.031,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666091954022992,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3303.6129999999844,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.809,
"layouts": 6,
"layoutDurationMs": 1.5209999999999997,
"taskDurationMs": 952.8820000000001,
"heapDeltaBytes": 16498696,
"heapUsedBytes": 100096204,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 392.701,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665656565656565,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3325.6639999999607,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.5080000000000007,
"layouts": 6,
"layoutDurationMs": 1.5730000000000002,
"taskDurationMs": 987.5769999999999,
"heapDeltaBytes": -2247224,
"heapUsedBytes": 74078108,
"domNodes": -274,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 383.744,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66582914572864,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 647.440999999958,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.654,
"layouts": 8,
"layoutDurationMs": 1.9560000000000002,
"taskDurationMs": 453.202,
"heapDeltaBytes": 24865936,
"heapUsedBytes": 86347820,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 148.555,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102567,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 670.011000000045,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.0329999999999995,
"layouts": 10,
"layoutDurationMs": 2.8120000000000003,
"taskDurationMs": 458.88700000000006,
"heapDeltaBytes": 24813080,
"heapUsedBytes": 86380816,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 145.68200000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2017.1980000000076,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.535,
"layouts": 8,
"layoutDurationMs": 2.543,
"taskDurationMs": 549.755,
"heapDeltaBytes": 4647660,
"heapUsedBytes": 65205264,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 9.360999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2072.8749999999536,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.797,
"layouts": 8,
"layoutDurationMs": 2.616,
"taskDurationMs": 691.975,
"heapDeltaBytes": -4231560,
"heapUsedBytes": 70398900,
"domNodes": -200,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 12.901000000000003,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1760.013000000015,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.449000000000002,
"layouts": 9,
"layoutDurationMs": 2.7059999999999995,
"taskDurationMs": 919.3009999999999,
"heapDeltaBytes": -5581708,
"heapUsedBytes": 58698588,
"domNodes": -200,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 112.395,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66509433962264,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1784.8699999999553,
"styleRecalcs": 78,
"styleRecalcDurationMs": 16.387999999999998,
"layouts": 9,
"layoutDurationMs": 2.5730000000000004,
"taskDurationMs": 1023.114,
"heapDeltaBytes": 16157024,
"heapUsedBytes": 75791176,
"domNodes": -200,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 124.94899999999998,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666355140186912,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1611.3150000000473,
"styleRecalcs": 18,
"styleRecalcDurationMs": 26.483999999999995,
"layouts": 5,
"layoutDurationMs": 19.14,
"taskDurationMs": 1349.5720000000001,
"heapDeltaBytes": -5457340,
"heapUsedBytes": 77627104,
"domNodes": 19229,
"jsHeapTotalBytes": 17039360,
"scriptDurationMs": 32.245999999999995,
"eventListeners": 3566,
"totalBlockingTimeMs": 215,
"frameDurationMs": 20.41625,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9945.777999999962,
"styleRecalcs": 250,
"styleRecalcDurationMs": 28.168,
"layouts": 8,
"layoutDurationMs": 2.2110000000000003,
"taskDurationMs": 6135.822,
"heapDeltaBytes": -9628620,
"heapUsedBytes": 63342744,
"domNodes": -274,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 2791.018,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.693959731543625,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10717.672999999992,
"styleRecalcs": 251,
"styleRecalcDurationMs": 28.591,
"layouts": 9,
"layoutDurationMs": 2.577,
"taskDurationMs": 6313.91,
"heapDeltaBytes": 2428096,
"heapUsedBytes": 85424556,
"domNodes": -274,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 2870.1100000000006,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66594090202177,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 24436.780999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23550.450999999997,
"heapDeltaBytes": -10963096,
"heapUsedBytes": 278204628,
"domNodes": -3512,
"jsHeapTotalBytes": 14405632,
"scriptDurationMs": 328.122,
"eventListeners": -677,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.1248275862069,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 24471.88099999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23634.450999999997,
"heapDeltaBytes": -11186852,
"heapUsedBytes": 286168148,
"domNodes": -3482,
"jsHeapTotalBytes": 14139392,
"scriptDurationMs": 354.993,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.697556719022685,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 28837.515999999992,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.523999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28481.302,
"heapDeltaBytes": -42897388,
"heapUsedBytes": 254072280,
"domNodes": -3482,
"jsHeapTotalBytes": 11784192,
"scriptDurationMs": 900.843,
"eventListeners": -659,
"totalBlockingTimeMs": 19,
"frameDurationMs": 53.42388888888889,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 29681.993000000035,
"styleRecalcs": 181,
"styleRecalcDurationMs": 21.720000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 29393.732,
"heapDeltaBytes": -27221192,
"heapUsedBytes": 257340996,
"domNodes": -3482,
"jsHeapTotalBytes": 12828672,
"scriptDurationMs": 974.2919999999999,
"eventListeners": -663,
"totalBlockingTimeMs": 46,
"frameDurationMs": 55.898870056497174,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8654.216000000019,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.57399999999999,
"layouts": 20,
"layoutDurationMs": 22.19700000000001,
"taskDurationMs": 8512.031,
"heapDeltaBytes": -10993556,
"heapUsedBytes": 272112204,
"domNodes": -3482,
"jsHeapTotalBytes": 17022976,
"scriptDurationMs": 148.19100000000003,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 50.978235294117646,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8682.839999999942,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.75899999999998,
"layouts": 20,
"layoutDurationMs": 23.409,
"taskDurationMs": 8595.6,
"heapDeltaBytes": -41702464,
"heapUsedBytes": 259328004,
"domNodes": -3482,
"jsHeapTotalBytes": 19386368,
"scriptDurationMs": 136.791,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 50.3860465116279,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12255.289000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11912.359000000002,
"heapDeltaBytes": -11459360,
"heapUsedBytes": 260718980,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 167.01500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.980350877192976,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12465.066000000093,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12055.35,
"heapDeltaBytes": -16159168,
"heapUsedBytes": 258195196,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 167.11200000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.99151943462897,
"p95FrameDurationMs": 99.89999999999782
},
{
"name": "workflow-execution",
"durationMs": 514.6369999999933,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.052999999999999,
"layouts": 11,
"layoutDurationMs": 4.380999999999999,
"taskDurationMs": 152.984,
"heapDeltaBytes": 7808348,
"heapUsedBytes": 74607452,
"domNodes": 140,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 20.428,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 479.1240000000698,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.598999999999998,
"layouts": 10,
"layoutDurationMs": 3.248,
"taskDurationMs": 115.72699999999999,
"heapDeltaBytes": 7149836,
"heapUsedBytes": 69063632,
"domNodes": 99,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.571,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285715,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 573.3290000000579,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.731,
"layouts": 76,
"layoutDurationMs": 16.396,
"taskDurationMs": 521.7750000000001,
"heapDeltaBytes": -3054908,
"heapUsedBytes": 43729904,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 252.874,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 490.02599999994345,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6539999999999999,
"layouts": 76,
"layoutDurationMs": 14.614,
"taskDurationMs": 439.12,
"heapDeltaBytes": -3710416,
"heapUsedBytes": 42592324,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 214.534,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 495.53900000000795,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.4,
"layouts": 76,
"layoutDurationMs": 13.749,
"taskDurationMs": 464.781,
"heapDeltaBytes": -788016,
"heapUsedBytes": 101973252,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 175.232,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 676.6290000000481,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.619,
"layouts": 76,
"layoutDurationMs": 17.517999999999997,
"taskDurationMs": 617.8900000000001,
"heapDeltaBytes": 1441472,
"heapUsedBytes": 103746856,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 262.766,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.517948717948713,
"p95FrameDurationMs": 33.30000000000018
}
]
}🔬 E2E Coverage: 🟡 59.3% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3221 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since b91594e689665539bb90f636ae6ac966c1b9b0ae
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (356)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.60 #22840 +/- ##
=============================================
Coverage ? 87.49%
=============================================
Files ? 2888
Lines ? 159330
Branches ? 40656
=============================================
Hits ? 139402
Misses ? 19163
Partials ? 765
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Clean automatic backport of #22436; CI green.
Backport of #22436 to
cloud/1.60Automatically created by backport workflow.