Repository navigation
[backport cloud/1.60] FRONT-3650 feat(account-core): auto top-up reader, save and preview in the billing SDK - #22827
Conversation
…n the billing SDK (#22413) ## Summary The ingest-types sync carrying Comfy-Org/cloud#17298 is on main (#22354), so the preview that charges (`not_charging_reason: null`) now decodes. Nothing calls this code yet, so there is no behavior change. Adds the framework-free auto top-up core to `packages/account-core/src/core/billing`: a scoped reader, a save command and a preview command. This PR only adds code. No app or billing-site code uses it yet. ### Why The ComfyUI app (`BillingAutoTopUpCard.vue` / `useBillingAutoTopUpCard`) and the billing site (`utils/autoTopUp.ts` in Comfy-Org/platform) each have their own auto top-up logic. Alex asked us to put it in the SDK first so it is not duplicated. ### Root cause Every other billing read and command already lives in account-core (credits, status, plans, payment methods, top-up, subscription). Auto top-up never moved there, so each host calls `/billing/auto-reload` itself, decodes the response itself and handles errors its own way. ### How - New `autoTopUp.ts`: - `createAutoTopUpReader`: a `GET /billing/auto-reload` reader built on `createScopedReader`, shaped like the payment-methods reader. It has `read`, `getSnapshot`, `invalidate` and `dispose`, and its snapshot is `{ scope, settings, readAt }`. - `saveAutoTopUp(transport, input)`: `PUT /billing/auto-reload`. It checks the input against `zPutBillingAutoReloadBody` and decodes the reply with `zPutBillingAutoReloadResponse`. - `previewAutoTopUp(transport, query)`: `GET /billing/auto-reload/preview` with `threshold_credits`, `target_credits` and an optional `monthly_budget_cents`. The input is checked against `zGetBillingAutoReloadPreviewQuery` and the reply is decoded with `zGetBillingAutoReloadPreviewResponse`. - Every wire shape comes from `@comfyorg/ingest-types`. int64 fields are overridden with `wireCents`, the same as `topup.ts` and `subscriptionCommands.ts`, so callers get numbers, not `bigint`. - Server refusals come back as coded failures through `readValidatedBillingResponse` and `codeForHttpStatus`. No new `BillingErrorCode`. `httpStatus`, `serverCode` and `serverMessage` are kept, so a host can tell these apart: - 422 `AUTO_TOP_UP_NOT_ELIGIBLE` → `REQUEST_FAILED` - 409 `SUBSCRIPTION_CHANGE_IN_PROGRESS` → `CONFLICT` - 503 `AUTO_TOP_UP_PREVIEW_UNAVAILABLE` → `REQUEST_FAILED` - If the input fails the generated request schema, save and preview return `INVALID_REQUEST` and send nothing. This matches `previewSubscribe`. - `BillingRequest` now accepts `PUT` with a body. No transport code had to change: - `exchangeBillingRequest` already sends a body for any method other than GET. - The session transport's 401 replay gate is `GET || idempotencyKey`, so a PUT without a key is not replayed and is reported as `authenticationRetrySkipped` → `REQUEST_FAILED`. - The web-session authorizer adds CSRF for every method that is not safe, PUT included. - The preview decodes what Comfy-Org/cloud#17298 serves: `not_charging_reason` is `null` on a preview that charges now, and the optional `capped`, `balance_after_credits` and `monthly_budget_remaining_cents` are passed through as served (int64 fields as numbers via `wireCents`). Nothing is derived on the client; an older server that omits them reads as absent. - The preview query is added to the route with `URLSearchParams`, the same way `events.ts` does it. The transport needs no query support. ### Open points for PR2 - The PUT docs say a 5xx "may have committed, re-read with GET". This PR only returns the failure. Invalidating and re-reading belongs in the state layer (PR2/PR3). ## Plan position | PR | Scope | Status | | --- | --- | --- | | Sync | ingest-types sync carrying cloud#17298 | merged (#22354) | | **PR1 (this)** | **account-core: auto top-up reader, save, preview** | **open** | | PR2 | account-core shared state/view derivation, after a design check of the billing-site rules (`utils/autoTopUp.ts` in platform) against the app card (`BillingAutoTopUpCard.vue` `viewKey`) | design check first | | PR3 | account-ui `useAutoTopUp` composable | pending | | PR4 | ComfyUI app adopts | pending | | PR5 | publish `account-core` / `account-ui` to npm; billing site adopts | pending | ```mermaid graph LR S["ingest-types sync with cloud#17298"] --> PR1 PR1["PR1 core reader/save/preview"]:::current --> PR2["PR2 shared state/view derivation"] PR2 --> PR3["PR3 account-ui useAutoTopUp"] PR3 --> PR4["PR4 app adopts"] PR3 --> PR5["PR5 npm publish + billing site adopts"] classDef current fill:#f5a623,stroke:#333,stroke-width:2px,color:#000 ``` ## AS IS / TO BE No UI change (SDK only). ## Verification - `pnpm exec vitest run src/core/billing/autoTopUp.test.ts` in `packages/account-core`: 32 tests passed. - New `autoTopUp.test.ts` covers: - Reader: decoding with int64 as numbers, a workspace change mid-read giving `SUPERSEDED`, concurrent reads sharing one request, a fractional count giving `MALFORMED_RESPONSE`, the HTTP status table, and invalidate fencing a read already in flight. - Save: the request is a PUT carrying the body, the reply is decoded, the 400/409/422/500 refusals keep their server codes, no idempotency key is sent so a 401 comes back as `REQUEST_FAILED`, and `INVALID_REQUEST` is returned before anything is sent. - Preview: query encoding with and without a budget, `charges_now` true with `not_charging_reason: null` (with and without `capped` / `balance_after_credits` / `monthly_budget_remaining_cents`), `charges_now` false, optional fields absent when omitted, a fractional budget remainder as `MALFORMED_RESPONSE`, and 422/409/503 as coded failures. - The auto top-up reader is added to the shared `scopedReader.test.ts` contract table. - `transport.test.ts`: a PUT without a key is never replayed on 401 (POST and PUT in one table) and a PUT with a key is replayed. The credentialed transport sends the PUT method and body. `credentialedTransport.webSession.test.ts`: a PUT gets the CSRF header. - Mutation check: changing the replay gate to `method !== 'POST'` turns the PUT no-replay test red. - Pre-commit: eslint, oxlint, oxfmt, `typecheck:app`, `typecheck:account-core` all passed.
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-03T18:25:13.011Z",
"gitSha": "bbfd5b9ebe9555341d22ddc4b4d0cf2461be4325",
"branch": "backport-22413-to-cloud-1.60",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2027.343000000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.798,
"layouts": 9,
"layoutDurationMs": 2.8680000000000003,
"taskDurationMs": 605.374,
"heapDeltaBytes": 15492512,
"heapUsedBytes": 75141912,
"domNodes": -178,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 10.677000000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2022.6499999999987,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1790000000000003,
"layouts": 10,
"layoutDurationMs": 3.28,
"taskDurationMs": 557.4970000000001,
"heapDeltaBytes": -13201248,
"heapUsedBytes": 63924192,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 10.22,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1907.2419999999966,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.832,
"layouts": 10,
"layoutDurationMs": 2.8960000000000004,
"taskDurationMs": 1011.644,
"heapDeltaBytes": 4954196,
"heapUsedBytes": 66095736,
"domNodes": -178,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 172.57199999999997,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66578947368421,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1824.7210000000678,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.802000000000001,
"layouts": 9,
"layoutDurationMs": 2.5109999999999992,
"taskDurationMs": 926.5820000000001,
"heapDeltaBytes": 591224,
"heapUsedBytes": 61755652,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 165.717,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871563,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.1359999999913,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.68,
"layouts": 12,
"layoutDurationMs": 3.6240000000000006,
"taskDurationMs": 462.041,
"heapDeltaBytes": 6118320,
"heapUsedBytes": 74967712,
"domNodes": 57,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 13.641000000000004,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1692.1960000000809,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.382000000000001,
"layouts": 10,
"layoutDurationMs": 3.222,
"taskDurationMs": 425.7460000000001,
"heapDeltaBytes": 25380316,
"heapUsedBytes": 85608896,
"domNodes": 57,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 12.204000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 693.411999999995,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.7620000000000005,
"layouts": 9,
"layoutDurationMs": 2.6350000000000002,
"taskDurationMs": 513.272,
"heapDeltaBytes": -10954896,
"heapUsedBytes": 62166536,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 176.20599999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 708.8459999999941,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.704,
"layouts": 9,
"layoutDurationMs": 2.732,
"taskDurationMs": 505.969,
"heapDeltaBytes": 8638040,
"heapUsedBytes": 78418668,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 172.779,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285718,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1157.2390000000041,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 855.543,
"heapDeltaBytes": 16308756,
"heapUsedBytes": 81672572,
"domNodes": 0,
"jsHeapTotalBytes": 13533184,
"scriptDurationMs": 66.71100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 526,
"frameDurationMs": 34.84545454545455,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1258.0330000000686,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 957.683,
"heapDeltaBytes": 17904180,
"heapUsedBytes": 108399520,
"domNodes": -148,
"jsHeapTotalBytes": 21397504,
"scriptDurationMs": 65.18400000000001,
"eventListeners": -107,
"totalBlockingTimeMs": 592,
"frameDurationMs": 35.71142857142858,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 892.7740000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.8349999999999,
"heapDeltaBytes": -17668292,
"heapUsedBytes": 69139724,
"domNodes": -208,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 176.96699999999998,
"eventListeners": -107,
"totalBlockingTimeMs": 230,
"frameDurationMs": 24.997222222222213,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 893.0250000000797,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 573.5420000000003,
"heapDeltaBytes": -10013996,
"heapUsedBytes": 76981072,
"domNodes": -208,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 173.94800000000004,
"eventListeners": -107,
"totalBlockingTimeMs": 230,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11866.140000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10998.383,
"heapDeltaBytes": 92030408,
"heapUsedBytes": 166718032,
"domNodes": -274,
"jsHeapTotalBytes": 85323776,
"scriptDurationMs": 8847.481,
"eventListeners": -69,
"totalBlockingTimeMs": 1608,
"frameDurationMs": 32.64297520661157,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10787.812999999971,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9943.009999999998,
"heapDeltaBytes": 85752308,
"heapUsedBytes": 160690832,
"domNodes": -274,
"jsHeapTotalBytes": 77721600,
"scriptDurationMs": 7893.112999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 820,
"frameDurationMs": 30.985344827586207,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11524.423000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10807.485,
"heapDeltaBytes": 32552740,
"heapUsedBytes": 95326276,
"domNodes": -179,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 8784.338,
"eventListeners": 0,
"totalBlockingTimeMs": 1636,
"frameDurationMs": 31.858839779005525,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10552.471000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9740.702,
"heapDeltaBytes": 67693800,
"heapUsedBytes": 143955760,
"domNodes": -274,
"jsHeapTotalBytes": 62517248,
"scriptDurationMs": 7772.481,
"eventListeners": -69,
"totalBlockingTimeMs": 881,
"frameDurationMs": 31.304747774480713,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 297.73700000001213,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.815,
"layouts": 10,
"layoutDurationMs": 3.27,
"taskDurationMs": 247.816,
"heapDeltaBytes": -12784116,
"heapUsedBytes": 63461404,
"domNodes": 936,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 12.414000000000001,
"eventListeners": 205,
"totalBlockingTimeMs": 7,
"frameDurationMs": 25,
"p95FrameDurationMs": 116.59999999999991
},
{
"name": "large-combo-open",
"durationMs": 290.7859999999687,
"styleRecalcs": 26,
"styleRecalcDurationMs": 15.910999999999998,
"layouts": 11,
"layoutDurationMs": 3.3229999999999995,
"taskDurationMs": 250.143,
"heapDeltaBytes": -7226096,
"heapUsedBytes": 75892016,
"domNodes": 936,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.677999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 5,
"frameDurationMs": 23.076923076923077,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2056.8419999999605,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.94,
"layouts": 9,
"layoutDurationMs": 2.691,
"taskDurationMs": 739.5679999999999,
"heapDeltaBytes": -20275576,
"heapUsedBytes": 61304056,
"domNodes": -274,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 39.785,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2057.4000000000296,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3579999999999997,
"layouts": 8,
"layoutDurationMs": 2.1670000000000003,
"taskDurationMs": 672.4219999999998,
"heapDeltaBytes": -19089916,
"heapUsedBytes": 63775392,
"domNodes": -274,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 34.35900000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2872.7030000000013,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.932,
"layouts": 7,
"layoutDurationMs": 2.181,
"taskDurationMs": 1802.3219999999997,
"heapDeltaBytes": -17450212,
"heapUsedBytes": 62246724,
"domNodes": -274,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 839.2579999999999,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665697674418606,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2723.220999999967,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.476,
"layouts": 7,
"layoutDurationMs": 2.049,
"taskDurationMs": 1756.4930000000004,
"heapDeltaBytes": -21344244,
"heapUsedBytes": 62513020,
"domNodes": -274,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 831.391,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3845.320999999956,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.063000000000002,
"layouts": 64,
"layoutDurationMs": 10.081,
"taskDurationMs": 1778.365,
"heapDeltaBytes": 14380412,
"heapUsedBytes": 87449060,
"domNodes": 24,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 780.554,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66580086580087,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3907.112999999981,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.882000000000001,
"layouts": 64,
"layoutDurationMs": 10.707999999999998,
"taskDurationMs": 1904.2990000000002,
"heapDeltaBytes": -23898660,
"heapUsedBytes": 61792664,
"domNodes": -250,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 813.207,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666382978723405,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3065.967999999998,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.902,
"layouts": 5,
"layoutDurationMs": 1.5380000000000003,
"taskDurationMs": 1990.642,
"heapDeltaBytes": -5480212,
"heapUsedBytes": 81406104,
"domNodes": 0,
"jsHeapTotalBytes": 4943872,
"scriptDurationMs": 973.826,
"eventListeners": 182,
"totalBlockingTimeMs": 1,
"frameDurationMs": 16.8489010989011,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3198.823999999945,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.019,
"layouts": 5,
"layoutDurationMs": 1.1909999999999998,
"taskDurationMs": 2040.0599999999995,
"heapDeltaBytes": -9293512,
"heapUsedBytes": 76769060,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 999.6989999999998,
"eventListeners": 182,
"totalBlockingTimeMs": 2,
"frameDurationMs": 16.84083769633508,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3035.5199999999913,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3609999999999993,
"layouts": 7,
"layoutDurationMs": 1.9780000000000002,
"taskDurationMs": 718.3149999999999,
"heapDeltaBytes": -7807692,
"heapUsedBytes": 75412848,
"domNodes": -274,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 360.193,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3071.901999999966,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.8829999999999993,
"layouts": 6,
"layoutDurationMs": 1.7320000000000004,
"taskDurationMs": 764.4210000000002,
"heapDeltaBytes": 4350460,
"heapUsedBytes": 88003600,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 365.62699999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666304347826088,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2059.436000000005,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.398999999999999,
"layouts": 7,
"layoutDurationMs": 2.1620000000000004,
"taskDurationMs": 785.7570000000001,
"heapDeltaBytes": -20281864,
"heapUsedBytes": 65582892,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 38.044000000000004,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2044.354999999996,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4349999999999996,
"layouts": 7,
"layoutDurationMs": 2.056,
"taskDurationMs": 694.135,
"heapDeltaBytes": -19527112,
"heapUsedBytes": 65161068,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 36.812999999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2803.0129999999926,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.153,
"layouts": 6,
"layoutDurationMs": 1.5350000000000004,
"taskDurationMs": 584.184,
"heapDeltaBytes": -18639480,
"heapUsedBytes": 73322076,
"domNodes": 19,
"jsHeapTotalBytes": 4493312,
"scriptDurationMs": 191.204,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571428,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2877.543000000003,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.829999999999998,
"layouts": 7,
"layoutDurationMs": 2.0010000000000003,
"taskDurationMs": 640.511,
"heapDeltaBytes": -6685060,
"heapUsedBytes": 77987612,
"domNodes": -256,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 192.328,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665895953757225,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3363.8090000000034,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.7880000000000005,
"layouts": 6,
"layoutDurationMs": 1.7750000000000001,
"taskDurationMs": 984.904,
"heapDeltaBytes": 4047600,
"heapUsedBytes": 79987960,
"domNodes": -274,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 399.297,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665841584158414,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3292.395000000056,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9840000000000004,
"layouts": 7,
"layoutDurationMs": 1.818,
"taskDurationMs": 987.496,
"heapDeltaBytes": -4330152,
"heapUsedBytes": 79344148,
"domNodes": -274,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 381.585,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66548223350254,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 672.2219999999766,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.023000000000001,
"layouts": 9,
"layoutDurationMs": 2.519,
"taskDurationMs": 473.66200000000003,
"heapDeltaBytes": 3801624,
"heapUsedBytes": 74671932,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 148.927,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667500000000008,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 628.172999999947,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.162999999999999,
"layouts": 9,
"layoutDurationMs": 2.64,
"taskDurationMs": 461.137,
"heapDeltaBytes": 24813612,
"heapUsedBytes": 86606328,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 147.422,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864864,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2039.9550000000204,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.204,
"layouts": 8,
"layoutDurationMs": 2.796,
"taskDurationMs": 612.0870000000001,
"heapDeltaBytes": 6283004,
"heapUsedBytes": 68794408,
"domNodes": -200,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 9.666999999999998,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.5910000000104,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.902,
"layouts": 8,
"layoutDurationMs": 2.6159999999999997,
"taskDurationMs": 542.7729999999999,
"heapDeltaBytes": 4608976,
"heapUsedBytes": 67404252,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 8.549000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1840.2340000000095,
"styleRecalcs": 60,
"styleRecalcDurationMs": 15.885000000000003,
"layouts": 9,
"layoutDurationMs": 3.24,
"taskDurationMs": 987.555,
"heapDeltaBytes": -5661096,
"heapUsedBytes": 58732528,
"domNodes": -200,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 113.23,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666363636363638,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.9240000000873,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.747,
"layouts": 9,
"layoutDurationMs": 2.6969999999999996,
"taskDurationMs": 914.2660000000001,
"heapDeltaBytes": 919640,
"heapUsedBytes": 75681768,
"domNodes": -200,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 112.43999999999998,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 1605.1760000000286,
"styleRecalcs": 16,
"styleRecalcDurationMs": 26.14400000000001,
"layouts": 5,
"layoutDurationMs": 19.197999999999997,
"taskDurationMs": 1340.2730000000001,
"heapDeltaBytes": 4490444,
"heapUsedBytes": 84080264,
"domNodes": -1320,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 30.966999999999995,
"eventListeners": -262,
"totalBlockingTimeMs": 221,
"frameDurationMs": 20.9948051948052,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10655.580999999984,
"styleRecalcs": 250,
"styleRecalcDurationMs": 28.251,
"layouts": 8,
"layoutDurationMs": 2.1839999999999997,
"taskDurationMs": 6271.445,
"heapDeltaBytes": 1972516,
"heapUsedBytes": 74557772,
"domNodes": -274,
"jsHeapTotalBytes": 843776,
"scriptDurationMs": 2789.36,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6660406885759,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10989.625000000047,
"styleRecalcs": 251,
"styleRecalcDurationMs": 28.67,
"layouts": 8,
"layoutDurationMs": 2.052,
"taskDurationMs": 6406.606,
"heapDeltaBytes": -19763068,
"heapUsedBytes": 62123316,
"domNodes": -274,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 2829.4030000000002,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6660091047041,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23994.68999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23306.342,
"heapDeltaBytes": -17099432,
"heapUsedBytes": 266240160,
"domNodes": -3482,
"jsHeapTotalBytes": 12304384,
"scriptDurationMs": 328.675,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.9270979020979,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 24439.06800000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23659.814,
"heapDeltaBytes": -49720336,
"heapUsedBytes": 260733220,
"domNodes": -3482,
"jsHeapTotalBytes": 10993664,
"scriptDurationMs": 328.975,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.61029668411867,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 29350.55,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.258999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28962.742,
"heapDeltaBytes": -18291840,
"heapUsedBytes": 272604788,
"domNodes": -3482,
"jsHeapTotalBytes": 12828672,
"scriptDurationMs": 902.2420000000001,
"eventListeners": -659,
"totalBlockingTimeMs": 14,
"frameDurationMs": 53.8508256880734,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 29461.189999999988,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.054000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 29134.105000000003,
"heapDeltaBytes": -27642696,
"heapUsedBytes": 256499100,
"domNodes": -3482,
"jsHeapTotalBytes": 13615104,
"scriptDurationMs": 968.74,
"eventListeners": -659,
"totalBlockingTimeMs": 125,
"frameDurationMs": 56.69634615384616,
"p95FrameDurationMs": 116.69999999999709
},
{
"name": "vue-node-resize-workload",
"durationMs": 8633.557999999994,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.12999999999999,
"layouts": 20,
"layoutDurationMs": 23.312999999999988,
"taskDurationMs": 8519.233,
"heapDeltaBytes": -5658852,
"heapUsedBytes": 284695120,
"domNodes": -3482,
"jsHeapTotalBytes": 17022976,
"scriptDurationMs": 126.192,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 49.33085714285714,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 8780.889000000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 86.337,
"layouts": 20,
"layoutDurationMs": 25.948999999999987,
"taskDurationMs": 8666.855000000001,
"heapDeltaBytes": -41511980,
"heapUsedBytes": 262025624,
"domNodes": -3482,
"jsHeapTotalBytes": 16498688,
"scriptDurationMs": 127.35499999999999,
"eventListeners": -661,
"totalBlockingTimeMs": 27,
"frameDurationMs": 50.477011494252864,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12315.598999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11914.037,
"heapDeltaBytes": 13470312,
"heapUsedBytes": 287632792,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 157.559,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.78618181818183,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12552.495999999905,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12159.157000000001,
"heapDeltaBytes": 21686828,
"heapUsedBytes": 275408364,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 170.3,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.1254295532646,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 149.75599999996803,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.501999999999999,
"layouts": 9,
"layoutDurationMs": 3.0930000000000004,
"taskDurationMs": 112.12399999999998,
"heapDeltaBytes": -12117000,
"heapUsedBytes": 62062888,
"domNodes": 101,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 9.054,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.677777777777766,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 131.58999999996013,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.415000000000001,
"layouts": 9,
"layoutDurationMs": 3.475,
"taskDurationMs": 86.879,
"heapDeltaBytes": 4820060,
"heapUsedBytes": 66843408,
"domNodes": 120,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.805999999999997,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.674999999999955,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 594.2469999999958,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.709,
"layouts": 76,
"layoutDurationMs": 15.914000000000001,
"taskDurationMs": 556.3739999999999,
"heapDeltaBytes": 596284,
"heapUsedBytes": 47710680,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 275.957,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 583.9480000000776,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.7110000000000001,
"layouts": 76,
"layoutDurationMs": 16.387,
"taskDurationMs": 538.428,
"heapDeltaBytes": -2742092,
"heapUsedBytes": 43369388,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 266.494,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 646.4240000000245,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.339,
"layouts": 76,
"layoutDurationMs": 15.908999999999999,
"taskDurationMs": 621.03,
"heapDeltaBytes": 1631340,
"heapUsedBytes": 107125412,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 260.41700000000003,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.092307692307703,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 661.8099999999458,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.3080000000000003,
"layouts": 76,
"layoutDurationMs": 16.310000000000002,
"taskDurationMs": 629.61,
"heapDeltaBytes": -24687896,
"heapUsedBytes": 80750516,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 259.975,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.799999999999272
}
]
}🎭 Playwright: ✅ 3221 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 2074a38e3f8a45cd981fab2a26bbb3324d12f118
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (356)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.60 #22827 +/- ##
=============================================
Coverage ? 87.58%
=============================================
Files ? 2996
Lines ? 162700
Branches ? 41824
=============================================
Hits ? 142504
Misses ? 19263
Partials ? 933
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Clean automatic backport; CI green.
Backport of #22413 to
cloud/1.60Automatically created by backport workflow.