Repository navigation
fix(agent): keep an unsent chat draft across a page refresh #22821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
59 changes: 59 additions & 0 deletions
59
browser_tests/tests/agent/agentComposerDraftSurvivesReload.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| import { expect } from '@playwright/test' | ||
|
|
||
| import enMessages from '@/locales/en/main.json' with { type: 'json' } | ||
|
|
||
| import { waitForCloudApp } from '@e2e/fixtures/cloudAppFixture' | ||
| import { agentTest as test } from '@e2e/tests/agent/agentPanelMocks' | ||
|
|
||
| test.describe( | ||
| 'Agent composer draft survives a page refresh', | ||
| { tag: ['@cloud', '@ui'] }, | ||
| () => { | ||
| test('restores an unsent draft after a reload, but not one discarded by New Chat', async ({ | ||
| agentPanel, | ||
| page | ||
| }, testInfo) => { | ||
| await agentPanel.open() | ||
| const draft = 'Make the background a sunset over the ocean' | ||
|
|
||
| await test.step('an unsent draft is still in the composer after a reload', async () => { | ||
| await agentPanel.composer.fill(draft) | ||
| await expect(agentPanel.composer).toHaveText(draft) | ||
|
|
||
| await page.reload() | ||
| await waitForCloudApp(page) | ||
| await agentPanel.open() | ||
| await expect(agentPanel.composer).toHaveText(draft) | ||
| await testInfo.attach('draft-restored-after-reload', { | ||
| body: await agentPanel.root.screenshot({ | ||
| path: testInfo.outputPath('draft-restored-after-reload.png') | ||
| }), | ||
| contentType: 'image/png' | ||
| }) | ||
| }) | ||
|
|
||
| await test.step('New Chat leaves the composer empty after a reload', async () => { | ||
| await agentPanel.root | ||
| .getByRole('button', { name: enMessages.agent.newChat }) | ||
| .click() | ||
| await expect(agentPanel.composer).toHaveText('') | ||
|
|
||
| await page.reload() | ||
| await waitForCloudApp(page) | ||
| await agentPanel.open() | ||
| await expect( | ||
| agentPanel.root.getByText(enMessages.agent.placeholder, { | ||
| exact: true | ||
| }) | ||
| ).toBeVisible() | ||
| await expect(agentPanel.composer).toHaveText('') | ||
| await testInfo.attach('new-chat-empty-after-reload', { | ||
| body: await agentPanel.root.screenshot({ | ||
| path: testInfo.outputPath('new-chat-empty-after-reload.png') | ||
| }), | ||
| contentType: 'image/png' | ||
| }) | ||
| }) | ||
| }) | ||
| } | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.