Repository navigation
[backport cloud/1.59] fix(agent): bind the workflow a followed chat opens (FRONT-3804) - #22813
Conversation
…rs (#21964) ## Summary Black-box proof for #19871: resetting one workflow's document must not reset the human op sender's mint cursor for another workflow. The case edits workflow B, visits and resets workflow A, returns to B, and edits again before B's resubscribe is acknowledged; the second B edit must carry a higher `base_version` than the first. Test and harness only — no production change. Supersedes #19876, whose three production commits already merged in #19871 and whose harness no longer applied to the redesigned `AgentFollowerHostSocket` on `main`. ## Changes - `AgentFollowerHostSocket` can serve several documents on one routed socket (`addWorkflow`), hold one workflow's subscribe answer (`pauseSubscribes` / `resumeSubscribe`), record each op's wire `base_version`, count subscribes per workflow, and judge or release a human batch against the document that sent it. Existing single-document behaviour is unchanged. - `AgentConversationHarness` gains `activateEmptyWorkflow`, `sendDocumentReset`, and `activateRecordedWorkflowBeforeSubscribeAck`. - New spec `browser_tests/tests/agent/agentHumanEditAfterOtherWorkflowReset.spec.ts`. ## Verification - `pnpm exec playwright test browser_tests/tests/agent/agentHumanEditAfterOtherWorkflowReset.spec.ts --project=cloud --repeat-each=3`: 3/3 pass on this head. - Mutation check: replacing the per-workflow `lastMintedVersions.delete(resetWorkflowId)` in `opSender.abortAll` with `lastMintedVersions.clear()` fails the spec (`Expected: > 1, Received: 0`). - The 25 `@cloud` agent specs that use the routed host's subscribe, hold/release, or refusal controls: 46/46 tests pass; two failed once on a cold dev server with two workers and passed on rerun. - `vitest run browser_tests/fixtures/agentFollowerHostSocket.test.ts`: 17/17. `pnpm typecheck` and `pnpm typecheck:browser` clean. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: mrseek-reviews[bot] <337131926+mrseek-reviews[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> (cherry picked from commit a421e90)
…81) (#22596) - Records unsynced state only when a real local graph intent occurs while the bound workflow document is not yet confirmed; merely binding or abandoning a target stays clean. - Preserves genuine unsynced ownership across follower/product-gate restarts, then lets the replacement follower retire it after confirmation. - Keeps the existing restore warning and bind guard unchanged. Linear: FRONT-3581 (split from FE-1969 / #21147). - [x] Cloud black-box harness: `agentFollowerRestoredBindingReload.spec.ts` makes and saves a widget edit while identity is pending, restores again, resolves identity, and verifies the visible edit survives without an unsafe second subscription. - [x] Parent-behavior RED proof: removing only the production intent-to-follower wiring makes that test fail (`expected subscribe count 1, received 2`); restored wiring is GREEN. - [x] Focused Vitest after live-main rebase: 729 tests passed across AgentPanelRoot, docOpMinter, unsynced ownership, and product-gate restart coverage. - [x] Commit hooks: app/browser typecheck, type-aware lint, ESLint, stylelint, server-facts all passed. - [x] Push hooks: dependency-cruiser, knip, and fallow changed-file audit passed with zero findings. (cherry picked from commit c76f916)
) ## Summary Agent edits to a workflow whose tab is in the background now appear when you switch back. Before this, they appeared only after a reload (1.60 regression from #21512, [FRONT-3804](https://linear.app/comfyorg/issue/FRONT-3804)). Root cause: clicking a saved tab opens that tab's chat. Loading a chat clears the session binding that the CRDT follower subscribes to, and the follow path never set it again. The follower stayed detached, and the next turn's acknowledgement was the only thing that reattached it. The fix binds the followed chat's workflow the same way a chat restored from history already does, with the same unsynced-human-ops guard (#21147). <details><summary>Full context for agent readers</summary> - **Regressing commit:** 1a6324c (#21512, "carry workflow chat follow onto current main"). It changed `useAgentSession`'s `restored` hook from `onWorkflowRestoredAndBound` to `restoreChatWorkflow`. The follow branch of that hook calls `adoptWorkflowTarget` + `adoptRestoredWorkflowTab` but never `bindWorkflow`, while `loadThread` → `openThread` → `forgetBinding()` has already nulled `boundWorkflowId`. With `boundWorkflowId === null`, `isFollowerActive` is false, so `useAgentCrdtFollower` unsubscribes and never resubscribes. - **Matches QA CNV06 step 5:** the first `add_node` landed live before the switch. After the follow, nothing else reached the canvas, so the node stayed untitled, the turn read "Changes not confirmed on your canvas", and a reload restored everything. - **Bisect:** the canvas-only variant of the new spec is green at f9f5b8d (the parent of 1a6324c) and red at 1a6324c. 1.59.0.dev2 (864bfc9) predates #21512. - **Change:** `AgentPanelRoot.vue` extracts `bindRestoredWorkflow` from `onWorkflowRestoredAndBound`. The follow path's `adoptWorkflowTarget` dep now also binds. No change to the follower, the projection or the applier. No reconcile pass. Remote apply still goes through the graph API. - **Unsynced guard on the follow bind (review round 1):** before this round, an unbound local edit was recorded as unsynced only when it hit the *bound* workflow. An edit to the visible tab while another workflow, or none, was bound went unrecorded, so the follow could bind that tab and run catch-up over a canvas the document never saw. `docOpMinter` now reports those edits through `onUnboundVisibleIntent`. `AgentPanelRoot` records them under the visible tab's confirmed binding (`bindingStore.workflowIdFor`), so `bindRestoredWorkflow`'s existing `hasUnsyncedHumanOps` guard refuses the bind. Tabs with no confirmed binding are not recorded, so edits made before a workflow's first chat do not block its later follow bind. No reconcile pass. - **Why the spec exists:** the agent edits saved workflow A while the user is on saved workflow B, whose own chat the panel follows. Returning to A must show every edit the agent made there, without a reload. Following a tab's chat loads that chat, which clears the session binding the CRDT follower subscribes to. Unless the followed chat binds its workflow again, the follower stays detached. Source: frontend 1.60 QA check CNV06 step 5, [FRONT-3804](https://linear.app/comfyorg/issue/FRONT-3804). - **Harness:** `agentConversationFixture` gains `applyOpsOnHostUnsent` (a host edit made while this client follows another workflow; the host fans it out only to subscribers, so it reaches this client only in the catch-up that answers its next subscribe), `serveWorkflow` (a second workflow's document) and `holdTranscript` (holds one thread's transcript read so a test can act while a chat loads). The spec's workflows, threads and transcripts live in `fixtures/data/agent/backgroundTabEdits.ts` and are served by the existing `AgentWorkflowChatsMock`. </details> ## Verification - New black-box spec `browser_tests/tests/agent/agentBackgroundTabEditsLand.spec.ts`: red on `main` a8c2ace (`[data-node-id="801"]` title never appears), green with the fix, 4/4 on `--repeat-each=4`. - Second case in the same spec, `do not rebind a tab the user edited while its chat was loading`: red with only the visible-intent wiring removed (B re-subscribed, subscribe count 2, expected 1), green with it. Both cases pass 6/6 on `--repeat-each=3` at `2e1e1c4f9b`. The first case is still red with the follow bind removed. - Neighbouring agent specs green: follows-chat, tab-chat transitions, restored-binding reload, tab-switch catch-up, reload binding, history reopen/focus, duplicate-name binding, stale tab binding, new-chat target, human-add tab switch. One failure, `agentWorkflowSelection` "picks an unsaved tab a reload left unopened", fails identically on unmodified `main` on this host, so it is unrelated. - `AgentPanelRoot.test.ts` and `useAgentWorkflowChatFollow.test.ts` pass (575/575). `typecheck` and `typecheck:browser` pass, and pre-commit/pre-push hooks ran. - **Backport:** `core/1.60` and `cloud/1.60` (the pin decision), plus `core/1.59` and `cloud/1.59`, whose tips already carry #21512. `cloud/v1.59.1` and later tags ship it. Tag `v1.59.0` does not. (cherry picked from commit 6dd3d82)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-03T12:42:52.224Z",
"gitSha": "bda8fab8a0fa1d947f975b10248adf00cde8a345",
"branch": "backport-22792-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.0709999999963,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.3970000000000002,
"layouts": 9,
"layoutDurationMs": 2.344,
"taskDurationMs": 508.606,
"heapDeltaBytes": 2170484,
"heapUsedBytes": 64003164,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 8.238999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.6779999999985,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4010000000000002,
"layouts": 8,
"layoutDurationMs": 2.409,
"taskDurationMs": 509.182,
"heapDeltaBytes": 4515376,
"heapUsedBytes": 65800132,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 7.693000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1774.7260000000153,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.344,
"layouts": 9,
"layoutDurationMs": 2.529,
"taskDurationMs": 859.453,
"heapDeltaBytes": -1719984,
"heapUsedBytes": 69422556,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 160.564,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1725.9639999999763,
"styleRecalcs": 73,
"styleRecalcDurationMs": 11.339,
"layouts": 8,
"layoutDurationMs": 2.0469999999999997,
"taskDurationMs": 856.21,
"heapDeltaBytes": 21291076,
"heapUsedBytes": 82755508,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 157.25699999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667307692307695,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.9350000000163,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.581999999999999,
"layouts": 12,
"layoutDurationMs": 2.8669999999999995,
"taskDurationMs": 399.873,
"heapDeltaBytes": 2778844,
"heapUsedBytes": 78874432,
"domNodes": 56,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 9.798000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.8370000000032,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.723,
"layouts": 10,
"layoutDurationMs": 2.7289999999999996,
"taskDurationMs": 387.39599999999996,
"heapDeltaBytes": -1807316,
"heapUsedBytes": 60346856,
"domNodes": 56,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 9.594000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 662.4529999999993,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.8779999999999997,
"layouts": 9,
"layoutDurationMs": 2.3339999999999996,
"taskDurationMs": 488.139,
"heapDeltaBytes": 6356612,
"heapUsedBytes": 67831004,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 173.75099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 645.8130000000892,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.269,
"layouts": 8,
"layoutDurationMs": 2.097,
"taskDurationMs": 487.985,
"heapDeltaBytes": 3641000,
"heapUsedBytes": 65456904,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 169.611,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102567,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1197.3370000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 894.651,
"heapDeltaBytes": -12697376,
"heapUsedBytes": 75261616,
"domNodes": -191,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 66.786,
"eventListeners": -107,
"totalBlockingTimeMs": 508,
"frameDurationMs": 32.43513513513512,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1165.8289999999738,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 851.3660000000001,
"heapDeltaBytes": 21307100,
"heapUsedBytes": 85676320,
"domNodes": 0,
"jsHeapTotalBytes": 13271040,
"scriptDurationMs": 65.50399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 544,
"frameDurationMs": 35.35151515151515,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.150999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.7149999999999,
"heapDeltaBytes": -4543540,
"heapUsedBytes": 69071456,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 153.74900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 213,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 893.2609999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 570.8109999999999,
"heapDeltaBytes": -28017588,
"heapUsedBytes": 66519860,
"domNodes": -191,
"jsHeapTotalBytes": 4325376,
"scriptDurationMs": 176.081,
"eventListeners": -107,
"totalBlockingTimeMs": 237,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10236.484999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9383.28,
"heapDeltaBytes": 62842604,
"heapUsedBytes": 137474700,
"domNodes": -257,
"jsHeapTotalBytes": 57536512,
"scriptDurationMs": 7464.747,
"eventListeners": -69,
"totalBlockingTimeMs": 949,
"frameDurationMs": 31.485846153846158,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10130.771999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9378.601999999999,
"heapDeltaBytes": 66662504,
"heapUsedBytes": 141294448,
"domNodes": -257,
"jsHeapTotalBytes": 62517248,
"scriptDurationMs": 7497.069,
"eventListeners": -69,
"totalBlockingTimeMs": 793,
"frameDurationMs": 31.274691358024697,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10229.334999999992,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.07400000000000029,
"layouts": 1,
"layoutDurationMs": 0.294,
"taskDurationMs": 9423.572999999999,
"heapDeltaBytes": 59885976,
"heapUsedBytes": 134384924,
"domNodes": -257,
"jsHeapTotalBytes": 68022272,
"scriptDurationMs": 7542.407,
"eventListeners": -69,
"totalBlockingTimeMs": 813,
"frameDurationMs": 31.826168224299067,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11048.704999999984,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.4030000000000006,
"layouts": 1,
"layoutDurationMs": 0.3280000000000002,
"taskDurationMs": 10364.501,
"heapDeltaBytes": 91405100,
"heapUsedBytes": 166223884,
"domNodes": -257,
"jsHeapTotalBytes": 85323776,
"scriptDurationMs": 8481.459,
"eventListeners": -69,
"totalBlockingTimeMs": 1442,
"frameDurationMs": 31.939193083573482,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 235.4389999999853,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.701999999999998,
"layouts": 9,
"layoutDurationMs": 2.2950000000000004,
"taskDurationMs": 171.58599999999998,
"heapDeltaBytes": 14591896,
"heapUsedBytes": 74806700,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.418999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 3,
"frameDurationMs": 23.33000000000002,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 259.3439999999987,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.45,
"layouts": 11,
"layoutDurationMs": 2.974,
"taskDurationMs": 218.2,
"heapDeltaBytes": -14261932,
"heapUsedBytes": 68613108,
"domNodes": -2315,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 8.575999999999999,
"eventListeners": -574,
"totalBlockingTimeMs": 2,
"frameDurationMs": 22.216666666666697,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "large-graph-idle",
"durationMs": 2031.316000000004,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.8580000000000003,
"layouts": 5,
"layoutDurationMs": 1.5350000000000004,
"taskDurationMs": 600.9879999999998,
"heapDeltaBytes": -3770320,
"heapUsedBytes": 69881528,
"domNodes": -257,
"jsHeapTotalBytes": -1183744,
"scriptDurationMs": 32.155,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2053.7069999999176,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.241,
"layouts": 8,
"layoutDurationMs": 2.371,
"taskDurationMs": 621.365,
"heapDeltaBytes": -6930212,
"heapUsedBytes": 70495368,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 29.303000000000004,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2756.697000000031,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.298,
"layouts": 6,
"layoutDurationMs": 1.485,
"taskDurationMs": 1855.334,
"heapDeltaBytes": 2773352,
"heapUsedBytes": 78498532,
"domNodes": -257,
"jsHeapTotalBytes": 5332992,
"scriptDurationMs": 925.496,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.767272727272722,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2568.5039999999617,
"styleRecalcs": 66,
"styleRecalcDurationMs": 7.361000000000001,
"layouts": 4,
"layoutDurationMs": 0.9260000000000002,
"taskDurationMs": 1651.6119999999999,
"heapDeltaBytes": 15055260,
"heapUsedBytes": 76147408,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 820.355,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66623376623377,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3639.04500000001,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.056,
"layouts": 64,
"layoutDurationMs": 10.145,
"taskDurationMs": 1766.4470000000003,
"heapDeltaBytes": -7996888,
"heapUsedBytes": 69055328,
"domNodes": -233,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 775.7780000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66605504587156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3628.139000000033,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.198,
"layouts": 65,
"layoutDurationMs": 10.142,
"taskDurationMs": 1716.818,
"heapDeltaBytes": 1980204,
"heapUsedBytes": 73531856,
"domNodes": 24,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 770.0400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66589861751152,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3058.1549999999993,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.059,
"layouts": 5,
"layoutDurationMs": 1.208,
"taskDurationMs": 1936.588,
"heapDeltaBytes": 19335176,
"heapUsedBytes": 99389516,
"domNodes": 0,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 963.052,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75769230769231,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2758.4940000000415,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.283,
"layouts": 2,
"layoutDurationMs": 0.5840000000000003,
"taskDurationMs": 1698.2079999999999,
"heapDeltaBytes": 6194588,
"heapUsedBytes": 69003988,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 949.308,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76829268292683,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3108.7090000000044,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.4150000000000005,
"layouts": 5,
"layoutDurationMs": 1.343,
"taskDurationMs": 798.874,
"heapDeltaBytes": 7681436,
"heapUsedBytes": 86762504,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 383.961,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665775401069517,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3094.906999999978,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8390000000000004,
"layouts": 7,
"layoutDurationMs": 1.6879999999999997,
"taskDurationMs": 785.915,
"heapDeltaBytes": 3281788,
"heapUsedBytes": 80163004,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 367.93,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.757065217391304,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2047.2110000000043,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.019,
"layouts": 7,
"layoutDurationMs": 1.8670000000000002,
"taskDurationMs": 624.508,
"heapDeltaBytes": -18179708,
"heapUsedBytes": 62709064,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 30.251,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.2199999999857,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.8859999999999997,
"layouts": 7,
"layoutDurationMs": 1.673,
"taskDurationMs": 623.7389999999999,
"heapDeltaBytes": -2156376,
"heapUsedBytes": 77407324,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 31.999999999999993,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2872.4650000000056,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.709,
"layouts": 7,
"layoutDurationMs": 1.9380000000000004,
"taskDurationMs": 614.5780000000001,
"heapDeltaBytes": -7350460,
"heapUsedBytes": 85155476,
"domNodes": -238,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 181.379,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666279069767437,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2756.5420000000245,
"styleRecalcs": 27,
"styleRecalcDurationMs": 12.616999999999997,
"layouts": 7,
"layoutDurationMs": 1.9559999999999997,
"taskDurationMs": 598.722,
"heapDeltaBytes": -15846088,
"heapUsedBytes": 77437764,
"domNodes": -252,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 189.972,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666060606060608,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3227.316999999999,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.765,
"layouts": 3,
"layoutDurationMs": 0.6580000000000001,
"taskDurationMs": 867.9579999999999,
"heapDeltaBytes": 2521948,
"heapUsedBytes": 63591300,
"domNodes": -257,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 360.572,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6659793814433,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3289.244999999994,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8850000000000005,
"layouts": 8,
"layoutDurationMs": 2.1390000000000002,
"taskDurationMs": 942.727,
"heapDeltaBytes": -17330440,
"heapUsedBytes": 63967652,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 383.469,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.751530612244895,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 581.265999999971,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.663,
"layouts": 9,
"layoutDurationMs": 2.2990000000000004,
"taskDurationMs": 431.603,
"heapDeltaBytes": -1259068,
"heapUsedBytes": 61404160,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 146.019,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66285714285715,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 593.2760000000599,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.873,
"layouts": 10,
"layoutDurationMs": 2.653,
"taskDurationMs": 439.94500000000005,
"heapDeltaBytes": 3455484,
"heapUsedBytes": 76353344,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 145.65,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.918999999987,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4069999999999996,
"layouts": 9,
"layoutDurationMs": 2.2680000000000002,
"taskDurationMs": 508.756,
"heapDeltaBytes": 2146868,
"heapUsedBytes": 63834068,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 7.8679999999999986,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2038.7479999999414,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4229999999999996,
"layouts": 9,
"layoutDurationMs": 2.4450000000000003,
"taskDurationMs": 544.248,
"heapDeltaBytes": 929184,
"heapUsedBytes": 75178616,
"domNodes": -183,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 7.569000000000001,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1700.6230000000073,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.011999999999999,
"layouts": 8,
"layoutDurationMs": 1.85,
"taskDurationMs": 830.226,
"heapDeltaBytes": 20273860,
"heapUsedBytes": 83263772,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 106.72000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.7280000000274,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.708,
"layouts": 9,
"layoutDurationMs": 2.5229999999999997,
"taskDurationMs": 805.2320000000001,
"heapDeltaBytes": 17866740,
"heapUsedBytes": 80949316,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 107.36800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1451.9189999999753,
"styleRecalcs": 20,
"styleRecalcDurationMs": 22.687000000000005,
"layouts": 5,
"layoutDurationMs": 14.254000000000003,
"taskDurationMs": 1033.167,
"heapDeltaBytes": 11653128,
"heapUsedBytes": 114517504,
"domNodes": 16030,
"jsHeapTotalBytes": 6164480,
"scriptDurationMs": 32.660999999999994,
"eventListeners": 3246,
"totalBlockingTimeMs": 168,
"frameDurationMs": 19.555999999999997,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9511.291999999969,
"styleRecalcs": 249,
"styleRecalcDurationMs": 27.734,
"layouts": 7,
"layoutDurationMs": 1.9560000000000002,
"taskDurationMs": 6074.401,
"heapDeltaBytes": 12296404,
"heapUsedBytes": 88609824,
"domNodes": -257,
"jsHeapTotalBytes": 5300224,
"scriptDurationMs": 2823.2599999999998,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.695263157894736,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8841.619000000037,
"styleRecalcs": 250,
"styleRecalcDurationMs": 27.578,
"layouts": 8,
"layoutDurationMs": 2.19,
"taskDurationMs": 5872.691,
"heapDeltaBytes": 4111008,
"heapUsedBytes": 82012536,
"domNodes": -257,
"jsHeapTotalBytes": 5332992,
"scriptDurationMs": 2689.8979999999997,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23939.486999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23095.068000000003,
"heapDeltaBytes": -7215540,
"heapUsedBytes": 272249396,
"domNodes": -3343,
"jsHeapTotalBytes": 10211328,
"scriptDurationMs": 334.003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.748797250859106,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-idle",
"durationMs": 23119.144000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22315.32,
"heapDeltaBytes": -8415292,
"heapUsedBytes": 283630460,
"domNodes": -3343,
"jsHeapTotalBytes": 9166848,
"scriptDurationMs": 298.80600000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.75731497418244,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 28058.761000000006,
"styleRecalcs": 180,
"styleRecalcDurationMs": 18.636000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27751.933999999997,
"heapDeltaBytes": -24896352,
"heapUsedBytes": 251808696,
"domNodes": -3343,
"jsHeapTotalBytes": 9691136,
"scriptDurationMs": 927.108,
"eventListeners": -651,
"totalBlockingTimeMs": 56,
"frameDurationMs": 54.39050387596899,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 27980.759000000035,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.011,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27583.48,
"heapDeltaBytes": -31388280,
"heapUsedBytes": 270927944,
"domNodes": -3343,
"jsHeapTotalBytes": 13094912,
"scriptDurationMs": 892.7130000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 8,
"frameDurationMs": 52.67075471698113,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8020.3559999999925,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.81100000000001,
"layouts": 20,
"layoutDurationMs": 21.222000000000005,
"taskDurationMs": 7857.852999999999,
"heapDeltaBytes": 1061412,
"heapUsedBytes": 248384272,
"domNodes": -3343,
"jsHeapTotalBytes": 14155776,
"scriptDurationMs": 122.368,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.804918032786894,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 8253.655999999977,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.31099999999999,
"layouts": 20,
"layoutDurationMs": 33.754000000000005,
"taskDurationMs": 8086.647000000001,
"heapDeltaBytes": 1873516,
"heapUsedBytes": 278835592,
"domNodes": -3343,
"jsHeapTotalBytes": 15458304,
"scriptDurationMs": 154.979,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.83532608695651,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11449.62399999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11150.260000000002,
"heapDeltaBytes": 13379148,
"heapUsedBytes": 285068148,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 155.576,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.15376712328768,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11413.083000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11146.203,
"heapDeltaBytes": 3476280,
"heapUsedBytes": 262471912,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 148.35500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.3399293286219,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 150.89100000000144,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.256000000000002,
"layouts": 10,
"layoutDurationMs": 4.547,
"taskDurationMs": 110.30199999999998,
"heapDeltaBytes": 4978068,
"heapUsedBytes": 73901896,
"domNodes": 132,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.059000000000001,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.677777777777766,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 123.9500000000362,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.616,
"layouts": 10,
"layoutDurationMs": 3.4290000000000003,
"taskDurationMs": 84.208,
"heapDeltaBytes": 4645988,
"heapUsedBytes": 75189552,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.163,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142844,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 455.3399999999783,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.937,
"layouts": 76,
"layoutDurationMs": 15.233,
"taskDurationMs": 420.528,
"heapDeltaBytes": -4653612,
"heapUsedBytes": 39651024,
"domNodes": 4,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 202.64,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285717,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 432.08500000002914,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.615,
"layouts": 76,
"layoutDurationMs": 14.172,
"taskDurationMs": 391.795,
"heapDeltaBytes": -4838756,
"heapUsedBytes": 39772932,
"domNodes": 4,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 185.192,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661538461538456,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 524.7850000000653,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.5,
"layouts": 76,
"layoutDurationMs": 14.046,
"taskDurationMs": 495.061,
"heapDeltaBytes": 1435760,
"heapUsedBytes": 98659392,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 204.923,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999994,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 617.1450000000505,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.517,
"layouts": 76,
"layoutDurationMs": 17.013,
"taskDurationMs": 560.175,
"heapDeltaBytes": 1299740,
"heapUsedBytes": 103661828,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 230.824,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.127777777777787,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage: 🟡 59.8% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3134 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 072c3c1140172bbc8ff25cbdd1644cea3ec2f16c
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (280)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.59 #22813 +/- ##
=============================================
Coverage ? 87.29%
=============================================
Files ? 3067
Lines ? 160692
Branches ? 42950
=============================================
Hits ? 140271
Misses ? 19741
Partials ? 680
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Backport review at 3dda9c5: same as the core/1.59 carrier. Exact-head checks all green, target-branch merge guard passed, no unresolved threads. Merging under the program's release-backport grant.
…) with its CNV06 fix (#22792) (#22865) Backport of workflow chat-follow (#21791 + #21512) to `core/1.58`, **together with the FRONT-3804 fix (#22792)** for the regression chat-follow introduced (agent edits to a background tab only appeared after a reload, frontend 1.60 QA check CNV06). Shipping one without the other would put that regression on the stable line, so this PR carries the whole chain. Decision (2026-11-05): take option 2 from the earlier draft, the full stack, because ComfyUI now pins 1.58.5, so `core/1.58` is the line Core and Desktop users get, and the release owner asked for the backport. The stack turned out smaller than estimated: #21686 is not needed (see below). ## Why `core/1.58` and not the lines the original ask named The ask was "backport chat-follow to 1.58/1.59 so cloud and desktop users get it". Measured against branch ancestry and the live distribution surfaces on 2026-11-03: | Surface | What serves it | Chat-follow (#21791 + #21512) | |---|---|---| | Cloud production | `cloud/1.59` (`frontend-version.json` `releaseBranch`, rotated 2026-10-31); serves commit `072c3c1140` | **already present**, but that commit predates the CNV06 fix (#22813) | | Cloud testcloud | `cloud/1.60` (`testcloudBranch`, rotated 2026-11-03) | **already present** | | Core / Desktop pin | `core/1.58`: `ComfyUI` master pins `comfyui-frontend-package==1.58.5` since Comfy-Org/ComfyUI#17442 merged 2026-11-04 | absent before this PR | | `core/1.59`, `core/1.60` | tagged `v1.59.0` / `v1.60.0` on GitHub; PyPI has only `.dev` builds of these lines, and ComfyUI does not pin them | already present | So **cloud users already have chat-follow**; the gap is Core/Desktop only. `core/1.58` is the line chosen here because it is the newest stable package line and the one the open `ComfyUI` pin bump targets. Retired lines were excluded on the release owner's own stated grounds: `thedatalife` closed #21922/#21923 with "the 1.56 release line is finished and won't get another patch" and #21921 with "cloud.comfy.org now serves cloud/1.58, so cloud/1.57 won't be redeployed" — by the same rule `cloud/1.58` is now superseded by `cloud/1.59`. ## What is carried, in dependency order All four are `cherry-pick -x` from `main`, original authorship preserved. 1. **#20827** — `fix(agent): load every page of Chat history` (41 files, +1197/−434). Required: `core/1.58` forked from `main` on 2026-10-19 and lacks `useAgentChatHistoryRefresh`, `agentThreadList` and the paged `/api/agent/threads?*` client that #21512 modifies. Three conflicts, all incidental: two spec files took the landed `core/1.59` content for the files whose only 1.58→1.59 delta is this PR, and one import union in `agentRestClient.test.ts` aligned to the `@/workbench/...` form 1.59 uses. 2. **#21147** — `fix(agent-crdt): bind the session to the workflow a reload restored (FE-1969)` (9 files, +688/−36). Required: #21512 calls `onWorkflowRestoredAndBound`, and `hasUnsyncedHumanOps` is the guard the follow bind reuses. One conflict, a declaration-order union in `useAgentWorkflowSelection.ts` resolved to the order `core/1.59` landed. 3. **#21791** — `refactor(workflow): report user-initiated tab activations` (17 files, +473/−84, byte-identical stat to `main`). One conflict: `openWorkflow`'s options object, where 1.58 has `keepSavedBaseline` and this PR adds `initiator`. Both kept. 4. **#21512** — `feat(agent): carry workflow chat follow onto current main` (49 files). Seven conflicts; each resolution is stated below. ### #21512 conflict resolutions - `agentConversationStore.ts` (5) — 1.58 carries the snapshot-turn work (`unreconciledSnapshotTurns`, `snapshotTurnSettled`, `publishSnapshotMessage`) that `main` has since renamed. Declarations and the exported surface are unions in `core/1.59`'s order; `replacedSlot` is adopted alongside `unreconciledSnapshotTurns.clear()`; and the transport publish callback **keeps 1.58's `publishSnapshotMessage`**, which does `replaceActive` *plus* announcing a reconcilable snapshot turn, rather than narrowing to `publishMessage`. - `useAgentSession.ts` (1) — took #21512's `openThread`/`outlivedItsNavigation` rewrite with `boundWorkflowId.value = null; rememberedWorkflowId = null` replaced by 1.58's `forgetBinding()` helper (from #22518/#22697). The result is byte-identical to `core/1.59`'s `loadThread`. - `AgentPanelRoot.vue` (2) — import superset, and the `custom-title` fallback through `historyGroups.current`. - `RunNoticeBanner.vue` (2) — **narrow adaptation.** Added the `followFailed` context and the `liveness`/`contextAction` computeds, but **not** `genericNoticeReady` or the `visible` computed: those belong to a different PR that is not on this train, and 1.58's template already gates on `context || !dismissed`. Nothing chat-follow needs is dropped. - `AgentPanel.ts` fixture (2) — added only `historyButton`; `loadFailedMessage`/`loadRetryButton` appeared in the conflict as context from a PR not on this train and are unused here, so they are not introduced. `userMessageBubbles` **was** added (same reason, but the carried specs do use it). - `agentConversationFixture.ts` (1) — took the canvas-relative `canvasOps.click`; `comfyPage.canvas` and `comfyPage.canvasOps` both exist on this train. - `AgentPanelRoot.tabActivity.test.ts` — **path adaptation only.** 1.58 predates the billing module move: `@/platform/billing/composables/useBillingCapabilities` → `@/platform/workspace/composables/useBillingCapabilities`, `@/platform/billing/composables/useBillingContext` → `@/composables/billing/useBillingContext`, `@/platform/billing/subscription/composables/useAccountPreconditionDialog` → `@/platform/cloud/subscription/composables/useAccountPreconditionDialog`. Same three modules `AgentPanelRoot.vue` already imports on this branch. - Seven assertions in `AgentPanelRoot.test.ts` and `useAgentWorkflowSelection.test.ts` were updated to the behaviour the carried commits define, matching `core/1.59` exactly: four `expect(await restoration).toBe(true)` sites became `WorkflowRestoration`-shaped (#21147 changed that return type), and three chat-title tests now expect the server-assigned title (`'build a duck'`, `'my masterpiece'`) rather than `agent.newChatTitle`, which is #21512's own PM-2098 change. These are #21512's and #21147's own test updates; they failed to apply because the surrounding file differs on this train. ### Added on 2026-11-05: the FRONT-3804 chain 5. **#21497** `test: pin agent wire identity across a /ws reconnect` (test harness only). One conflict in `agentFollowerHostSocket.ts`: took #21497's per-connection `sid` and doc comment; 1.58 already had the `comfyConnections` counter from its PM-2123 backport. 6. **#21964** `test(agent): prove a document reset keeps other workflows' mint cursors` (test harness only). Applied clean. 7. **#22596** `fix(agent-crdt): track unconfirmed bind targets as unsynced (FRONT-3581)`. Three conflicts, all from `retrySubscription` and the dynamic-combo test scenario, neither on this train: added only `noteUnboundLocalIntent` to the follower surface; kept 1.58's `workflowByUnsettledOpId` settle bookkeeping and renamed `workflowsWithLostOps` to `workflowsWithUnsyncedOps` as #22596 does; in `docOpMinter.test.ts` added only the `unboundLocalIntents` counter. The new tests do not use the dynamic-combo scenario, so **#21686 is not carried**. 8. **#22792** `fix(agent): bind the workflow a followed chat opens (FRONT-3804)`. One conflict (`retrySubscription` again, dropped). `AgentPanelRoot.vue`, `docOpMinter.ts`, the fixture and the new spec applied clean. 9. `test(agent): import the workflow schema from its core/1.58 path`: the new fixture imported `@comfyorg/graph-model/workflowSchema`, a package 1.58 predates; it now uses `@/platform/workflow/validation/schemas/workflowSchema` like the other 1.58 fixtures. 10. **Rebased 2026-11-05 onto `core/1.58` after #22943** (empty composer on New Chat / draft across refresh). Two conflicts, both resolved to `main`'s and `core/1.59`'s shape: `onNewChat` keeps `retireFollow()` first and then the `history_back` branch, and `agentComposerStore.test.ts` keeps both the "draft presence" and "draft persistence" blocks in `main`'s order. One follow-up commit drops a duplicate `hasDraft` key in the composer store's returned object (both PRs added it; `main` has one). ## Verification - Before the rebase, at `928aaa2bc7`: `pnpm typecheck` and `pnpm typecheck:browser` pass (Node 26). - Vitest, 701 tests in 7 files, all pass: `AgentPanelRoot`, `docOpMinter`, `unsyncedHumanOps`, `followerProductGate`, `crossWorkflowPending`, `agentFollowerHostSocket`, `useAgentWorkflowChatFollow`. - The earlier four commits' 1945-test focused run (27 files) passed at `c10dbfe073`, before the chain was added. - Black-box: `browser_tests/tests/agent/agentBackgroundTabEditsLand.spec.ts` (CNV06 step 5) plus the chat-follow specs `agentTabActivationFollowsChat` and `agentTabChatTransitions` run in this PR's `@cloud` e2e shards. On `main` the CNV06 spec was red at the regressing commit 1a6324c and green with #22792 (see #22792). ## Delivery - **Core / Desktop:** the 1.58.6 release PR (#22908) is open on `core/1.58`. This PR merges first so 1.58.6 carries it; Core and Desktop get it when ComfyUI's pin moves to 1.58.6. - **Cloud:** chat-follow is already on `cloud/1.59` and `cloud/1.60`. The CNV06 fix is merged on both (#22813, #22806) but cloud production still serves `072c3c1140`, which predates it. The open production canary (Comfy-Org/cloud#17917) starts from a `cloud/1.59` tip that includes #22813. Testcloud builds `cloud/1.60` on every push, so it already carries #22806. Known limit, unchanged by this PR: an edit made by hand while a tab is not bound keeps that tab's follow bind refused until a reload plus a turn (the #22596 marker lifecycle). The owner decision is recorded on #22792; the in-session recovery design is #22801. --------- Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com> Co-authored-by: christian-byrne <chrbyrne96@gmail.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: mrseek-reviews[bot] <337131926+mrseek-reviews[bot]@users.noreply.github.com>
Backport of #22792 to
cloud/1.59. Fixes FRONT-3804: agent edits to a workflow whose tab is in the background did not appear until a reload.cloud/1.59contains the regressing commit 1a6324c (feat(agent): carry workflow chat follow onto current main #21512). With only the follow bind reverted, the new spec fails on this branch the same way it failed onmain.agentBackgroundTabEditsLand,agentFollowerRestoredBindingReloadandagentHumanEditAfterOtherWorkflowResetpass 6/6 on this head locally (--project=cloud).Full context for agent readers
Commits, in order (all
cherry-pick -xfrommainexcept the last):AgentFollowerHostSocket.addWorkflowand per-workflowsubscribeCount, which fix(agent): bind the workflow a followed chat opens (FRONT-3804) #22792's fixture calls. Its own spec proves fix(agent): keep op sender stamps and displaced admissions #19871, which is already on this train, and it passes here.onUnboundLocalIntent/noteUnboundLocalIntentwiring. Carrying only the bind would reopen the hole reviewed on fix(agent): bind the workflow a followed chat opens (FRONT-3804) #22792: a follow binding over a visible-tab edit the document never saw.useAgentCrdtFollower.ts. 1.59 still tracks lost ops withworkflowByUnsettledOpId+workflowsWithLostOps(the shape before fix(agent): stamp a held human edit above what it has received (PM-2118) #22410, which is not on 1.59). Resolved by keeping the train's structure and renaming onlyworkflowsWithLostOpstoworkflowsWithUnsyncedOps, which is the rename fix(agent-crdt): track unconfirmed bind targets as unsynced (FRONT-3581) #22596 makes.backgroundTabEdits.tsimportsComfyWorkflowJSONfrom@/platform/workflow/validation/schemas/workflowSchema, because 1.59 predates the@comfyorg/graph-modelpackage (refactor: extract graph model types into a leaf package #22053).Other notes:
cloud/1.59bot comment flagged a possible stacking conflict on [backport cloud/1.59] ci: merge backports only when approved at the current head #22608. [backport cloud/1.59] ci: merge backports only when approved at the current head #22608 only touches.github/workflows/backport-auto-merge.yamland its test, so it is unrelated. The real cause was the missing fix(agent-crdt): track unconfirmed bind targets as unsynced (FRONT-3581) #22596.browser_tests/hunk from all three sources is carried. None is dropped.typecheckandtypecheck:browserpass. Vitest ondocOpMinter,AgentPanelRoot,followerProductGate,unsyncedHumanOpsanduseAgentCrdtFollowerpasses 864/864.Justification: Agent release backport of merged #22792 on a current train, merged by the program under its standing release-backport grant (program/release-backport-authority.md). Reviewed diff and conflict resolution against the source; all exact-head checks green; no unresolved threads. GitHub does not accept an author approval, so no approval record exists.