Repository navigation
[backport cloud/1.58] fix(agent): keep a restored finished turn's Worked label (FRONT-3803) - #22808
Conversation
…#22791) After a reload or reopening a chat from history, every finished Agent turn read "Changes not confirmed on your canvas", although the same turn read "Worked" live and its edits are on the canvas. Restored turns now read "Worked" again, as on 1.59.0.dev2. Fixes [FRONT-3803](https://linear.app/comfyorg/issue/FRONT-3803). <details><summary>Full context for agent readers</summary> **Cause.** #20741 (`08b4792346`, the only canvas-claim change between 1.59.0.dev2 `864bfc939e` and 1.60.0.dev1 `9b73bee0a5`) made `parseToolCallEntry` in `agentTranscript.ts` set `canvasConfirmed: false` on every successful canvas-mutating call read from a stored row. A stored row carries no browser observation, so after a reload nothing could ever confirm those calls. `preserveCanvasConfirmation` upgraded them back only for calls the same page session had confirmed live, which is why in-session turns kept "Worked" until the reload. #20741 flipped `agentToolCallHistoryPersistence.spec.ts` to expect the unconfirmed label; this PR flips it back. **Fix.** - `agentTranscript.ts`: a stored row makes no canvas claim (no `canvasConfirmed`). - `agentConversationStore.ts`: when a turn settles in the session that ran it, the verdict its live calls reached carries onto the stored row, **true or false** (previously true only, because stored rows defaulted to false). Applied on both settle paths: the socket reconcile (`reconcileSettledTurn`) and the recovery read (`settleTurn`). Without the second one, a live denial settled by the recovery read would now drop to "Worked". This is the canvas half of [FRONT-3757](https://linear.app/comfyorg/issue/FRONT-3757); its tab-link half is unchanged. - A call still waiting for canvas catch-up when its turn settles is stored as not confirmed, which is the same verdict the transport's flush records. A verdict moves onto a stored tool only when the tool names match (review round 1). - Live behaviour from #20741 is unchanged: unobserved, timed-out or unavailable-canvas writes still read "not confirmed" live and after settle in that session. Only a restored row, which never had an observation, stops claiming one. No reconcile pass, no new store writes; this is display state on the message parts only (KEEP-ALIVE #14 untouched). **Backport.** #20741 is on `core/1.60`, `cloud/1.60`, `core/1.59`, `cloud/1.59` natively and was backported to `core/1.58` (#22062) and `cloud/1.58` (#21966). The frontend pin decision needs `core/1.60`; labels are set for all six lines. </details> - Black-box: `browser_tests/tests/agent/agentToolCallHistoryPersistence.spec.ts` (reload, then reopen from history) restored to expect "Worked" with no unconfirmed marker. **Red on parent `a8c2ace17f`** (summary reads "Changes not confirmed on your canvas"), **green on this branch** (rerun at `2d96033bfc`). - Related canvas-claim specs, `--project=cloud`, local backend: `agentCanvasClaimNeedsObservation`, `agentCanvasLagsToolCallCompletion`, `agentRefusedDocSubscribe`, `agentGraphOpLostOnDisconnect`, `agentSchemaSkewTellsTheUser`, `agentZeroNodesOnUnreadableSchema`, `agentToolCallHistoryPersistence`: 15/15 pass. - Unit: store cases cover the live verdict (confirmed, denied, still pending) through both settle paths, plus a name-mismatch guard; each fails without the change that it covers. Agent suites: 194 files, 4914 pass. `pnpm typecheck`, `typecheck:browser`, oxlint, eslint, oxfmt pass via hooks. (cherry picked from commit 5ecce1c)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 9 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-03T12:34:04.262Z",
"gitSha": "aca8ccac351f5fcffecf23a3f61f3244021dc36a",
"branch": "backport-22791-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2054.5569999999884,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.0469999999999997,
"layouts": 10,
"layoutDurationMs": 3.0370000000000004,
"taskDurationMs": 461.82800000000003,
"heapDeltaBytes": 2200236,
"heapUsedBytes": 90054172,
"domNodes": -200,
"jsHeapTotalBytes": -3080192,
"scriptDurationMs": 11.206000000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2017.2340000000304,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.666,
"layouts": 8,
"layoutDurationMs": 2.297,
"taskDurationMs": 593.487,
"heapDeltaBytes": -486952,
"heapUsedBytes": 90538292,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 11.684,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1808.6880000000178,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.721,
"layouts": 10,
"layoutDurationMs": 2.8840000000000003,
"taskDurationMs": 834.672,
"heapDeltaBytes": 1669016,
"heapUsedBytes": 90031828,
"domNodes": -200,
"jsHeapTotalBytes": -2031616,
"scriptDurationMs": 159.964,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.820370370370373,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1807.7160000000276,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.527000000000001,
"layouts": 9,
"layoutDurationMs": 2.405,
"taskDurationMs": 875.775,
"heapDeltaBytes": 5719544,
"heapUsedBytes": 93652964,
"domNodes": -180,
"jsHeapTotalBytes": -2293760,
"scriptDurationMs": 162.362,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.82037037037037,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.924000000021,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.4719999999999995,
"layouts": 12,
"layoutDurationMs": 3.1989999999999994,
"taskDurationMs": 333.547,
"heapDeltaBytes": 21465976,
"heapUsedBytes": 108935184,
"domNodes": 47,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 16.112000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.1160000000045,
"styleRecalcs": 20,
"styleRecalcDurationMs": 5.535,
"layouts": 11,
"layoutDurationMs": 3.608,
"taskDurationMs": 444.88000000000005,
"heapDeltaBytes": 21623524,
"heapUsedBytes": 109054368,
"domNodes": 47,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 13.575000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 660.2740000000153,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.047,
"layouts": 9,
"layoutDurationMs": 2.6039999999999996,
"taskDurationMs": 461.7540000000001,
"heapDeltaBytes": 753732,
"heapUsedBytes": 88206116,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 167.519,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230754,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 682.2929999999587,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.5479999999999996,
"layouts": 10,
"layoutDurationMs": 3.3280000000000003,
"taskDurationMs": 473.06899999999996,
"heapDeltaBytes": 265232,
"heapUsedBytes": 87745616,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 171.126,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1198.1019999999774,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 846.087,
"heapDeltaBytes": -14068568,
"heapUsedBytes": 102158092,
"domNodes": -210,
"jsHeapTotalBytes": 16588800,
"scriptDurationMs": 60.88100000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 506,
"frameDurationMs": 32.42972972972974,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1256.8840000000137,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 975.489,
"heapDeltaBytes": -17262424,
"heapUsedBytes": 102620364,
"domNodes": -230,
"jsHeapTotalBytes": 17190912,
"scriptDurationMs": 64.92699999999999,
"eventListeners": -168,
"totalBlockingTimeMs": 559,
"frameDurationMs": 33.78108108108107,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 826.2280000000146,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.05999999999995,
"heapDeltaBytes": -4437020,
"heapUsedBytes": 97166936,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 148.12399999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 194,
"frameDurationMs": 24.50882352941177,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 813.9979999999696,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.7069999999997,
"heapDeltaBytes": -3995080,
"heapUsedBytes": 97888828,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 134.839,
"eventListeners": 0,
"totalBlockingTimeMs": 183,
"frameDurationMs": 24.020588235294138,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9958.248999999994,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.33199999999999985,
"layouts": 1,
"layoutDurationMs": 0.23700000000000024,
"taskDurationMs": 9021.530999999999,
"heapDeltaBytes": 43538680,
"heapUsedBytes": 146561368,
"domNodes": -276,
"jsHeapTotalBytes": 29687808,
"scriptDurationMs": 6901.259000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 411,
"frameDurationMs": 29.34985250737463,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8939.926999999954,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.059000000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8080.229000000001,
"heapDeltaBytes": 24325144,
"heapUsedBytes": 127508776,
"domNodes": -276,
"jsHeapTotalBytes": 27590656,
"scriptDurationMs": 6501.83,
"eventListeners": -130,
"totalBlockingTimeMs": 217,
"frameDurationMs": 29.524503311258275,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8792.341999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8035.609000000001,
"heapDeltaBytes": 27076508,
"heapUsedBytes": 147968948,
"domNodes": -296,
"jsHeapTotalBytes": 28377088,
"scriptDurationMs": 6451.2789999999995,
"eventListeners": -130,
"totalBlockingTimeMs": 214,
"frameDurationMs": 29.772881355932203,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9831.913999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9035.335,
"heapDeltaBytes": 34680672,
"heapUsedBytes": 137714300,
"domNodes": -276,
"jsHeapTotalBytes": 33435648,
"scriptDurationMs": 7014.6759999999995,
"eventListeners": -130,
"totalBlockingTimeMs": 291,
"frameDurationMs": 29.264880952380953,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 237.57100000000264,
"styleRecalcs": 26,
"styleRecalcDurationMs": 14.319,
"layouts": 12,
"layoutDurationMs": 3.4059999999999997,
"taskDurationMs": 176.41500000000002,
"heapDeltaBytes": 13253108,
"heapUsedBytes": 117959620,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.813,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.218181818181787,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-combo-open",
"durationMs": 232.98900000003187,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.607,
"layouts": 12,
"layoutDurationMs": 3.908,
"taskDurationMs": 175.86900000000003,
"heapDeltaBytes": 13242540,
"heapUsedBytes": 116018748,
"domNodes": 917,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.157,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.33000000000002,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-graph-idle",
"durationMs": 2054.3989999999894,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6169999999999995,
"layouts": 8,
"layoutDurationMs": 2.739,
"taskDurationMs": 686.683,
"heapDeltaBytes": 238896,
"heapUsedBytes": 101671708,
"domNodes": -276,
"jsHeapTotalBytes": -1507328,
"scriptDurationMs": 32.239999999999995,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2057.4530000000095,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.306,
"layouts": 7,
"layoutDurationMs": 2.607,
"taskDurationMs": 726.9510000000001,
"heapDeltaBytes": 889652,
"heapUsedBytes": 108929624,
"domNodes": -296,
"jsHeapTotalBytes": -1662976,
"scriptDurationMs": 32.919,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2280.5329999999913,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.731000000000002,
"layouts": 7,
"layoutDurationMs": 1.8109999999999997,
"taskDurationMs": 1543.797,
"heapDeltaBytes": 1085024,
"heapUsedBytes": 103960956,
"domNodes": -296,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 825.3569999999999,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.788235294117644,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2380.516000000057,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.762,
"layouts": 8,
"layoutDurationMs": 2.302,
"taskDurationMs": 1653.64,
"heapDeltaBytes": 1726824,
"heapUsedBytes": 104332192,
"domNodes": -296,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 840.596,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78380281690141,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3722.712999999999,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.38,
"layouts": 64,
"layoutDurationMs": 10.801,
"taskDurationMs": 1826.749,
"heapDeltaBytes": 7111368,
"heapUsedBytes": 111497476,
"domNodes": 24,
"jsHeapTotalBytes": 5246976,
"scriptDurationMs": 774.695,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.741255605381166,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3803.4430000000157,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.363000000000001,
"layouts": 63,
"layoutDurationMs": 11.207,
"taskDurationMs": 1919.1009999999999,
"heapDeltaBytes": 1015900,
"heapUsedBytes": 105139972,
"domNodes": -272,
"jsHeapTotalBytes": -327680,
"scriptDurationMs": 806.606,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666228070175443,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3103.7259999999947,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.057999999999999,
"layouts": 5,
"layoutDurationMs": 1.6450000000000002,
"taskDurationMs": 1863.2559999999999,
"heapDeltaBytes": 20302784,
"heapUsedBytes": 130631280,
"domNodes": 0,
"jsHeapTotalBytes": 8024064,
"scriptDurationMs": 964.5939999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.936216216216216,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3173.3560000000125,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.618999999999999,
"layouts": 5,
"layoutDurationMs": 1.6940000000000002,
"taskDurationMs": 1911.3259999999998,
"heapDeltaBytes": -15460456,
"heapUsedBytes": 94391728,
"domNodes": 0,
"jsHeapTotalBytes": 1507328,
"scriptDurationMs": 1023.607,
"eventListeners": 182,
"totalBlockingTimeMs": 38,
"frameDurationMs": 17.022459893048133,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2047.9250000000206,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.9430000000000003,
"layouts": 6,
"layoutDurationMs": 1.8460000000000005,
"taskDurationMs": 684.117,
"heapDeltaBytes": 355536,
"heapUsedBytes": 102886312,
"domNodes": -296,
"jsHeapTotalBytes": -2031616,
"scriptDurationMs": 33.522999999999996,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2048.5270000000355,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.059,
"layouts": 7,
"layoutDurationMs": 1.9189999999999996,
"taskDurationMs": 546.9730000000001,
"heapDeltaBytes": 561876,
"heapUsedBytes": 103981676,
"domNodes": -296,
"jsHeapTotalBytes": -1245184,
"scriptDurationMs": 35.08,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 773.5190000000216,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.364,
"layouts": 10,
"layoutDurationMs": 3.191,
"taskDurationMs": 513.693,
"heapDeltaBytes": 22889840,
"heapUsedBytes": 114608204,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 160.409,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 641.7740000000549,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.114,
"layouts": 11,
"layoutDurationMs": 3.0219999999999994,
"taskDurationMs": 439.9460000000001,
"heapDeltaBytes": 22561480,
"heapUsedBytes": 112542332,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 157.05,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668421052631583,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2023.2849999999871,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.061999999999999,
"layouts": 9,
"layoutDurationMs": 3.236,
"taskDurationMs": 458.66200000000003,
"heapDeltaBytes": 357624,
"heapUsedBytes": 90552556,
"domNodes": -228,
"jsHeapTotalBytes": -2031616,
"scriptDurationMs": 10.016999999999998,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2038.4880000000294,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.431000000000001,
"layouts": 9,
"layoutDurationMs": 2.654,
"taskDurationMs": 680.48,
"heapDeltaBytes": -7670148,
"heapUsedBytes": 83275768,
"domNodes": -198,
"jsHeapTotalBytes": -2215936,
"scriptDurationMs": 12.562,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1727.2839999999974,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.894,
"layouts": 8,
"layoutDurationMs": 2.117,
"taskDurationMs": 918.774,
"heapDeltaBytes": -4358500,
"heapUsedBytes": 85913480,
"domNodes": -210,
"jsHeapTotalBytes": -1769472,
"scriptDurationMs": 101.98899999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846145,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1743.6999999999898,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.313,
"layouts": 10,
"layoutDurationMs": 2.9289999999999994,
"taskDurationMs": 846.366,
"heapDeltaBytes": 2991016,
"heapUsedBytes": 93061676,
"domNodes": -190,
"jsHeapTotalBytes": -2293760,
"scriptDurationMs": 115.598,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 999.8659999999973,
"styleRecalcs": 20,
"styleRecalcDurationMs": 22.709,
"layouts": 5,
"layoutDurationMs": 14.357000000000001,
"taskDurationMs": 785.0120000000003,
"heapDeltaBytes": 35543272,
"heapUsedBytes": 135159636,
"domNodes": 16030,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 29.326000000000004,
"eventListeners": 3244,
"totalBlockingTimeMs": 154,
"frameDurationMs": 21.27659574468085,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "viewport-pan-sweep",
"durationMs": 8385.509000000013,
"styleRecalcs": 249,
"styleRecalcDurationMs": 29.338,
"layouts": 6,
"layoutDurationMs": 1.5139999999999998,
"taskDurationMs": 5371.876,
"heapDeltaBytes": -882384,
"heapUsedBytes": 105160416,
"domNodes": -297,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 2690.938,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7328,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8443.934000000012,
"styleRecalcs": 249,
"styleRecalcDurationMs": 30.149999999999995,
"layouts": 7,
"layoutDurationMs": 1.8719999999999994,
"taskDurationMs": 5496.081,
"heapDeltaBytes": 2548480,
"heapUsedBytes": 104175760,
"domNodes": -296,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 2723.088,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73188118811881,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 20344.85799999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19759.213000000003,
"heapDeltaBytes": -53961400,
"heapUsedBytes": 276653952,
"domNodes": -3344,
"jsHeapTotalBytes": 10211328,
"scriptDurationMs": 286.52700000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.76781193490054,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 20448.15200000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19946.127999999997,
"heapDeltaBytes": -50858472,
"heapUsedBytes": 273325652,
"domNodes": -3344,
"jsHeapTotalBytes": -7876608,
"scriptDurationMs": 323.78000000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.86888888888889,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 16867.124999999985,
"styleRecalcs": 107,
"styleRecalcDurationMs": 14.109999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16504.956,
"heapDeltaBytes": -6480556,
"heapUsedBytes": 304322184,
"domNodes": -3344,
"jsHeapTotalBytes": 8306688,
"scriptDurationMs": 875.772,
"eventListeners": -651,
"totalBlockingTimeMs": 121,
"frameDurationMs": 30.777554744525546,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 25440.157,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.209000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 25180.746,
"heapDeltaBytes": -17608772,
"heapUsedBytes": 293815868,
"domNodes": -3344,
"jsHeapTotalBytes": 7065600,
"scriptDurationMs": 859.137,
"eventListeners": -651,
"totalBlockingTimeMs": 3,
"frameDurationMs": 49.19206963249516,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 5046.562999999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.413,
"layouts": 20,
"layoutDurationMs": 23.466,
"taskDurationMs": 4929.074,
"heapDeltaBytes": -68995064,
"heapUsedBytes": 260451564,
"domNodes": -3344,
"jsHeapTotalBytes": 5230592,
"scriptDurationMs": 89.62299999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.05833333333333,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-node-resize-workload",
"durationMs": 7570.690000000013,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.67899999999998,
"layouts": 20,
"layoutDurationMs": 23.581000000000003,
"taskDurationMs": 7484.627,
"heapDeltaBytes": -5613620,
"heapUsedBytes": 295232936,
"domNodes": -3344,
"jsHeapTotalBytes": 7852032,
"scriptDurationMs": 115.02,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.24795321637427,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6960.1060000000525,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6424.956999999999,
"heapDeltaBytes": 43804,
"heapUsedBytes": 268351056,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 103.95300000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.4438596491228,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10443.24400000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10222.115999999998,
"heapDeltaBytes": 9261800,
"heapUsedBytes": 295739668,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 143.78999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.12775800711743,
"p95FrameDurationMs": 83.20000000000073
},
{
"name": "workflow-execution",
"durationMs": 142.62999999999693,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.052,
"layouts": 10,
"layoutDurationMs": 4.083,
"taskDurationMs": 102.79599999999998,
"heapDeltaBytes": 4819972,
"heapUsedBytes": 93539288,
"domNodes": 97,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.301,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.674999999999955,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 128.54200000003857,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.978,
"layouts": 9,
"layoutDurationMs": 3.4120000000000004,
"taskDurationMs": 90.09699999999998,
"heapDeltaBytes": 4681276,
"heapUsedBytes": 96640860,
"domNodes": 117,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 8.23,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142908,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 485.18300000000636,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.661,
"layouts": 76,
"layoutDurationMs": 16.102,
"taskDurationMs": 441.44399999999996,
"heapDeltaBytes": -13672692,
"heapUsedBytes": 81959200,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 202.711,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 395.80499999999574,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.657,
"layouts": 76,
"layoutDurationMs": 15.475,
"taskDurationMs": 359.713,
"heapDeltaBytes": -15912604,
"heapUsedBytes": 78328944,
"domNodes": 4,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 160.829,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663999999999977,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 637.012000000027,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.085,
"layouts": 76,
"layoutDurationMs": 17.961000000000002,
"taskDurationMs": 593.7620000000001,
"heapDeltaBytes": 1316372,
"heapUsedBytes": 112911620,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 240.351,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.10263157894736,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 645.0159999999414,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.003,
"layouts": 76,
"layoutDurationMs": 17.124,
"taskDurationMs": 613.622,
"heapDeltaBytes": 1868244,
"heapUsedBytes": 119218308,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 247.68599999999998,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage: 🟡 63.6% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2997 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 48ae12c82ffd57336d988c5ed6f0f945939e59f0
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (146)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.58 #22808 +/- ##
=============================================
Coverage ? 84.29%
=============================================
Files ? 3172
Lines ? 165794
Branches ? 41653
=============================================
Hits ? 139759
Misses ? 25644
Partials ? 391
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Backport review at 0b523ce: same resolution as the core/1.58 carrier. Exact-head checks all green, target-branch merge guard passed, no unresolved threads. Merging under the program's release-backport grant.
Backport of #22791 to
cloud/1.58. Fixes FRONT-3803: a restored finished Agent turn reads "Worked" again instead of "Changes not confirmed on your canvas".Hand-resolved; the automatic backport conflicted.
Full context for agent readers
Applies here.
cloud/1.58carries #20741's stored-rowcanvasConfirmed: falseinagentTranscript.ts(the defect) and both settle paths (reconcileSettledTurnviafinishSnapshotTurn,settleTurnviafinishWithPersistedParts).Conflict and resolution. Only
agentConversationStore.tsconflicted, infinishWithPersistedParts: onmainthe fix wrapspreserveLiveToolStartTimes(...), which is a separate tool-timing feature not on 1.58. Resolved by applyingpreserveCanvasVerdicts(message.parts, persistedParts)directly, without carrying that feature. The import ofToolPartkeeps this train's relative../../services/agent/agentMessagePartspath. All other files applied cleanly. Source commit provenance kept viacherry picked from.Verification on this train (local).
agentConversationStore.test.ts+agentTranscript.test.ts: all pass with the fix; 6 fail with only the two source files reverted (the new settle-path verdict cases, the transcript stored-row case, and the late-retire case).pnpm typecheckpasses.browser_tests/tests/agent/agentToolCallHistoryPersistence.spec.tscarried; left to hosted CI.Justification: Agent release backport of merged #22791 on a current train, merged by the program under its standing release-backport grant (program/release-backport-authority.md). Reviewed diff and conflict resolution against the source; all exact-head checks green; no unresolved threads. GitHub does not accept an author approval, so no approval record exists.