Repository navigation
[backport cloud/1.60] fix(agent): keep a restored finished turn's Worked label (FRONT-3803) - #22804
Conversation
…#22791) ## Summary After a reload or reopening a chat from history, every finished Agent turn read "Changes not confirmed on your canvas", although the same turn read "Worked" live and its edits are on the canvas. Restored turns now read "Worked" again, as on 1.59.0.dev2. Fixes [FRONT-3803](https://linear.app/comfyorg/issue/FRONT-3803). <details><summary>Full context for agent readers</summary> **Cause.** #20741 (`08b4792346`, the only canvas-claim change between 1.59.0.dev2 `864bfc939e` and 1.60.0.dev1 `9b73bee0a5`) made `parseToolCallEntry` in `agentTranscript.ts` set `canvasConfirmed: false` on every successful canvas-mutating call read from a stored row. A stored row carries no browser observation, so after a reload nothing could ever confirm those calls. `preserveCanvasConfirmation` upgraded them back only for calls the same page session had confirmed live, which is why in-session turns kept "Worked" until the reload. #20741 flipped `agentToolCallHistoryPersistence.spec.ts` to expect the unconfirmed label; this PR flips it back. **Fix.** - `agentTranscript.ts`: a stored row makes no canvas claim (no `canvasConfirmed`). - `agentConversationStore.ts`: when a turn settles in the session that ran it, the verdict its live calls reached carries onto the stored row, **true or false** (previously true only, because stored rows defaulted to false). Applied on both settle paths: the socket reconcile (`reconcileSettledTurn`) and the recovery read (`settleTurn`). Without the second one, a live denial settled by the recovery read would now drop to "Worked". This is the canvas half of [FRONT-3757](https://linear.app/comfyorg/issue/FRONT-3757); its tab-link half is unchanged. - A call still waiting for canvas catch-up when its turn settles is stored as not confirmed, which is the same verdict the transport's flush records. A verdict moves onto a stored tool only when the tool names match (review round 1). - Live behaviour from #20741 is unchanged: unobserved, timed-out or unavailable-canvas writes still read "not confirmed" live and after settle in that session. Only a restored row, which never had an observation, stops claiming one. No reconcile pass, no new store writes; this is display state on the message parts only (KEEP-ALIVE #14 untouched). **Backport.** #20741 is on `core/1.60`, `cloud/1.60`, `core/1.59`, `cloud/1.59` natively and was backported to `core/1.58` (#22062) and `cloud/1.58` (#21966). The frontend pin decision needs `core/1.60`; labels are set for all six lines. </details> ## Verification - Black-box: `browser_tests/tests/agent/agentToolCallHistoryPersistence.spec.ts` (reload, then reopen from history) restored to expect "Worked" with no unconfirmed marker. **Red on parent `a8c2ace17f`** (summary reads "Changes not confirmed on your canvas"), **green on this branch** (rerun at `2d96033bfc`). - Related canvas-claim specs, `--project=cloud`, local backend: `agentCanvasClaimNeedsObservation`, `agentCanvasLagsToolCallCompletion`, `agentRefusedDocSubscribe`, `agentGraphOpLostOnDisconnect`, `agentSchemaSkewTellsTheUser`, `agentZeroNodesOnUnreadableSchema`, `agentToolCallHistoryPersistence`: 15/15 pass. - Unit: store cases cover the live verdict (confirmed, denied, still pending) through both settle paths, plus a name-mismatch guard; each fails without the change that it covers. Agent suites: 194 files, 4914 pass. `pnpm typecheck`, `typecheck:browser`, oxlint, eslint, oxfmt pass via hooks.
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-03T12:21:17.257Z",
"gitSha": "17df33de71ebc1246e7caea69c085db582c86300",
"branch": "backport-22791-to-cloud-1.60",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.540000000049,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.0859999999999994,
"layouts": 9,
"layoutDurationMs": 3.069,
"taskDurationMs": 554.4370000000001,
"heapDeltaBytes": -11261940,
"heapUsedBytes": 60808476,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 8.686,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2038.6940000000777,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.136,
"layouts": 10,
"layoutDurationMs": 3.139,
"taskDurationMs": 583.62,
"heapDeltaBytes": 2921388,
"heapUsedBytes": 75831968,
"domNodes": -178,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 8.792000000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1837.6459999999497,
"styleRecalcs": 78,
"styleRecalcDurationMs": 12.379000000000001,
"layouts": 8,
"layoutDurationMs": 1.8919999999999997,
"taskDurationMs": 917.3820000000001,
"heapDeltaBytes": 2364444,
"heapUsedBytes": 64191992,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 172.228,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666363636363638,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1906.4200000000255,
"styleRecalcs": 80,
"styleRecalcDurationMs": 13.463000000000001,
"layouts": 10,
"layoutDurationMs": 2.863,
"taskDurationMs": 957.8319999999999,
"heapDeltaBytes": -9901184,
"heapUsedBytes": 63336180,
"domNodes": -178,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 167.406,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66578947368421,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1701.7210000000205,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.560999999999999,
"layouts": 11,
"layoutDurationMs": 2.9659999999999997,
"taskDurationMs": 424.33599999999996,
"heapDeltaBytes": 25383268,
"heapUsedBytes": 85183668,
"domNodes": 57,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 10.356,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.9489999999423,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.846,
"layouts": 11,
"layoutDurationMs": 2.4949999999999997,
"taskDurationMs": 420.498,
"heapDeltaBytes": 7743952,
"heapUsedBytes": 83646488,
"domNodes": 57,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 10.179999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 709.3610000000012,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.7159999999999997,
"layouts": 8,
"layoutDurationMs": 2.5559999999999996,
"taskDurationMs": 512.894,
"heapDeltaBytes": 4086256,
"heapUsedBytes": 65727572,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 173.11200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666657,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 741.3209999999708,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.0930000000000004,
"layouts": 10,
"layoutDurationMs": 2.7410000000000005,
"taskDurationMs": 536.867,
"heapDeltaBytes": -10851792,
"heapUsedBytes": 62087968,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 176.53599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909086,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1242.2010000000228,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 938.256,
"heapDeltaBytes": -5646568,
"heapUsedBytes": 78336016,
"domNodes": -208,
"jsHeapTotalBytes": 14950400,
"scriptDurationMs": 64.07099999999998,
"eventListeners": -107,
"totalBlockingTimeMs": 556,
"frameDurationMs": 33.33243243243243,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1195.2039999999897,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 901.3870000000001,
"heapDeltaBytes": -7197004,
"heapUsedBytes": 76792616,
"domNodes": -208,
"jsHeapTotalBytes": 17309696,
"scriptDurationMs": 65.26,
"eventListeners": -107,
"totalBlockingTimeMs": 522,
"frameDurationMs": 32.43243243243242,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 877.6149999999916,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.6579999999999,
"heapDeltaBytes": -4397184,
"heapUsedBytes": 86622728,
"domNodes": 0,
"jsHeapTotalBytes": 3674112,
"scriptDurationMs": 175.14599999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 241,
"frameDurationMs": 25.237142857142864,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 876.6799999999648,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 561.2789999999999,
"heapDeltaBytes": -24134068,
"heapUsedBytes": 67434044,
"domNodes": -208,
"jsHeapTotalBytes": 3276800,
"scriptDurationMs": 164.80999999999995,
"eventListeners": -107,
"totalBlockingTimeMs": 225,
"frameDurationMs": 24.538888888888906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11414.145999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10493.170000000002,
"heapDeltaBytes": 75196520,
"heapUsedBytes": 149344008,
"domNodes": -274,
"jsHeapTotalBytes": 80080896,
"scriptDurationMs": 8336.677,
"eventListeners": -69,
"totalBlockingTimeMs": 1263,
"frameDurationMs": 31.577562326869806,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10702.908999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9899.987,
"heapDeltaBytes": 51443324,
"heapUsedBytes": 145292524,
"domNodes": -274,
"jsHeapTotalBytes": 68022272,
"scriptDurationMs": 7897.3949999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 1049,
"frameDurationMs": 31.377126099706746,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11742.002999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10989.133,
"heapDeltaBytes": -2034972,
"heapUsedBytes": 73052788,
"domNodes": -274,
"jsHeapTotalBytes": 20836352,
"scriptDurationMs": 8841.300000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 1349,
"frameDurationMs": 32.144657534246576,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10477.55200000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9763.479,
"heapDeltaBytes": 81174220,
"heapUsedBytes": 157544248,
"domNodes": -274,
"jsHeapTotalBytes": 69332992,
"scriptDurationMs": 7845.7699999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 1062,
"frameDurationMs": 30.874041297935108,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 217.0240000000092,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.858,
"layouts": 8,
"layoutDurationMs": 2.1550000000000007,
"taskDurationMs": 162.45200000000006,
"heapDeltaBytes": 14914052,
"heapUsedBytes": 74860372,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.705999999999998,
"eventListeners": 205,
"totalBlockingTimeMs": 5,
"frameDurationMs": 24.066666666666656,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 230.40800000001127,
"styleRecalcs": 22,
"styleRecalcDurationMs": 13.661,
"layouts": 8,
"layoutDurationMs": 2.915,
"taskDurationMs": 181.84099999999998,
"heapDeltaBytes": 14916332,
"heapUsedBytes": 76099448,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.848999999999998,
"eventListeners": 205,
"totalBlockingTimeMs": 5,
"frameDurationMs": 25.922222222222192,
"p95FrameDurationMs": 99.90000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2054.5099999999934,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.333000000000001,
"layouts": 8,
"layoutDurationMs": 2.162,
"taskDurationMs": 680.621,
"heapDeltaBytes": -28613752,
"heapUsedBytes": 61574608,
"domNodes": -274,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 35.10799999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2057.3360000000775,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.522,
"layouts": 8,
"layoutDurationMs": 2.166,
"taskDurationMs": 657.7950000000001,
"heapDeltaBytes": 7398164,
"heapUsedBytes": 82288176,
"domNodes": -274,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 31.505,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2710.887000000014,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.484,
"layouts": 7,
"layoutDurationMs": 1.688,
"taskDurationMs": 1831.9769999999996,
"heapDeltaBytes": -19981908,
"heapUsedBytes": 74993724,
"domNodes": -274,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 911.665,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.768944099378878,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2707.1599999999307,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.292999999999997,
"layouts": 8,
"layoutDurationMs": 1.7290000000000005,
"taskDurationMs": 1749.579,
"heapDeltaBytes": -22102516,
"heapUsedBytes": 61941888,
"domNodes": -274,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 844.511,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666257668711655,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3840.8339999999725,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.792,
"layouts": 62,
"layoutDurationMs": 9.783,
"taskDurationMs": 1862.606,
"heapDeltaBytes": 7670804,
"heapUsedBytes": 84700400,
"domNodes": -250,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 816.774,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66580086580087,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3944.2850000000362,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.314,
"layouts": 64,
"layoutDurationMs": 10.364999999999998,
"taskDurationMs": 1912.0250000000003,
"heapDeltaBytes": -13081068,
"heapUsedBytes": 63680072,
"domNodes": -250,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 835.535,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66582278481013,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3194.22000000003,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.986,
"layouts": 5,
"layoutDurationMs": 1.353,
"taskDurationMs": 2090.7299999999996,
"heapDeltaBytes": -15259400,
"heapUsedBytes": 72350056,
"domNodes": 0,
"jsHeapTotalBytes": 6643712,
"scriptDurationMs": 1042.146,
"eventListeners": 182,
"totalBlockingTimeMs": 32,
"frameDurationMs": 17.020744680851063,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3339.8049999999557,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.305,
"layouts": 5,
"layoutDurationMs": 1.3179999999999996,
"taskDurationMs": 2180.379,
"heapDeltaBytes": -32652476,
"heapUsedBytes": 61782676,
"domNodes": -274,
"jsHeapTotalBytes": 6193152,
"scriptDurationMs": 1072.206,
"eventListeners": -58,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3073.081000000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.129,
"layouts": 8,
"layoutDurationMs": 1.933,
"taskDurationMs": 813.3530000000001,
"heapDeltaBytes": -9630924,
"heapUsedBytes": 75012840,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 376.04699999999997,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666304347826088,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3081.809000000021,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.6240000000000006,
"layouts": 6,
"layoutDurationMs": 1.6249999999999998,
"taskDurationMs": 809.8159999999999,
"heapDeltaBytes": -8929364,
"heapUsedBytes": 75591788,
"domNodes": -274,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 378.17699999999996,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66540540540541,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2045.4689999999687,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.2320000000000007,
"layouts": 7,
"layoutDurationMs": 2.0880000000000005,
"taskDurationMs": 709.542,
"heapDeltaBytes": 6685988,
"heapUsedBytes": 82202144,
"domNodes": -274,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 37.33,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2060.227999999938,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.409,
"layouts": 8,
"layoutDurationMs": 2.091,
"taskDurationMs": 680.0489999999999,
"heapDeltaBytes": -17243876,
"heapUsedBytes": 66907120,
"domNodes": -274,
"jsHeapTotalBytes": -397312,
"scriptDurationMs": 39.462,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66532258064516,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2997.434999999996,
"styleRecalcs": 27,
"styleRecalcDurationMs": 12.412999999999998,
"layouts": 7,
"layoutDurationMs": 1.4909999999999999,
"taskDurationMs": 598.3289999999998,
"heapDeltaBytes": -18340584,
"heapUsedBytes": 73738952,
"domNodes": 19,
"jsHeapTotalBytes": 4493312,
"scriptDurationMs": 194.98100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666111111111114,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2850.2879999999777,
"styleRecalcs": 25,
"styleRecalcDurationMs": 11.508999999999999,
"layouts": 6,
"layoutDurationMs": 1.4600000000000004,
"taskDurationMs": 574.5260000000001,
"heapDeltaBytes": 8545472,
"heapUsedBytes": 92270756,
"domNodes": 19,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 194.112,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66608187134503,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3250.175000000013,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5469999999999997,
"layouts": 9,
"layoutDurationMs": 2.608,
"taskDurationMs": 983.5870000000001,
"heapDeltaBytes": -19507140,
"heapUsedBytes": 64307420,
"domNodes": -274,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 371.128,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666153846153843,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3381.7559999999958,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9919999999999998,
"layouts": 7,
"layoutDurationMs": 1.9729999999999994,
"taskDurationMs": 1032.943,
"heapDeltaBytes": 5053608,
"heapUsedBytes": 81376060,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 403.115,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66600985221675,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 622.7850000000217,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.688999999999999,
"layouts": 8,
"layoutDurationMs": 2.2270000000000003,
"taskDurationMs": 452.45000000000005,
"heapDeltaBytes": 990872,
"heapUsedBytes": 63785820,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 150.38500000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662162162162176,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 614.0320000000656,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.541,
"layouts": 8,
"layoutDurationMs": 2.2740000000000005,
"taskDurationMs": 448.05000000000007,
"heapDeltaBytes": 23817296,
"heapUsedBytes": 85824496,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 150.23899999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66216216216216,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2041.059999999959,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3080000000000003,
"layouts": 8,
"layoutDurationMs": 1.894,
"taskDurationMs": 575.977,
"heapDeltaBytes": -4344080,
"heapUsedBytes": 57064672,
"domNodes": -200,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 7.689999999999999,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2024.4159999999738,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9900000000000007,
"layouts": 10,
"layoutDurationMs": 2.7950000000000004,
"taskDurationMs": 580.3360000000001,
"heapDeltaBytes": 4933368,
"heapUsedBytes": 68935904,
"domNodes": -200,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 7.3439999999999985,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.8400000000424,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.127000000000002,
"layouts": 9,
"layoutDurationMs": 2.5489999999999995,
"taskDurationMs": 792.373,
"heapDeltaBytes": -11505940,
"heapUsedBytes": 63544288,
"domNodes": -200,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 120.364,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1757.4349999999868,
"styleRecalcs": 79,
"styleRecalcDurationMs": 13.682,
"layouts": 9,
"layoutDurationMs": 2.1550000000000002,
"taskDurationMs": 907.5810000000001,
"heapDeltaBytes": -18874784,
"heapUsedBytes": 52378168,
"domNodes": -200,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 109.805,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1620.8969999999567,
"styleRecalcs": 18,
"styleRecalcDurationMs": 26.500999999999998,
"layouts": 5,
"layoutDurationMs": 19.563999999999997,
"taskDurationMs": 1358.676,
"heapDeltaBytes": 10279628,
"heapUsedBytes": 89896836,
"domNodes": -1320,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 33.086000000000006,
"eventListeners": -262,
"totalBlockingTimeMs": 221,
"frameDurationMs": 20.673417721518984,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10206.565000000011,
"styleRecalcs": 251,
"styleRecalcDurationMs": 28.320999999999998,
"layouts": 9,
"layoutDurationMs": 2.039,
"taskDurationMs": 6295.101,
"heapDeltaBytes": -13204856,
"heapUsedBytes": 61247804,
"domNodes": -274,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 2883.9359999999997,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.748275862068965,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9957.221000000005,
"styleRecalcs": 250,
"styleRecalcDurationMs": 28.008000000000003,
"layouts": 8,
"layoutDurationMs": 1.9919999999999998,
"taskDurationMs": 6212.195000000001,
"heapDeltaBytes": -17660692,
"heapUsedBytes": 63702584,
"domNodes": -274,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 2841.595,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665829145728644,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 24443.33899999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23625.88,
"heapDeltaBytes": -32049328,
"heapUsedBytes": 278186448,
"domNodes": -3482,
"jsHeapTotalBytes": 10731520,
"scriptDurationMs": 340.069,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.090476190476195,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 24830.438999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24036.528000000002,
"heapDeltaBytes": -20046876,
"heapUsedBytes": 263200512,
"domNodes": -3482,
"jsHeapTotalBytes": 7847936,
"scriptDurationMs": 331.75499999999994,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.413111888111885,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 29363.999999999975,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.577000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 29097.456000000002,
"heapDeltaBytes": -49579764,
"heapUsedBytes": 253936760,
"domNodes": -3482,
"jsHeapTotalBytes": 9162752,
"scriptDurationMs": 901.773,
"eventListeners": -659,
"totalBlockingTimeMs": 6,
"frameDurationMs": 54.786380597014926,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 29368.05000000004,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.60199999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 29068.211,
"heapDeltaBytes": -25646568,
"heapUsedBytes": 258946860,
"domNodes": -3482,
"jsHeapTotalBytes": 15187968,
"scriptDurationMs": 908.201,
"eventListeners": -659,
"totalBlockingTimeMs": 53,
"frameDurationMs": 54.786380597014926,
"p95FrameDurationMs": 116.60000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8692.88499999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.031,
"layouts": 20,
"layoutDurationMs": 22.451,
"taskDurationMs": 8614.947,
"heapDeltaBytes": -6116828,
"heapUsedBytes": 283946264,
"domNodes": -3482,
"jsHeapTotalBytes": 17809408,
"scriptDurationMs": 132.08599999999998,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 49.712,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8732.534999999985,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.973,
"layouts": 20,
"layoutDurationMs": 23.520000000000014,
"taskDurationMs": 8590.757,
"heapDeltaBytes": -46707292,
"heapUsedBytes": 257776372,
"domNodes": -3482,
"jsHeapTotalBytes": 19648512,
"scriptDurationMs": 155.042,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 50.77325581395349,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12502.354000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12102.756,
"heapDeltaBytes": -11154928,
"heapUsedBytes": 260798404,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 166.29300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.28840579710145,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12347.903999999971,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12036.951,
"heapDeltaBytes": -28839080,
"heapUsedBytes": 260184628,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 179.24200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.14846416382254,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 139.19199999998,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.505,
"layouts": 10,
"layoutDurationMs": 4.326999999999999,
"taskDurationMs": 104.15599999999999,
"heapDeltaBytes": 5016540,
"heapUsedBytes": 71843532,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.75,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999966,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 458.02500000002055,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.418999999999999,
"layouts": 10,
"layoutDurationMs": 4.745,
"taskDurationMs": 113.17499999999998,
"heapDeltaBytes": 7133608,
"heapUsedBytes": 68686808,
"domNodes": 99,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.642,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285715,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 546.8980000000556,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.67,
"layouts": 76,
"layoutDurationMs": 15.174,
"taskDurationMs": 497.67599999999993,
"heapDeltaBytes": -3205720,
"heapUsedBytes": 42371996,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 245.73999999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 480.6780000000117,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6759999999999999,
"layouts": 76,
"layoutDurationMs": 14.078,
"taskDurationMs": 431.695,
"heapDeltaBytes": -1129184,
"heapUsedBytes": 46232664,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 206.175,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 569.5630000000165,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.951,
"layouts": 76,
"layoutDurationMs": 15.129,
"taskDurationMs": 532.215,
"heapDeltaBytes": 938232,
"heapUsedBytes": 103203368,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 215.791,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.152941176470584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 618.6860000000252,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.075,
"layouts": 76,
"layoutDurationMs": 15.378,
"taskDurationMs": 584.615,
"heapDeltaBytes": 1420420,
"heapUsedBytes": 103741296,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 236.417,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567588,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage: 🟡 59.3% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3216 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 7552848966adfbaf7b3de74778512eef4b7801f4
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (352)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.60 #22804 +/- ##
=============================================
Coverage ? 87.49%
=============================================
Files ? 2883
Lines ? 159190
Branches ? 42633
=============================================
Hits ? 139276
Misses ? 19149
Partials ? 765
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Backport review at a13360a: clean cherry-pick, diff identical to the source. Exact-head checks all green, target-branch merge guard passed, no unresolved threads. Merging under the program's release-backport grant.
Backport of #22791 to
cloud/1.60Automatically created by backport workflow.
Justification: Agent release backport of merged #22791 on a current train, merged by the program under its standing release-backport grant (program/release-backport-authority.md). Reviewed diff and conflict resolution against the source; all exact-head checks green; no unresolved threads. GitHub does not accept an author approval, so no approval record exists.