Repository navigation
[backport cloud/1.57] fix: keep a late image preview load off another workflow's node - #22790
Conversation
- Late preview load leaked onto other workflow's same-id node - Fix: Vue `ImagePreview` skips `syncLegacyNodeImgs` after unmount - Classic canvas not affected; e2e covers both modes <details><summary>Full context for agent readers</summary> ## Bug 1.57 release QA: a Load Image preview from one workflow tab showed up on the node with the same id in another workflow after that workflow was closed and reopened. ## Root cause The Vue-nodes `ImagePreview` copies its loaded `<img>` onto the legacy `node.imgs` via `nodeOutputStore.syncLegacyNodeImgs(nodeId, …)`, which resolves the node **by id** against the current graph. An `<img>` keeps loading after its component unmounts, so when the workflow was swapped out mid-load, the id resolved against the newly loaded workflow. ## Fix `ImagePreview.vue` sets a flag in `onBeforeUnmount` and skips the sync once unmounted. ## Classic (LiteGraph) path: not affected - `syncLegacyNodeImgs` returns early unless `LiteGraph.vueNodesMode`, and `ImagePreview.vue` is not mounted in classic mode. - Classic previews go through `useNodeImage` / `useNodePreview` (`src/composables/node/useNodeImage.ts`). The load closure captures the `LGraphNode` **object** that requested it and writes `node.imgs = elements` on that object. There is no id lookup, so a late load lands on the discarded graph's node, never on the new graph's node with the same id. - Verified: the e2e has a canvas-mode variant (no `@vue-nodes` tag) that holds A's `example.png` request, opens B (same node id) from the Workflows sidebar, releases the load, and waits until the load callbacks have run before asserting. It passes on this branch, and it also passes with the Vue fix reverted (where the Vue variant fails with `imgs: 1` on B's node). ## Red → green - e2e `browser_tests/tests/workflow/imagePreviewWorkflowScope.spec.ts` (Vue + canvas variants; load-handled spy in `browser_tests/fixtures/utils/imageLoadSpy.ts`): 4/4 with `--repeat-each=2`. With the guard reverted: Vue variant fails (`Received … "imgs": 1`), canvas variant passes. - e2e speed: A loads from the existing `widgets/load_image_widget.json` asset and B (same node id 10) from `nodes/lora_loader_model_only_id_10.json` via `setupWorkflowsDirectory` in `beforeEach`, instead of building, saving, closing and reopening B in the UI. Test body ~4.5s → ~1s; per-test wall time on a shared host 12–15s → 9–12s. Remaining time is the `comfyPage` fixture boot, not the spec, so no `test.slow()`. - unit `ImagePreview.test.ts`: "ignores an image that finishes loading after unmount" fails without the fix; 38/38 pass. - `pnpm typecheck:browser`, oxlint, lint-staged and pre-push hooks: clean. Run locally against the CI container backend (0.0.27) and a Vite dev server. </details>
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-03T09:39:12.110Z",
"gitSha": "83ee6feb28d21cd08ff99634c09afd8ede63127a",
"branch": "backport-21341-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.7149999999951,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6440000000000006,
"layouts": 9,
"layoutDurationMs": 2.686,
"taskDurationMs": 507.40200000000004,
"heapDeltaBytes": 22171400,
"heapUsedBytes": 87598280,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 10.116,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.2490000000016,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.1060000000000003,
"layouts": 10,
"layoutDurationMs": 2.986,
"taskDurationMs": 374.07800000000003,
"heapDeltaBytes": 22097760,
"heapUsedBytes": 87974412,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 10.571,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1806.2639999999988,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.181000000000001,
"layouts": 10,
"layoutDurationMs": 3.6069999999999998,
"taskDurationMs": 886.147,
"heapDeltaBytes": 15578840,
"heapUsedBytes": 81863588,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 169.027,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664814814814818,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.4009999999726,
"styleRecalcs": 74,
"styleRecalcDurationMs": 16.187,
"layouts": 10,
"layoutDurationMs": 3.0220000000000002,
"taskDurationMs": 752.1099999999999,
"heapDeltaBytes": 15573212,
"heapUsedBytes": 81448128,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 167.831,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.9240000000345,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.41,
"layouts": 12,
"layoutDurationMs": 3.459,
"taskDurationMs": 274.57699999999994,
"heapDeltaBytes": 18804924,
"heapUsedBytes": 84489700,
"domNodes": 47,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 11.322000000000003,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1787.661000000071,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.1000000000000005,
"layouts": 10,
"layoutDurationMs": 2.5130000000000003,
"taskDurationMs": 392.84799999999996,
"heapDeltaBytes": 18292128,
"heapUsedBytes": 84676664,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 11.192,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 653.7379999999757,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.661,
"layouts": 8,
"layoutDurationMs": 2.35,
"taskDurationMs": 493.16800000000006,
"heapDeltaBytes": 2830088,
"heapUsedBytes": 77541688,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 170.993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.107894736842116,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 609.2370000000074,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.405,
"layouts": 8,
"layoutDurationMs": 2.0309999999999997,
"taskDurationMs": 434.6139999999999,
"heapDeltaBytes": 25278340,
"heapUsedBytes": 91694628,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 169.711,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.142857142857157,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1241.408999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 923.7520000000001,
"heapDeltaBytes": 264680,
"heapUsedBytes": 81132888,
"domNodes": -192,
"jsHeapTotalBytes": 14163968,
"scriptDurationMs": 68.24300000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 548,
"frameDurationMs": 33.33243243243244,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1229.8230000000103,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 917.906,
"heapDeltaBytes": 696552,
"heapUsedBytes": 81313708,
"domNodes": -212,
"jsHeapTotalBytes": 14426112,
"scriptDurationMs": 75.516,
"eventListeners": -106,
"totalBlockingTimeMs": 546,
"frameDurationMs": 33.33243243243244,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.7859999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.09099999999984,
"heapDeltaBytes": -4628604,
"heapUsedBytes": 75374400,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 159.19699999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 217,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.5060000000713,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.35600000000005,
"heapDeltaBytes": -5484304,
"heapUsedBytes": 75474792,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 152.648,
"eventListeners": 0,
"totalBlockingTimeMs": 210,
"frameDurationMs": 24.50882352941177,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10305.11800000005,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.04700000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9373.224,
"heapDeltaBytes": -16293020,
"heapUsedBytes": 83518992,
"domNodes": -278,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 7939.972999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 1256,
"frameDurationMs": 32.69714285714286,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9608.49200000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8732.358,
"heapDeltaBytes": 5984092,
"heapUsedBytes": 82735044,
"domNodes": -258,
"jsHeapTotalBytes": 1437696,
"scriptDurationMs": 7334.6,
"eventListeners": -68,
"totalBlockingTimeMs": 833,
"frameDurationMs": 32.1056856187291,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10359.77399999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9577.524000000001,
"heapDeltaBytes": -22514376,
"heapUsedBytes": 71516956,
"domNodes": -258,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 7819.694,
"eventListeners": -68,
"totalBlockingTimeMs": 982,
"frameDurationMs": 31.604573170731705,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10615.534999999909,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.053000000000000096,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9836.554000000002,
"heapDeltaBytes": -11371620,
"heapUsedBytes": 85631952,
"domNodes": -258,
"jsHeapTotalBytes": 11399168,
"scriptDurationMs": 8026.245000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 1260,
"frameDurationMs": 31.408875739644966,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 240.68999999997231,
"styleRecalcs": 26,
"styleRecalcDurationMs": 14.934000000000001,
"layouts": 12,
"layoutDurationMs": 3.3880000000000003,
"taskDurationMs": 178.091,
"heapDeltaBytes": -8124632,
"heapUsedBytes": 79583180,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8.360999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.218181818181787,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-combo-open",
"durationMs": 233.0890000000636,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.639,
"layouts": 11,
"layoutDurationMs": 3.243,
"taskDurationMs": 176.017,
"heapDeltaBytes": -8189724,
"heapUsedBytes": 79672320,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 9.061,
"eventListeners": 196,
"totalBlockingTimeMs": 1,
"frameDurationMs": 23.329999999999927,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-graph-idle",
"durationMs": 2025.2920000000358,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5270000000000006,
"layouts": 8,
"layoutDurationMs": 3.0629999999999997,
"taskDurationMs": 632.9309999999999,
"heapDeltaBytes": -7487804,
"heapUsedBytes": 71816480,
"domNodes": -278,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 30.029,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2067.3530000000255,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.9270000000000007,
"layouts": 6,
"layoutDurationMs": 1.758,
"taskDurationMs": 722.815,
"heapDeltaBytes": -21051060,
"heapUsedBytes": 76082760,
"domNodes": -258,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 34.315,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66612903225806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2763.480999999956,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.662999999999999,
"layouts": 7,
"layoutDurationMs": 1.9740000000000004,
"taskDurationMs": 1752.803,
"heapDeltaBytes": -12659700,
"heapUsedBytes": 67509732,
"domNodes": -278,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 839.491,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.86951219512195,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2244.250999999963,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.379999999999999,
"layouts": 8,
"layoutDurationMs": 2.537,
"taskDurationMs": 1454.9380000000003,
"heapDeltaBytes": -11795728,
"heapUsedBytes": 67969680,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 800.1189999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665671641791043,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3606.8109999999933,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.554000000000001,
"layouts": 64,
"layoutDurationMs": 10.848999999999998,
"taskDurationMs": 1608.9030000000002,
"heapDeltaBytes": -14217340,
"heapUsedBytes": 67580312,
"domNodes": -254,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 782.3840000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.743720930232556,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3646.9299999999976,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.486,
"layouts": 64,
"layoutDurationMs": 10.549,
"taskDurationMs": 1733.5819999999997,
"heapDeltaBytes": -5869248,
"heapUsedBytes": 71803028,
"domNodes": -254,
"jsHeapTotalBytes": 389120,
"scriptDurationMs": 783.054,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871563,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2960.4780000000233,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.601,
"layouts": 5,
"layoutDurationMs": 1.085,
"taskDurationMs": 1913.731,
"heapDeltaBytes": 5345544,
"heapUsedBytes": 84110136,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 961.152,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.759887005649716,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3014.047000000005,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.521000000000001,
"layouts": 5,
"layoutDurationMs": 1.3280000000000003,
"taskDurationMs": 1935.6719999999998,
"heapDeltaBytes": 7053800,
"heapUsedBytes": 84724512,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 968.9349999999998,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.758659217877096,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2040.3880000000072,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.229,
"layouts": 8,
"layoutDurationMs": 2.62,
"taskDurationMs": 632.1210000000001,
"heapDeltaBytes": -23326224,
"heapUsedBytes": 75096472,
"domNodes": -258,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 31.470000000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2064.619999999991,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2909999999999995,
"layouts": 8,
"layoutDurationMs": 2.5919999999999996,
"taskDurationMs": 672.8890000000001,
"heapDeltaBytes": -27443968,
"heapUsedBytes": 71379416,
"domNodes": -278,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 33.091,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666935483870965,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 582.5339999999528,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.553,
"layouts": 8,
"layoutDurationMs": 2.2959999999999994,
"taskDurationMs": 423.61199999999997,
"heapDeltaBytes": 21623412,
"heapUsedBytes": 88475088,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 145.465,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66285714285715,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 560.2739999999358,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.872000000000001,
"layouts": 9,
"layoutDurationMs": 2.9330000000000007,
"taskDurationMs": 374.328,
"heapDeltaBytes": 20310708,
"heapUsedBytes": 87257540,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 147.286,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.9999999999582,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.0830000000000006,
"layouts": 10,
"layoutDurationMs": 2.837,
"taskDurationMs": 508.729,
"heapDeltaBytes": 22413748,
"heapUsedBytes": 89788156,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 9.259000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.708000000027,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.686000000000001,
"layouts": 8,
"layoutDurationMs": 2.4720000000000004,
"taskDurationMs": 359.77,
"heapDeltaBytes": 22405244,
"heapUsedBytes": 89915844,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 9.113,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1971.8279999999595,
"styleRecalcs": 87,
"styleRecalcDurationMs": 16.677999999999997,
"layouts": 9,
"layoutDurationMs": 3.037,
"taskDurationMs": 1032.09,
"heapDeltaBytes": 11318036,
"heapUsedBytes": 78279716,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 112.063,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.7640000000265,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.696999999999997,
"layouts": 9,
"layoutDurationMs": 2.101,
"taskDurationMs": 788.7169999999999,
"heapDeltaBytes": -6673392,
"heapUsedBytes": 70230020,
"domNodes": 0,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 110.03200000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262138,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1450.792999999976,
"styleRecalcs": 20,
"styleRecalcDurationMs": 27.602000000000007,
"layouts": 5,
"layoutDurationMs": 16.320999999999998,
"taskDurationMs": 1062.4609999999998,
"heapDeltaBytes": 4955520,
"heapUsedBytes": 100773476,
"domNodes": 15953,
"jsHeapTotalBytes": 18489344,
"scriptDurationMs": 28.779999999999994,
"eventListeners": 3244,
"totalBlockingTimeMs": 172,
"frameDurationMs": 19.554666666666673,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8276.231000000053,
"styleRecalcs": 248,
"styleRecalcDurationMs": 17.259000000000004,
"layouts": 6,
"layoutDurationMs": 1.628,
"taskDurationMs": 4992.592000000001,
"heapDeltaBytes": 709336,
"heapUsedBytes": 79402000,
"domNodes": -258,
"jsHeapTotalBytes": 3760128,
"scriptDurationMs": 2663.195,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.801014198782962,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9594.893999999953,
"styleRecalcs": 250,
"styleRecalcDurationMs": 19.201,
"layouts": 8,
"layoutDurationMs": 2.667,
"taskDurationMs": 6032.130999999999,
"heapDeltaBytes": -12244560,
"heapUsedBytes": 84379800,
"domNodes": -258,
"jsHeapTotalBytes": 5074944,
"scriptDurationMs": 2767.364,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.724258289703315,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23194.537999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22558.086,
"heapDeltaBytes": 5621552,
"heapUsedBytes": 287264268,
"domNodes": -3330,
"jsHeapTotalBytes": 8904704,
"scriptDurationMs": 350.36899999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.998275862068965,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 23202.78300000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22663.836000000003,
"heapDeltaBytes": 2488208,
"heapUsedBytes": 285382288,
"domNodes": -3330,
"jsHeapTotalBytes": 7331840,
"scriptDurationMs": 345.055,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.20641247833622,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 19366.231999999967,
"styleRecalcs": 160,
"styleRecalcDurationMs": 11.77599999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18866.078,
"heapDeltaBytes": 22535444,
"heapUsedBytes": 294787200,
"domNodes": -3330,
"jsHeapTotalBytes": 19841024,
"scriptDurationMs": 849.323,
"eventListeners": -651,
"totalBlockingTimeMs": 29,
"frameDurationMs": 35.533577981651376,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 19764.839999999935,
"styleRecalcs": 154,
"styleRecalcDurationMs": 13.149999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19239.043999999998,
"heapDeltaBytes": -34928716,
"heapUsedBytes": 261503056,
"domNodes": -3330,
"jsHeapTotalBytes": 15716352,
"scriptDurationMs": 842.527,
"eventListeners": -651,
"totalBlockingTimeMs": 25,
"frameDurationMs": 35.743037974683546,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5755.098000000089,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.255,
"layouts": 20,
"layoutDurationMs": 22.77800000000002,
"taskDurationMs": 5606.558000000001,
"heapDeltaBytes": -26405468,
"heapUsedBytes": 263489524,
"domNodes": -307,
"jsHeapTotalBytes": 24367104,
"scriptDurationMs": 95.58199999999998,
"eventListeners": -7,
"totalBlockingTimeMs": 14,
"frameDurationMs": 31.68351648351648,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-node-resize-workload",
"durationMs": 8258.498000000032,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.225,
"layouts": 20,
"layoutDurationMs": 33.785,
"taskDurationMs": 8114.457999999999,
"heapDeltaBytes": -32570372,
"heapUsedBytes": 269333452,
"domNodes": -3330,
"jsHeapTotalBytes": 18075648,
"scriptDurationMs": 148.976,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.68554913294797,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11420.505999999932,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11170.614000000001,
"heapDeltaBytes": -4565388,
"heapUsedBytes": 264929212,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.45599999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.502076124567466,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11527.338999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11215.406,
"heapDeltaBytes": 8685860,
"heapUsedBytes": 279003824,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 152.97799999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.70238907849829,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 494.2709999999124,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.376000000000001,
"layouts": 11,
"layoutDurationMs": 4.276000000000001,
"taskDurationMs": 153.28799999999998,
"heapDeltaBytes": 7117732,
"heapUsedBytes": 80214464,
"domNodes": 126,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 15.912000000000003,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 126.43400000001748,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.926000000000002,
"layouts": 8,
"layoutDurationMs": 4.1850000000000005,
"taskDurationMs": 98.39699999999999,
"heapDeltaBytes": -11042452,
"heapUsedBytes": 68980208,
"domNodes": 95,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 7.143,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142844,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 506.1309999999821,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.9470000000000001,
"layouts": 76,
"layoutDurationMs": 14.959999999999999,
"taskDurationMs": 455.853,
"heapDeltaBytes": 11914500,
"heapUsedBytes": 101476944,
"domNodes": 4,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 226.575,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483896,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 402.8000000000702,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.9470000000000001,
"layouts": 76,
"layoutDurationMs": 14.309000000000001,
"taskDurationMs": 357.85900000000004,
"heapDeltaBytes": 10499272,
"heapUsedBytes": 104105468,
"domNodes": 4,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 171.049,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664000000000016,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 510.50099999997656,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.8010000000000002,
"layouts": 76,
"layoutDurationMs": 14.305,
"taskDurationMs": 476.1389999999999,
"heapDeltaBytes": 606124,
"heapUsedBytes": 124505612,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 196.794,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903224,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 648.3799999999746,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.907,
"layouts": 76,
"layoutDurationMs": 15.449,
"taskDurationMs": 582.645,
"heapDeltaBytes": 495200,
"heapUsedBytes": 131960120,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 249.64000000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.107894736842116,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage: 🟡 64.5% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2288 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 97500dda17f52ebc8a58093f4068a6e6ca025ba3
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.57 #22790 +/- ##
=============================================
Coverage ? 83.70%
=============================================
Files ? 3077
Lines ? 162218
Branches ? 38420
=============================================
Hits ? 135791
Misses ? 26037
Partials ? 390
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #21341 to
cloud/1.57Automatically created by backport workflow.