Repository navigation
[backport cloud/1.60] offer only ready deployments for missing nodes (#22772) - #22775
Conversation
… nodes The issues card and the Issues panel offer the deployments that can run a workflow with missing nodes. They listed stopped, failed and starting deployments too, so Switch could reload the editor onto a deployment where jobs won't run. The Run on menu already refuses this. They now list only ready deployments. When only a deployment that isn't ready can run the workflow, the card stays as it was and the Run on menu's Start remains the way forward. (cherry picked from commit fe6394b)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-03T02:35:34.548Z",
"gitSha": "548d4912cdd8ea7a17a14dd1ab84f6e3b5672d89",
"branch": "bl/cloud-1.60-missing-node-offer-ready-only",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2037.8459999999734,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.999,
"layouts": 9,
"layoutDurationMs": 2.953,
"taskDurationMs": 616.41,
"heapDeltaBytes": -91624,
"heapUsedBytes": 62067492,
"domNodes": -178,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 11.565000000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2030.1749999999856,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6040000000000005,
"layouts": 8,
"layoutDurationMs": 2.332,
"taskDurationMs": 603.3720000000001,
"heapDeltaBytes": 9254212,
"heapUsedBytes": 69704944,
"domNodes": -178,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 10.708000000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1850.4450000000077,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.750999999999998,
"layouts": 8,
"layoutDurationMs": 2.1900000000000004,
"taskDurationMs": 908.836,
"heapDeltaBytes": 23740812,
"heapUsedBytes": 84376256,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 171.358,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665765765765762,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1801.2300000000323,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.104000000000001,
"layouts": 7,
"layoutDurationMs": 1.7759999999999998,
"taskDurationMs": 906.0820000000001,
"heapDeltaBytes": 23686544,
"heapUsedBytes": 83128800,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 169.81,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66574074074074,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.1929999999752,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.11,
"layouts": 10,
"layoutDurationMs": 3.005,
"taskDurationMs": 475.669,
"heapDeltaBytes": 3297724,
"heapUsedBytes": 65447760,
"domNodes": 57,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 13.666,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.7989999999954,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.128,
"layouts": 12,
"layoutDurationMs": 3.1670000000000003,
"taskDurationMs": 421.27,
"heapDeltaBytes": 11561560,
"heapUsedBytes": 84472120,
"domNodes": 57,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 11.317999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 733.5649999999987,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.032,
"layouts": 8,
"layoutDurationMs": 2.6769999999999996,
"taskDurationMs": 527.077,
"heapDeltaBytes": 649320,
"heapUsedBytes": 61025568,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 172.876,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66363636363636,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 720.2469999999721,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.156,
"layouts": 10,
"layoutDurationMs": 2.748,
"taskDurationMs": 506.12200000000007,
"heapDeltaBytes": 1054428,
"heapUsedBytes": 61352916,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 173.68,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1197.3059999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 908.637,
"heapDeltaBytes": -11789416,
"heapUsedBytes": 78309096,
"domNodes": -208,
"jsHeapTotalBytes": 21504000,
"scriptDurationMs": 69.288,
"eventListeners": -107,
"totalBlockingTimeMs": 517,
"frameDurationMs": 32.42972972972973,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1206.8160000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 921.0269999999999,
"heapDeltaBytes": -10262176,
"heapUsedBytes": 77925924,
"domNodes": -208,
"jsHeapTotalBytes": 19931136,
"scriptDurationMs": 67.324,
"eventListeners": -107,
"totalBlockingTimeMs": 518,
"frameDurationMs": 32.432432432432435,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 927.3000000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 605.3000000000002,
"heapDeltaBytes": -852556,
"heapUsedBytes": 89300736,
"domNodes": -208,
"jsHeapTotalBytes": 3014656,
"scriptDurationMs": 165.51,
"eventListeners": -107,
"totalBlockingTimeMs": 247,
"frameDurationMs": 25.22432432432433,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.1509999999871,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.37199999999956,
"heapDeltaBytes": -2244276,
"heapUsedBytes": 84730756,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 166.34099999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 25.00000000000003,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11695.285999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10830.178,
"heapDeltaBytes": 57533144,
"heapUsedBytes": 151722460,
"domNodes": -274,
"jsHeapTotalBytes": 87158784,
"scriptDurationMs": 8762.967000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 1505,
"frameDurationMs": 32.319337016574586,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10292.749000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9508.446,
"heapDeltaBytes": 39582768,
"heapUsedBytes": 134049120,
"domNodes": -274,
"jsHeapTotalBytes": 69595136,
"scriptDurationMs": 7535.53,
"eventListeners": -69,
"totalBlockingTimeMs": 788,
"frameDurationMs": 31.217220543806647,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10959.497999999996,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.04399999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10163.791,
"heapDeltaBytes": 79210516,
"heapUsedBytes": 156422448,
"domNodes": -274,
"jsHeapTotalBytes": 74313728,
"scriptDurationMs": 8170.178999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 1220,
"frameDurationMs": 31.373925501432666,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10178.354000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9407.671,
"heapDeltaBytes": 55866744,
"heapUsedBytes": 150107152,
"domNodes": -274,
"jsHeapTotalBytes": 73527296,
"scriptDurationMs": 7501.048,
"eventListeners": -69,
"totalBlockingTimeMs": 806,
"frameDurationMs": 31.140672782874617,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 266.4660000000083,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.807,
"layouts": 12,
"layoutDurationMs": 3.8229999999999995,
"taskDurationMs": 236.554,
"heapDeltaBytes": -7013676,
"heapUsedBytes": 68220116,
"domNodes": -2427,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 9.511,
"eventListeners": -582,
"totalBlockingTimeMs": 4,
"frameDurationMs": 24.23636363636367,
"p95FrameDurationMs": 99.90000000000009
},
{
"name": "large-combo-open",
"durationMs": 225.72900000000118,
"styleRecalcs": 21,
"styleRecalcDurationMs": 12.011,
"layouts": 8,
"layoutDurationMs": 2.3749999999999996,
"taskDurationMs": 161.99,
"heapDeltaBytes": 14921184,
"heapUsedBytes": 75397392,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.931000000000001,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.077777777777808,
"p95FrameDurationMs": 83.29999999999973
},
{
"name": "large-graph-idle",
"durationMs": 2056.3740000000053,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.574,
"layouts": 8,
"layoutDurationMs": 2.3640000000000008,
"taskDurationMs": 719.9550000000002,
"heapDeltaBytes": 6491576,
"heapUsedBytes": 80856524,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 36.618,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2056.9840000000568,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4939999999999998,
"layouts": 8,
"layoutDurationMs": 2.3630000000000004,
"taskDurationMs": 705.172,
"heapDeltaBytes": -18888364,
"heapUsedBytes": 62333144,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 33.92000000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2806.662000000017,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.913,
"layouts": 8,
"layoutDurationMs": 2.156,
"taskDurationMs": 1798.891,
"heapDeltaBytes": -30709292,
"heapUsedBytes": 64002144,
"domNodes": -274,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 856.921,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666272189349115,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2635.4769999999235,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.166,
"layouts": 7,
"layoutDurationMs": 1.8310000000000002,
"taskDurationMs": 1736.409,
"heapDeltaBytes": 3618512,
"heapUsedBytes": 79046444,
"domNodes": -274,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 839.4200000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665408805031444,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3972.029999999961,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.987,
"layouts": 65,
"layoutDurationMs": 10.89,
"taskDurationMs": 1886.289,
"heapDeltaBytes": -11098252,
"heapUsedBytes": 61619744,
"domNodes": -250,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 804.628,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665546218487393,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3891.3929999999937,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.985000000000001,
"layouts": 65,
"layoutDurationMs": 10.902000000000001,
"taskDurationMs": 1806.5430000000001,
"heapDeltaBytes": 12217032,
"heapUsedBytes": 96292344,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 797.519,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666239316239317,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3204.674999999952,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.361,
"layouts": 5,
"layoutDurationMs": 1.3760000000000001,
"taskDurationMs": 2148.2520000000004,
"heapDeltaBytes": -5815108,
"heapUsedBytes": 71509800,
"domNodes": 0,
"jsHeapTotalBytes": 7204864,
"scriptDurationMs": 1048.229,
"eventListeners": 182,
"totalBlockingTimeMs": 21,
"frameDurationMs": 16.9282722513089,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3197.8990000000067,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.333,
"layouts": 6,
"layoutDurationMs": 1.424,
"taskDurationMs": 2077.805,
"heapDeltaBytes": -15134428,
"heapUsedBytes": 70849024,
"domNodes": 0,
"jsHeapTotalBytes": 8253440,
"scriptDurationMs": 1021.7179999999998,
"eventListeners": 182,
"totalBlockingTimeMs": 19,
"frameDurationMs": 17.019047619047615,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3039.822999999984,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.6699999999999997,
"layouts": 7,
"layoutDurationMs": 1.687,
"taskDurationMs": 785.645,
"heapDeltaBytes": -16356272,
"heapUsedBytes": 68255836,
"domNodes": -274,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 354.40099999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665934065934064,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3118.069999999989,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.6340000000000001,
"layouts": 6,
"layoutDurationMs": 1.409,
"taskDurationMs": 804.349,
"heapDeltaBytes": -22016396,
"heapUsedBytes": 72271100,
"domNodes": 0,
"jsHeapTotalBytes": 5541888,
"scriptDurationMs": 387.956,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666310160427805,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2058.693000000005,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.269,
"layouts": 7,
"layoutDurationMs": 2.006,
"taskDurationMs": 768.8210000000001,
"heapDeltaBytes": -19220032,
"heapUsedBytes": 65431136,
"domNodes": -274,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 39.134,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2041.8409999999767,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.039999999999999,
"layouts": 7,
"layoutDurationMs": 2.068,
"taskDurationMs": 652.9990000000001,
"heapDeltaBytes": 6758976,
"heapUsedBytes": 82371104,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 33.022999999999996,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2839.9749999999813,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.889,
"layouts": 7,
"layoutDurationMs": 1.829,
"taskDurationMs": 592.639,
"heapDeltaBytes": -18340652,
"heapUsedBytes": 74034400,
"domNodes": 19,
"jsHeapTotalBytes": 5017600,
"scriptDurationMs": 209.13000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66647058823529,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2813.7629999999945,
"styleRecalcs": 25,
"styleRecalcDurationMs": 11.544000000000002,
"layouts": 6,
"layoutDurationMs": 1.4520000000000002,
"taskDurationMs": 604.238,
"heapDeltaBytes": -7432700,
"heapUsedBytes": 65368008,
"domNodes": -259,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 189.99699999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666272189349115,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3319.3490000000165,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9880000000000002,
"layouts": 4,
"layoutDurationMs": 1.0429999999999997,
"taskDurationMs": 971.648,
"heapDeltaBytes": 3116840,
"heapUsedBytes": 79366948,
"domNodes": -274,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 386.176,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.749999999999996,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3398.2500000000755,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.8409999999999997,
"layouts": 5,
"layoutDurationMs": 1.7280000000000004,
"taskDurationMs": 1102.312,
"heapDeltaBytes": -21262824,
"heapUsedBytes": 62516476,
"domNodes": -274,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 411.875,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74827586206897,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 604.1320000000496,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.17,
"layouts": 8,
"layoutDurationMs": 2.05,
"taskDurationMs": 442.50499999999994,
"heapDeltaBytes": 24772984,
"heapUsedBytes": 85805324,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 149.548,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 593.9449999999624,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.841999999999999,
"layouts": 8,
"layoutDurationMs": 2.4850000000000003,
"taskDurationMs": 445.05300000000005,
"heapDeltaBytes": 24844952,
"heapUsedBytes": 86441372,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 151.227,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66285714285714,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2071.754999999996,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.0620000000000003,
"layouts": 9,
"layoutDurationMs": 2.5759999999999996,
"taskDurationMs": 611.094,
"heapDeltaBytes": -4418976,
"heapUsedBytes": 67293328,
"domNodes": -200,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 9.547,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66612903225806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.568000000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.805,
"layouts": 8,
"layoutDurationMs": 2.424,
"taskDurationMs": 552.02,
"heapDeltaBytes": 4545848,
"heapUsedBytes": 67313644,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 8.929,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.6220000000203,
"styleRecalcs": 78,
"styleRecalcDurationMs": 16.311,
"layouts": 9,
"layoutDurationMs": 2.93,
"taskDurationMs": 958.802,
"heapDeltaBytes": 19622156,
"heapUsedBytes": 81107400,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 123.72899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1774.2409999999609,
"styleRecalcs": 78,
"styleRecalcDurationMs": 17.046000000000003,
"layouts": 9,
"layoutDurationMs": 3.372,
"taskDurationMs": 981.138,
"heapDeltaBytes": 11103312,
"heapUsedBytes": 72942764,
"domNodes": -200,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 121.78100000000002,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66509433962264,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1616.878999999983,
"styleRecalcs": 18,
"styleRecalcDurationMs": 26.997000000000007,
"layouts": 5,
"layoutDurationMs": 19.761999999999997,
"taskDurationMs": 1437.3269999999998,
"heapDeltaBytes": 265772,
"heapUsedBytes": 77603508,
"domNodes": 19229,
"jsHeapTotalBytes": 17039360,
"scriptDurationMs": 33.967,
"eventListeners": 3566,
"totalBlockingTimeMs": 219,
"frameDurationMs": 20.6746835443038,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10716.390999999987,
"styleRecalcs": 251,
"styleRecalcDurationMs": 28.954,
"layouts": 8,
"layoutDurationMs": 2.098,
"taskDurationMs": 6314.322,
"heapDeltaBytes": 14104136,
"heapUsedBytes": 87982644,
"domNodes": -274,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 2864.499,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.692056074766356,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10850.23799999999,
"styleRecalcs": 250,
"styleRecalcDurationMs": 29.657,
"layouts": 8,
"layoutDurationMs": 2.1990000000000003,
"taskDurationMs": 6428.458,
"heapDeltaBytes": -3903496,
"heapUsedBytes": 78254140,
"domNodes": -274,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 2854.421,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66605222734255,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 24687.01699999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23807.901,
"heapDeltaBytes": -1048940,
"heapUsedBytes": 288348988,
"domNodes": -356,
"jsHeapTotalBytes": 6537216,
"scriptDurationMs": 331.249,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.6083038869258,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 24290.72599999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23423.273999999998,
"heapDeltaBytes": -42119012,
"heapUsedBytes": 267677688,
"domNodes": -3482,
"jsHeapTotalBytes": 11780096,
"scriptDurationMs": 330.372,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.303658536585374,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 29650.666999999998,
"styleRecalcs": 181,
"styleRecalcDurationMs": 21.954999999999973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 29359.893,
"heapDeltaBytes": -30166816,
"heapUsedBytes": 258544592,
"domNodes": -3482,
"jsHeapTotalBytes": 16769024,
"scriptDurationMs": 932.294,
"eventListeners": -659,
"totalBlockingTimeMs": 26,
"frameDurationMs": 56.0468809073724,
"p95FrameDurationMs": 116.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 29229.824000000008,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.592,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28815.482000000004,
"heapDeltaBytes": -5998608,
"heapUsedBytes": 278529808,
"domNodes": -3482,
"jsHeapTotalBytes": 13615104,
"scriptDurationMs": 917.481,
"eventListeners": -659,
"totalBlockingTimeMs": 96,
"frameDurationMs": 54.303903345724905,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8687.708999999984,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.97099999999999,
"layouts": 20,
"layoutDurationMs": 24.899000000000004,
"taskDurationMs": 8606.51,
"heapDeltaBytes": 2616608,
"heapUsedBytes": 285809236,
"domNodes": -2409,
"jsHeapTotalBytes": 18857984,
"scriptDurationMs": 160.04200000000003,
"eventListeners": -431,
"totalBlockingTimeMs": 92,
"frameDurationMs": 51.58511904761905,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8631.906999999956,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.204,
"layouts": 20,
"layoutDurationMs": 28.704999999999995,
"taskDurationMs": 8513.619,
"heapDeltaBytes": -29572640,
"heapUsedBytes": 253731048,
"domNodes": -3482,
"jsHeapTotalBytes": 19386368,
"scriptDurationMs": 130.828,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 49.901734104046234,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12542.674999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12090.733,
"heapDeltaBytes": 5876940,
"heapUsedBytes": 271798260,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 185.76999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.900696864111495,
"p95FrameDurationMs": 99.89999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12473.118999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11978.639000000001,
"heapDeltaBytes": 32235088,
"heapUsedBytes": 287682208,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 167.06199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.896219931271474,
"p95FrameDurationMs": 99.89999999999782
},
{
"name": "workflow-execution",
"durationMs": 148.21399999999585,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.54,
"layouts": 9,
"layoutDurationMs": 3.9659999999999997,
"taskDurationMs": 113.737,
"heapDeltaBytes": -11924880,
"heapUsedBytes": 63489992,
"domNodes": 128,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 9.089000000000002,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67500000000001,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 497.69899999989775,
"styleRecalcs": 18,
"styleRecalcDurationMs": 13.107999999999999,
"layouts": 10,
"layoutDurationMs": 4.361000000000001,
"taskDurationMs": 138.836,
"heapDeltaBytes": 7334408,
"heapUsedBytes": 73315176,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.363999999999999,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 564.5659999998998,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6819999999999999,
"layouts": 76,
"layoutDurationMs": 15.611999999999998,
"taskDurationMs": 510.02000000000004,
"heapDeltaBytes": -2875640,
"heapUsedBytes": 43887808,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 253.26000000000005,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 489.47499999997035,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.696,
"layouts": 76,
"layoutDurationMs": 14.791,
"taskDurationMs": 446.76300000000003,
"heapDeltaBytes": -934828,
"heapUsedBytes": 47240080,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 217.10399999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 563.5599999999386,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.8339999999999999,
"layouts": 76,
"layoutDurationMs": 14.556,
"taskDurationMs": 529.927,
"heapDeltaBytes": 971560,
"heapUsedBytes": 103174168,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 220.384,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.152941176470584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 553.6990000000515,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.812,
"layouts": 76,
"layoutDurationMs": 14.946,
"taskDurationMs": 524.0550000000001,
"heapDeltaBytes": 735652,
"heapUsedBytes": 103115012,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 212.905,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352926,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage: 🟡 59.4% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3216 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e876139725f5ee3c2ea6bed93971ee25aed68b82
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (352)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.60 #22775 +/- ##
==============================================
- Coverage 87.58% 87.49% -0.09%
==============================================
Files 2991 2883 -108
Lines 162548 159169 -3379
Branches 41781 42635 +854
==============================================
- Hits 142361 139259 -3102
+ Misses 19254 19145 -109
+ Partials 933 765 -168
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 116 files with indirect coverage changes 🚀 New features to boost your workflow:
|
… nodes (Comfy-Org#22772) ## Summary When a workflow is missing nodes, the issues card and the Issues panel offer the deployments that can run it. They also listed stopped, failed and starting deployments, so **Switch** could reload the editor onto a deployment where jobs won't run. The Run on menu already refuses this (Comfy-Org#21858). They now list only ready deployments; when only a deployment that isn't ready can run the workflow, the card stays as it was and the menu's **Start** remains the way forward. Reachable only with `deployment_compatibility_marks_enabled` on. Not changed here: switching from an already-open dialog after its deployment stops (known, listed on Comfy-Org#22539), and picking a deployment from a link (`pickFromLink`). ## Verification - The 5 new tests fail without the fix. With it, `ErrorOverlayDeploymentOffer`, `MissingNodeDeploymentOffer` and `MissingNodeCard` pass (55 tests). - Cherry-picked locally onto `cloud/1.59` (`3e870e6f8`) and `cloud/1.60` (`e87613972`): the two changed suites pass (34 tests), application typecheck clean on both. Backports: Comfy-Org#22774 (`cloud/1.59`), Comfy-Org#22775 (`cloud/1.60`). - Not run in a browser. The bug was found in QA on staging at `3e870e6f8`, and confirmed by reading the code.
Summary
Backport of #22772 to
cloud/1.60. When a workflow is missing nodes, the issues card and the Issues panel listed stopped, failed and starting deployments, so Switch could reload the editor onto a deployment where jobs won't run. They now list only ready deployments; when only a deployment that isn't ready can run the workflow, the card stays as it was and the Run on menu's Start remains the way forward.Applies without conflicts. Reachable only with
deployment_compatibility_marks_enabledon.Verification
ErrorOverlayDeploymentOfferandMissingNodeDeploymentOfferpass (34 tests), application typecheck clean.3e870e6f8, and confirmed by reading the code.