Repository navigation
[backport cloud/1.59] offer only ready deployments for missing nodes (#22772) - #22774
Conversation
… nodes The issues card and the Issues panel offer the deployments that can run a workflow with missing nodes. They listed stopped, failed and starting deployments too, so Switch could reload the editor onto a deployment where jobs won't run. The Run on menu already refuses this. They now list only ready deployments. When only a deployment that isn't ready can run the workflow, the card stays as it was and the Run on menu's Start remains the way forward. (cherry picked from commit fe6394b)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-03T02:34:50.294Z",
"gitSha": "768dc031b16a7eaeb03d13af407cbfc51d7593cf",
"branch": "bl/cloud-1.59-missing-node-offer-ready-only",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.8259999999855,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9119999999999995,
"layouts": 9,
"layoutDurationMs": 2.747,
"taskDurationMs": 573.965,
"heapDeltaBytes": 2220328,
"heapUsedBytes": 63890284,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 11.73,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2023.416999999995,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.143,
"layouts": 9,
"layoutDurationMs": 2.8199999999999994,
"taskDurationMs": 648.6260000000001,
"heapDeltaBytes": 2021356,
"heapUsedBytes": 64288776,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 14.605,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1826.989999999995,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.719999999999999,
"layouts": 9,
"layoutDurationMs": 2.5160000000000005,
"taskDurationMs": 949.427,
"heapDeltaBytes": -9742144,
"heapUsedBytes": 67021200,
"domNodes": -161,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 155.50300000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871563,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1842.1740000000568,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.887999999999998,
"layouts": 9,
"layoutDurationMs": 2.8089999999999997,
"taskDurationMs": 943.2810000000001,
"heapDeltaBytes": 22899876,
"heapUsedBytes": 84139732,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 160.93400000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666363636363634,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.5419999999758,
"styleRecalcs": 20,
"styleRecalcDurationMs": 5.705000000000001,
"layouts": 10,
"layoutDurationMs": 3.055,
"taskDurationMs": 408.811,
"heapDeltaBytes": -1678148,
"heapUsedBytes": 60097984,
"domNodes": 56,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 11.702999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.4989999999234,
"styleRecalcs": 20,
"styleRecalcDurationMs": 5.827,
"layouts": 10,
"layoutDurationMs": 3.3539999999999996,
"taskDurationMs": 467.418,
"heapDeltaBytes": 24505996,
"heapUsedBytes": 86291484,
"domNodes": 56,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 15.323000000000004,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 663.7059999999906,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.1180000000000003,
"layouts": 10,
"layoutDurationMs": 2.926,
"taskDurationMs": 496.34400000000005,
"heapDeltaBytes": 6583700,
"heapUsedBytes": 76682548,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 164.15099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 759.6260000000257,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.2830000000000004,
"layouts": 9,
"layoutDurationMs": 2.8299999999999996,
"taskDurationMs": 544.591,
"heapDeltaBytes": 7075504,
"heapUsedBytes": 77682272,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 172.585,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1222.7550000000065,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 927.124,
"heapDeltaBytes": -14599616,
"heapUsedBytes": 73036396,
"domNodes": -191,
"jsHeapTotalBytes": 22028288,
"scriptDurationMs": 66.518,
"eventListeners": -107,
"totalBlockingTimeMs": 538,
"frameDurationMs": 32.88108108108109,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1332.1980000000053,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1060.973,
"heapDeltaBytes": -11769724,
"heapUsedBytes": 76036188,
"domNodes": -191,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 64.65100000000001,
"eventListeners": -107,
"totalBlockingTimeMs": 637,
"frameDurationMs": 35.086842105263166,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 894.9980000000153,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 591.5609999999996,
"heapDeltaBytes": -28563384,
"heapUsedBytes": 65664280,
"domNodes": -191,
"jsHeapTotalBytes": 3538944,
"scriptDurationMs": 151.78900000000002,
"eventListeners": -107,
"totalBlockingTimeMs": 228,
"frameDurationMs": 24.997222222222238,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 922.3149999999691,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 607.6230000000003,
"heapDeltaBytes": -29574108,
"heapUsedBytes": 66861352,
"domNodes": -191,
"jsHeapTotalBytes": 3276800,
"scriptDurationMs": 156.23200000000003,
"eventListeners": -107,
"totalBlockingTimeMs": 233,
"frameDurationMs": 24.775675675675647,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10146.31,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9253.226,
"heapDeltaBytes": -8881596,
"heapUsedBytes": 70448432,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 7335.887,
"eventListeners": 0,
"totalBlockingTimeMs": 493,
"frameDurationMs": 31.082515337423313,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9949.918999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9130.764999999998,
"heapDeltaBytes": 59164032,
"heapUsedBytes": 133855152,
"domNodes": -257,
"jsHeapTotalBytes": 66711552,
"scriptDurationMs": 7109.143999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 320,
"frameDurationMs": 30.333841463414632,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9671.453999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8884.161,
"heapDeltaBytes": 60979648,
"heapUsedBytes": 134568784,
"domNodes": -257,
"jsHeapTotalBytes": 69070848,
"scriptDurationMs": 6994.3330000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 208,
"frameDurationMs": 28.94131736526946,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10022.239999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9154.32,
"heapDeltaBytes": 62050448,
"heapUsedBytes": 136333368,
"domNodes": -257,
"jsHeapTotalBytes": 57274368,
"scriptDurationMs": 7073.750999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 354,
"frameDurationMs": 30.16957831325301,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 282.98800000001734,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.236,
"layouts": 11,
"layoutDurationMs": 3.1169999999999995,
"taskDurationMs": 230.305,
"heapDeltaBytes": -17235632,
"heapUsedBytes": 58586836,
"domNodes": 936,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 9.033,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.60833333333331,
"p95FrameDurationMs": 99.90000000000009
},
{
"name": "large-combo-open",
"durationMs": 339.60000000001855,
"styleRecalcs": 27,
"styleRecalcDurationMs": 17.876999999999995,
"layouts": 12,
"layoutDurationMs": 4.2620000000000005,
"taskDurationMs": 286.566,
"heapDeltaBytes": -19177844,
"heapUsedBytes": 63504836,
"domNodes": 551,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 12.121,
"eventListeners": 5,
"totalBlockingTimeMs": 9,
"frameDurationMs": 27.775000000000016,
"p95FrameDurationMs": 116.70000000000027
},
{
"name": "large-graph-idle",
"durationMs": 2055.1529999999902,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.732,
"layouts": 9,
"layoutDurationMs": 2.703,
"taskDurationMs": 706.3369999999999,
"heapDeltaBytes": -14190072,
"heapUsedBytes": 60474868,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 36.91300000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2057.2040000000698,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.197,
"layouts": 7,
"layoutDurationMs": 2.09,
"taskDurationMs": 809.7129999999999,
"heapDeltaBytes": -3489324,
"heapUsedBytes": 73446580,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 40.952000000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2426.5830000000224,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.189,
"layouts": 7,
"layoutDurationMs": 1.878,
"taskDurationMs": 1649.139,
"heapDeltaBytes": 741164,
"heapUsedBytes": 76331600,
"domNodes": -257,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 787.7539999999999,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78194444444444,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2892.7489999999807,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.622,
"layouts": 6,
"layoutDurationMs": 1.641,
"taskDurationMs": 1772.3110000000001,
"heapDeltaBytes": -3283736,
"heapUsedBytes": 72301764,
"domNodes": -257,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 824.834,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.763372093023257,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3996.735000000001,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.667,
"layouts": 64,
"layoutDurationMs": 11.332,
"taskDurationMs": 1843.248,
"heapDeltaBytes": -11444792,
"heapUsedBytes": 64567276,
"domNodes": -233,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 796.559,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66625,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4064.3800000000283,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.271,
"layouts": 64,
"layoutDurationMs": 12.205,
"taskDurationMs": 1947.368,
"heapDeltaBytes": -15688844,
"heapUsedBytes": 66206452,
"domNodes": -233,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 849.468,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665983606557376,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2928.3459999999764,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.221000000000001,
"layouts": 6,
"layoutDurationMs": 1.697,
"taskDurationMs": 1904.6989999999998,
"heapDeltaBytes": 19528676,
"heapUsedBytes": 98879736,
"domNodes": 0,
"jsHeapTotalBytes": 5398528,
"scriptDurationMs": 953.306,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.856571428571428,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3204.6960000000126,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.761999999999999,
"layouts": 4,
"layoutDurationMs": 1.2799999999999998,
"taskDurationMs": 2090.969,
"heapDeltaBytes": -6095708,
"heapUsedBytes": 73534604,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 1041.742,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.841052631578947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3117.6529999999902,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7469999999999994,
"layouts": 3,
"layoutDurationMs": 0.696,
"taskDurationMs": 808.7629999999999,
"heapDeltaBytes": 445728,
"heapUsedBytes": 80582092,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 374.816,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665775401069517,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3054.196999999988,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.3089999999999985,
"layouts": 1,
"layoutDurationMs": 0.38699999999999934,
"taskDurationMs": 775.5160000000001,
"heapDeltaBytes": 23181788,
"heapUsedBytes": 86212232,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 368.30800000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666120218579234,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2045.5460000000016,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.3620000000000005,
"layouts": 7,
"layoutDurationMs": 2.3550000000000004,
"taskDurationMs": 654.997,
"heapDeltaBytes": -13751420,
"heapUsedBytes": 62798384,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 38.79899999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.5339999999987,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4539999999999997,
"layouts": 8,
"layoutDurationMs": 2.4749999999999996,
"taskDurationMs": 732.8359999999999,
"heapDeltaBytes": -18752516,
"heapUsedBytes": 73890628,
"domNodes": -257,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 39.59,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2867.3140000000217,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.400000000000002,
"layouts": 7,
"layoutDurationMs": 1.8909999999999998,
"taskDurationMs": 603.1629999999999,
"heapDeltaBytes": -7964292,
"heapUsedBytes": 69452136,
"domNodes": -254,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 183.546,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665697674418603,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2998.047999999983,
"styleRecalcs": 24,
"styleRecalcDurationMs": 12.031,
"layouts": 5,
"layoutDurationMs": 1.829,
"taskDurationMs": 675.652,
"heapDeltaBytes": -7826016,
"heapUsedBytes": 84946256,
"domNodes": -238,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 197.903,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611111111111,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3335.871999999995,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.7300000000000006,
"layouts": 5,
"layoutDurationMs": 1.5190000000000003,
"taskDurationMs": 1036.323,
"heapDeltaBytes": -15850944,
"heapUsedBytes": 61465748,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 401.7,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.749748743718595,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3386.457000000007,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.625999999999999,
"layouts": 5,
"layoutDurationMs": 1.5850000000000004,
"taskDurationMs": 1046.502,
"heapDeltaBytes": -6619672,
"heapUsedBytes": 70853216,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 411.149,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7490099009901,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 625.6589999999846,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.329,
"layouts": 9,
"layoutDurationMs": 2.477,
"taskDurationMs": 443.31600000000003,
"heapDeltaBytes": 404948,
"heapUsedBytes": 62638628,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 146.44,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 708.1210000000056,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.522000000000001,
"layouts": 8,
"layoutDurationMs": 2.4580000000000006,
"taskDurationMs": 476.18499999999995,
"heapDeltaBytes": -201872,
"heapUsedBytes": 62719340,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 151.369,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669047619047628,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2023.2490000000212,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4610000000000003,
"layouts": 9,
"layoutDurationMs": 2.1659999999999995,
"taskDurationMs": 520.0060000000001,
"heapDeltaBytes": 1776168,
"heapUsedBytes": 63429704,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 8.869,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2020.0449999999819,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.5720000000000005,
"layouts": 8,
"layoutDurationMs": 2.613,
"taskDurationMs": 691.175,
"heapDeltaBytes": 2214828,
"heapUsedBytes": 64304260,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 13.111,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.4040000000205,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.074000000000002,
"layouts": 10,
"layoutDurationMs": 2.744,
"taskDurationMs": 803.496,
"heapDeltaBytes": 17650536,
"heapUsedBytes": 79767044,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 102.885,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1750.6879999999683,
"styleRecalcs": 78,
"styleRecalcDurationMs": 15.842000000000002,
"layouts": 9,
"layoutDurationMs": 2.5120000000000005,
"taskDurationMs": 961.438,
"heapDeltaBytes": -9678652,
"heapUsedBytes": 51662644,
"domNodes": -183,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 119.878,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1435.4639999999677,
"styleRecalcs": 19,
"styleRecalcDurationMs": 22.440999999999995,
"layouts": 5,
"layoutDurationMs": 13.066,
"taskDurationMs": 1122.9260000000002,
"heapDeltaBytes": 38000992,
"heapUsedBytes": 113810364,
"domNodes": 16030,
"jsHeapTotalBytes": 7737344,
"scriptDurationMs": 33.082,
"eventListeners": 3246,
"totalBlockingTimeMs": 150,
"frameDurationMs": 19.331999999999994,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10505.084999999952,
"styleRecalcs": 251,
"styleRecalcDurationMs": 31.561000000000007,
"layouts": 8,
"layoutDurationMs": 2.11,
"taskDurationMs": 5972.357,
"heapDeltaBytes": 9646664,
"heapUsedBytes": 87070568,
"domNodes": -257,
"jsHeapTotalBytes": 6086656,
"scriptDurationMs": 2632.4809999999998,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666190476190476,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 11851.999999999975,
"styleRecalcs": 247,
"styleRecalcDurationMs": 33.775,
"layouts": 5,
"layoutDurationMs": 1.3950000000000005,
"taskDurationMs": 6495.756,
"heapDeltaBytes": 6482248,
"heapUsedBytes": 80920496,
"domNodes": -257,
"jsHeapTotalBytes": 57344,
"scriptDurationMs": 2885.41,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.68956276445698,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 24010.735999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23405.906,
"heapDeltaBytes": 5308368,
"heapUsedBytes": 285080288,
"domNodes": -3343,
"jsHeapTotalBytes": 8900608,
"scriptDurationMs": 349.77799999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.28116197183099,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 24557.643999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23925.677,
"heapDeltaBytes": -20137148,
"heapUsedBytes": 281195700,
"domNodes": -3343,
"jsHeapTotalBytes": 7856128,
"scriptDurationMs": 370.677,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.71103202846975,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 28826.585999999963,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.136000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28459.616000000005,
"heapDeltaBytes": -47952164,
"heapUsedBytes": 254731480,
"domNodes": -3343,
"jsHeapTotalBytes": 14929920,
"scriptDurationMs": 901.5699999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 20,
"frameDurationMs": 54.92418426103647,
"p95FrameDurationMs": 116.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 29651.242000000024,
"styleRecalcs": 181,
"styleRecalcDurationMs": 27.087,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 29410.213999999996,
"heapDeltaBytes": -39924168,
"heapUsedBytes": 262573552,
"domNodes": -3343,
"jsHeapTotalBytes": 14929920,
"scriptDurationMs": 971.5859999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 27,
"frameDurationMs": 57.79512670565302,
"p95FrameDurationMs": 116.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8537.568000000021,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.21499999999997,
"layouts": 20,
"layoutDurationMs": 31.014,
"taskDurationMs": 8438.985,
"heapDeltaBytes": -15469280,
"heapUsedBytes": 277055632,
"domNodes": -3343,
"jsHeapTotalBytes": 18075648,
"scriptDurationMs": 186.41100000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 94,
"frameDurationMs": 48.66457142857143,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 8649.82999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.99999999999999,
"layouts": 20,
"layoutDurationMs": 28.924000000000007,
"taskDurationMs": 8555.139000000001,
"heapDeltaBytes": 7489808,
"heapUsedBytes": 280905480,
"domNodes": -307,
"jsHeapTotalBytes": 19128320,
"scriptDurationMs": 141.537,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 50.484795321637414,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11708.349999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11429.105000000001,
"heapDeltaBytes": 14602940,
"heapUsedBytes": 266027184,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.62699999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.10982456140351,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12403.763000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12194.866999999998,
"heapDeltaBytes": 3338400,
"heapUsedBytes": 261253660,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 183.349,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.15687732342009,
"p95FrameDurationMs": 100
},
{
"name": "workflow-execution",
"durationMs": 148.01199999999426,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9,
"layouts": 10,
"layoutDurationMs": 3.8469999999999995,
"taskDurationMs": 117.82,
"heapDeltaBytes": -12260012,
"heapUsedBytes": 63082476,
"domNodes": 135,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 8.803,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67500000000001,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 164.78999999992539,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.977999999999998,
"layouts": 11,
"layoutDurationMs": 4.529999999999999,
"taskDurationMs": 107.33600000000001,
"heapDeltaBytes": 4751832,
"heapUsedBytes": 71223880,
"domNodes": 103,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.542000000000002,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 592.7979999999025,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.785,
"layouts": 76,
"layoutDurationMs": 20.147000000000002,
"taskDurationMs": 536.812,
"heapDeltaBytes": -3415260,
"heapUsedBytes": 42259320,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 250.76700000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 608.4189999999126,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.8220000000000001,
"layouts": 76,
"layoutDurationMs": 19.429,
"taskDurationMs": 550.6329999999999,
"heapDeltaBytes": -362752,
"heapUsedBytes": 46194744,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 260.476,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 774.8540000000048,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.9370000000000003,
"layouts": 76,
"layoutDurationMs": 18.903,
"taskDurationMs": 739.9979999999999,
"heapDeltaBytes": 2698000,
"heapUsedBytes": 96957884,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 312.93,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.0282608695652,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 647.4220000000059,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.117,
"layouts": 76,
"layoutDurationMs": 17.443,
"taskDurationMs": 606.09,
"heapDeltaBytes": 2169300,
"heapUsedBytes": 99450548,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 244.578,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.105263157894736,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage: 🟡 59.8% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3132 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3e870e6f828e17fd4635af1d0e5840d747737a81
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (278)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.59 #22774 +/- ##
=============================================
Coverage ? 87.28%
=============================================
Files ? 3064
Lines ? 160608
Branches ? 40399
=============================================
Hits ? 140187
Misses ? 19741
Partials ? 680
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
… nodes (Comfy-Org#22772) ## Summary When a workflow is missing nodes, the issues card and the Issues panel offer the deployments that can run it. They also listed stopped, failed and starting deployments, so **Switch** could reload the editor onto a deployment where jobs won't run. The Run on menu already refuses this (Comfy-Org#21858). They now list only ready deployments; when only a deployment that isn't ready can run the workflow, the card stays as it was and the menu's **Start** remains the way forward. Reachable only with `deployment_compatibility_marks_enabled` on. Not changed here: switching from an already-open dialog after its deployment stops (known, listed on Comfy-Org#22539), and picking a deployment from a link (`pickFromLink`). ## Verification - The 5 new tests fail without the fix. With it, `ErrorOverlayDeploymentOffer`, `MissingNodeDeploymentOffer` and `MissingNodeCard` pass (55 tests). - Cherry-picked locally onto `cloud/1.59` (`3e870e6f8`) and `cloud/1.60` (`e87613972`): the two changed suites pass (34 tests), application typecheck clean on both. Backports: Comfy-Org#22774 (`cloud/1.59`), Comfy-Org#22775 (`cloud/1.60`). - Not run in a browser. The bug was found in QA on staging at `3e870e6f8`, and confirmed by reading the code.
Summary
Backport of #22772 to
cloud/1.59. When a workflow is missing nodes, the issues card and the Issues panel listed stopped, failed and starting deployments, so Switch could reload the editor onto a deployment where jobs won't run. They now list only ready deployments; when only a deployment that isn't ready can run the workflow, the card stays as it was and the Run on menu's Start remains the way forward.Applies without conflicts. Reachable only with
deployment_compatibility_marks_enabledon.Verification
ErrorOverlayDeploymentOfferandMissingNodeDeploymentOfferpass (34 tests), application typecheck clean.3e870e6f8, and confirmed by reading the code.