Repository navigation
chore: enable new Vue, Playwright, and Stylelint rules #22749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,22 +58,26 @@ | |
| <i class="icon-[lucide--undo-2]" /> | ||
| {{ $t('g.cancel') }} | ||
| </Button> | ||
| <Button v-if="type === 'default'" variant="primary" @click="onConfirm"> | ||
| <Button | ||
| v-if="type === 'default'" | ||
| variant="primary" | ||
| @click="handleConfirm" | ||
| > | ||
| <i class="icon-[lucide--check]" /> | ||
| {{ $t('g.confirm') }} | ||
| </Button> | ||
| <Button | ||
| v-else-if="type === 'delete'" | ||
| variant="destructive" | ||
| @click="onConfirm" | ||
| @click="handleConfirm" | ||
| > | ||
| <i class="icon-[lucide--trash-2]" /> | ||
| {{ $t('g.delete') }} | ||
| </Button> | ||
| <Button | ||
| v-else-if="type === 'overwrite' || type === 'overwriteBlueprint'" | ||
| variant="destructive" | ||
| @click="onConfirm" | ||
| @click="handleConfirm" | ||
| > | ||
| <i class="icon-[lucide--save]" /> | ||
| {{ $t('g.overwrite') }} | ||
|
|
@@ -83,15 +87,15 @@ | |
| <i class="icon-[lucide--x]" /> | ||
| {{ denyLabel ?? $t('g.no') }} | ||
| </Button> | ||
| <Button autofocus @click="onConfirm"> | ||
| <Button autofocus @click="handleConfirm"> | ||
| <i class="icon-[lucide--save]" /> | ||
| {{ confirmLabel ?? $t('g.save') }} | ||
| </Button> | ||
| </template> | ||
| <Button | ||
| v-else-if="type === 'reinstall'" | ||
| variant="destructive" | ||
| @click="onConfirm" | ||
| @click="handleConfirm" | ||
| > | ||
| <i class="icon-[lucide--eraser]" /> | ||
| {{ $t('desktopMenu.reinstall') }} | ||
|
|
@@ -145,7 +149,7 @@ const onDeny = () => { | |
| useDialogStore().closeDialog() | ||
| } | ||
|
|
||
| const onConfirm = () => { | ||
| const handleConfirm = () => { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I like this that use handleX for handler and onX as prop. It's great to keep them consistent
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Answer: Kept |
||
| if (props.type === 'overwriteBlueprint' && doNotAskAgain.value) | ||
| void useSettingStore().set('Comfy.Workflow.WarnBlueprintOverwrite', false) | ||
| props.onConfirm(true) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Answer: Both sibling describe blocks originally used the same title, which the newly enabled
playwright/no-identical-titlerule rejects. This second suite exercises exhausted subscription retries and reconnect, so the new title distinguishes that case. Restoring the old title reproduces the lint error; the current title passes. The tests and fixtures are unchanged.