Skip to content

feat(architecture): give mask-editor public entry points - #22738

Closed
DrJKL wants to merge 2 commits into
architecture/remove-rolesfrom
architecture/mask-editor-entries
Closed

DrJKL wants to merge 2 commits into
architecture/remove-rolesfrom
architecture/mask-editor-entries

Conversation

@DrJKL

@DrJKL DrJKL commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes the deep imports into mask-editor, stacked on #22733. Mask-editor violations go from 16 to 1, and the total from 47 to 32.

  • New public entry points, each cited by a characterization scenario:
    • src/extensions/core/maskeditor.ts, src/extensions/core/clipspace.ts: the core extension seam that extensions/core/index.ts registers (index.test.ts, maskeditor.test.ts).
    • src/renderer/extensions/maskEditor/composables/useMaskEditor.ts: opening the editor from app mode and Vue node previews (useMaskEditor.test.ts).
    • src/scripts/clipspace.ts: the clipspace state ComfyApp, changeTracker and litegraphService share (clipspace.test.ts).
    • @comfyorg/mask-editor/maskEditorStore: undo/redo from core commands (maskEditorStore.test.ts).
    • @comfyorg/mask-editor/StrokeProcessor and brushUtils: the stroke engine the painter reuses (StrokeProcessor.test.ts, brushUtils.test.ts).
  • extractWidgetStringValue moves from useMaskEditorLoader to src/utils/imageUtil.ts, next to parseImageWidgetValue. It reads a generic image widget value, and the app-mode loader drop indicator was importing mask-editor internals only to get it.

The remaining violation is src/extensions/core/index.test.ts → src/extensions/core/maskeditor.test.ts. The test's import.meta.glob excludes *.test.ts with negative entries, which Vite applies and Fallow 3.24.1 ignores, so Fallow sees an import of every test file in the directory. Fixing it needs a Fallow upgrade or a different way to enumerate core extension modules.

Verification

  • pnpm architecture:update / architecture:check pass (same warnings).
  • Affected unit tests pass: imageUtil, builder, maskEditor, core extensions, clipspace, useCoreCommands, painter, tools/architecture.
  • pnpm typecheck, oxlint, oxfmt and the pre-push hook pass.

DrJKL added 2 commits November 2, 2026 20:52
Callers reach the mask editor through its extension modules, useMaskEditor,
clipspace, and the package's stroke engine and store, each covered by a
characterization test. extractWidgetStringValue moves to imageUtil next to
parseImageWidgetValue, since the loader drop indicator and the mask editor
loader both read image widget values with it.
@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle: ⏳ Size data collection in progress…

⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable

❌ 7 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Details
Scenario timings

canvas-idle: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.0 MB heap
canvas-mouse-sweep: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.8 MB heap
canvas-zoom-sweep: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.6 MB heap
dom-widget-clipping: 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.4 MB heap
dom-widget-order-dense-n200-w200-i120: 38.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 273ms TBT · 74.3 MB heap
dom-widget-order-sparse-n1000-w20-i120: 48.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 89ms TBT · 72.8 MB heap
extension-clean-combined-draw: 45.8 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 67ms TBT · 108.4 MB heap
extension-rgthree-prototype-draw: 49.4 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 3ms TBT · 113.2 MB heap
large-combo-open: 50.5 avg FPS · 24.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 78.7 MB heap
large-graph-idle: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.2 MB heap
large-graph-pan: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.1 MB heap
large-graph-zoom: 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.3 MB heap
legacy-node-drag: 59.8 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.5 MB heap
minimap-geometry-cadence: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.1 MB heap
minimap-idle: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.6 MB heap
minimap-progress-execution-cadence: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.0 MB heap
minimap-topology-cadence: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.6 MB heap
subgraph-dom-widget-clipping: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
subgraph-idle: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.1 MB heap
subgraph-mouse-sweep: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
subgraph-transition-enter: 52.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 123ms TBT · 95.4 MB heap
viewport-pan-sweep: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.9 MB heap
vue-large-graph-idle: 33.9 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 263.6 MB heap
vue-large-graph-pan: 30.5 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 80ms TBT · 261.2 MB heap
vue-node-resize-workload: 27.9 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 256.1 MB heap
vue-zoom-out-idle: 35.0 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 255.2 MB heap
workflow-execution: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.3 MB heap
agent-composer-empty-conversation-typing: 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 48.5 MB heap
agent-composer-long-conversation-typing: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 92.7 MB heap

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 2ms
canvas-idle: style recalc duration 2ms
canvas-idle: layout count 10
canvas-idle: style recalc count 10
canvas-idle: task duration 377ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 64.0 MB
canvas-idle: DOM nodes -178
canvas-idle: event listeners -69
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 2ms
canvas-mouse-sweep: style recalc duration 12ms
canvas-mouse-sweep: layout count 10
canvas-mouse-sweep: style recalc count 72
canvas-mouse-sweep: task duration 616ms
canvas-mouse-sweep: script duration 111ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 69.8 MB
canvas-mouse-sweep: DOM nodes 0
canvas-mouse-sweep: event listeners 6
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 3ms
canvas-zoom-sweep: style recalc duration 5ms
canvas-zoom-sweep: layout count 13
canvas-zoom-sweep: style recalc count 19
canvas-zoom-sweep: task duration 272ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 81.6 MB
canvas-zoom-sweep: DOM nodes 57
canvas-zoom-sweep: event listeners 43
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 3ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 10
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 348ms
dom-widget-clipping: script duration 113ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 71.4 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 26ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 579ms
dom-widget-order-dense-n200-w200-i120: script duration 39ms
dom-widget-order-dense-n200-w200-i120: TBT 273ms
dom-widget-order-dense-n200-w200-i120: heap used 74.3 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -208
dom-widget-order-dense-n200-w200-i120: event listeners -107
dom-widget-order-sparse-n1000-w20-i120: avg frame time 21ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 283ms
dom-widget-order-sparse-n1000-w20-i120: script duration 93ms
dom-widget-order-sparse-n1000-w20-i120: TBT 89ms
dom-widget-order-sparse-n1000-w20-i120: heap used 72.8 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 22ms
extension-clean-combined-draw: p95 frame time 33ms
extension-clean-combined-draw: layout duration 1ms
extension-clean-combined-draw: style recalc duration 1ms
extension-clean-combined-draw: layout count 3
extension-clean-combined-draw: style recalc count 3
extension-clean-combined-draw: task duration 5703ms
extension-clean-combined-draw: script duration 4291ms
extension-clean-combined-draw: TBT 67ms
extension-clean-combined-draw: heap used 108.4 MB
extension-clean-combined-draw: DOM nodes -274
extension-clean-combined-draw: event listeners -69
extension-rgthree-prototype-draw: avg frame time 20ms
extension-rgthree-prototype-draw: p95 frame time 33ms
extension-rgthree-prototype-draw: layout duration 1ms
extension-rgthree-prototype-draw: style recalc duration 1ms
extension-rgthree-prototype-draw: layout count 5
extension-rgthree-prototype-draw: style recalc count 5
extension-rgthree-prototype-draw: task duration 5494ms
extension-rgthree-prototype-draw: script duration 4106ms
extension-rgthree-prototype-draw: TBT 3ms
extension-rgthree-prototype-draw: heap used 113.2 MB
extension-rgthree-prototype-draw: DOM nodes -274
extension-rgthree-prototype-draw: event listeners -69
large-combo-open: avg frame time 20ms
large-combo-open: p95 frame time 42ms
large-combo-open: layout duration 3ms
large-combo-open: style recalc duration 11ms
large-combo-open: layout count 12
large-combo-open: style recalc count 21
large-combo-open: task duration 110ms
large-combo-open: script duration 6ms
large-combo-open: TBT 0ms
large-combo-open: heap used 78.7 MB
large-combo-open: DOM nodes 936
large-combo-open: event listeners 205
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 2ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 9
large-graph-idle: style recalc count 9
large-graph-idle: task duration 505ms
large-graph-idle: script duration 29ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 62.2 MB
large-graph-idle: DOM nodes -274
large-graph-idle: event listeners -69
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 2ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 8
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1310ms
large-graph-pan: script duration 602ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 71.1 MB
large-graph-pan: DOM nodes -274
large-graph-pan: event listeners -67
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 67
large-graph-zoom: style recalc count 73
large-graph-zoom: task duration 1353ms
large-graph-zoom: script duration 561ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 70.3 MB
large-graph-zoom: DOM nodes -253
large-graph-zoom: event listeners -69
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 2ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 7
legacy-node-drag: style recalc count 47
legacy-node-drag: task duration 1542ms
legacy-node-drag: script duration 762ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 75.5 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 182
minimap-geometry-cadence: avg frame time 17ms
minimap-geometry-cadence: p95 frame time 17ms
minimap-geometry-cadence: layout duration 2ms
minimap-geometry-cadence: style recalc duration 2ms
minimap-geometry-cadence: layout count 8
minimap-geometry-cadence: style recalc count 9
minimap-geometry-cadence: task duration 528ms
minimap-geometry-cadence: script duration 242ms
minimap-geometry-cadence: TBT 0ms
minimap-geometry-cadence: heap used 70.1 MB
minimap-geometry-cadence: DOM nodes -274
minimap-geometry-cadence: event listeners -69
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 2ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 9
minimap-idle: style recalc count 9
minimap-idle: task duration 469ms
minimap-idle: script duration 29ms
minimap-idle: TBT 0ms
minimap-idle: heap used 70.6 MB
minimap-idle: DOM nodes -274
minimap-idle: event listeners -69
minimap-progress-execution-cadence: avg frame time 17ms
minimap-progress-execution-cadence: p95 frame time 17ms
minimap-progress-execution-cadence: layout duration 2ms
minimap-progress-execution-cadence: style recalc duration 11ms
minimap-progress-execution-cadence: layout count 9
minimap-progress-execution-cadence: style recalc count 29
minimap-progress-execution-cadence: task duration 377ms
minimap-progress-execution-cadence: script duration 132ms
minimap-progress-execution-cadence: TBT 0ms
minimap-progress-execution-cadence: heap used 79.0 MB
minimap-progress-execution-cadence: DOM nodes 19
minimap-progress-execution-cadence: event listeners 0
minimap-topology-cadence: avg frame time 17ms
minimap-topology-cadence: p95 frame time 17ms
minimap-topology-cadence: layout duration 2ms
minimap-topology-cadence: style recalc duration 2ms
minimap-topology-cadence: layout count 8
minimap-topology-cadence: style recalc count 9
minimap-topology-cadence: task duration 610ms
minimap-topology-cadence: script duration 243ms
minimap-topology-cadence: TBT 0ms
minimap-topology-cadence: heap used 83.6 MB
minimap-topology-cadence: DOM nodes 0
minimap-topology-cadence: event listeners 0
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 3ms
subgraph-dom-widget-clipping: style recalc duration 6ms
subgraph-dom-widget-clipping: layout count 10
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 328ms
subgraph-dom-widget-clipping: script duration 105ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 71.8 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 2ms
subgraph-idle: style recalc duration 2ms
subgraph-idle: layout count 9
subgraph-idle: style recalc count 10
subgraph-idle: task duration 347ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 60.1 MB
subgraph-idle: DOM nodes -100
subgraph-idle: event listeners -58
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 16ms
subgraph-mouse-sweep: layout count 10
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 675ms
subgraph-mouse-sweep: script duration 97ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 71.8 MB
subgraph-mouse-sweep: DOM nodes -96
subgraph-mouse-sweep: event listeners -54
subgraph-transition-enter: avg frame time 19ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 20ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 1041ms
subgraph-transition-enter: script duration 28ms
subgraph-transition-enter: TBT 123ms
subgraph-transition-enter: heap used 95.4 MB
subgraph-transition-enter: DOM nodes 19229
subgraph-transition-enter: event listeners 3566
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 2ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 10
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 4203ms
viewport-pan-sweep: script duration 1932ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 60.9 MB
viewport-pan-sweep: DOM nodes -274
viewport-pan-sweep: event listeners -67
vue-large-graph-idle: avg frame time 29ms
vue-large-graph-idle: p95 frame time 67ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16807ms
vue-large-graph-idle: script duration 240ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 263.6 MB
vue-large-graph-idle: DOM nodes -3482
vue-large-graph-idle: event listeners -661
vue-large-graph-pan: avg frame time 33ms
vue-large-graph-pan: p95 frame time 67ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 127
vue-large-graph-pan: task duration 17680ms
vue-large-graph-pan: script duration 712ms
vue-large-graph-pan: TBT 80ms
vue-large-graph-pan: heap used 261.2 MB
vue-large-graph-pan: DOM nodes -3482
vue-large-graph-pan: event listeners -659
vue-node-resize-workload: avg frame time 36ms
vue-node-resize-workload: p95 frame time 67ms
vue-node-resize-workload: layout duration 22ms
vue-node-resize-workload: style recalc duration 50ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6025ms
vue-node-resize-workload: script duration 88ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 256.1 MB
vue-node-resize-workload: DOM nodes -1919
vue-node-resize-workload: event listeners -334
vue-zoom-out-idle: avg frame time 29ms
vue-zoom-out-idle: p95 frame time 67ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8184ms
vue-zoom-out-idle: script duration 109ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 255.2 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 3ms
workflow-execution: style recalc duration 7ms
workflow-execution: layout count 7
workflow-execution: style recalc count 8
workflow-execution: task duration 66ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 60.3 MB
workflow-execution: DOM nodes 113
workflow-execution: event listeners 4
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 11ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 174ms
agent-composer-empty-conversation-typing: script duration 75ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 48.5 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 11ms
agent-composer-long-conversation-typing: style recalc duration 1ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 219ms
agent-composer-long-conversation-typing: script duration 72ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 92.7 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 292
Raw data
{
  "timestamp": "2026-11-02T21:06:36.904Z",
  "gitSha": "d0857849d4c1f760ec79f2f22eeb7d966e82110f",
  "branch": "architecture/mask-editor-entries",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2009.3430000000012,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.1510000000000002,
      "layouts": 9,
      "layoutDurationMs": 1.9929999999999999,
      "taskDurationMs": 349.21000000000004,
      "heapDeltaBytes": -3558112,
      "heapUsedBytes": 73711956,
      "domNodes": -178,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 6.495000000000001,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66528925619835,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "canvas-idle",
      "durationMs": 2009.7190000000182,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.637,
      "layouts": 10,
      "layoutDurationMs": 2.267,
      "taskDurationMs": 405.452,
      "heapDeltaBytes": -17611184,
      "heapUsedBytes": 60569552,
      "domNodes": -178,
      "jsHeapTotalBytes": 9175040,
      "scriptDurationMs": 9.1,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1676.3190000000066,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 11.777,
      "layouts": 9,
      "layoutDurationMs": 2.0559999999999996,
      "taskDurationMs": 628.338,
      "heapDeltaBytes": 23134476,
      "heapUsedBytes": 84650596,
      "domNodes": 0,
      "jsHeapTotalBytes": 3145728,
      "scriptDurationMs": 111.85999999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667326732673267,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1676.2839999999528,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 12.939000000000002,
      "layouts": 10,
      "layoutDurationMs": 2.508,
      "taskDurationMs": 603.3739999999999,
      "heapDeltaBytes": 255076,
      "heapUsedBytes": 61799648,
      "domNodes": 0,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 110.607,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665346534653462,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1709.9900000000048,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 4.4270000000000005,
      "layouts": 12,
      "layoutDurationMs": 2.592,
      "taskDurationMs": 306.004,
      "heapDeltaBytes": 7166324,
      "heapUsedBytes": 85976208,
      "domNodes": 57,
      "jsHeapTotalBytes": 9961472,
      "scriptDurationMs": 11.812,
      "eventListeners": 43,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666019417475727,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1725.6289999999694,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 5.304,
      "layouts": 13,
      "layoutDurationMs": 3.189,
      "taskDurationMs": 237.22199999999998,
      "heapDeltaBytes": 6977100,
      "heapUsedBytes": 85097576,
      "domNodes": 57,
      "jsHeapTotalBytes": 9961472,
      "scriptDurationMs": 11.521999999999998,
      "eventListeners": 43,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846153,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 526.8000000000086,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 3.1040000000000005,
      "layouts": 10,
      "layoutDurationMs": 2.615,
      "taskDurationMs": 346.34400000000005,
      "heapDeltaBytes": -15537536,
      "heapUsedBytes": 61932804,
      "domNodes": 0,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 113.051,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665625000000006,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 533.3459999999945,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 3.2070000000000003,
      "layouts": 9,
      "layoutDurationMs": 2.7419999999999995,
      "taskDurationMs": 349.49399999999997,
      "heapDeltaBytes": 9320196,
      "heapUsedBytes": 87816784,
      "domNodes": 0,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 113.00599999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665625000000006,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 908.4920000000238,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 560.5450000000001,
      "heapDeltaBytes": -10819632,
      "heapUsedBytes": 77483552,
      "domNodes": -208,
      "jsHeapTotalBytes": 20455424,
      "scriptDurationMs": 38.019999999999996,
      "eventListeners": -107,
      "totalBlockingTimeMs": 265,
      "frameDurationMs": 25.46111111111111,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 959.951999999987,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 597.564,
      "heapDeltaBytes": -10198284,
      "heapUsedBytes": 78327344,
      "domNodes": -208,
      "jsHeapTotalBytes": 20717568,
      "scriptDurationMs": 39.332,
      "eventListeners": -107,
      "totalBlockingTimeMs": 281,
      "frameDurationMs": 26.38888888888889,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 701.8579999999872,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 279.97,
      "heapDeltaBytes": -4164312,
      "heapUsedBytes": 86867968,
      "domNodes": 0,
      "jsHeapTotalBytes": 4984832,
      "scriptDurationMs": 91.96399999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 86,
      "frameDurationMs": 20.58529411764705,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 698.5599999999863,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 285.1149999999998,
      "heapDeltaBytes": -2258608,
      "heapUsedBytes": 65810348,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 94.171,
      "eventListeners": 0,
      "totalBlockingTimeMs": 92,
      "frameDurationMs": 20.585294117647074,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6767.973000000012,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.8619999999999999,
      "layouts": 3,
      "layoutDurationMs": 0.7529999999999998,
      "taskDurationMs": 5707.063,
      "heapDeltaBytes": 52633332,
      "heapUsedBytes": 134391292,
      "domNodes": -274,
      "jsHeapTotalBytes": 54390784,
      "scriptDurationMs": 4309.281999999999,
      "eventListeners": -69,
      "totalBlockingTimeMs": 88,
      "frameDurationMs": 20.7434250764526,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6565.469000000007,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.9659999999999999,
      "layouts": 3,
      "layoutDurationMs": 0.8290000000000003,
      "taskDurationMs": 5698.104,
      "heapDeltaBytes": 3714012,
      "heapUsedBytes": 92948444,
      "domNodes": -274,
      "jsHeapTotalBytes": 8253440,
      "scriptDurationMs": 4272.253999999999,
      "eventListeners": -69,
      "totalBlockingTimeMs": 46,
      "frameDurationMs": 22.879094076655054,
      "p95FrameDurationMs": 33.40000000000009
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6587.016000000005,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.2799999999999998,
      "layouts": 5,
      "layoutDurationMs": 1.1329999999999998,
      "taskDurationMs": 5529.866,
      "heapDeltaBytes": 43321384,
      "heapUsedBytes": 118690784,
      "domNodes": -274,
      "jsHeapTotalBytes": 51769344,
      "scriptDurationMs": 4134.609,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 20.193865030674843,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6555.478999999991,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 0.9849999999999998,
      "layouts": 4,
      "layoutDurationMs": 0.8930000000000001,
      "taskDurationMs": 5458.854,
      "heapDeltaBytes": 43380872,
      "heapUsedBytes": 118663656,
      "domNodes": -274,
      "jsHeapTotalBytes": 50458624,
      "scriptDurationMs": 4078.324,
      "eventListeners": -69,
      "totalBlockingTimeMs": 6,
      "frameDurationMs": 20.278018575851394,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "large-combo-open",
      "durationMs": 163.60800000001063,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 11.422999999999998,
      "layouts": 11,
      "layoutDurationMs": 2.718,
      "taskDurationMs": 119.055,
      "heapDeltaBytes": -5845348,
      "heapUsedBytes": 73128552,
      "domNodes": 936,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 6.683000000000001,
      "eventListeners": 205,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 20.837500000000034,
      "p95FrameDurationMs": 50
    },
    {
      "name": "large-combo-open",
      "durationMs": 136.7129999999861,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 10.587000000000003,
      "layouts": 12,
      "layoutDurationMs": 2.926,
      "taskDurationMs": 100.92800000000001,
      "heapDeltaBytes": 14705128,
      "heapUsedBytes": 91907404,
      "domNodes": 936,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 5.777,
      "eventListeners": 205,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.75,
      "p95FrameDurationMs": 33.40000000000009
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2024.548999999979,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.6169999999999995,
      "layouts": 8,
      "layoutDurationMs": 2.2399999999999998,
      "taskDurationMs": 570.492,
      "heapDeltaBytes": -20197484,
      "heapUsedBytes": 62437284,
      "domNodes": -274,
      "jsHeapTotalBytes": 3010560,
      "scriptDurationMs": 30.669999999999995,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664754098360653,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2025.63200000003,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.798,
      "layouts": 9,
      "layoutDurationMs": 2.41,
      "taskDurationMs": 439.662,
      "heapDeltaBytes": -14027848,
      "heapUsedBytes": 67994564,
      "domNodes": -274,
      "jsHeapTotalBytes": 3272704,
      "scriptDurationMs": 27.180000000000003,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665573770491804,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3050.5880000000047,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 10.963000000000001,
      "layouts": 7,
      "layoutDurationMs": 1.8519999999999999,
      "taskDurationMs": 1377.8839999999998,
      "heapDeltaBytes": 3070584,
      "heapUsedBytes": 87044720,
      "domNodes": -274,
      "jsHeapTotalBytes": 3497984,
      "scriptDurationMs": 636.007,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665573770491804,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2650.7290000000125,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 10.557,
      "layouts": 9,
      "layoutDurationMs": 2.142,
      "taskDurationMs": 1242.6819999999998,
      "heapDeltaBytes": -28180148,
      "heapUsedBytes": 62108688,
      "domNodes": -274,
      "jsHeapTotalBytes": 4882432,
      "scriptDurationMs": 568.7560000000001,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66582278481013,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3887.0860000000107,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 12.304,
      "layouts": 67,
      "layoutDurationMs": 12.437999999999999,
      "taskDurationMs": 1420.838,
      "heapDeltaBytes": 586568,
      "heapUsedBytes": 85735676,
      "domNodes": -250,
      "jsHeapTotalBytes": 3534848,
      "scriptDurationMs": 583.3960000000001,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666094420600857,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3436.546000000021,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 11.732000000000003,
      "layouts": 67,
      "layoutDurationMs": 11.450999999999999,
      "taskDurationMs": 1284.934,
      "heapDeltaBytes": -30928796,
      "heapUsedBytes": 61634036,
      "domNodes": -256,
      "jsHeapTotalBytes": 3309568,
      "scriptDurationMs": 537.8550000000001,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66601941747573,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3088.6150000000043,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 6.462999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.6150000000000002,
      "taskDurationMs": 1648.7839999999999,
      "heapDeltaBytes": -9740928,
      "heapUsedBytes": 80924876,
      "domNodes": 0,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 804.754,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666486486486487,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2506.965999999977,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 6.536,
      "layouts": 8,
      "layoutDurationMs": 2.053,
      "taskDurationMs": 1434.384,
      "heapDeltaBytes": -9455784,
      "heapUsedBytes": 77313556,
      "domNodes": 0,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 718.753,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.778,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-geometry-cadence",
      "durationMs": 2815.1269999999895,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.026,
      "layouts": 8,
      "layoutDurationMs": 1.8739999999999999,
      "taskDurationMs": 515.3190000000001,
      "heapDeltaBytes": 7615152,
      "heapUsedBytes": 80122868,
      "domNodes": -274,
      "jsHeapTotalBytes": 3534848,
      "scriptDurationMs": 233.90600000000003,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666272189349115,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-geometry-cadence",
      "durationMs": 2848.389999999995,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.0289999999999995,
      "layouts": 8,
      "layoutDurationMs": 1.723,
      "taskDurationMs": 540.581,
      "heapDeltaBytes": -17079684,
      "heapUsedBytes": 66931476,
      "domNodes": -274,
      "jsHeapTotalBytes": 4059136,
      "scriptDurationMs": 249.782,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66608187134503,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2035.7890000000225,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.275,
      "layouts": 9,
      "layoutDurationMs": 2.0340000000000003,
      "taskDurationMs": 419.92199999999997,
      "heapDeltaBytes": 6527764,
      "heapUsedBytes": 81908080,
      "domNodes": -274,
      "jsHeapTotalBytes": 3010560,
      "scriptDurationMs": 26.344,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2030.684000000008,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.5470000000000006,
      "layouts": 8,
      "layoutDurationMs": 2.065,
      "taskDurationMs": 517.218,
      "heapDeltaBytes": -7793028,
      "heapUsedBytes": 66167024,
      "domNodes": -274,
      "jsHeapTotalBytes": 3272704,
      "scriptDurationMs": 31.637999999999998,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666393442622947,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-progress-execution-cadence",
      "durationMs": 2678.613000000013,
      "styleRecalcs": 28,
      "styleRecalcDurationMs": 10.912999999999998,
      "layouts": 8,
      "layoutDurationMs": 1.7550000000000001,
      "taskDurationMs": 386.46000000000004,
      "heapDeltaBytes": 8197556,
      "heapUsedBytes": 92838904,
      "domNodes": 19,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 135.71999999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66521739130435,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-progress-execution-cadence",
      "durationMs": 2680.39600000003,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 10.642000000000001,
      "layouts": 10,
      "layoutDurationMs": 1.906,
      "taskDurationMs": 366.788,
      "heapDeltaBytes": -18706652,
      "heapUsedBytes": 72872272,
      "domNodes": 19,
      "jsHeapTotalBytes": 3969024,
      "scriptDurationMs": 127.854,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66645962732919,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-topology-cadence",
      "durationMs": 2940.224999999998,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.0300000000000007,
      "layouts": 8,
      "layoutDurationMs": 1.7289999999999999,
      "taskDurationMs": 598.1339999999999,
      "heapDeltaBytes": -15739548,
      "heapUsedBytes": 75573528,
      "domNodes": 0,
      "jsHeapTotalBytes": 6590464,
      "scriptDurationMs": 236.69700000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666477272727274,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-topology-cadence",
      "durationMs": 2955.775000000017,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.1539999999999995,
      "layouts": 8,
      "layoutDurationMs": 1.797,
      "taskDurationMs": 622.2840000000001,
      "heapDeltaBytes": 8503456,
      "heapUsedBytes": 99719984,
      "domNodes": 0,
      "jsHeapTotalBytes": 5804032,
      "scriptDurationMs": 248.961,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 514.5380000000159,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 5.980999999999999,
      "layouts": 10,
      "layoutDurationMs": 2.644,
      "taskDurationMs": 337.02,
      "heapDeltaBytes": -4130728,
      "heapUsedBytes": 65162572,
      "domNodes": 0,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 106.389,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667741935483864,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 464.821000000029,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 5.481999999999999,
      "layouts": 10,
      "layoutDurationMs": 2.4650000000000003,
      "taskDurationMs": 318.197,
      "heapDeltaBytes": 6746636,
      "heapUsedBytes": 85340280,
      "domNodes": 0,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 104.06099999999999,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667857142857144,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2009.9019999999825,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.299,
      "layouts": 9,
      "layoutDurationMs": 1.95,
      "taskDurationMs": 322.249,
      "heapDeltaBytes": 8745736,
      "heapUsedBytes": 70682236,
      "domNodes": 0,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 6.805000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66528925619835,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2026.028999999994,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.409,
      "layouts": 9,
      "layoutDurationMs": 2.1780000000000004,
      "taskDurationMs": 372.535,
      "heapDeltaBytes": -8071996,
      "heapUsedBytes": 55358620,
      "domNodes": -200,
      "jsHeapTotalBytes": 2883584,
      "scriptDurationMs": 6.587999999999998,
      "eventListeners": -116,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665573770491804,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1678.5700000000077,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 16.247,
      "layouts": 10,
      "layoutDurationMs": 3.1919999999999997,
      "taskDurationMs": 693.7639999999999,
      "heapDeltaBytes": 23138228,
      "heapUsedBytes": 85398840,
      "domNodes": 0,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 103.021,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666336633663366,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1710.6829999999604,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 15.719000000000001,
      "layouts": 10,
      "layoutDurationMs": 2.583,
      "taskDurationMs": 655.867,
      "heapDeltaBytes": -14383672,
      "heapUsedBytes": 65280184,
      "domNodes": -192,
      "jsHeapTotalBytes": 9175040,
      "scriptDurationMs": 91.109,
      "eventListeners": -114,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666990291262138,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1385.2990000000318,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 19.953,
      "layouts": 5,
      "layoutDurationMs": 12.020999999999997,
      "taskDurationMs": 1041.0319999999997,
      "heapDeltaBytes": 18211684,
      "heapUsedBytes": 100027016,
      "domNodes": 19229,
      "jsHeapTotalBytes": 9961472,
      "scriptDurationMs": 28.452999999999992,
      "eventListeners": 3566,
      "totalBlockingTimeMs": 123,
      "frameDurationMs": 19.17671232876713,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8527.100000000019,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 35.382000000000005,
      "layouts": 10,
      "layoutDurationMs": 2.302,
      "taskDurationMs": 4183.467000000001,
      "heapDeltaBytes": -19429292,
      "heapUsedBytes": 63420348,
      "domNodes": -274,
      "jsHeapTotalBytes": 4845568,
      "scriptDurationMs": 1931.889,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666015625,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8742.876000000024,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 35.429,
      "layouts": 9,
      "layoutDurationMs": 2.2760000000000002,
      "taskDurationMs": 4222.014000000001,
      "heapDeltaBytes": -18304088,
      "heapUsedBytes": 64246992,
      "domNodes": -274,
      "jsHeapTotalBytes": 4845568,
      "scriptDurationMs": 1932.97,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66590476190476,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17531.138,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16963.754999999997,
      "heapDeltaBytes": -34303532,
      "heapUsedBytes": 264604784,
      "domNodes": -3482,
      "jsHeapTotalBytes": 15974400,
      "scriptDurationMs": 258.329,
      "eventListeners": -661,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 29.417114093959736,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17312.03800000003,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16650.662,
      "heapDeltaBytes": -2028284,
      "heapUsedBytes": 288118744,
      "domNodes": -3482,
      "jsHeapTotalBytes": 253952,
      "scriptDurationMs": 220.946,
      "eventListeners": -661,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 29.571452991452997,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20089.86100000004,
      "styleRecalcs": 155,
      "styleRecalcDurationMs": 20.50400000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19678.398999999998,
      "heapDeltaBytes": -13912796,
      "heapUsedBytes": 270046540,
      "domNodes": -3482,
      "jsHeapTotalBytes": 12832768,
      "scriptDurationMs": 700.0000000000001,
      "eventListeners": -659,
      "totalBlockingTimeMs": 17,
      "frameDurationMs": 36.78095238095238,
      "p95FrameDurationMs": 66.80000000000109
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16184.423999999979,
      "styleRecalcs": 99,
      "styleRecalcDurationMs": 14.649999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15681.276000000002,
      "heapDeltaBytes": -19727796,
      "heapUsedBytes": 277783976,
      "domNodes": -3482,
      "jsHeapTotalBytes": 17293312,
      "scriptDurationMs": 724.7860000000001,
      "eventListeners": -659,
      "totalBlockingTimeMs": 142,
      "frameDurationMs": 28.883807829181496,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6386.755999999991,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 59.83699999999999,
      "layouts": 20,
      "layoutDurationMs": 23.313999999999986,
      "taskDurationMs": 6263.505,
      "heapDeltaBytes": -29892872,
      "heapUsedBytes": 267645296,
      "domNodes": -3482,
      "jsHeapTotalBytes": 22798336,
      "scriptDurationMs": 91.134,
      "eventListeners": -661,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 36.68448275862069,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5864.503999999897,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 39.626,
      "layouts": 20,
      "layoutDurationMs": 20.995,
      "taskDurationMs": 5786.554000000001,
      "heapDeltaBytes": -20414220,
      "heapUsedBytes": 269465188,
      "domNodes": -356,
      "jsHeapTotalBytes": 29872128,
      "scriptDurationMs": 83.99000000000001,
      "eventListeners": -7,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 35.128143712574854,
      "p95FrameDurationMs": 66.80000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8505.47800000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8245.859,
      "heapDeltaBytes": -27713680,
      "heapUsedBytes": 261439068,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 113.22100000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 28.427090301003346,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8403.680999999891,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8122.445999999998,
      "heapDeltaBytes": 6419752,
      "heapUsedBytes": 273782964,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 104.59400000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 28.76575342465753,
      "p95FrameDurationMs": 66.59999999999854
    },
    {
      "name": "workflow-execution",
      "durationMs": 93.34400000000187,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.201,
      "layouts": 7,
      "layoutDurationMs": 2.127,
      "taskDurationMs": 73.426,
      "heapDeltaBytes": -12720220,
      "heapUsedBytes": 62424556,
      "domNodes": 101,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 7.439000000000001,
      "eventListeners": 3,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.650000000000016,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "workflow-execution",
      "durationMs": 92.31599999998252,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.901,
      "layouts": 7,
      "layoutDurationMs": 3.151,
      "taskDurationMs": 57.611,
      "heapDeltaBytes": -12136472,
      "heapUsedBytes": 64000636,
      "domNodes": 124,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 3.5769999999999995,
      "eventListeners": 5,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 213.5000000000673,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.578,
      "layouts": 76,
      "layoutDurationMs": 10.641,
      "taskDurationMs": 171.994,
      "heapDeltaBytes": 9794312,
      "heapUsedBytes": 52974476,
      "domNodes": 4,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 71.877,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669230769230754,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 224.4510000000446,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.589,
      "layouts": 76,
      "layoutDurationMs": 10.788,
      "taskDurationMs": 176.622,
      "heapDeltaBytes": 9906156,
      "heapUsedBytes": 48676164,
      "domNodes": 4,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 77.33500000000001,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66923076923079,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 245.1419999999871,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.2409999999999999,
      "layouts": 76,
      "layoutDurationMs": 10.297,
      "taskDurationMs": 214.187,
      "heapDeltaBytes": -1656032,
      "heapUsedBytes": 95373444,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 69.848,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 252.4670000000242,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.266,
      "layouts": 76,
      "layoutDurationMs": 11.02,
      "taskDurationMs": 223.083,
      "heapDeltaBytes": -1652924,
      "heapUsedBytes": 99063184,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 74.395,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.67500000000001,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage: 🟡 59.4% of lines

Coverage totals
Metric Covered Total Pct
Lines 61785 104023 59.4% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1179
src/workbench/extensions/agent/composables/agent/useAgentSession.ts 12.0% 980
src/workbench/extensions/agent/crdt/liveGraphApplier.ts 2.1% 730
src/workbench/extensions/agent/stores/agent/agentConversationStore.ts 12.1% 646
src/workbench/extensions/agent/AgentPanelRoot.vue 26.9% 610
src/workbench/extensions/agent/crdt/docOpMinter.ts 4.3% 425
src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts 26.1% 379
src/LGraphNode.ts 71.4% 377
src/platform/billing/stores/billingOperationStore.ts 9.3% 333
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 39.6% 332

🎭 Playwright: ✅ 3215 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2352 / ❌ 0 / ⚠️ 2 / ⏭️ 0)
  • chromium-2x: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 827 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • desktop: View Report (✅ 9 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 11/02/2026, 08:58:27 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Full docs: scripts/registry-census/README.md

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

🌾 Fallow: ✅ Passed

Findings and check details

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Full docs: ADR-DEVEX-LINT-0015

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since f0bb56c1a1010046e05ce74264a9bb4849593f23

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (350)

  • billing path matches no source files: src/platform/billing/composables/activateBillingScope.testUtils.ts. Remove or update it in docs/architecture/domains/records/billing.domain.json.
  • error-handling path matches no source files: src/utils/errorUtil.ts. Remove or update it in docs/architecture/domains/records/error-handling.domain.json.
  • graph-model path matches no source files: src/types/linkTopology.ts. Remove or update it in docs/architecture/domains/records/graph-model.domain.json.
  • graph-model path matches no source files: src/types/nodeState.ts. Remove or update it in docs/architecture/domains/records/graph-model.domain.json.
  • job-queue path matches no source files: src/platform/remote/comfyui/jobs/**. Remove or update it in docs/architecture/domains/records/job-queue.domain.json.
  • linear-mode path matches no source files: src/utils/appMode.ts. Remove or update it in docs/architecture/domains/records/linear-mode.domain.json.
  • link-connection path matches no source files: src/lib/litegraph/src/infrastructure/LinkConnectorEventMap.ts. Remove or update it in docs/architecture/domains/records/link-connection.domain.json.
  • node-widgets path matches no source files: src/types/widgetState.ts. Remove or update it in docs/architecture/domains/records/node-widgets.domain.json.
  • subgraphs path matches no source files: src/lib/litegraph/src/infrastructure/SubgraphEventMap.ts. Remove or update it in docs/architecture/domains/records/subgraphs.domain.json.
  • vue-node-widgets path matches no source files: src/types/positionConfig.ts. Remove or update it in docs/architecture/domains/records/vue-node-widgets.domain.json.
  • workspace path matches no source files: src/platform/workspace/fixtures/**. Remove or update it in docs/architecture/domains/records/workspace.domain.json.
  • packages/api-client/src/abortSignal.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/abortSignal.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchRouteTemplate.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchWithRetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchWithRetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/retryPolicy.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/retryPolicy.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/statusRetryTelemetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/statusRetryTelemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/formatUtil.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/formatUtil.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/geometry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/loadExternalScript.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/networkUtil.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/telemetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/telemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/urlSafety.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/urlSafety.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/tailwind-utils/src/index.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/TopbarActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatClipStrip.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatClipTile.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPanel.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPanel.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPlaybackBar.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/WidgetVideoConcat.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/WidgetVideoConcat.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/__fixtures__/clipTiles.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionActions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionActions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionNotices.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionNotices.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentSidebarTabs.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 300 more

Full docs: Frontend domain catalog

Reproduce locally
pnpm architecture:check

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Nov 2, 2026
@codecov

codecov Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/utils/imageUtil.ts 33.33% 6 Missing ⚠️
@@                     Coverage Diff                      @@
##           architecture/remove-roles   #22738     +/-   ##
============================================================
  Coverage                      87.48%   87.49%             
============================================================
  Files                           2886     2886             
  Lines                         159187   159184      -3     
  Branches                       40599    42625   +2026     
============================================================
+ Hits                          139270   139275      +5     
+ Misses                         19157    19149      -8     
  Partials                         760      760             
Flag Coverage Δ
e2e 59.39% <75.00%> (+0.01%) ⬆️
unit 86.71% <22.22%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/builder/useLoaderDropIndicator.ts 96.15% <ø> (ø)
...ions/maskEditor/composables/useMaskEditorLoader.ts 88.05% <ø> (+2.93%) ⬆️
src/utils/imageUtil.ts 62.50% <33.33%> (-6.74%) ⬇️

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL DrJKL added the ddd Domain-driven design; included in the Gordian Knot domain views label Nov 2, 2026
@mrseek-reviews

mrseek-reviews Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Superseded by #22744, which combines the six deep-import fixes (#22738–#22743) into one PR stacked on #22733 with boundaries.json regenerated once. This fix is carried over unchanged.

@DrJKL DrJKL closed this Nov 2, 2026
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Nov 3, 2026
…entries (Comfy-Org#22744)

## Summary

Routes the deep imports into the six enforced domains through public
entry points. Follows Comfy-Org#22733, now on `main`. This replaces Comfy-Org#22738,
Comfy-Org#22739, Comfy-Org#22740, Comfy-Org#22741, Comfy-Org#22742 and Comfy-Org#22743, with `boundaries.json`
regenerated once for the whole set.

Boundary violations go from 40 on `main` to 2. Both remaining violations
are Fallow false positives (see below).

## mask-editor (11 → 1)

- New public entry points, each cited by a characterization scenario:
- `src/extensions/core/maskeditor.ts` and
`src/extensions/core/clipspace.ts`: the core extension seam that
`extensions/core/index.ts` registers (`index.test.ts`,
`maskeditor.test.ts`).
- `src/renderer/extensions/maskEditor/composables/useMaskEditor.ts`:
opening the editor from app mode and Vue node previews
(`useMaskEditor.test.ts`).
- `src/scripts/clipspace.ts`: the clipspace state that `ComfyApp`,
`changeTracker` and `litegraphService` share (`clipspace.test.ts`).
- `@comfyorg/mask-editor/maskEditorStore`: undo and redo from core
commands (`maskEditorStore.test.ts`).
- `@comfyorg/mask-editor/StrokeProcessor` and `brushUtils`: the stroke
engine the painter reuses (`StrokeProcessor.test.ts`,
`brushUtils.test.ts`).
- `extractWidgetStringValue` moves from `useMaskEditorLoader` to
`src/utils/imageUtil.ts`, next to `parseImageWidgetValue`. It reads a
generic image widget value, and the app-mode loader drop indicator
imported mask-editor internals only to get it.

## image-compositor (11 → 1)

- The record declares as `publicEntryPoints` the seams its consumers
already use. These are the core extensions, the LiteGraph
`CompositorWidget`, the Vue-node `useCompositorWidget` adapter and
`WidgetCompositor.vue`, and the layer editor's `useLayerEditor` and
`layerEditorDialogKey`. They also include `@comfyorg/layer-editor/mode`
and `/node`, which graph-model imports for the `BlendFn` and `Transform`
types.
- The record's compatibility promises already name the core extension,
the Vue-node adapter and the LiteGraph widget as host integration seams.
- A new characterization scenario cites `index.test.ts` and
`richWidgetPanelVisibility.test.ts`. The engine scenario now also cites
`packages/layer-editor/src/node.test.ts`.

## image-compare (6 → 0), painter (6 → 0)

- Each record declares as `publicEntryPoints` the host integration seams
its compatibility promises already name: the core extension, the
LiteGraph widget, the Vue-node adapter, and the `Widget*.vue` component
the widget registry loads.
- Each record gets a new characterization scenario that cites
`index.test.ts` and `richWidgetPanelVisibility.test.ts`.

## image-crop (5 → 0)

- The record declares the core extension `imageCrop.ts`, the LiteGraph
`ImageCropWidget.ts`, `WidgetImageCrop.vue` and `useImageCrop.ts` as
public entry points.
- `useImageCrop.ts` is public because video-edit's `useCropRatioLock`
reuses its `ASPECT_RATIOS`, so video crop offers the same ratios as
image crop. `useImageCrop.test.ts` already characterizes the composable.
- A new scenario cites `index.test.ts` and `useCropRatioLock.test.ts`.

## account (1 → 0)

- `src/platform/account/composables/__mocks__/useWorkspaceDialogs.ts`
joins `publicEntryPoints`.
- `CurrentUserButton.test.ts` mocks the public `useWorkspaceDialogs`
entry through its public specifier. Vitest then loads the sibling
`__mocks__` file, and Fallow records that file as the import target.
Seven account tests and this external test share the double, and
`vi.mockObject<WorkspaceDialogs>` type-checks it against the real
composable.

## Remaining false positives

- `src/extensions/core/index.test.ts` → `maskeditor.test.ts`
- `src/extensions/core/index.test.ts` → `imageCompositor.test.ts`

`index.test.ts` loads the core extensions with `import.meta.glob` and
excludes `*.test.ts` with negative patterns. Vite applies those
patterns, but Fallow ignores them, so it reports imports of every test
file in the directory. Neither edge is suppressed. They stay until
Fallow supports negative globs.

## Verification

- `architecture --update` leaves no diff, and `--check` passes. The
warnings are the same as on `main`.
- `fallow dead-code` reports 2 boundary violations, down from 40 on
`main`.
- Tests pass for tools/architecture, the builder, mask-editor
composables and `imageUtil`.
- Typecheck, eslint, oxfmt and the pre-push hook pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ddd Domain-driven design; included in the Gordian Knot domain views risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants