Skip to content

docs: say which workflow publishes the frontend to PyPI - #22703

Merged
christian-byrne merged 2 commits into
mainfrom
docs/release-pypi-owner
Nov 3, 2026
Merged

christian-byrne merged 2 commits into
mainfrom
docs/release-pypi-owner

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

docs/release-process.md says a merged Release PR publishes to PyPI. It doesn't: release-draft-create.yaml has no PyPI step. Stable PyPI versions come only from release-weekly-comfyui.yaml (its publish-pypi job), and .devN builds from release-pypi-dev.yaml.

Seen on Nov 1: v1.57.7 was released through its Release PR (#22385) and is on GitHub Releases, but not on PyPI. v1.58.4, the version the weekly workflow targeted, is on PyPI.

Docs only.

@christian-byrne
christian-byrne requested a review from a team November 2, 2026 07:50
@mrseek-reviews
mrseek-reviews Bot requested a review from DrJKL November 2, 2026 07:50
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 303b239 and ce88e52.

Files selected for processing: 1
  • docs/release-process.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.

Walkthrough

The release-process documentation updates the outputs attributed to the draft publishing workflow and clarifies the roles of the weekly and development PyPI workflows.

Changes: Release publishing documentation

Layer / File(s) Summary
Publishing workflow responsibilities
docs/release-process.md
The documentation assigns GitHub Releases and npm publishing to release-draft-create.yaml, stable PyPI publishing to release-weekly-comfyui.yaml, and .devN builds from the dispatched ref to release-pypi-dev.yaml. It also documents when a patch on another release line appears on PyPI and updates the workflow table.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related PRs

Suggested labels: size:XS

Suggested reviewers: huang47

Merge Risk: Minimal · up to ce88e

No actionable merge-blocking risk remains for this documentation-only change.

Pre-merge checks: Passed 6
Check name Status Explanation
Title check Passed The title is concise, specific, and accurately identifies the documentation change about which workflow publishes the frontend to PyPI.
Description check Passed The description includes a clear Summary with the problem, corrected workflow behavior, and a concrete example. It omits the Verification section, but the description is otherwise complete for a docum…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
End-To-End Test Suggestion For User-Facing Changes Passed The PR changes only docs/release-process.md and documents release workflows. It does not change the frontend application under src/ or packages/. This check explicitly passes documentation-only …
Adr Compliance For Entity/Litegraph Changes Passed The changed-file list contains only docs/release-process.md. It does not include src/lib/litegraph/, src/ecs/, or graph-entity files, so this check does not apply.
Full details: Description check

Explanation

The description includes a clear Summary with the problem, corrected workflow behavior, and a concrete example. It omits the Verification section, but the description is otherwise complete for a documentation-only change.

Full details: End-To-End Test Suggestion For User-Facing Changes

Explanation

The PR changes only docs/release-process.md and documents release workflows. It does not change the frontend application under src/ or packages/. This check explicitly passes documentation-only changes.

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Full docs: scripts/registry-census/README.md

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

🌾 Fallow: ✅ Passed

Findings and check details

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Full docs: ADR-DEVEX-LINT-0015

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since aa8c1610ac7e3ef8e4008a4a66188afc02b68f12

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (350)

  • billing path matches no source files: src/platform/billing/composables/activateBillingScope.testUtils.ts. Remove or update it in docs/architecture/domains/records/billing.domain.json.
  • error-handling path matches no source files: src/utils/errorUtil.ts. Remove or update it in docs/architecture/domains/records/error-handling.domain.json.
  • graph-model path matches no source files: src/types/linkTopology.ts. Remove or update it in docs/architecture/domains/records/graph-model.domain.json.
  • graph-model path matches no source files: src/types/nodeState.ts. Remove or update it in docs/architecture/domains/records/graph-model.domain.json.
  • job-queue path matches no source files: src/platform/remote/comfyui/jobs/**. Remove or update it in docs/architecture/domains/records/job-queue.domain.json.
  • linear-mode path matches no source files: src/utils/appMode.ts. Remove or update it in docs/architecture/domains/records/linear-mode.domain.json.
  • link-connection path matches no source files: src/lib/litegraph/src/infrastructure/LinkConnectorEventMap.ts. Remove or update it in docs/architecture/domains/records/link-connection.domain.json.
  • node-widgets path matches no source files: src/types/widgetState.ts. Remove or update it in docs/architecture/domains/records/node-widgets.domain.json.
  • subgraphs path matches no source files: src/lib/litegraph/src/infrastructure/SubgraphEventMap.ts. Remove or update it in docs/architecture/domains/records/subgraphs.domain.json.
  • vue-node-widgets path matches no source files: src/types/positionConfig.ts. Remove or update it in docs/architecture/domains/records/vue-node-widgets.domain.json.
  • workspace path matches no source files: src/platform/workspace/fixtures/**. Remove or update it in docs/architecture/domains/records/workspace.domain.json.
  • packages/api-client/src/abortSignal.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/abortSignal.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchRouteTemplate.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchWithRetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchWithRetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/retryPolicy.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/retryPolicy.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/statusRetryTelemetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/statusRetryTelemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/formatUtil.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/formatUtil.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/geometry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/loadExternalScript.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/networkUtil.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/telemetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/telemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/urlSafety.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/urlSafety.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/tailwind-utils/src/index.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/TopbarActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatClipStrip.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatClipTile.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPanel.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPanel.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPlaybackBar.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/WidgetVideoConcat.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/WidgetVideoConcat.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/__fixtures__/clipTiles.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionActions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionActions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionNotices.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionNotices.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentSidebarTabs.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 300 more

Full docs: Frontend domain catalog

Reproduce locally
pnpm architecture:check

@coderabbitai coderabbitai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fix comments: Fix CodeRabbit comments on this PR

Comment thread docs/release-process.md Resolved
Comment thread docs/release-process.md Resolved
Comment thread docs/release-process.md Resolved
@github-actions github-actions Bot added the risk:medium PR risk grade (advisory shadow check; grader-owned) label Nov 2, 2026
@comfy-greenlight-bot

comfy-greenlight-bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Swarmhost agentic review

The detailed evaluation is available to employees in the internal Slack review thread.

Evaluation budget remaining for this pull request: 97 automatic and 99 manual.

Updated by Swarmhost's agentic review process.

@comfy-greenlight-bot comfy-greenlight-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request at head commit ce88e52 has been reviewed and approved by Swarmhost's agentic review process.

The detailed evaluation is available to employees in the internal Slack review thread.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked each claim against the workflows on this head:

  • release-draft-create.yaml has no PyPI step. It uploads dist.zip and dist-desktop.zip to GitHub Releases and runs publish_types for npm, which matches the new paragraph and table row.
  • release-weekly-comfyui.yaml owns the publish-pypi job (cron Monday 20:00 UTC plus workflow_dispatch).
  • release-pypi-dev.yaml is workflow_dispatch-only and publishes from the dispatched ref.

The v1.57.7 vs v1.58.4 example in the description is consistent with that split.

nit-pick (non-blocking): "A patch released through a Release PR on any other line" could say "on a line the weekly run doesn't target", so readers don't have to work out what "other" refers to. Separately, release-draft-create.yaml:61 still has a comment calling dist.zip the "default release artifact for core/PyPI". That might be worth a follow-up so the workflow and the doc don't disagree.

Docs only, CI green. LGTM.

Comment thread docs/release-process.md
Comment on lines 197 to 205
| Workflow | Purpose |
| -------------------------------- | ------------------------------------------------ |
| `release-version-bump.yaml` | Bump version, create Release PR |
| `release-draft-create.yaml` | Build + publish to GitHub/PyPI/npm |
| `release-draft-create.yaml` | Build + publish to GitHub Releases/npm |
| `release-branch-create.yaml` | Create `core/` + `cloud/` branches (minor/major) |
| `release-weekly-comfyui.yaml` | Weekly auto-patch + ComfyUI requirements PR |
| `release-weekly-comfyui.yaml` | Auto-patch, PyPI publish, ComfyUI pin PR |
| `pr-backport.yaml` | Cherry-pick fixes to stable branches |
| `cloud-backport-tag.yaml` | Tag cloud branch merges |
| `pr-assign-release-sheriff.yaml` | Assign the sheriff to backport/release/bot PRs |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think tables like this are more of a maintenance burden and opportunity to mislead than they are worth.

Comment thread docs/release-process.md
Comment on lines +174 to +179
Stable PyPI versions of `comfyui-frontend-package` are published only by
`release-weekly-comfyui.yaml`, for the version each run targets
(`release-pypi-dev.yaml` publishes `.devN` builds from the ref it is
dispatched on, normally `main`). A patch
released through a `Release` PR on any other line is on GitHub Releases but not
on PyPI until that workflow runs for it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmm, flowchart maybe?

@DrJKL DrJKL removed their assignment Nov 2, 2026
@christian-byrne
christian-byrne added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit 92c8b0e Nov 3, 2026
80 checks passed
@christian-byrne
christian-byrne deleted the docs/release-pypi-owner branch November 3, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

greenlight risk:medium PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants