Repository navigation
docs: say which workflow publishes the frontend to PyPI - #22703
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Publishing workflow responsibilities docs/release-process.md |
The documentation assigns GitHub Releases and npm publishing to release-draft-create.yaml, stable PyPI publishing to release-weekly-comfyui.yaml, and .devN builds from the dispatched ref to release-pypi-dev.yaml. It also documents when a patch on another release line appears on PyPI and updates the workflow table. |
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Other
Possibly related PRs
- Comfy-Org/ComfyUI_frontend#22329: Changes the weekly ComfyUI release flow and documents patch-release behavior.
Suggested labels: size:XS
Suggested reviewers: huang47
Merge Risk: 
Minimal · up to ce88e
-
No actionable merge-blocking risk remains for this documentation-only change.
Pre-merge checks: 
6
-
Full details: Description check
-
Explanation
The description includes a clear Summary with the problem, corrected workflow behavior, and a concrete example. It omits the Verification section, but the description is otherwise complete for a documentation-only change.
Full details: End-To-End Test Suggestion For User-Facing Changes
-
Explanation
The PR changes only
docs/release-process.mdand documents release workflows. It does not change the frontend application undersrc/orpackages/. This check explicitly passes documentation-only changes.
-
Finishing Touches
-
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since aa8c1610ac7e3ef8e4008a4a66188afc02b68f12
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (350)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 97 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit ce88e52 has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
dante01yoon
left a comment
There was a problem hiding this comment.
Checked each claim against the workflows on this head:
release-draft-create.yamlhas no PyPI step. It uploadsdist.zipanddist-desktop.zipto GitHub Releases and runspublish_typesfor npm, which matches the new paragraph and table row.release-weekly-comfyui.yamlowns thepublish-pypijob (cron Monday 20:00 UTC plusworkflow_dispatch).release-pypi-dev.yamlisworkflow_dispatch-only and publishes from the dispatched ref.
The v1.57.7 vs v1.58.4 example in the description is consistent with that split.
nit-pick (non-blocking): "A patch released through a Release PR on any other line" could say "on a line the weekly run doesn't target", so readers don't have to work out what "other" refers to. Separately, release-draft-create.yaml:61 still has a comment calling dist.zip the "default release artifact for core/PyPI". That might be worth a follow-up so the workflow and the doc don't disagree.
Docs only, CI green. LGTM.
| | Workflow | Purpose | | ||
| | -------------------------------- | ------------------------------------------------ | | ||
| | `release-version-bump.yaml` | Bump version, create Release PR | | ||
| | `release-draft-create.yaml` | Build + publish to GitHub/PyPI/npm | | ||
| | `release-draft-create.yaml` | Build + publish to GitHub Releases/npm | | ||
| | `release-branch-create.yaml` | Create `core/` + `cloud/` branches (minor/major) | | ||
| | `release-weekly-comfyui.yaml` | Weekly auto-patch + ComfyUI requirements PR | | ||
| | `release-weekly-comfyui.yaml` | Auto-patch, PyPI publish, ComfyUI pin PR | | ||
| | `pr-backport.yaml` | Cherry-pick fixes to stable branches | | ||
| | `cloud-backport-tag.yaml` | Tag cloud branch merges | | ||
| | `pr-assign-release-sheriff.yaml` | Assign the sheriff to backport/release/bot PRs | |
There was a problem hiding this comment.
I still think tables like this are more of a maintenance burden and opportunity to mislead than they are worth.
| Stable PyPI versions of `comfyui-frontend-package` are published only by | ||
| `release-weekly-comfyui.yaml`, for the version each run targets | ||
| (`release-pypi-dev.yaml` publishes `.devN` builds from the ref it is | ||
| dispatched on, normally `main`). A patch | ||
| released through a `Release` PR on any other line is on GitHub Releases but not | ||
| on PyPI until that workflow runs for it. |
Summary
docs/release-process.mdsays a mergedReleasePR publishes to PyPI. It doesn't:release-draft-create.yamlhas no PyPI step. Stable PyPI versions come only fromrelease-weekly-comfyui.yaml(itspublish-pypijob), and.devNbuilds fromrelease-pypi-dev.yaml.Seen on Nov 1: v1.57.7 was released through its
ReleasePR (#22385) and is on GitHub Releases, but not on PyPI. v1.58.4, the version the weekly workflow targeted, is on PyPI.Docs only.