Repository navigation
Conversation
Bytes appended after IEND were read as another chunk header. A 1-3 byte tail made getUint32 throw a RangeError, rejecting the whole parse and dropping the workflow already read. IEND is the last chunk by spec, so the loop now ends there.
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Stop parsing at IEND src/scripts/metadata/png.ts, src/scripts/metadata/png.test.ts |
The parser exits the chunk scan at IEND. Parameterized tests verify that workflow metadata remains in the result when one to three bytes follow the chunk. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix · Severity of issue fixed: Medium
Possibly related PRs
- Comfy-Org/ComfyUI_frontend#22690: Both changes define PNG parser boundaries in
getFromPngBuffer. This PR adds theIENDstop condition alongside the related handling of text chunks and truncated data. - Comfy-Org/ComfyUI_frontend#21983: Both changes address truncated PNG parsing behavior. This PR preserves rejection when truncation occurs before
IEND.
Suggested reviewers: drjkl
Merge Risk: 
Minimal · up to 4c2dc
-
The change safely stops parsing at IEND and includes regression coverage for trailing bytes.
Pre-merge checks: 
5 · 
1
-
Failed checks: 1 warning Passed checks: 5 passed-
Full details: Description check
-
Explanation
The description explains the problem, the resulting behavior, the preserved truncation behavior, the test coverage, and the linked issue. It does not use the required Verification heading, but it includes the relevant verification details and is otherwise complete.
Full details: Linked Issues check
-
Explanation
Issue
#22691requires that getFromPngBuffer stop chunk parsing at IEND, so bytes after IEND are not read, and that files truncated before IEND keep rejecting. At head, src/scripts/metadata/png.ts containsif (type === 'IEND') breakin the chunk loop, before the chunkEnd bounds check and before any further offset read. Bytes after IEND are therefore never parsed. The truncated-header case is unchanged: with only the signature plus one byte, the loop reads dataView.getUint32(8) and throws RangeError, which the existing test 'rejects rather than never settling when a chunk header is truncated' pins. The new table test in src/scripts/metadata/png.test.ts ('keeps the metadata when a %i-byte tail follows the IEND chunk', lengths 1, 2, 3) builds a valid tEXt chunk, an IEND chunk, and a trailing tail, then asserts the workflow is returned. This covers the reported failure. The PR summary states that this test fails on the parent branch with the reported RangeError; that claim was not independently re-run. Base file blobs were not readable, so the exact base-to-head diff was not read directly. The requirement is judged from the head source, which satisfies it.
Full details: Out of Scope Changes check
-
Explanation
The whole-PR summary lists two changed files. In src/scripts/metadata/png.ts (+2 lines), the change is the IEND break that
#22691requests. In src/scripts/metadata/png.test.ts (+17 lines), the change is the new regression table test for 1-3 trailing bytes after IEND. This test directly exercises the requested behavior. No other changed hunks were reported. The other chunk-handling code at head (keyword termination, chunkEnd bounds check, iTXt decompression) is existing code from the merge base chain, not a change introduced here. The base blob could not be read, so the exact file list was taken from the supplied summary. No unrelated change was identified.
Full details: Adr Compliance For Entity/Litegraph Changes
-
Explanation
The changed files are
src/scripts/metadata/png.tsandsrc/scripts/metadata/png.test.ts. They are not undersrc/lib/litegraph/,src/ecs/, and are not graph-entity files. The ADR compliance check does not apply.
-
Full details: End-To-End Test Suggestion For User-Facing Changes
-
Explanation
The diff fixes a user-facing PNG workflow import bug in
src/scripts/metadata/png.ts: a PNG with valid workflow metadata and 1–3 bytes afterIENDpreviously failed to import. The PR adds a unit test, but it does not add or update a spec underbrowser_tests/. This is a suggestion, not a merge requirement.Resolution
Add an end-to-end test under
browser_tests/for importing a PNG with workflow metadata and trailing bytes afterIEND: - Create or provide a PNG with valid workflow metadata and trailing bytes. - Import the PNG through the user-facing workflow import flow. - Expect the workflow metadata to remain available after import.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
📦 Bundle: 12 MB gzipDetailsSummary
Category Glance App Entry Points — 6.64 kBMain entry bundles and manifests
Status: 1 added Graph Workspace — 2.63 MBGraph editor runtime, canvas, workflow orchestration
Status: 4 added Views & Navigation — 148 kBTop-level views, pages, and routed surfaces
Status: 18 added Panels & Settings — 883 kBConfiguration panels, inspectors, and settings screens
Status: 35 added User & Accounts — 160 kBAuthentication, profile, and account management bundles
Status: 18 added Editors & Dialogs — 502 kBModals, dialogs, drawers, and in-app editors
Status: 17 added UI Components — 367 kBReusable component library chunks
Status: 33 added Data & Services — 1.96 MBStores, services, APIs, and repositories
Status: 43 added Utilities & Hooks — 2.47 MBHelpers, composables, and utility bundles
Status: 81 added Vendor & Third-Party — 9.69 MBExternal libraries and shared vendor chunks
Status: 16 added Other — 34.9 MBBundles that do not match a named category
Status: 746 added ⚡ Performance: ❌ 8 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-02T07:39:27.514Z",
"gitSha": "fb834a747c53cabb491ecac50cd53ed5f5aad0d6",
"branch": "jaeone94/png-stop-at-iend",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2074.3009999999913,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.006,
"layouts": 9,
"layoutDurationMs": 2.541,
"taskDurationMs": 748.9879999999999,
"heapDeltaBytes": -7355896,
"heapUsedBytes": 62876668,
"domNodes": -178,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 13.908000000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2047.824999999989,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.039999999999999,
"layouts": 8,
"layoutDurationMs": 2.8409999999999997,
"taskDurationMs": 660.678,
"heapDeltaBytes": 10189836,
"heapUsedBytes": 70247600,
"domNodes": -178,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 11.274,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1895.2310000000239,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.056,
"layouts": 9,
"layoutDurationMs": 2.8569999999999998,
"taskDurationMs": 1037.7669999999998,
"heapDeltaBytes": 5943604,
"heapUsedBytes": 66425884,
"domNodes": -178,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 176.30499999999998,
"eventListeners": -73,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666664,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1991.4339999999129,
"styleRecalcs": 80,
"styleRecalcDurationMs": 15.305,
"layouts": 10,
"layoutDurationMs": 2.9630000000000005,
"taskDurationMs": 1081.953,
"heapDeltaBytes": 7730188,
"heapUsedBytes": 77599092,
"domNodes": -178,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 182.309,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665546218487393,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.2630000000036,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.689,
"layouts": 12,
"layoutDurationMs": 3.437,
"taskDurationMs": 462.2370000000001,
"heapDeltaBytes": 11341448,
"heapUsedBytes": 84157724,
"domNodes": 57,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 13.797,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.6870000000545,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.720999999999999,
"layouts": 11,
"layoutDurationMs": 3.8500000000000005,
"taskDurationMs": 496.591,
"heapDeltaBytes": 8209876,
"heapUsedBytes": 84969860,
"domNodes": 57,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 14.421999999999997,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 647.420000000011,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.1879999999999997,
"layouts": 9,
"layoutDurationMs": 2.279,
"taskDurationMs": 466.377,
"heapDeltaBytes": -15285144,
"heapUsedBytes": 61293472,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 175.239,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102567,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 767.1589999999924,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.0869999999999993,
"layouts": 8,
"layoutDurationMs": 2.704,
"taskDurationMs": 551.527,
"heapDeltaBytes": 679688,
"heapUsedBytes": 60998872,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 182.54500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304346,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1375.2910000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1093.7360000000003,
"heapDeltaBytes": -11525636,
"heapUsedBytes": 78319408,
"domNodes": -208,
"jsHeapTotalBytes": 22552576,
"scriptDurationMs": 81.873,
"eventListeners": -107,
"totalBlockingTimeMs": 674,
"frameDurationMs": 36.93513513513515,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1237.622999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 922.8530000000002,
"heapDeltaBytes": 15485980,
"heapUsedBytes": 78024432,
"domNodes": 0,
"jsHeapTotalBytes": 12746752,
"scriptDurationMs": 69.78200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 592,
"frameDurationMs": 36.27058823529411,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 904.1889999999739,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.8500000000003,
"heapDeltaBytes": -4694920,
"heapUsedBytes": 90595552,
"domNodes": 0,
"jsHeapTotalBytes": 5771264,
"scriptDurationMs": 185.59199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 250,
"frameDurationMs": 25.714285714285715,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 891.0869999999704,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.9809999999998,
"heapDeltaBytes": 1975344,
"heapUsedBytes": 89474396,
"domNodes": -208,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 171.39600000000004,
"eventListeners": -107,
"totalBlockingTimeMs": 239,
"frameDurationMs": 24.999999999999975,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11585.453999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10679.456999999999,
"heapDeltaBytes": 71451572,
"heapUsedBytes": 164974060,
"domNodes": -274,
"jsHeapTotalBytes": 77197312,
"scriptDurationMs": 8485.565,
"eventListeners": -69,
"totalBlockingTimeMs": 1359,
"frameDurationMs": 31.475,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11674.61400000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10870.898,
"heapDeltaBytes": 76274780,
"heapUsedBytes": 153131044,
"domNodes": -274,
"jsHeapTotalBytes": 73003008,
"scriptDurationMs": 8758.789999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 1668,
"frameDurationMs": 32.00794520547945,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11166.757000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10399.376999999999,
"heapDeltaBytes": 85170796,
"heapUsedBytes": 161150192,
"domNodes": -274,
"jsHeapTotalBytes": 69070848,
"scriptDurationMs": 8338.618,
"eventListeners": -69,
"totalBlockingTimeMs": 1114,
"frameDurationMs": 31.366011235955053,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 12224.173999999948,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11434.917000000001,
"heapDeltaBytes": 68802428,
"heapUsedBytes": 152417428,
"domNodes": -274,
"jsHeapTotalBytes": 84275200,
"scriptDurationMs": 9293.514,
"eventListeners": -69,
"totalBlockingTimeMs": 2093,
"frameDurationMs": 33.93388888888889,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-combo-open",
"durationMs": 241.72700000002578,
"styleRecalcs": 22,
"styleRecalcDurationMs": 13.005999999999998,
"layouts": 8,
"layoutDurationMs": 2.6499999999999995,
"taskDurationMs": 180.30800000000002,
"heapDeltaBytes": 14987156,
"heapUsedBytes": 75427544,
"domNodes": 699,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.829,
"eventListeners": 72,
"totalBlockingTimeMs": 3,
"frameDurationMs": 24.077777777777808,
"p95FrameDurationMs": 83.29999999999973
},
{
"name": "large-combo-open",
"durationMs": 232.39999999998417,
"styleRecalcs": 21,
"styleRecalcDurationMs": 13.958,
"layouts": 8,
"layoutDurationMs": 2.524,
"taskDurationMs": 170.34,
"heapDeltaBytes": 14931828,
"heapUsedBytes": 76250748,
"domNodes": 936,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.824000000000002,
"eventListeners": 205,
"totalBlockingTimeMs": 4,
"frameDurationMs": 23.33000000000002,
"p95FrameDurationMs": 83.40000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2057.0789999999874,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.8059999999999996,
"layouts": 8,
"layoutDurationMs": 2.3870000000000005,
"taskDurationMs": 766.0780000000001,
"heapDeltaBytes": -27630044,
"heapUsedBytes": 64161300,
"domNodes": -274,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 40.964000000000006,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2051.796999999965,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.5189999999999997,
"layouts": 7,
"layoutDurationMs": 2.1799999999999997,
"taskDurationMs": 752.77,
"heapDeltaBytes": -17196320,
"heapUsedBytes": 65278112,
"domNodes": -274,
"jsHeapTotalBytes": 126976,
"scriptDurationMs": 36.25300000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2758.8890000000106,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.528,
"layouts": 8,
"layoutDurationMs": 2.3489999999999998,
"taskDurationMs": 1805.283,
"heapDeltaBytes": -10167780,
"heapUsedBytes": 72714856,
"domNodes": -274,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 850.854,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76768292682927,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2665.04800000007,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.699,
"layouts": 7,
"layoutDurationMs": 2.018,
"taskDurationMs": 1834.3829999999998,
"heapDeltaBytes": -21543900,
"heapUsedBytes": 62108764,
"domNodes": -274,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 882.221,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.771069182389933,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3985.7849999999644,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.426,
"layouts": 64,
"layoutDurationMs": 11.333,
"taskDurationMs": 1980.3899999999999,
"heapDeltaBytes": -15347316,
"heapUsedBytes": 61711196,
"domNodes": -250,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 846.3149999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610878661088,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3929.988000000094,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.453000000000001,
"layouts": 64,
"layoutDurationMs": 11.247,
"taskDurationMs": 1965.5610000000001,
"heapDeltaBytes": 470048,
"heapUsedBytes": 85213500,
"domNodes": -250,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 842.453,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3230.412000000001,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.288,
"layouts": 6,
"layoutDurationMs": 1.5570000000000002,
"taskDurationMs": 2140.161,
"heapDeltaBytes": -5125260,
"heapUsedBytes": 81419472,
"domNodes": -274,
"jsHeapTotalBytes": 5001216,
"scriptDurationMs": 1008.148,
"eventListeners": -64,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.839583333333334,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3295.1510000000326,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.648000000000001,
"layouts": 5,
"layoutDurationMs": 1.4660000000000002,
"taskDurationMs": 2176.982,
"heapDeltaBytes": 2903080,
"heapUsedBytes": 86406368,
"domNodes": -274,
"jsHeapTotalBytes": 6049792,
"scriptDurationMs": 1036.529,
"eventListeners": -61,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.836923076923075,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3168.342999999993,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7820000000000007,
"layouts": 6,
"layoutDurationMs": 1.6489999999999998,
"taskDurationMs": 851.2919999999999,
"heapDeltaBytes": -20747700,
"heapUsedBytes": 62791540,
"domNodes": -274,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 404.915,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684207,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3160.302999999999,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.8209999999999997,
"layouts": 7,
"layoutDurationMs": 1.7550000000000001,
"taskDurationMs": 904.43,
"heapDeltaBytes": -7902964,
"heapUsedBytes": 68175904,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 402.617,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666137566137568,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2041.292999999996,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.34,
"layouts": 7,
"layoutDurationMs": 2.202,
"taskDurationMs": 708.711,
"heapDeltaBytes": -6690844,
"heapUsedBytes": 78298544,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 36.981,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2042.5769999999375,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.3820000000000006,
"layouts": 7,
"layoutDurationMs": 2.034,
"taskDurationMs": 739.189,
"heapDeltaBytes": -20091500,
"heapUsedBytes": 63457392,
"domNodes": -274,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 39.40299999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2795.3999999999724,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.408,
"layouts": 7,
"layoutDurationMs": 2.26,
"taskDurationMs": 650.251,
"heapDeltaBytes": -5352764,
"heapUsedBytes": 78590400,
"domNodes": -256,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 195.896,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66607142857143,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2985.084000000029,
"styleRecalcs": 24,
"styleRecalcDurationMs": 12.629,
"layouts": 5,
"layoutDurationMs": 1.627,
"taskDurationMs": 698.3820000000001,
"heapDeltaBytes": 8592528,
"heapUsedBytes": 92756052,
"domNodes": 19,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 240.74900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665363128491624,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3402.1379999999795,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.94,
"layouts": 6,
"layoutDurationMs": 1.8250000000000002,
"taskDurationMs": 1031.7939999999999,
"heapDeltaBytes": 2580696,
"heapUsedBytes": 85691032,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 400.162,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666176470588237,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3419.0980000000764,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.7680000000000005,
"layouts": 6,
"layoutDurationMs": 1.8149999999999997,
"taskDurationMs": 1057.225,
"heapDeltaBytes": 1989292,
"heapUsedBytes": 86577056,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 401.55,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.748039215686273,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 676.3589999999908,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.065999999999999,
"layouts": 9,
"layoutDurationMs": 2.199,
"taskDurationMs": 465.398,
"heapDeltaBytes": 362548,
"heapUsedBytes": 62737844,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 149.255,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 706.8439999999327,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.537,
"layouts": 9,
"layoutDurationMs": 2.8819999999999997,
"taskDurationMs": 489.90999999999997,
"heapDeltaBytes": -14879040,
"heapUsedBytes": 59808304,
"domNodes": 0,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 149.981,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2025.6400000000099,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1379999999999995,
"layouts": 9,
"layoutDurationMs": 2.9059999999999997,
"taskDurationMs": 476.691,
"heapDeltaBytes": -1142396,
"heapUsedBytes": 68894084,
"domNodes": -200,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 10.266999999999998,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2040.8109999999624,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7999999999999994,
"layouts": 8,
"layoutDurationMs": 2.6389999999999993,
"taskDurationMs": 631.9259999999999,
"heapDeltaBytes": -19425132,
"heapUsedBytes": 55104000,
"domNodes": -200,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 10.298000000000002,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1752.834000000007,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.146999999999998,
"layouts": 7,
"layoutDurationMs": 2.306,
"taskDurationMs": 950.447,
"heapDeltaBytes": 6017852,
"heapUsedBytes": 68566984,
"domNodes": -200,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 120.18199999999999,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1740.68299999999,
"styleRecalcs": 78,
"styleRecalcDurationMs": 16.249,
"layouts": 9,
"layoutDurationMs": 2.7610000000000006,
"taskDurationMs": 975.035,
"heapDeltaBytes": -1964232,
"heapUsedBytes": 60557768,
"domNodes": -192,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 121.365,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1587.9979999999705,
"styleRecalcs": 16,
"styleRecalcDurationMs": 28.752,
"layouts": 5,
"layoutDurationMs": 20.108999999999998,
"taskDurationMs": 1368.1650000000002,
"heapDeltaBytes": 20806348,
"heapUsedBytes": 110322124,
"domNodes": 19229,
"jsHeapTotalBytes": 18612224,
"scriptDurationMs": 32.487,
"eventListeners": 3566,
"totalBlockingTimeMs": 224,
"frameDurationMs": 21.333333333333332,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "viewport-pan-sweep",
"durationMs": 11168.772000000046,
"styleRecalcs": 251,
"styleRecalcDurationMs": 30.746000000000002,
"layouts": 8,
"layoutDurationMs": 2.2409999999999997,
"taskDurationMs": 6623.5599999999995,
"heapDeltaBytes": -10071472,
"heapUsedBytes": 72936472,
"domNodes": -274,
"jsHeapTotalBytes": 3465216,
"scriptDurationMs": 2928.233,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66597014925373,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10860.220000000027,
"styleRecalcs": 251,
"styleRecalcDurationMs": 31.606,
"layouts": 8,
"layoutDurationMs": 2.4090000000000003,
"taskDurationMs": 6729.146999999999,
"heapDeltaBytes": 1818220,
"heapUsedBytes": 83151748,
"domNodes": -274,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 3020.304,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.691692307692307,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 24659.672,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23788.047,
"heapDeltaBytes": -24249148,
"heapUsedBytes": 264885276,
"domNodes": -3482,
"jsHeapTotalBytes": 12308480,
"scriptDurationMs": 325.72499999999997,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.62654867256637,
"p95FrameDurationMs": 99.89999999999964
},
{
"name": "vue-large-graph-idle",
"durationMs": 24893.985999999928,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24073.229,
"heapDeltaBytes": -28246696,
"heapUsedBytes": 282050388,
"domNodes": -3482,
"jsHeapTotalBytes": 8634368,
"scriptDurationMs": 373.098,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.533846153846156,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 29566.73599999999,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.44199999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 29272.156,
"heapDeltaBytes": -37834624,
"heapUsedBytes": 258783904,
"domNodes": -3482,
"jsHeapTotalBytes": 17551360,
"scriptDurationMs": 917.036,
"eventListeners": -659,
"totalBlockingTimeMs": 49,
"frameDurationMs": 54.75092592592593,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 29517.251999999986,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.506999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 29196.728000000003,
"heapDeltaBytes": 13021232,
"heapUsedBytes": 278940456,
"domNodes": -3126,
"jsHeapTotalBytes": 18612224,
"scriptDurationMs": 947.7719999999999,
"eventListeners": -652,
"totalBlockingTimeMs": 18,
"frameDurationMs": 55.209925093632954,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8527.963,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.71099999999999,
"layouts": 20,
"layoutDurationMs": 22.548999999999985,
"taskDurationMs": 8423.049,
"heapDeltaBytes": 14045152,
"heapUsedBytes": 273315256,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 135.849,
"eventListeners": 0,
"totalBlockingTimeMs": 14,
"frameDurationMs": 48.48238636363636,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8903.70900000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.25,
"layouts": 20,
"layoutDurationMs": 23.92100000000001,
"taskDurationMs": 8786.934,
"heapDeltaBytes": -11132060,
"heapUsedBytes": 272221852,
"domNodes": -3482,
"jsHeapTotalBytes": 17022976,
"scriptDurationMs": 127.21199999999999,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 50.185310734463286,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12107.311000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11686.049999999997,
"heapDeltaBytes": 5690728,
"heapUsedBytes": 259571748,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.76100000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.57869415807559,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12683.687999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12392.771,
"heapDeltaBytes": -3997240,
"heapUsedBytes": 260456088,
"domNodes": 0,
"jsHeapTotalBytes": 18874368,
"scriptDurationMs": 182.70300000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.190940766550504,
"p95FrameDurationMs": 100
},
{
"name": "workflow-execution",
"durationMs": 132.13199999995595,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.527,
"layouts": 9,
"layoutDurationMs": 3.522,
"taskDurationMs": 97.40499999999999,
"heapDeltaBytes": 4994676,
"heapUsedBytes": 66679188,
"domNodes": 101,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.084,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 139.28099999998267,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.133,
"layouts": 10,
"layoutDurationMs": 4.392,
"taskDurationMs": 106.839,
"heapDeltaBytes": -12524768,
"heapUsedBytes": 61781480,
"domNodes": 124,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 7.889000000000002,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67500000000001,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 547.6859999999988,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.752,
"layouts": 76,
"layoutDurationMs": 16.66,
"taskDurationMs": 511.10200000000003,
"heapDeltaBytes": -309240,
"heapUsedBytes": 48044752,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 246.594,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352926,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 587.3530000000073,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6809999999999999,
"layouts": 76,
"layoutDurationMs": 16.320999999999998,
"taskDurationMs": 545.5649999999999,
"heapDeltaBytes": -2673352,
"heapUsedBytes": 44104824,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 271.5,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 675.0489999999445,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.48,
"layouts": 76,
"layoutDurationMs": 16.326,
"taskDurationMs": 635.87,
"heapDeltaBytes": 1762984,
"heapUsedBytes": 105461724,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 264.386,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.082500000000003,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 668.5509999999795,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.821,
"layouts": 76,
"layoutDurationMs": 15.427,
"taskDurationMs": 628.171,
"heapDeltaBytes": 1995564,
"heapUsedBytes": 104957416,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 240.563,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage: 🟡 59.4% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3219 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 08d22dd215ce9df13930585ecc939d2a848fe506
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (348)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## jaeone94/getfrompngfile-hangs-the-tab-on-a-png-text-chunk #22701 +/- ##
=============================================================================================
- Coverage 87.53% 87.53% -0.01%
=============================================================================================
Files 2896 2895 -1
Lines 160135 160114 -21
Branches 40540 40535 -5
=============================================================================================
- Hits 140176 140151 -25
- Misses 19196 19200 +4
Partials 763 763
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 14 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Approving: I found no blockers.
- The bug is real. I traced it: with a 1–3 byte tail after
IEND,offset < pngData.lengthstill holds, sodataView.getUint32(offset)reads past the buffer and throws aRangeError. That rejects the whole parse and drops theworkflowalready collected. A tail of 4–7 bytes was already handled by thechunkEnd > pngData.lengthguard. Only the 1–3 byte window threw. - The fix is minimal and follows the spec.
IENDis the last chunk by definition, so stopping there also means trailing garbage of 12+ bytes is no longer read as fake chunks. Truncation beforeIENDkeeps its existing rejection, which the truncated-header test pins. - The test checks behaviour. The
it.for([1, 2, 3])table covers exactly the byte counts that threw, and the PR reports it fails on the parent branch.
No added comments, no types touched, and no server-state or API-type concerns. Reminder: this is stacked on #22690, so retarget it to main after #22690 merges.
Summary
Stop PNG chunk parsing at
IEND, so bytes appended after it no longer reject the parse and drop the workflow.Changes
getFromPngBufferbreaks out of the chunk loop atIEND. Before, a 1-3 byte tail afterIENDmadedataView.getUint32throw aRangeError, so a valid image with a valid workflow failed to import.IENDstill rejects; the existing testrejects rather than never settling when a chunk header is truncatedis unchanged.Review Focus
Stacked on #22690 (same loop). Retarget to
mainafter #22690 merges.The new table test fails on the parent branch with
RangeError: Offset is outside the bounds of the DataViewfor all three tail lengths, and passes with the fix.