Repository navigation
[backport cloud/1.58] fix(agent): re-send the canvas whenever an unsaved tab's remembered workflow is not its own (PM-2401) - #22698
Conversation
…orkflow is not its own (PM-2401) (#22518) The agent could still read an old graph on an unsaved tab in three rarer cases. Fixed. - Chat's workflow tab closed: the canvas is now sent, not the old workflow - No canvas available: the send is held and the message stays in the composer - Reply with no adoptable workflow: the tab no longer mints a new one each turn - Blank tab after the chat's tab closed: stays on the chat's workflow Linear: https://linear.app/comfyorg/issue/PM-2401 <details><summary>Full context for agent readers</summary> Follow-up to #22310, which re-sent the canvas only when the session's bound workflow was still open in another tab. These are the three edges cursor-review raised on that PR. - **What**: `isUnboundTarget` no longer needs the bound workflow to appear in `open_tabs` when the tab has content. A selected tab with no cloud id has no workflow of its own, so with a draft holding nodes or groups the turn carries `current_tab_unbound` and the draft. A blank tab whose bound workflow is open nowhere keeps today's thread fallback: minting would replace a built thread workflow with an empty one. A blank tab whose bound workflow is open elsewhere still re-flags, as #22310 does. - **Mint memo**: `unadoptedMintBinding` records, per tab path, the binding at the reply to a mint the tab did not adopt. Such a tab does not re-flag while the binding is unchanged, so there is no one-workflow-per-turn loop. An id with a tab binding is not recorded: an adopted mint shows in the binding, and temp-tab paths are reused after close. Cleared with the binding by `newChat`, `loadThread` and a deleted thread. The memo lives with the session: after a panel remount an unadopted mint can re-mint once. - **Hold**: a continuing turn from such a tab with no canvas is refused with the existing `agent.targetNavigationUnavailable` failure instead of silently retargeting. `current_tab_unbound` without a draft would mint an empty workflow, so sending is not an option. `performSend` returns false, so the composer keeps the text. - `postTurn` now takes the built input so `performSend` can read whether the turn was flagged. - **Tests**: red on `main`, green here: `(h10b)` hold, `(h10e)` closed tab re-flags, `(h10f)` reply without an id does not re-flag. Added after adversarial review, red before the second commit: `(h10e2)` blank tab keeps the thread workflow, `(h10e3)` reused path of a closed adopted tab mints for itself. Guards: `(h10d)` unadopted mint not re-minted, `(h10g)` new chat clears the memo. - Accepted cost, per the ticket: renaming a bound unsaved tab loses its binding, so the next turn mints a copy of that tab's canvas and leaves the old draft workflow orphaned. - Held sends apply only when the host provides a canvas reader. They reuse the existing "target no longer available" text to keep this PR inside the agent paths. `draft` is undefined only when the tab has no `activeState`. - Not changed: a flagged first turn (nothing bound) with no draft can still mint empty. Same as `main`. - After a reply with no id, later turns on that tab send neither flag nor draft. The server (`agent_handler.go`) always returns `workflow_id`, so this is a loop guard only. </details> (cherry picked from commit 9ceb4ce)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 8 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-02T07:02:51.993Z",
"gitSha": "ef216d7d37a55033f2d29b88315a5de88c06617e",
"branch": "backport-22518-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2055.2220000000148,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.0770000000000004,
"layouts": 10,
"layoutDurationMs": 2.3800000000000003,
"taskDurationMs": 404.89699999999993,
"heapDeltaBytes": 2357828,
"heapUsedBytes": 90375992,
"domNodes": -200,
"jsHeapTotalBytes": -2555904,
"scriptDurationMs": 8.145999999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2037.3950000000036,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.067,
"layouts": 10,
"layoutDurationMs": 2.255,
"taskDurationMs": 522.032,
"heapDeltaBytes": -498760,
"heapUsedBytes": 87829768,
"domNodes": -200,
"jsHeapTotalBytes": -3342336,
"scriptDurationMs": 7.67,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622944,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1753.2159999999806,
"styleRecalcs": 74,
"styleRecalcDurationMs": 10.315000000000001,
"layouts": 8,
"layoutDurationMs": 1.807,
"taskDurationMs": 738.0759999999999,
"heapDeltaBytes": 21813052,
"heapUsedBytes": 112750440,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 127.31900000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1726.477999999986,
"styleRecalcs": 73,
"styleRecalcDurationMs": 9.737,
"layouts": 9,
"layoutDurationMs": 1.852,
"taskDurationMs": 670.843,
"heapDeltaBytes": 1617872,
"heapUsedBytes": 90681132,
"domNodes": -201,
"jsHeapTotalBytes": 1638400,
"scriptDurationMs": 120.62100000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.2879999999918,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.018000000000001,
"layouts": 12,
"layoutDurationMs": 2.4690000000000003,
"taskDurationMs": 265.228,
"heapDeltaBytes": 21559848,
"heapUsedBytes": 109103712,
"domNodes": 47,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 9.676,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.887999999998,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.135,
"layouts": 12,
"layoutDurationMs": 2.8400000000000003,
"taskDurationMs": 353.675,
"heapDeltaBytes": 21538156,
"heapUsedBytes": 109896304,
"domNodes": 47,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 9.457,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 581.6660000000127,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.2980000000000005,
"layouts": 10,
"layoutDurationMs": 2.2970000000000006,
"taskDurationMs": 426.141,
"heapDeltaBytes": 163520,
"heapUsedBytes": 87728804,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 146.787,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66857142857142,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 567.4530000000004,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.101,
"layouts": 9,
"layoutDurationMs": 1.9969999999999997,
"taskDurationMs": 379.215,
"heapDeltaBytes": -658712,
"heapUsedBytes": 88185356,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 146.52900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1135.6719999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 780.4120000000001,
"heapDeltaBytes": -14208152,
"heapUsedBytes": 102378592,
"domNodes": -230,
"jsHeapTotalBytes": 16850944,
"scriptDurationMs": 55.14200000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 466,
"frameDurationMs": 31.480555555555547,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1130.3120000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 812.776,
"heapDeltaBytes": -16878204,
"heapUsedBytes": 102739368,
"domNodes": -230,
"jsHeapTotalBytes": 16142336,
"scriptDurationMs": 50.277,
"eventListeners": -168,
"totalBlockingTimeMs": 443,
"frameDurationMs": 30.627027027027022,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 762.7940000000137,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.4720000000001,
"heapDeltaBytes": -3985840,
"heapUsedBytes": 97559244,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 107.31400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 139,
"frameDurationMs": 22.547058823529422,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 765.2800000000184,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.97800000000024,
"heapDeltaBytes": -4044296,
"heapUsedBytes": 97398020,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 118.29599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 145,
"frameDurationMs": 22.547058823529422,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7909.081000000015,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.4190000000000001,
"layouts": 2,
"layoutDurationMs": 0.47199999999999975,
"taskDurationMs": 7092.98,
"heapDeltaBytes": 34157068,
"heapUsedBytes": 135978392,
"domNodes": -296,
"jsHeapTotalBytes": 24969216,
"scriptDurationMs": 5658.527,
"eventListeners": -130,
"totalBlockingTimeMs": 187,
"frameDurationMs": 26.744256756756762,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7242.809999999963,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.19000000000000006,
"layouts": 1,
"layoutDurationMs": 0.3129999999999999,
"taskDurationMs": 6414.892,
"heapDeltaBytes": 24797008,
"heapUsedBytes": 127005896,
"domNodes": -276,
"jsHeapTotalBytes": 26542080,
"scriptDurationMs": 5079.7429999999995,
"eventListeners": -130,
"totalBlockingTimeMs": 64,
"frameDurationMs": 24.602040816326532,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7941.6620000000075,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.03200000000000078,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7067.243,
"heapDeltaBytes": 41379264,
"heapUsedBytes": 142944640,
"domNodes": -277,
"jsHeapTotalBytes": 30212096,
"scriptDurationMs": 5617.542,
"eventListeners": -130,
"totalBlockingTimeMs": 158,
"frameDurationMs": 26.181848184818485,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7458.320000000014,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.35400000000000015,
"layouts": 2,
"layoutDurationMs": 0.428,
"taskDurationMs": 6673.789,
"heapDeltaBytes": 20941856,
"heapUsedBytes": 125402488,
"domNodes": -276,
"jsHeapTotalBytes": 26357760,
"scriptDurationMs": 5342.799999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 91,
"frameDurationMs": 25.512671232876713,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "large-combo-open",
"durationMs": 205.46300000000883,
"styleRecalcs": 25,
"styleRecalcDurationMs": 12.089000000000002,
"layouts": 12,
"layoutDurationMs": 2.897,
"taskDurationMs": 145.365,
"heapDeltaBytes": 13206880,
"heapUsedBytes": 117180592,
"domNodes": 917,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 7.885,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.010000000000037,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "large-combo-open",
"durationMs": 215.64100000000508,
"styleRecalcs": 24,
"styleRecalcDurationMs": 12.202000000000002,
"layouts": 11,
"layoutDurationMs": 2.913,
"taskDurationMs": 170.129,
"heapDeltaBytes": 15498536,
"heapUsedBytes": 117717472,
"domNodes": 917,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 7.84,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.66999999999998,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2041.8650000000014,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.797,
"layouts": 8,
"layoutDurationMs": 2.111,
"taskDurationMs": 585.4030000000001,
"heapDeltaBytes": -9568768,
"heapUsedBytes": 95765624,
"domNodes": -276,
"jsHeapTotalBytes": -2215936,
"scriptDurationMs": 26.226,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2042.05300000001,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.732,
"layouts": 9,
"layoutDurationMs": 1.7990000000000002,
"taskDurationMs": 443.18400000000014,
"heapDeltaBytes": 1345768,
"heapUsedBytes": 107635972,
"domNodes": -296,
"jsHeapTotalBytes": -2293760,
"scriptDurationMs": 22.363000000000007,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2169.4720000000134,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.337,
"layouts": 7,
"layoutDurationMs": 1.499,
"taskDurationMs": 1411.6269999999997,
"heapDeltaBytes": 5114908,
"heapUsedBytes": 109607252,
"domNodes": -276,
"jsHeapTotalBytes": -942080,
"scriptDurationMs": 650.695,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66615384615385,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2234.1579999999794,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.136000000000001,
"layouts": 7,
"layoutDurationMs": 1.425,
"taskDurationMs": 1444.9779999999998,
"heapDeltaBytes": -737008,
"heapUsedBytes": 108181548,
"domNodes": -296,
"jsHeapTotalBytes": -389120,
"scriptDurationMs": 652.184,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66567164179105,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3254.671999999971,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.407,
"layouts": 64,
"layoutDurationMs": 9.209,
"taskDurationMs": 1497.2589999999998,
"heapDeltaBytes": -7661460,
"heapUsedBytes": 98059472,
"domNodes": -272,
"jsHeapTotalBytes": -1024000,
"scriptDurationMs": 607.593,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66615384615385,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3294.5569999999975,
"styleRecalcs": 73,
"styleRecalcDurationMs": 8.792,
"layouts": 67,
"layoutDurationMs": 10.355,
"taskDurationMs": 1383.499,
"heapDeltaBytes": -3455332,
"heapUsedBytes": 100806316,
"domNodes": -272,
"jsHeapTotalBytes": -65536,
"scriptDurationMs": 632.288,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665989847715736,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2489.1789999999787,
"styleRecalcs": 44,
"styleRecalcDurationMs": 3.905,
"layouts": 5,
"layoutDurationMs": 1.0019999999999998,
"taskDurationMs": 1637.9360000000004,
"heapDeltaBytes": 19294068,
"heapUsedBytes": 128300364,
"domNodes": 0,
"jsHeapTotalBytes": 6713344,
"scriptDurationMs": 780.119,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.89251700680272,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2285.0740000000087,
"styleRecalcs": 47,
"styleRecalcDurationMs": 3.961000000000001,
"layouts": 5,
"layoutDurationMs": 1.091,
"taskDurationMs": 1446.217,
"heapDeltaBytes": 17017040,
"heapUsedBytes": 123761704,
"domNodes": 0,
"jsHeapTotalBytes": 7499776,
"scriptDurationMs": 765.035,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.039552238805967,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2046.1819999999875,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.51,
"layouts": 7,
"layoutDurationMs": 1.4709999999999999,
"taskDurationMs": 451.0419999999999,
"heapDeltaBytes": 221388,
"heapUsedBytes": 103046652,
"domNodes": -296,
"jsHeapTotalBytes": -2293760,
"scriptDurationMs": 30.216000000000008,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2048.5030000000393,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.6389999999999998,
"layouts": 8,
"layoutDurationMs": 1.861,
"taskDurationMs": 451.328,
"heapDeltaBytes": 356152,
"heapUsedBytes": 103013652,
"domNodes": -296,
"jsHeapTotalBytes": -1769472,
"scriptDurationMs": 25.900999999999993,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 542.9570000000012,
"styleRecalcs": 47,
"styleRecalcDurationMs": 3.795,
"layouts": 10,
"layoutDurationMs": 2.2509999999999994,
"taskDurationMs": 322.974,
"heapDeltaBytes": 22539984,
"heapUsedBytes": 111949808,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 117.027,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.190624999999997,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 541.2050000000477,
"styleRecalcs": 46,
"styleRecalcDurationMs": 3.7540000000000004,
"layouts": 9,
"layoutDurationMs": 1.8760000000000003,
"taskDurationMs": 373.193,
"heapDeltaBytes": 25233892,
"heapUsedBytes": 114751556,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 117.984,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.9929999999943,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.0439999999999996,
"layouts": 10,
"layoutDurationMs": 2.2470000000000003,
"taskDurationMs": 347.169,
"heapDeltaBytes": -794388,
"heapUsedBytes": 91178672,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 6.968,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2027.0679999999857,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.072,
"layouts": 10,
"layoutDurationMs": 2.206,
"taskDurationMs": 394.28999999999996,
"heapDeltaBytes": 2802488,
"heapUsedBytes": 93279352,
"domNodes": -218,
"jsHeapTotalBytes": -3080192,
"scriptDurationMs": 7.391,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1995.176999999984,
"styleRecalcs": 86,
"styleRecalcDurationMs": 11.683,
"layouts": 10,
"layoutDurationMs": 1.9579999999999997,
"taskDurationMs": 866.564,
"heapDeltaBytes": -456340,
"heapUsedBytes": 89813700,
"domNodes": -210,
"jsHeapTotalBytes": -983040,
"scriptDurationMs": 89.002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66583333333333,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1979.0540000000192,
"styleRecalcs": 86,
"styleRecalcDurationMs": 11.556,
"layouts": 10,
"layoutDurationMs": 2.0860000000000003,
"taskDurationMs": 856.283,
"heapDeltaBytes": 2230340,
"heapUsedBytes": 91832764,
"domNodes": -190,
"jsHeapTotalBytes": -2031616,
"scriptDurationMs": 84.631,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666386554621848,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.7950000000164,
"styleRecalcs": 18,
"styleRecalcDurationMs": 20.761,
"layouts": 5,
"layoutDurationMs": 12.193999999999999,
"taskDurationMs": 901.7159999999998,
"heapDeltaBytes": 38027212,
"heapUsedBytes": 137650296,
"domNodes": 16030,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 28.121,
"eventListeners": 3244,
"totalBlockingTimeMs": 145,
"frameDurationMs": 19.95352112676056,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8180.316000000004,
"styleRecalcs": 250,
"styleRecalcDurationMs": 20.818999999999996,
"layouts": 9,
"layoutDurationMs": 1.7610000000000001,
"taskDurationMs": 4292.513,
"heapDeltaBytes": -4616744,
"heapUsedBytes": 101049724,
"domNodes": -296,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 2115.123,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665987780040734,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8228.398999999969,
"styleRecalcs": 251,
"styleRecalcDurationMs": 20.395000000000003,
"layouts": 9,
"layoutDurationMs": 2.034,
"taskDurationMs": 4288.953,
"heapDeltaBytes": 2521424,
"heapUsedBytes": 104204308,
"domNodes": -296,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 2108.225,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666194331983807,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10816.07200000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10289.709000000003,
"heapDeltaBytes": -5188492,
"heapUsedBytes": 296042836,
"domNodes": -3344,
"jsHeapTotalBytes": 21745664,
"scriptDurationMs": 144.584,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.180976430976433,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 11106.870000000072,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10473.974,
"heapDeltaBytes": -27732412,
"heapUsedBytes": 277797524,
"domNodes": -3344,
"jsHeapTotalBytes": 22269952,
"scriptDurationMs": 149.222,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.873174872665537,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 15078.404999999975,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.377999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14403.083999999999,
"heapDeltaBytes": -19940152,
"heapUsedBytes": 304569084,
"domNodes": -3344,
"jsHeapTotalBytes": 19316736,
"scriptDurationMs": 859.471,
"eventListeners": -651,
"totalBlockingTimeMs": 154,
"frameDurationMs": 26.033448275862067,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 14797.374999999989,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.365000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14198.382,
"heapDeltaBytes": 1168928,
"heapUsedBytes": 306859276,
"domNodes": -3344,
"jsHeapTotalBytes": 13549568,
"scriptDurationMs": 688.73,
"eventListeners": -651,
"totalBlockingTimeMs": 13,
"frameDurationMs": 25.963859649122806,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-node-resize-workload",
"durationMs": 6072.885999999982,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.30999999999997,
"layouts": 20,
"layoutDurationMs": 25.903999999999996,
"taskDurationMs": 5938.925000000001,
"heapDeltaBytes": -40312484,
"heapUsedBytes": 279036800,
"domNodes": -3344,
"jsHeapTotalBytes": 17027072,
"scriptDurationMs": 87.042,
"eventListeners": -653,
"totalBlockingTimeMs": 3,
"frameDurationMs": 35.47543859649122,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 4292.454000000021,
"styleRecalcs": 20,
"styleRecalcDurationMs": 50.051999999999985,
"layouts": 20,
"layoutDurationMs": 19.16999999999999,
"taskDurationMs": 4158.6179999999995,
"heapDeltaBytes": -12189532,
"heapUsedBytes": 298515768,
"domNodes": -307,
"jsHeapTotalBytes": 18337792,
"scriptDurationMs": 70.65299999999999,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.33636363636364,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5584.949999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5176.856000000001,
"heapDeltaBytes": 8587552,
"heapUsedBytes": 277119256,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 71.40400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.487086092715234,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8268.012999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7880.836,
"heapDeltaBytes": -8619704,
"heapUsedBytes": 276703768,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 100.05200000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.021355932203388,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 483.17499999996016,
"styleRecalcs": 22,
"styleRecalcDurationMs": 8.779,
"layouts": 12,
"layoutDurationMs": 3.497,
"taskDurationMs": 121.22400000000002,
"heapDeltaBytes": -16894748,
"heapUsedBytes": 92878168,
"domNodes": 126,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 17.073999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 114.18000000003303,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.865,
"layouts": 9,
"layoutDurationMs": 3.32,
"taskDurationMs": 76.91099999999999,
"heapDeltaBytes": 4659748,
"heapUsedBytes": 93912024,
"domNodes": 94,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.636000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 383.8190000000168,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.705,
"layouts": 76,
"layoutDurationMs": 13.635,
"taskDurationMs": 336.671,
"heapDeltaBytes": -21213980,
"heapUsedBytes": 71732840,
"domNodes": 4,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 160.975,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304356,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 343.0789999999888,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6669999999999999,
"layouts": 76,
"layoutDurationMs": 13.389,
"taskDurationMs": 303.307,
"heapDeltaBytes": -21862284,
"heapUsedBytes": 70248340,
"domNodes": 4,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 138.74900000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636382,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 436.26099999994494,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.508,
"layouts": 76,
"layoutDurationMs": 12.631,
"taskDurationMs": 391.00300000000004,
"heapDeltaBytes": 12944,
"heapUsedBytes": 117101892,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 157.56599999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230754,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 391.64499999992586,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.532,
"layouts": 76,
"layoutDurationMs": 12.936,
"taskDurationMs": 350.148,
"heapDeltaBytes": -557688,
"heapUsedBytes": 116578060,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 133.601,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage: 🟡 63.6% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2996 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since b30f3efa4db0784467c382bd21d5f716b3a599b0
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (145)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.58 #22698 +/- ##
=============================================
Coverage ? 84.26%
=============================================
Files ? 3173
Lines ? 165728
Branches ? 41612
=============================================
Hits ? 139651
Misses ? 25686
Partials ? 391
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #22518 to
cloud/1.58. Manual: auto-backport conflicted.Full context for agent readers
Conflict was only in
loadThreadinuseAgentSession.ts: this branch predates thekeepOpenChatUntilLoadedrefactor on main. Kept the branch'sloadThreadand swapped its two binding resets forforgetBinding(), which is what #22518 changes there. Everything else applied cleanly, including theloadGeneration++in the deleted-thread path and all new unit cases(h10b)-(h10g).useAgentSession.test.ts: 281/281 locally on this branch; eslint clean on the source file.