Repository navigation
test(ci): use function declarations for the eligibility test helpers - #22688
Conversation
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9a58ff9195bee5c9c0764169376d5141f47dafe8
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (349)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Extract and reuse step lookup scripts/cicd/ecosystem-matrix-eligibility.test.ts |
The test defines createPullRequestStep, uses it to read and validate with.branch, and reuses it for the PR-token assertion. The workflow loader changes to a function declaration without changing its parsing behavior. |
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Refactor
Suggested reviewers: anupreet-comfy
Merge Risk: 
Minimal · up to 5a2fb
-
No actionable merge-blocking risk remains in this test-only refactor.
Pre-merge checks: 
6
-
Full details: Title check
-
Explanation
The title names the change: converting the eligibility test helpers to function declarations. The raw summary confirms the helpers became function declarations and the PR-step lookup moved into createPullRequestStep. The title is specific and matches the main change, though it omits the step-lookup consolidation.
Full details: Description check
-
Explanation
The description follows the template's Summary section and gives a clear account of the change and its intent, including a reference to the prior PR and the consolidated createPullRequestStep() lookup. It states that there is no behavior change and reports the test result under Review Focus. The template's Verification section is partly covered, with test command and result provided. Human QA and after-release items do not apply to a test-only change. The description does not include a linked issue line, which is optional because the template marks it as conditional.
Full details: End-To-End Test Suggestion For User-Facing Changes
-
Explanation
PASS. The PR changes only
scripts/cicd/ecosystem-matrix-eligibility.test.ts, which is a test file. The change does not modify the frontend application undersrc/orpackages/. The end-to-end test suggestion is therefore not applicable.
Full details: Adr Compliance For Entity/Litegraph Changes
-
Explanation
The pull request changes only
scripts/cicd/ecosystem-matrix-eligibility.test.ts. It does not modifysrc/lib/litegraph/,src/ecs/, or graph entity files. The ADR compliance check is not applicable.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #22688 +/- ##
==========================================
- Coverage 87.62% 87.53% -0.10%
==========================================
Files 3004 2896 -108
Lines 163495 160115 -3380
Branches 43693 40487 -3206
==========================================
- Hits 143265 140156 -3109
+ Misses 19299 19196 -103
+ Partials 931 763 -168
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Test-only refactor. The helpers are now function declarations per the repo guideline, the duplicated PR-step lookup is consolidated, and the assertions are unchanged. A missing PR step now throws a clear message instead of a Zod parse error on undefined, which is a small improvement. CI is green. One non-blocking naming nit inline.
|
|
||
| const bumpBranch = (() => { | ||
| const step = bump.jobs['update-pins'].steps?.find((candidate) => | ||
| function createPullRequestStep() { |
There was a problem hiding this comment.
nit-pick (non-blocking): createPullRequestStep() reads like it builds a step, but it looks up the existing peter-evans/create-pull-request step. Something like findCreatePullRequestStep() would make the lookup intent obvious at both call sites.
Summary
Style-only follow-up to #22260, from CodeRabbit's note on #22507: the named helpers in
scripts/cicd/ecosystem-matrix-eligibility.test.tsbecome function declarations, per the repo guideline. The PR-step lookup that was written twice (once for the bump branch, once for the token test) is now onecreatePullRequestStep().Changes
Review Focus
pnpm exec vitest run scripts/cicd/ecosystem-matrix-eligibility.test.ts: 10 passed.