Skip to content

test(ci): use function declarations for the eligibility test helpers - #22688

Merged
christian-byrne merged 1 commit into
mainfrom
test/eligibility-function-declarations
Nov 3, 2026
Merged

christian-byrne merged 1 commit into
mainfrom
test/eligibility-function-declarations

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Style-only follow-up to #22260, from CodeRabbit's note on #22507: the named helpers in scripts/cicd/ecosystem-matrix-eligibility.test.ts become function declarations, per the repo guideline. The PR-step lookup that was written twice (once for the bump branch, once for the token test) is now one createPullRequestStep().

Changes

  • What: test file only. No behaviour change: same 10 tests, same assertions; a missing PR step still throws with the same message.

Review Focus

  • pnpm exec vitest run scripts/cicd/ecosystem-matrix-eligibility.test.ts: 10 passed.

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Full docs: scripts/registry-census/README.md

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

🌾 Fallow: ✅ Passed

Findings and check details

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Full docs: ADR-DEVEX-LINT-0015

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 9a58ff9195bee5c9c0764169376d5141f47dafe8

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (349)

  • billing path matches no source files: src/platform/billing/composables/activateBillingScope.testUtils.ts. Remove or update it in docs/architecture/domains/records/billing.domain.json.
  • error-handling path matches no source files: src/utils/errorUtil.ts. Remove or update it in docs/architecture/domains/records/error-handling.domain.json.
  • graph-model path matches no source files: src/types/linkTopology.ts. Remove or update it in docs/architecture/domains/records/graph-model.domain.json.
  • graph-model path matches no source files: src/types/nodeState.ts. Remove or update it in docs/architecture/domains/records/graph-model.domain.json.
  • job-queue path matches no source files: src/platform/remote/comfyui/jobs/**. Remove or update it in docs/architecture/domains/records/job-queue.domain.json.
  • linear-mode path matches no source files: src/utils/appMode.ts. Remove or update it in docs/architecture/domains/records/linear-mode.domain.json.
  • link-connection path matches no source files: src/lib/litegraph/src/infrastructure/LinkConnectorEventMap.ts. Remove or update it in docs/architecture/domains/records/link-connection.domain.json.
  • node-widgets path matches no source files: src/types/widgetState.ts. Remove or update it in docs/architecture/domains/records/node-widgets.domain.json.
  • subgraphs path matches no source files: src/lib/litegraph/src/infrastructure/SubgraphEventMap.ts. Remove or update it in docs/architecture/domains/records/subgraphs.domain.json.
  • vue-node-widgets path matches no source files: src/types/positionConfig.ts. Remove or update it in docs/architecture/domains/records/vue-node-widgets.domain.json.
  • workspace path matches no source files: src/platform/workspace/fixtures/**. Remove or update it in docs/architecture/domains/records/workspace.domain.json.
  • packages/api-client/src/abortSignal.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/abortSignal.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchRouteTemplate.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchWithRetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchWithRetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/retryPolicy.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/retryPolicy.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/statusRetryTelemetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/statusRetryTelemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/formatUtil.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/formatUtil.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/geometry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/loadExternalScript.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/networkUtil.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/telemetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/telemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/urlSafety.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/urlSafety.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/tailwind-utils/src/index.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/TopbarActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatClipStrip.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatClipTile.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPanel.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPanel.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPlaybackBar.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/WidgetVideoConcat.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/WidgetVideoConcat.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/__fixtures__/clipTiles.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionActions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionActions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionNotices.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionNotices.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentSidebarTabs.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 299 more

Full docs: Frontend domain catalog

Reproduce locally
pnpm architecture:check

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 9a58ff9 and 5a2fb92.

Files selected for processing: 1
  • scripts/cicd/ecosystem-matrix-eligibility.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

Walkthrough

The workflow eligibility test now uses a shared helper to find the create-pull-request step. It reads and validates the step’s branch input and reuses the helper in the PR-token assertion.

Changes: Workflow eligibility test

Layer / File(s) Summary
Extract and reuse step lookup
scripts/cicd/ecosystem-matrix-eligibility.test.ts
The test defines createPullRequestStep, uses it to read and validate with.branch, and reuses it for the PR-token assertion. The workflow loader changes to a function declaration without changing its parsing behavior.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Refactor

Suggested reviewers: anupreet-comfy

Merge Risk: Minimal · up to 5a2fb

No actionable merge-blocking risk remains in this test-only refactor.

Pre-merge checks: Passed 6
Check name Status Explanation
Title check Passed The title names the change: converting the eligibility test helpers to function declarations. The raw summary confirms the helpers became function declarations and the PR-step lookup moved into create…
Description check Passed The description follows the template's Summary section and gives a clear account of the change and its intent, including a reference to the prior PR and the consolidated createPullRequestStep() lookup…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
End-To-End Test Suggestion For User-Facing Changes Passed PASS. The PR changes only scripts/cicd/ecosystem-matrix-eligibility.test.ts, which is a test file. The change does not modify the frontend application under src/ or packages/. The end-to-end tes…
Adr Compliance For Entity/Litegraph Changes Passed The pull request changes only scripts/cicd/ecosystem-matrix-eligibility.test.ts. It does not modify src/lib/litegraph/, src/ecs/, or graph entity files. The ADR compliance check is not applicabl…
Full details: Title check

Explanation

The title names the change: converting the eligibility test helpers to function declarations. The raw summary confirms the helpers became function declarations and the PR-step lookup moved into createPullRequestStep. The title is specific and matches the main change, though it omits the step-lookup consolidation.

Full details: Description check

Explanation

The description follows the template's Summary section and gives a clear account of the change and its intent, including a reference to the prior PR and the consolidated createPullRequestStep() lookup. It states that there is no behavior change and reports the test result under Review Focus. The template's Verification section is partly covered, with test command and result provided. Human QA and after-release items do not apply to a test-only change. The description does not include a linked issue line, which is optional because the template marks it as conditional.

Full details: End-To-End Test Suggestion For User-Facing Changes

Explanation

PASS. The PR changes only scripts/cicd/ecosystem-matrix-eligibility.test.ts, which is a test file. The change does not modify the frontend application under src/ or packages/. The end-to-end test suggestion is therefore not applicable.

Full details: Adr Compliance For Entity/Litegraph Changes

Explanation

The pull request changes only scripts/cicd/ecosystem-matrix-eligibility.test.ts. It does not modify src/lib/litegraph/, src/ecs/, or graph entity files. The ADR compliance check is not applicable.

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Nov 2, 2026
@codecov

codecov Bot commented Nov 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #22688      +/-   ##
==========================================
- Coverage   87.62%   87.53%   -0.10%     
==========================================
  Files        3004     2896     -108     
  Lines      163495   160115    -3380     
  Branches    43693    40487    -3206     
==========================================
- Hits       143265   140156    -3109     
+ Misses      19299    19196     -103     
+ Partials      931      763     -168     
Flag Coverage Δ
billing-web-unit ?
unit 86.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 108 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test-only refactor. The helpers are now function declarations per the repo guideline, the duplicated PR-step lookup is consolidated, and the assertions are unchanged. A missing PR step now throws a clear message instead of a Zod parse error on undefined, which is a small improvement. CI is green. One non-blocking naming nit inline.


const bumpBranch = (() => {
const step = bump.jobs['update-pins'].steps?.find((candidate) =>
function createPullRequestStep() {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit-pick (non-blocking): createPullRequestStep() reads like it builds a step, but it looks up the existing peter-evans/create-pull-request step. Something like findCreatePullRequestStep() would make the lookup intent obvious at both call sites.

@christian-byrne
christian-byrne added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit 38a3990 Nov 3, 2026
87 checks passed
@christian-byrne
christian-byrne deleted the test/eligibility-function-declarations branch November 3, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants