Skip to content

[backport cloud/1.59] fix(agent): restore pre-reload thinking when the turn finishes (FRONT-3659) (#22244) - #22681

Merged
christian-byrne merged 4 commits into
cloud/1.59from
backport-22244-to-cloud-1.59
Nov 2, 2026
Merged

christian-byrne merged 4 commits into
cloud/1.59from
backport-22244-to-cloud-1.59

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Manual backport of #22244 to this 1.59 branch, plus its follow-up #22678 (merged to main as cdbb0cb). The automatic backport hit conflicts in useAgentSession.ts and agentConversationStore.ts.

Fixes FRONT-3659: after a reload while the agent is working, the thinking from before the reload comes back when the turn finishes.

What differs from main

1.59 does not have main's recovery rework (RunningRecovery, finishRecovery, the pending-ask observation ledgers), so the settled read is written against 1.59's plain AbortController map:

  • It holds the turn's recovery key the way reconcileTurn does. On release, if a hydrate restored the turn while the read held the key, reconcileLiveTurns skipped it, so the read starts reconcileTurn for it. That matches main's finishRecovery rerun.
  • TurnOutcome.streaming stays { kind: 'streaming' }, and a missing anchor row still reads as streaming, as on 1.59. Only the error variant changes to carry its cause.
  • No ledger clean-up, since 1.59 has no ledgers.
  • Everything else, the store change and all tests, applies as on main.

Verification

This head includes every change #22678 made in review, so it matches what merged on main.

christian-byrne and others added 2 commits November 2, 2026 01:12
…-3659) (#22244)

Reload while the agent is still working and the rounds it had already
narrated do not come back when the turn finishes. Only what streamed
after the reload shows, and the earlier reasoning reappears once you
leave the chat and open it again. Fixes
[FRONT-3659](https://linear.app/comfyorg/issue/FRONT-3659).

The reload restores the running turn from the transcript, and a running
row carries no reasoning: the backend writes `content.thinking` when the
turn finishes (Comfy-Org/cloud#14903, consumed here by #21600). So the
panel follows the rest of the turn over the socket and settles on its
terminal frame with nothing fetched — the one completion path that never
reads the stored row back. The reconnect recovery *does* read it,
through `settleTurn`, which is why a dropped socket keeps the whole
trace and a reload does not.

`agentConversationStore` already knows which turns came from a snapshot
(`ActiveTurnSlot.origin`), so it announces one once nothing is still
publishing the row, and `useAgentSession` makes the same read the
recovery makes, once.

- **After the settle, not instead of it.** The turn is already finished,
so holding it open for a round trip would delay the composer's handback
and strand it outright if the read failed. Reconciling afterwards means
a failed read leaves the turn exactly as it is today, rather than
locking the composer.
- **The announcement waits for the transport to stop publishing.** A
settled turn can still hold a tool-call part pending canvas catch-up
(PM-1575), and such a turn keeps its transport reachable in
`settledActiveTransports`. That transport owns its own copy of the row
and republishes it through `replaceActive` on the next
`notifyCanvasCaughtUp` — which would discard everything the reconcile
folded in. So the registration carries the transport and the
announcement is deferred until nothing is held: the reconcile only ever
runs when no transport can still publish that row. Every transport emit
routes through `publishMessage`, which covers the catch-up settle and
the transport's own stale fallback alike, and the announcement is
one-shot.
- **The stored row decides the finished turn's thinking.** After the
settled read the panel renders the same thinking that reopening the chat
renders; live thinking is kept only when the stored row holds no
thinking at all. An earlier head of this PR merged live and stored
rounds on the client, and review rejected that: the same finished turn
showed different reasoning depending on whether you watched it settle.
Only two things carry over from the live copy, because only the client
has them: `canvasConfirmed`, and the tool offset that places post-reload
tab links. Any reasoning the backend cap drops is a backend contract
problem, tracked in
https://linear.app/comfyorg/issue/BE-24672/agent-stored-thinking-is-cut-off-with-no-signal-past-the-per-round-and.
- **The read repeats while the row still reads as streaming.** The
terminal write can trail the socket frame, so the settled read follows
`TURN_RECOVERY_DELAYS_MS` until the row is terminal or the deadline
passes. A failed read is reported once and not retried, and every exit
that does not apply a result releases the registration and its
transport.
- **A hydrate the read deferred is still honored.** Leaving for a new
chat and reopening the conversation while the settled read is in flight
clears the snapshot registration, so the read's own result is discarded
when it lands. The hydrate it deferred is then the only thing that can
settle the row hydration restored, so the read tears down through
`finishRecovery`, which reruns only while the turn is live -- a no-op on
the ordinary settled path, since a settled turn is not live.
- **`settleTurn` is unchanged.** The recovery read keeps its plain
stored-row handling, so this PR only touches the socket-settled path
that had no read at all.
- **The settled publisher is released at the announcement.** Its stale
fallback can clear the held part without removing it from
`settledActiveTransports`, and a later ask retirement would then
republish the transport's own copy of the row over the reconciled one.
- **`reconcileSettledTurn` writes a fresh object**, because
`replaceActive`'s emit is what every other write to a settled row relies
on.
- **Identity.** A snapshot keys a turn by **row id**
(`ActiveTurnSlot.turnId`) while its panel message is keyed by **turn
id**, so the registration holds both and the store unit tests use
different values for each — the browser fixture deliberately makes them
equal, which would hide a wrong lookup.
- **The pre-reload rounds still do not show *while* the turn is
running.** That would need the backend to replay or store in-flight
thinking, which is a separate and larger change.

The reload's recovery poll *can* win the race and settle the turn
through the reading path, which would hide the defect and make the spec
flaky-green on the parent.
`AgentTurnLockHarness.waitForRecoveryExhausted()` therefore waits out
the poll schedule — one hydration read plus one per
`TURN_RECOVERY_DELAYS_MS` entry, counted through the fixture's
transcript-read counter — so the socket is deterministically what
settles the turn. The schedule lives in its own leaf module
(`services/agent/turnRecoverySchedule.ts`) so the fixture derives that
count from the real value instead of hard-coding it: if the schedule
grew, a hard-coded wait would be too short and the spec would keep
passing for the wrong reason.

**Black-box proof, red on the parent and green here.** New spec
`browser_tests/tests/agent/agentThinkingAcrossMidTurnReload.spec.ts`
narrates a round, reloads mid-turn, narrates another round, finishes the
turn over the socket, and asserts the whole trace.

On the parent (`d85f282401`, product change reverted, test files kept)
the trace holds only the post-reload round — the earlier reasoning *and*
the tool call are both gone:

```
Error: expect(locator).toHaveText(expected) failed
  Locator: locator('#agent-panel-root').getByRole('listitem')
  - Expected  - 2
  + Received  + 0
  Array [
  -   "Wiring the audio output node.",
  -   /Add node/,
      "Back online, so I can finish the wiring.",
  ]
```

| Check | Result |
| --- | --- |
| New spec on the parent with the product change reverted | **Failed**
as quoted above |
| New spec on an earlier head of this branch | Passed, and 3/3 with
`--repeat-each=3` |
| Focused conversation-store and session unit suites | Green, 1 expected
fail |
| Broader Agent unit sweep | Green apart from one recovery-timer
assertion that fails only under full parallel load and passes alone,
identically on the parent |
| `pnpm typecheck`, `pnpm typecheck:browser`, `oxfmt`, `oxlint
--type-aware`, `depcruise`, `knip`, `fallow:audit`, pre-commit and
pre-push hooks | Clean |

Session coverage adds the leave-and-reopen interleaving: the settled
read is held open across a New Chat and a reopen with a still-streaming
snapshot, and the reopened row must still settle once the read lands. It
is red on the previous teardown with the row stranded as streaming.

Store coverage exercises announce-and-fold, one-shot reconciliation,
stored thinking winning over a live round that is longer, a suffix,
missing from the row, a repeat of an earlier round or keyed differently,
live thinking kept when the row holds none, confirmed canvas outcomes,
canvas-catch-up deferral, teardown ordering, a late ask retirement after
a stale held tool call, and a failed post-settlement history read
without reclaiming the composer.

Not verified: no live in-browser turn against a real backend, and no
Windows run. The agent API is mocked by the browser fixture throughout.
The browser spec is proven on this head by the cloud E2E job, not by a
local run.

One pre-existing unrelated failure: whole-repo `pnpm oxlint`
(`--type-aware`) crashes in `tsgolint` on this machine, identically on a
pristine parent checkout. The staged-file `oxlint --type-aware` that the
pre-commit hook runs passes.

- Earlier thinking still does not show while the turn is running:
https://linear.app/comfyorg/issue/BE-24497
- Reasoning past the stored caps is dropped with no signal:
https://linear.app/comfyorg/issue/BE-24672/agent-stored-thinking-is-cut-off-with-no-signal-past-the-per-round-and
- Backports: the 1.58 and 1.59 targets are labelled. 1.58 will probably
need a manual port because main's #18949 recovery rework is not on that
line.

---------

Co-authored-by: GitHub Action <action@github.com>
(cherry picked from commit 9a1f6dc)
…egistration

Follow-up to #22244 (FRONT-3659), from its adversarial review:

- reconcileSettledTurn only consumes an announced registration, so a read
  still finishing for an earlier settle cannot take or drop a re-registered
  turn whose own read has not started yet.
- The settled read retries a failed read on the same schedule as a row that
  still reads as streaming, and reports only if the last read fails.
- The read's teardown clears the recovery ledgers only while it still owns
  the key, before any deferred recovery reruns.

(cherry picked from commit 60f9354)
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 2
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle: ⏳ Size data collection in progress…

⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable

❌ 7 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Details
Scenario timings

canvas-idle: 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.7 MB heap
canvas-mouse-sweep: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.2 MB heap
canvas-zoom-sweep: 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.9 MB heap
dom-widget-clipping: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.6 MB heap
dom-widget-order-dense-n200-w200-i120: 30.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 526ms TBT · 72.1 MB heap
dom-widget-order-sparse-n1000-w20-i120: 40.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 228ms TBT · 62.8 MB heap
extension-clean-combined-draw: 31.9 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 801ms TBT · 122.3 MB heap
extension-rgthree-prototype-draw: 31.6 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 733ms TBT · 134.5 MB heap
large-combo-open: 39.1 avg FPS · 10.9 P5 FPS ❌ (target: ≥52) · 1ms TBT · 69.0 MB heap
large-graph-idle: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.0 MB heap
large-graph-pan: 59.6 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.9 MB heap
large-graph-zoom: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.9 MB heap
legacy-node-drag: 59.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.2 MB heap
minimap-geometry-cadence: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.9 MB heap
minimap-idle: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.2 MB heap
minimap-progress-execution-cadence: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.3 MB heap
minimap-topology-cadence: 59.7 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.1 MB heap
subgraph-dom-widget-clipping: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.4 MB heap
subgraph-idle: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.7 MB heap
subgraph-mouse-sweep: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.9 MB heap
subgraph-transition-enter: 51.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 153ms TBT · 111.3 MB heap
viewport-pan-sweep: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.1 MB heap
vue-large-graph-idle: 25.2 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 259.4 MB heap
vue-large-graph-pan: 19.3 avg FPS · 8.6 P5 FPS ❌ (target: ≥52) · 24ms TBT · 260.1 MB heap
vue-node-resize-workload: 21.1 avg FPS · 10.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 250.7 MB heap
vue-zoom-out-idle: 25.1 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 250.9 MB heap
workflow-execution: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.8 MB heap
agent-composer-empty-conversation-typing: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 37.1 MB heap
agent-composer-long-conversation-typing: 59.1 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 89.7 MB heap

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 3ms
canvas-idle: style recalc duration 3ms
canvas-idle: layout count 10
canvas-idle: style recalc count 10
canvas-idle: task duration 531ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 66.7 MB
canvas-idle: DOM nodes -81
canvas-idle: event listeners -35
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 2ms
canvas-mouse-sweep: style recalc duration 12ms
canvas-mouse-sweep: layout count 9
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 857ms
canvas-mouse-sweep: script duration 158ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 80.2 MB
canvas-mouse-sweep: DOM nodes 0
canvas-mouse-sweep: event listeners 6
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 3ms
canvas-zoom-sweep: style recalc duration 4ms
canvas-zoom-sweep: layout count 10
canvas-zoom-sweep: style recalc count 18
canvas-zoom-sweep: task duration 392ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 69.9 MB
canvas-zoom-sweep: DOM nodes 56
canvas-zoom-sweep: event listeners 43
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 2ms
dom-widget-clipping: style recalc duration 2ms
dom-widget-clipping: layout count 9
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 483ms
dom-widget-clipping: script duration 169ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 63.6 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 33ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 901ms
dom-widget-order-dense-n200-w200-i120: script duration 67ms
dom-widget-order-dense-n200-w200-i120: TBT 526ms
dom-widget-order-dense-n200-w200-i120: heap used 72.1 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -191
dom-widget-order-dense-n200-w200-i120: event listeners -107
dom-widget-order-sparse-n1000-w20-i120: avg frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 554ms
dom-widget-order-sparse-n1000-w20-i120: script duration 163ms
dom-widget-order-sparse-n1000-w20-i120: TBT 228ms
dom-widget-order-sparse-n1000-w20-i120: heap used 62.8 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes -191
dom-widget-order-sparse-n1000-w20-i120: event listeners -107
extension-clean-combined-draw: avg frame time 31ms
extension-clean-combined-draw: p95 frame time 50ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 9328ms
extension-clean-combined-draw: script duration 7389ms
extension-clean-combined-draw: TBT 801ms
extension-clean-combined-draw: heap used 122.3 MB
extension-clean-combined-draw: DOM nodes -257
extension-clean-combined-draw: event listeners -69
extension-rgthree-prototype-draw: avg frame time 32ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 0
extension-rgthree-prototype-draw: task duration 9200ms
extension-rgthree-prototype-draw: script duration 7346ms
extension-rgthree-prototype-draw: TBT 733ms
extension-rgthree-prototype-draw: heap used 134.5 MB
extension-rgthree-prototype-draw: DOM nodes -257
extension-rgthree-prototype-draw: event listeners -69
large-combo-open: avg frame time 26ms
large-combo-open: p95 frame time 92ms
large-combo-open: layout duration 2ms
large-combo-open: style recalc duration 12ms
large-combo-open: layout count 8
large-combo-open: style recalc count 21
large-combo-open: task duration 157ms
large-combo-open: script duration 8ms
large-combo-open: TBT 1ms
large-combo-open: heap used 69.0 MB
large-combo-open: DOM nodes -690
large-combo-open: event listeners 205
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 2ms
large-graph-idle: style recalc duration 2ms
large-graph-idle: layout count 8
large-graph-idle: style recalc count 9
large-graph-idle: task duration 626ms
large-graph-idle: script duration 33ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 70.0 MB
large-graph-idle: DOM nodes -257
large-graph-idle: event listeners -69
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 2ms
large-graph-pan: style recalc duration 8ms
large-graph-pan: layout count 8
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1693ms
large-graph-pan: script duration 825ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 74.9 MB
large-graph-pan: DOM nodes -257
large-graph-pan: event listeners -67
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 10ms
large-graph-zoom: style recalc duration 9ms
large-graph-zoom: layout count 64
large-graph-zoom: style recalc count 71
large-graph-zoom: task duration 1765ms
large-graph-zoom: script duration 771ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 63.9 MB
large-graph-zoom: DOM nodes -233
large-graph-zoom: event listeners -69
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 1ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 5
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 1915ms
legacy-node-drag: script duration 964ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 77.2 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 182
minimap-geometry-cadence: avg frame time 17ms
minimap-geometry-cadence: p95 frame time 17ms
minimap-geometry-cadence: layout duration 2ms
minimap-geometry-cadence: style recalc duration 2ms
minimap-geometry-cadence: layout count 7
minimap-geometry-cadence: style recalc count 8
minimap-geometry-cadence: task duration 786ms
minimap-geometry-cadence: script duration 360ms
minimap-geometry-cadence: TBT 0ms
minimap-geometry-cadence: heap used 68.9 MB
minimap-geometry-cadence: DOM nodes -257
minimap-geometry-cadence: event listeners -69
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 2ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 8
minimap-idle: style recalc count 8
minimap-idle: task duration 663ms
minimap-idle: script duration 34ms
minimap-idle: TBT 0ms
minimap-idle: heap used 61.2 MB
minimap-idle: DOM nodes -257
minimap-idle: event listeners -69
minimap-progress-execution-cadence: avg frame time 17ms
minimap-progress-execution-cadence: p95 frame time 17ms
minimap-progress-execution-cadence: layout duration 1ms
minimap-progress-execution-cadence: style recalc duration 12ms
minimap-progress-execution-cadence: layout count 6
minimap-progress-execution-cadence: style recalc count 25
minimap-progress-execution-cadence: task duration 600ms
minimap-progress-execution-cadence: script duration 187ms
minimap-progress-execution-cadence: TBT 0ms
minimap-progress-execution-cadence: heap used 70.3 MB
minimap-progress-execution-cadence: DOM nodes -254
minimap-progress-execution-cadence: event listeners -69
minimap-topology-cadence: avg frame time 17ms
minimap-topology-cadence: p95 frame time 17ms
minimap-topology-cadence: layout duration 2ms
minimap-topology-cadence: style recalc duration 2ms
minimap-topology-cadence: layout count 7
minimap-topology-cadence: style recalc count 7
minimap-topology-cadence: task duration 954ms
minimap-topology-cadence: script duration 388ms
minimap-topology-cadence: TBT 0ms
minimap-topology-cadence: heap used 78.1 MB
minimap-topology-cadence: DOM nodes -257
minimap-topology-cadence: event listeners -69
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 2ms
subgraph-dom-widget-clipping: style recalc duration 4ms
subgraph-dom-widget-clipping: layout count 9
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 442ms
subgraph-dom-widget-clipping: script duration 147ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 58.4 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 3ms
subgraph-idle: style recalc duration 2ms
subgraph-idle: layout count 9
subgraph-idle: style recalc count 10
subgraph-idle: task duration 532ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 61.7 MB
subgraph-idle: DOM nodes 0
subgraph-idle: event listeners 0
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 13ms
subgraph-mouse-sweep: layout count 10
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 792ms
subgraph-mouse-sweep: script duration 104ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 69.9 MB
subgraph-mouse-sweep: DOM nodes 0
subgraph-mouse-sweep: event listeners 6
subgraph-transition-enter: avg frame time 20ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 22ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 1030ms
subgraph-transition-enter: script duration 32ms
subgraph-transition-enter: TBT 153ms
subgraph-transition-enter: heap used 111.3 MB
subgraph-transition-enter: DOM nodes 16030
subgraph-transition-enter: event listeners 3246
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 2ms
viewport-pan-sweep: style recalc duration 28ms
viewport-pan-sweep: layout count 9
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 5791ms
viewport-pan-sweep: script duration 2664ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 82.1 MB
viewport-pan-sweep: DOM nodes -257
viewport-pan-sweep: event listeners -67
vue-large-graph-idle: avg frame time 40ms
vue-large-graph-idle: p95 frame time 83ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 22199ms
vue-large-graph-idle: script duration 304ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 259.4 MB
vue-large-graph-idle: DOM nodes -3343
vue-large-graph-idle: event listeners -653
vue-large-graph-pan: avg frame time 52ms
vue-large-graph-pan: p95 frame time 117ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 181
vue-large-graph-pan: task duration 27652ms
vue-large-graph-pan: script duration 890ms
vue-large-graph-pan: TBT 24ms
vue-large-graph-pan: heap used 260.1 MB
vue-large-graph-pan: DOM nodes -3343
vue-large-graph-pan: event listeners -651
vue-node-resize-workload: avg frame time 47ms
vue-node-resize-workload: p95 frame time 100ms
vue-node-resize-workload: layout duration 22ms
vue-node-resize-workload: style recalc duration 65ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 8168ms
vue-node-resize-workload: script duration 122ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 250.7 MB
vue-node-resize-workload: DOM nodes -3345
vue-node-resize-workload: event listeners -653
vue-zoom-out-idle: avg frame time 40ms
vue-zoom-out-idle: p95 frame time 83ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 11070ms
vue-zoom-out-idle: script duration 149ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 250.9 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 4ms
workflow-execution: style recalc duration 8ms
workflow-execution: layout count 10
workflow-execution: style recalc count 10
workflow-execution: task duration 95ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 63.8 MB
workflow-execution: DOM nodes 112
workflow-execution: event listeners 4
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 14ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 378ms
agent-composer-empty-conversation-typing: script duration 183ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 37.1 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 16ms
agent-composer-long-conversation-typing: style recalc duration 2ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 509ms
agent-composer-long-conversation-typing: script duration 202ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 89.7 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 300
Raw data
{
  "timestamp": "2026-11-02T02:55:14.028Z",
  "gitSha": "5e6be9f5fdba3e249314e487f240e3beb90be550",
  "branch": "backport-22244-to-cloud-1.59",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2007.3150000000055,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.878,
      "layouts": 10,
      "layoutDurationMs": 3.0749999999999997,
      "taskDurationMs": 521.9730000000001,
      "heapDeltaBytes": 4939524,
      "heapUsedBytes": 74928044,
      "domNodes": 0,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 8.170999999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666942148760334,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "canvas-idle",
      "durationMs": 2039.715000000001,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.543,
      "layouts": 9,
      "layoutDurationMs": 2.7040000000000006,
      "taskDurationMs": 540.591,
      "heapDeltaBytes": 3545784,
      "heapUsedBytes": 65004448,
      "domNodes": -161,
      "jsHeapTotalBytes": 8388608,
      "scriptDurationMs": 8.112000000000002,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1759.0979999999945,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 11.781999999999998,
      "layouts": 9,
      "layoutDurationMs": 2.3049999999999997,
      "taskDurationMs": 858.468,
      "heapDeltaBytes": 23816040,
      "heapUsedBytes": 85399232,
      "domNodes": 0,
      "jsHeapTotalBytes": 9699328,
      "scriptDurationMs": 155.53,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665714285714287,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1770.2520000000277,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 11.918000000000001,
      "layouts": 8,
      "layoutDurationMs": 2.1659999999999995,
      "taskDurationMs": 855.279,
      "heapDeltaBytes": 21484284,
      "heapUsedBytes": 82860060,
      "domNodes": 0,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 159.81,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666037735849052,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1735.3800000000206,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 4.135999999999999,
      "layouts": 10,
      "layoutDurationMs": 2.642,
      "taskDurationMs": 388.37600000000003,
      "heapDeltaBytes": 25335404,
      "heapUsedBytes": 86102232,
      "domNodes": 56,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 9.832999999999998,
      "eventListeners": 43,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846156,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1724.4480000000522,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 4.345999999999999,
      "layouts": 10,
      "layoutDurationMs": 2.4219999999999997,
      "taskDurationMs": 396.287,
      "heapDeltaBytes": -948168,
      "heapUsedBytes": 60550196,
      "domNodes": 56,
      "jsHeapTotalBytes": 9437184,
      "scriptDurationMs": 9.785000000000002,
      "eventListeners": 43,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665384615384614,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 666.2119999999732,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 2.302,
      "layouts": 8,
      "layoutDurationMs": 1.94,
      "taskDurationMs": 481.244,
      "heapDeltaBytes": 5327476,
      "heapUsedBytes": 67117968,
      "domNodes": 0,
      "jsHeapTotalBytes": 9699328,
      "scriptDurationMs": 168.952,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 689.6339999999554,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 2.483,
      "layouts": 9,
      "layoutDurationMs": 2.449,
      "taskDurationMs": 483.937,
      "heapDeltaBytes": 5142848,
      "heapUsedBytes": 66205880,
      "domNodes": 0,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 169.493,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66585365853659,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1231.4589999999725,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 921.8,
      "heapDeltaBytes": -12242832,
      "heapUsedBytes": 75407412,
      "domNodes": -191,
      "jsHeapTotalBytes": 19931136,
      "scriptDurationMs": 69.406,
      "eventListeners": -107,
      "totalBlockingTimeMs": 538,
      "frameDurationMs": 33.33513513513514,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1192.8550000000087,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 880.4419999999999,
      "heapDeltaBytes": -1896432,
      "heapUsedBytes": 75787556,
      "domNodes": -191,
      "jsHeapTotalBytes": 12591104,
      "scriptDurationMs": 64.822,
      "eventListeners": -107,
      "totalBlockingTimeMs": 514,
      "frameDurationMs": 32.42972972972973,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 911.8330000000014,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 560.6369999999994,
      "heapDeltaBytes": -28200160,
      "heapUsedBytes": 66365208,
      "domNodes": -191,
      "jsHeapTotalBytes": 3538944,
      "scriptDurationMs": 164.524,
      "eventListeners": -107,
      "totalBlockingTimeMs": 224,
      "frameDurationMs": 24.324324324324323,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 894.5089999999709,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 548.3409999999998,
      "heapDeltaBytes": -30311544,
      "heapUsedBytes": 65399532,
      "domNodes": -191,
      "jsHeapTotalBytes": 3145728,
      "scriptDurationMs": 161.57300000000004,
      "eventListeners": -107,
      "totalBlockingTimeMs": 231,
      "frameDurationMs": 25,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10128.488000000005,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9290.034,
      "heapDeltaBytes": 35656492,
      "heapUsedBytes": 118570708,
      "domNodes": -257,
      "jsHeapTotalBytes": 50196480,
      "scriptDurationMs": 7305.195000000001,
      "eventListeners": -69,
      "totalBlockingTimeMs": 856,
      "frameDurationMs": 31.178153846153844,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10129.955999999993,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9366.121,
      "heapDeltaBytes": 63542528,
      "heapUsedBytes": 137888356,
      "domNodes": -257,
      "jsHeapTotalBytes": 65925120,
      "scriptDurationMs": 7472.341,
      "eventListeners": -69,
      "totalBlockingTimeMs": 745,
      "frameDurationMs": 31.613124999999997,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 10207.110999999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9412.073999999999,
      "heapDeltaBytes": 80311364,
      "heapUsedBytes": 154546552,
      "domNodes": -257,
      "jsHeapTotalBytes": 70381568,
      "scriptDurationMs": 7523.389,
      "eventListeners": -69,
      "totalBlockingTimeMs": 829,
      "frameDurationMs": 31.479938271604937,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9729.066999999986,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8988.115,
      "heapDeltaBytes": 54620184,
      "heapUsedBytes": 127529228,
      "domNodes": -257,
      "jsHeapTotalBytes": 61730816,
      "scriptDurationMs": 7169.120999999999,
      "eventListeners": -69,
      "totalBlockingTimeMs": 637,
      "frameDurationMs": 31.752614379084964,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "large-combo-open",
      "durationMs": 206.8360000000098,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 11.606,
      "layouts": 9,
      "layoutDurationMs": 2.172,
      "taskDurationMs": 154.39600000000002,
      "heapDeltaBytes": 14640016,
      "heapUsedBytes": 73854624,
      "domNodes": 936,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.088000000000001,
      "eventListeners": 205,
      "totalBlockingTimeMs": 1,
      "frameDurationMs": 27.07499999999999,
      "p95FrameDurationMs": 100.09999999999991
    },
    {
      "name": "large-combo-open",
      "durationMs": 212.0429999999942,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 11.770000000000001,
      "layouts": 7,
      "layoutDurationMs": 2.017,
      "taskDurationMs": 159.73900000000003,
      "heapDeltaBytes": 14620160,
      "heapUsedBytes": 70789040,
      "domNodes": -2315,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.492999999999999,
      "eventListeners": 205,
      "totalBlockingTimeMs": 1,
      "frameDurationMs": 24.077777777777758,
      "p95FrameDurationMs": 83.30000000000018
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2056.896999999992,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.344,
      "layouts": 8,
      "layoutDurationMs": 2.213,
      "taskDurationMs": 624.1920000000001,
      "heapDeltaBytes": -10439400,
      "heapUsedBytes": 63467060,
      "domNodes": -257,
      "jsHeapTotalBytes": 4321280,
      "scriptDurationMs": 32.246,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666664,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2040.8649999999398,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.1580000000000004,
      "layouts": 8,
      "layoutDurationMs": 2.311,
      "taskDurationMs": 627.8340000000001,
      "heapDeltaBytes": 6256400,
      "heapUsedBytes": 83332872,
      "domNodes": -257,
      "jsHeapTotalBytes": 3272704,
      "scriptDurationMs": 34.59400000000001,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2412.419,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 8.402,
      "layouts": 8,
      "layoutDurationMs": 1.905,
      "taskDurationMs": 1675.0919999999999,
      "heapDeltaBytes": -6828652,
      "heapUsedBytes": 85248728,
      "domNodes": -257,
      "jsHeapTotalBytes": 4845568,
      "scriptDurationMs": 813.192,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.78194444444444,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2466.527000000042,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 8.211,
      "layouts": 8,
      "layoutDurationMs": 1.9040000000000001,
      "taskDurationMs": 1709.9250000000002,
      "heapDeltaBytes": -20289560,
      "heapUsedBytes": 71858252,
      "domNodes": -257,
      "jsHeapTotalBytes": 5894144,
      "scriptDurationMs": 837.41,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.779591836734692,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3555.8279999999627,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 9.078,
      "layouts": 64,
      "layoutDurationMs": 10.05,
      "taskDurationMs": 1762.381,
      "heapDeltaBytes": -16037712,
      "heapUsedBytes": 64048100,
      "domNodes": -233,
      "jsHeapTotalBytes": 4845568,
      "scriptDurationMs": 779.1120000000001,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665727699530514,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3654.724999999985,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 9.298,
      "layouts": 64,
      "layoutDurationMs": 10.511,
      "taskDurationMs": 1767.0849999999998,
      "heapDeltaBytes": -8552232,
      "heapUsedBytes": 69959872,
      "domNodes": -233,
      "jsHeapTotalBytes": 5107712,
      "scriptDurationMs": 762.205,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666210045662098,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2966.206999999997,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 4.597,
      "layouts": 5,
      "layoutDurationMs": 1.2690000000000006,
      "taskDurationMs": 1925.3149999999998,
      "heapDeltaBytes": 15912432,
      "heapUsedBytes": 89434088,
      "domNodes": 0,
      "jsHeapTotalBytes": 4349952,
      "scriptDurationMs": 980.743,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.854237288135593,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2986.8569999999863,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 4.98,
      "layouts": 5,
      "layoutDurationMs": 1.2300000000000002,
      "taskDurationMs": 1905.538,
      "heapDeltaBytes": -10410808,
      "heapUsedBytes": 72406860,
      "domNodes": 0,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 948.0439999999999,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.759550561797756,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-geometry-cadence",
      "durationMs": 3039.2539999999713,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 1.5640000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.3610000000000002,
      "taskDurationMs": 775.885,
      "heapDeltaBytes": 10083020,
      "heapUsedBytes": 85638816,
      "domNodes": -257,
      "jsHeapTotalBytes": 3534848,
      "scriptDurationMs": 361.822,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666483516483513,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-geometry-cadence",
      "durationMs": 3050.479999999993,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.02,
      "layouts": 7,
      "layoutDurationMs": 2.006,
      "taskDurationMs": 796.446,
      "heapDeltaBytes": -34320676,
      "heapUsedBytes": 58854816,
      "domNodes": -257,
      "jsHeapTotalBytes": 4358144,
      "scriptDurationMs": 357.63,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2047.8620000000092,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 2.037,
      "layouts": 7,
      "layoutDurationMs": 2.1600000000000006,
      "taskDurationMs": 686.019,
      "heapDeltaBytes": -13431724,
      "heapUsedBytes": 63904712,
      "domNodes": -257,
      "jsHeapTotalBytes": 3796992,
      "scriptDurationMs": 32.472,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536587,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2047.8749999999764,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.0360000000000005,
      "layouts": 8,
      "layoutDurationMs": 2.411,
      "taskDurationMs": 640.026,
      "heapDeltaBytes": -12588628,
      "heapUsedBytes": 64413136,
      "domNodes": -257,
      "jsHeapTotalBytes": 3796992,
      "scriptDurationMs": 35.666,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-progress-execution-cadence",
      "durationMs": 2740.0779999999827,
      "styleRecalcs": 25,
      "styleRecalcDurationMs": 12.09,
      "layouts": 6,
      "layoutDurationMs": 1.408,
      "taskDurationMs": 594.699,
      "heapDeltaBytes": 1898348,
      "heapUsedBytes": 79766564,
      "domNodes": -252,
      "jsHeapTotalBytes": 3534848,
      "scriptDurationMs": 185.08600000000004,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66646341463414,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-progress-execution-cadence",
      "durationMs": 2700.3499999999576,
      "styleRecalcs": 25,
      "styleRecalcDurationMs": 12.106000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.5440000000000003,
      "taskDurationMs": 606.053,
      "heapDeltaBytes": -25100596,
      "heapUsedBytes": 67588248,
      "domNodes": -255,
      "jsHeapTotalBytes": 5668864,
      "scriptDurationMs": 189.384,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66604938271605,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-topology-cadence",
      "durationMs": 3243.326999999965,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 1.751,
      "layouts": 7,
      "layoutDurationMs": 1.487,
      "taskDurationMs": 947.1489999999999,
      "heapDeltaBytes": 7602264,
      "heapUsedBytes": 84225572,
      "domNodes": -257,
      "jsHeapTotalBytes": 4583424,
      "scriptDurationMs": 376.79200000000003,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665979381443297,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-topology-cadence",
      "durationMs": 3322.1399999999903,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 1.4579999999999993,
      "layouts": 6,
      "layoutDurationMs": 1.5379999999999998,
      "taskDurationMs": 960.136,
      "heapDeltaBytes": -564836,
      "heapUsedBytes": 79640032,
      "domNodes": -257,
      "jsHeapTotalBytes": 5369856,
      "scriptDurationMs": 398.884,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.83502538071066,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 594.9710000000437,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 4.481,
      "layouts": 9,
      "layoutDurationMs": 2.352,
      "taskDurationMs": 438.9820000000001,
      "heapDeltaBytes": -1438072,
      "heapUsedBytes": 61017284,
      "domNodes": 0,
      "jsHeapTotalBytes": 8912896,
      "scriptDurationMs": 145.33300000000003,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66571428571429,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 609.1900000000123,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 4.516,
      "layouts": 8,
      "layoutDurationMs": 2.1959999999999997,
      "taskDurationMs": 444.859,
      "heapDeltaBytes": -1326380,
      "heapUsedBytes": 61544924,
      "domNodes": 0,
      "jsHeapTotalBytes": 8388608,
      "scriptDurationMs": 147.934,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667567567567563,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.6750000000397,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.3280000000000003,
      "layouts": 8,
      "layoutDurationMs": 2.716,
      "taskDurationMs": 550.6099999999999,
      "heapDeltaBytes": 2238396,
      "heapUsedBytes": 64595904,
      "domNodes": 0,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 7.124000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.6480000000174,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.615,
      "layouts": 9,
      "layoutDurationMs": 2.342,
      "taskDurationMs": 513.2750000000001,
      "heapDeltaBytes": 2616984,
      "heapUsedBytes": 64825872,
      "domNodes": 0,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 7.4990000000000006,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1707.9669999999965,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 12.655999999999999,
      "layouts": 10,
      "layoutDurationMs": 3.044,
      "taskDurationMs": 798.042,
      "heapDeltaBytes": 18807120,
      "heapUsedBytes": 80404980,
      "domNodes": 0,
      "jsHeapTotalBytes": 8912896,
      "scriptDurationMs": 103.152,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66764705882353,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1692.4850000000333,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 12.674999999999999,
      "layouts": 10,
      "layoutDurationMs": 2.407,
      "taskDurationMs": 786.277,
      "heapDeltaBytes": -5618832,
      "heapUsedBytes": 66195952,
      "domNodes": 0,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 105.586,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665686274509806,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1435.6910000000198,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 22.446,
      "layouts": 5,
      "layoutDurationMs": 14.296,
      "taskDurationMs": 1029.623,
      "heapDeltaBytes": 14242012,
      "heapUsedBytes": 116684272,
      "domNodes": 16030,
      "jsHeapTotalBytes": 16125952,
      "scriptDurationMs": 31.709,
      "eventListeners": 3246,
      "totalBlockingTimeMs": 153,
      "frameDurationMs": 19.594594594594593,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8773.851999999977,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 27.33,
      "layouts": 9,
      "layoutDurationMs": 2.3420000000000005,
      "taskDurationMs": 5731.334000000001,
      "heapDeltaBytes": 5057452,
      "heapUsedBytes": 81849436,
      "domNodes": -257,
      "jsHeapTotalBytes": 5332992,
      "scriptDurationMs": 2654.636,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66584440227704,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9073.869000000059,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 28.269000000000002,
      "layouts": 9,
      "layoutDurationMs": 2.241,
      "taskDurationMs": 5850.819,
      "heapDeltaBytes": -394432,
      "heapUsedBytes": 90418436,
      "domNodes": -257,
      "jsHeapTotalBytes": 6156288,
      "scriptDurationMs": 2673.4249999999997,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666176470588233,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 23047.85099999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22363.500000000004,
      "heapDeltaBytes": -3507928,
      "heapUsedBytes": 278440728,
      "domNodes": -3343,
      "jsHeapTotalBytes": 16506880,
      "scriptDurationMs": 303.66499999999996,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 39.33276450511946,
      "p95FrameDurationMs": 83.30000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 22858.665999999972,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22034.549000000003,
      "heapDeltaBytes": -35421360,
      "heapUsedBytes": 265479020,
      "domNodes": -3343,
      "jsHeapTotalBytes": 14147584,
      "scriptDurationMs": 304.124,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 40.01611208406304,
      "p95FrameDurationMs": 83.30000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 28060.70600000004,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 17.99999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 27740.829,
      "heapDeltaBytes": -432264,
      "heapUsedBytes": 282083512,
      "domNodes": -3343,
      "jsHeapTotalBytes": 10141696,
      "scriptDurationMs": 875.9259999999999,
      "eventListeners": -651,
      "totalBlockingTimeMs": 30,
      "frameDurationMs": 52.624577861163225,
      "p95FrameDurationMs": 116.59999999999854
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 27891.237999999932,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 17.707,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 27562.838000000003,
      "heapDeltaBytes": -27293760,
      "heapUsedBytes": 263431508,
      "domNodes": -3343,
      "jsHeapTotalBytes": 15196160,
      "scriptDurationMs": 903.476,
      "eventListeners": -651,
      "totalBlockingTimeMs": 18,
      "frameDurationMs": 51.06630036630036,
      "p95FrameDurationMs": 116.59999999999854
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 8247.247999999956,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 65.43099999999998,
      "layouts": 20,
      "layoutDurationMs": 22.358000000000004,
      "taskDurationMs": 8137.231,
      "heapDeltaBytes": -17412196,
      "heapUsedBytes": 274226048,
      "domNodes": -3343,
      "jsHeapTotalBytes": 20963328,
      "scriptDurationMs": 124.19400000000002,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 46.87329545454545,
      "p95FrameDurationMs": 100
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 8354.604999999992,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 64.74499999999999,
      "layouts": 20,
      "layoutDurationMs": 21.679000000000002,
      "taskDurationMs": 8199.193999999998,
      "heapDeltaBytes": -30918580,
      "heapUsedBytes": 251535276,
      "domNodes": -3347,
      "jsHeapTotalBytes": 15716352,
      "scriptDurationMs": 119.354,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 48.071676300578034,
      "p95FrameDurationMs": 100.09999999999854
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 11396.878000000015,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11115.541000000001,
      "heapDeltaBytes": -18866500,
      "heapUsedBytes": 254302204,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 148.60399999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 38.90580204778158,
      "p95FrameDurationMs": 83.29999999999927
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 11417.655999999966,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11024.159,
      "heapDeltaBytes": 285204,
      "heapUsedBytes": 271937036,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 150.09899999999993,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 40.6270462633452,
      "p95FrameDurationMs": 83.30000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 121.970000000033,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.594000000000001,
      "layouts": 9,
      "layoutDurationMs": 3.934999999999999,
      "taskDurationMs": 89.19699999999999,
      "heapDeltaBytes": 4805440,
      "heapUsedBytes": 66070100,
      "domNodes": 124,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.385,
      "eventListeners": 5,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.662499999999966,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 461.4160000000993,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.278,
      "layouts": 10,
      "layoutDurationMs": 3.5829999999999993,
      "taskDurationMs": 101.113,
      "heapDeltaBytes": 6620516,
      "heapUsedBytes": 67689256,
      "domNodes": 99,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.721,
      "eventListeners": 3,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.662962962962965,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 413.0330000000413,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.599,
      "layouts": 76,
      "layoutDurationMs": 13.484,
      "taskDurationMs": 372.89500000000004,
      "heapDeltaBytes": -5094320,
      "heapUsedBytes": 38395264,
      "domNodes": 4,
      "jsHeapTotalBytes": 2359296,
      "scriptDurationMs": 182.476,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66538461538462,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 431.3729999998941,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.638,
      "layouts": 76,
      "layoutDurationMs": 14.373000000000001,
      "taskDurationMs": 383.88800000000003,
      "heapDeltaBytes": -4850220,
      "heapUsedBytes": 39507736,
      "domNodes": 4,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 183.492,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.661538461538456,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 514.0290000000505,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.721,
      "layouts": 76,
      "layoutDurationMs": 14.248000000000001,
      "taskDurationMs": 480.557,
      "heapDeltaBytes": 387640,
      "heapUsedBytes": 103100780,
      "domNodes": 4,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 186.839,
      "eventListeners": 300,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667741935483864,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 603.0680000000075,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.5839999999999999,
      "layouts": 76,
      "layoutDurationMs": 17.052,
      "taskDurationMs": 536.592,
      "heapDeltaBytes": 1434540,
      "heapUsedBytes": 84960884,
      "domNodes": 4,
      "jsHeapTotalBytes": 528384,
      "scriptDurationMs": 217.22,
      "eventListeners": 300,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.14571428571427,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage: 🟡 60.0% of lines

Coverage totals
Metric Covered Total Pct
Lines 60661 101149 60.0% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1179
src/workbench/extensions/agent/composables/agent/useAgentSession.ts 13.9% 714
src/workbench/extensions/agent/crdt/liveGraphApplier.ts 2.1% 657
src/workbench/extensions/agent/AgentPanelRoot.vue 27.6% 566
src/workbench/extensions/agent/stores/agent/agentConversationStore.ts 13.5% 557
src/workbench/extensions/agent/crdt/docOpMinter.ts 4.3% 425
src/LGraphNode.ts 71.3% 379
src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts 26.1% 379
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 39.6% 332
src/platform/billing/components/TopUpCreditsDialogContentWorkspace.vue 0.9% 321

🎭 Playwright: ✅ 3128 passed, 0 failed · 5 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2319 / ❌ 0 / ⚠️ 5 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 778 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • desktop: View Report (✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 11/02/2026, 02:44:30 AM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since afb19e8a6a1babec947de2b4c62f7ae5546ad156

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (241)

  • workspace path matches no source files: src/platform/workspace/fixtures/**. Remove or update it in docs/architecture/domains/records/workspace.domain.json.
  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/Popover.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupEnforcementBoundary.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/syncPromotedComboHostOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/legacyUI/attachLegacyUI.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/agentPanel.historyIdentity.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cloudBadges.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/dynamicPrompts.serializeValue.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/electronAdapter.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/index.cloud.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/index.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/findNumericWidget.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dLazy.retry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dSettings.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dWidgets.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dWidgets.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/slotDefaults.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchPointerGuards.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/ContextMenu.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/LGraphCanvas.startRendering.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 191 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

@github-actions
github-actions Bot requested a review from thedatalife November 2, 2026 01:19
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Nov 2, 2026
@codecov

codecov Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.09589% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...sions/agent/stores/agent/agentConversationStore.ts 88.50% 10 Missing ⚠️
...ensions/agent/composables/agent/useAgentSession.ts 94.82% 3 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.59   #22681   +/-   ##
=============================================
  Coverage              ?   87.24%           
=============================================
  Files                 ?     3036           
  Lines                 ?   159628           
  Branches              ?    42677           
=============================================
  Hits                  ?   139262           
  Misses                ?    19687           
  Partials              ?      679           
Flag Coverage Δ
e2e 59.86% <4.54%> (?)
unit 86.60% <98.51%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...sions/agent/services/agent/turnRecoverySchedule.ts 100.00% <100.00%> (ø)
...ensions/agent/composables/agent/useAgentSession.ts 92.81% <94.82%> (ø)
...sions/agent/stores/agent/agentConversationStore.ts 92.04% <88.50%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

… at its deadline

Review follow-ups on the settled snapshot read:

- Retry an 'error' outcome only when isRetryableRequestFailure says a
  retry can help, so a refused or malformed read is reported at once
  instead of costing five more thread downloads.
- When the deadline aborts the read while it is still failing, report the
  last failure rather than swallowing it as an ordinary abort.
- Apply a successful read only while this read still owns the turn's key.
- Clear the recovery ledgers after finishRecovery again, so a deferred
  rerun still sees this recovery's observation, and only while this read
  owned the key.
- Drop the code comments the previous commit added.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the manual backport of #22244, including the follow-up #22678 (now approved on main).

Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Nov 2, 2026
…egistration (Comfy-Org#22678)

## Summary

Follow-up to Comfy-Org#22244
([FRONT-3659](https://linear.app/comfyorg/issue/FRONT-3659)). Three gaps
found in that PR's adversarial review, each a case where the restored
pre-reload thinking could still be lost after a reload mid-turn.

- **A late read could take a later turn's registration.**
`reconcileSettledTurn` matched on the turn id only. If the turn was
restored again (same-thread hydrate) and re-settled with a tool call
still held for canvas catch-up, a read still finishing for the earlier
settle consumed the new registration: on give-up the new turn never
reconciled, and on success a later transport emit overwrote it. It now
only consumes a registration that has been announced, which is the one
its own read was started for.
- **One transient read failure dropped the stored thinking.** The
settled read retried a row that still read as streaming but gave up on
the first failed read. A failed read that `isRetryableRequestFailure`
calls retryable now retries on the same `TURN_RECOVERY_DELAYS_MS`
schedule; a refused or malformed read (4xx, `ZodError`, unreadable
response) is reported at once. If the deadline fires while reads are
still failing, the last failure is reported instead of being swallowed
as an abort. The composer is already released, so the retry delays
nothing the user waits on.
- **Teardown cleared another recovery's ledgers.** The settled read
deleted the ask-observation and thread-missing ledgers even after a
newer recovery had taken the key. They are now cleared only while this
read owned the key (still after `finishRecovery`, so a deferred rerun
sees them first), and a successful read is applied only while it owns
the key.

## Verification

| Check | Result |
| --- | --- |
| New store case `keeps a re-registered held turn for its own read when
an earlier read lands late` | Red on `main` (the re-registered turn was
never announced), green here |
| New session case `reads a settled snapshot turn again after a
transient read failure` | Red on `main` (timed out with live thinking
only), green here |
| Updated session case: a settled read that keeps failing is reported
once, after the whole schedule | Red on `main` (3 reads, not 8), green
here |
| New session case `does not retry a settled snapshot read the server
refused` (401) | Red before the retry filter (8 reads), green here |
| New session case `reports a settled snapshot read that is still
failing when its deadline passes` | Red before the deadline change (not
reported), green here |
| Store and session suites | 490/490 green |
| `pnpm typecheck`, `oxlint --type-aware`, `oxfmt`, pre-commit hook |
Clean |

The ledger ownership guard has no dedicated test: reproducing it needs a
live recovery to take the key from the settled read mid-flight, and the
change only narrows when the two deletes run.

Backports: same targets as Comfy-Org#22244 (core/1.58, cloud/1.58, core/1.59,
cloud/1.59). Comfy-Org#22244's automatic backports all hit conflicts; the manual
ports Comfy-Org#22680, Comfy-Org#22681, Comfy-Org#22682 and Comfy-Org#22683 carry this change too.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport approved on current head.

christian-byrne added a commit that referenced this pull request Nov 2, 2026
…e turn finishes (FRONT-3659) (#22244) (#22683)

Manual backport of #22244 to this 1.58 branch, plus its follow-up #22678
(merged to `main` as cdbb0cb). The automatic backport hit conflicts
in `useAgentSession.ts` and `agentConversationStore.ts`.

Fixes [FRONT-3659](https://linear.app/comfyorg/issue/FRONT-3659): after
a reload while the agent is working, the thinking from before the reload
comes back when the turn finishes.

## What differs from main

The session side is the same as the 1.59 ports (#22680, #22681): 1.58
has no `RunningRecovery`/`finishRecovery`, so the settled read holds the
recovery key like `reconcileTurn` does and, on release, recovers the
turn if a hydrate restored it while the key was held.

The store differs more, because 1.58 has no `publishMessage` (transports
emit straight into `replaceActive`):

- The snapshot slot's transport now emits through a new
`publishSnapshotMessage`, which calls `replaceActive` and then announces
the settled snapshot turn once its held tool call clears. This is the
part of main's `publishMessage` this fix needs. Local and background
transports are unchanged.
- `createEventHook` is imported from `@vueuse/core`. Imports stay
relative, as on this branch.
- Everything else (the stored-row fold, canvas confirmation carry-over,
the tool offset, clearing registrations on reset and hydrate, the
announced-only guard from #22678, and all tests) applies as on main.

## Verification

- Store and session suites on this branch: 396/396 green, including
every case #22244 and #22678 add.
- `pnpm typecheck`, `pnpm typecheck:browser`, `oxfmt --check`, `oxlint`:
clean. Pre-push hook (`deps:audit`, `knip`, `fallow:audit`): clean.
- The browser spec `agentThinkingAcrossMidTurnReload.spec.ts` was not
run locally; this PR's E2E jobs passed at the current head.
- The red-on-parent proof was not repeated on this branch; it is on
#22244.

This head includes every change #22678 made in review, so it matches
what merged on `main`.

---------

Co-authored-by: GitHub Action <action@github.com>
christian-byrne added a commit that referenced this pull request Nov 2, 2026
… turn finishes (FRONT-3659) (#22244) (#22682)

Manual backport of #22244 to this 1.58 branch, plus its follow-up #22678
(merged to `main` as cdbb0cb). The automatic backport hit conflicts
in `useAgentSession.ts` and `agentConversationStore.ts`.

Fixes [FRONT-3659](https://linear.app/comfyorg/issue/FRONT-3659): after
a reload while the agent is working, the thinking from before the reload
comes back when the turn finishes.

## What differs from main

The session side is the same as the 1.59 ports (#22680, #22681): 1.58
has no `RunningRecovery`/`finishRecovery`, so the settled read holds the
recovery key like `reconcileTurn` does and, on release, recovers the
turn if a hydrate restored it while the key was held.

The store differs more, because 1.58 has no `publishMessage` (transports
emit straight into `replaceActive`):

- The snapshot slot's transport now emits through a new
`publishSnapshotMessage`, which calls `replaceActive` and then announces
the settled snapshot turn once its held tool call clears. This is the
part of main's `publishMessage` this fix needs. Local and background
transports are unchanged.
- `createEventHook` is imported from `@vueuse/core`. Imports stay
relative, as on this branch.
- Everything else (the stored-row fold, canvas confirmation carry-over,
the tool offset, clearing registrations on reset and hydrate, the
announced-only guard from #22678, and all tests) applies as on main.

## Verification

- Store and session suites on this branch: 396/396 green, including
every case #22244 and #22678 add.
- `pnpm typecheck`, `pnpm typecheck:browser`, `oxfmt --check`, `oxlint`:
clean. Pre-push hook (`deps:audit`, `knip`, `fallow:audit`): clean.
- The browser spec `agentThinkingAcrossMidTurnReload.spec.ts` was not
run locally; this PR's E2E jobs passed at the current head.
- The red-on-parent proof was not repeated on this branch; it is on
#22244.

This head includes every change #22678 made in review, so it matches
what merged on `main`.

---------

Co-authored-by: GitHub Action <action@github.com>
@christian-byrne
christian-byrne merged commit c203339 into cloud/1.59 Nov 2, 2026
107 checks passed
@christian-byrne
christian-byrne deleted the backport-22244-to-cloud-1.59 branch November 2, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants