Repository navigation
test(design-system): give the icon sizing build test a 30 s timeout - #22669
Conversation
The test runs a full Vite and Tailwind build. Under coverage in CI it took 6.4 s and failed the default 5 s timeout (unit / test-packages).
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9c5fa55ddff94f51335f507c0589f2c87a0f1f3b
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (348)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Set test timeout packages/design-system/src/css/iconSizing.test.ts |
The test declaration now sets a 30-second timeout. Its assertions are unchanged. |
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other
Suggested reviewers: drjkl
Merge Risk: 
Minimal · up to 82fdc
-
No actionable merge-blocking risk remains.
Pre-merge checks: 
6
-
Full details: Description check
-
Explanation
The description explains what changed, why the timeout is needed, the CI failure context, and local verification. It uses What, Why, and Proof headings instead of the template's Summary and Verification headings, but it provides the required information.
Full details: End-To-End Test Suggestion For User-Facing Changes
-
Explanation
The pull request changes only
packages/design-system/src/css/iconSizing.test.tsand only adjusts a test timeout. It does not change frontend behavior or add a feature. The check passes for test-only changes.
Full details: Adr Compliance For Entity/Litegraph Changes
-
Explanation
The changed-file list contains only
packages/design-system/src/css/iconSizing.test.ts. It does not modifysrc/lib/litegraph/,src/ecs/, or graph-entity files. The ADR compliance check is not applicable.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #22669 +/- ##
==========================================
- Coverage 87.62% 87.56% -0.06%
==========================================
Files 3003 3003
Lines 163470 163641 +171
Branches 43687 41704 -1983
==========================================
+ Hits 143239 143297 +58
- Misses 19300 19413 +113
Partials 931 931
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
✅ No high-signal findings.
Panel: 6/6 reviewers contributed findings.
dante01yoon
left a comment
There was a problem hiding this comment.
Verified the linked CI run: the test ran a full Vite + Tailwind build and hit the 5 s default at 6.4 s under coverage. A per-test timeout is the narrowest fix and no assertion changed. LGTM.
What
Gives
packages/design-system/src/css/iconSizing.test.tsa 30 s timeout (third argument toit, one line).Why
The test runs a full Vite + Tailwind build. In CI under coverage it took 6.4 s and failed the default 5 s timeout in
unit / test-packages(https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/41365064494, on #22666, which changes an unrelated test). Added in #21949.Proof
Passes locally. No assertion changed.