Repository navigation
[backport cloud/1.59] fix(workflow): stop deleting an unsaved tab's draft on a same-path save or its first load - #22668
Conversation
…ve or its first load (#22649) ## Summary Two ways an unsaved tab's draft could be deleted while the tab was still unsaved. Both showed up in release QA case C-163 (stagingcloud 1.59.3), where picking an unopened unsaved tab in the Agent's workflow picker after a reload deleted that tab's draft, and the next reload lost the tab. 1. **Moving a draft onto its own path deleted it.** `moveDraft` writes the payload under the new key, then deletes the old key. When the path does not change, both keys are the same, so the draft is deleted. Saving an unsaved tab under its current name hits this, because `saveWorkflowAs` renames it to the same path before saving. Now a same-key move only updates the index. 2. **A restored unsaved tab's first load deleted its draft.** A reload rebuilds each unsaved tab from its draft but gives the tab the current time. The first `load()` then sees the draft as older than the tab and removes it as stale. Opening the tab normally writes the draft again, but a load without a canvas switch (the Agent picker) leaves the tab with no draft. The restored tab now gets the draft's own time. This applies only to a tab created at the draft's own path from a draft with a valid id, never to a workflow that `createTemporary` reused. Linear: [FRONT-3774](https://linear.app/comfyorg/issue/FRONT-3774). The Agent picker side (loading the tab before saving it) is #22648. Merge this before #22648. Not a 1.59 regression: the same code is on every current train (1.56 to 1.59). ## Verification - `workflowDraftStoreV2.test.ts` "keeps the draft when moved onto its own path": red on `main` (`getDraft` returns null), green with the fix. - `useWorkflowPersistenceV2.test.ts` "keeps the draft of an unsaved background tab when it is first loaded": red on `main` (draft gone after `load()`), green with the fix. "leaves a reused workflow outside the workflows folder unstamped" is red without the path guard. All 42 tests in the file pass, and all 25 in `workflowDraftStoreV2.test.ts`. - Human QA after deploy: repeat the C-163 steps on stagingcloud. Expected: after the pick and another reload, the tab and its contents are still there.
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-02T00:21:28.073Z",
"gitSha": "efb5f5d9496635440327ca510a1579c893f3306e",
"branch": "backport-22649-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.819000000012,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8329999999999997,
"layouts": 9,
"layoutDurationMs": 2.6380000000000003,
"taskDurationMs": 490.32300000000004,
"heapDeltaBytes": 1727512,
"heapUsedBytes": 62587008,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 11.019,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2008.0920000000333,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.66,
"layouts": 9,
"layoutDurationMs": 2.341,
"taskDurationMs": 448.266,
"heapDeltaBytes": 1494676,
"heapUsedBytes": 61466624,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 8.841,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1724.9989999999968,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.158,
"layouts": 10,
"layoutDurationMs": 2.5060000000000002,
"taskDurationMs": 774.98,
"heapDeltaBytes": 21787816,
"heapUsedBytes": 82068004,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 128.97,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1679.249000000027,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.495999999999999,
"layouts": 9,
"layoutDurationMs": 2.2600000000000002,
"taskDurationMs": 642.35,
"heapDeltaBytes": 17463552,
"heapUsedBytes": 78343208,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 134.75600000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.6780000000203,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.970000000000001,
"layouts": 12,
"layoutDurationMs": 3.1580000000000004,
"taskDurationMs": 323.51,
"heapDeltaBytes": 583640,
"heapUsedBytes": 70742936,
"domNodes": 56,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 10.222999999999999,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.8509999999678,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.536999999999999,
"layouts": 10,
"layoutDurationMs": 2.35,
"taskDurationMs": 341.109,
"heapDeltaBytes": 24494636,
"heapUsedBytes": 84923572,
"domNodes": 56,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 10.883000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667307692307688,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 549.570000000017,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.726,
"layouts": 9,
"layoutDurationMs": 2.32,
"taskDurationMs": 386.598,
"heapDeltaBytes": 2903320,
"heapUsedBytes": 65106692,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 140.39499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636353,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 566.1230000000046,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.6599999999999997,
"layouts": 10,
"layoutDurationMs": 2.5149999999999997,
"taskDurationMs": 420.00699999999995,
"heapDeltaBytes": 3375476,
"heapUsedBytes": 64628480,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 140.19299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1098.0050000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 784.1310000000001,
"heapDeltaBytes": -13291592,
"heapUsedBytes": 75849588,
"domNodes": -191,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 54.76299999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 396,
"frameDurationMs": 28.94736842105262,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1093.4060000000159,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 767.4380000000001,
"heapDeltaBytes": -890964,
"heapUsedBytes": 75604688,
"domNodes": -191,
"jsHeapTotalBytes": 14950400,
"scriptDurationMs": 47.708,
"eventListeners": -106,
"totalBlockingTimeMs": 415,
"frameDurationMs": 29.72702702702703,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 813.4430000000066,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.9479999999997,
"heapDeltaBytes": -28319268,
"heapUsedBytes": 65866680,
"domNodes": -191,
"jsHeapTotalBytes": 4063232,
"scriptDurationMs": 122.70399999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 162,
"frameDurationMs": 22.68333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 780.8810000000221,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.4639999999997,
"heapDeltaBytes": -4443452,
"heapUsedBytes": 70095604,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 123.743,
"eventListeners": 0,
"totalBlockingTimeMs": 162,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8128.665999999981,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.22400000000000025,
"layouts": 1,
"layoutDurationMs": 0.22199999999999998,
"taskDurationMs": 7240.592000000001,
"heapDeltaBytes": 83847832,
"heapUsedBytes": 156572888,
"domNodes": -257,
"jsHeapTotalBytes": 64352256,
"scriptDurationMs": 5460.873,
"eventListeners": -68,
"totalBlockingTimeMs": 39,
"frameDurationMs": 24.133234421364985,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7537.322000000017,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5710000000000003,
"layouts": 2,
"layoutDurationMs": 0.581,
"taskDurationMs": 6675.2080000000005,
"heapDeltaBytes": 53227324,
"heapUsedBytes": 124841948,
"domNodes": -257,
"jsHeapTotalBytes": 59895808,
"scriptDurationMs": 5145.79,
"eventListeners": -68,
"totalBlockingTimeMs": 63,
"frameDurationMs": 24.300000000000004,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7914.636000000001,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6499999999999996,
"layouts": 2,
"layoutDurationMs": 0.4729999999999999,
"taskDurationMs": 6989.188,
"heapDeltaBytes": 54838904,
"heapUsedBytes": 128983460,
"domNodes": -257,
"jsHeapTotalBytes": 61730816,
"scriptDurationMs": 5392.331999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 112,
"frameDurationMs": 23.98939393939394,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7964.6650000000245,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.3130000000000008,
"layouts": 2,
"layoutDurationMs": 0.48400000000000004,
"taskDurationMs": 7185.079,
"heapDeltaBytes": 59501604,
"heapUsedBytes": 133716800,
"domNodes": -257,
"jsHeapTotalBytes": 66187264,
"scriptDurationMs": 5590.212,
"eventListeners": -68,
"totalBlockingTimeMs": 72,
"frameDurationMs": 24.43680981595092,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "large-combo-open",
"durationMs": 267.59000000001265,
"styleRecalcs": 23,
"styleRecalcDurationMs": 19.765,
"layouts": 12,
"layoutDurationMs": 4.867999999999999,
"taskDurationMs": 222.53099999999998,
"heapDeltaBytes": -6845272,
"heapUsedBytes": 68467964,
"domNodes": 750,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 13.038999999999998,
"eventListeners": 64,
"totalBlockingTimeMs": 43,
"frameDurationMs": 28.34000000000001,
"p95FrameDurationMs": 133.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 181.28899999999248,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.827,
"layouts": 10,
"layoutDurationMs": 2.5170000000000003,
"taskDurationMs": 142.73800000000003,
"heapDeltaBytes": 14479384,
"heapUsedBytes": 90073916,
"domNodes": 936,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 7.039,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.92500000000001,
"p95FrameDurationMs": 66.70000000000027
},
{
"name": "large-graph-idle",
"durationMs": 2024.9630000000138,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5639999999999996,
"layouts": 9,
"layoutDurationMs": 2.6830000000000003,
"taskDurationMs": 628.014,
"heapDeltaBytes": -12016676,
"heapUsedBytes": 63146848,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 36.769,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2024.9220000000037,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.169,
"layouts": 8,
"layoutDurationMs": 1.981,
"taskDurationMs": 515.8199999999999,
"heapDeltaBytes": 4949660,
"heapUsedBytes": 82153048,
"domNodes": -257,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 30.039,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66475409836066,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2736.2150000000156,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.343,
"layouts": 7,
"layoutDurationMs": 1.7959999999999998,
"taskDurationMs": 1460.3760000000002,
"heapDeltaBytes": -3939728,
"heapUsedBytes": 72053028,
"domNodes": -257,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 680.3399999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666463414634144,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2420.11100000002,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.965,
"layouts": 8,
"layoutDurationMs": 1.9949999999999999,
"taskDurationMs": 1383.0059999999999,
"heapDeltaBytes": -29569040,
"heapUsedBytes": 62128392,
"domNodes": -257,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 650.695,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66551724137931,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3752.907999999991,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.137,
"layouts": 64,
"layoutDurationMs": 10.642999999999999,
"taskDurationMs": 1562.7590000000002,
"heapDeltaBytes": 2999272,
"heapUsedBytes": 79257416,
"domNodes": -233,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 654.356,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66577777777778,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3606.6430000000764,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.81,
"layouts": 66,
"layoutDurationMs": 10.369,
"taskDurationMs": 1524.909,
"heapDeltaBytes": -14276764,
"heapUsedBytes": 65522660,
"domNodes": -233,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 651.845,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66574074074074,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2901.6449999999736,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.605,
"layouts": 6,
"layoutDurationMs": 1.5050000000000003,
"taskDurationMs": 1714.164,
"heapDeltaBytes": 15563140,
"heapUsedBytes": 93945696,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 834.22,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.762427745664745,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2609.8350000000323,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.228999999999999,
"layouts": 6,
"layoutDurationMs": 1.445,
"taskDurationMs": 1636.263,
"heapDeltaBytes": 17727256,
"heapUsedBytes": 97179100,
"domNodes": 0,
"jsHeapTotalBytes": 6447104,
"scriptDurationMs": 809.311,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.773548387096778,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3020.9289999999955,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2239999999999993,
"layouts": 8,
"layoutDurationMs": 2.0010000000000003,
"taskDurationMs": 654.2570000000001,
"heapDeltaBytes": 2884800,
"heapUsedBytes": 80924184,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 298.228,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665934065934067,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2987.1700000000487,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9700000000000004,
"layouts": 8,
"layoutDurationMs": 2.0020000000000002,
"taskDurationMs": 678.45,
"heapDeltaBytes": 2255812,
"heapUsedBytes": 79015624,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 305.02599999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611111111111,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2033.7390000000255,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.152,
"layouts": 9,
"layoutDurationMs": 2.2199999999999998,
"taskDurationMs": 532.8130000000001,
"heapDeltaBytes": -9763912,
"heapUsedBytes": 67101708,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 29.561999999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2032.7939999999671,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3829999999999996,
"layouts": 8,
"layoutDurationMs": 2.4330000000000003,
"taskDurationMs": 553.0699999999999,
"heapDeltaBytes": -16287564,
"heapUsedBytes": 59943856,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 30.846000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2724.425999999994,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.681,
"layouts": 7,
"layoutDurationMs": 2.1310000000000002,
"taskDurationMs": 503.72700000000003,
"heapDeltaBytes": -13602756,
"heapUsedBytes": 66129420,
"domNodes": -248,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 156.30299999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2676.4800000000264,
"styleRecalcs": 25,
"styleRecalcDurationMs": 10.735000000000001,
"layouts": 6,
"layoutDurationMs": 1.495,
"taskDurationMs": 487.776,
"heapDeltaBytes": -4551712,
"heapUsedBytes": 71966564,
"domNodes": -254,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 150.97500000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665838509316767,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3082.7639999999974,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0629999999999997,
"layouts": 7,
"layoutDurationMs": 1.882,
"taskDurationMs": 808.369,
"heapDeltaBytes": -11919192,
"heapUsedBytes": 63144544,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 307.014,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3074.8859999999922,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.1560000000000008,
"layouts": 4,
"layoutDurationMs": 0.977,
"taskDurationMs": 776.987,
"heapDeltaBytes": -1669284,
"heapUsedBytes": 74402952,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 298.151,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665760869565215,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 541.3449999999784,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.688999999999999,
"layouts": 9,
"layoutDurationMs": 2.1670000000000003,
"taskDurationMs": 366.10200000000003,
"heapDeltaBytes": -830744,
"heapUsedBytes": 60969664,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 123.49799999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636353,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 539.7390000000541,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.204,
"layouts": 10,
"layoutDurationMs": 2.497,
"taskDurationMs": 367.39,
"heapDeltaBytes": 22011440,
"heapUsedBytes": 85003072,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 123.82499999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2006.996000000015,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.719,
"layouts": 9,
"layoutDurationMs": 2.353,
"taskDurationMs": 503.252,
"heapDeltaBytes": 1855768,
"heapUsedBytes": 63085516,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 11.163999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.798000000013,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.6840000000000006,
"layouts": 10,
"layoutDurationMs": 2.541,
"taskDurationMs": 417.11600000000004,
"heapDeltaBytes": 1910816,
"heapUsedBytes": 63770692,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 7.677999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.309000000004,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.706,
"layouts": 10,
"layoutDurationMs": 2.415,
"taskDurationMs": 724.971,
"heapDeltaBytes": 17470712,
"heapUsedBytes": 79999268,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 97.593,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.8229999999994,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.454,
"layouts": 9,
"layoutDurationMs": 2.224,
"taskDurationMs": 689.547,
"heapDeltaBytes": 17158284,
"heapUsedBytes": 78932912,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 92.09500000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.5049999999942,
"styleRecalcs": 20,
"styleRecalcDurationMs": 18.432999999999996,
"layouts": 5,
"layoutDurationMs": 12.665999999999999,
"taskDurationMs": 875.0549999999997,
"heapDeltaBytes": 9823476,
"heapUsedBytes": 94322980,
"domNodes": 16030,
"jsHeapTotalBytes": 17178624,
"scriptDurationMs": 25.803,
"eventListeners": 3246,
"totalBlockingTimeMs": 117,
"frameDurationMs": 18.94794520547945,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9343.623999999978,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.254999999999995,
"layouts": 8,
"layoutDurationMs": 1.981,
"taskDurationMs": 4944.150000000001,
"heapDeltaBytes": -18890832,
"heapUsedBytes": 72018140,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 2212.6299999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66595365418895,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8195.68199999992,
"styleRecalcs": 250,
"styleRecalcDurationMs": 29.69,
"layouts": 8,
"layoutDurationMs": 1.9929999999999999,
"taskDurationMs": 4181.782,
"heapDeltaBytes": -13992116,
"heapUsedBytes": 61545356,
"domNodes": -277,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 2141.656,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666056910569107,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 20397.85699999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19619.643,
"heapDeltaBytes": -31233816,
"heapUsedBytes": 262866468,
"domNodes": -3343,
"jsHeapTotalBytes": 15196160,
"scriptDurationMs": 296.55,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.46261180679786,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 20148.65299999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19470.951,
"heapDeltaBytes": -4666048,
"heapUsedBytes": 287578860,
"domNodes": -3343,
"jsHeapTotalBytes": 13885440,
"scriptDurationMs": 302.27700000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.04508050089446,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 23863.702999999987,
"styleRecalcs": 179,
"styleRecalcDurationMs": 20.342,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23574.842,
"heapDeltaBytes": -34822388,
"heapUsedBytes": 266940128,
"domNodes": -3373,
"jsHeapTotalBytes": 16506880,
"scriptDurationMs": 777.6220000000001,
"eventListeners": -667,
"totalBlockingTimeMs": 4,
"frameDurationMs": 45.807485604606526,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 24265.57100000002,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.397,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23978.231,
"heapDeltaBytes": -25232496,
"heapUsedBytes": 266566724,
"domNodes": -3343,
"jsHeapTotalBytes": 16244736,
"scriptDurationMs": 800.163,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.575239923224565,
"p95FrameDurationMs": 99.89999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7282.857000000035,
"styleRecalcs": 20,
"styleRecalcDurationMs": 49.38299999999998,
"layouts": 20,
"layoutDurationMs": 22.069999999999993,
"taskDurationMs": 7146.3150000000005,
"heapDeltaBytes": -34732848,
"heapUsedBytes": 257191828,
"domNodes": -3343,
"jsHeapTotalBytes": 23322624,
"scriptDurationMs": 111.424,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.85689655172414,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7249.859999999899,
"styleRecalcs": 20,
"styleRecalcDurationMs": 48.714000000000006,
"layouts": 20,
"layoutDurationMs": 21.974000000000007,
"taskDurationMs": 7097.603,
"heapDeltaBytes": -18530920,
"heapUsedBytes": 273445852,
"domNodes": -3343,
"jsHeapTotalBytes": 19914752,
"scriptDurationMs": 109.084,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.54764705882353,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10032.468999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9672.437,
"heapDeltaBytes": -3990296,
"heapUsedBytes": 252573064,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 131.272,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.83178571428572,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10285.04399999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9918.768000000002,
"heapDeltaBytes": -13301016,
"heapUsedBytes": 263972908,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 136.08400000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.08035087719298,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 118.69799999999486,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.4,
"layouts": 8,
"layoutDurationMs": 3.1700000000000004,
"taskDurationMs": 79.753,
"heapDeltaBytes": 4816936,
"heapUsedBytes": 65294140,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.552000000000001,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 97.26200000000063,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.443,
"layouts": 7,
"layoutDurationMs": 1.9360000000000002,
"taskDurationMs": 64.39900000000002,
"heapDeltaBytes": 4587924,
"heapUsedBytes": 66384284,
"domNodes": 98,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.108000000000001,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 309.2110000000048,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6040000000000001,
"layouts": 76,
"layoutDurationMs": 12.639,
"taskDurationMs": 267.19300000000004,
"heapDeltaBytes": 10517616,
"heapUsedBytes": 51631036,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 125.638,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657894736842106,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 300.49700000006396,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.616,
"layouts": 76,
"layoutDurationMs": 12.575,
"taskDurationMs": 263.63699999999994,
"heapDeltaBytes": -6113840,
"heapUsedBytes": 36536200,
"domNodes": 4,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 119.785,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736862,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 345.69100000010167,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.739,
"layouts": 76,
"layoutDurationMs": 11.365,
"taskDurationMs": 311.813,
"heapDeltaBytes": -5489736,
"heapUsedBytes": 79520052,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 113.30699999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 338.97000000001754,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.9480000000000002,
"layouts": 76,
"layoutDurationMs": 12.112,
"taskDurationMs": 309.0679999999999,
"heapDeltaBytes": -1623916,
"heapUsedBytes": 92061300,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 111.283,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage: 🟡 60.1% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3133 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 90ed7176ce274513a40cbfa0b52a83ed0ab0feaf
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (240)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
dante01yoon
left a comment
There was a problem hiding this comment.
Holding the backport approval until typecheck passes. lint-pr / typecheck fails on this branch:
src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.ts(47,40): error TS2307: Cannot find module '@comfyorg/graph-model/workflowSchema'
@comfyorg/graph-model does not exist on cloud/1.59. The same fix that landed on the core backport (#22667, commit b21d4d64) should apply here: import ComfyWorkflowJSON from @/platform/workflow/validation/schemas/workflowSchema. I'll approve once that's pushed and CI is green.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.59 #22668 +/- ##
=============================================
Coverage ? 87.23%
=============================================
Files ? 3034
Lines ? 159439
Branches ? 40047
=============================================
Hits ? 139089
Misses ? 19672
Partials ? 678
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Typecheck fix is in (ComfyWorkflowJSON now imported from its 1.59 location) and CI is green. Approving the backport.
…he workflow picker saves it (FRONT-3774) (#22817) Backport of #22648 to `cloud/1.59`. Fixes [FRONT-3774](https://linear.app/comfyorg/issue/FRONT-3774): picking an unopened unsaved tab in the Agent workflow picker after a reload failed with "Save failed · Cannot save workflow … before it is loaded" and lost the tab. Found in release QA case C-163 on 1.59.3. - **Applies here:** `cloud/1.59` has the save-before-load picker path. With only the picker fix reverted, the three new `useAgentWorkflowSelection` tests fail on this branch; with it, they pass. - **Prerequisite already on this train:** #22649 (draft deletion) landed here as #22668. - **Same tree change as the `core/1.59` carrier (#22816).** Behaviour hunks apply unchanged. <details><summary>Full context for agent readers</summary> Commit: the `core/1.59` carrier commit (#22816, itself `cherry-pick -x 816ea98`), which applies cleanly here. Its two resolutions: 1. `workflowService.test.ts` import conflict. `main` also imports `getDefaultWorkflow` (not on 1.59 and not used by this change). Kept the train's import set plus `blankGraph`, which the new `loadWorkflowInBackground` test uses. 2. `agentWorkflowSelection.spec.ts` imports `ComfyWorkflowJSON` from `@/platform/workflow/validation/schemas/workflowSchema`, because 1.59 predates the `@comfyorg/graph-model` package. knip caught the unlisted package on pre-push. Every `browser_tests/` hunk from the source is carried; none is dropped. Local checks on this tree (Node 24): `typecheck` and `typecheck:browser` pass. Vitest on `useAgentWorkflowSelection.test.ts`, `workflowService.test.ts`, `AgentPanelRoot.test.ts` and `src/platform/workflow/persistence/`: 915 passed, 1 expected fail, 15 files. The new browser case `picks an unsaved tab a reload left unopened` runs in CI (`e2e-status`). Authority: the program's release-backport grant for the current trains (`cloud/1.59` is listed). </details> Justification: Release backport of FRONT-3774 fixes (#22648, plus #22649 where the train lacked it) to cloud/1.59 under the standing agent backport review-and-merge grant for the current trains. Production hunks match the source PRs line for line (only a train-local import path differs); the source unit tests fail on the train tip without the carrier and pass with it; all required checks pass at 2c22d4c; no unresolved threads.
Backport of #22649 to
cloud/1.59Automatically created by backport workflow.