Repository navigation
[backport core/1.59] test(agent): pin the fake clock in the g6 and g18 recovery tests (#22481) - #22664
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e2c1cd4952d8f665784436589d0bafc3f1460c95
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (233)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.59 #22664 +/- ##
==========================================
Coverage 87.17% 87.17%
==========================================
Files 3030 3030
Lines 159257 159257
Branches 40321 40321
==========================================
Hits 138837 138837
Misses 19744 19744
Partials 676 676
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit f5dff0b has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
Backport of #22481 to
core/1.59. The auto-backport hit a conflict only because the g18 test has a different title on this branch; the change is the same two lines.This branch has the same auto-advancing fake clock and the same two tests, so they can flake the same way (reproduced on 1.57, 1.58 and 1.59 in FRONT-3485). Each test now pins the clock with
vi.useFakeTimers({ shouldAdvanceTime: false }), as on main.Test-only change; no product code.