Skip to content

[backport cloud/1.56] test(agent): pin the fake clock in the g6 and g18 recovery tests (#22481) - #22659

Merged
christian-byrne merged 1 commit into
cloud/1.56from
backport-22481-to-cloud-1.56
Nov 1, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.56from
backport-22481-to-cloud-1.56

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backport of #22481 to cloud/1.56. The auto-backport hit a conflict only because the g18 test has a different title on this branch; the change is the same two lines.

This branch has the same auto-advancing fake clock and the same two tests, so they can flake the same way (reproduced on 1.57, 1.58 and 1.59 in FRONT-3485). Each test now pins the clock with vi.useFakeTimers({ shouldAdvanceTime: false }), as on main.

Test-only change; no product code.

…18 recovery tests (#22481)

Backport of #22481 to cloud/1.56. The suite's fake clock advances with real time, so these two tests could reach their deadlines early and flake. Same two-line change as on main.
@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 2
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle: ⏳ Size data collection in progress…

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 11/01/2026, 11:21:37 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 607ccaefaafa1e728e6d332063c8f8be71249210

Full docs: ADR-DEVEX-LINT-0015

@comfy-greenlight-bot

comfy-greenlight-bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Swarmhost agentic review

The detailed evaluation is available to employees in the internal Slack review thread.

Evaluation budget remaining for this pull request: 98 automatic and 99 manual.

Updated by Swarmhost's agentic review process.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Nov 1, 2026
@codecov

codecov Bot commented Nov 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.56   #22659   +/-   ##
=============================================
  Coverage              ?   83.17%           
=============================================
  Files                 ?     2399           
  Lines                 ?   128116           
  Branches              ?    36881           
=============================================
  Hits                  ?   106558           
  Misses                ?    21147           
  Partials              ?      411           
Flag Coverage Δ
unit 83.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-greenlight-bot comfy-greenlight-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request at head commit 94d7ce9 has been reviewed and approved by Swarmhost's agentic review process.

The detailed evaluation is available to employees in the internal Slack review thread.

@christian-byrne
christian-byrne merged commit d6d6d7e into cloud/1.56 Nov 1, 2026
108 checks passed
@christian-byrne
christian-byrne deleted the backport-22481-to-cloud-1.56 branch November 1, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

greenlight risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants