Repository navigation
[backport cloud/1.58] fix: keep the canvas rendering after a failed first frame - #22654
Conversation
Follow-up to #21321, from review findings on its backports #21850 and #21851. - **The canvas keeps rendering after a frame throws.** #21321 caught a throwing first frame so the `LGraphCanvas` constructor could finish, but it also stopped the render loop, so the canvas stayed frozen for the rest of the session. Now any frame that throws is reported (each distinct error once). The 2D context is reset to its DPR base transform, both canvases are redrawn, and the loop continues. After 60 failed drawing frames with no successful draw in between, the loop stops, reports `error_rendering_canvas_stopped` and can be restarted. - **Pinch zoom no longer writes NaN, 0 or Infinity into the viewport.** This happened when two fingers touched the same point. A pinch that starts that way now measures from the first move where the fingers are at least 8px apart. - **`bootstrapTracer.outcome` reads `timed_out` after the watchdog fires,** not `pending`, so the missing-canvas report can tell a hung startup from one that is still loading. <details><summary>Full context for agent readers</summary> **Tests, red first.** On `main` these failed: - `is_rendering` was false after a throwing first frame, and no frame was scheduled. - A persistently throwing draw escaped on frame 2 and left `is_rendering` stuck at true. - A same-point pinch changed the viewport. - `outcome` stayed `pending` after the watchdog fired. They pass with this PR. Local results: - `vitest run src/extensions/core src/lib/litegraph/src/LGraphCanvas* src/platform/telemetry/perf`: 1793 passed. - `pnpm typecheck`, oxlint and eslint are clean. - The pre-push hooks pass: depcruise, knip and the fallow audit. **Review rounds.** CodeRabbit and Cursor review findings on the first heads are addressed in 8014af1: context reset, dirty marking, failure counting that ignores idle frames, an outer guard on the first frame, the 8px pinch threshold, no inline comments, and a later-frame failure test. **Adversarial review.** A fresh Claude reviewer ran on the first push (Codex is unavailable on this host). Its HIGH finding: a persistent failure still killed the loop on frame 2, and `is_rendering` stayed stuck. This push addresses that with the bounded retry, frame-level tests and stronger pinch assertions. **Also changed:** - The touchmove pinch branch moved into `handlePinchMove`, to stay under the complexity gate. - The test no longer imports `@/scripts/app`, which was a boundary-rule violation. **Not changed.** The `canvasOrReport('processMouseDown')` false-positive finding on the backports does not apply to `main`, which has no processMouseDown wrapper in `simpleTouchSupport.ts`. **Backports.** Labels are set for 1.57, 1.58 and 1.59. The 1.57 and 1.58 lines need the #21321 carriers first; 1.59 already has #21321. </details> Part of https://linear.app/comfyorg/issue/FRONT-3716 (cherry picked from commit 47d1cf4)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-01T22:30:50.951Z",
"gitSha": "d6fec142e5bdb379dc900ffabdf03af05c6fe2b2",
"branch": "backport-22273-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.3390000000018,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.961,
"layouts": 10,
"layoutDurationMs": 2.447,
"taskDurationMs": 347.87,
"heapDeltaBytes": 26056268,
"heapUsedBytes": 115979552,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 10.596,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2009.9069999999983,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.758,
"layouts": 9,
"layoutDurationMs": 2.364,
"taskDurationMs": 439.697,
"heapDeltaBytes": 6893172,
"heapUsedBytes": 95339980,
"domNodes": -181,
"jsHeapTotalBytes": -983040,
"scriptDurationMs": 12.754,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1725.8620000000064,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.453000000000001,
"layouts": 11,
"layoutDurationMs": 2.679,
"taskDurationMs": 675.9739999999999,
"heapDeltaBytes": 346152,
"heapUsedBytes": 88398060,
"domNodes": -200,
"jsHeapTotalBytes": -2031616,
"scriptDurationMs": 127.861,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.7730000000215,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.281,
"layouts": 9,
"layoutDurationMs": 2.286,
"taskDurationMs": 654.4110000000001,
"heapDeltaBytes": 23080876,
"heapUsedBytes": 114303872,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 130.168,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.3210000000122,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.237,
"layouts": 11,
"layoutDurationMs": 2.3080000000000003,
"taskDurationMs": 321.715,
"heapDeltaBytes": -1602240,
"heapUsedBytes": 87977244,
"domNodes": 47,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 10.072000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.0299999999943,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.971,
"layouts": 12,
"layoutDurationMs": 2.995,
"taskDurationMs": 375.52299999999997,
"heapDeltaBytes": 21532940,
"heapUsedBytes": 112862176,
"domNodes": 47,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 13.618000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 576.6909999999825,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.6999999999999997,
"layouts": 9,
"layoutDurationMs": 2.279,
"taskDurationMs": 421.59200000000004,
"heapDeltaBytes": 3334044,
"heapUsedBytes": 92323916,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 141.465,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714277,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 596.4630000000852,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.2680000000000002,
"layouts": 10,
"layoutDurationMs": 2.748,
"taskDurationMs": 434.798,
"heapDeltaBytes": 141384,
"heapUsedBytes": 88093404,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 143.13400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1038.8769999999568,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 703.9570000000001,
"heapDeltaBytes": -10143804,
"heapUsedBytes": 101950364,
"domNodes": -231,
"jsHeapTotalBytes": 15540224,
"scriptDurationMs": 53.285,
"eventListeners": -168,
"totalBlockingTimeMs": 390,
"frameDurationMs": 29.520000000000007,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1059.0819999999894,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 711.6539999999999,
"heapDeltaBytes": -14163200,
"heapUsedBytes": 102557620,
"domNodes": -230,
"jsHeapTotalBytes": 16588800,
"scriptDurationMs": 54.38900000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 398,
"frameDurationMs": 29.627777777777787,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 782.4099999999703,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.742,
"heapDeltaBytes": 23591856,
"heapUsedBytes": 121817040,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 116.519,
"eventListeners": 0,
"totalBlockingTimeMs": 161,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 777.2860000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.58300000000014,
"heapDeltaBytes": -3327052,
"heapUsedBytes": 95652592,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 120.94099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 162,
"frameDurationMs": 23.035294117647055,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8111.446999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7249.825000000001,
"heapDeltaBytes": 28763100,
"heapUsedBytes": 150758476,
"domNodes": -276,
"jsHeapTotalBytes": 42532864,
"scriptDurationMs": 5898.1849999999995,
"eventListeners": -130,
"totalBlockingTimeMs": 110,
"frameDurationMs": 25.28442367601246,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7535.19799999998,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.6259999999999998,
"layouts": 2,
"layoutDurationMs": 0.5349999999999999,
"taskDurationMs": 6667.6089999999995,
"heapDeltaBytes": 32224144,
"heapUsedBytes": 152760880,
"domNodes": -277,
"jsHeapTotalBytes": 31862784,
"scriptDurationMs": 5183.380999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 40,
"frameDurationMs": 23.83892405063291,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7825.3040000000165,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.5830000000000002,
"layouts": 2,
"layoutDurationMs": 0.46699999999999997,
"taskDurationMs": 6963.955,
"heapDeltaBytes": 28145756,
"heapUsedBytes": 150026616,
"domNodes": -296,
"jsHeapTotalBytes": 41222144,
"scriptDurationMs": 5689.218000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 144,
"frameDurationMs": 24.945859872611464,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6897.007999999971,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7740000000000004,
"layouts": 3,
"layoutDurationMs": 0.738,
"taskDurationMs": 6134.968,
"heapDeltaBytes": 3629376,
"heapUsedBytes": 127193928,
"domNodes": -276,
"jsHeapTotalBytes": 18493440,
"scriptDurationMs": 4888.649,
"eventListeners": -130,
"totalBlockingTimeMs": 76,
"frameDurationMs": 24.642142857142858,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 204.13400000001047,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.347999999999999,
"layouts": 11,
"layoutDurationMs": 3.0799999999999996,
"taskDurationMs": 169.61900000000003,
"heapDeltaBytes": 15484180,
"heapUsedBytes": 116125968,
"domNodes": 917,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 7.132,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.670000000000027,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 177.0209999999679,
"styleRecalcs": 23,
"styleRecalcDurationMs": 12.088000000000001,
"layouts": 11,
"layoutDurationMs": 2.681,
"taskDurationMs": 139.38800000000003,
"heapDeltaBytes": 15562652,
"heapUsedBytes": 118119448,
"domNodes": 917,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 6.8870000000000005,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.36666666666669,
"p95FrameDurationMs": 49.90000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2041.187999999977,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8919999999999995,
"layouts": 9,
"layoutDurationMs": 2.6850000000000005,
"taskDurationMs": 677.569,
"heapDeltaBytes": 1420956,
"heapUsedBytes": 103033024,
"domNodes": -296,
"jsHeapTotalBytes": -1507328,
"scriptDurationMs": 34.321000000000005,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2040.6239999999798,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6450000000000005,
"layouts": 9,
"layoutDurationMs": 2.3770000000000002,
"taskDurationMs": 560.5749999999999,
"heapDeltaBytes": -23338868,
"heapUsedBytes": 97206324,
"domNodes": -296,
"jsHeapTotalBytes": -1703936,
"scriptDurationMs": 29.963000000000005,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2669.2859999999996,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.501000000000001,
"layouts": 7,
"layoutDurationMs": 1.72,
"taskDurationMs": 1478.1360000000002,
"heapDeltaBytes": -5986044,
"heapUsedBytes": 98461940,
"domNodes": -296,
"jsHeapTotalBytes": -2748416,
"scriptDurationMs": 672.873,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666249999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2336.6530000000694,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.864,
"layouts": 7,
"layoutDurationMs": 1.584,
"taskDurationMs": 1401.8790000000001,
"heapDeltaBytes": 1581624,
"heapUsedBytes": 104480660,
"domNodes": -296,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 635.726,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66642857142857,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3910.174999999981,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.314,
"layouts": 64,
"layoutDurationMs": 10.884,
"taskDurationMs": 1644.5990000000004,
"heapDeltaBytes": 10174256,
"heapUsedBytes": 110884316,
"domNodes": -272,
"jsHeapTotalBytes": -1609728,
"scriptDurationMs": 699.0039999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.737606837606837,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3432.3440000000573,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.161999999999997,
"layouts": 65,
"layoutDurationMs": 10.223,
"taskDurationMs": 1496.191,
"heapDeltaBytes": 10610148,
"heapUsedBytes": 110658092,
"domNodes": -252,
"jsHeapTotalBytes": -2396160,
"scriptDurationMs": 646.751,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3031.5200000000004,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.762,
"layouts": 5,
"layoutDurationMs": 1.404,
"taskDurationMs": 1826.5349999999999,
"heapDeltaBytes": -4539972,
"heapUsedBytes": 104810688,
"domNodes": 0,
"jsHeapTotalBytes": 7081984,
"scriptDurationMs": 880.191,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.85195530726257,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2236.7710000000898,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.154000000000001,
"layouts": 5,
"layoutDurationMs": 1.202,
"taskDurationMs": 1581.793,
"heapDeltaBytes": 4397428,
"heapUsedBytes": 110463400,
"domNodes": 0,
"jsHeapTotalBytes": 8130560,
"scriptDurationMs": 777.825,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.91654135338346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2047.8050000000394,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.0740000000000003,
"layouts": 7,
"layoutDurationMs": 1.9009999999999998,
"taskDurationMs": 555.597,
"heapDeltaBytes": 227720,
"heapUsedBytes": 103151320,
"domNodes": -296,
"jsHeapTotalBytes": -983040,
"scriptDurationMs": 32.56999999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2048.1720000000223,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.623,
"layouts": 8,
"layoutDurationMs": 2.1359999999999997,
"taskDurationMs": 603.712,
"heapDeltaBytes": -22312796,
"heapUsedBytes": 99511068,
"domNodes": -296,
"jsHeapTotalBytes": 131072,
"scriptDurationMs": 34.10999999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 498.43299999997726,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.117,
"layouts": 10,
"layoutDurationMs": 2.3080000000000003,
"taskDurationMs": 316.427,
"heapDeltaBytes": 3209812,
"heapUsedBytes": 102382336,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 118.22399999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 513.3650000000216,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.637,
"layouts": 11,
"layoutDurationMs": 2.6719999999999997,
"taskDurationMs": 325.409,
"heapDeltaBytes": 22453000,
"heapUsedBytes": 112541860,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 120.777,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664516129032254,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2038.5110000000282,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.795,
"layouts": 10,
"layoutDurationMs": 2.524,
"taskDurationMs": 547.748,
"heapDeltaBytes": -3348924,
"heapUsedBytes": 86286828,
"domNodes": -219,
"jsHeapTotalBytes": -196608,
"scriptDurationMs": 10.869,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2026.2880000000223,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.9060000000000006,
"layouts": 9,
"layoutDurationMs": 2.7179999999999995,
"taskDurationMs": 440.9310000000001,
"heapDeltaBytes": 1508148,
"heapUsedBytes": 91177676,
"domNodes": -219,
"jsHeapTotalBytes": -2031616,
"scriptDurationMs": 11.618,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1958.1890000000044,
"styleRecalcs": 86,
"styleRecalcDurationMs": 14.959999999999997,
"layouts": 9,
"layoutDurationMs": 2.1200000000000006,
"taskDurationMs": 980.88,
"heapDeltaBytes": 19439460,
"heapUsedBytes": 111421504,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 101.11500000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66525423728814,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.5379999998895,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.525000000000002,
"layouts": 10,
"layoutDurationMs": 2.337,
"taskDurationMs": 576.824,
"heapDeltaBytes": 14899972,
"heapUsedBytes": 106634788,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 94.16300000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 1320.3720000000203,
"styleRecalcs": 19,
"styleRecalcDurationMs": 19.271000000000004,
"layouts": 5,
"layoutDurationMs": 10.192,
"taskDurationMs": 868.989,
"heapDeltaBytes": 11711420,
"heapUsedBytes": 140266124,
"domNodes": 16030,
"jsHeapTotalBytes": 9314304,
"scriptDurationMs": 26.011,
"eventListeners": 3244,
"totalBlockingTimeMs": 102,
"frameDurationMs": 18.77746478873239,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9110.390999999992,
"styleRecalcs": 251,
"styleRecalcDurationMs": 30.442999999999998,
"layouts": 9,
"layoutDurationMs": 2.1679999999999997,
"taskDurationMs": 4826.178,
"heapDeltaBytes": -31025468,
"heapUsedBytes": 89550388,
"domNodes": -300,
"jsHeapTotalBytes": -393216,
"scriptDurationMs": 2161.318,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665996343692868,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9841.968000000066,
"styleRecalcs": 251,
"styleRecalcDurationMs": 30.901999999999997,
"layouts": 9,
"layoutDurationMs": 2.4480000000000004,
"taskDurationMs": 5161.612,
"heapDeltaBytes": 13656372,
"heapUsedBytes": 118319828,
"domNodes": -276,
"jsHeapTotalBytes": -1499136,
"scriptDurationMs": 2373.6699999999996,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665989847715736,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18937.876999999957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18656.32,
"heapDeltaBytes": -50338100,
"heapUsedBytes": 269588280,
"domNodes": -3348,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 267.513,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.86666666666667,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 19626.20800000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18883.102000000003,
"heapDeltaBytes": -47218232,
"heapUsedBytes": 282930072,
"domNodes": -3344,
"jsHeapTotalBytes": 18075648,
"scriptDurationMs": 287.33400000000006,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.50351493848857,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 23661.17300000002,
"styleRecalcs": 180,
"styleRecalcDurationMs": 21.639999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23363.759000000002,
"heapDeltaBytes": -19834736,
"heapUsedBytes": 309447252,
"domNodes": -3344,
"jsHeapTotalBytes": 16433152,
"scriptDurationMs": 784.1239999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 1,
"frameDurationMs": 45.33639846743295,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 17005.268,
"styleRecalcs": 117,
"styleRecalcDurationMs": 13.85900000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16521.315000000002,
"heapDeltaBytes": -2938844,
"heapUsedBytes": 317573896,
"domNodes": -3344,
"jsHeapTotalBytes": 25608192,
"scriptDurationMs": 710.441,
"eventListeners": -651,
"totalBlockingTimeMs": 26,
"frameDurationMs": 31.597211895910785,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5274.302999999974,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.78099999999998,
"layouts": 20,
"layoutDurationMs": 27.191999999999993,
"taskDurationMs": 5180.964,
"heapDeltaBytes": -38043748,
"heapUsedBytes": 281704840,
"domNodes": -307,
"jsHeapTotalBytes": 27250688,
"scriptDurationMs": 84.27400000000002,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.07705882352941,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 7052.467999999976,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.922000000000004,
"layouts": 20,
"layoutDurationMs": 29.956999999999997,
"taskDurationMs": 6990.871999999999,
"heapDeltaBytes": -2523984,
"heapUsedBytes": 298656008,
"domNodes": -3344,
"jsHeapTotalBytes": 18337792,
"scriptDurationMs": 160.01,
"eventListeners": -653,
"totalBlockingTimeMs": 7,
"frameDurationMs": 42.31317365269461,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7172.914999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6752.827,
"heapDeltaBytes": 23318556,
"heapUsedBytes": 303528408,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 97.36799999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.769310344827595,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7211.766000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7032.424999999998,
"heapDeltaBytes": -8417656,
"heapUsedBytes": 277568020,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 104.30500000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.05198555956679,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 95.2429999999822,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.398,
"layouts": 7,
"layoutDurationMs": 2.1580000000000004,
"taskDurationMs": 70.112,
"heapDeltaBytes": 4849820,
"heapUsedBytes": 105226968,
"domNodes": 97,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.8900000000000015,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.650000000000016,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 441.9920000000275,
"styleRecalcs": 15,
"styleRecalcDurationMs": 10.211000000000002,
"layouts": 13,
"layoutDurationMs": 4.36,
"taskDurationMs": 102.42999999999999,
"heapDeltaBytes": -17257208,
"heapUsedBytes": 93042044,
"domNodes": 95,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 10.077,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 329.3859999999995,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.657,
"layouts": 76,
"layoutDurationMs": 12.992999999999999,
"taskDurationMs": 290.884,
"heapDeltaBytes": 10776680,
"heapUsedBytes": 100136860,
"domNodes": 4,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 135.69899999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 381.94899999996323,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.651,
"layouts": 76,
"layoutDurationMs": 13.873,
"taskDurationMs": 345.724,
"heapDeltaBytes": -18088380,
"heapUsedBytes": 74227008,
"domNodes": 4,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 160.87199999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999984,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 377.8580000000602,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.605,
"layouts": 76,
"layoutDurationMs": 12.631,
"taskDurationMs": 340.895,
"heapDeltaBytes": -5750228,
"heapUsedBytes": 102180860,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 123.126,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66818181818181,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 373.95099999992,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.132,
"layouts": 76,
"layoutDurationMs": 11.4,
"taskDurationMs": 337.368,
"heapDeltaBytes": -3621832,
"heapUsedBytes": 110708552,
"domNodes": 4,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 122.747,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66818181818181,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage: 🟡 63.6% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2994 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 402e011a76144d56ce31311483af6149d36b5547
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (143)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Matches the assertion #22273 added on main; it was left out of the hand port.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.58 #22654 +/- ##
=============================================
Coverage ? 84.26%
=============================================
Files ? 3172
Lines ? 165661
Branches ? 39111
=============================================
Hits ? 139590
Misses ? 25681
Partials ? 390
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
An adversarial review of the hand port (a fresh Claude reviewer; Codex is unavailable on this host) found it faithful to #22273 except for one missing test assertion: a pinch with no canvas must not raise a listener error. That assertion is now added. It found nothing in the source changes. |
dante01yoon
left a comment
There was a problem hiding this comment.
Backport of #22273 — approving.
Backport of #22273. The auto-backport hit cherry-pick conflicts.
This line predates the touch-support refactor on main (
touchGesture, the exported extension), so the port was done by hand:LGraphCanvas.ts: the changed lines match fix: keep the canvas rendering after a failed first frame #22273 exactly; only the placement ofMAX_FAILED_FRAMESconflicted.simpleTouchSupport.ts: samehandlePinchMoveandMIN_PINCH_DISTANCEguard as main, using this line's module-leveltouchZoomingflag.simpleTouchSupport.test.ts: this line's test file, with the viewport mock hoisted so the four pinch-zoom tests from fix: keep the canvas rendering after a failed first frame #22273 can read it.LGraphCanvas.startRendering.test.ts: main's tests, importingreportErrorfrom@/platform/telemetry/reportErrorand mocking it in the file (this line predates refactor: extract telemetry into a package #22135 and test: centralize default error reporter mocking #22018).Local checks: the touch, startRendering and bootstrapTracer suites pass (43 tests). Without the source changes, 14 of them fail. Lint, format and
typecheck:apppassed in the commit hooks oncore/1.58.