Repository navigation
test: keep the video record command test independent of ~/.bashrc - #22636
Conversation
spawnSync gives bash a socket for stdin, so Debian's bash sources ~/.bashrc as if run over SSH. A PATH change there put the real pnpm ahead of the stub and failed three cases locally. Use a non-socket stdin.
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Child-process I/O options scripts/cicd/plan-playwright-videos.test.ts |
The test configures spawnSync to ignore stdin and pipe stdout and stderr. |
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix
Possibly related PRs
- Comfy-Org/ComfyUI_frontend#21582: Adds the independent video workflow test that this change updates.
Suggested reviewers: jtydhr88
Merge Risk: 
Minimal · up to 3c6f7
-
No actionable merge-blocking risk remains in this focused test-only change.
Pre-merge checks: 
6
-
Full details: End-To-End Test Suggestion For User-Facing Changes
-
Explanation
The PR changes only
scripts/cicd/plan-playwright-videos.test.ts, which is a test file outsidesrc/andpackages/. The change does not modify the main frontend application or add a user-facing feature. This check passes for test-only changes.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d41c1e312c28f22a92f97281d180821b46211ce8
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (343)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #22636 +/- ##
==========================================
- Coverage 87.60% 87.51% -0.10%
==========================================
Files 2999 2891 -108
Lines 163305 159949 -3356
Branches 41619 40453 -1166
==========================================
- Hits 143070 139976 -3094
+ Misses 19304 19210 -94
+ Partials 931 763 -168
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Summary
Three
records … one spec at a timecases inscripts/cicd/plan-playwright-videos.test.tsfail on a developer machine whose~/.bashrcchangesPATH, while CI passes.Cause:
spawnSyncgives the child a socket for stdin. Debian and Ubuntu builds of bash treat that as a run over SSH and source~/.bashrc, even with a cleanenv. APATHline there put the realpnpmahead of the test's stub, so the stub never ran,calls.jsonlwas never written, and the test failed withENOENT … calls.jsonl(stderr:ERR_PNPM_RECURSIVE_EXEC_NO_PACKAGE).Change
The bash spawn that relies on the stub
pnpmnow usesstdio: ['ignore', 'pipe', 'pipe'], so bash gets a non-socket stdin and skips~/.bashrc. The command already reads nothing from stdin.Verification
vitest run scripts/cicd/plan-playwright-videos.test.ts).Other script tests spawn bash the same way but do not depend on
PATHorder, so they are left unchanged.