Repository navigation
[backport cloud/1.59] fix(agent): re-send the canvas whenever an unsaved tab's remembered workflow is not its own (PM-2401) - #22613
Conversation
…orkflow is not its own (PM-2401) (#22518) The agent could still read an old graph on an unsaved tab in three rarer cases. Fixed. - Chat's workflow tab closed: the canvas is now sent, not the old workflow - No canvas available: the send is held and the message stays in the composer - Reply with no adoptable workflow: the tab no longer mints a new one each turn - Blank tab after the chat's tab closed: stays on the chat's workflow Linear: https://linear.app/comfyorg/issue/PM-2401 <details><summary>Full context for agent readers</summary> ## Summary Follow-up to #22310, which re-sent the canvas only when the session's bound workflow was still open in another tab. These are the three edges cursor-review raised on that PR. ## Changes - **What**: `isUnboundTarget` no longer needs the bound workflow to appear in `open_tabs` when the tab has content. A selected tab with no cloud id has no workflow of its own, so with a draft holding nodes or groups the turn carries `current_tab_unbound` and the draft. A blank tab whose bound workflow is open nowhere keeps today's thread fallback: minting would replace a built thread workflow with an empty one. A blank tab whose bound workflow is open elsewhere still re-flags, as #22310 does. - **Mint memo**: `unadoptedMintBinding` records, per tab path, the binding at the reply to a mint the tab did not adopt. Such a tab does not re-flag while the binding is unchanged, so there is no one-workflow-per-turn loop. An id with a tab binding is not recorded: an adopted mint shows in the binding, and temp-tab paths are reused after close. Cleared with the binding by `newChat`, `loadThread` and a deleted thread. The memo lives with the session: after a panel remount an unadopted mint can re-mint once. - **Hold**: a continuing turn from such a tab with no canvas is refused with the existing `agent.targetNavigationUnavailable` failure instead of silently retargeting. `current_tab_unbound` without a draft would mint an empty workflow, so sending is not an option. `performSend` returns false, so the composer keeps the text. - `postTurn` now takes the built input so `performSend` can read whether the turn was flagged. - **Tests**: red on `main`, green here: `(h10b)` hold, `(h10e)` closed tab re-flags, `(h10f)` reply without an id does not re-flag. Added after adversarial review, red before the second commit: `(h10e2)` blank tab keeps the thread workflow, `(h10e3)` reused path of a closed adopted tab mints for itself. Guards: `(h10d)` unadopted mint not re-minted, `(h10g)` new chat clears the memo. ## Review Focus - Accepted cost, per the ticket: renaming a bound unsaved tab loses its binding, so the next turn mints a copy of that tab's canvas and leaves the old draft workflow orphaned. - Held sends apply only when the host provides a canvas reader. They reuse the existing "target no longer available" text to keep this PR inside the agent paths. `draft` is undefined only when the tab has no `activeState`. - Not changed: a flagged first turn (nothing bound) with no draft can still mint empty. Same as `main`. - After a reply with no id, later turns on that tab send neither flag nor draft. The server (`agent_handler.go`) always returns `workflow_id`, so this is a loop guard only. </details>
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-01T14:12:52.204Z",
"gitSha": "59b834e25cd4a6a5e0193a907fac6fe918bb94fb",
"branch": "backport-22518-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2016.411000000005,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.128,
"layouts": 10,
"layoutDurationMs": 2.7380000000000004,
"taskDurationMs": 365.26,
"heapDeltaBytes": 1727076,
"heapUsedBytes": 63187084,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 9.585999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2010.7629999999972,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.228,
"layouts": 10,
"layoutDurationMs": 2.941,
"taskDurationMs": 375.13,
"heapDeltaBytes": 24478796,
"heapUsedBytes": 84605136,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 10.560000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.6220000000185,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.623000000000001,
"layouts": 10,
"layoutDurationMs": 2.53,
"taskDurationMs": 599.865,
"heapDeltaBytes": 21782576,
"heapUsedBytes": 84014132,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 110.38,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.5119999999765,
"styleRecalcs": 74,
"styleRecalcDurationMs": 15.727000000000002,
"layouts": 9,
"layoutDurationMs": 2.404,
"taskDurationMs": 671.32,
"heapDeltaBytes": 21863736,
"heapUsedBytes": 83343636,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 129.105,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.0219999999908,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.486000000000001,
"layouts": 10,
"layoutDurationMs": 3.076,
"taskDurationMs": 297.707,
"heapDeltaBytes": -1396912,
"heapUsedBytes": 69783268,
"domNodes": 56,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 12.763000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.9729999999772,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.417,
"layouts": 11,
"layoutDurationMs": 3.2430000000000003,
"taskDurationMs": 333.721,
"heapDeltaBytes": -1307860,
"heapUsedBytes": 60421176,
"domNodes": 56,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 14.056999999999999,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667307692307695,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 558.4920000000011,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.0410000000000004,
"layouts": 10,
"layoutDurationMs": 2.706,
"taskDurationMs": 364.852,
"heapDeltaBytes": 8968,
"heapUsedBytes": 67249116,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 123.80499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 532.4899999999957,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.1790000000000003,
"layouts": 10,
"layoutDurationMs": 2.631,
"taskDurationMs": 326.971,
"heapDeltaBytes": 5590968,
"heapUsedBytes": 75788508,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 107.374,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000003,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 991.7489999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 652.262,
"heapDeltaBytes": -1021808,
"heapUsedBytes": 74806544,
"domNodes": -191,
"jsHeapTotalBytes": 14688256,
"scriptDurationMs": 44.91300000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 331,
"frameDurationMs": 27.027027027027028,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 950.9740000000306,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 625.268,
"heapDeltaBytes": -12266232,
"heapUsedBytes": 74554524,
"domNodes": -191,
"jsHeapTotalBytes": 20193280,
"scriptDurationMs": 40.626,
"eventListeners": -106,
"totalBlockingTimeMs": 298,
"frameDurationMs": 26.38888888888889,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 736.6310000000169,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 340.1909999999999,
"heapDeltaBytes": -21441212,
"heapUsedBytes": 67027728,
"domNodes": -191,
"jsHeapTotalBytes": 3014656,
"scriptDurationMs": 99.41100000000003,
"eventListeners": -106,
"totalBlockingTimeMs": 90,
"frameDurationMs": 20.369444444444426,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 729.3920000000185,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 357.5750000000002,
"heapDeltaBytes": -27700688,
"heapUsedBytes": 66351808,
"domNodes": -191,
"jsHeapTotalBytes": 3801088,
"scriptDurationMs": 95.603,
"eventListeners": -106,
"totalBlockingTimeMs": 96,
"frameDurationMs": 20.951428571428576,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6690.283000000022,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.0740000000000003,
"layouts": 4,
"layoutDurationMs": 0.9719999999999998,
"taskDurationMs": 5609.305,
"heapDeltaBytes": 64112156,
"heapUsedBytes": 135680176,
"domNodes": -257,
"jsHeapTotalBytes": 57274368,
"scriptDurationMs": 4241.004,
"eventListeners": -68,
"totalBlockingTimeMs": 63,
"frameDurationMs": 20.626851851851853,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6078.434000000016,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.0470000000000002,
"layouts": 4,
"layoutDurationMs": 0.954,
"taskDurationMs": 5073.209999999999,
"heapDeltaBytes": 59720884,
"heapUsedBytes": 132405036,
"domNodes": -257,
"jsHeapTotalBytes": 52293632,
"scriptDurationMs": 3805.125,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.378247734138974,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6728.33799999998,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.2749999999999992,
"layouts": 4,
"layoutDurationMs": 1.17,
"taskDurationMs": 5724.405,
"heapDeltaBytes": 50089840,
"heapUsedBytes": 132638316,
"domNodes": -257,
"jsHeapTotalBytes": 60157952,
"scriptDurationMs": 4310.26,
"eventListeners": -68,
"totalBlockingTimeMs": 63,
"frameDurationMs": 20.6021472392638,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6454.348999999979,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9009999999999999,
"layouts": 3,
"layoutDurationMs": 0.798,
"taskDurationMs": 5561.07,
"heapDeltaBytes": 64938916,
"heapUsedBytes": 136630592,
"domNodes": -257,
"jsHeapTotalBytes": 58585088,
"scriptDurationMs": 4169.25,
"eventListeners": -68,
"totalBlockingTimeMs": 5,
"frameDurationMs": 19.845538461538464,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 187.96499999999128,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.015000000000002,
"layouts": 13,
"layoutDurationMs": 3.646,
"taskDurationMs": 131.174,
"heapDeltaBytes": -6078088,
"heapUsedBytes": 72647724,
"domNodes": 936,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 7.152,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.377777777777737,
"p95FrameDurationMs": 49.90000000000009
},
{
"name": "large-combo-open",
"durationMs": 162.8210000000081,
"styleRecalcs": 23,
"styleRecalcDurationMs": 11.25,
"layouts": 13,
"layoutDurationMs": 3.1790000000000003,
"taskDurationMs": 112.915,
"heapDeltaBytes": 14466316,
"heapUsedBytes": 91240352,
"domNodes": 936,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.911,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2043.6040000000162,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.0010000000000003,
"layouts": 9,
"layoutDurationMs": 2.6119999999999997,
"taskDurationMs": 489.82699999999994,
"heapDeltaBytes": -10243876,
"heapUsedBytes": 73262440,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 30.788000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2025.7930000000215,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5380000000000003,
"layouts": 9,
"layoutDurationMs": 2.2689999999999997,
"taskDurationMs": 400.69300000000004,
"heapDeltaBytes": -9202252,
"heapUsedBytes": 65539240,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 27.762,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2198.2069999999967,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.263000000000002,
"layouts": 9,
"layoutDurationMs": 2.1430000000000002,
"taskDurationMs": 1096.771,
"heapDeltaBytes": -30734904,
"heapUsedBytes": 61094612,
"domNodes": -257,
"jsHeapTotalBytes": 5931008,
"scriptDurationMs": 550.695,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666412213740458,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2332.934000000023,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.669999999999998,
"layouts": 9,
"layoutDurationMs": 2.2510000000000003,
"taskDurationMs": 1178.6049999999998,
"heapDeltaBytes": 2103256,
"heapUsedBytes": 76099760,
"domNodes": -257,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 568.971,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-zoom",
"durationMs": 3589.244999999977,
"styleRecalcs": 74,
"styleRecalcDurationMs": 11.623,
"layouts": 67,
"layoutDurationMs": 11.927999999999999,
"taskDurationMs": 1289.95,
"heapDeltaBytes": -11457672,
"heapUsedBytes": 65754044,
"domNodes": -233,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 539.9499999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66574074074074,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3338.115000000016,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.000000000000002,
"layouts": 65,
"layoutDurationMs": 11.481,
"taskDurationMs": 1232.9460000000001,
"heapDeltaBytes": 1593708,
"heapUsedBytes": 79282856,
"domNodes": -233,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 523.7959999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2191.412000000014,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.809,
"layouts": 7,
"layoutDurationMs": 1.671,
"taskDurationMs": 1249.675,
"heapDeltaBytes": 13467952,
"heapUsedBytes": 92856376,
"domNodes": 0,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 624.364,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2868.5710000000313,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.382999999999999,
"layouts": 7,
"layoutDurationMs": 1.8249999999999997,
"taskDurationMs": 1381.818,
"heapDeltaBytes": 18467676,
"heapUsedBytes": 97320016,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 669.4519999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66589595375723,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2847.054000000014,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.02,
"layouts": 7,
"layoutDurationMs": 1.812,
"taskDurationMs": 553.9240000000001,
"heapDeltaBytes": 8464668,
"heapUsedBytes": 85368040,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 250.699,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66608187134503,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2893.6590000000137,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.417,
"layouts": 8,
"layoutDurationMs": 2.2529999999999997,
"taskDurationMs": 558.686,
"heapDeltaBytes": -32213916,
"heapUsedBytes": 60371608,
"domNodes": -257,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 255.805,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66551724137931,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2037.807999999984,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1079999999999997,
"layouts": 9,
"layoutDurationMs": 2.705,
"taskDurationMs": 490.79900000000004,
"heapDeltaBytes": -15222848,
"heapUsedBytes": 73596632,
"domNodes": -257,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 32.776,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-idle",
"durationMs": 2035.2250000000254,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7989999999999995,
"layouts": 8,
"layoutDurationMs": 2.372,
"taskDurationMs": 525.03,
"heapDeltaBytes": -27533020,
"heapUsedBytes": 65787516,
"domNodes": -257,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 35.81000000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2690.9510000000128,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.017,
"layouts": 7,
"layoutDurationMs": 1.8989999999999996,
"taskDurationMs": 425.4430000000001,
"heapDeltaBytes": 1703568,
"heapUsedBytes": 80287196,
"domNodes": -251,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 137.365,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66604938271605,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2680.7400000000143,
"styleRecalcs": 27,
"styleRecalcDurationMs": 10.274,
"layouts": 7,
"layoutDurationMs": 1.541,
"taskDurationMs": 412.186,
"heapDeltaBytes": -15294408,
"heapUsedBytes": 63848392,
"domNodes": -256,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 133.671,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66583850931677,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 2938.2779999999966,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4010000000000002,
"layouts": 8,
"layoutDurationMs": 1.9940000000000002,
"taskDurationMs": 650.1350000000001,
"heapDeltaBytes": -11544068,
"heapUsedBytes": 62157872,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 244.53600000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915255,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-topology-cadence",
"durationMs": 3105.684999999994,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2970000000000006,
"layouts": 7,
"layoutDurationMs": 1.819,
"taskDurationMs": 763.411,
"heapDeltaBytes": -10883328,
"heapUsedBytes": 65307620,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 280.648,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 527.355,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.904999999999999,
"layouts": 10,
"layoutDurationMs": 2.76,
"taskDurationMs": 335.978,
"heapDeltaBytes": 579276,
"heapUsedBytes": 63745960,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 108.94800000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 542.7200000000312,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.4879999999999995,
"layouts": 10,
"layoutDurationMs": 2.948,
"taskDurationMs": 351.42600000000004,
"heapDeltaBytes": 22163624,
"heapUsedBytes": 83504508,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 115.61699999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2010.1800000000196,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.3870000000000013,
"layouts": 11,
"layoutDurationMs": 3.0380000000000003,
"taskDurationMs": 394.07300000000004,
"heapDeltaBytes": 4157016,
"heapUsedBytes": 69392944,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 9.662999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.137999999974,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.8459999999999996,
"layouts": 11,
"layoutDurationMs": 2.7680000000000002,
"taskDurationMs": 332.386,
"heapDeltaBytes": 24404824,
"heapUsedBytes": 85309504,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 8.058,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1676.1249999999848,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.407999999999998,
"layouts": 9,
"layoutDurationMs": 2.788,
"taskDurationMs": 661.263,
"heapDeltaBytes": 18019548,
"heapUsedBytes": 80218372,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 99.465,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.9899999999657,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.749000000000002,
"layouts": 9,
"layoutDurationMs": 2.163,
"taskDurationMs": 553.8929999999999,
"heapDeltaBytes": 17367156,
"heapUsedBytes": 79384596,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 83.25200000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653466,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 817.752999999982,
"styleRecalcs": 21,
"styleRecalcDurationMs": 14.818999999999996,
"layouts": 5,
"layoutDurationMs": 9.553999999999998,
"taskDurationMs": 645.497,
"heapDeltaBytes": 9711280,
"heapUsedBytes": 86603920,
"domNodes": 16030,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 21.659000000000006,
"eventListeners": 3246,
"totalBlockingTimeMs": 85,
"frameDurationMs": 19.44285714285714,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10110.437999999987,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.562,
"layouts": 8,
"layoutDurationMs": 2.065,
"taskDurationMs": 4627.8009999999995,
"heapDeltaBytes": 1533808,
"heapUsedBytes": 75332580,
"domNodes": -257,
"jsHeapTotalBytes": 3497984,
"scriptDurationMs": 2058.924,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666062602965404,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9678.278999999975,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.824999999999996,
"layouts": 8,
"layoutDurationMs": 2.007,
"taskDurationMs": 4511.085,
"heapDeltaBytes": 923992,
"heapUsedBytes": 75900680,
"domNodes": -257,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 2029.807,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665920826161788,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17018.057999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16129.879000000003,
"heapDeltaBytes": -10158716,
"heapUsedBytes": 282400700,
"domNodes": -3343,
"jsHeapTotalBytes": 10215424,
"scriptDurationMs": 242.311,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.644599303135895,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-idle",
"durationMs": 17014.080000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16456.438000000002,
"heapDeltaBytes": -16193792,
"heapUsedBytes": 267259116,
"domNodes": -3343,
"jsHeapTotalBytes": -7348224,
"scriptDurationMs": 222.895,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.621913043478266,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 18377.07999999998,
"styleRecalcs": 156,
"styleRecalcDurationMs": 17.192999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18026.196,
"heapDeltaBytes": -2038892,
"heapUsedBytes": 275511936,
"domNodes": -3343,
"jsHeapTotalBytes": 14667776,
"scriptDurationMs": 634.88,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.61883239171375,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 19065.623999999956,
"styleRecalcs": 141,
"styleRecalcDurationMs": 18.257999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18720.783,
"heapDeltaBytes": -7549876,
"heapUsedBytes": 275971532,
"domNodes": -3343,
"jsHeapTotalBytes": 16769024,
"scriptDurationMs": 675.912,
"eventListeners": -651,
"totalBlockingTimeMs": 4,
"frameDurationMs": 35.57052238805969,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5718.911999999989,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.701,
"layouts": 20,
"layoutDurationMs": 26.356999999999992,
"taskDurationMs": 5581.062,
"heapDeltaBytes": 4700164,
"heapUsedBytes": 287901964,
"domNodes": -3343,
"jsHeapTotalBytes": 27516928,
"scriptDurationMs": 84.33399999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.52690058479532,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5938.830000000053,
"styleRecalcs": 20,
"styleRecalcDurationMs": 47.16300000000001,
"layouts": 20,
"layoutDurationMs": 24.975000000000012,
"taskDurationMs": 5868.634,
"heapDeltaBytes": 15703544,
"heapUsedBytes": 298104316,
"domNodes": -307,
"jsHeapTotalBytes": 34332672,
"scriptDurationMs": 88.38399999999999,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.90058823529412,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8053.314999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7635.741000000001,
"heapDeltaBytes": -1473548,
"heapUsedBytes": 262763340,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 100.88399999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.950000000000003,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8080.367999999908,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7577.333,
"heapDeltaBytes": 556208,
"heapUsedBytes": 260927940,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 98.86199999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.872413793103448,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "workflow-execution",
"durationMs": 105.73700000003328,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.533000000000001,
"layouts": 6,
"layoutDurationMs": 2.424,
"taskDurationMs": 73.25899999999999,
"heapDeltaBytes": 5031276,
"heapUsedBytes": 65244624,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.535,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142908,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 99.8299999999972,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.27,
"layouts": 7,
"layoutDurationMs": 2.2929999999999997,
"taskDurationMs": 57.09099999999999,
"heapDeltaBytes": 4631460,
"heapUsedBytes": 64087936,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.864,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 236.12500000001546,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.619,
"layouts": 76,
"layoutDurationMs": 11.461,
"taskDurationMs": 183.167,
"heapDeltaBytes": 9728808,
"heapUsedBytes": 48908568,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 79.301,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428578,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 250.92100000006212,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.623,
"layouts": 76,
"layoutDurationMs": 13.498,
"taskDurationMs": 208.405,
"heapDeltaBytes": 9915568,
"heapUsedBytes": 50952300,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 90.423,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 263.0380000000514,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.583,
"layouts": 76,
"layoutDurationMs": 11.738999999999999,
"taskDurationMs": 236.145,
"heapDeltaBytes": -1101740,
"heapUsedBytes": 96001568,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 77.53500000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.658823529411755,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 368.55800000000727,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.624,
"layouts": 76,
"layoutDurationMs": 16.829,
"taskDurationMs": 327.807,
"heapDeltaBytes": -5055376,
"heapUsedBytes": 76945060,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 114.57600000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660869565217382,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage: 🟡 60.1% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3122 passed, 0 failed · 5 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 44811228978d1a5a0f9ef0bef54c981cbb00ac59
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (240)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.59 #22613 +/- ##
=============================================
Coverage ? 87.22%
=============================================
Files ? 3034
Lines ? 159334
Branches ? 40029
=============================================
Hits ? 138982
Misses ? 19673
Partials ? 679
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
LGTM — clean backport.
Backport of #22518 to
cloud/1.59Automatically created by backport workflow.