Repository navigation
[backport cloud/1.59] feat(agent): show thinking while the model is still writing it (BE-24439) (#22442) - #22610
Conversation
…439) (#22442) Show the agent's thinking while the model is still writing it. Today a long think leaves the panel blank until the model round ends: one Desktop reply showed nothing for 60 s and the user gave up ([PM-2331](https://linear.app/comfyorg/issue/PM-2331)). Fixes the frontend half of [BE-24439](https://linear.app/comfyorg/issue/BE-24439); the server half is in Comfy-Org/cloud#17306. - **What**: handle the new `agent_thinking_draft` event in `agentEventTransport`. Each frame replaces the thinking row's text, an empty frame withdraws it, and the round's `agent_thinking` frames take the row over. - **Breaking**: none. Against a server that does not send the event, nothing changes. - The draft is a provisional row, not a second kind of part. `adoptThinkingDraft` reuses it for the round's `agent_thinking` so it keeps its place above any answer draft, and nothing shows twice. - If a round moves on without sending thinking (tool call, answer, ask, settle), the draft is dropped with the answer draft: it was never confirmed. - A withdrawal of the answer draft leaves the thinking draft alone. They are separate streams, and a retry withdraws each. Red first: 6 of the new transport tests failed on `main`'s transport, and all pass with this change. `browser_tests/tests/agent/agentReplyDrafts.spec.ts` adds two cases: live thinking that is replaced and shown once, and a retry that withdraws. No layout change: it reuses the existing thinking row.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-01T14:11:22.583Z",
"gitSha": "a83793ae1215cc19cad1f5276395e8ccf67a50ba",
"branch": "backport-22442-to-cloud-1.59-manual",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.0149999999535,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.8049999999999993,
"layouts": 8,
"layoutDurationMs": 2.713,
"taskDurationMs": 588.0229999999999,
"heapDeltaBytes": 2251628,
"heapUsedBytes": 64061848,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 9.016000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2014.114999999947,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.0260000000000007,
"layouts": 8,
"layoutDurationMs": 2.6170000000000004,
"taskDurationMs": 571.85,
"heapDeltaBytes": 3649140,
"heapUsedBytes": 64658252,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 9.791,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1793.5010000000489,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.152000000000001,
"layouts": 10,
"layoutDurationMs": 3.4130000000000003,
"taskDurationMs": 918.9420000000001,
"heapDeltaBytes": 21672040,
"heapUsedBytes": 83025184,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 166.011,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1857.4709999999186,
"styleRecalcs": 80,
"styleRecalcDurationMs": 14.859999999999998,
"layouts": 9,
"layoutDurationMs": 2.731,
"taskDurationMs": 969.629,
"heapDeltaBytes": 21886072,
"heapUsedBytes": 83579144,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 178.033,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665765765765766,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.0849999999928,
"styleRecalcs": 20,
"styleRecalcDurationMs": 6.597,
"layouts": 10,
"layoutDurationMs": 3.2640000000000002,
"taskDurationMs": 471.99100000000004,
"heapDeltaBytes": 24123644,
"heapUsedBytes": 85202516,
"domNodes": 56,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 14.145999999999995,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.0060000000021,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.718999999999999,
"layouts": 11,
"layoutDurationMs": 3.624,
"taskDurationMs": 472.21899999999994,
"heapDeltaBytes": -636436,
"heapUsedBytes": 60015372,
"domNodes": 56,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 12.805000000000003,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 760.8740000000012,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.4070000000000005,
"layouts": 10,
"layoutDurationMs": 3.397,
"taskDurationMs": 529.999,
"heapDeltaBytes": 3056900,
"heapUsedBytes": 64872436,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 175.976,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664444444444435,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 727.9100000000653,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.201,
"layouts": 9,
"layoutDurationMs": 2.904,
"taskDurationMs": 521.3330000000001,
"heapDeltaBytes": 5331652,
"heapUsedBytes": 66692784,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 179.299,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1229.013000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 941.645,
"heapDeltaBytes": -12347632,
"heapUsedBytes": 75749476,
"domNodes": -191,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 73.37199999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 543,
"frameDurationMs": 33.32972972972973,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1268.3749999999918,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1009.8259999999999,
"heapDeltaBytes": -12785220,
"heapUsedBytes": 74807472,
"domNodes": -191,
"jsHeapTotalBytes": 22028288,
"scriptDurationMs": 77.043,
"eventListeners": -106,
"totalBlockingTimeMs": 568,
"frameDurationMs": 33.331578947368406,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 859.9140000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.6299999999998,
"heapDeltaBytes": -3494124,
"heapUsedBytes": 68557728,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 176.87199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 233,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 956.1129999999594,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.0329999999997,
"heapDeltaBytes": -17012124,
"heapUsedBytes": 65892560,
"domNodes": -191,
"jsHeapTotalBytes": 1966080,
"scriptDurationMs": 185.60999999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 232,
"frameDurationMs": 24.356410256410246,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11338.854000000027,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.0629999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10517.174,
"heapDeltaBytes": 90086576,
"heapUsedBytes": 164274596,
"domNodes": -257,
"jsHeapTotalBytes": 74051584,
"scriptDurationMs": 8349.407,
"eventListeners": -68,
"totalBlockingTimeMs": 1373,
"frameDurationMs": 31.92338028169014,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10716.138,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9895.495,
"heapDeltaBytes": 69410436,
"heapUsedBytes": 143996512,
"domNodes": -257,
"jsHeapTotalBytes": 66449408,
"scriptDurationMs": 7879.818,
"eventListeners": -68,
"totalBlockingTimeMs": 1007,
"frameDurationMs": 31.334210526315786,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10939.056999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10194.182,
"heapDeltaBytes": 74753380,
"heapUsedBytes": 150107724,
"domNodes": -257,
"jsHeapTotalBytes": 73527296,
"scriptDurationMs": 8197.338,
"eventListeners": -68,
"totalBlockingTimeMs": 1085,
"frameDurationMs": 31.689565217391305,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11002.019000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10240.507,
"heapDeltaBytes": 73479464,
"heapUsedBytes": 155640148,
"domNodes": -257,
"jsHeapTotalBytes": 79818752,
"scriptDurationMs": 8253.848,
"eventListeners": -68,
"totalBlockingTimeMs": 1237,
"frameDurationMs": 31.517191977077363,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 279.25500000003467,
"styleRecalcs": 25,
"styleRecalcDurationMs": 14.729,
"layouts": 11,
"layoutDurationMs": 4.193,
"taskDurationMs": 236.183,
"heapDeltaBytes": -914792,
"heapUsedBytes": 68420284,
"domNodes": -2315,
"jsHeapTotalBytes": -1048576,
"scriptDurationMs": 15.035,
"eventListeners": -573,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.224999999999984,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "large-combo-open",
"durationMs": 279.35600000000704,
"styleRecalcs": 21,
"styleRecalcDurationMs": 16.159,
"layouts": 8,
"layoutDurationMs": 3.251999999999999,
"taskDurationMs": 225.817,
"heapDeltaBytes": -21796216,
"heapUsedBytes": 69443120,
"domNodes": -2315,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 12.048000000000002,
"eventListeners": -573,
"totalBlockingTimeMs": 8,
"frameDurationMs": 25.763636363636373,
"p95FrameDurationMs": 100
},
{
"name": "large-graph-idle",
"durationMs": 2054.532999999992,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.189,
"layouts": 8,
"layoutDurationMs": 2.501,
"taskDurationMs": 693.2550000000001,
"heapDeltaBytes": -26129480,
"heapUsedBytes": 65169624,
"domNodes": -257,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 37.062,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.4729999999827,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.809999999999999,
"layouts": 7,
"layoutDurationMs": 2.839,
"taskDurationMs": 740.757,
"heapDeltaBytes": -9102244,
"heapUsedBytes": 67327396,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 38.96000000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3058.729000000028,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.045,
"layouts": 6,
"layoutDurationMs": 2.049,
"taskDurationMs": 1972.024,
"heapDeltaBytes": -13432212,
"heapUsedBytes": 62419044,
"domNodes": -257,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 992.5089999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75714285714286,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3099.309000000062,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.690000000000001,
"layouts": 5,
"layoutDurationMs": 1.6199999999999999,
"taskDurationMs": 1999.557,
"heapDeltaBytes": -16055600,
"heapUsedBytes": 76052572,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 940.4240000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258063,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3779.066999999941,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.693000000000001,
"layouts": 63,
"layoutDurationMs": 11.413,
"taskDurationMs": 1876.887,
"heapDeltaBytes": 5279572,
"heapUsedBytes": 82720348,
"domNodes": 24,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 863.75,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666079295154187,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3994.4570000000112,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.604,
"layouts": 64,
"layoutDurationMs": 12.165000000000001,
"taskDurationMs": 2007.0769999999998,
"heapDeltaBytes": -15827472,
"heapUsedBytes": 61043032,
"domNodes": -233,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 866.4470000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665833333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3311.815000000024,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.242999999999999,
"layouts": 5,
"layoutDurationMs": 2.046,
"taskDurationMs": 2250.768,
"heapDeltaBytes": 7599240,
"heapUsedBytes": 85548284,
"domNodes": -257,
"jsHeapTotalBytes": 5001216,
"scriptDurationMs": 1082.172,
"eventListeners": -60,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.836224489795917,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3284.7020000000384,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.854,
"layouts": 4,
"layoutDurationMs": 1.4369999999999998,
"taskDurationMs": 2230.2889999999998,
"heapDeltaBytes": 1579488,
"heapUsedBytes": 82166232,
"domNodes": -257,
"jsHeapTotalBytes": 5787648,
"scriptDurationMs": 1081.856,
"eventListeners": -62,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.836410256410257,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3169.242000000054,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9170000000000003,
"layouts": 6,
"layoutDurationMs": 1.5600000000000003,
"taskDurationMs": 865.473,
"heapDeltaBytes": -18679288,
"heapUsedBytes": 59126364,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 392.61400000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3151.1580000000095,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.306,
"layouts": 6,
"layoutDurationMs": 1.7429999999999997,
"taskDurationMs": 876.109,
"heapDeltaBytes": 4582760,
"heapUsedBytes": 85159184,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 405.18199999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.754787234042553,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2042.3580000000356,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.339,
"layouts": 7,
"layoutDurationMs": 1.9739999999999995,
"taskDurationMs": 672.724,
"heapDeltaBytes": -2704036,
"heapUsedBytes": 76325664,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 35.328,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2045.4009999999698,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.037,
"layouts": 8,
"layoutDurationMs": 2.539,
"taskDurationMs": 698.497,
"heapDeltaBytes": 2302696,
"heapUsedBytes": 82077960,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 36.32900000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2801.423,
"styleRecalcs": 25,
"styleRecalcDurationMs": 12.750000000000002,
"layouts": 6,
"layoutDurationMs": 1.5470000000000002,
"taskDurationMs": 638.749,
"heapDeltaBytes": -6358016,
"heapUsedBytes": 72297892,
"domNodes": -246,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 211.939,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571428,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2802.4729999999636,
"styleRecalcs": 26,
"styleRecalcDurationMs": 13.347000000000001,
"layouts": 6,
"layoutDurationMs": 1.7890000000000001,
"taskDurationMs": 692.4679999999998,
"heapDeltaBytes": -9653472,
"heapUsedBytes": 67507556,
"domNodes": -255,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 218.917,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571428,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3355.7250000000067,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9639999999999995,
"layouts": 4,
"layoutDurationMs": 1.1029999999999998,
"taskDurationMs": 982.6519999999999,
"heapDeltaBytes": 7980476,
"heapUsedBytes": 69302680,
"domNodes": -257,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 403.118,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7495,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3405.8539999999766,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.7919999999999994,
"layouts": 5,
"layoutDurationMs": 1.6760000000000004,
"taskDurationMs": 1059.823,
"heapDeltaBytes": 656560,
"heapUsedBytes": 77734936,
"domNodes": -257,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 435.03700000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.830049261083744,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 713.5700000000043,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.978,
"layouts": 8,
"layoutDurationMs": 2.99,
"taskDurationMs": 492.97099999999995,
"heapDeltaBytes": -1518032,
"heapUsedBytes": 60510716,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 153.841,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 697.0429999998942,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.622,
"layouts": 9,
"layoutDurationMs": 2.8589999999999995,
"taskDurationMs": 469.546,
"heapDeltaBytes": 607656,
"heapUsedBytes": 62855616,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 152.929,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66341463414634,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.882999999979,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.201,
"layouts": 8,
"layoutDurationMs": 2.7799999999999994,
"taskDurationMs": 575.6210000000001,
"heapDeltaBytes": 1951296,
"heapUsedBytes": 63618108,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 8.994000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2007.6199999999744,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.4479999999999986,
"layouts": 9,
"layoutDurationMs": 2.8579999999999997,
"taskDurationMs": 566.019,
"heapDeltaBytes": 3342088,
"heapUsedBytes": 65222232,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 10.429999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.7550000000201,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.594,
"layouts": 9,
"layoutDurationMs": 2.6260000000000003,
"taskDurationMs": 906.349,
"heapDeltaBytes": 17083148,
"heapUsedBytes": 79344584,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 122.53999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.588000000026,
"styleRecalcs": 78,
"styleRecalcDurationMs": 16.767,
"layouts": 8,
"layoutDurationMs": 2.9070000000000005,
"taskDurationMs": 967.9779999999998,
"heapDeltaBytes": 17101708,
"heapUsedBytes": 79655044,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 130.645,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1469.2890000000034,
"styleRecalcs": 17,
"styleRecalcDurationMs": 23.426999999999996,
"layouts": 5,
"layoutDurationMs": 14.901999999999996,
"taskDurationMs": 1084.09,
"heapDeltaBytes": 13978372,
"heapUsedBytes": 116320612,
"domNodes": 16030,
"jsHeapTotalBytes": 15863808,
"scriptDurationMs": 33.54399999999999,
"eventListeners": 3246,
"totalBlockingTimeMs": 157,
"frameDurationMs": 20.044594594594596,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10032.475999999973,
"styleRecalcs": 251,
"styleRecalcDurationMs": 34.053,
"layouts": 8,
"layoutDurationMs": 2.371,
"taskDurationMs": 6515.249,
"heapDeltaBytes": 7180324,
"heapUsedBytes": 85598604,
"domNodes": -257,
"jsHeapTotalBytes": 3727360,
"scriptDurationMs": 2985.4379999999996,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665946843853824,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9889.340999999946,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.351,
"layouts": 6,
"layoutDurationMs": 2.1530000000000005,
"taskDurationMs": 6569.915,
"heapDeltaBytes": 2639436,
"heapUsedBytes": 81145672,
"domNodes": -257,
"jsHeapTotalBytes": 3465216,
"scriptDurationMs": 2980.806,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.694256756756754,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 25682.46799999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 25000.442,
"heapDeltaBytes": -17555276,
"heapUsedBytes": 274327160,
"domNodes": -3343,
"jsHeapTotalBytes": 8904704,
"scriptDurationMs": 421.41700000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.13585237258348,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-idle",
"durationMs": 25489.09500000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24822.223,
"heapDeltaBytes": -23986328,
"heapUsedBytes": 257849220,
"domNodes": -3343,
"jsHeapTotalBytes": 13099008,
"scriptDurationMs": 439.03900000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.19237435008665,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 30150.48200000001,
"styleRecalcs": 181,
"styleRecalcDurationMs": 21.510999999999974,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 29834.244,
"heapDeltaBytes": -9001604,
"heapUsedBytes": 267154888,
"domNodes": -3343,
"jsHeapTotalBytes": 12836864,
"scriptDurationMs": 959.415,
"eventListeners": -651,
"totalBlockingTimeMs": 127,
"frameDurationMs": 55.65590405904059,
"p95FrameDurationMs": 116.69999999999709
},
{
"name": "vue-large-graph-pan",
"durationMs": 30437.320999999996,
"styleRecalcs": 181,
"styleRecalcDurationMs": 21.744999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 30106.999000000003,
"heapDeltaBytes": -616980,
"heapUsedBytes": 276160412,
"domNodes": -3343,
"jsHeapTotalBytes": 12050432,
"scriptDurationMs": 960.8749999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 69,
"frameDurationMs": 56.988951310861424,
"p95FrameDurationMs": 116.69999999999891
},
{
"name": "vue-node-resize-workload",
"durationMs": 8924.203000000034,
"styleRecalcs": 20,
"styleRecalcDurationMs": 91.61899999999997,
"layouts": 20,
"layoutDurationMs": 29.768000000000004,
"taskDurationMs": 8817.554,
"heapDeltaBytes": -22828696,
"heapUsedBytes": 269265492,
"domNodes": -3343,
"jsHeapTotalBytes": 14143488,
"scriptDurationMs": 141.778,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 51.24310344827587,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 9233.669000000078,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.212,
"layouts": 20,
"layoutDurationMs": 26.29200000000001,
"taskDurationMs": 9140.432999999999,
"heapDeltaBytes": -26072756,
"heapUsedBytes": 255691340,
"domNodes": -3343,
"jsHeapTotalBytes": 16506880,
"scriptDurationMs": 143.01799999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 54.31117647058822,
"p95FrameDurationMs": 116.69999999999709
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12716.433999999936,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12390.027,
"heapDeltaBytes": 23388272,
"heapUsedBytes": 284139772,
"domNodes": 0,
"jsHeapTotalBytes": -10223616,
"scriptDurationMs": 199.1069999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.25238095238094,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12628.637000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12426.352,
"heapDeltaBytes": -9864484,
"heapUsedBytes": 249134420,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 190.01000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.71086956521739,
"p95FrameDurationMs": 100
},
{
"name": "workflow-execution",
"durationMs": 145.70100000003094,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.371,
"layouts": 9,
"layoutDurationMs": 3.843,
"taskDurationMs": 105.81900000000002,
"heapDeltaBytes": 4780456,
"heapUsedBytes": 65702004,
"domNodes": 102,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.254999999999999,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 500.6349999999884,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.971,
"layouts": 9,
"layoutDurationMs": 3.4179999999999997,
"taskDurationMs": 130.53300000000002,
"heapDeltaBytes": -10480660,
"heapUsedBytes": 66834748,
"domNodes": 99,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 12.134,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 510.2309999999761,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.709,
"layouts": 76,
"layoutDurationMs": 15.710999999999999,
"taskDurationMs": 455.451,
"heapDeltaBytes": -4742132,
"heapUsedBytes": 41079876,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 215.884,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 499.8330000000806,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6629999999999999,
"layouts": 76,
"layoutDurationMs": 16.105,
"taskDurationMs": 458.11800000000005,
"heapDeltaBytes": -4358380,
"heapUsedBytes": 41509984,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 219.342,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 675.8899999999812,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.26,
"layouts": 76,
"layoutDurationMs": 16.682,
"taskDurationMs": 643.428,
"heapDeltaBytes": 2257340,
"heapUsedBytes": 100551600,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 266.598,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.082499999999982,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 658.380999999963,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.693,
"layouts": 76,
"layoutDurationMs": 16.845,
"taskDurationMs": 619.768,
"heapDeltaBytes": 1428940,
"heapUsedBytes": 95464144,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 258.115,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.092307692307703,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage: 🟡 60.0% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3126 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 64e67b23ea319bed5148a13a73787d750afbd206
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (240)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
This comment has been minimized.
This comment has been minimized.
Keeps applyChatEvent under the fallow complexity gate after adding the agent_thinking_draft case.
dante01yoon
left a comment
There was a problem hiding this comment.
LGTM — backport of an already-merged change.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.59 #22610 +/- ##
=============================================
Coverage ? 87.22%
=============================================
Files ? 3034
Lines ? 159336
Branches ? 40019
=============================================
Hits ? 138976
Misses ? 19681
Partials ? 679
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation failed to run ( Evaluation budget remaining for this pull request: 99 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
|
Merge judgment: approved at exact head 11c46ef, all checks green (only the release-sheriff assignment job is still running, not a test). The base branch moved since this was cut, with zero file overlap with this PR, so merging at this head. |
Manual backport of #22442 to
cloud/1.59(auto-backport hit conflicts). Shows the agent's thinking while the model is still writing it (BE-24439). Its server half, https://github.com/Comfy-Org/cloud/pull/17306, is merged; older servers never send the new event, so this is inert until they do.Conflict resolution:
agentEventTransport.ts: this branch still settles onagent_message_doneinside the event switch; kept that case and added the newagent_thinking_draftcase beside it.Testing: CI; agent service unit tests pass locally.
applyChatEventover the fallow complexity gate on this branch, soagent_message_doneis now handled iningestbefore the switch, the same waymaindoes it (AgentNonTerminalEvent). Same behaviour.