Repository navigation
[backport cloud/1.59] fix(telemetry): stop paging when page-evaluated code runs an unknown command - #22589
Conversation
…command (#22409) Sentry paged [CLOUD-FRONTEND-PROD-361](https://comfy-org.sentry.io/issues/7819207108/) on `Command Comfy.CloseWorkflow not found`. Nothing is broken for users: the ID has never existed in this repo, and the real command is `Workspace.CloseWorkflow`. This keeps the event in Sentry and tags it so it stops paging. A bad ID reached from our own code still pages. - One event, one user, on 1.58.0. `custom_node_count` was 0. - Stack, oldest first: `<anonymous>:1:38` → Pinia `wrappedAction` → `commandStore.execute`. There is no first-party caller. - Reproduced in Chromium: with CDP `Runtime.evaluate`, `window.app?.extensionManager.command.execute('Comfy.CloseWorkflow')` throws from exactly `<anonymous>:1:38`. Other strings could land on that column, so that is consistent with a one-line page script, not proof of who ran it. `app.extensionManager.command.execute` is public and takes any string. The rejection comes from `commandStore`, so the top frame looks first-party. `tagSentryEvaluatedCommandCaller` sets `error_origin: third_party` when the last exception is `Command <id> not found` and its direct caller is code evaluated in the page. That means a frame named `<anonymous>` with a line number; engine builtins share the name but have no line number. The `Send a notification for high priority issues` alert already skips `error_origin: third_party`, so no rule change is needed. Public behaviour is unchanged: `execute` still rejects, and the event is retained. [#22403](#22403) sets the same tag from the top stack frame, which is `commandStore` here, so it treats this event as first-party. This PR adds its own file plus one line in `sentryBeforeSend`, so whichever lands second has a one-line rebase. - The 3 older `Command … not found` issues (`Comfy.ExportWorkflow`, `Comfy.ExportWorkflowAPI`, `Comfy.User.OpenSignInDialog`, all on `/cloud/login`) would keep paging: their callers are bundled code, and a test uses that shape. - A caller inside a custom extension file also keeps paging. No such event exists yet. - Datadog RUM classifies by the first `/assets/` line, so it still reads this as first-party. That only labels the error; it pages nobody. - No `Comfy.CloseWorkflow` alias: one event does not justify one. - Red first: `sentryEvaluatedCommandCaller.test.ts` failed on the untagged event, then passed with the change. - `defaultStackParser` runs on the stack lines from the real Sentry events, so the frame shape is not hand-written. - `vitest` on `sentryBeforeSend`, `thirdPartyErrorNoise`, `initSentry` and the new file: 41 passed. No UI change. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> (cherry picked from commit 070eb3e) (cherry picked from commit e1bf8d2)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-01T10:44:04.956Z",
"gitSha": "f4bb7854da96081aadf7280a277108b52db36f6d",
"branch": "backport-22409-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.3409999999926,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.3499999999999996,
"layouts": 9,
"layoutDurationMs": 3.1439999999999997,
"taskDurationMs": 651.064,
"heapDeltaBytes": 2638416,
"heapUsedBytes": 64223884,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 14.060999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2023.5910000000104,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.391,
"layouts": 9,
"layoutDurationMs": 3.2979999999999996,
"taskDurationMs": 646.981,
"heapDeltaBytes": 1735332,
"heapUsedBytes": 63038568,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 14.437999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1906.394000000006,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.317000000000002,
"layouts": 9,
"layoutDurationMs": 3.0460000000000003,
"taskDurationMs": 980.5140000000001,
"heapDeltaBytes": 22453360,
"heapUsedBytes": 84017004,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 174.52200000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684207,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1873.2329999999138,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.323,
"layouts": 10,
"layoutDurationMs": 3.1229999999999998,
"taskDurationMs": 965.644,
"heapDeltaBytes": 21846688,
"heapUsedBytes": 83157536,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 172.11800000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666964285714283,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.379000000003,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.618,
"layouts": 9,
"layoutDurationMs": 3.204,
"taskDurationMs": 482.941,
"heapDeltaBytes": 25020060,
"heapUsedBytes": 86117472,
"domNodes": 56,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 15.955999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.8669999999884,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.652,
"layouts": 10,
"layoutDurationMs": 3.8299999999999996,
"taskDurationMs": 486.295,
"heapDeltaBytes": -876388,
"heapUsedBytes": 59800476,
"domNodes": 56,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 16.304000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 742.9710000000114,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.935,
"layouts": 8,
"layoutDurationMs": 2.3559999999999994,
"taskDurationMs": 530.7030000000001,
"heapDeltaBytes": 3692620,
"heapUsedBytes": 65520040,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 177.944,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66363636363636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 761.3380000000234,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.099000000000001,
"layouts": 9,
"layoutDurationMs": 2.6560000000000006,
"taskDurationMs": 544.219,
"heapDeltaBytes": 3788996,
"heapUsedBytes": 65014892,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 180.679,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1270.083999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1009.83,
"heapDeltaBytes": -13648232,
"heapUsedBytes": 75460660,
"domNodes": -191,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 71.23899999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 578,
"frameDurationMs": 34.23513513513513,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1289.5049999999628,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1028.709,
"heapDeltaBytes": -1022368,
"heapUsedBytes": 75541464,
"domNodes": -191,
"jsHeapTotalBytes": 14163968,
"scriptDurationMs": 73.55399999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 590,
"frameDurationMs": 34.68648648648648,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 874.307999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.9230000000001,
"heapDeltaBytes": -4755036,
"heapUsedBytes": 69542820,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 175.42400000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 232,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 868.5440000000426,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.8609999999993,
"heapDeltaBytes": -4332568,
"heapUsedBytes": 70257536,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 176.48499999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 230,
"frameDurationMs": 25.491176470588204,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11926.557000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11024.132,
"heapDeltaBytes": 76576252,
"heapUsedBytes": 149983316,
"domNodes": -257,
"jsHeapTotalBytes": 77197312,
"scriptDurationMs": 8878.102,
"eventListeners": -68,
"totalBlockingTimeMs": 1644,
"frameDurationMs": 31.90614973262032,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11499.504,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10715.942000000001,
"heapDeltaBytes": -4644356,
"heapUsedBytes": 68931556,
"domNodes": -257,
"jsHeapTotalBytes": 18214912,
"scriptDurationMs": 8615.309,
"eventListeners": -68,
"totalBlockingTimeMs": 1305,
"frameDurationMs": 31.993074792243767,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11287.455999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10491,
"heapDeltaBytes": 81584652,
"heapUsedBytes": 153965040,
"domNodes": -257,
"jsHeapTotalBytes": 74575872,
"scriptDurationMs": 8433.284,
"eventListeners": -68,
"totalBlockingTimeMs": 1350,
"frameDurationMs": 31.604761904761904,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 12261.385000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11523.465,
"heapDeltaBytes": 11183068,
"heapUsedBytes": 85526004,
"domNodes": -257,
"jsHeapTotalBytes": 18739200,
"scriptDurationMs": 9368.557,
"eventListeners": -68,
"totalBlockingTimeMs": 1883,
"frameDurationMs": 32.974530831099194,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 341.8920000000014,
"styleRecalcs": 26,
"styleRecalcDurationMs": 16.956,
"layouts": 11,
"layoutDurationMs": 3.87,
"taskDurationMs": 294.73599999999993,
"heapDeltaBytes": -15753460,
"heapUsedBytes": 59704668,
"domNodes": 936,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 11.116999999999999,
"eventListeners": -640,
"totalBlockingTimeMs": 6,
"frameDurationMs": 25.638461538461552,
"p95FrameDurationMs": 116.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 244.1650000000095,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.108,
"layouts": 10,
"layoutDurationMs": 3.1279999999999997,
"taskDurationMs": 196.197,
"heapDeltaBytes": 14624656,
"heapUsedBytes": 70783896,
"domNodes": -2315,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.427000000000001,
"eventListeners": -573,
"totalBlockingTimeMs": 6,
"frameDurationMs": 22.72727272727277,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2056.7840000000215,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8249999999999993,
"layouts": 8,
"layoutDurationMs": 2.5109999999999997,
"taskDurationMs": 767.0360000000001,
"heapDeltaBytes": 1708540,
"heapUsedBytes": 79045764,
"domNodes": -257,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 38.163999999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2056.331,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4699999999999998,
"layouts": 7,
"layoutDurationMs": 2.364,
"taskDurationMs": 764.8549999999999,
"heapDeltaBytes": -15679236,
"heapUsedBytes": 59427372,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 36.753,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2888.211999999953,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.860999999999999,
"layouts": 7,
"layoutDurationMs": 2.1629999999999994,
"taskDurationMs": 1891.049,
"heapDeltaBytes": -31209176,
"heapUsedBytes": 60919436,
"domNodes": -257,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 907.297,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666473988439304,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2761.556999999925,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.136,
"layouts": 6,
"layoutDurationMs": 1.8849999999999996,
"taskDurationMs": 1874.848,
"heapDeltaBytes": -898700,
"heapUsedBytes": 76455088,
"domNodes": -257,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 884.883,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76768292682927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 4028.656999999953,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.301999999999998,
"layouts": 64,
"layoutDurationMs": 11.495,
"taskDurationMs": 1942.4250000000002,
"heapDeltaBytes": 7389004,
"heapUsedBytes": 87398992,
"domNodes": 24,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 890.4499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665702479338844,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3975.330999999983,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.579000000000002,
"layouts": 65,
"layoutDurationMs": 11.437,
"taskDurationMs": 1968.283,
"heapDeltaBytes": 7408332,
"heapUsedBytes": 84213792,
"domNodes": -233,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 852.367,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665966386554622,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3129.5189999999593,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.422000000000001,
"layouts": 5,
"layoutDurationMs": 1.7249999999999996,
"taskDurationMs": 2069.91,
"heapDeltaBytes": 22839164,
"heapUsedBytes": 102565144,
"domNodes": 0,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 1007.6229999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84516129032258,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3271.6970000000174,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.6450000000000005,
"layouts": 5,
"layoutDurationMs": 1.6130000000000002,
"taskDurationMs": 2240.758,
"heapDeltaBytes": 8773644,
"heapUsedBytes": 81869996,
"domNodes": -257,
"jsHeapTotalBytes": 3428352,
"scriptDurationMs": 1105.23,
"eventListeners": -62,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.837628865979383,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3198.775000000012,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.687,
"layouts": 5,
"layoutDurationMs": 1.5839999999999999,
"taskDurationMs": 881.385,
"heapDeltaBytes": 302852,
"heapUsedBytes": 75537056,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 414.92699999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.753403141361254,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3210.1180000000227,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7979999999999992,
"layouts": 6,
"layoutDurationMs": 1.6049999999999998,
"taskDurationMs": 900.406,
"heapDeltaBytes": -11787624,
"heapUsedBytes": 81822716,
"domNodes": -257,
"jsHeapTotalBytes": 6455296,
"scriptDurationMs": 424.203,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.753403141361257,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2059.5539999999914,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.2189999999999994,
"layouts": 6,
"layoutDurationMs": 2.196,
"taskDurationMs": 827.249,
"heapDeltaBytes": -17820632,
"heapUsedBytes": 69645736,
"domNodes": -257,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 40.221,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2053.038000000015,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.8529999999999995,
"layouts": 6,
"layoutDurationMs": 2.155,
"taskDurationMs": 816.2120000000001,
"heapDeltaBytes": -10390764,
"heapUsedBytes": 66468836,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 39.787000000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666664,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2944.2430000000004,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.79,
"layouts": 7,
"layoutDurationMs": 2.1569999999999996,
"taskDurationMs": 692.683,
"heapDeltaBytes": -12419616,
"heapUsedBytes": 69526388,
"domNodes": -241,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 206.66199999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2968.119999999999,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.717,
"layouts": 7,
"layoutDurationMs": 1.885,
"taskDurationMs": 731.753,
"heapDeltaBytes": -9472312,
"heapUsedBytes": 83803236,
"domNodes": -251,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 231.08700000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66629213483146,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3336.0660000000166,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.6150000000000002,
"layouts": 5,
"layoutDurationMs": 1.3809999999999998,
"taskDurationMs": 1034.5929999999998,
"heapDeltaBytes": -15724464,
"heapUsedBytes": 62030680,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 398.816,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3388.8200000000097,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.5339999999999998,
"layouts": 5,
"layoutDurationMs": 1.4719999999999998,
"taskDurationMs": 1060.333,
"heapDeltaBytes": -5358980,
"heapUsedBytes": 70630488,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 418.022,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7490099009901,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 696.9210000000317,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.199999999999999,
"layouts": 9,
"layoutDurationMs": 2.836,
"taskDurationMs": 474.84900000000005,
"heapDeltaBytes": 1481580,
"heapUsedBytes": 62491984,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 150.89600000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 723.0500000000575,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.166,
"layouts": 8,
"layoutDurationMs": 2.5990000000000006,
"taskDurationMs": 479.41999999999996,
"heapDeltaBytes": -1244548,
"heapUsedBytes": 61201212,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 153.36699999999996,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069753,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2024.5439999999917,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6900000000000004,
"layouts": 8,
"layoutDurationMs": 2.4109999999999996,
"taskDurationMs": 627.511,
"heapDeltaBytes": 2072212,
"heapUsedBytes": 64571672,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 12.451999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.097000000007,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.119,
"layouts": 9,
"layoutDurationMs": 3.1260000000000003,
"taskDurationMs": 626.6089999999999,
"heapDeltaBytes": 4633248,
"heapUsedBytes": 66490912,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 12.229999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1851.1320000000069,
"styleRecalcs": 78,
"styleRecalcDurationMs": 15.258000000000001,
"layouts": 7,
"layoutDurationMs": 2.256,
"taskDurationMs": 1030.848,
"heapDeltaBytes": 17118224,
"heapUsedBytes": 79598472,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 129.745,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1848.5729999999876,
"styleRecalcs": 79,
"styleRecalcDurationMs": 16.472,
"layouts": 7,
"layoutDurationMs": 2.262,
"taskDurationMs": 985.485,
"heapDeltaBytes": 19323520,
"heapUsedBytes": 81330348,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 121.309,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576576576577,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1485.8859999999936,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.605000000000008,
"layouts": 5,
"layoutDurationMs": 14.901000000000002,
"taskDurationMs": 1213.7570000000003,
"heapDeltaBytes": 9384448,
"heapUsedBytes": 102677720,
"domNodes": 16030,
"jsHeapTotalBytes": 6688768,
"scriptDurationMs": 35.27200000000001,
"eventListeners": 3246,
"totalBlockingTimeMs": 181,
"frameDurationMs": 19.775999999999996,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10477.366000000018,
"styleRecalcs": 249,
"styleRecalcDurationMs": 30.195,
"layouts": 7,
"layoutDurationMs": 1.9559999999999997,
"taskDurationMs": 6512.657000000001,
"heapDeltaBytes": 1211960,
"heapUsedBytes": 75923220,
"domNodes": -257,
"jsHeapTotalBytes": 3989504,
"scriptDurationMs": 2894.934,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69251592356688,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10912.33699999998,
"styleRecalcs": 249,
"styleRecalcDurationMs": 30.298000000000002,
"layouts": 7,
"layoutDurationMs": 2.204,
"taskDurationMs": 6875.987,
"heapDeltaBytes": 14993284,
"heapUsedBytes": 89897532,
"domNodes": -257,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 3209.069,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.691284403669727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 24153.877000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23521.71,
"heapDeltaBytes": -23464760,
"heapUsedBytes": 257519920,
"domNodes": -3343,
"jsHeapTotalBytes": 11264000,
"scriptDurationMs": 353.88100000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.74176991150442,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 23713.78900000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23216.002,
"heapDeltaBytes": -23621940,
"heapUsedBytes": 276849552,
"domNodes": -3373,
"jsHeapTotalBytes": 8118272,
"scriptDurationMs": 354.202,
"eventListeners": -669,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.39552772808587,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 28853.054999999982,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.594999999999978,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28532.698999999997,
"heapDeltaBytes": -11160744,
"heapUsedBytes": 271408956,
"domNodes": -3343,
"jsHeapTotalBytes": 14667776,
"scriptDurationMs": 913.4019999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 28,
"frameDurationMs": 54.12532833020637,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 28475.53400000004,
"styleRecalcs": 181,
"styleRecalcDurationMs": 21.688000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28174.346,
"heapDeltaBytes": -22119688,
"heapUsedBytes": 254224908,
"domNodes": -3343,
"jsHeapTotalBytes": 15458304,
"scriptDurationMs": 958.634,
"eventListeners": -651,
"totalBlockingTimeMs": 43,
"frameDurationMs": 53.4063789868668,
"p95FrameDurationMs": 100.10000000000582
},
{
"name": "vue-node-resize-workload",
"durationMs": 8637.200000000008,
"styleRecalcs": 20,
"styleRecalcDurationMs": 92.66499999999999,
"layouts": 20,
"layoutDurationMs": 25.524000000000004,
"taskDurationMs": 8476.365,
"heapDeltaBytes": 7178076,
"heapUsedBytes": 280721420,
"domNodes": -3343,
"jsHeapTotalBytes": 16240640,
"scriptDurationMs": 129.53500000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.4994382022472,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 8299.96099999994,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.64300000000001,
"layouts": 20,
"layoutDurationMs": 24.569999999999993,
"taskDurationMs": 8156.782,
"heapDeltaBytes": -899516,
"heapUsedBytes": 240774372,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 134.71,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.890960451977406,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12321.532999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11952.25,
"heapDeltaBytes": 3468124,
"heapUsedBytes": 258678732,
"domNodes": 0,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 169.49000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.56340579710145,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11746.10000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11443.848,
"heapDeltaBytes": 18390668,
"heapUsedBytes": 286438368,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 168.53800000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.08216783216783,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 153.7270000000035,
"styleRecalcs": 12,
"styleRecalcDurationMs": 13.592999999999998,
"layouts": 10,
"layoutDurationMs": 5.326,
"taskDurationMs": 122.47,
"heapDeltaBytes": 4775964,
"heapUsedBytes": 64398312,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.705000000000002,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.677777777777766,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 128.5649999999805,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.716,
"layouts": 9,
"layoutDurationMs": 4.124999999999999,
"taskDurationMs": 100.212,
"heapDeltaBytes": 4684044,
"heapUsedBytes": 65129688,
"domNodes": 133,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.982,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67500000000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 517.4719999999979,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.7110000000000001,
"layouts": 76,
"layoutDurationMs": 15.699000000000002,
"taskDurationMs": 470.01300000000003,
"heapDeltaBytes": -3918244,
"heapUsedBytes": 41813764,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 228.493,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 584.9809999999707,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.848,
"layouts": 76,
"layoutDurationMs": 17.919999999999998,
"taskDurationMs": 532.1629999999999,
"heapDeltaBytes": -612488,
"heapUsedBytes": 45268072,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 252.90599999999998,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 593.8899999999876,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.316,
"layouts": 76,
"layoutDurationMs": 15.831000000000001,
"taskDurationMs": 556.476,
"heapDeltaBytes": 614564,
"heapUsedBytes": 94521020,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 224.168,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 627.5080000000344,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.7590000000000003,
"layouts": 76,
"layoutDurationMs": 16.488,
"taskDurationMs": 587.2539999999999,
"heapDeltaBytes": 2246456,
"heapUsedBytes": 99456268,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 239.642,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.11621621621622,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage: 🟡 60.1% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3122 passed, 0 failed · 5 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 74261cf6eb5c2a77703ff643559e81946c26745d
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (240)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.59 #22589 +/- ##
=============================================
Coverage ? 87.21%
=============================================
Files ? 3034
Lines ? 159216
Branches ? 42491
=============================================
Hits ? 138863
Misses ? 19673
Partials ? 680
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Approving backport.
Backport of #22409 to
cloud/1.59.Manual: the automatic cherry-pick conflicted in
sentryBeforeSend.ts.cloud/1.59does not have the stale-chunk and non-first-party origin taggers thatmainhas, so the newtagSentryEvaluatedCommandCallerwrapsaddVueDirectiveDiagnosticsdirectly. The two new files are unchanged frommain. Same change as thecore/1.59backport.Local check:
vitest runon thesentryEvaluatedCommandCaller,sentryBeforeSendandthirdPartyErrorNoisetests: 28 passed.