Repository navigation
test(telemetry): pin the direct-caller rule for evaluated command callers - #22586
Conversation
…lers A bundled caller that was itself invoked from evaluated code must keep paging. Adding the evaluated ancestor frame to the existing bundled-caller row makes a scan-any-frame implementation fail, while the current direct-caller lookup passes. Follow-up to review on #22409 (r4429236547).
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 070eb3eaed1a0f476a1cc009ff28b1c34a4282bd
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (338)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update caller stack test src/platform/telemetry/sentryEvaluatedCommandCaller.test.ts |
The test name and caller stack now cover a bundled caller invoked from evaluated code. The test still expects the event to be kept. |
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other
Suggested reviewers: anupreet-comfy
Merge Risk: 
Minimal · up to 2ffa1
-
This focused test-only change is ready to merge.
Pre-merge checks: 
6
-
Full details: Description check
-
Explanation
The description includes the required Summary and Verification sections. It explains the behavior, identifies the test-only scope, reports test results and mutation-check results, and notes the absence of a backport.
Full details: End-To-End Test Suggestion For User-Facing Changes
-
Explanation
The PR changes only
src/platform/telemetry/sentryEvaluatedCommandCaller.test.tsand adds a test case. It does not fix a bug or add/change a user-facing feature in the main frontend application. The check therefore passes.
Full details: Adr Compliance For Entity/Litegraph Changes
-
Explanation
The changed-file list identifies only
src/platform/telemetry/sentryEvaluatedCommandCaller.test.ts. It does not modifysrc/lib/litegraph/,src/ecs/, or a graph-entity-related file, so this check does not apply.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #22586 +/- ##
==========================================
- Coverage 87.58% 87.48% -0.10%
==========================================
Files 2995 2887 -108
Lines 162839 159463 -3376
Branches 43523 40323 -3200
==========================================
- Hits 142618 139513 -3105
+ Misses 19289 19186 -103
+ Partials 932 764 -168
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
✅ No high-signal findings.
Panel: 6/6 reviewers contributed findings.
dante01yoon
left a comment
There was a problem hiding this comment.
Test-only change; verified by tracing: Sentry frames are oldest-first, so frames.at(-(COMMAND_STORE_FRAME_DEPTH + 1)) resolves to the bundled onclick frame, not the older <anonymous>:1:38 frame added below it. The row now distinguishes "direct caller is evaluated" from "any evaluated frame exists", which matches the mutation check in the description. No blockers.
Summary
Test-only follow-up to #22409, from the review comment #22409 (comment).
A bundled handler that was itself invoked by page-evaluated code must still page. The existing "bundled caller" row now has an older
<anonymous>:1:38frame below the bundled caller.Verification
vitest run src/platform/telemetry/sentryEvaluatedCommandCaller.test.ts: 8 passed on this branch.No production code change, so no backport.