Skip to content

test(telemetry): pin the direct-caller rule for evaluated command callers - #22586

Merged
christian-byrne merged 1 commit into
mainfrom
test/sentry-evaluated-ancestor
Nov 1, 2026
Merged

christian-byrne merged 1 commit into
mainfrom
test/sentry-evaluated-ancestor

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Test-only follow-up to #22409, from the review comment #22409 (comment).

A bundled handler that was itself invoked by page-evaluated code must still page. The existing "bundled caller" row now has an older <anonymous>:1:38 frame below the bundled caller.

Verification

  • vitest run src/platform/telemetry/sentryEvaluatedCommandCaller.test.ts: 8 passed on this branch.
  • Mutation check: replacing the fixed caller lookup with a scan for any evaluated frame makes this row fail (1 failed, 7 passed). Before this change that mutant passed all 8 cases.

No production code change, so no backport.

…lers

A bundled caller that was itself invoked from evaluated code must keep
paging. Adding the evaluated ancestor frame to the existing bundled-caller
row makes a scan-any-frame implementation fail, while the current
direct-caller lookup passes.

Follow-up to review on #22409 (r4429236547).
@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 11/01/2026, 10:18:28 AM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 070eb3eaed1a0f476a1cc009ff28b1c34a4282bd

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (338)

  • billing path matches no source files: src/platform/billing/composables/activateBillingScope.testUtils.ts. Remove or update it in docs/architecture/domains/records/billing.domain.json.
  • error-handling path matches no source files: src/utils/errorUtil.ts. Remove or update it in docs/architecture/domains/records/error-handling.domain.json.
  • graph-model path matches no source files: src/types/linkTopology.ts. Remove or update it in docs/architecture/domains/records/graph-model.domain.json.
  • graph-model path matches no source files: src/types/nodeState.ts. Remove or update it in docs/architecture/domains/records/graph-model.domain.json.
  • job-queue path matches no source files: src/platform/remote/comfyui/jobs/**. Remove or update it in docs/architecture/domains/records/job-queue.domain.json.
  • linear-mode path matches no source files: src/utils/appMode.ts. Remove or update it in docs/architecture/domains/records/linear-mode.domain.json.
  • link-connection path matches no source files: src/lib/litegraph/src/infrastructure/LinkConnectorEventMap.ts. Remove or update it in docs/architecture/domains/records/link-connection.domain.json.
  • node-widgets path matches no source files: src/types/widgetState.ts. Remove or update it in docs/architecture/domains/records/node-widgets.domain.json.
  • subgraphs path matches no source files: src/lib/litegraph/src/infrastructure/SubgraphEventMap.ts. Remove or update it in docs/architecture/domains/records/subgraphs.domain.json.
  • vue-node-widgets path matches no source files: src/types/positionConfig.ts. Remove or update it in docs/architecture/domains/records/vue-node-widgets.domain.json.
  • workspace path matches no source files: src/platform/workspace/fixtures/**. Remove or update it in docs/architecture/domains/records/workspace.domain.json.
  • packages/api-client/src/abortSignal.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/abortSignal.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchRouteTemplate.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchWithRetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchWithRetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/retryPolicy.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/retryPolicy.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/statusRetryTelemetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/statusRetryTelemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/formatUtil.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/formatUtil.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/geometry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/loadExternalScript.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/networkUtil.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/telemetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/telemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/urlSafety.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/urlSafety.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/tailwind-utils/src/index.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/TopbarActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatClipStrip.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatClipTile.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPanel.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPanel.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPlaybackBar.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/WidgetVideoConcat.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/WidgetVideoConcat.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/__fixtures__/clipTiles.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionActions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionActions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionNotices.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionNotices.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentSidebarTabs.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 288 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 070eb3e and 2ffa135.

Files selected for processing: 1
  • src/platform/telemetry/sentryEvaluatedCommandCaller.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

Walkthrough

The paging test for a bundled caller now includes an anonymous evaluated-code frame after the caller frame. The test name identifies this scenario, and the test still expects the event to be kept.

Changes: Telemetry paging test

Layer / File(s) Summary
Update caller stack test
src/platform/telemetry/sentryEvaluatedCommandCaller.test.ts
The test name and caller stack now cover a bundled caller invoked from evaluated code. The test still expects the event to be kept.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: anupreet-comfy

Merge Risk: Minimal · up to 2ffa1

This focused test-only change is ready to merge.

Pre-merge checks: Passed 6
Check name Status Explanation
Title check Passed The title clearly identifies the test-only telemetry change and the direct-caller rule being pinned.
Description check Passed The description includes the required Summary and Verification sections. It explains the behavior, identifies the test-only scope, reports test results and mutation-check results, and notes the absenc…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
End-To-End Test Suggestion For User-Facing Changes Passed The PR changes only src/platform/telemetry/sentryEvaluatedCommandCaller.test.ts and adds a test case. It does not fix a bug or add/change a user-facing feature in the main frontend application. The …
Adr Compliance For Entity/Litegraph Changes Passed The changed-file list identifies only src/platform/telemetry/sentryEvaluatedCommandCaller.test.ts. It does not modify src/lib/litegraph/, src/ecs/, or a graph-entity-related file, so this check …
Full details: Description check

Explanation

The description includes the required Summary and Verification sections. It explains the behavior, identifies the test-only scope, reports test results and mutation-check results, and notes the absence of a backport.

Full details: End-To-End Test Suggestion For User-Facing Changes

Explanation

The PR changes only src/platform/telemetry/sentryEvaluatedCommandCaller.test.ts and adds a test case. It does not fix a bug or add/change a user-facing feature in the main frontend application. The check therefore passes.

Full details: Adr Compliance For Entity/Litegraph Changes

Explanation

The changed-file list identifies only src/platform/telemetry/sentryEvaluatedCommandCaller.test.ts. It does not modify src/lib/litegraph/, src/ecs/, or a graph-entity-related file, so this check does not apply.

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@codecov

codecov Bot commented Nov 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #22586      +/-   ##
==========================================
- Coverage   87.58%   87.48%   -0.10%     
==========================================
  Files        2995     2887     -108     
  Lines      162839   159463    -3376     
  Branches    43523    40323    -3200     
==========================================
- Hits       142618   139513    -3105     
+ Misses      19289    19186     -103     
+ Partials      932      764     -168     
Flag Coverage Δ
billing-web-unit ?
unit 86.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 108 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:medium PR risk grade (advisory shadow check; grader-owned) label Nov 1, 2026
@christian-byrne christian-byrne added the cursor-review Trigger multi-model Cursor agent review on this PR label Nov 1, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

✅ No high-signal findings.

Panel: 6/6 reviewers contributed findings.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test-only change; verified by tracing: Sentry frames are oldest-first, so frames.at(-(COMMAND_STORE_FRAME_DEPTH + 1)) resolves to the bundled onclick frame, not the older <anonymous>:1:38 frame added below it. The row now distinguishes "direct caller is evaluated" from "any evaluated frame exists", which matches the mutation check in the description. No blockers.

@christian-byrne
christian-byrne added this pull request to the merge queue Nov 1, 2026
Merged via the queue into main with commit 338941a Nov 1, 2026
121 checks passed
@christian-byrne
christian-byrne deleted the test/sentry-evaluated-ancestor branch November 1, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor agent review on this PR risk:medium PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants