Repository navigation
[backport cloud/1.58] fix: stop reactive proxies from breaking workflow loads (DataCloneError) - #22585
Conversation
…or) (#20747) *PR Created by the Glary-Bot Agent* --- ## Summary Fixes the prod error `DataCloneError: Proxy object could not be cloned` on `cloud-frontend-prod`. Chrome reports it as `#<Object> could not be cloned`, Safari as `The object can not be cloned`. Datadog RUM shows 116 errors across 70 sessions in 30 days, still happening on cloud/v1.56.3. Workflows fail to open from templates, file open or drop, startup restore, and shared links. This is the third round of the same bug: code keeps moving from a JSON copy to `structuredClone` on data that is not actually plain. This PR removes the crash site, fixes both sources of proxies, and adds a regression test for each earlier occurrence. ## Root cause A strict `structuredClone` ran on `graph.serialize()` output, and that output can still contain JS proxies: - `createNewWorkflow` (`workflowStore.ts`) cloned `rootGraph.serialize()` on every load. - `serialize()` copies `extra` only one level deep and runs extension `onSerialize` hooks on the output object. ## Timeline | When | Change | Effect | |---|---|---| | Jul 2025 | [litegraph.js#1158](Comfy-Org/litegraph.js#1158) / [#4696](#4696) propose `structuredClone` for `LiteGraph.cloneObject()` | Review blocked it: *"you cannot simply drop this in… It will break custom nodes."* Still open; `cloneObject` is still a JSON copy. | | Feb 2026 | #8898 (`3d88d0a6ab`) | First in-tree proxy fix: widget values are JSON-copied in `LGraphNode.serialize`. | | Mar 2026 | #9338 (`68b16e3a3f`) | App Builder writes `extra.linearData = { inputs: [...data.inputs] }`. The shallow spread leaks reactive tuples into the graph. | | Aug 19 2026 | #11631 (`fb030dcdb8`), first in **cloud/v1.52.4** | `createNewWorkflow` switches from a JSON copy to `structuredClone`. **This creates the crash site.** | | Aug 24 2026 | ECS migration #14246 (`a8abe573c0`), first in **cloud/v1.53.4** | `NodeState` is now registered with `reactive()`, so `node.properties` is a deep reactive proxy. | | Sep 20 2026 | #18165 ("1.52.7 fine, 1.53.6 broken") | CRT Nodes "Fancy Timer" does `onSerialize(o) { o.properties = this.properties }` → `DataCloneError`. | | Sep 22 2026 | #18252 (`8ff5db2f1e`, Sentry FRONTEND-51) | Fixes extension-only fields. `properties` is a canonical field, so #18165 still crashed at `createNewWorkflow`. | ## Changes The history alternates red and green: each failing test commit comes before its fix. **Crash site (`workflowStore.ts`).** `createNewWorkflow` no longer deep-copies. `ensureWorkflowId` doesn't mutate its argument and the result is only passed to `JSON.stringify`, so the stored bytes are unchanged and nothing is left to clone (`e9f23ce`). **Source 1: App Builder (`appModeStore.ts`).** `linearData` is written as new typed tuples, and each config gets a JSON copy. A missing config is omitted rather than written as `null`, so the value matches the `zLinearInput` schema. End-to-end reorder, save and reopen is already covered by `browser_tests/tests/builderReorder.spec.ts:125-147`. The unit tests cover proxy depth and the omitted config. **Source 2: serialize hooks (`extensionPersistence.ts → runExtensionSerializeHook`).** This only runs when a hook exists; nodes and graphs without hooks are untouched. After the hook runs, each canonical field is checked with `structuredClone`, whether the hook replaced it or edited it in place: - **A cloneable value is kept exactly as the hook left it.** That matches main: `Date`, `Map`, typed arrays and class instances keep their in-memory types, and `toJSON` still runs at save time. - **A value that can't be cloned is JSON-detached.** In practice that means a live reactive proxy or a geometry view. Live geometry views (`pos`/`size`, proxies over typed arrays) become `[x, y]`. Real typed arrays keep main's `{"0":…}` JSON. - **If JSON detachment also fails** (a cycle, BigInt, or a throwing getter or `toJSON`), the value is kept and a warning is logged, so the save fails loudly as it did on main instead of writing a workflow without that field. **Regression guards.** Each new test fails on base and passes here. - `extensionPersistence.test.ts` covers: - #18165, both the whole-field and the nested in-place variants, for node and graph hooks; - later live edits not leaking into a serialized node; - geometry views, flat, nested and in place; - #8898 reactive widget values; - cloneable replaced values staying intact, including `toJSON`; - an untouched field keeping full fidelity; - a typed array keeping its saved shape next to a proxy; - an undetachable value kept so the save fails. - `LiteGraphGlobal.cloneObject.test.ts` pins `cloneObject`'s proxy tolerance, so repeating #1158 now fails a test. - `browser_tests/tests/legacyDoNotReplicate/legacyLiveSerializedProperties.spec.ts` (from #21504) opens a workflow containing a devtools node that reproduces the Fancy Timer hook. Before the fix the load fails with `Failed to parse workflow: DataCloneError` and no tab opens. ## For reviewers - **JSON vs `structuredClone` policy:** JSON is used only for values `structuredClone` rejects, which in practice means live proxies. Everything else is left as the hook wrote it, so saved JSON and in-memory types match main. - **Custom-node risk (#1158):** this PR moves away from it. Hook-provided values are still honoured; only live proxies are replaced with copies. - **Performance** (1,000 nodes, mean of 20 `graph.serialize()` calls in Vitest, two runs each): | Case | main | this branch | |---|---|---| | No hooks | 14–15 ms | 15 ms (unchanged) | | Graph `onSerialize` | 12–14 ms | 17 ms | | Graph hook + a hook on every node | 19.5 ms | 34–35 ms | - The cost is the per-field `structuredClone` check. For a graph hook, that clones `nodes` and `definitions` once per serialize. - Skipping those fields is not safe, because a hook can push a live proxy into an existing container. - No code in this repo registers `onSerialize`, so only custom-node packs that install hooks pay this. - On main, the hooked-node case was not usable either: it produced the proxy output that crashed on load. - **Known limits:** - A raw (non-proxy) object a hook assigns still aliases live state, as on main. - Other strict clones still exist (`structuredClone(extra)` in `LGraph.configure`, `workflowToClipboardItems`, `subgraphStore.getBlueprint`). Both proxy sources are now fixed before data reaches them. - **Commit history:** red/green is intentional. Squash-merge, or keep the history as is; please don't squash red into green. ## Verification - **Unit tests** under `src/lib/litegraph`, `src/platform/workflow`, `src/stores` and `src/scripts`: 314 files, 5463 passed. Pre-commit (oxfmt, oxlint, `typecheck:app`) passed on every commit. - **E2E:** the `legacyDoNotReplicate` folder and `builderReorder.spec.ts` passed (47 tests) with `scripts/test-browser-offline.sh --project=chromium` against a dist built from this head. The new Fancy Timer spec fails against a dist built with the fix reverted. - **Live dev app (Playwright):** select and reorder in builder mode, then run `structuredClone(rootGraph.serialize())` and `createNewTemporary(…)`. Both threw `DataCloneError` before the fix and succeed after. --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-01T10:17:20.226Z",
"gitSha": "6d8755f81ab50859168a9f730738f01ca32a8e59",
"branch": "backport-20747-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2037.7149999999915,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.773,
"layouts": 9,
"layoutDurationMs": 2.94,
"taskDurationMs": 429.971,
"heapDeltaBytes": 1823496,
"heapUsedBytes": 89828944,
"domNodes": -200,
"jsHeapTotalBytes": -2555904,
"scriptDurationMs": 8.965999999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.0600000000004,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.5879999999999996,
"layouts": 9,
"layoutDurationMs": 2.806,
"taskDurationMs": 373.618,
"heapDeltaBytes": -359712,
"heapUsedBytes": 91023360,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 9.439,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1794.5669999999723,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.850999999999999,
"layouts": 9,
"layoutDurationMs": 2.465,
"taskDurationMs": 801.4839999999999,
"heapDeltaBytes": 818696,
"heapUsedBytes": 89676624,
"domNodes": -200,
"jsHeapTotalBytes": 589824,
"scriptDurationMs": 166.729,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740738,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1710.4620000000068,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.466,
"layouts": 9,
"layoutDurationMs": 2.695,
"taskDurationMs": 747.4639999999999,
"heapDeltaBytes": 18747304,
"heapUsedBytes": 110654708,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 160.802,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262138,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.2840000000297,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.289999999999999,
"layouts": 11,
"layoutDurationMs": 2.5439999999999996,
"taskDurationMs": 399.29100000000005,
"heapDeltaBytes": 21565992,
"heapUsedBytes": 109512692,
"domNodes": 47,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 10.398000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1718.099000000052,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.796999999999999,
"layouts": 10,
"layoutDurationMs": 2.4139999999999997,
"taskDurationMs": 402.93300000000005,
"heapDeltaBytes": 21442432,
"heapUsedBytes": 112861460,
"domNodes": 47,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 11.068000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 631.6980000000285,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.1260000000000003,
"layouts": 10,
"layoutDurationMs": 2.6519999999999997,
"taskDurationMs": 450.923,
"heapDeltaBytes": 249616,
"heapUsedBytes": 88115708,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 177.001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66486486486485,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 611.1460000000761,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.0170000000000003,
"layouts": 9,
"layoutDurationMs": 2.6319999999999997,
"taskDurationMs": 445.83700000000005,
"heapDeltaBytes": 3311812,
"heapUsedBytes": 92344776,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 171.19899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1214.6079999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 856.437,
"heapDeltaBytes": -13937484,
"heapUsedBytes": 102661676,
"domNodes": -230,
"jsHeapTotalBytes": 15540224,
"scriptDurationMs": 70.56499999999998,
"eventListeners": -168,
"totalBlockingTimeMs": 523,
"frameDurationMs": 32.88108108108109,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1212.225999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 911.3919999999999,
"heapDeltaBytes": -15531064,
"heapUsedBytes": 102725428,
"domNodes": -210,
"jsHeapTotalBytes": 15880192,
"scriptDurationMs": 65.39000000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 526,
"frameDurationMs": 32.881081081081064,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.2250000000276,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.49699999999973,
"heapDeltaBytes": -3909316,
"heapUsedBytes": 97815368,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 157.819,
"eventListeners": 0,
"totalBlockingTimeMs": 217,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.7260000000133,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.57199999999966,
"heapDeltaBytes": -3669604,
"heapUsedBytes": 98341228,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 154.962,
"eventListeners": 0,
"totalBlockingTimeMs": 224,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10875.630000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9993.434000000001,
"heapDeltaBytes": 117308808,
"heapUsedBytes": 224019756,
"domNodes": -276,
"jsHeapTotalBytes": 101330944,
"scriptDurationMs": 8040.089999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 1113,
"frameDurationMs": 31.91436950146628,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10841.383000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10084.009999999998,
"heapDeltaBytes": 128907956,
"heapUsedBytes": 234986272,
"domNodes": -276,
"jsHeapTotalBytes": 116011008,
"scriptDurationMs": 8348.776000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 1342,
"frameDurationMs": 31.955162241887905,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10938.717000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10101.749,
"heapDeltaBytes": 34044904,
"heapUsedBytes": 155110740,
"domNodes": -296,
"jsHeapTotalBytes": 40079360,
"scriptDurationMs": 8104.875,
"eventListeners": -130,
"totalBlockingTimeMs": 970,
"frameDurationMs": 31.236857142857144,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10385.264000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9639.410999999998,
"heapDeltaBytes": 20023136,
"heapUsedBytes": 141596896,
"domNodes": -296,
"jsHeapTotalBytes": 33357824,
"scriptDurationMs": 7637.92,
"eventListeners": -130,
"totalBlockingTimeMs": 899,
"frameDurationMs": 30.809792284866468,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 259.70399999999927,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.683,
"layouts": 11,
"layoutDurationMs": 3.6439999999999997,
"taskDurationMs": 209.62400000000002,
"heapDeltaBytes": 15460884,
"heapUsedBytes": 118076996,
"domNodes": 917,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 8.809999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 6,
"frameDurationMs": 24.23636363636359,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 257.7479999999923,
"styleRecalcs": 26,
"styleRecalcDurationMs": 13.992999999999999,
"layouts": 12,
"layoutDurationMs": 3.6229999999999998,
"taskDurationMs": 198.97,
"heapDeltaBytes": 15468160,
"heapUsedBytes": 118140864,
"domNodes": 917,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 9.919999999999998,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.507692307692334,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2078.7179999999807,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.3049999999999997,
"layouts": 6,
"layoutDurationMs": 2.1010000000000004,
"taskDurationMs": 703.647,
"heapDeltaBytes": -14850996,
"heapUsedBytes": 90712504,
"domNodes": -296,
"jsHeapTotalBytes": -2215936,
"scriptDurationMs": 38.98500000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665599999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2041.8769999999995,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2310000000000003,
"layouts": 8,
"layoutDurationMs": 2.3719999999999994,
"taskDurationMs": 480.55400000000014,
"heapDeltaBytes": 501948,
"heapUsedBytes": 102065232,
"domNodes": -296,
"jsHeapTotalBytes": -1769472,
"scriptDurationMs": 32.283,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2635.304000000019,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.424000000000001,
"layouts": 7,
"layoutDurationMs": 1.9579999999999997,
"taskDurationMs": 1783.5390000000002,
"heapDeltaBytes": 3284324,
"heapUsedBytes": 106257952,
"domNodes": -296,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 871.7040000000001,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665822784810125,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2230.1230000000487,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.532,
"layouts": 8,
"layoutDurationMs": 1.77,
"taskDurationMs": 1504.0379999999998,
"heapDeltaBytes": -2753944,
"heapUsedBytes": 104045144,
"domNodes": -296,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 804.695,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.79172932330827,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3694.447000000025,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.146999999999998,
"layouts": 63,
"layoutDurationMs": 10.161,
"taskDurationMs": 1797.2640000000001,
"heapDeltaBytes": -4478588,
"heapUsedBytes": 95771360,
"domNodes": -272,
"jsHeapTotalBytes": -2134016,
"scriptDurationMs": 777.378,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66561085972851,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3462.474000000043,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.083,
"layouts": 64,
"layoutDurationMs": 9.747,
"taskDurationMs": 1592.052,
"heapDeltaBytes": 5072020,
"heapUsedBytes": 109547564,
"domNodes": -272,
"jsHeapTotalBytes": -2162688,
"scriptDurationMs": 752.844,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.747087378640774,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2995.7639999999515,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.890999999999999,
"layouts": 3,
"layoutDurationMs": 0.9940000000000005,
"taskDurationMs": 1967.563,
"heapDeltaBytes": 20354904,
"heapUsedBytes": 126298084,
"domNodes": 0,
"jsHeapTotalBytes": 6189056,
"scriptDurationMs": 954.9430000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.759550561797752,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2675.4499999999553,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.385999999999999,
"layouts": 6,
"layoutDurationMs": 1.4799999999999995,
"taskDurationMs": 1718.234,
"heapDeltaBytes": 18830360,
"heapUsedBytes": 128455656,
"domNodes": 0,
"jsHeapTotalBytes": 8024064,
"scriptDurationMs": 940.299,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.770624999999995,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2028.7999999999897,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.099,
"layouts": 7,
"layoutDurationMs": 2.198,
"taskDurationMs": 481.91499999999996,
"heapDeltaBytes": 354600,
"heapUsedBytes": 102893200,
"domNodes": -296,
"jsHeapTotalBytes": -2555904,
"scriptDurationMs": 32.410999999999994,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.3999999999387,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.654,
"layouts": 8,
"layoutDurationMs": 2.5979999999999994,
"taskDurationMs": 498.93299999999994,
"heapDeltaBytes": -18236052,
"heapUsedBytes": 92322020,
"domNodes": -296,
"jsHeapTotalBytes": -1691648,
"scriptDurationMs": 32.19400000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 544.5179999999823,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.919999999999999,
"layouts": 8,
"layoutDurationMs": 2.4440000000000004,
"taskDurationMs": 383.84999999999997,
"heapDeltaBytes": 22385576,
"heapUsedBytes": 114906544,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 147.467,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 533.0639999999676,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.485,
"layouts": 8,
"layoutDurationMs": 2.1710000000000003,
"taskDurationMs": 371.966,
"heapDeltaBytes": 24726808,
"heapUsedBytes": 114780036,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 143.067,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2054.5419999999694,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.1800000000000006,
"layouts": 9,
"layoutDurationMs": 2.757,
"taskDurationMs": 597.3009999999999,
"heapDeltaBytes": 1284792,
"heapUsedBytes": 91151828,
"domNodes": -218,
"jsHeapTotalBytes": -3342336,
"scriptDurationMs": 8.508999999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2025.6429999999455,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5329999999999995,
"layouts": 9,
"layoutDurationMs": 2.3970000000000002,
"taskDurationMs": 417.24999999999994,
"heapDeltaBytes": 3131548,
"heapUsedBytes": 93061836,
"domNodes": -218,
"jsHeapTotalBytes": -2293760,
"scriptDurationMs": 7.561,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.1709999999653,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.923000000000002,
"layouts": 10,
"layoutDurationMs": 3.0980000000000003,
"taskDurationMs": 782.624,
"heapDeltaBytes": -2727988,
"heapUsedBytes": 87638088,
"domNodes": -210,
"jsHeapTotalBytes": -1769472,
"scriptDurationMs": 115.43399999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1757.8010000000859,
"styleRecalcs": 78,
"styleRecalcDurationMs": 13.657,
"layouts": 10,
"layoutDurationMs": 2.4619999999999997,
"taskDurationMs": 881.071,
"heapDeltaBytes": -2458948,
"heapUsedBytes": 86970608,
"domNodes": -190,
"jsHeapTotalBytes": 1900544,
"scriptDurationMs": 109.90799999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1471.2329999999838,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.918000000000003,
"layouts": 5,
"layoutDurationMs": 14.31,
"taskDurationMs": 1139.693,
"heapDeltaBytes": 11705232,
"heapUsedBytes": 140382756,
"domNodes": 16030,
"jsHeapTotalBytes": 13246464,
"scriptDurationMs": 32.169000000000004,
"eventListeners": 3244,
"totalBlockingTimeMs": 151,
"frameDurationMs": 19.51578947368422,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9545.304999999986,
"styleRecalcs": 248,
"styleRecalcDurationMs": 27.873,
"layouts": 6,
"layoutDurationMs": 1.81,
"taskDurationMs": 5932.953,
"heapDeltaBytes": 4306580,
"heapUsedBytes": 107935396,
"domNodes": -296,
"jsHeapTotalBytes": -1761280,
"scriptDurationMs": 2635.64,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.695104895104897,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8478.679000000056,
"styleRecalcs": 249,
"styleRecalcDurationMs": 28.474,
"layouts": 7,
"layoutDurationMs": 2.117,
"taskDurationMs": 5561.986,
"heapDeltaBytes": 4427208,
"heapUsedBytes": 112524112,
"domNodes": -296,
"jsHeapTotalBytes": 73728,
"scriptDurationMs": 2980.331,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699015748031496,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16316.35799999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15239.113,
"heapDeltaBytes": -30867068,
"heapUsedBytes": 288302540,
"domNodes": -3344,
"jsHeapTotalBytes": 17551360,
"scriptDurationMs": 254.20899999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.938356164383563,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 15448.522000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14745.159999999998,
"heapDeltaBytes": -21522892,
"heapUsedBytes": 303475200,
"domNodes": -3344,
"jsHeapTotalBytes": -5517312,
"scriptDurationMs": 225.97400000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.22988115449915,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 19007.641999999974,
"styleRecalcs": 146,
"styleRecalcDurationMs": 14.206999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18636.336,
"heapDeltaBytes": -4897672,
"heapUsedBytes": 306331924,
"domNodes": -3344,
"jsHeapTotalBytes": 11190272,
"scriptDurationMs": 801.368,
"eventListeners": -651,
"totalBlockingTimeMs": 8,
"frameDurationMs": 35.183703703703706,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 28288.069000000065,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.69800000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27874.691,
"heapDeltaBytes": 286594544,
"heapUsedBytes": 661275416,
"domNodes": -3344,
"jsHeapTotalBytes": 302956544,
"scriptDurationMs": 911.144,
"eventListeners": -651,
"totalBlockingTimeMs": 11,
"frameDurationMs": 51.79890109890109,
"p95FrameDurationMs": 100.10000000000582
},
{
"name": "vue-node-resize-workload",
"durationMs": 6004.714000000035,
"styleRecalcs": 20,
"styleRecalcDurationMs": 65.98900000000002,
"layouts": 20,
"layoutDurationMs": 23.621000000000016,
"taskDurationMs": 5876.119999999999,
"heapDeltaBytes": -48151444,
"heapUsedBytes": 262163164,
"domNodes": -3344,
"jsHeapTotalBytes": 7589888,
"scriptDurationMs": 98.793,
"eventListeners": -653,
"totalBlockingTimeMs": 22,
"frameDurationMs": 35.08654970760234,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8275.236999999946,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.306,
"layouts": 20,
"layoutDurationMs": 36.164,
"taskDurationMs": 8139.81,
"heapDeltaBytes": -35407196,
"heapUsedBytes": 274972608,
"domNodes": -3344,
"jsHeapTotalBytes": 10997760,
"scriptDurationMs": 124.5,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.508045977011506,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11403.93899999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11115.24,
"heapDeltaBytes": 4524152,
"heapUsedBytes": 294689940,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 159.25900000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.44498269896193,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8121.603999999934,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7557.169,
"heapDeltaBytes": 4658136,
"heapUsedBytes": 267091348,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 122.14500000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.758020477815705,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 471.24900000000025,
"styleRecalcs": 21,
"styleRecalcDurationMs": 10.937,
"layouts": 14,
"layoutDurationMs": 4.907,
"taskDurationMs": 145.567,
"heapDeltaBytes": -18415496,
"heapUsedBytes": 91426880,
"domNodes": 126,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 18.409000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 132.59600000003502,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.142999999999999,
"layouts": 9,
"layoutDurationMs": 4.082000000000001,
"taskDurationMs": 88.498,
"heapDeltaBytes": 4625196,
"heapUsedBytes": 95454356,
"domNodes": 116,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.197,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 499.14300000000367,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.69,
"layouts": 76,
"layoutDurationMs": 17.180999999999997,
"taskDurationMs": 448.829,
"heapDeltaBytes": -13999216,
"heapUsedBytes": 81504304,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 212.641,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 469.26300000006904,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.647,
"layouts": 76,
"layoutDurationMs": 14.966999999999999,
"taskDurationMs": 421.65400000000005,
"heapDeltaBytes": -14301840,
"heapUsedBytes": 82077912,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 203.453,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 522.4759999999833,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.225,
"layouts": 76,
"layoutDurationMs": 13.268,
"taskDurationMs": 482.70000000000005,
"heapDeltaBytes": 415236,
"heapUsedBytes": 117493500,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 191.377,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.203225806451588,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 635.8350000000428,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.75,
"layouts": 76,
"layoutDurationMs": 14.659,
"taskDurationMs": 593.6819999999999,
"heapDeltaBytes": 1424600,
"heapUsedBytes": 119116444,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 253.38099999999997,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage: 🟡 63.6% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2992 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since acf829d847d493d5651bb4dcdb1c7c36ba44ab9e
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (143)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.58 #22585 +/- ##
=============================================
Coverage ? 84.24%
=============================================
Files ? 3172
Lines ? 165569
Branches ? 41561
=============================================
Hits ? 139488
Misses ? 25689
Partials ? 392
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Approving backport.
Backport of #20747 to
cloud/1.58Automatically created by backport workflow.