Repository navigation
[backport cloud/1.59] fix: do not mark unedited saved workflows unsaved after a reload - #22579
Conversation
) ## Summary Unedited saved workflows opened marked unsaved after a reload: the unsaved dot showed, the page title started with `*`, closing the tab asked to save, and reloading showed the browser's "Leave site?" prompt. Root cause: switching tabs writes a draft for the outgoing workflow even when it is unedited (`beforeLoadNewGraph` → `persistActiveWorkflowDraft`). After a reload, `ComfyWorkflow.load()` overlays that draft and set `isModified = true` whenever a draft existed, although the draft equals the saved file. Fix: when a draft is overlaid, mark the workflow modified only if the draft graph differs from the saved file, using the change tracker's existing `graphEqual` (which ignores the viewport). The draft is still overlaid, so a saved viewport is kept. This also clears the mark for drafts users already have in browser storage. The comparison is reached through the injected `WorkflowRuntime`, so the workflow model still does not import the change tracker. Not changed: tab switches still write drafts for unedited workflows. Skipping that write would conflict with #21440, which stores each tab's viewport in its draft. Linear: FRONT-3766. Reported in QA on testcloud cloud/1.59; it reproduces on cloud/1.58 too, so it is not a 1.59 regression. ## Verification - Red first, on CI: test-only head `ab1ed65e3d` failed both new `workflowStore.test.ts` cases (draft equal to the file; draft differing only by viewport) with `expected true to be false` (unit shard 4), and the new browser test failed at the restored-tab `isModified` check in chromium shard 16 (https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/41281652340/job/124775157225). The fix commit follows. - More unit cases: a draft that only changes app mode (`extra.linearMode`) stays marked modified. A draft or saved file with no `nodes` array stays marked modified and no longer throws; this case was red with a TypeError before the guard. - New browser test `Unedited saved workflows reopen as saved after a reload` in `workflowPersistence.spec.ts` follows the reported steps: save three workflows, visit each tab, reload, reopen the first two, and assert no unsaved mark and no `*` title. It also checks the tab that was active at the reload. - `vitest run src/platform/workflow src/scripts/changeTracker`: 125 files, 2423 passed. - `pnpm typecheck`, `pnpm typecheck:browser`, oxfmt, oxlint. ## Review notes An independent adversarial review (fresh Claude reviewer; cross-model was unavailable) raised: - comments in the changed function and tests: removed (repo rule). - `graphEqual` might treat swapped `widgets_values` as equal: checked, it does not. Only the top-level node array is compared unordered; arrays inside a node are compared in order. - a restored draft becomes the tracker's baseline in `activateLoadedWorkflow`, so editing and then reverting on a tab that had real draft edits can clear its unsaved mark. That is existing behaviour, not changed here; it is followed up separately. Known limits, followed up separately: a file that changes when it is loaded and serialized again (older frontend, external tool) can still reopen as modified. A viewport-only draft is restored once, then dropped like any unmodified draft (see #21440).
dante01yoon
left a comment
There was a problem hiding this comment.
Backport of #22571; file set matches the merged original. LGTM.
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 8 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-01T08:49:49.451Z",
"gitSha": "83ba856b7e88c28d792eb79237cddc4fd37b77b9",
"branch": "backport-22571-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2013.2040000000018,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.334,
"layouts": 10,
"layoutDurationMs": 2.77,
"taskDurationMs": 435.421,
"heapDeltaBytes": 24405584,
"heapUsedBytes": 85169480,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 11.967,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2009.078000000045,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.279,
"layouts": 10,
"layoutDurationMs": 2.757,
"taskDurationMs": 387.856,
"heapDeltaBytes": 5186628,
"heapUsedBytes": 75199260,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 9.86,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1677.4519999999882,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.872000000000002,
"layouts": 10,
"layoutDurationMs": 2.618,
"taskDurationMs": 661.3059999999999,
"heapDeltaBytes": 18136992,
"heapUsedBytes": 86708952,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 120.874,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664356435643562,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.8550000000182,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.396,
"layouts": 9,
"layoutDurationMs": 2.4499999999999997,
"taskDurationMs": 621.408,
"heapDeltaBytes": 21840048,
"heapUsedBytes": 83796988,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 114.499,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.962999999983,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.0440000000000005,
"layouts": 11,
"layoutDurationMs": 3.1820000000000004,
"taskDurationMs": 307.891,
"heapDeltaBytes": -389896,
"heapUsedBytes": 61640412,
"domNodes": 56,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 12.754,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.0580000000232,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.486000000000001,
"layouts": 11,
"layoutDurationMs": 3.3240000000000003,
"taskDurationMs": 325.838,
"heapDeltaBytes": 24468056,
"heapUsedBytes": 85869096,
"domNodes": 56,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 14.097,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 543.2119999999827,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.997,
"layouts": 10,
"layoutDurationMs": 2.6130000000000004,
"taskDurationMs": 359.519,
"heapDeltaBytes": 7528448,
"heapUsedBytes": 70334956,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 116.88000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 516.0610000000361,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.9770000000000003,
"layouts": 9,
"layoutDurationMs": 2.349,
"taskDurationMs": 336.18,
"heapDeltaBytes": -1101500,
"heapUsedBytes": 59949652,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 112.47900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 933.3839999999896,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 573.9070000000002,
"heapDeltaBytes": -13885864,
"heapUsedBytes": 75113564,
"domNodes": -191,
"jsHeapTotalBytes": 21766144,
"scriptDurationMs": 36.96000000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 282,
"frameDurationMs": 26.665714285714277,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 919.5229999999697,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 559.97,
"heapDeltaBytes": -11936460,
"heapUsedBytes": 75067456,
"domNodes": -191,
"jsHeapTotalBytes": 21504000,
"scriptDurationMs": 35.278,
"eventListeners": -106,
"totalBlockingTimeMs": 273,
"frameDurationMs": 26.188571428571425,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 703.4810000000107,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 333.12300000000005,
"heapDeltaBytes": -23130192,
"heapUsedBytes": 66195512,
"domNodes": -191,
"jsHeapTotalBytes": 2752512,
"scriptDurationMs": 89.15100000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 87,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 716.24300000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 307.9170000000002,
"heapDeltaBytes": -4484432,
"heapUsedBytes": 69983988,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 98.20800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 96,
"frameDurationMs": 21.079411764705878,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6608.77099999999,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8770000000000002,
"layouts": 3,
"layoutDurationMs": 0.7209999999999999,
"taskDurationMs": 5529.266,
"heapDeltaBytes": 54299920,
"heapUsedBytes": 128914504,
"domNodes": -257,
"jsHeapTotalBytes": 50458624,
"scriptDurationMs": 4100.327,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.295705521472392,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6681.222999999989,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.6500000000000012,
"layouts": 2,
"layoutDurationMs": 0.5279999999999998,
"taskDurationMs": 5662.722,
"heapDeltaBytes": 70736596,
"heapUsedBytes": 143163544,
"domNodes": -257,
"jsHeapTotalBytes": 58060800,
"scriptDurationMs": 4280.278,
"eventListeners": -68,
"totalBlockingTimeMs": 21,
"frameDurationMs": 20.626851851851853,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6568.41700000001,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8830000000000001,
"layouts": 3,
"layoutDurationMs": 0.7949999999999997,
"taskDurationMs": 5533.668,
"heapDeltaBytes": 69097128,
"heapUsedBytes": 143072064,
"domNodes": -257,
"jsHeapTotalBytes": 64614400,
"scriptDurationMs": 4140.713,
"eventListeners": -68,
"totalBlockingTimeMs": 17,
"frameDurationMs": 20.080428134556577,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6544.736000000001,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9070000000000007,
"layouts": 3,
"layoutDurationMs": 0.8099999999999999,
"taskDurationMs": 5747.996999999999,
"heapDeltaBytes": 31258028,
"heapUsedBytes": 125217792,
"domNodes": -257,
"jsHeapTotalBytes": 62779392,
"scriptDurationMs": 4362.19,
"eventListeners": -68,
"totalBlockingTimeMs": 38,
"frameDurationMs": 23.560071942446044,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 157.18100000000845,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.772000000000002,
"layouts": 10,
"layoutDurationMs": 2.5680000000000005,
"taskDurationMs": 110.13400000000001,
"heapDeltaBytes": 14482136,
"heapUsedBytes": 90477768,
"domNodes": 936,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 6.304,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.428571428571427,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 176.65299999998751,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.451,
"layouts": 10,
"layoutDurationMs": 2.827,
"taskDurationMs": 138.918,
"heapDeltaBytes": 14470800,
"heapUsedBytes": 90999680,
"domNodes": 936,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 7.098000000000002,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.36666666666669,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2025.3450000000157,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8509999999999995,
"layouts": 9,
"layoutDurationMs": 2.556,
"taskDurationMs": 491.35900000000004,
"heapDeltaBytes": -27056600,
"heapUsedBytes": 64377684,
"domNodes": -257,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 29.065,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2025.5319999999983,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6830000000000003,
"layouts": 9,
"layoutDurationMs": 2.2550000000000003,
"taskDurationMs": 443.88000000000005,
"heapDeltaBytes": 9750708,
"heapUsedBytes": 82640844,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 30.042,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2929.8880000000054,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.460999999999999,
"layouts": 8,
"layoutDurationMs": 2.0669999999999997,
"taskDurationMs": 1342.809,
"heapDeltaBytes": 739716,
"heapUsedBytes": 76407912,
"domNodes": -257,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 617.686,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2766.5930000000003,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.011,
"layouts": 8,
"layoutDurationMs": 2.043,
"taskDurationMs": 1280.9859999999999,
"heapDeltaBytes": 4879104,
"heapUsedBytes": 81334252,
"domNodes": -257,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 593.546,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666265060240963,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3786.8389999999863,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.424,
"layouts": 67,
"layoutDurationMs": 12.822999999999999,
"taskDurationMs": 1310.0269999999998,
"heapDeltaBytes": 5670492,
"heapUsedBytes": 81481700,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 560.785,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666079295154184,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3655.479000000014,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.923999999999998,
"layouts": 67,
"layoutDurationMs": 12.873,
"taskDurationMs": 1371.861,
"heapDeltaBytes": -7436812,
"heapUsedBytes": 70233864,
"domNodes": -233,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 578.2499999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665753424657535,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2988.0040000000463,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.343,
"layouts": 6,
"layoutDurationMs": 1.5899999999999999,
"taskDurationMs": 1523.759,
"heapDeltaBytes": -8180372,
"heapUsedBytes": 73512532,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 737.765,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6659217877095,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2942.540000000008,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.489000000000001,
"layouts": 8,
"layoutDurationMs": 1.9879999999999998,
"taskDurationMs": 1426.8590000000002,
"heapDeltaBytes": -9587512,
"heapUsedBytes": 73095916,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 701.3679999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66553672316384,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2822.4150000000063,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0010000000000003,
"layouts": 8,
"layoutDurationMs": 1.7910000000000001,
"taskDurationMs": 513.9789999999999,
"heapDeltaBytes": 1496468,
"heapUsedBytes": 78987356,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 236.568,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568047337278,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2872.6499999999646,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4469999999999996,
"layouts": 8,
"layoutDurationMs": 2.073,
"taskDurationMs": 557.1630000000001,
"heapDeltaBytes": 4616840,
"heapUsedBytes": 81250728,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 253.54099999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665697674418606,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2036.9779999999764,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7609999999999997,
"layouts": 9,
"layoutDurationMs": 2.431,
"taskDurationMs": 477.186,
"heapDeltaBytes": -15117880,
"heapUsedBytes": 60346212,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 28.862000000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2036.9589999999675,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7619999999999996,
"layouts": 9,
"layoutDurationMs": 2.339,
"taskDurationMs": 522.2119999999999,
"heapDeltaBytes": -3625140,
"heapUsedBytes": 75969412,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 30.587000000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2711.7149999999983,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.656999999999996,
"layouts": 7,
"layoutDurationMs": 1.7269999999999999,
"taskDurationMs": 465.7700000000001,
"heapDeltaBytes": -11018208,
"heapUsedBytes": 63767132,
"domNodes": -256,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 150.74200000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66625766871166,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2692.0220000000086,
"styleRecalcs": 27,
"styleRecalcDurationMs": 11.210999999999999,
"layouts": 7,
"layoutDurationMs": 1.823,
"taskDurationMs": 435.323,
"heapDeltaBytes": -9455412,
"heapUsedBytes": 68058772,
"domNodes": -255,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 139.305,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666049382716047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 2899.733999999995,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.8720000000000003,
"layouts": 7,
"layoutDurationMs": 1.6749999999999998,
"taskDurationMs": 626.177,
"heapDeltaBytes": -389032,
"heapUsedBytes": 75478176,
"domNodes": -257,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 237.207,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 2925.801999999976,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4270000000000005,
"layouts": 8,
"layoutDurationMs": 2.078,
"taskDurationMs": 657.0480000000001,
"heapDeltaBytes": -4132712,
"heapUsedBytes": 72634176,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 248.34599999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66647727272727,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 496.9609999999989,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.5520000000000005,
"layouts": 9,
"layoutDurationMs": 2.322,
"taskDurationMs": 319.983,
"heapDeltaBytes": -1284256,
"heapUsedBytes": 61515676,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 105.91799999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 525.3809999999817,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.107,
"layouts": 11,
"layoutDurationMs": 2.724,
"taskDurationMs": 329.87500000000006,
"heapDeltaBytes": 22136588,
"heapUsedBytes": 83955756,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 109.405,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000003,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2009.3129999999633,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.012000000000001,
"layouts": 10,
"layoutDurationMs": 2.788,
"taskDurationMs": 408.827,
"heapDeltaBytes": 2049932,
"heapUsedBytes": 63631440,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 10.479,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2010.3690000000256,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.973,
"layouts": 10,
"layoutDurationMs": 2.5249999999999995,
"taskDurationMs": 356.22499999999997,
"heapDeltaBytes": 2205016,
"heapUsedBytes": 64347824,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 9.053,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.3219999999997,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.267,
"layouts": 9,
"layoutDurationMs": 2.258,
"taskDurationMs": 663.3,
"heapDeltaBytes": 13319904,
"heapUsedBytes": 75187992,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 103.22000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.925000000016,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.404000000000002,
"layouts": 10,
"layoutDurationMs": 2.5749999999999997,
"taskDurationMs": 676.562,
"heapDeltaBytes": 17402544,
"heapUsedBytes": 79662348,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 99.574,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1183.3560000000034,
"styleRecalcs": 20,
"styleRecalcDurationMs": 17.233999999999995,
"layouts": 5,
"layoutDurationMs": 10.277,
"taskDurationMs": 777.8050000000001,
"heapDeltaBytes": 9804880,
"heapUsedBytes": 86738308,
"domNodes": 16030,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 25.897000000000002,
"eventListeners": 3246,
"totalBlockingTimeMs": 108,
"frameDurationMs": 19.085483870967746,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9042.748000000018,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.397,
"layouts": 8,
"layoutDurationMs": 2.1130000000000004,
"taskDurationMs": 4293.737,
"heapDeltaBytes": 2756592,
"heapUsedBytes": 77272612,
"domNodes": -257,
"jsHeapTotalBytes": 5595136,
"scriptDurationMs": 2005.6759999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665745856353592,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8341.167999999981,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.758,
"layouts": 9,
"layoutDurationMs": 2.309,
"taskDurationMs": 4075.3890000000006,
"heapDeltaBytes": 9729464,
"heapUsedBytes": 84052436,
"domNodes": -263,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 2036.4520000000002,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665999999999997,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16660.263000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15709.216000000002,
"heapDeltaBytes": -4032128,
"heapUsedBytes": 288202624,
"domNodes": -3343,
"jsHeapTotalBytes": 35119104,
"scriptDurationMs": 210.955,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.635567010309273,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 16937.012999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16094.966999999997,
"heapDeltaBytes": 3580804,
"heapUsedBytes": 281072756,
"domNodes": -3343,
"jsHeapTotalBytes": 15982592,
"scriptDurationMs": 229.928,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.994349315068494,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 18632.492000000013,
"styleRecalcs": 144,
"styleRecalcDurationMs": 16.783999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18275.505,
"heapDeltaBytes": -46580356,
"heapUsedBytes": 256387884,
"domNodes": -3343,
"jsHeapTotalBytes": 14147584,
"scriptDurationMs": 643.501,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.504999999999995,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 18744.87999999997,
"styleRecalcs": 148,
"styleRecalcDurationMs": 17.99300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18345.272999999997,
"heapDeltaBytes": -5560348,
"heapUsedBytes": 287146728,
"domNodes": -3343,
"jsHeapTotalBytes": 16699392,
"scriptDurationMs": 638.7080000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.6540590405904,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6048.321999999985,
"styleRecalcs": 20,
"styleRecalcDurationMs": 42.84200000000002,
"layouts": 20,
"layoutDurationMs": 21.585000000000008,
"taskDurationMs": 5954.903999999999,
"heapDeltaBytes": -39526456,
"heapUsedBytes": 262427760,
"domNodes": -3343,
"jsHeapTotalBytes": 25681920,
"scriptDurationMs": 88.506,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.226347305389226,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5815.202999999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 42.13400000000001,
"layouts": 20,
"layoutDurationMs": 21.336999999999996,
"taskDurationMs": 5662.4670000000015,
"heapDeltaBytes": -22771464,
"heapUsedBytes": 278930556,
"domNodes": -3343,
"jsHeapTotalBytes": 27254784,
"scriptDurationMs": 84.79700000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.01403508771929,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8347.911000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7956.968999999999,
"heapDeltaBytes": 23053816,
"heapUsedBytes": 283201772,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 108.70799999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.833910034602077,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7993.116999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7514.080000000002,
"heapDeltaBytes": -4236000,
"heapUsedBytes": 258655940,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 93.68599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.52793103448276,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 99.46999999999662,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.782,
"layouts": 7,
"layoutDurationMs": 2.1609999999999996,
"taskDurationMs": 66.08800000000001,
"heapDeltaBytes": 4760980,
"heapUsedBytes": 65358388,
"domNodes": 101,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.929999999999999,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.68333333333332,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 445.6289999999399,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.003,
"layouts": 12,
"layoutDurationMs": 3.2379999999999995,
"taskDurationMs": 84.316,
"heapDeltaBytes": 6651872,
"heapUsedBytes": 68072548,
"domNodes": 99,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.056000000000001,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 230.00500000000557,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.621,
"layouts": 76,
"layoutDurationMs": 11.5,
"taskDurationMs": 189.12500000000003,
"heapDeltaBytes": 9751560,
"heapUsedBytes": 49336356,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 81.197,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285693,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 221.61500000004253,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.602,
"layouts": 76,
"layoutDurationMs": 11.950000000000001,
"taskDurationMs": 186.718,
"heapDeltaBytes": -6788028,
"heapUsedBytes": 38539632,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 77.586,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285693,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 291.484999999966,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.3960000000000001,
"layouts": 76,
"layoutDurationMs": 12.836,
"taskDurationMs": 248.178,
"heapDeltaBytes": -2251704,
"heapUsedBytes": 88397892,
"domNodes": 4,
"jsHeapTotalBytes": 1052672,
"scriptDurationMs": 84.73400000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66111111111109,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 281.5219999999954,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.591,
"layouts": 76,
"layoutDurationMs": 12.102,
"taskDurationMs": 247.387,
"heapDeltaBytes": -2235632,
"heapUsedBytes": 91578764,
"domNodes": 4,
"jsHeapTotalBytes": 1052672,
"scriptDurationMs": 83.37599999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage: 🟡 60.1% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3126 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 122b615f36e9cf7cfb5e109ca3ccd685db1a8929
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (238)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.59 #22579 +/- ##
=============================================
Coverage ? 87.21%
=============================================
Files ? 3033
Lines ? 159203
Branches ? 39986
=============================================
Hits ? 138848
Misses ? 19675
Partials ? 680
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…d after a reload (#22571) (#22969) Manual backport of #22571 to `core/1.58`. The automatic backport failed with a merge conflict (comments on #22571, Nov 1 and Nov 3). ## Why 1.58 The bug (unedited saved workflows reopen marked unsaved after a reload) reproduces on 1.58 too. The `cloud/1.58`, `core/1.59` and `cloud/1.59` ports already merged (#22577, #22578, #22579). ## What differs from #22571 One conflict, in `comfyWorkflow.ts`: - `core/1.58` has no `readUsableDraft` / `parseStoredWorkflow` / anomaly-report helpers, so they are not brought in. Only the new `draftMatchesSavedFile` helper is added. - The draft overlay in `load()` uses the 1.58 names (`draftState`, `draftContent`). It now sets `_isModified` from `!draftMatchesSavedFile(runtime, initialState, draftState)` instead of `true`, the same as on main. The other five files (unit tests, browser test, `WorkflowRuntime.graphEqual`, `changeTrackerAccess`) applied cleanly. ## Tests - `vitest run src/platform/workflow/management/stores/workflowStore.test.ts` on this branch: 80/80 pass, including the new cases. - oxfmt and oxlint clean on the resolved file. Typecheck and the browser test run in CI.
Backport of #22571 to
cloud/1.59Automatically created by backport workflow.