Repository navigation
[backport cloud/1.58] fix: do not mark unedited saved workflows unsaved after a reload - #22577
Conversation
) ## Summary Unedited saved workflows opened marked unsaved after a reload: the unsaved dot showed, the page title started with `*`, closing the tab asked to save, and reloading showed the browser's "Leave site?" prompt. Root cause: switching tabs writes a draft for the outgoing workflow even when it is unedited (`beforeLoadNewGraph` → `persistActiveWorkflowDraft`). After a reload, `ComfyWorkflow.load()` overlays that draft and set `isModified = true` whenever a draft existed, although the draft equals the saved file. Fix: when a draft is overlaid, mark the workflow modified only if the draft graph differs from the saved file, using the change tracker's existing `graphEqual` (which ignores the viewport). The draft is still overlaid, so a saved viewport is kept. This also clears the mark for drafts users already have in browser storage. The comparison is reached through the injected `WorkflowRuntime`, so the workflow model still does not import the change tracker. Not changed: tab switches still write drafts for unedited workflows. Skipping that write would conflict with #21440, which stores each tab's viewport in its draft. Linear: FRONT-3766. Reported in QA on testcloud cloud/1.59; it reproduces on cloud/1.58 too, so it is not a 1.59 regression. ## Verification - Red first, on CI: test-only head `ab1ed65e3d` failed both new `workflowStore.test.ts` cases (draft equal to the file; draft differing only by viewport) with `expected true to be false` (unit shard 4), and the new browser test failed at the restored-tab `isModified` check in chromium shard 16 (https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/41281652340/job/124775157225). The fix commit follows. - More unit cases: a draft that only changes app mode (`extra.linearMode`) stays marked modified. A draft or saved file with no `nodes` array stays marked modified and no longer throws; this case was red with a TypeError before the guard. - New browser test `Unedited saved workflows reopen as saved after a reload` in `workflowPersistence.spec.ts` follows the reported steps: save three workflows, visit each tab, reload, reopen the first two, and assert no unsaved mark and no `*` title. It also checks the tab that was active at the reload. - `vitest run src/platform/workflow src/scripts/changeTracker`: 125 files, 2423 passed. - `pnpm typecheck`, `pnpm typecheck:browser`, oxfmt, oxlint. ## Review notes An independent adversarial review (fresh Claude reviewer; cross-model was unavailable) raised: - comments in the changed function and tests: removed (repo rule). - `graphEqual` might treat swapped `widgets_values` as equal: checked, it does not. Only the top-level node array is compared unordered; arrays inside a node are compared in order. - a restored draft becomes the tracker's baseline in `activateLoadedWorkflow`, so editing and then reverting on a tab that had real draft edits can clear its unsaved mark. That is existing behaviour, not changed here; it is followed up separately. Known limits, followed up separately: a file that changes when it is loaded and serialized again (older frontend, external tool) can still reopen as modified. A viewport-only draft is restored once, then dropped like any unmodified draft (see #21440).
dante01yoon
left a comment
There was a problem hiding this comment.
Backport of #22571; file set matches the merged original. LGTM.
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-01T08:52:15.319Z",
"gitSha": "ad1a8e85fdb266a5dc727d5caf049e331f99238c",
"branch": "backport-22571-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2056.2570000000164,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.9029999999999996,
"layouts": 10,
"layoutDurationMs": 2.446,
"taskDurationMs": 441.752,
"heapDeltaBytes": 2155588,
"heapUsedBytes": 90020856,
"domNodes": -200,
"jsHeapTotalBytes": -3604480,
"scriptDurationMs": 9.657000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2021.5819999999667,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.2929999999999997,
"layouts": 9,
"layoutDurationMs": 2.418,
"taskDurationMs": 520.464,
"heapDeltaBytes": 2203776,
"heapUsedBytes": 93231024,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.111,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1792.8170000000136,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.305,
"layouts": 9,
"layoutDurationMs": 2.457,
"taskDurationMs": 932.3539999999999,
"heapDeltaBytes": -21316852,
"heapUsedBytes": 81118172,
"domNodes": -200,
"jsHeapTotalBytes": -1478656,
"scriptDurationMs": 164.17100000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740745,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1777.637000000027,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.449,
"layouts": 9,
"layoutDurationMs": 2.3859999999999997,
"taskDurationMs": 919.0070000000002,
"heapDeltaBytes": -17964504,
"heapUsedBytes": 79342352,
"domNodes": -200,
"jsHeapTotalBytes": 1667072,
"scriptDurationMs": 163.214,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.2340000000145,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.374,
"layouts": 12,
"layoutDurationMs": 3.2259999999999995,
"taskDurationMs": 288.917,
"heapDeltaBytes": 21544152,
"heapUsedBytes": 109394692,
"domNodes": 47,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 11.39,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.0230000000784,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.258000000000001,
"layouts": 11,
"layoutDurationMs": 3.018,
"taskDurationMs": 296.007,
"heapDeltaBytes": 21524576,
"heapUsedBytes": 112176856,
"domNodes": 47,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 11.151000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 614.6499999999833,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.084,
"layouts": 10,
"layoutDurationMs": 2.901,
"taskDurationMs": 435.337,
"heapDeltaBytes": 173088,
"heapUsedBytes": 87672692,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 170.78199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 637.9859999999553,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.745,
"layouts": 8,
"layoutDurationMs": 2.6220000000000003,
"taskDurationMs": 453.777,
"heapDeltaBytes": 254028,
"heapUsedBytes": 88146212,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 179.275,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668421052631583,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1218.3339999999703,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 852.28,
"heapDeltaBytes": -9303464,
"heapUsedBytes": 102723188,
"domNodes": -230,
"jsHeapTotalBytes": 12918784,
"scriptDurationMs": 65.51299999999999,
"eventListeners": -168,
"totalBlockingTimeMs": 529,
"frameDurationMs": 32.881081081081064,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1229.8439999999573,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 923.497,
"heapDeltaBytes": -15847796,
"heapUsedBytes": 102853144,
"domNodes": -230,
"jsHeapTotalBytes": 16171008,
"scriptDurationMs": 65.673,
"eventListeners": -168,
"totalBlockingTimeMs": 537,
"frameDurationMs": 32.45263157894736,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 848.1140000000096,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.19600000000025,
"heapDeltaBytes": -4398696,
"heapUsedBytes": 97033732,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 165.14499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 216,
"frameDurationMs": 25.00000000000003,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 849.9289999999746,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.1590000000002,
"heapDeltaBytes": -3729780,
"heapUsedBytes": 97805312,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 164.02899999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 222,
"frameDurationMs": 25.00000000000003,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10083.292999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9219.604000000001,
"heapDeltaBytes": 23610184,
"heapUsedBytes": 127198764,
"domNodes": -296,
"jsHeapTotalBytes": 27406336,
"scriptDurationMs": 7638.076,
"eventListeners": -130,
"totalBlockingTimeMs": 991,
"frameDurationMs": 32.42090032154341,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10326.045000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9567.601,
"heapDeltaBytes": 42011600,
"heapUsedBytes": 148920880,
"domNodes": -276,
"jsHeapTotalBytes": 46018560,
"scriptDurationMs": 7593.462,
"eventListeners": -130,
"totalBlockingTimeMs": 820,
"frameDurationMs": 31.356534954407298,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10329.031999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9511.723999999998,
"heapDeltaBytes": 31552496,
"heapUsedBytes": 135061292,
"domNodes": -276,
"jsHeapTotalBytes": 35270656,
"scriptDurationMs": 7946.667,
"eventListeners": -130,
"totalBlockingTimeMs": 1127,
"frameDurationMs": 32.03788819875776,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10127.264999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9379.377,
"heapDeltaBytes": 13249028,
"heapUsedBytes": 134986288,
"domNodes": -276,
"jsHeapTotalBytes": 39649280,
"scriptDurationMs": 7826.335,
"eventListeners": -130,
"totalBlockingTimeMs": 1026,
"frameDurationMs": 31.86446540880503,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 204.63899999998603,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.46,
"layouts": 11,
"layoutDurationMs": 3.3200000000000003,
"taskDurationMs": 148.792,
"heapDeltaBytes": 13269140,
"heapUsedBytes": 117892152,
"domNodes": 917,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 8.161999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.22222222222222,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 235.07600000004913,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.721999999999998,
"layouts": 11,
"layoutDurationMs": 3.142,
"taskDurationMs": 184.179,
"heapDeltaBytes": 15500864,
"heapUsedBytes": 118022700,
"domNodes": 917,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 8.795,
"eventListeners": 196,
"totalBlockingTimeMs": 5,
"frameDurationMs": 24.989999999999963,
"p95FrameDurationMs": 99.89999999999964
},
{
"name": "large-graph-idle",
"durationMs": 2057.301999999993,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5900000000000003,
"layouts": 9,
"layoutDurationMs": 2.4879999999999995,
"taskDurationMs": 677.542,
"heapDeltaBytes": -5540164,
"heapUsedBytes": 97332332,
"domNodes": -296,
"jsHeapTotalBytes": -3002368,
"scriptDurationMs": 32.557,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2042.2059999999647,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.322,
"layouts": 8,
"layoutDurationMs": 2.064,
"taskDurationMs": 476.04,
"heapDeltaBytes": 362324,
"heapUsedBytes": 101921684,
"domNodes": -296,
"jsHeapTotalBytes": -5177344,
"scriptDurationMs": 32.97299999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2231.133,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.343,
"layouts": 7,
"layoutDurationMs": 1.8579999999999999,
"taskDurationMs": 1497.1229999999998,
"heapDeltaBytes": 2823600,
"heapUsedBytes": 108064764,
"domNodes": -296,
"jsHeapTotalBytes": -1466368,
"scriptDurationMs": 809.215,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66616541353383,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2702.25999999991,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.395,
"layouts": 7,
"layoutDurationMs": 1.829,
"taskDurationMs": 1788.4660000000001,
"heapDeltaBytes": -20855636,
"heapUsedBytes": 88591608,
"domNodes": -296,
"jsHeapTotalBytes": -614400,
"scriptDurationMs": 888.386,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666049382716054,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3570.482000000027,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.729999999999999,
"layouts": 65,
"layoutDurationMs": 10.681999999999999,
"taskDurationMs": 1577.197,
"heapDeltaBytes": 7394984,
"heapUsedBytes": 111599808,
"domNodes": 24,
"jsHeapTotalBytes": 5246976,
"scriptDurationMs": 801.811,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74413145539906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3655.3440000000137,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.254,
"layouts": 63,
"layoutDurationMs": 9.672,
"taskDurationMs": 1780.951,
"heapDeltaBytes": -8759908,
"heapUsedBytes": 95758272,
"domNodes": -272,
"jsHeapTotalBytes": -851968,
"scriptDurationMs": 757.655,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.742660550458712,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3010.3030000000217,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.842,
"layouts": 4,
"layoutDurationMs": 1.375,
"taskDurationMs": 1913.662,
"heapDeltaBytes": 21909408,
"heapUsedBytes": 128410308,
"domNodes": 0,
"jsHeapTotalBytes": 5664768,
"scriptDurationMs": 917.9739999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.948587570621466,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3019.541000000004,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.2669999999999995,
"layouts": 5,
"layoutDurationMs": 1.3870000000000002,
"taskDurationMs": 1947.3860000000002,
"heapDeltaBytes": 22398240,
"heapUsedBytes": 128472544,
"domNodes": 0,
"jsHeapTotalBytes": 5926912,
"scriptDurationMs": 938.5810000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.946629213483146,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2028.7700000000086,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.588999999999999,
"layouts": 8,
"layoutDurationMs": 2.7079999999999997,
"taskDurationMs": 487.213,
"heapDeltaBytes": -16375376,
"heapUsedBytes": 94791816,
"domNodes": -297,
"jsHeapTotalBytes": -3002368,
"scriptDurationMs": 30.973000000000006,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2046.6780000000426,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8639999999999994,
"layouts": 7,
"layoutDurationMs": 1.7479999999999998,
"taskDurationMs": 483.63199999999983,
"heapDeltaBytes": 2090888,
"heapUsedBytes": 104632604,
"domNodes": -296,
"jsHeapTotalBytes": -5177344,
"scriptDurationMs": 32.088,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 675.2999999999929,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.077999999999999,
"layouts": 10,
"layoutDurationMs": 2.497,
"taskDurationMs": 481.3519999999999,
"heapDeltaBytes": -2578796,
"heapUsedBytes": 102116024,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 148.872,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536566,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 532.3869999999715,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.587,
"layouts": 9,
"layoutDurationMs": 2.0709999999999997,
"taskDurationMs": 368.69000000000005,
"heapDeltaBytes": 22536776,
"heapUsedBytes": 112980620,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 143.514,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000017,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2041.0479999999893,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.902,
"layouts": 9,
"layoutDurationMs": 3.0149999999999997,
"taskDurationMs": 577.01,
"heapDeltaBytes": -538976,
"heapUsedBytes": 88880032,
"domNodes": -218,
"jsHeapTotalBytes": -2031616,
"scriptDurationMs": 8.435000000000002,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.9550000000245,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4519999999999995,
"layouts": 8,
"layoutDurationMs": 2.003,
"taskDurationMs": 516.721,
"heapDeltaBytes": 1781972,
"heapUsedBytes": 93349568,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7.959999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.5979999999868,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.098,
"layouts": 9,
"layoutDurationMs": 2.1439999999999997,
"taskDurationMs": 907.6529999999999,
"heapDeltaBytes": -7451844,
"heapUsedBytes": 82474792,
"domNodes": -210,
"jsHeapTotalBytes": -2293760,
"scriptDurationMs": 110.88300000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.632999999987,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.054,
"layouts": 9,
"layoutDurationMs": 2.6040000000000005,
"taskDurationMs": 732,
"heapDeltaBytes": -1267920,
"heapUsedBytes": 88712596,
"domNodes": -210,
"jsHeapTotalBytes": -2818048,
"scriptDurationMs": 110.043,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1451.7589999999814,
"styleRecalcs": 20,
"styleRecalcDurationMs": 24.241,
"layouts": 5,
"layoutDurationMs": 13.521000000000003,
"taskDurationMs": 1042.53,
"heapDeltaBytes": 16519052,
"heapUsedBytes": 145244328,
"domNodes": 16030,
"jsHeapTotalBytes": 13246464,
"scriptDurationMs": 28.878,
"eventListeners": 3244,
"totalBlockingTimeMs": 146,
"frameDurationMs": 19.553333333333345,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8278.764999999965,
"styleRecalcs": 249,
"styleRecalcDurationMs": 27.668000000000003,
"layouts": 7,
"layoutDurationMs": 1.8579999999999999,
"taskDurationMs": 5113.341,
"heapDeltaBytes": 2824620,
"heapUsedBytes": 104302132,
"domNodes": -296,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 2659.208,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.767206477732792,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8571.834999999965,
"styleRecalcs": 250,
"styleRecalcDurationMs": 28.64,
"layouts": 8,
"layoutDurationMs": 1.938,
"taskDurationMs": 5285.852999999999,
"heapDeltaBytes": -2564756,
"heapUsedBytes": 104137968,
"domNodes": -296,
"jsHeapTotalBytes": -528384,
"scriptDurationMs": 2720.4519999999998,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665953307393,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16118.96200000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15125.274,
"heapDeltaBytes": -23559244,
"heapUsedBytes": 295604796,
"domNodes": -3344,
"jsHeapTotalBytes": 25415680,
"scriptDurationMs": 233.66400000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.59589041095891,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-idle",
"durationMs": 16115.106999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15126.846,
"heapDeltaBytes": -19253404,
"heapUsedBytes": 285732188,
"domNodes": -3348,
"jsHeapTotalBytes": 6017024,
"scriptDurationMs": 239.03700000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.454855195911414,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 19256.690999999988,
"styleRecalcs": 166,
"styleRecalcDurationMs": 14.752000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18747.384,
"heapDeltaBytes": -28052160,
"heapUsedBytes": 282488988,
"domNodes": -2276,
"jsHeapTotalBytes": -2371584,
"scriptDurationMs": 801.037,
"eventListeners": -421,
"totalBlockingTimeMs": 33,
"frameDurationMs": 35.16014625228519,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 18982.079999999994,
"styleRecalcs": 144,
"styleRecalcDurationMs": 14.284999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18636.454999999998,
"heapDeltaBytes": -36387672,
"heapUsedBytes": 293692856,
"domNodes": -3374,
"jsHeapTotalBytes": 15192064,
"scriptDurationMs": 823.457,
"eventListeners": -651,
"totalBlockingTimeMs": 24,
"frameDurationMs": 35.15296296296297,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8202.994999999988,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.77999999999997,
"layouts": 20,
"layoutDurationMs": 22.995999999999988,
"taskDurationMs": 8098.009999999998,
"heapDeltaBytes": -15548320,
"heapUsedBytes": 296547272,
"domNodes": -3344,
"jsHeapTotalBytes": 14405632,
"scriptDurationMs": 121.686,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.672093023255826,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 5850.634000000014,
"styleRecalcs": 20,
"styleRecalcDurationMs": 67.03300000000002,
"layouts": 20,
"layoutDurationMs": 22.818000000000005,
"taskDurationMs": 5743.986000000001,
"heapDeltaBytes": -27820416,
"heapUsedBytes": 284905452,
"domNodes": -3344,
"jsHeapTotalBytes": 24891392,
"scriptDurationMs": 93.42999999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.41058823529412,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11331.253000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10891.720000000001,
"heapDeltaBytes": 4304100,
"heapUsedBytes": 297028628,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 152.71800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.078965517241386,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11370.209000000046,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11044.262000000002,
"heapDeltaBytes": -24509072,
"heapUsedBytes": 271072284,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 151.397,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.251724137931035,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 504.8779999999624,
"styleRecalcs": 18,
"styleRecalcDurationMs": 10.14,
"layouts": 11,
"layoutDurationMs": 4.370000000000001,
"taskDurationMs": 143.582,
"heapDeltaBytes": -17831736,
"heapUsedBytes": 93909736,
"domNodes": 126,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 14.544,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 470.4860000000508,
"styleRecalcs": 21,
"styleRecalcDurationMs": 10.016,
"layouts": 13,
"layoutDurationMs": 4.7620000000000005,
"taskDurationMs": 119.43400000000001,
"heapDeltaBytes": 7071532,
"heapUsedBytes": 96349068,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.355,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66206896551725,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 467.0339999998987,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.615,
"layouts": 76,
"layoutDurationMs": 15.238,
"taskDurationMs": 422.51700000000005,
"heapDeltaBytes": -14319028,
"heapUsedBytes": 81595056,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 205.873,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379284,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 506.30499999999756,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.7150000000000001,
"layouts": 76,
"layoutDurationMs": 15.394,
"taskDurationMs": 441.093,
"heapDeltaBytes": 12126560,
"heapUsedBytes": 84006964,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 211.49599999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 498.81300000004103,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.732,
"layouts": 76,
"layoutDurationMs": 13.221,
"taskDurationMs": 453.49699999999996,
"heapDeltaBytes": -15496,
"heapUsedBytes": 117175464,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 176.252,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 577.8150000001006,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.7329999999999999,
"layouts": 76,
"layoutDurationMs": 13.749,
"taskDurationMs": 548.4259999999999,
"heapDeltaBytes": 934608,
"heapUsedBytes": 118622608,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 230.80999999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669444444444455,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage: 🟡 63.6% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2991 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 4ac97659b08dc35ff3997bea46a7b4464b853c80
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (142)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.58 #22577 +/- ##
=============================================
Coverage ? 84.25%
=============================================
Files ? 3172
Lines ? 165538
Branches ? 41559
=============================================
Hits ? 139466
Misses ? 25680
Partials ? 392
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…d after a reload (#22571) (#22969) Manual backport of #22571 to `core/1.58`. The automatic backport failed with a merge conflict (comments on #22571, Nov 1 and Nov 3). ## Why 1.58 The bug (unedited saved workflows reopen marked unsaved after a reload) reproduces on 1.58 too. The `cloud/1.58`, `core/1.59` and `cloud/1.59` ports already merged (#22577, #22578, #22579). ## What differs from #22571 One conflict, in `comfyWorkflow.ts`: - `core/1.58` has no `readUsableDraft` / `parseStoredWorkflow` / anomaly-report helpers, so they are not brought in. Only the new `draftMatchesSavedFile` helper is added. - The draft overlay in `load()` uses the 1.58 names (`draftState`, `draftContent`). It now sets `_isModified` from `!draftMatchesSavedFile(runtime, initialState, draftState)` instead of `true`, the same as on main. The other five files (unit tests, browser test, `WorkflowRuntime.graphEqual`, `changeTrackerAccess`) applied cleanly. ## Tests - `vitest run src/platform/workflow/management/stores/workflowStore.test.ts` on this branch: 80/80 pass, including the new cases. - oxfmt and oxlint clean on the resolved file. Typecheck and the browser test run in CI.
Backport of #22571 to
cloud/1.58Automatically created by backport workflow.