Repository navigation
[backport cloud/1.59] Don't trust preview_url for media lightbox - #22564
Conversation
As stated #20359, the `preview_url` may not be present for for some assets (like videos), but `preview_url` was still blindly trusted for the media lightbox displayed when an asset is inspected. This is a minimal PR to instead use `getAssetInlineMediaUrl`
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-11-01T05:58:06.880Z",
"gitSha": "c4fd5cbcfd00535a3fbadbf793ff135acd56c208",
"branch": "backport-22075-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.4030000000107,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6220000000000003,
"layouts": 9,
"layoutDurationMs": 2.7680000000000007,
"taskDurationMs": 554.934,
"heapDeltaBytes": 1402300,
"heapUsedBytes": 62562800,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 10.578999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2021.285999999975,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5370000000000004,
"layouts": 8,
"layoutDurationMs": 2.709,
"taskDurationMs": 584.679,
"heapDeltaBytes": 3377012,
"heapUsedBytes": 64472268,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 11.112999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1855.8210000000201,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.15,
"layouts": 9,
"layoutDurationMs": 2.6700000000000004,
"taskDurationMs": 913.6539999999999,
"heapDeltaBytes": 21026020,
"heapUsedBytes": 81800544,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 152.077,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665765765765762,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1859.2840000000024,
"styleRecalcs": 54,
"styleRecalcDurationMs": 11.644000000000002,
"layouts": 8,
"layoutDurationMs": 2.4649999999999994,
"taskDurationMs": 956.97,
"heapDeltaBytes": 21819452,
"heapUsedBytes": 83025780,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 162.767,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665765765765766,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.6260000000048,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.303,
"layouts": 10,
"layoutDurationMs": 2.8409999999999997,
"taskDurationMs": 441.191,
"heapDeltaBytes": 24054260,
"heapUsedBytes": 85426220,
"domNodes": 56,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 13.305000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.562000000058,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.148,
"layouts": 11,
"layoutDurationMs": 3.2110000000000003,
"taskDurationMs": 447.13199999999995,
"heapDeltaBytes": 24090636,
"heapUsedBytes": 85290916,
"domNodes": 56,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 13.297,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 694.3990000000042,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.776,
"layouts": 9,
"layoutDurationMs": 2.62,
"taskDurationMs": 499.6689999999999,
"heapDeltaBytes": 5370032,
"heapUsedBytes": 66922060,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 167.702,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285718,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 738.2649999999558,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.2279999999999998,
"layouts": 6,
"layoutDurationMs": 1.9359999999999997,
"taskDurationMs": 508.27500000000003,
"heapDeltaBytes": 5748864,
"heapUsedBytes": 67029164,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 166.05599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1212.3859999999809,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 923.291,
"heapDeltaBytes": -13392956,
"heapUsedBytes": 75262512,
"domNodes": -191,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 61.773999999999994,
"eventListeners": -106,
"totalBlockingTimeMs": 517,
"frameDurationMs": 32.01578947368421,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1245.822999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 943.7520000000001,
"heapDeltaBytes": -11260712,
"heapUsedBytes": 75783996,
"domNodes": -191,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 67.53299999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 565,
"frameDurationMs": 33.78378378378377,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 877.0269999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 559.78,
"heapDeltaBytes": -14273716,
"heapUsedBytes": 65507896,
"domNodes": -191,
"jsHeapTotalBytes": 917504,
"scriptDurationMs": 155.787,
"eventListeners": -106,
"totalBlockingTimeMs": 199,
"frameDurationMs": 23.87567567567569,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 857.1000000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.0799999999999,
"heapDeltaBytes": -29321136,
"heapUsedBytes": 65762048,
"domNodes": -191,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 142.851,
"eventListeners": -106,
"totalBlockingTimeMs": 191,
"frameDurationMs": 23.61111111111111,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10401.699000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9456.68,
"heapDeltaBytes": 63803108,
"heapUsedBytes": 136292268,
"domNodes": -257,
"jsHeapTotalBytes": 70119424,
"scriptDurationMs": 7328.205000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 507,
"frameDurationMs": 30.951190476190476,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9552.243999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8785.643,
"heapDeltaBytes": 70096776,
"heapUsedBytes": 143928352,
"domNodes": -257,
"jsHeapTotalBytes": 65400832,
"scriptDurationMs": 6875.89,
"eventListeners": -68,
"totalBlockingTimeMs": 478,
"frameDurationMs": 31.83166666666666,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9675.297,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.05799999999999989,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8904.635,
"heapDeltaBytes": 3854636,
"heapUsedBytes": 92291024,
"domNodes": -257,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 6927.281,
"eventListeners": -68,
"totalBlockingTimeMs": 489,
"frameDurationMs": 32.221000000000004,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9591.785000000016,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.037000000000000574,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8806.463,
"heapDeltaBytes": 69231484,
"heapUsedBytes": 144676900,
"domNodes": -257,
"jsHeapTotalBytes": 67760128,
"scriptDurationMs": 6851.312,
"eventListeners": -68,
"totalBlockingTimeMs": 244,
"frameDurationMs": 29.03909090909091,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 212.0610000000056,
"styleRecalcs": 21,
"styleRecalcDurationMs": 12.743,
"layouts": 7,
"layoutDurationMs": 2.3120000000000016,
"taskDurationMs": 162.28800000000004,
"heapDeltaBytes": 14588156,
"heapUsedBytes": 73460732,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.133,
"eventListeners": 205,
"totalBlockingTimeMs": 4,
"frameDurationMs": 24.066666666666656,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 265.69500000005064,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.727,
"layouts": 11,
"layoutDurationMs": 3.5300000000000002,
"taskDurationMs": 222.65500000000003,
"heapDeltaBytes": -8010440,
"heapUsedBytes": 75228696,
"domNodes": 936,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.572000000000001,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.236363636363627,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2055.1639999999907,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.536,
"layouts": 9,
"layoutDurationMs": 2.515,
"taskDurationMs": 687.788,
"heapDeltaBytes": -9995064,
"heapUsedBytes": 64286964,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 34.577999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2052.055999999993,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.8740000000000006,
"layouts": 6,
"layoutDurationMs": 2.0300000000000002,
"taskDurationMs": 713.066,
"heapDeltaBytes": -24033356,
"heapUsedBytes": 67362104,
"domNodes": -257,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 39.721000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2326.0859999999752,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.555,
"layouts": 7,
"layoutDurationMs": 2.0839999999999996,
"taskDurationMs": 1710.537,
"heapDeltaBytes": 9850872,
"heapUsedBytes": 84787832,
"domNodes": -257,
"jsHeapTotalBytes": 5332992,
"scriptDurationMs": 789.553,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666187050359714,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2432.0600000000923,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.854000000000001,
"layouts": 7,
"layoutDurationMs": 2.014,
"taskDurationMs": 1766.4170000000001,
"heapDeltaBytes": -2095412,
"heapUsedBytes": 72083052,
"domNodes": -257,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 831.5369999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78137931034483,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3705.411999999967,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.757000000000001,
"layouts": 64,
"layoutDurationMs": 10.63,
"taskDurationMs": 1881.232,
"heapDeltaBytes": -8448908,
"heapUsedBytes": 70234172,
"domNodes": -233,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 782.94,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66591928251121,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3892.626000000064,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.078999999999997,
"layouts": 64,
"layoutDurationMs": 11.067,
"taskDurationMs": 1955.405,
"heapDeltaBytes": 1012936,
"heapUsedBytes": 82540348,
"domNodes": -233,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 849.6850000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665811965811965,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3176.1789999999905,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.219,
"layouts": 5,
"layoutDurationMs": 1.141,
"taskDurationMs": 2091.354,
"heapDeltaBytes": -8344208,
"heapUsedBytes": 71752576,
"domNodes": 0,
"jsHeapTotalBytes": 6643712,
"scriptDurationMs": 1005.6850000000002,
"eventListeners": 182,
"totalBlockingTimeMs": 26,
"frameDurationMs": 16.93068783068783,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3252.8570000000627,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.468,
"layouts": 4,
"layoutDurationMs": 1.303,
"taskDurationMs": 2152.9660000000003,
"heapDeltaBytes": -642044,
"heapUsedBytes": 80256008,
"domNodes": -257,
"jsHeapTotalBytes": 5525504,
"scriptDurationMs": 1004.6379999999999,
"eventListeners": -63,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.838860103626946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3068.9500000000007,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.6759999999999995,
"layouts": 6,
"layoutDurationMs": 1.5269999999999997,
"taskDurationMs": 851.1249999999999,
"heapDeltaBytes": 158188,
"heapUsedBytes": 78813172,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 362.973,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75737704918033,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3121.3689999999588,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9729999999999999,
"layouts": 8,
"layoutDurationMs": 2.0930000000000004,
"taskDurationMs": 818.2149999999999,
"heapDeltaBytes": -11954092,
"heapUsedBytes": 67905784,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 359.17600000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666310160427805,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2041.3879999999835,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.0940000000000003,
"layouts": 7,
"layoutDurationMs": 2.0820000000000003,
"taskDurationMs": 701.617,
"heapDeltaBytes": -14279440,
"heapUsedBytes": 65726600,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 37.68099999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2057.5079999999843,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.9020000000000001,
"layouts": 6,
"layoutDurationMs": 1.9020000000000006,
"taskDurationMs": 722.2729999999999,
"heapDeltaBytes": -11322204,
"heapUsedBytes": 66209164,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 35.495,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2885.964999999999,
"styleRecalcs": 25,
"styleRecalcDurationMs": 11.142000000000001,
"layouts": 6,
"layoutDurationMs": 1.611,
"taskDurationMs": 639.428,
"heapDeltaBytes": -9938184,
"heapUsedBytes": 69392084,
"domNodes": -247,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 181.959,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665317919075147,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2828.7990000000036,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.062999999999999,
"layouts": 6,
"layoutDurationMs": 1.718,
"taskDurationMs": 645.9840000000002,
"heapDeltaBytes": 1409708,
"heapUsedBytes": 80423288,
"domNodes": -245,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 187.034,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66588235294118,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3357.5690000000122,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.6850000000000007,
"layouts": 6,
"layoutDurationMs": 1.5459999999999998,
"taskDurationMs": 1001.933,
"heapDeltaBytes": -6654628,
"heapUsedBytes": 69892436,
"domNodes": -257,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 389.22100000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.83366834170854,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3272.5510000000213,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.6059999999999999,
"layouts": 6,
"layoutDurationMs": 1.611,
"taskDurationMs": 970.383,
"heapDeltaBytes": -17607636,
"heapUsedBytes": 75446964,
"domNodes": -257,
"jsHeapTotalBytes": 6979584,
"scriptDurationMs": 359.42100000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665816326530614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 631.8299999999795,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.393000000000001,
"layouts": 9,
"layoutDurationMs": 2.4440000000000004,
"taskDurationMs": 460.279,
"heapDeltaBytes": -1400648,
"heapUsedBytes": 59923076,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 146.88600000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684203,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 675.9670000000142,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.459,
"layouts": 8,
"layoutDurationMs": 2.5860000000000003,
"taskDurationMs": 485.05299999999994,
"heapDeltaBytes": -815184,
"heapUsedBytes": 61617976,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 149.402,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2007.7699999999936,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.671,
"layouts": 10,
"layoutDurationMs": 2.745,
"taskDurationMs": 538.285,
"heapDeltaBytes": 1879204,
"heapUsedBytes": 63695004,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 9.195000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2024.8850000000402,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.0230000000000006,
"layouts": 10,
"layoutDurationMs": 3.032,
"taskDurationMs": 640.396,
"heapDeltaBytes": -985976,
"heapUsedBytes": 61554660,
"domNodes": -183,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 10.933000000000002,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.02900000002,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.872000000000002,
"layouts": 8,
"layoutDurationMs": 2.0030000000000006,
"taskDurationMs": 874.5260000000001,
"heapDeltaBytes": 17368860,
"heapUsedBytes": 79342724,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 106.027,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1741.1290000000008,
"styleRecalcs": 78,
"styleRecalcDurationMs": 13.916999999999998,
"layouts": 8,
"layoutDurationMs": 2.25,
"taskDurationMs": 905.585,
"heapDeltaBytes": 18042500,
"heapUsedBytes": 80517252,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 111.29,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1450.2469999999903,
"styleRecalcs": 19,
"styleRecalcDurationMs": 20.248999999999995,
"layouts": 5,
"layoutDurationMs": 12.538,
"taskDurationMs": 1095.7099999999998,
"heapDeltaBytes": 38039768,
"heapUsedBytes": 113944540,
"domNodes": 16030,
"jsHeapTotalBytes": 15339520,
"scriptDurationMs": 31.483999999999998,
"eventListeners": 3246,
"totalBlockingTimeMs": 162,
"frameDurationMs": 19.594594594594593,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8694.076999999994,
"styleRecalcs": 250,
"styleRecalcDurationMs": 28.500000000000004,
"layouts": 8,
"layoutDurationMs": 2.302,
"taskDurationMs": 6158.76,
"heapDeltaBytes": -3966356,
"heapUsedBytes": 71384136,
"domNodes": -257,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 2741.0029999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.697884615384616,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8727.008000000069,
"styleRecalcs": 250,
"styleRecalcDurationMs": 29.651,
"layouts": 7,
"layoutDurationMs": 1.9689999999999999,
"taskDurationMs": 6346.8640000000005,
"heapDeltaBytes": -2562876,
"heapUsedBytes": 72310748,
"domNodes": -257,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 2777.471,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698084291187744,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 20737.082999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20233.872,
"heapDeltaBytes": -13520164,
"heapUsedBytes": 278170604,
"domNodes": -3343,
"jsHeapTotalBytes": 9166848,
"scriptDurationMs": 314.974,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.52115732368897,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 20821.461999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20351.861,
"heapDeltaBytes": -23560940,
"heapUsedBytes": 258972832,
"domNodes": -3343,
"jsHeapTotalBytes": 10735616,
"scriptDurationMs": 286.15000000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.29522058823529,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 25296.392999999967,
"styleRecalcs": 181,
"styleRecalcDurationMs": 21.272999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 25089.581000000002,
"heapDeltaBytes": -7839124,
"heapUsedBytes": 275797796,
"domNodes": -3343,
"jsHeapTotalBytes": 12836864,
"scriptDurationMs": 894.923,
"eventListeners": -651,
"totalBlockingTimeMs": 17,
"frameDurationMs": 48.61980769230768,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 25540.20700000001,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.395,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 25292.97,
"heapDeltaBytes": -17768620,
"heapUsedBytes": 274213380,
"domNodes": -3343,
"jsHeapTotalBytes": 14143488,
"scriptDurationMs": 894.6429999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 23,
"frameDurationMs": 48.35662878787879,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 7535.894000000042,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.388,
"layouts": 20,
"layoutDurationMs": 35.091999999999985,
"taskDurationMs": 7448.494,
"heapDeltaBytes": -18269488,
"heapUsedBytes": 278135784,
"domNodes": -3343,
"jsHeapTotalBytes": 13885440,
"scriptDurationMs": 113.80900000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.44682080924855,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7652.003000000036,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.319999999999986,
"layouts": 20,
"layoutDurationMs": 23.986999999999995,
"taskDurationMs": 7576.453,
"heapDeltaBytes": -39958852,
"heapUsedBytes": 257112796,
"domNodes": -3343,
"jsHeapTotalBytes": 18604032,
"scriptDurationMs": 144.02599999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.265088757396455,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10259.726,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9968.304999999998,
"heapDeltaBytes": 164140,
"heapUsedBytes": 279711960,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 139.448,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.75977859778597,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10485.322999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10191.001,
"heapDeltaBytes": -4205776,
"heapUsedBytes": 260048316,
"domNodes": 0,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 140.10200000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.57311827956988,
"p95FrameDurationMs": 66.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 472.49900000002754,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.835,
"layouts": 12,
"layoutDurationMs": 7.077999999999999,
"taskDurationMs": 130.53799999999998,
"heapDeltaBytes": 7058396,
"heapUsedBytes": 75175928,
"domNodes": 106,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.526999999999997,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379302,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 131.72599999995782,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.731,
"layouts": 8,
"layoutDurationMs": 3.585,
"taskDurationMs": 93.05299999999998,
"heapDeltaBytes": 4529444,
"heapUsedBytes": 65567116,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.399999999999998,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 583.3430000000135,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.636,
"layouts": 76,
"layoutDurationMs": 18.728,
"taskDurationMs": 540.563,
"heapDeltaBytes": -3497408,
"heapUsedBytes": 42425296,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 253.92999999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 510.9780000000228,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.7020000000000001,
"layouts": 76,
"layoutDurationMs": 18.516000000000002,
"taskDurationMs": 471.312,
"heapDeltaBytes": -4504448,
"heapUsedBytes": 40005952,
"domNodes": 4,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 214.80100000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 665.0649999999132,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.157,
"layouts": 76,
"layoutDurationMs": 18.171,
"taskDurationMs": 623.023,
"heapDeltaBytes": 2492972,
"heapUsedBytes": 99832156,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 247.65599999999998,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 681.919999999991,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.112,
"layouts": 76,
"layoutDurationMs": 17.687,
"taskDurationMs": 639.197,
"heapDeltaBytes": 2131800,
"heapUsedBytes": 104583672,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 259.029,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
}
]
}🎭 Playwright: ✅ 3123 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9ff9d9de3a997e3ac7baebb4b7da080590528e3b
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (238)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.59 #22564 +/- ##
=============================================
Coverage ? 87.21%
=============================================
Files ? 3033
Lines ? 159196
Branches ? 42482
=============================================
Hits ? 138841
Misses ? 19675
Partials ? 680
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Approving the backport. Mergeable against the release branch with no failing checks at this head.
christian-byrne
left a comment
There was a problem hiding this comment.
Clean cherry-pick of #22075 (same two files, same diff) onto cloud/1.59; all checks green at this head. Needed on cloud/1.59: testcloud QA found the Assets lightbox audio still has an empty source there.
…olved url with VHS previews on (#22563) (#22573) Manual backport of #22563 to `cloud/1.59` (the automated backport hit a conflict). Conflict only in the `<video>` tag: `cloud/1.59` has no `autoplay` prop, so this keeps the branch's tag and adds only the `data-testid`. The test imports `useExtensionStore` from `@/stores/extensionStore`, its path on this branch. Logic change is identical to #22563. Why on cloud/1.59: testcloud QA found Assets lightbox videos stuck at 0:00 (404 on `/api/viewvideo` for the display name). The audio half is #22564, already merged here. Tests: `ResultVideo.test.ts` and the sidebar tab tests pass on this branch.
Backport of #22075 to
cloud/1.59Automatically created by backport workflow.