Repository navigation
[backport cloud/1.59] fix(agent): name the tour card in onboarding step telemetry - #22557
Conversation
`agent_onboarding_step` only sent a position, so step 3 meant the canvas card before #22269 and the history card after it, and `finish` moved from step 4 to step 3. Funnels can't follow a card across a release. Each step event now also sends `card` (`intro`, `workflow`, `history`) and `total` (tour length). `step` and `action` are unchanged, so existing funnels keep working. Funnels built on events from before this change should split on app version. Linear: https://linear.app/comfyorg/issue/FRONT-3715 - `OnboardingCoach.test.ts`: all seven step-event cases failed before the change and pass after. - Telemetry registry, host sink and PostHog provider fixtures updated for the new fields. - `pnpm typecheck`, oxlint and oxfmt clean. (cherry picked from commit 56fbb46)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-11-01T03:51:36.613Z",
"gitSha": "58644ad5d6204a721d28faa6d14286366ede59b8",
"branch": "backport-22498-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2006.811999999968,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.89,
"layouts": 9,
"layoutDurationMs": 2.8729999999999998,
"taskDurationMs": 511.55299999999994,
"heapDeltaBytes": 4706068,
"heapUsedBytes": 74837404,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 7.924,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2039.1810000000987,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.77,
"layouts": 9,
"layoutDurationMs": 2.921,
"taskDurationMs": 522.3760000000001,
"heapDeltaBytes": 5380996,
"heapUsedBytes": 75263568,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 8.616999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1772.527000000025,
"styleRecalcs": 75,
"styleRecalcDurationMs": 11.583,
"layouts": 10,
"layoutDurationMs": 2.4800000000000004,
"taskDurationMs": 860.465,
"heapDeltaBytes": 23315976,
"heapUsedBytes": 84858668,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 158.966,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1744.1949999999906,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.931000000000001,
"layouts": 9,
"layoutDurationMs": 2.636,
"taskDurationMs": 875.139,
"heapDeltaBytes": 22365192,
"heapUsedBytes": 83851656,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 159.049,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.294000000014,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.731,
"layouts": 11,
"layoutDurationMs": 3.469,
"taskDurationMs": 404.351,
"heapDeltaBytes": 23890840,
"heapUsedBytes": 85383720,
"domNodes": 56,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 10.372,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.650999999957,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.804,
"layouts": 10,
"layoutDurationMs": 2.7870000000000004,
"taskDurationMs": 419.956,
"heapDeltaBytes": 940892,
"heapUsedBytes": 70710348,
"domNodes": 56,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 10.665999999999999,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 661.0360000000242,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.951,
"layouts": 10,
"layoutDurationMs": 2.524,
"taskDurationMs": 492.2369999999999,
"heapDeltaBytes": 7089432,
"heapUsedBytes": 76941064,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 168.19600000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 690.5169999999998,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.431,
"layouts": 7,
"layoutDurationMs": 2.2150000000000003,
"taskDurationMs": 492.43800000000005,
"heapDeltaBytes": 5242976,
"heapUsedBytes": 66642336,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 173.857,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66341463414634,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1193.7030000000277,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 897.1800000000001,
"heapDeltaBytes": -1914532,
"heapUsedBytes": 75475456,
"domNodes": -191,
"jsHeapTotalBytes": 13639680,
"scriptDurationMs": 66.88700000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 523,
"frameDurationMs": 32.42972972972972,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1229.2199999999411,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 924.081,
"heapDeltaBytes": -1051000,
"heapUsedBytes": 75156296,
"domNodes": -191,
"jsHeapTotalBytes": 15212544,
"scriptDurationMs": 75.062,
"eventListeners": -106,
"totalBlockingTimeMs": 554,
"frameDurationMs": 33.32972972972973,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 883.2330000000184,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.5969999999999,
"heapDeltaBytes": -8674544,
"heapUsedBytes": 86711328,
"domNodes": -191,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 167.20999999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 233,
"frameDurationMs": 25.234285714285708,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 878.2619999999497,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.5340000000001,
"heapDeltaBytes": -28295964,
"heapUsedBytes": 66344628,
"domNodes": -191,
"jsHeapTotalBytes": 3801088,
"scriptDurationMs": 170.99900000000002,
"eventListeners": -106,
"totalBlockingTimeMs": 225,
"frameDurationMs": 24.533333333333353,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11311.865000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10426.432999999999,
"heapDeltaBytes": 80412460,
"heapUsedBytes": 153336260,
"domNodes": -257,
"jsHeapTotalBytes": 73265152,
"scriptDurationMs": 8374.982,
"eventListeners": -68,
"totalBlockingTimeMs": 1390,
"frameDurationMs": 32.61181556195965,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10535.617999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9768.298999999999,
"heapDeltaBytes": 58652860,
"heapUsedBytes": 133606464,
"domNodes": -257,
"jsHeapTotalBytes": 68284416,
"scriptDurationMs": 7827.319,
"eventListeners": -68,
"totalBlockingTimeMs": 1039,
"frameDurationMs": 31.348214285714285,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10043.267000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9224.024,
"heapDeltaBytes": 67665444,
"heapUsedBytes": 142281872,
"domNodes": -257,
"jsHeapTotalBytes": 62517248,
"scriptDurationMs": 7405.873,
"eventListeners": -68,
"totalBlockingTimeMs": 804,
"frameDurationMs": 31.216408668730654,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11151.365000000056,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10386.108999999999,
"heapDeltaBytes": 93144856,
"heapUsedBytes": 166521016,
"domNodes": -257,
"jsHeapTotalBytes": 75100160,
"scriptDurationMs": 8471.021999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 1423,
"frameDurationMs": 32.03908045977012,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 245.69599999998104,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.226999999999999,
"layouts": 12,
"layoutDurationMs": 4.503,
"taskDurationMs": 226.279,
"heapDeltaBytes": 2246196,
"heapUsedBytes": 71630364,
"domNodes": 721,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 9,
"eventListeners": 73,
"totalBlockingTimeMs": 3,
"frameDurationMs": 24.99000000000001,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 287.0860000000448,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.481000000000002,
"layouts": 10,
"layoutDurationMs": 2.9739999999999998,
"taskDurationMs": 234.57600000000002,
"heapDeltaBytes": -17267616,
"heapUsedBytes": 58059428,
"domNodes": 936,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 8.718000000000002,
"eventListeners": -640,
"totalBlockingTimeMs": 5,
"frameDurationMs": 23.600000000000023,
"p95FrameDurationMs": 99.90000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2056.173000000001,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.419,
"layouts": 8,
"layoutDurationMs": 1.936,
"taskDurationMs": 647.577,
"heapDeltaBytes": -10416488,
"heapUsedBytes": 63468048,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 38.11599999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.6049999999905,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3829999999999996,
"layouts": 8,
"layoutDurationMs": 2.3160000000000003,
"taskDurationMs": 624.971,
"heapDeltaBytes": -10405936,
"heapUsedBytes": 64784792,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 31.583000000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2542.552999999998,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.277,
"layouts": 7,
"layoutDurationMs": 1.5990000000000002,
"taskDurationMs": 1695.6330000000003,
"heapDeltaBytes": 5657852,
"heapUsedBytes": 80874556,
"domNodes": -257,
"jsHeapTotalBytes": 5332992,
"scriptDurationMs": 829.419,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601307189542,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2592.6980000000412,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.088,
"layouts": 7,
"layoutDurationMs": 1.704,
"taskDurationMs": 1726.7730000000001,
"heapDeltaBytes": 10475292,
"heapUsedBytes": 85880404,
"domNodes": -257,
"jsHeapTotalBytes": 5595136,
"scriptDurationMs": 852.5849999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6658064516129,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3762.0299999999816,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.971,
"layouts": 63,
"layoutDurationMs": 9.811,
"taskDurationMs": 1779.751,
"heapDeltaBytes": -1793936,
"heapUsedBytes": 74918944,
"domNodes": -233,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 771.0989999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66592920353982,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3766.0529999999426,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.121,
"layouts": 65,
"layoutDurationMs": 10.357,
"taskDurationMs": 1783.867,
"heapDeltaBytes": -3267900,
"heapUsedBytes": 74933668,
"domNodes": -233,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 777.828,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66592920353982,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3058.4579999999733,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.7219999999999995,
"layouts": 5,
"layoutDurationMs": 1.3349999999999997,
"taskDurationMs": 1900.5639999999999,
"heapDeltaBytes": -5940552,
"heapUsedBytes": 73272888,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 941.948,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.757377049180324,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 3113.2929999999988,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.724,
"layouts": 5,
"layoutDurationMs": 1.317,
"taskDurationMs": 1982.703,
"heapDeltaBytes": -7519268,
"heapUsedBytes": 73997360,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 989.4739999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755913978494625,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3123.2800000000225,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9069999999999998,
"layouts": 8,
"layoutDurationMs": 2.061,
"taskDurationMs": 796.578,
"heapDeltaBytes": -11743132,
"heapUsedBytes": 81387244,
"domNodes": -257,
"jsHeapTotalBytes": 6717440,
"scriptDurationMs": 384.757,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66577540106952,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3120.2429999999595,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.084,
"layouts": 8,
"layoutDurationMs": 1.9979999999999998,
"taskDurationMs": 801.68,
"heapDeltaBytes": 9838888,
"heapUsedBytes": 87188492,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 393.91499999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666310160427805,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2031.8110000000047,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.7760000000000007,
"layouts": 7,
"layoutDurationMs": 1.6340000000000001,
"taskDurationMs": 624.5500000000001,
"heapDeltaBytes": -14496744,
"heapUsedBytes": 66411408,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 34.609,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.0910000000467,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.111,
"layouts": 7,
"layoutDurationMs": 1.9509999999999996,
"taskDurationMs": 631.563,
"heapDeltaBytes": -7771396,
"heapUsedBytes": 70525740,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 31.933999999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2783.2209999999977,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.497999999999998,
"layouts": 6,
"layoutDurationMs": 1.389,
"taskDurationMs": 590.292,
"heapDeltaBytes": 5348132,
"heapUsedBytes": 83698736,
"domNodes": -250,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 196.88799999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666467065868265,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2775.069999999914,
"styleRecalcs": 25,
"styleRecalcDurationMs": 11.992999999999999,
"layouts": 6,
"layoutDurationMs": 1.5209999999999997,
"taskDurationMs": 591.016,
"heapDeltaBytes": -4829492,
"heapUsedBytes": 71956384,
"domNodes": -254,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 185.167,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66566265060241,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3273.0439999999703,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.5330000000000006,
"layouts": 6,
"layoutDurationMs": 1.3909999999999998,
"taskDurationMs": 958.6619999999999,
"heapDeltaBytes": -14923880,
"heapUsedBytes": 61634244,
"domNodes": -277,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 378.15999999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666326530612245,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3242.211999999995,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.5310000000000001,
"layouts": 6,
"layoutDurationMs": 1.3750000000000004,
"taskDurationMs": 933.7779999999999,
"heapDeltaBytes": -8285352,
"heapUsedBytes": 70055800,
"domNodes": -257,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 359.227,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6659793814433,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.8219999999942,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.881,
"layouts": 9,
"layoutDurationMs": 2.347,
"taskDurationMs": 438.41999999999996,
"heapDeltaBytes": 1098664,
"heapUsedBytes": 63403028,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 145.17,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 614.5789999999351,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.803,
"layouts": 9,
"layoutDurationMs": 2.4760000000000004,
"taskDurationMs": 442.01500000000004,
"heapDeltaBytes": -1436032,
"heapUsedBytes": 60828548,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 147.254,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2022.0580000000155,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7020000000000004,
"layouts": 9,
"layoutDurationMs": 2.535,
"taskDurationMs": 516.9290000000001,
"heapDeltaBytes": 5970592,
"heapUsedBytes": 78009980,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 7.774000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2014.4319999999425,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2880000000000003,
"layouts": 9,
"layoutDurationMs": 2.464,
"taskDurationMs": 505.55300000000005,
"heapDeltaBytes": 2939324,
"heapUsedBytes": 65226672,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 7.502999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1756.510999999989,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.125000000000002,
"layouts": 9,
"layoutDurationMs": 2.7760000000000002,
"taskDurationMs": 857.591,
"heapDeltaBytes": 20169296,
"heapUsedBytes": 81515804,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 113.904,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.4109999999791,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.347999999999999,
"layouts": 9,
"layoutDurationMs": 2.537,
"taskDurationMs": 811.51,
"heapDeltaBytes": 18447952,
"heapUsedBytes": 80831028,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 108.37299999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1453.3040000000028,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.018000000000004,
"layouts": 5,
"layoutDurationMs": 14.199,
"taskDurationMs": 1084.5029999999997,
"heapDeltaBytes": 37980500,
"heapUsedBytes": 113896232,
"domNodes": 16030,
"jsHeapTotalBytes": 8523776,
"scriptDurationMs": 32.678,
"eventListeners": 3246,
"totalBlockingTimeMs": 166,
"frameDurationMs": 19.55466666666666,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9467.818999999963,
"styleRecalcs": 249,
"styleRecalcDurationMs": 26.587,
"layouts": 7,
"layoutDurationMs": 1.8339999999999999,
"taskDurationMs": 5903.886,
"heapDeltaBytes": 9989212,
"heapUsedBytes": 85387644,
"domNodes": -257,
"jsHeapTotalBytes": 5300224,
"scriptDurationMs": 2726.099,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665961199294532,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9237.668999999983,
"styleRecalcs": 250,
"styleRecalcDurationMs": 26.943,
"layouts": 7,
"layoutDurationMs": 1.7340000000000002,
"taskDurationMs": 5899.143,
"heapDeltaBytes": -1490064,
"heapUsedBytes": 76122768,
"domNodes": -257,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 2693.643,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66600361663653,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23085.447999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22473.572999999997,
"heapDeltaBytes": -36280624,
"heapUsedBytes": 265062436,
"domNodes": -3343,
"jsHeapTotalBytes": 13623296,
"scriptDurationMs": 314.641,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.32282793867122,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 23082.30600000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22456.721999999998,
"heapDeltaBytes": -19062652,
"heapUsedBytes": 281760444,
"domNodes": -3343,
"jsHeapTotalBytes": 12312576,
"scriptDurationMs": 333.822,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.83713298791019,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 27802.41699999999,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.41900000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27456.488,
"heapDeltaBytes": -8201624,
"heapUsedBytes": 274262696,
"domNodes": -3343,
"jsHeapTotalBytes": 13881344,
"scriptDurationMs": 952.549,
"eventListeners": -651,
"totalBlockingTimeMs": 27,
"frameDurationMs": 51.28948339483395,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 27962.301000000025,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.10500000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27594.755999999998,
"heapDeltaBytes": -13204532,
"heapUsedBytes": 264732520,
"domNodes": -3343,
"jsHeapTotalBytes": 13357056,
"scriptDurationMs": 880.809,
"eventListeners": -651,
"totalBlockingTimeMs": 3,
"frameDurationMs": 52.83327032136106,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8173.1259999999675,
"styleRecalcs": 20,
"styleRecalcDurationMs": 65.24199999999999,
"layouts": 20,
"layoutDurationMs": 22.677000000000003,
"taskDurationMs": 8045.033,
"heapDeltaBytes": -28344340,
"heapUsedBytes": 273662040,
"domNodes": -3343,
"jsHeapTotalBytes": 20172800,
"scriptDurationMs": 119.841,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.20462427745666,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8237.533999999981,
"styleRecalcs": 20,
"styleRecalcDurationMs": 86.00699999999998,
"layouts": 20,
"layoutDurationMs": 22.618999999999986,
"taskDurationMs": 8113.267999999998,
"heapDeltaBytes": -10596596,
"heapUsedBytes": 271603060,
"domNodes": -3343,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 142.59199999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.86627906976745,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11363.770999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11011.106,
"heapDeltaBytes": 18782948,
"heapUsedBytes": 286390668,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 148.28699999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.19379310344828,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11423.876999999948,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11170.012000000002,
"heapDeltaBytes": -16066816,
"heapUsedBytes": 265967732,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 152.04100000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.6270462633452,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "workflow-execution",
"durationMs": 148.97600000000466,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.939,
"layouts": 10,
"layoutDurationMs": 4.486000000000001,
"taskDurationMs": 114.175,
"heapDeltaBytes": 4797256,
"heapUsedBytes": 64199000,
"domNodes": 109,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.593,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 116.6489999999385,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.165,
"layouts": 8,
"layoutDurationMs": 3.557,
"taskDurationMs": 100.69900000000001,
"heapDeltaBytes": -13356320,
"heapUsedBytes": 59885848,
"domNodes": 125,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 6.336000000000001,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142844,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 498.9850000000615,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.662,
"layouts": 76,
"layoutDurationMs": 15.678999999999998,
"taskDurationMs": 461.06199999999995,
"heapDeltaBytes": -4189804,
"heapUsedBytes": 39896084,
"domNodes": 4,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 225.284,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 453.9839999999913,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.635,
"layouts": 76,
"layoutDurationMs": 14.302,
"taskDurationMs": 409.754,
"heapDeltaBytes": -4633640,
"heapUsedBytes": 37982008,
"domNodes": 4,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 198.573,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 508.4320000000844,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.006,
"layouts": 76,
"layoutDurationMs": 14.983,
"taskDurationMs": 477.42699999999996,
"heapDeltaBytes": 1310768,
"heapUsedBytes": 98568748,
"domNodes": 4,
"jsHeapTotalBytes": 1052672,
"scriptDurationMs": 193.797,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 559.8159999999552,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.777,
"layouts": 76,
"layoutDurationMs": 14.551,
"taskDurationMs": 525.461,
"heapDeltaBytes": 460932,
"heapUsedBytes": 91146168,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 219.639,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageLine coverage: 60.1% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3127 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3f63a38b78bd59debc8c5c0e81c3c09182d8d30d
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (238)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.59 #22557 +/- ##
=============================================
Coverage ? 87.21%
=============================================
Files ? 3033
Lines ? 159196
Branches ? 42482
=============================================
Hits ? 138842
Misses ? 19674
Partials ? 680
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Backport of #22498; the only conflict was the telemetry import path, kept on this branch's @/platform/telemetry. LGTM.
Backport of #22498 to
cloud/1.59. The automatic backport hit a conflict.The only conflict was the telemetry import path in
useOnboarding.ts. Main imports from@comfyorg/telemetry, and this branch still uses@/platform/telemetry. I kept this branch's path and added theAgentOnboardingCardtype import. No other line differs from #22498.Linear: https://linear.app/comfyorg/issue/FRONT-3715