Repository navigation
[backport core/1.59] fix(agent): name the tour card in onboarding step telemetry - #22556
Conversation
`agent_onboarding_step` only sent a position, so step 3 meant the canvas card before #22269 and the history card after it, and `finish` moved from step 4 to step 3. Funnels can't follow a card across a release. Each step event now also sends `card` (`intro`, `workflow`, `history`) and `total` (tour length). `step` and `action` are unchanged, so existing funnels keep working. Funnels built on events from before this change should split on app version. Linear: https://linear.app/comfyorg/issue/FRONT-3715 - `OnboardingCoach.test.ts`: all seven step-event cases failed before the change and pass after. - Telemetry registry, host sink and PostHog provider fixtures updated for the new fields. - `pnpm typecheck`, oxlint and oxfmt clean. (cherry picked from commit 56fbb46)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-11-01T03:51:44.973Z",
"gitSha": "aa80a5e096c43be2892bbc68d2c3c74c8a1a588e",
"branch": "backport-22498-to-core-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.9700000000003,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.082,
"layouts": 9,
"layoutDurationMs": 3.0780000000000003,
"taskDurationMs": 586.3130000000001,
"heapDeltaBytes": 5097432,
"heapUsedBytes": 75046052,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 11.953000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2039.7830000000567,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.006,
"layouts": 10,
"layoutDurationMs": 3.433,
"taskDurationMs": 592.377,
"heapDeltaBytes": 1763464,
"heapUsedBytes": 63220372,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 12.478000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1773.680000000013,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.776,
"layouts": 9,
"layoutDurationMs": 2.832,
"taskDurationMs": 888.292,
"heapDeltaBytes": 22744964,
"heapUsedBytes": 84018888,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 162.84199999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1822.6540000000568,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.122,
"layouts": 9,
"layoutDurationMs": 3.4939999999999998,
"taskDurationMs": 927.4340000000001,
"heapDeltaBytes": 23315240,
"heapUsedBytes": 84273516,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 170.099,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871563,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1702.1139999999946,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.886,
"layouts": 8,
"layoutDurationMs": 2.6860000000000004,
"taskDurationMs": 485.448,
"heapDeltaBytes": -37468,
"heapUsedBytes": 60704316,
"domNodes": 56,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 15.033000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.2799999999688,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.183999999999999,
"layouts": 10,
"layoutDurationMs": 3.158,
"taskDurationMs": 449.40399999999994,
"heapDeltaBytes": -477876,
"heapUsedBytes": 60579864,
"domNodes": 56,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 13.714,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 695.524000000006,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.9259999999999997,
"layouts": 9,
"layoutDurationMs": 2.7079999999999997,
"taskDurationMs": 504.66900000000004,
"heapDeltaBytes": 7658008,
"heapUsedBytes": 77276964,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 176.785,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 750.5749999999125,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.19,
"layouts": 10,
"layoutDurationMs": 3.0309999999999997,
"taskDurationMs": 524.3729999999999,
"heapDeltaBytes": 7021872,
"heapUsedBytes": 77494856,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 174.749,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909086,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1257.6779999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 968.9619999999999,
"heapDeltaBytes": -1832652,
"heapUsedBytes": 75234172,
"domNodes": -191,
"jsHeapTotalBytes": 15212544,
"scriptDurationMs": 75.30600000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 560,
"frameDurationMs": 33.78378378378377,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1219.947999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 930.2730000000001,
"heapDeltaBytes": -977348,
"heapUsedBytes": 75252860,
"domNodes": -191,
"jsHeapTotalBytes": 14426112,
"scriptDurationMs": 77.42200000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 536,
"frameDurationMs": 32.88108108108108,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 911.6330000000232,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.7679999999996,
"heapDeltaBytes": -13631780,
"heapUsedBytes": 66897268,
"domNodes": -191,
"jsHeapTotalBytes": 1441792,
"scriptDurationMs": 172.57100000000003,
"eventListeners": -106,
"totalBlockingTimeMs": 233,
"frameDurationMs": 24.775675675675647,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 891.4080000000695,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.3519999999999,
"heapDeltaBytes": -27707168,
"heapUsedBytes": 66883668,
"domNodes": -191,
"jsHeapTotalBytes": 3538944,
"scriptDurationMs": 175.472,
"eventListeners": -106,
"totalBlockingTimeMs": 230,
"frameDurationMs": 24.997222222222213,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 12403.898999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11523.941,
"heapDeltaBytes": 84806572,
"heapUsedBytes": 159346272,
"domNodes": -257,
"jsHeapTotalBytes": 88207360,
"scriptDurationMs": 9374.914,
"eventListeners": -68,
"totalBlockingTimeMs": 1773,
"frameDurationMs": 32.45942408376963,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11270.61500000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10491.797999999999,
"heapDeltaBytes": 81729624,
"heapUsedBytes": 155038752,
"domNodes": -257,
"jsHeapTotalBytes": 74838016,
"scriptDurationMs": 8542.907,
"eventListeners": -68,
"totalBlockingTimeMs": 1370,
"frameDurationMs": 31.919491525423734,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11312.213000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10502.243,
"heapDeltaBytes": 70786360,
"heapUsedBytes": 144329300,
"domNodes": -257,
"jsHeapTotalBytes": 77459456,
"scriptDurationMs": 8515.796,
"eventListeners": -68,
"totalBlockingTimeMs": 1375,
"frameDurationMs": 31.78707865168539,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10824.111000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10032.06,
"heapDeltaBytes": 65774680,
"heapUsedBytes": 138671288,
"domNodes": -257,
"jsHeapTotalBytes": 72740864,
"scriptDurationMs": 8061.97,
"eventListeners": -68,
"totalBlockingTimeMs": 1024,
"frameDurationMs": 31.812352941176474,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 232.10399999999254,
"styleRecalcs": 22,
"styleRecalcDurationMs": 13.059999999999999,
"layouts": 9,
"layoutDurationMs": 2.603,
"taskDurationMs": 169.263,
"heapDeltaBytes": 14608192,
"heapUsedBytes": 73911096,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.218,
"eventListeners": 205,
"totalBlockingTimeMs": 5,
"frameDurationMs": 23.329999999999973,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 238.24999999999363,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.619999999999997,
"layouts": 8,
"layoutDurationMs": 2.8460000000000005,
"taskDurationMs": 177.815,
"heapDeltaBytes": 14604036,
"heapUsedBytes": 74102500,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.830999999999998,
"eventListeners": 205,
"totalBlockingTimeMs": 5,
"frameDurationMs": 23.329999999999973,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2057.2250000000167,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7750000000000004,
"layouts": 8,
"layoutDurationMs": 2.767,
"taskDurationMs": 724.729,
"heapDeltaBytes": 12077120,
"heapUsedBytes": 85175784,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 37.269,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2056.491000000051,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.683,
"layouts": 8,
"layoutDurationMs": 2.5590000000000006,
"taskDurationMs": 701.1909999999999,
"heapDeltaBytes": -10701208,
"heapUsedBytes": 64335916,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 35.96600000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2764.471999999955,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.020999999999999,
"layouts": 8,
"layoutDurationMs": 2.1929999999999996,
"taskDurationMs": 1774.616,
"heapDeltaBytes": -1501532,
"heapUsedBytes": 75752880,
"domNodes": -257,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 854.0310000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76727272727273,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2671.925999999985,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.086,
"layouts": 7,
"layoutDurationMs": 1.9689999999999999,
"taskDurationMs": 1752.0739999999998,
"heapDeltaBytes": -7908836,
"heapUsedBytes": 71447220,
"domNodes": -257,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 824.885,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666249999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3714.413000000036,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.927999999999999,
"layouts": 64,
"layoutDurationMs": 11.072000000000001,
"taskDurationMs": 1781.3819999999998,
"heapDeltaBytes": 5123864,
"heapUsedBytes": 85573692,
"domNodes": 24,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 782.361,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665765765765766,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3805.291999999895,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.107999999999999,
"layouts": 65,
"layoutDurationMs": 11.267000000000001,
"taskDurationMs": 1857.915,
"heapDeltaBytes": 7223116,
"heapUsedBytes": 78336380,
"domNodes": -233,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 817.092,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66578947368421,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3167.933000000005,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.307,
"layouts": 6,
"layoutDurationMs": 1.9259999999999997,
"taskDurationMs": 2003.221,
"heapDeltaBytes": 22744904,
"heapUsedBytes": 102485500,
"domNodes": 0,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 983.0439999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.93068783068783,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3200.1209999999674,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.5680000000000005,
"layouts": 5,
"layoutDurationMs": 1.2999999999999996,
"taskDurationMs": 2097.548,
"heapDeltaBytes": -4579012,
"heapUsedBytes": 76563860,
"domNodes": -257,
"jsHeapTotalBytes": 6311936,
"scriptDurationMs": 1009.2339999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.841578947368426,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3083.719000000002,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.8670000000000007,
"layouts": 6,
"layoutDurationMs": 1.9119999999999997,
"taskDurationMs": 807.0569999999999,
"heapDeltaBytes": -16967032,
"heapUsedBytes": 59499180,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 362.03100000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665405405405405,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3098.5940000000483,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9369999999999994,
"layouts": 7,
"layoutDurationMs": 1.9140000000000004,
"taskDurationMs": 828.533,
"heapDeltaBytes": -6693012,
"heapUsedBytes": 64683308,
"domNodes": -257,
"jsHeapTotalBytes": 1175552,
"scriptDurationMs": 379.36800000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258063,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2045.4019999999673,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.372,
"layouts": 7,
"layoutDurationMs": 1.6810000000000003,
"taskDurationMs": 757.2639999999999,
"heapDeltaBytes": 6728896,
"heapUsedBytes": 86156740,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 44.178999999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2045.6839999999374,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.2230000000000003,
"layouts": 7,
"layoutDurationMs": 1.744,
"taskDurationMs": 711.9929999999999,
"heapDeltaBytes": -18669880,
"heapUsedBytes": 74295748,
"domNodes": -257,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 34.815,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2754.6140000000037,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.167000000000002,
"layouts": 6,
"layoutDurationMs": 2.164,
"taskDurationMs": 646.378,
"heapDeltaBytes": -13475440,
"heapUsedBytes": 79593000,
"domNodes": -252,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 208.646,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666060606060604,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2837.0570000000157,
"styleRecalcs": 27,
"styleRecalcDurationMs": 12.310999999999998,
"layouts": 7,
"layoutDurationMs": 2.0570000000000004,
"taskDurationMs": 633.6650000000001,
"heapDeltaBytes": 780868,
"heapUsedBytes": 80968728,
"domNodes": -245,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 203.69799999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665882352941175,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3369.839000000013,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.4930000000000003,
"layouts": 5,
"layoutDurationMs": 1.6100000000000003,
"taskDurationMs": 999.387,
"heapDeltaBytes": 643820,
"heapUsedBytes": 79060804,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 393.298,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665841584158414,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3360.704999999996,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.7950000000000006,
"layouts": 6,
"layoutDurationMs": 1.7679999999999996,
"taskDurationMs": 1025.912,
"heapDeltaBytes": 4446116,
"heapUsedBytes": 80886940,
"domNodes": -257,
"jsHeapTotalBytes": 6680576,
"scriptDurationMs": 422.861,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.748756218905474,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 629.0429999999674,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.884,
"layouts": 8,
"layoutDurationMs": 2.4259999999999997,
"taskDurationMs": 452.978,
"heapDeltaBytes": -1467060,
"heapUsedBytes": 60806056,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 148.32899999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 619.6639999999434,
"styleRecalcs": 43,
"styleRecalcDurationMs": 3.9430000000000005,
"layouts": 5,
"layoutDurationMs": 1.597,
"taskDurationMs": 451.12,
"heapDeltaBytes": 1161680,
"heapUsedBytes": 63040016,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 146.845,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864864,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2023.1870000000072,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.837,
"layouts": 9,
"layoutDurationMs": 2.8930000000000002,
"taskDurationMs": 595.235,
"heapDeltaBytes": 2696552,
"heapUsedBytes": 65271032,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 11.820999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.7509999999847,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.2579999999999996,
"layouts": 10,
"layoutDurationMs": 3.2800000000000002,
"taskDurationMs": 621.3729999999999,
"heapDeltaBytes": 5255440,
"heapUsedBytes": 76965848,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 11.17,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.158000000007,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.801,
"layouts": 9,
"layoutDurationMs": 3.3519999999999994,
"taskDurationMs": 859.7650000000001,
"heapDeltaBytes": 18749732,
"heapUsedBytes": 80715688,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 112.34799999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.3860000000186,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.572000000000001,
"layouts": 8,
"layoutDurationMs": 2.3299999999999996,
"taskDurationMs": 843.5610000000001,
"heapDeltaBytes": 17553052,
"heapUsedBytes": 79437396,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 114.58500000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1469.1050000000132,
"styleRecalcs": 19,
"styleRecalcDurationMs": 22.708000000000006,
"layouts": 5,
"layoutDurationMs": 14.274,
"taskDurationMs": 1165.68,
"heapDeltaBytes": 14032924,
"heapUsedBytes": 117305724,
"domNodes": 16030,
"jsHeapTotalBytes": 15863808,
"scriptDurationMs": 33.336,
"eventListeners": 3246,
"totalBlockingTimeMs": 162,
"frameDurationMs": 19.775999999999996,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10137.73299999997,
"styleRecalcs": 249,
"styleRecalcDurationMs": 28.92,
"layouts": 7,
"layoutDurationMs": 2.1679999999999997,
"taskDurationMs": 6186.481000000001,
"heapDeltaBytes": -6919080,
"heapUsedBytes": 70691228,
"domNodes": -257,
"jsHeapTotalBytes": 3727360,
"scriptDurationMs": 2773.1639999999998,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611842105263,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10059.00699999995,
"styleRecalcs": 249,
"styleRecalcDurationMs": 29.305000000000003,
"layouts": 7,
"layoutDurationMs": 2.1040000000000005,
"taskDurationMs": 6235.7789999999995,
"heapDeltaBytes": -15552240,
"heapUsedBytes": 76305548,
"domNodes": -257,
"jsHeapTotalBytes": 6123520,
"scriptDurationMs": 2825.799,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.693853820598008,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23375.981000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22909.739999999998,
"heapDeltaBytes": -25454236,
"heapUsedBytes": 257123304,
"domNodes": -3343,
"jsHeapTotalBytes": 11526144,
"scriptDurationMs": 323.031,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.77783595113438,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 23858.84299999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23201.186999999998,
"heapDeltaBytes": -1905420,
"heapUsedBytes": 275114100,
"domNodes": -3343,
"jsHeapTotalBytes": 9949184,
"scriptDurationMs": 357.368,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.261245674740486,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 28595.754999999997,
"styleRecalcs": 181,
"styleRecalcDurationMs": 21.919999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28250.531,
"heapDeltaBytes": -23024036,
"heapUsedBytes": 253472740,
"domNodes": -3343,
"jsHeapTotalBytes": 15196160,
"scriptDurationMs": 909.44,
"eventListeners": -651,
"totalBlockingTimeMs": 8,
"frameDurationMs": 53.928679245283014,
"p95FrameDurationMs": 116.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 28403.136000000017,
"styleRecalcs": 181,
"styleRecalcDurationMs": 21.21500000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27993.297000000006,
"heapDeltaBytes": -25674004,
"heapUsedBytes": 256302096,
"domNodes": -3347,
"jsHeapTotalBytes": 18341888,
"scriptDurationMs": 898.305,
"eventListeners": -651,
"totalBlockingTimeMs": 50,
"frameDurationMs": 52.590555555555554,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8498.117999999977,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.660999999999994,
"layouts": 20,
"layoutDurationMs": 23.580000000000016,
"taskDurationMs": 8376.597,
"heapDeltaBytes": -21942144,
"heapUsedBytes": 269378932,
"domNodes": -3343,
"jsHeapTotalBytes": 20701184,
"scriptDurationMs": 134.45000000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.02033898305084,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8457.595999999967,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.61799999999998,
"layouts": 20,
"layoutDurationMs": 23.507,
"taskDurationMs": 8334.545,
"heapDeltaBytes": 5082792,
"heapUsedBytes": 281271632,
"domNodes": -3343,
"jsHeapTotalBytes": 23846912,
"scriptDurationMs": 156.90599999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.73841807909605,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11670.83100000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11460.961000000001,
"heapDeltaBytes": -15399292,
"heapUsedBytes": 257152608,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 156.61,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.22332155477032,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11851.524999999925,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11667.024000000001,
"heapDeltaBytes": 12497632,
"heapUsedBytes": 283667884,
"domNodes": 0,
"jsHeapTotalBytes": -1048576,
"scriptDurationMs": 166.555,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.14444444444444,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 114.33199999999033,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.105999999999998,
"layouts": 7,
"layoutDurationMs": 3.299,
"taskDurationMs": 89.241,
"heapDeltaBytes": 4787088,
"heapUsedBytes": 72750596,
"domNodes": 120,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.639999999999999,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67142857142861,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 133.32500000001346,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.084,
"layouts": 9,
"layoutDurationMs": 3.934,
"taskDurationMs": 93.30600000000001,
"heapDeltaBytes": 4627192,
"heapUsedBytes": 65518888,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.333999999999999,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 582.1940000000723,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.639,
"layouts": 76,
"layoutDurationMs": 16.759,
"taskDurationMs": 541.362,
"heapDeltaBytes": -3048992,
"heapUsedBytes": 41067632,
"domNodes": 4,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 272.731,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 563.5569999999461,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.664,
"layouts": 76,
"layoutDurationMs": 17.644,
"taskDurationMs": 515.1759999999999,
"heapDeltaBytes": -3591032,
"heapUsedBytes": 41645592,
"domNodes": 4,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 250.645,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 572.7979999999206,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.9780000000000002,
"layouts": 76,
"layoutDurationMs": 15.143,
"taskDurationMs": 526.696,
"heapDeltaBytes": 1487408,
"heapUsedBytes": 99629224,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 212.626,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 611.1529999999448,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.145,
"layouts": 76,
"layoutDurationMs": 15.602,
"taskDurationMs": 576.2799999999999,
"heapDeltaBytes": 1462460,
"heapUsedBytes": 104131004,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 237.028,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 60.2% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3127 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since b166f4a6bb47ceec235ce760c6e817dee34d913c
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (231)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.59 #22556 +/- ##
=============================================
- Coverage 87.15% 87.14% -0.01%
=============================================
Files 3029 3029
Lines 159001 159001
Branches 42414 42414
=============================================
- Hits 138578 138565 -13
- Misses 19745 19758 +13
Partials 678 678
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Backport of #22498; the only conflict was the telemetry import path, kept on this branch's @/platform/telemetry. LGTM.
Backport of #22498 to
core/1.59. The automatic backport hit a conflict.The only conflict was the telemetry import path in
useOnboarding.ts. Main imports from@comfyorg/telemetry, and this branch still uses@/platform/telemetry. I kept this branch's path and added theAgentOnboardingCardtype import. No other line differs from #22498.Linear: https://linear.app/comfyorg/issue/FRONT-3715