Repository navigation
fix(mask-editor): synchronize document history and rotated dimensions #22549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
223a055
b7bdf7a
17d5c1f
988737c
0427f1b
b791e40
0631a28
2390613
1549a2e
21f7390
244c167
859921a
ec1bdf8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -61,7 +61,7 @@ const currentTool = computed(() => store.currentTool) | |
|
|
||
| const zoomText = computed(() => `${Math.round(store.displayZoomRatio * 100)}%`) | ||
| const dimensionsText = computed(() => { | ||
| const img = store.image | ||
| const img = store.canvasHistory.dimensions ?? store.image | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion:
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added the rotated-document row to the existing dimensions-label table in a56fc44: history is 600×800 while the original image remains 800×600. It asserts the displayed 600×800 label and fails when the history-dimensions preference is removed. |
||
| return img ? `${img.width}x${img.height}` : ' ' | ||
| }) | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: This changes behavior: a cancelled pointer (an OS gesture, palm rejection, or touch-action taking over) now ends the stroke through
toolManager.handlePointerUp. Nothing pins it.PointerZone.test.tsalready has the mockedtoolManager. Could we add a row that firespointercancelon the zone and expectshandlePointerUpto be called with that event? It should fail without this line. The PR description should also mention which symptom this fixes (a stroke stuck in the drawing state?), because the verification section only covers the revision and rotation regressions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
pointercancel → handlePointerUpto the existing PointerZone event table in a56fc44. The test dispatches a real PointerEvent and asserts that the same event reaches the tool manager. It fails when the production pointercancel binding is removed. The PR description now includes cancellation ending an active stroke; native validation passes 403 package and 179 frontend tests.