Skip to content

[backport cloud/1.59] offer a deployment for missing custom nodes (#21188) - #22538

Merged
benceruleanlu merged 1 commit into
bl/cloud-1.59-deployment-build-actionsfrom
bl/cloud-1.59-missing-node-deployment-offer
Nov 3, 2026
Merged

benceruleanlu merged 1 commit into
bl/cloud-1.59-deployment-build-actionsfrom
bl/cloud-1.59-missing-node-deployment-offer

Conversation

@benceruleanlu

@benceruleanlu benceruleanlu commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Summary

Backport of #21188 to cloud/1.59. Opening a workflow with missing custom nodes on Comfy Cloud offers deployment setup while retaining the Issues card and bounded listing waits.

Part 6 of 9 in the Cloud workflow deployment backport stack. Uses the release branch's UI and telemetry imports.

Verification

  • 56 focused tests passed on this individual stack layer.
  • Rebuilt on cloud/1.59 at 7482c071; application typecheck passes on every layer. The expanded stack, including deployment Start/Retry, passes 23,186 of 23,187 affected tests across 1,269 files; the one failure, in SignUpForm.test.ts, is intermittent and also fails on cloud/1.59 without this stack. Formatting, affected-file lint, dependency audit and pre-push checks pass.
  • The original feature was exercised against test cloud at cc9bd948, including a successful job after switching deployments. Browser QA has not been repeated on this release-branch build.

@benceruleanlu
benceruleanlu requested review from a team and dante01yoon as code owners October 31, 2026 22:24
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 2
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T22:26:37.685776Z 4e206d8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle: ⏳ Size data collection in progress…

⚡ Performance: ❌ 8 below 52 FPS target · ℹ️ No baseline — significance unavailable

❌ 8 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Details
Scenario timings

canvas-idle: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.6 MB heap
canvas-mouse-sweep: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.2 MB heap
canvas-zoom-sweep: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.3 MB heap
dom-widget-clipping: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.6 MB heap
dom-widget-order-dense-n200-w200-i120: 35.8 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 334ms TBT · 72.3 MB heap
dom-widget-order-sparse-n1000-w20-i120: 46.5 avg FPS · 39.9 P5 FPS ❌ (target: ≥52) · 103ms TBT · 66.3 MB heap
extension-clean-combined-draw: 45.0 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 15ms TBT · 104.9 MB heap
extension-rgthree-prototype-draw: 43.0 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 9ms TBT · 130.0 MB heap
large-combo-open: 43.4 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 65.0 MB heap
large-graph-idle: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.4 MB heap
large-graph-pan: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.4 MB heap
large-graph-zoom: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.3 MB heap
legacy-node-drag: 59.8 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.7 MB heap
minimap-geometry-cadence: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.9 MB heap
minimap-idle: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.7 MB heap
minimap-progress-execution-cadence: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.0 MB heap
minimap-topology-cadence: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.4 MB heap
subgraph-dom-widget-clipping: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.5 MB heap
subgraph-idle: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.2 MB heap
subgraph-mouse-sweep: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.1 MB heap
subgraph-transition-enter: 47.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 131ms TBT · 108.3 MB heap
viewport-pan-sweep: 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.7 MB heap
vue-large-graph-idle: 38.6 avg FPS · 24.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 275.4 MB heap
vue-large-graph-pan: 30.9 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 19ms TBT · 254.5 MB heap
vue-node-resize-workload: 31.8 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 261.1 MB heap
vue-zoom-out-idle: 41.2 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 243.2 MB heap
workflow-execution: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.6 MB heap
agent-composer-empty-conversation-typing: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 45.3 MB heap
agent-composer-long-conversation-typing: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.7 MB heap

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 2ms
canvas-idle: style recalc duration 2ms
canvas-idle: layout count 10
canvas-idle: style recalc count 10
canvas-idle: task duration 361ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 70.6 MB
canvas-idle: DOM nodes 0
canvas-idle: event listeners 0
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 2ms
canvas-mouse-sweep: style recalc duration 10ms
canvas-mouse-sweep: layout count 10
canvas-mouse-sweep: style recalc count 72
canvas-mouse-sweep: task duration 627ms
canvas-mouse-sweep: script duration 107ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 77.2 MB
canvas-mouse-sweep: DOM nodes 0
canvas-mouse-sweep: event listeners 6
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 2ms
canvas-zoom-sweep: style recalc duration 4ms
canvas-zoom-sweep: layout count 12
canvas-zoom-sweep: style recalc count 18
canvas-zoom-sweep: task duration 285ms
canvas-zoom-sweep: script duration 9ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 67.3 MB
canvas-zoom-sweep: DOM nodes 56
canvas-zoom-sweep: event listeners 43
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 2ms
dom-widget-clipping: style recalc duration 2ms
dom-widget-clipping: layout count 11
dom-widget-clipping: style recalc count 15
dom-widget-clipping: task duration 347ms
dom-widget-clipping: script duration 117ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 64.6 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 28ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 631ms
dom-widget-order-dense-n200-w200-i120: script duration 38ms
dom-widget-order-dense-n200-w200-i120: TBT 334ms
dom-widget-order-dense-n200-w200-i120: heap used 72.3 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -191
dom-widget-order-dense-n200-w200-i120: event listeners -107
dom-widget-order-sparse-n1000-w20-i120: avg frame time 21ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 337ms
dom-widget-order-sparse-n1000-w20-i120: script duration 95ms
dom-widget-order-sparse-n1000-w20-i120: TBT 103ms
dom-widget-order-sparse-n1000-w20-i120: heap used 66.3 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes -96
dom-widget-order-sparse-n1000-w20-i120: event listeners -54
extension-clean-combined-draw: avg frame time 22ms
extension-clean-combined-draw: p95 frame time 33ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 3
extension-clean-combined-draw: style recalc count 3
extension-clean-combined-draw: task duration 5623ms
extension-clean-combined-draw: script duration 4230ms
extension-clean-combined-draw: TBT 15ms
extension-clean-combined-draw: heap used 104.9 MB
extension-clean-combined-draw: DOM nodes -129
extension-clean-combined-draw: event listeners -35
extension-rgthree-prototype-draw: avg frame time 23ms
extension-rgthree-prototype-draw: p95 frame time 33ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 3
extension-rgthree-prototype-draw: style recalc count 3
extension-rgthree-prototype-draw: task duration 5675ms
extension-rgthree-prototype-draw: script duration 4237ms
extension-rgthree-prototype-draw: TBT 9ms
extension-rgthree-prototype-draw: heap used 130.0 MB
extension-rgthree-prototype-draw: DOM nodes -257
extension-rgthree-prototype-draw: event listeners -69
large-combo-open: avg frame time 23ms
large-combo-open: p95 frame time 67ms
large-combo-open: layout duration 3ms
large-combo-open: style recalc duration 11ms
large-combo-open: layout count 12
large-combo-open: style recalc count 23
large-combo-open: task duration 164ms
large-combo-open: script duration 8ms
large-combo-open: TBT 0ms
large-combo-open: heap used 65.0 MB
large-combo-open: DOM nodes -2315
large-combo-open: event listeners -574
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 2ms
large-graph-idle: style recalc duration 2ms
large-graph-idle: layout count 9
large-graph-idle: style recalc count 9
large-graph-idle: task duration 448ms
large-graph-idle: script duration 29ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 63.4 MB
large-graph-idle: DOM nodes -257
large-graph-idle: event listeners -69
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 3ms
large-graph-pan: style recalc duration 7ms
large-graph-pan: layout count 8
large-graph-pan: style recalc count 70
large-graph-pan: task duration 1182ms
large-graph-pan: script duration 546ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 59.4 MB
large-graph-pan: DOM nodes -257
large-graph-pan: event listeners -67
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 10ms
large-graph-zoom: style recalc duration 9ms
large-graph-zoom: layout count 66
large-graph-zoom: style recalc count 72
large-graph-zoom: task duration 1273ms
large-graph-zoom: script duration 525ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 62.3 MB
large-graph-zoom: DOM nodes -105
large-graph-zoom: event listeners -35
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 1ms
legacy-node-drag: style recalc duration 4ms
legacy-node-drag: layout count 6
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 1290ms
legacy-node-drag: script duration 607ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 69.7 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 182
minimap-geometry-cadence: avg frame time 17ms
minimap-geometry-cadence: p95 frame time 17ms
minimap-geometry-cadence: layout duration 1ms
minimap-geometry-cadence: style recalc duration 1ms
minimap-geometry-cadence: layout count 8
minimap-geometry-cadence: style recalc count 8
minimap-geometry-cadence: task duration 593ms
minimap-geometry-cadence: script duration 257ms
minimap-geometry-cadence: TBT 0ms
minimap-geometry-cadence: heap used 72.9 MB
minimap-geometry-cadence: DOM nodes -257
minimap-geometry-cadence: event listeners -69
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 1ms
minimap-idle: style recalc duration 1ms
minimap-idle: layout count 8
minimap-idle: style recalc count 8
minimap-idle: task duration 465ms
minimap-idle: script duration 26ms
minimap-idle: TBT 0ms
minimap-idle: heap used 80.7 MB
minimap-idle: DOM nodes -257
minimap-idle: event listeners -69
minimap-progress-execution-cadence: avg frame time 17ms
minimap-progress-execution-cadence: p95 frame time 17ms
minimap-progress-execution-cadence: layout duration 1ms
minimap-progress-execution-cadence: style recalc duration 11ms
minimap-progress-execution-cadence: layout count 9
minimap-progress-execution-cadence: style recalc count 28
minimap-progress-execution-cadence: task duration 474ms
minimap-progress-execution-cadence: script duration 130ms
minimap-progress-execution-cadence: TBT 0ms
minimap-progress-execution-cadence: heap used 65.0 MB
minimap-progress-execution-cadence: DOM nodes -255
minimap-progress-execution-cadence: event listeners -69
minimap-topology-cadence: avg frame time 17ms
minimap-topology-cadence: p95 frame time 17ms
minimap-topology-cadence: layout duration 1ms
minimap-topology-cadence: style recalc duration 1ms
minimap-topology-cadence: layout count 9
minimap-topology-cadence: style recalc count 9
minimap-topology-cadence: task duration 693ms
minimap-topology-cadence: script duration 273ms
minimap-topology-cadence: TBT 0ms
minimap-topology-cadence: heap used 68.4 MB
minimap-topology-cadence: DOM nodes -257
minimap-topology-cadence: event listeners -69
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 2ms
subgraph-dom-widget-clipping: style recalc duration 4ms
subgraph-dom-widget-clipping: layout count 10
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 313ms
subgraph-dom-widget-clipping: script duration 103ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 60.5 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 2ms
subgraph-idle: style recalc duration 2ms
subgraph-idle: layout count 11
subgraph-idle: style recalc count 11
subgraph-idle: task duration 394ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 65.2 MB
subgraph-idle: DOM nodes -183
subgraph-idle: event listeners -116
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 2ms
subgraph-mouse-sweep: style recalc duration 11ms
subgraph-mouse-sweep: layout count 10
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 641ms
subgraph-mouse-sweep: script duration 80ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 65.1 MB
subgraph-mouse-sweep: DOM nodes -88
subgraph-mouse-sweep: event listeners -54
subgraph-transition-enter: avg frame time 21ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 10ms
subgraph-transition-enter: style recalc duration 16ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 708ms
subgraph-transition-enter: script duration 21ms
subgraph-transition-enter: TBT 131ms
subgraph-transition-enter: heap used 108.3 MB
subgraph-transition-enter: DOM nodes 16030
subgraph-transition-enter: event listeners 3246
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 1ms
viewport-pan-sweep: style recalc duration 26ms
viewport-pan-sweep: layout count 9
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4194ms
viewport-pan-sweep: script duration 1858ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 75.7 MB
viewport-pan-sweep: DOM nodes -257
viewport-pan-sweep: event listeners -67
vue-large-graph-idle: avg frame time 26ms
vue-large-graph-idle: p95 frame time 42ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 14323ms
vue-large-graph-idle: script duration 190ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 275.4 MB
vue-large-graph-idle: DOM nodes -3343
vue-large-graph-idle: event listeners -653
vue-large-graph-pan: avg frame time 32ms
vue-large-graph-pan: p95 frame time 67ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 152
vue-large-graph-pan: task duration 17583ms
vue-large-graph-pan: script duration 712ms
vue-large-graph-pan: TBT 19ms
vue-large-graph-pan: heap used 254.5 MB
vue-large-graph-pan: DOM nodes -3343
vue-large-graph-pan: event listeners -651
vue-node-resize-workload: avg frame time 31ms
vue-node-resize-workload: p95 frame time 67ms
vue-node-resize-workload: layout duration 22ms
vue-node-resize-workload: style recalc duration 44ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5279ms
vue-node-resize-workload: script duration 78ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 261.1 MB
vue-node-resize-workload: DOM nodes -1825
vue-node-resize-workload: event listeners -330
vue-zoom-out-idle: avg frame time 24ms
vue-zoom-out-idle: p95 frame time 50ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 6721ms
vue-zoom-out-idle: script duration 80ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 243.2 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 5ms
workflow-execution: layout count 7
workflow-execution: style recalc count 9
workflow-execution: task duration 60ms
workflow-execution: script duration 5ms
workflow-execution: TBT 0ms
workflow-execution: heap used 67.6 MB
workflow-execution: DOM nodes 100
workflow-execution: event listeners 3
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 12ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 244ms
agent-composer-empty-conversation-typing: script duration 107ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 45.3 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 296
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 12ms
agent-composer-long-conversation-typing: style recalc duration 1ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 268ms
agent-composer-long-conversation-typing: script duration 97ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 87.7 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 292
Raw data
{
  "timestamp": "2026-11-03T00:04:44.058Z",
  "gitSha": "0f19936b5cdd0cf5c4592ea3dcc32cbcb4f23c64",
  "branch": "bl/cloud-1.59-missing-node-deployment-offer",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2009.7039999999993,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 1.5839999999999999,
      "layouts": 9,
      "layoutDurationMs": 1.6489999999999998,
      "taskDurationMs": 363.75,
      "heapDeltaBytes": 24589864,
      "heapUsedBytes": 85003132,
      "domNodes": 0,
      "jsHeapTotalBytes": 2621440,
      "scriptDurationMs": 8.173,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2010.1509999999507,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 1.6349999999999998,
      "layouts": 10,
      "layoutDurationMs": 1.8470000000000002,
      "taskDurationMs": 357.61299999999994,
      "heapDeltaBytes": 1892980,
      "heapUsedBytes": 63026960,
      "domNodes": 0,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 7.0630000000000015,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1692.3469999999838,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 10.077,
      "layouts": 10,
      "layoutDurationMs": 1.857,
      "taskDurationMs": 625.929,
      "heapDeltaBytes": 21843748,
      "heapUsedBytes": 83059328,
      "domNodes": 0,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 107.613,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664705882352937,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1691.8019999999956,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 9.37,
      "layouts": 9,
      "layoutDurationMs": 1.8810000000000002,
      "taskDurationMs": 627.2099999999999,
      "heapDeltaBytes": 17521996,
      "heapUsedBytes": 78769748,
      "domNodes": 0,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 105.80499999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664705882352937,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1726.191999999969,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 4.106999999999999,
      "layouts": 12,
      "layoutDurationMs": 2.4330000000000003,
      "taskDurationMs": 293.234,
      "heapDeltaBytes": 1043692,
      "heapUsedBytes": 71052840,
      "domNodes": 56,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 9.807,
      "eventListeners": 43,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6673076923077,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1710.4810000000157,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 3.786,
      "layouts": 12,
      "layoutDurationMs": 2.5640000000000005,
      "taskDurationMs": 276.34000000000003,
      "heapDeltaBytes": 915800,
      "heapUsedBytes": 70178576,
      "domNodes": 56,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 8.234,
      "eventListeners": 43,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666990291262138,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 535.9559999999988,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 2.1590000000000003,
      "layouts": 11,
      "layoutDurationMs": 2.0170000000000003,
      "taskDurationMs": 361.613,
      "heapDeltaBytes": 327480,
      "heapUsedBytes": 70578240,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 124.27000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66562499999999,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 559.8870000000034,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 2.049,
      "layouts": 10,
      "layoutDurationMs": 1.8800000000000001,
      "taskDurationMs": 332.199,
      "heapDeltaBytes": 3863352,
      "heapUsedBytes": 64931800,
      "domNodes": 0,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 108.879,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1006.4270000000022,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 636.2509999999999,
      "heapDeltaBytes": -11886496,
      "heapUsedBytes": 75949464,
      "domNodes": -191,
      "jsHeapTotalBytes": 21504000,
      "scriptDurationMs": 39.757999999999996,
      "eventListeners": -107,
      "totalBlockingTimeMs": 334,
      "frameDurationMs": 27.775000000000002,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 973.1580000000122,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 625.2280000000001,
      "heapDeltaBytes": -12800832,
      "heapUsedBytes": 75642564,
      "domNodes": -191,
      "jsHeapTotalBytes": 18882560,
      "scriptDurationMs": 36.409000000000006,
      "eventListeners": -107,
      "totalBlockingTimeMs": 333,
      "frameDurationMs": 28.094285714285707,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 734.0779999999825,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 315.4579999999996,
      "heapDeltaBytes": -2369928,
      "heapUsedBytes": 71232116,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 93.453,
      "eventListeners": 0,
      "totalBlockingTimeMs": 102,
      "frameDurationMs": 21.567647058823507,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 748.6329999999839,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 359.5389999999998,
      "heapDeltaBytes": -29127576,
      "heapUsedBytes": 67728636,
      "domNodes": -191,
      "jsHeapTotalBytes": 4325376,
      "scriptDurationMs": 95.747,
      "eventListeners": -107,
      "totalBlockingTimeMs": 104,
      "frameDurationMs": 21.428571428571427,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6630.677999999989,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.17400000000000054,
      "layouts": 1,
      "layoutDurationMs": 0.1250000000000001,
      "taskDurationMs": 5759.478999999999,
      "heapDeltaBytes": 5067112,
      "heapUsedBytes": 83931252,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 4333.419,
      "eventListeners": 0,
      "totalBlockingTimeMs": 6,
      "frameDurationMs": 23.111846689895472,
      "p95FrameDurationMs": 33.40000000000009
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6446.456000000012,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 0.6680000000000001,
      "layouts": 4,
      "layoutDurationMs": 0.6999999999999996,
      "taskDurationMs": 5486.312000000001,
      "heapDeltaBytes": 64124700,
      "heapUsedBytes": 135965672,
      "domNodes": -257,
      "jsHeapTotalBytes": 58322944,
      "scriptDurationMs": 4127.378000000001,
      "eventListeners": -69,
      "totalBlockingTimeMs": 24,
      "frameDurationMs": 21.30165562913907,
      "p95FrameDurationMs": 33.40000000000009
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6399.171999999993,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.5190000000000003,
      "layouts": 3,
      "layoutDurationMs": 0.49700000000000005,
      "taskDurationMs": 5532.865,
      "heapDeltaBytes": 52229940,
      "heapUsedBytes": 127050524,
      "domNodes": -257,
      "jsHeapTotalBytes": 59895808,
      "scriptDurationMs": 4138.548999999999,
      "eventListeners": -69,
      "totalBlockingTimeMs": 18,
      "frameDurationMs": 22.068275862068962,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6544.723000000033,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.4580000000000001,
      "layouts": 2,
      "layoutDurationMs": 0.35899999999999993,
      "taskDurationMs": 5817.0650000000005,
      "heapDeltaBytes": 71099788,
      "heapUsedBytes": 145526684,
      "domNodes": -257,
      "jsHeapTotalBytes": 62779392,
      "scriptDurationMs": 4334.86,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 24.43917910447761,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "large-combo-open",
      "durationMs": 179.0510000000154,
      "styleRecalcs": 22,
      "styleRecalcDurationMs": 10.725999999999999,
      "layouts": 11,
      "layoutDurationMs": 2.5399999999999996,
      "taskDurationMs": 147.15900000000002,
      "heapDeltaBytes": -394920,
      "heapUsedBytes": 69850444,
      "domNodes": -2315,
      "jsHeapTotalBytes": -524288,
      "scriptDurationMs": 7.871999999999999,
      "eventListeners": -574,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 23.81428571428569,
      "p95FrameDurationMs": 66.59999999999991
    },
    {
      "name": "large-combo-open",
      "durationMs": 205.21099999996295,
      "styleRecalcs": 23,
      "styleRecalcDurationMs": 10.292,
      "layouts": 12,
      "layoutDurationMs": 2.5889999999999995,
      "taskDurationMs": 181.031,
      "heapDeltaBytes": -16821732,
      "heapUsedBytes": 66517144,
      "domNodes": -2315,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 8.718999999999998,
      "eventListeners": -574,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 22.22222222222222,
      "p95FrameDurationMs": 66.70000000000027
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2026.6210000000058,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 1.7590000000000001,
      "layouts": 9,
      "layoutDurationMs": 1.7570000000000001,
      "taskDurationMs": 469.775,
      "heapDeltaBytes": -19329796,
      "heapUsedBytes": 63526320,
      "domNodes": -257,
      "jsHeapTotalBytes": 4321280,
      "scriptDurationMs": 27.276000000000003,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2037.8729999999905,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 1.4369999999999998,
      "layouts": 8,
      "layoutDurationMs": 1.37,
      "taskDurationMs": 425.404,
      "heapDeltaBytes": -4209108,
      "heapUsedBytes": 69460864,
      "domNodes": -257,
      "jsHeapTotalBytes": -659456,
      "scriptDurationMs": 30.037,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2134.6810000000005,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 9.084,
      "layouts": 8,
      "layoutDurationMs": 4.5009999999999994,
      "taskDurationMs": 1234.899,
      "heapDeltaBytes": -18381984,
      "heapUsedBytes": 62816640,
      "domNodes": -257,
      "jsHeapTotalBytes": 6680576,
      "scriptDurationMs": 581.7410000000001,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66640625,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2162.025999999969,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 5.491999999999999,
      "layouts": 8,
      "layoutDurationMs": 1.236,
      "taskDurationMs": 1128.3729999999998,
      "heapDeltaBytes": -12410512,
      "heapUsedBytes": 61772312,
      "domNodes": -257,
      "jsHeapTotalBytes": 4583424,
      "scriptDurationMs": 509.94399999999996,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665891472868214,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3210.791,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 10.427999999999999,
      "layouts": 68,
      "layoutDurationMs": 11.065,
      "taskDurationMs": 1330.156,
      "heapDeltaBytes": -8731484,
      "heapUsedBytes": 68860700,
      "domNodes": -233,
      "jsHeapTotalBytes": 4059136,
      "scriptDurationMs": 554.763,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665625000000002,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3118.0820000000153,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 7.460000000000001,
      "layouts": 64,
      "layoutDurationMs": 8.463999999999999,
      "taskDurationMs": 1215.505,
      "heapDeltaBytes": -15036824,
      "heapUsedBytes": 61763780,
      "domNodes": 24,
      "jsHeapTotalBytes": 3272704,
      "scriptDurationMs": 496.144,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665775401069517,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2224.793000000005,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 4.05,
      "layouts": 4,
      "layoutDurationMs": 0.7200000000000002,
      "taskDurationMs": 1337.1879999999999,
      "heapDeltaBytes": 4732356,
      "heapUsedBytes": 66690696,
      "domNodes": 0,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 634.4680000000001,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.792424242424243,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2133.9289999999664,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 4.321999999999999,
      "layouts": 7,
      "layoutDurationMs": 1.0499999999999998,
      "taskDurationMs": 1242.1229999999998,
      "heapDeltaBytes": 6775204,
      "heapUsedBytes": 79543012,
      "domNodes": 0,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 579.0139999999999,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666141732283464,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-geometry-cadence",
      "durationMs": 2962.319999999977,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 1.496,
      "layouts": 8,
      "layoutDurationMs": 1.3999999999999997,
      "taskDurationMs": 651.3530000000001,
      "heapDeltaBytes": -2542628,
      "heapUsedBytes": 72698220,
      "domNodes": -257,
      "jsHeapTotalBytes": 3534848,
      "scriptDurationMs": 281.628,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665730337078653,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-geometry-cadence",
      "durationMs": 2880.6860000000256,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 1.1549999999999998,
      "layouts": 8,
      "layoutDurationMs": 1.1600000000000001,
      "taskDurationMs": 534.2370000000001,
      "heapDeltaBytes": 27416,
      "heapUsedBytes": 80112680,
      "domNodes": -257,
      "jsHeapTotalBytes": 4059136,
      "scriptDurationMs": 233.06500000000003,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665317919075143,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2035.8499999999822,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 1.3239999999999996,
      "layouts": 7,
      "layoutDurationMs": 1.338,
      "taskDurationMs": 457.8740000000001,
      "heapDeltaBytes": 8152992,
      "heapUsedBytes": 83699872,
      "domNodes": -257,
      "jsHeapTotalBytes": 3534848,
      "scriptDurationMs": 25.977999999999994,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2020.2000000000453,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 1.6749999999999994,
      "layouts": 9,
      "layoutDurationMs": 1.476,
      "taskDurationMs": 472.6050000000001,
      "heapDeltaBytes": 9408412,
      "heapUsedBytes": 85491644,
      "domNodes": -257,
      "jsHeapTotalBytes": 3796992,
      "scriptDurationMs": 25.943,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666942148760327,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-progress-execution-cadence",
      "durationMs": 2679.3089999999893,
      "styleRecalcs": 28,
      "styleRecalcDurationMs": 10.72,
      "layouts": 8,
      "layoutDurationMs": 1.4649999999999999,
      "taskDurationMs": 485.61299999999994,
      "heapDeltaBytes": -9660796,
      "heapUsedBytes": 68127308,
      "domNodes": -255,
      "jsHeapTotalBytes": 3534848,
      "scriptDurationMs": 133.66400000000002,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66583850931677,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-progress-execution-cadence",
      "durationMs": 2680.3959999999734,
      "styleRecalcs": 28,
      "styleRecalcDurationMs": 10.738,
      "layouts": 9,
      "layoutDurationMs": 1.5220000000000002,
      "taskDurationMs": 461.94,
      "heapDeltaBytes": -8665756,
      "heapUsedBytes": 68150220,
      "domNodes": -255,
      "jsHeapTotalBytes": 3534848,
      "scriptDurationMs": 126.00599999999999,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666459627329193,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "minimap-topology-cadence",
      "durationMs": 3106.5590000000043,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 1.3149999999999993,
      "layouts": 8,
      "layoutDurationMs": 1.3129999999999997,
      "taskDurationMs": 742.5830000000001,
      "heapDeltaBytes": -23263552,
      "heapUsedBytes": 70230936,
      "domNodes": -257,
      "jsHeapTotalBytes": 5931008,
      "scriptDurationMs": 293.80699999999996,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66577540106952,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-topology-cadence",
      "durationMs": 2968.859000000009,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 1.2569999999999995,
      "layouts": 9,
      "layoutDurationMs": 1.309,
      "taskDurationMs": 643.894,
      "heapDeltaBytes": -12139472,
      "heapUsedBytes": 73256432,
      "domNodes": -257,
      "jsHeapTotalBytes": 6156288,
      "scriptDurationMs": 252.87599999999998,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666292134831462,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 497.542999999979,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 4.219,
      "layouts": 9,
      "layoutDurationMs": 1.8999999999999997,
      "taskDurationMs": 312.12,
      "heapDeltaBytes": 1109384,
      "heapUsedBytes": 64057568,
      "domNodes": 0,
      "jsHeapTotalBytes": 9961472,
      "scriptDurationMs": 104.298,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 513.8489999999933,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 3.6840000000000006,
      "layouts": 10,
      "layoutDurationMs": 1.8219999999999998,
      "taskDurationMs": 313.42199999999997,
      "heapDeltaBytes": -79932,
      "heapUsedBytes": 62802856,
      "domNodes": 0,
      "jsHeapTotalBytes": 8912896,
      "scriptDurationMs": 101.10999999999999,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66774193548388,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2009.3820000000164,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 2.0990000000000006,
      "layouts": 11,
      "layoutDurationMs": 2.2120000000000006,
      "taskDurationMs": 404.815,
      "heapDeltaBytes": -7701948,
      "heapUsedBytes": 64426992,
      "domNodes": -183,
      "jsHeapTotalBytes": 3145728,
      "scriptDurationMs": 6.874000000000001,
      "eventListeners": -116,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2037.0620000000486,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 2.3100000000000005,
      "layouts": 10,
      "layoutDurationMs": 2.221,
      "taskDurationMs": 383.25299999999993,
      "heapDeltaBytes": 12126628,
      "heapUsedBytes": 72377272,
      "domNodes": -183,
      "jsHeapTotalBytes": 2359296,
      "scriptDurationMs": 6.885000000000001,
      "eventListeners": -116,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665573770491804,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1693.951999999996,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 11.914000000000001,
      "layouts": 10,
      "layoutDurationMs": 2.178,
      "taskDurationMs": 711.791,
      "heapDeltaBytes": -8949840,
      "heapUsedBytes": 60999724,
      "domNodes": -175,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 87.617,
      "eventListeners": -114,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1678.03600000002,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 10.014,
      "layouts": 10,
      "layoutDurationMs": 1.6689999999999998,
      "taskDurationMs": 571.145,
      "heapDeltaBytes": 13844824,
      "heapUsedBytes": 75518356,
      "domNodes": 0,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 72.205,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666336633663366,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 882.6090000000022,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 15.927999999999997,
      "layouts": 5,
      "layoutDurationMs": 9.592,
      "taskDurationMs": 707.6640000000001,
      "heapDeltaBytes": 38359784,
      "heapUsedBytes": 113552328,
      "domNodes": 16030,
      "jsHeapTotalBytes": 17178624,
      "scriptDurationMs": 21.055000000000003,
      "eventListeners": 3246,
      "totalBlockingTimeMs": 131,
      "frameDurationMs": 21.033333333333346,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8178.819000000004,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 29.198999999999998,
      "layouts": 9,
      "layoutDurationMs": 1.555,
      "taskDurationMs": 4304.273999999999,
      "heapDeltaBytes": 12553948,
      "heapUsedBytes": 85344416,
      "domNodes": -257,
      "jsHeapTotalBytes": 4808704,
      "scriptDurationMs": 1914.381,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66598778004073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8143.353999999988,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 22.724999999999998,
      "layouts": 9,
      "layoutDurationMs": 1.2570000000000003,
      "taskDurationMs": 4083.926999999999,
      "heapDeltaBytes": -1394864,
      "heapUsedBytes": 73357884,
      "domNodes": -257,
      "jsHeapTotalBytes": 4808704,
      "scriptDurationMs": 1802.5720000000001,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666188524590165,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16221.233999999982,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15299.238000000001,
      "heapDeltaBytes": 15363632,
      "heapUsedBytes": 298364216,
      "domNodes": -3343,
      "jsHeapTotalBytes": 37740544,
      "scriptDurationMs": 216.152,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 27.843174061433444,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14437.020000000019,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13346.571000000002,
      "heapDeltaBytes": 6488256,
      "heapUsedBytes": 279141848,
      "domNodes": -3343,
      "jsHeapTotalBytes": 13094912,
      "scriptDurationMs": 163.301,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 24.014642262895173,
      "p95FrameDurationMs": 33.400000000001455
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18215.282000000003,
      "styleRecalcs": 151,
      "styleRecalcDurationMs": 17.82700000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17759.03,
      "heapDeltaBytes": -9375276,
      "heapUsedBytes": 272769400,
      "domNodes": -3343,
      "jsHeapTotalBytes": 15192064,
      "scriptDurationMs": 757.63,
      "eventListeners": -651,
      "totalBlockingTimeMs": 37,
      "frameDurationMs": 32.76258992805755,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17891.698000000077,
      "styleRecalcs": 152,
      "styleRecalcDurationMs": 16.49700000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17406.701999999997,
      "heapDeltaBytes": -16461944,
      "heapUsedBytes": 261060204,
      "domNodes": -3343,
      "jsHeapTotalBytes": 17293312,
      "scriptDurationMs": 666.834,
      "eventListeners": -651,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 31.962857142857143,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5682.566000000008,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 46.09300000000001,
      "layouts": 20,
      "layoutDurationMs": 23.461999999999996,
      "taskDurationMs": 5533.831,
      "heapDeltaBytes": -25549072,
      "heapUsedBytes": 270451604,
      "domNodes": -3343,
      "jsHeapTotalBytes": 34590720,
      "scriptDurationMs": 81.041,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 32.47485714285715,
      "p95FrameDurationMs": 66.69999999999891
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5144.919999999956,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 41.562000000000005,
      "layouts": 20,
      "layoutDurationMs": 20.311999999999998,
      "taskDurationMs": 5024.307,
      "heapDeltaBytes": 3366784,
      "heapUsedBytes": 277027168,
      "domNodes": -307,
      "jsHeapTotalBytes": 18862080,
      "scriptDurationMs": 74.23,
      "eventListeners": -7,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 30.472189349112426,
      "p95FrameDurationMs": 66.59999999999945
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7083.768999999961,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6658.896000000001,
      "heapDeltaBytes": -6048552,
      "heapUsedBytes": 259270908,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 80.59999999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 23.712751677852353,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7290.783999999917,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6783.9850000000015,
      "heapDeltaBytes": 75764,
      "heapUsedBytes": 250701352,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 78.60400000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 24.772108843537413,
      "p95FrameDurationMs": 49.900000000001455
    },
    {
      "name": "workflow-execution",
      "durationMs": 93.6240000000339,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 5.208,
      "layouts": 7,
      "layoutDurationMs": 2.9419999999999997,
      "taskDurationMs": 67.851,
      "heapDeltaBytes": 4771216,
      "heapUsedBytes": 69513024,
      "domNodes": 101,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.183000000000001,
      "eventListeners": 3,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.650000000000016,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 94.55100000002403,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5,
      "layouts": 7,
      "layoutDurationMs": 1.37,
      "taskDurationMs": 53.017999999999994,
      "heapDeltaBytes": 4616300,
      "heapUsedBytes": 72289016,
      "domNodes": 98,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.343,
      "eventListeners": 3,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 275.94699999997374,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.759,
      "layouts": 76,
      "layoutDurationMs": 12.79,
      "taskDurationMs": 244.34900000000002,
      "heapDeltaBytes": 10331640,
      "heapUsedBytes": 47402660,
      "domNodes": 4,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 107.84299999999999,
      "eventListeners": 300,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66470588235295,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 283.6049999999659,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.6769999999999999,
      "layouts": 76,
      "layoutDurationMs": 11.673,
      "taskDurationMs": 242.985,
      "heapDeltaBytes": 10484404,
      "heapUsedBytes": 47536272,
      "domNodes": 4,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 106.225,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66470588235295,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 324.9479999999494,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.601,
      "layouts": 76,
      "layoutDurationMs": 12.158999999999999,
      "taskDurationMs": 277.835,
      "heapDeltaBytes": -1046344,
      "heapUsedBytes": 91985604,
      "domNodes": 4,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 101.717,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66500000000001,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 295.56400000001304,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.397,
      "layouts": 76,
      "layoutDurationMs": 11.758,
      "taskDurationMs": 257.279,
      "heapDeltaBytes": -2028408,
      "heapUsedBytes": 91876556,
      "domNodes": 4,
      "jsHeapTotalBytes": 790528,
      "scriptDurationMs": 92.303,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66842105263162,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage: ⚠️ Coverage collection failed — check the CI workflow logs

🎭 Playwright: ✅ 3126 passed, 0 failed · 6 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2321 / ❌ 0 / ⚠️ 4 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 774 / ❌ 0 / ⚠️ 2 / ⏭️ 0)
  • desktop: View Report (✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 11/02/2026, 11:57:01 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since b7e04ade365b7cf3c05e6e048f91291d32ce477e

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (266)

  • workspace path matches no source files: src/platform/workspace/fixtures/**. Remove or update it in docs/architecture/domains/records/workspace.domain.json.
  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/Popover.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupEnforcementBoundary.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/syncPromotedComboHostOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/legacyUI/attachLegacyUI.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/agentPanel.historyIdentity.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cloudBadges.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/dynamicPrompts.serializeValue.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/electronAdapter.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/index.cloud.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/index.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/findNumericWidget.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dLazy.retry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dSettings.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dWidgets.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dWidgets.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/slotDefaults.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchPointerGuards.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/ContextMenu.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/LGraphCanvas.startRendering.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 216 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4e206d897a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

const runIt = toValue(deploymentsThatRunIt)
return (
pickStore.deployments.length === 0 ||
(runIt !== null && runIt.length === 0)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep unknown compatibility distinct from incompatible deployments

When the compatibility response marks a deployment as unknown: true (or omits a listed deployment), useDeploymentCompatibility().deploymentsThatRunIt excludes it and can return an empty array. This condition then shows “Run it on a custom deployment” even though an existing deployment may already support the workflow, directing users toward unnecessary setup when ingest could not complete the check. The existing useMissingNodeDeploymentOffer explicitly distinguishes this case with eachCheckedAndLacking(); preserve that distinction here and offer creation only after every existing deployment is confirmed incompatible.

Useful? React with 👍 / 👎.

@datadog-official

datadog-official Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Pipelines

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 5 Pipeline jobs failed

CI: Billing Web E2E | billing-web-e2e-gate

View in Datadog · View in GitHub Actions

CI: Billing Web Unit | billing-web-unit-gate

View in Datadog · View in GitHub Actions

CI: Tests E2E | e2e-status

View in Datadog · View in GitHub Actions

View all 5 failed jobs.

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 432df64 | Docs | View more details | Give us feedback!

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Oct 31, 2026

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport approval: LGTM.

christian-byrne added a commit that referenced this pull request Nov 1, 2026
…59.3 bump

`lint-pr / lint` fails on this carrier with

    'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization
    message resources  @intlify/vue-i18n/no-missing-keys

in `src/components/graph/selectionToolbox/Load3DViewerButton.vue`, which
fails `preflight` and so reports `lint-and-format`, `test` and `e2e-status`
as failures without any of them running.

The failure is inherited, not introduced here: the component, the catalog and
the ESLint config are byte-identical to `cloud/1.59`, and the sibling carrier
#22538 fails on the same two lines. The key was restored on `cloud/1.59` by
#22130 and the 1.59.3 version bump (#22137) regenerated the locale JSON and
dropped it again.

Restores the same three lines, so `src/locales/en/commands.json` is now
byte-identical (blob 412dbd0) to the tree #22130 merged. No product
behavior changes.
benceruleanlu pushed a commit that referenced this pull request Nov 2, 2026
…59.3 bump

`lint-pr / lint` fails on this carrier with

    'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization
    message resources  @intlify/vue-i18n/no-missing-keys

in `src/components/graph/selectionToolbox/Load3DViewerButton.vue`, which
fails `preflight` and so reports `lint-and-format`, `test` and `e2e-status`
as failures without any of them running.

The failure is inherited, not introduced here: the component, the catalog and
the ESLint config are byte-identical to `cloud/1.59`, and the sibling carrier
#22538 fails on the same two lines. The key was restored on `cloud/1.59` by
#22130 and the 1.59.3 version bump (#22137) regenerated the locale JSON and
dropped it again.

Restores the same three lines, so `src/locales/en/commands.json` is now
byte-identical (blob 412dbd0) to the tree #22130 merged. No product
behavior changes.

(cherry picked from commit a358582)
benceruleanlu pushed a commit that referenced this pull request Nov 2, 2026
…59.3 bump

`lint-pr / lint` fails on this carrier with

    'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization
    message resources  @intlify/vue-i18n/no-missing-keys

in `src/components/graph/selectionToolbox/Load3DViewerButton.vue`, which
fails `preflight` and so reports `lint-and-format`, `test` and `e2e-status`
as failures without any of them running.

The failure is inherited, not introduced here: the component, the catalog and
the ESLint config are byte-identical to `cloud/1.59`, and the sibling carrier
#22538 fails on the same two lines. The key was restored on `cloud/1.59` by
#22130 and the 1.59.3 version bump (#22137) regenerated the locale JSON and
dropped it again.

Restores the same three lines, so `src/locales/en/commands.json` is now
byte-identical (blob 412dbd0) to the tree #22130 merged. No product
behavior changes.

(cherry picked from commit a358582)
benceruleanlu pushed a commit that referenced this pull request Nov 2, 2026
…59.3 bump

`lint-pr / lint` fails on this carrier with

    'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization
    message resources  @intlify/vue-i18n/no-missing-keys

in `src/components/graph/selectionToolbox/Load3DViewerButton.vue`, which
fails `preflight` and so reports `lint-and-format`, `test` and `e2e-status`
as failures without any of them running.

The failure is inherited, not introduced here: the component, the catalog and
the ESLint config are byte-identical to `cloud/1.59`, and the sibling carrier
#22538 fails on the same two lines. The key was restored on `cloud/1.59` by
#22130 and the 1.59.3 version bump (#22137) regenerated the locale JSON and
dropped it again.

Restores the same three lines, so `src/locales/en/commands.json` is now
byte-identical (blob 412dbd0) to the tree #22130 merged. No product
behavior changes.

(cherry picked from commit a358582)
benceruleanlu pushed a commit that referenced this pull request Nov 2, 2026
…59.3 bump

`lint-pr / lint` fails on this carrier with

    'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization
    message resources  @intlify/vue-i18n/no-missing-keys

in `src/components/graph/selectionToolbox/Load3DViewerButton.vue`, which
fails `preflight` and so reports `lint-and-format`, `test` and `e2e-status`
as failures without any of them running.

The failure is inherited, not introduced here: the component, the catalog and
the ESLint config are byte-identical to `cloud/1.59`, and the sibling carrier
#22538 fails on the same two lines. The key was restored on `cloud/1.59` by
#22130 and the 1.59.3 version bump (#22137) regenerated the locale JSON and
dropped it again.

Restores the same three lines, so `src/locales/en/commands.json` is now
byte-identical (blob 412dbd0) to the tree #22130 merged. No product
behavior changes.

(cherry picked from commit a358582)
benceruleanlu pushed a commit that referenced this pull request Nov 2, 2026
…59.3 bump

`lint-pr / lint` fails on this carrier with

    'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization
    message resources  @intlify/vue-i18n/no-missing-keys

in `src/components/graph/selectionToolbox/Load3DViewerButton.vue`, which
fails `preflight` and so reports `lint-and-format`, `test` and `e2e-status`
as failures without any of them running.

The failure is inherited, not introduced here: the component, the catalog and
the ESLint config are byte-identical to `cloud/1.59`, and the sibling carrier
#22538 fails on the same two lines. The key was restored on `cloud/1.59` by
#22130 and the 1.59.3 version bump (#22137) regenerated the locale JSON and
dropped it again.

Restores the same three lines, so `src/locales/en/commands.json` is now
byte-identical (blob 412dbd0) to the tree #22130 merged. No product
behavior changes.

(cherry picked from commit a358582)
benceruleanlu pushed a commit that referenced this pull request Nov 2, 2026
…59.3 bump

`lint-pr / lint` fails on this carrier with

    'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization
    message resources  @intlify/vue-i18n/no-missing-keys

in `src/components/graph/selectionToolbox/Load3DViewerButton.vue`, which
fails `preflight` and so reports `lint-and-format`, `test` and `e2e-status`
as failures without any of them running.

The failure is inherited, not introduced here: the component, the catalog and
the ESLint config are byte-identical to `cloud/1.59`, and the sibling carrier
#22538 fails on the same two lines. The key was restored on `cloud/1.59` by
#22130 and the 1.59.3 version bump (#22137) regenerated the locale JSON and
dropped it again.

Restores the same three lines, so `src/locales/en/commands.json` is now
byte-identical (blob 412dbd0) to the tree #22130 merged. No product
behavior changes.

(cherry picked from commit a358582)
benceruleanlu pushed a commit that referenced this pull request Nov 2, 2026
…59.3 bump

`lint-pr / lint` fails on this carrier with

    'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization
    message resources  @intlify/vue-i18n/no-missing-keys

in `src/components/graph/selectionToolbox/Load3DViewerButton.vue`, which
fails `preflight` and so reports `lint-and-format`, `test` and `e2e-status`
as failures without any of them running.

The failure is inherited, not introduced here: the component, the catalog and
the ESLint config are byte-identical to `cloud/1.59`, and the sibling carrier
#22538 fails on the same two lines. The key was restored on `cloud/1.59` by
#22130 and the 1.59.3 version bump (#22137) regenerated the locale JSON and
dropped it again.

Restores the same three lines, so `src/locales/en/commands.json` is now
byte-identical (blob 412dbd0) to the tree #22130 merged. No product
behavior changes.

(cherry picked from commit a358582)
benceruleanlu pushed a commit that referenced this pull request Nov 2, 2026
…59.3 bump

`lint-pr / lint` fails on this carrier with

    'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization
    message resources  @intlify/vue-i18n/no-missing-keys

in `src/components/graph/selectionToolbox/Load3DViewerButton.vue`, which
fails `preflight` and so reports `lint-and-format`, `test` and `e2e-status`
as failures without any of them running.

The failure is inherited, not introduced here: the component, the catalog and
the ESLint config are byte-identical to `cloud/1.59`, and the sibling carrier
#22538 fails on the same two lines. The key was restored on `cloud/1.59` by
#22130 and the 1.59.3 version bump (#22137) regenerated the locale JSON and
dropped it again.

Restores the same three lines, so `src/locales/en/commands.json` is now
byte-identical (blob 412dbd0) to the tree #22130 merged. No product
behavior changes.

(cherry picked from commit a358582)
benceruleanlu pushed a commit that referenced this pull request Nov 2, 2026
…59.3 bump

`lint-pr / lint` fails on this carrier with

    'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization
    message resources  @intlify/vue-i18n/no-missing-keys

in `src/components/graph/selectionToolbox/Load3DViewerButton.vue`, which
fails `preflight` and so reports `lint-and-format`, `test` and `e2e-status`
as failures without any of them running.

The failure is inherited, not introduced here: the component, the catalog and
the ESLint config are byte-identical to `cloud/1.59`, and the sibling carrier
#22538 fails on the same two lines. The key was restored on `cloud/1.59` by
#22130 and the 1.59.3 version bump (#22137) regenerated the locale JSON and
dropped it again.

Restores the same three lines, so `src/locales/en/commands.json` is now
byte-identical (blob 412dbd0) to the tree #22130 merged. No product
behavior changes.

(cherry picked from commit a358582)
…om deployment (#21188)

Opening or dropping a workflow on Comfy Cloud with missing custom nodes
offers a custom deployment, listing missing packs, unknown nodes and
models. The offer provides the docs, an agent brief and Create on
Platform, and omits the video. It shows as a "Run it on a custom
deployment" row on the issues card, whose Set up button opens the
dialog, and as that dialog opening over the card by itself the first
time the page meets those missing nodes.

Stack: 3 of 4, after #21186 (merged); #21587 opens the dialog for
workspaces with deployments too, offering Switch to one that runs the
workflow. Board D2 of DES-1254.

The card stays as it is today underneath the dialog: View details, and
the Switch row when a workspace deployment already runs the workflow.
Closing the dialog lands on it, so this can merge without #21587.

The offer needs the deployments listing to have been served (the
Extensions pitch's rule), the session to run on Comfy Cloud rather than
a deployment, a missing custom node the editor found no replacement for
(not a legacy group node's wrapper, nor a core node newer than Comfy
Cloud's), and no deployment known to run the workflow:

- A workspace with no deployments gets the row at once, and the dialog
once the listing answers. The dialog waits at most 5 s for the listing,
then opens only if the card is still showing, the same workflow is in
front and the editor is not in App mode; otherwise it is not offered on
that open.
- A workspace with deployments gets the row only once the compatibility
check finds that none of them, nor Comfy Cloud, runs the workflow. While
the check runs, when it fails, or with its feature flag off, the card
shows as today. The dialog does not open by itself for these workspaces;

Local ComfyUI, deployment sessions, API-key sessions, accounts not
served the listing, and replaceable nodes see the card as today.
`builds_visible` is not part of the rule: it only reports whether
comfy-builder named the listing's rows.

Both agent briefs replace line breaks and backticks in names taken from
the workflow. They link a model only from a source the editor itself
downloads from, printed as the URL parser normalizes it, so a link
cannot carry extra words onto its line. Both tell the agent that the
editor cannot list the models missing custom nodes load.

- Workspace, workflow and errors-panel unit suites pass (173 files, 3433
tests), including the 5 s cap, a workflow that stops needing a
deployment during the wait, the card waiting for the check, and the
dialog opening once per set of missing nodes and only while its card is
up. Each new test fails when the rule it covers is removed.
- Pre-commit format, lint and typecheck, and pre-push dependency audit,
knip and Fallow pass.
- Browser verification is still pending; there is no Playwright case
yet.

---------

Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com>
(cherry picked from commit 49b6cc4)
@benceruleanlu
benceruleanlu removed this pull request from stack #22540 November 2, 2026 23:54
@benceruleanlu
benceruleanlu force-pushed the bl/cloud-1.59-missing-node-deployment-offer branch from c4d38cd to 432df64 Compare November 2, 2026 23:54
@codecov

codecov Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.67816% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/platform/workspace/missingForDeployment.ts 88.46% 3 Missing ⚠️
src/platform/workspace/deploymentBuildBrief.ts 92.00% 2 Missing ⚠️
src/platform/workspace/noticeMissingNodes.ts 90.00% 2 Missing ⚠️
...c/platform/workspace/openCustomDeploymentDialog.ts 88.88% 2 Missing ⚠️
...orkspace/composables/useCustomDeploymentOffered.ts 93.75% 1 Missing ⚠️
...orm/workspace/composables/waitForDeploymentPick.ts 83.33% 1 Missing ⚠️
@@                            Coverage Diff                             @@
##           bl/cloud-1.59-deployment-build-actions   #22538      +/-   ##
==========================================================================
+ Coverage                                   86.64%   87.27%   +0.62%     
==========================================================================
  Files                                        2682     3055     +373     
  Lines                                      139361   160245   +20884     
  Branches                                    42752    42798      +46     
==========================================================================
+ Hits                                       120750   139847   +19097     
- Misses                                      17791    19719    +1928     
+ Partials                                      820      679     -141     
Flag Coverage Δ
e2e 59.81% <15.05%> (?)
unit 86.65% <99.39%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/TopMenuSection.vue 91.19% <100.00%> (-0.17%) ⬇️
...s/rightSidePanel/errors/DeploymentBuildActions.vue 100.00% <ø> (ø)
...platform/workflow/core/services/workflowService.ts 95.80% <100.00%> (+5.74%) ⬆️
...orkflowErrors/missingModel/missingModelDownload.ts 91.30% <ø> (-3.00%) ⬇️
...m/workflowErrors/missingModel/modelUrlAllowlist.ts 100.00% <100.00%> (ø)
...latform/workspace/api/deploymentListingTimeouts.ts 100.00% <100.00%> (ø)
...form/workspace/components/CustomDeploymentCard.vue 97.43% <100.00%> (-2.57%) ⬇️
...pace/components/ErrorOverlayDeploymentOfferRow.vue 96.00% <100.00%> (-4.00%) ⬇️
...rkspace/components/WorkflowNeedsDeploymentCard.vue 100.00% <100.00%> (ø)
src/platform/workspace/customDeploymentBrief.ts 100.00% <100.00%> (ø)
... and 8 more

... and 1805 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benceruleanlu
benceruleanlu merged commit 91b10fa into cloud/1.59 Nov 3, 2026
126 of 165 checks passed
@benceruleanlu
benceruleanlu deleted the bl/cloud-1.59-missing-node-deployment-offer branch November 3, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants